Pau Espin Pedrol has submitted this change and it was merged.
Change subject: modem: Fix race condition when connect() is called more than
once
..
modem: Fix race condition when connect() is called more than once
An issue was
Patch Set 2: Code-Review+2
If the cancellable object remains valid and usable after calling cancel(), then
it should indeed remain. But if calling self.cancellable.cancel() somehow
invalidates that object / makes it not useful anymore, then please set it to
None whenever you cancel()ed, and
Patch Set 2:
(1 comment)
I guess we agree that removing that sleep() can be done more in the future and
doesn't belong to this patch.
https://gerrit.osmocom.org/#/c/3901/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 524:
Patch Set 2:
We can already grep osmo-msc stderr to assert no accept and one reject, without
adding external dependencies. But in general if we're adding pcap grepping
anyway, we might as well grep the pcap here, too.
--
To view, visit https://gerrit.osmocom.org/3901
To unsubscribe, visit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3901/1/suites/aoip_encryption/register_a5_0_authreq.py
File suites/aoip_encryption/register_a5_0_authreq.py:
Line 34: sleep(40) # TODO: read pcap or CTRL interface and look for Rejected?
(gsm_a.dtap.msg_mm_type == 0x04)
> in general, if
Patch Set 2: Code-Review-1
(3 comments)
(sorry, comments on old patch set, but still apply)
-1 for the NoneType / missing None, otherwise ok. The sleep can be replaced as
a separate issue, some time.
https://gerrit.osmocom.org/#/c/3901/1/src/osmo_gsm_tester/ofono_client.py
File
modem: Fix race condition when connect() is called more than once
An issue was spotted recently in tests run in production which call
modem.connect() twice, first time to check that we are unable to connect
with a wrong KI, then that we can connect with the correct KI.
As there's no current
Patch Set 1:
I'll test the patch tomorrow morning and then we can merge
--
To view, visit https://gerrit.osmocom.org/3901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4bb1c6b72c23cd860c33bee7851bca3d0ac0e1b
Gerrit-PatchSet: 1
Review at https://gerrit.osmocom.org/3901
modem: Fix race condition when connect() is called more than once
An issue was spotted recently in tests run in production which call
modem.connect() twice, first time to check that we are unable to connect
with a wrong KI, then that we can connect
