Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5881
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887ce0c15a831dffeb6251a975337b83942af566
Gerrit-PatchSet: 12
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: client: add an optional FSM interface
..
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#12).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an
Patch Set 11:
aside from the "DLCX from the cleanup function in case of erroneous shutdown"
it is fine.
--
To view, visit https://gerrit.osmocom.org/5881
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 9:
(1 comment)
https://gerrit.osmocom.org/#/c/5881/9/src/libosmo-mgcp-client/mgcp_client_fsm.c
File src/libosmo-mgcp-client/mgcp_client_fsm.c:
Line 443: static void fsm_cleanup_cb(struct osmo_fsm_inst *fi, enum
osmo_fsm_term_cause cause)
> It exits always through the cleanup_cb, I
Patch Set 10:
(8 comments)
> Waiting for feedback on dlcx in cleanup question, looks fine
> otgherwise
Hmm. I have answered. I wonder why gerrit did not flush the draft messages...
Hopefully it works this time.
Patch Set 10: Code-Review+1
Waiting for feedback on dlcx in cleanup question, looks fine otgherwise
--
To view, visit https://gerrit.osmocom.org/5881
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#10).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an
Patch Set 9: Code-Review-1
(9 comments)
https://gerrit.osmocom.org/#/c/5881/9/include/osmocom/mgcp_client/mgcp_client_fsm.h
File include/osmocom/mgcp_client/mgcp_client_fsm.h:
Line 11: struct mgcp_conn_info {
naming is not clear enough "conn_info" sounds like some generic information
about a
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#8).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an osmo-fsm.
- Add
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#5).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an osmo-fsm.
- Add
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#3).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an osmo-fsm.
- Add
Patch Set 2:
> I think you fogot some 'git add' commands...
Thanks, added it now.
--
To view, visit https://gerrit.osmocom.org/5881
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I887ce0c15a831dffeb6251a975337b83942af566
Review at https://gerrit.osmocom.org/5881
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an osmo-fsm.
- Add an FSM that permits comfortable handling of an MGCP
connection.
Change-Id:
14 matches
Mail list logo
