osmo-msc[master]: fix GSM-Milenage in presence of 2G keys

2017-12-18 Thread Neels Hofmeyr
Patch Set 4: this still needs https://gerrit.osmocom.org/5466 to compile -- To view, visit https://gerrit.osmocom.org/5470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04e405426c55a81341747a9b450a69188525d5c Gerrit-PatchSet: 4

osmo-msc[master]: fix GSM-Milenage in presence of 2G keys

2017-12-18 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04e405426c55a81341747a9b450a69188525d5c Gerrit-PatchSet: 4 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-msc[master]: fix GSM-Milenage in presence of 2G keys

2017-12-17 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5470 to look at the new patch set (#3). fix GSM-Milenage in presence of 2G keys In case of UMTS AKA, the Kc for ciphering must be derived from the 3G auth tokens. tuple->vec.kc was

[PATCH] osmo-msc[master]: fix GSM-Milenage in presence of 2G keys

2017-12-17 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5470 fix GSM-Milenage in presence of 2G keys In case of UMTS AKA, the Kc for ciphering must be derived from the 3G auth tokens. tuple->vec.kc was calculated from the GSM algorithm and is not necessarily a match for the UMTS AKA tokens. So far we were