Max has abandoned this change.
Change subject: Fix wrong encoding of LH bits
..
Abandoned
Superseded by "rewrite rest octets" patch series.
--
To view, visit https://gerrit.osmocom.org/5686
To unsubscribe, visit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5686/1/src/encoding.cpp
File src/encoding.cpp:
Line 83:*write_index += 2;
why +2? I don't get it. we are setting a single bit, aren't we?
--
To view, visit https://gerrit.osmocom.org/5686
To unsubscribe, visit
Patch Set 1:
The odd thing I don't understand yet is why we should replace H only in some
places while in others it seems to break egprs. Any ideas?
--
To view, visit https://gerrit.osmocom.org/5686
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Review at https://gerrit.osmocom.org/5686
Fix wrong encoding of LH bits
Introduce functions to set L/H bits using bitvec_set_bit() with proper
enum from libosmocore instead of bitvec_write_field() with hardcoded
numeric values. Adjust tests accordingly. While at it, clarify
spec-related
