Harald Welte has submitted this change and it was merged.
Change subject: Move paging generation into PDCH
..
Move paging generation into PDCH
Previously paging was prepared inside BTS function and than handed over
to PDCH
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6193
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I389fb16b6e54040770c21f88edbcb8e045636928
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/6193/2/src/bts.cpp
File src/bts.cpp:
Line 971: return false;
You could change the return type from bool to int and then return -ENOMEM here,
instead of encoding the knowledge that 'return false' implies ENOMEM in the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6193
to look at the new patch set (#2).
Move paging generation into PDCH
Previously paging was prepared inside BTS function and than handed over
to PDCH function. Move the actual
Review at https://gerrit.osmocom.org/6193
Move paging generation into PDCH
Previously paging was prepared inside BTS function and than handed over
to PDCH function. Move the actual preparation into PDCH to better
decouple PDCH from BTS.
Change-Id: I389fb16b6e54040770c21f88edbcb8e045636928
---
