Max has submitted this change and it was merged.
Change subject: Simplify TS alloc: adjust function signatures
..
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent forma
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3912
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I211b10b4da59c73d509b719346774515c761886a
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3912
to look at the new patch set (#7).
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent formatting
* constify functi
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3912
to look at the new patch set (#6).
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent formatting
* constify functi
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3912
to look at the new patch set (#4).
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent formatting
* constify functi
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3912
to look at the new patch set (#3).
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent formatting
* constify functi
Patch Set 2:
> Did we remove the 80 chars limit?
For several months already - see
https://lists.osmocom.org/pipermail/openbsc/2017-April/thread.html#10522
--
To view, visit https://gerrit.osmocom.org/3912
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
G
Patch Set 2:
(1 comment)
What tests are adjusted?
https://gerrit.osmocom.org/#/c/3912/2/src/gprs_rlcmac_ts_alloc.cpp
File src/gprs_rlcmac_ts_alloc.cpp:
Line 305: static void assign_uplink_tbf_usf(struct gprs_rlcmac_pdch *pdch,
struct gprs_rlcmac_ul_tbf *tbf, uint8_t tfi, int8_t usf)
Did we re
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3912
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I211b10b4da59c73d509b719346774515c761886a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/3912
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent formatting
* constify function parameters where appropriate (adjusting parameter
types if necessary)
Tests are adjusted accordingly but test r
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3807
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d81ab64ff790b9c4c2d0312a574485cd83e755
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3807
to look at the new patch set (#5).
Simplify TS alloc: adjust function signatures
* drop unused parameters (from both functions and structs)
* document used parameters and
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3807
to look at the new patch set (#4).
Simplify TS alloc: adjust function signatures
* drop unused parameters (from both functions and structs)
* document used parameters and
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3807
to look at the new patch set (#3).
Simplify TS alloc: adjust function signatures
* drop unused parameters (from both functions and structs)
* document used parameters and
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3807
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d81ab64ff790b9c4c2d0312a574485cd83e755
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/3807
Simplify TS alloc: adjust function signatures
* drop unused parameters (from both functions and structs)
* document used parameters and return values
* tighten types used for parameters
* use consistent formatting
Tests are adjusted accordingly but tes
16 matches
Mail list logo
