Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2320309bc8c1c20e2de6ef2e0f17472c68de80cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: tests: convolve: Disable due to difference in output in
different archs
..
tests: convolve: Disable due to difference in output in different archs
Patch Set 1:
@alexander: On top of sending the mail to the ml, I already assigned a task to
Tsou a few days ago too (https://osmocom.org/issues/2826). I think that counts
as pinging specifically.
@max: I can prefix it with FIXME but anyway it's quite visible since everytime
you run the tests
Patch Set 1:
> it is even inside the commit in testsuite.at
Might make sense to prefix it with FIXME so it'll jump out when grepping the
sources.
--
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1:
I think you should send an e-mail to the mailing list, as not everyone is
reading Gerrit. I've stumbled upon this patch completely accidentally and I
haven't seen any discussions.
--
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit
Patch Set 1: Code-Review-1
I don't think to disable it is a good idea. Why not improve it? I think Thomas
Tsou and/or Vadim had suggestions how to do that.
--
To view, visit https://gerrit.osmocom.org/5817
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Review at https://gerrit.osmocom.org/5817
tests: convolve: Disable due to difference in output in different archs
Let's disable this test in order to have passing jenkins jobs until we
find a better way to properly test this for different architectures.
Change-Id:
