osmo-ttcn3-hacks[master]: improve documentation of templates used in GGSN_Tests

2018-04-01 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7598 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bfc21a5ba74e0505457e4874f93501ad7c68b7b Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

[MERGED] osmo-ttcn3-hacks[master]: improve documentation of templates used in GGSN_Tests

2018-04-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: improve documentation of templates used in GGSN_Tests .. improve documentation of templates used in GGSN_Tests Various improvements to the comments docum

osmo-ttcn3-hacks[master]: improve documentation of templates used in GGSN_Tests

2018-03-30 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 I think it's already clear due to the "ts/tr" in the naming, but of course it's even better if documented as you did :) -- To view, visit https://gerrit.osmocom.org/7598 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Cha

[PATCH] osmo-ttcn3-hacks[master]: improve documentation of templates used in GGSN_Tests

2018-03-30 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7598 improve documentation of templates used in GGSN_Tests Various improvements to the comments documenting packet templates used in GGSN_Tests: fix IPv4 vs. IPv6 confusion, clearly indicate whether templates are used for sending or for receiving/matching pa