Vadim Yanitskiy has submitted this change and it was merged.
Change subject: layer23/cell_log: set default logfile to /dev/null
..
layer23/cell_log: set default logfile to /dev/null
When '/var/log/osmocom.log' does not exist
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a9982f221871c78c5c9a73b7b7a1787ff07a86c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
I agree, we shouldn't write a log unless requested to do so. Just like in all
the libosmovty-using programs on the network side: Log files must be explicitly
enabled/configured
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit
Patch Set 1:
> I'd prefer to keep some log file by default - /tmp/osmocom.log for
> example. Or, at the very least, this should be explicitly described
> in readme as well as in the help for corresponding command-line
> option.
>From my experience, in most use cases the log file is
not
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a9982f221871c78c5c9a73b7b7a1787ff07a86c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1:
I'd prefer to keep some log file by default - /tmp/osmocom.log for example. Or,
at the very least, this should be explicitly described in readme as well as in
the help for corresponding command-line option.
--
To view, visit https://gerrit.osmocom.org/6252
To unsubscribe, visit
Review at https://gerrit.osmocom.org/6252
layer23/cell_log: set default logfile to /dev/null
When '/var/log/osmocom.log' does not exist the cell_log
app cannot start normally, because it has no permissions
to create a new file. Furthermore, logfile is optional now.
Change-Id:
