Review at https://gerrit.osmocom.org/2939
common: Declare explicit Vector move constructor
Vector class already has a semantically odd non-const copy
constructor that serves the same function as a C++11 move
constructor. Make the move constructor semantics explicit
and address Coverity at the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2939
to look at the new patch set (#2).
common: Declare explicit Vector move constructor
Vector class already has a semantically odd non-const copy
constructor that serves the same function
Tom Tsou has submitted this change and it was merged.
Change subject: sigProcLib: Remove heap based signal vector allocations
..
sigProcLib: Remove heap based signal vector allocations
The osmo-trx internals rely heavily on
Review at https://gerrit.osmocom.org/2941
sigProcLib: Remove trigonometric tables
Trigonometric sin/cos tables are unused after initialization.
There is no benefit to implementing lookup tables for run-once
operations. Also perform initial calculations in double width
because there is no
Review at https://gerrit.osmocom.org/2942
sigProcLib: Use explicit NaN check in sinc table generation
Using "x < 0.01" is a crude check for detecting NaN condition, which
occurs in a sinc call when x = 0 due to divide-by-zero. Use stdlib
isnan() call for this purpose. Also, as the table is
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2926
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1f524cc86416699b3c143e5faddb33d61380767
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2927
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib72ab98a27a02084b040319046c92d1c4157ae4c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2925
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide4e22418e2cc469418cba018970cb0eb9906697
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2914
to look at the new patch set (#2).
Unuse resources after every test
Fix bug in put_all(). That method was unused before this commit.
Clean the process list after the
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2884
to look at the new patch set (#4).
Add support for SMPP testing
As defined in [1], the different related actors are implemented in this
commit: ESME and SMSC.
SMSC: In
Review at https://gerrit.osmocom.org/2932
octphy: improve log output
Printing the RX payload size is strictly informative, so the
loglevel LOGL_ERROR is wrong. This commit changes it to
LOGL_DEBUG
(Patch by Octasic Inc.)
Change-Id: I712cdd79cbba93f457705d38871bd8d4b7f4e897
---
M
Review at https://gerrit.osmocom.org/2933
octphy: complete value strings (octphy_cid_vals)
The value string table octphy_cid_vals lacks the strings for
cOCTVC1_MAIN_MSG_APPLICATION_INFO_CID and cOCTVC1_MAIN_MSG_APPLICATION_INFO_CID
(Patch by Octasic Inc.)
Change-Id:
Review at https://gerrit.osmocom.org/2931
measurement: initalize lchan properly
When the TX channel is activated, the measurement related struct
members are not properly reset. To ensure all flags are initalized
properly we set the measurement related flags zu zero.
(Patch by Octasic Inc.)
Review at https://gerrit.osmocom.org/2930
measurement: improve log output
The code that receives the uplink measurement data from L1 does not
print the number of already received uplink measurements. Since
this is a valuable information when debugging the log output will
now print this
Review at https://gerrit.osmocom.org/2934
lchan: add members for BFI
The lchan struct lacks structures to keep track of the
BFI (Bad Frame Indication) counters. This commit adds the
needed structures.
(Patch by Octasic Inc.)
Change-Id: I2ed78a9dd8747736d01ccf700396d7996f9f4e5d
---
M
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2915
to look at the new patch set (#2).
Use a subdir of run_dir for each test
Processes created have the scope of the test, so we should store
everything in a
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2747
to look at the new patch set (#4).
OsmoBTS: Update osmotrx ip to diff between local and remote
Change Id of the code implementation:
Patch Set 1:
It would be even better to use RuntimeDirectory= option for script's oneshot
service but this would require modifications to lc15-sysdev-remap to use /run
paths.
--
To view, visit https://gerrit.osmocom.org/2935
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/2935
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6208a1f7d62cac7ef64459e62f8e6083b0025580
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2935
lc15: use directory instead of symlink
Use the directory populated by lc15-sysdev-remap directly instead of
symlink to it to simplify OE builds and troubleshooting.
Change-Id: I6208a1f7d62cac7ef64459e62f8e6083b0025580
Related: SYS#3686
---
M
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2831
to look at the new patch set (#4).
gsm0808: add function gsm0808_extrapolate_speech_codec()
The contents of the speech codec element (struct gsm0808_speech_codec),
that
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2820
to look at the new patch set (#3).
gsm0808: fix AoIP speech codec element parser/generator
The implementation of the parser/generator for the speech codec
information
Hello Max, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2811
to look at the new patch set (#5).
gsm0808: update permitted speech constants
3GPP TS 48.008 specifies two new half rate speech modes and two
new full rate speech
Review at https://gerrit.osmocom.org/2938
cosmetic: Add info about corespondig codecs to permittet speech
The constants in enum gsm0808_permitted_speech are not very
expressive. This patch adds a comment which tells to which
codec the constand is coresponding.
Change-Id:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2830
to look at the new patch set (#4).
gsm0808: add function to translate perm speech to speech codec type
The permitted speech field used in channel type element (struct
Review at https://gerrit.osmocom.org/2936
cosmetic: remove API documentation strings in header file
Typically we don't place comments with the function declarations
in .h files. Not sure why this file has comments for each. The
API doc belongs in the .c file as proper doxygen comments,
and
Review at https://gerrit.osmocom.org/2937
cosmetic: Add codec references to Speech Version Indication
Add the information which GSM Speech codec version coresponds to
which bearer capability speech version.
Change-Id: Ic9493fea139420a52c32b17d00ac7d0b2bf86967
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2935
to look at the new patch set (#2).
lc15: use directory instead of symlink
Use the runtime directory populated by lc15-sysdev-remap.service
directly instead of symlink to it to simplify
Hello Max, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2812
to look at the new patch set (#5).
gsm0408: update bearer capability speech version
3GPP TS 24.008 specifies two new speech versions for half rate and
two new
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2925
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide4e22418e2cc469418cba018970cb0eb9906697
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2927
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib72ab98a27a02084b040319046c92d1c4157ae4c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2926
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1f524cc86416699b3c143e5faddb33d61380767
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Tom Tsou has submitted this change and it was merged.
Change subject: uhd: Fix Tx-RX timing offset setting
..
uhd: Fix Tx-RX timing offset setting
Integer timestamp offset was set to zero due to bad cast-operator
precedence.
Tom Tsou has submitted this change and it was merged.
Change subject: uhd: Fix USRP2/N200/N210 device detection
..
uhd: Fix USRP2/N200/N210 device detection
Commit 1fb0ce67 "uhd: Use map container for for device parameter
Tom Tsou has submitted this change and it was merged.
Change subject: sigProcLib: Fix complex/real vector flag in Laurent modulator
..
sigProcLib: Fix complex/real vector flag in Laurent modulator
The modulator vector to be
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2920
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If53da1bf77b5944b6117765fa98ce12e1ccdeede
Gerrit-PatchSet: 3
Gerrit-Project: osmo-trx
Gerrit-Branch: master
36 matches
Mail list logo
