dexter has submitted this change and it was merged.
Change subject: measurement: improve log output
..
measurement: improve log output
The code that receives the uplink measurement data from L1 does not
print the number of
Review at https://gerrit.osmocom.org/3052
osmo-bts-sysmo: Include frame number in MEAS IND
l1_if.c does not generate struct osmo_phsap_prim l1sap properly.
The frame number is not included in this struct. This renders the
logic that processes the reported measurements non functional,
since the
Patch Set 1: Code-Review-1
you also have a revert of this pushed as a patch??
--
To view, visit https://gerrit.osmocom.org/3052
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09241d6cc2ff09e71a3d723d90e4468108a27ae1
Gerrit-PatchSet: 1
Review at https://gerrit.osmocom.org/3051
Revert "osmo-bts-sysmo: Include frame number in MEAS IND"
This reverts commit 3f97e4b1fcdc788345ab7740bd4fb8a3d73f5526.
Change-Id: Ib50c813c470bf6ea740fe6667431eaa1a23fdd8d
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 2 insertions(+), 7
Review at https://gerrit.osmocom.org/3050
Revert "sysmobts: normalize frame number in measurement indication"
This reverts commit 88b2cc30a6a7253c2c4c76178e5727fad48556ca.
Change-Id: I30f37a9feef24a45e254377502615d717dba9765
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 2 insertions(+), 10
Patch Set 3:
Please change commit message to reflect function name properly - or use some
text instead of function name.
--
To view, visit https://gerrit.osmocom.org/3048
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3048
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8015d2ded3940b01b35df7b72fc35c70c25e9926
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: -Code-Review
AFAIK, he's not registered in gerrit and the code is part of huge patch from 5
years ago so chances to get that explanation are rather slim. I think we should
just either enable it or drop it and git rid of associated warning.
--
To view, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3008
to look at the new patch set (#5).
Simplify jenkins build scripts
* move duplicated code into separate functions in jenkins_common.sh
* use that function in individual builds
Patch Set 1:
ah, the revert is for an older version of this change? we'd usually just submit
a fix for it, which makes it easier to see the actual difference between the
two implementations.
--
To view, visit https://gerrit.osmocom.org/3052
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3040
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I354d0c121880553ce1bd59b7394d52b104b7d6da
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3042
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f30ae1f547a5c01c516d4a05032193294c25f2d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review-1
not ready for merge
--
To view, visit https://gerrit.osmocom.org/3038
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I339db0e5f3fd5e44bac974f2447afc80388802af
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3041
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5031541d4ae4244a62a18acf71139db2874927fa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3039
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e19d68782a12e52ba1d3ba2665060275d04866c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3043
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac4e57a882e5a31143499c1662d8d8e52320938
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3008
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d09c5f2693b5ac0a4d8f2c840971e13d1ec58cf
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
dexter has abandoned this change.
Change subject: osmo-bts-octphy: normalize frame number in MEAS IND
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2867
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3054
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89b35fc587bbac6810511b2317eed24368858f37
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b5f934fc3bd00b0467d90029d3053b16594186
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3052
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09241d6cc2ff09e71a3d723d90e4468108a27ae1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3050
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30f37a9feef24a45e254377502615d717dba9765
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2934
to look at the new patch set (#2).
lchan: add members for BFI
The lchan struct lacks structures to keep track of the
BFI (Bad Frame Indication) counters. There are
Neels Hofmeyr has submitted this change and it was merged.
Change subject: osmo-bts-trx config: remove settsc
..
osmo-bts-trx config: remove settsc
In osmo-bts change I51aeb17661dfd63ff347f7b2c0d7ffa383ec814c the settsc config
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3053
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eef894e6f15b4449fc8926bebb118624efc7924
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3059
octphy: remove log output
When handle_ph_data_ind() runs BER and RSSI is logged. Remove
this log output by removing the call to dump_meas_res
(Patch by Octasic Inc.)
Change-Id: I5e755465daa3daec2e2b4f61bc8d779c49196e9a
---
M
Review at https://gerrit.osmocom.org/3057
octphy: initalize l1msg and only when needed
l1msg is initalized when the variable is declared. This means
the allocation always runs right on the beginning. Even when
the buffer is not needed at all.
do a prober l1msg initalization only when needed
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2931
to look at the new patch set (#2).
measurement: initalize lchan properly
When the TX channel is activated, the measurement related struct
members are not properly reset. To ensure all
Patch Set 1: Code-Review-1
(1 comment)
clarify: setbsic is moved, but settsc is actually dropped entirely, which
doesn't match the commit log.
https://gerrit.osmocom.org/#/c/3044/1/src/osmo-bts-trx/trx_vty.c
File src/osmo-bts-trx/trx_vty.c:
Line 506: vty_out(vty, " osmotrx
Patch Set 3:
Holger, Neels:Any input on this? For me it's really hard. I personally believe
it makes code less readable, but Max and Pau claim it is helpful for them...
--
To view, visit https://gerrit.osmocom.org/2857
To unsubscribe, visit https://gerrit.osmocom.org/settings
Harald Welte has submitted this change and it was merged.
Change subject: add/tweak various logging to help figure out complex routing
..
add/tweak various logging to help figure out complex routing
Add function
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3012
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3243606d6cad7721f7da7f6caba2caa90ae2bbd
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3055
sysmo/tch.c: Clean up use of empty buffer
Make code easier to read and avoid reading first byte of the buffer if size is
0.
Change-Id: I5ecfc4df5a3fcad3d3ad50bf3dd3db65b694481a
---
M src/osmo-bts-sysmo/tch.c
1 file changed, 4 insertions(+), 3
Harald Welte has submitted this change and it was merged.
Change subject: gen_mtp_transfer_req_xua(): add addr to error log for missing
DPC
..
gen_mtp_transfer_req_xua(): add addr to error log for missing DPC
Change-Id:
Review at https://gerrit.osmocom.org/3054
osmo-bts-trx config: remove settsc
In osmo-bts change I51aeb17661dfd63ff347f7b2c0d7ffa383ec814c the settsc config
item is being removed. To be able to test it, drop the settsc option from the
config.
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3049
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef7a45d015a28fdadf75f97294bc5d4f825b8ae
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Remove comment warning
..
Remove comment warning
It's unclear why the warning was placed next to commented log statement
to begin with, so let's just
Review at https://gerrit.osmocom.org/3064
tests: osmo-pcap: Allow different l2 pkts
Before this patch, ETH was assumed and other types were not supported.
This patch also adds Linux cooked packet support for L2.
Change-Id: Ie62fa0a8e45e1e141edb64b116dad185ad9c7a5f
---
M
Patch Set 2: Code-Review-1
I run it manually with osmo-gsm-tester and jenkins and it seems to be failing
with this patch applied:
http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_manual-run-all/2/console
I built everything using master and osmo-bts with branch
Review at https://gerrit.osmocom.org/3062
uhd: Always specify samples-per-symbol for device lookup
Fix MCBTS device setup where the map access was failing on the wrong
assumption that all devices support 1-SPS TX-RX operation. Some devices
and/or configurations such as LIMESDR and MCBTS only
Patch Set 1:
This patch and the other in the same series have been laying in my
pespin/jitterbuffer for a long time. They are not directly related to
jitterbuffer but contain features needed/used by that branch, and which may be
also useful to others. As I have been waiting to push the jitter
Patch Set 3:
Actually, I'm sorry, I think I stay with my original assessment. It makes code
harder to figure out, and as Holger points out it would even be restricted in
terms of what type it could be applied to.
In Linux kernel we have some macros in linux/bitops.h, but then they exist for
Patch Set 2:
Isn't this basically the link failure counter "s" ? which we also already have
in lchan->s ?
If there's something mandate by specs but we're missing it, pleaes include
relevant spec references in the commit log.
--
To view, visit https://gerrit.osmocom.org/2934
To unsubscribe,
Patch Set 2:
> > It actually fails only for me because
> > I build with -Werror locally.
>
> Ah missed this comment. I'll cast precisely then.
I didn't mean here that it fails if you use void* instead of char*, I wanted to
precise that build was failing for me if you didn't cast to pointer
Review at https://gerrit.osmocom.org/3047
RSL: receive and send multiple SI2q messages
* change BCCH Info handler to explicitly support multiple SI2quater
messages sent from BSC
* change SI scheduler to send SI2q in round-robin way
Change-Id: Ib595733cde108387bc7ee76b1b11ada6a235f13c
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3048
to look at the new patch set (#3).
utils: add function gsm_print_fn2gsmtime()
Convert a given frame number into a printable string that displays
the sub components of the frame number.
Review at https://gerrit.osmocom.org/3049
Remove comment warning
It's unclear why the warning was placed next to commented log statement
to begin with, so let's just follow that warning's advice and drop it.
Change-Id: I3ef7a45d015a28fdadf75f97294bc5d4f825b8ae
---
M src/pcu_l1_if.cpp
1 file
Patch Set 1: Code-Review-1
Test dummy for lc15 jenkins changes.
--
To view, visit https://gerrit.osmocom.org/3049
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef7a45d015a28fdadf75f97294bc5d4f825b8ae
Gerrit-PatchSet: 1
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2857
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3048
to look at the new patch set (#2).
utils: add function gsm_print_fn2gsmtime()
Convert a given frame number into a printable string that displays
the sub components of the frame number.
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2857
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3008
to look at the new patch set (#2).
Simplify jenkins build scripts
* move duplicated code into separate functions in jenkins_common.sh
* use that function in individual builds
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3008
to look at the new patch set (#4).
Simplify jenkins build scripts
* move duplicated code into separate functions in jenkins_common.sh
* use that function in individual builds
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3047
to look at the new patch set (#2).
RSL: receive and send multiple SI2q messages
* change BCCH Info handler to explicitly support multiple SI2quater
messages sent
Patch Set 3:
> Shall I abandon this or +1 x 3 outweight Harald's -1?
Let's wait for the final response from Harald.
--
To view, visit https://gerrit.osmocom.org/2857
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 3: Code-Review+1
Yepp, he's the boss.
--
To view, visit https://gerrit.osmocom.org/2857
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Patch Set 2:
I can't explain it properly because I do not understand why memory
initialization issue affects osmo-bts-trx but not the others. I think the issue
in reverted commit was with the SI3 memory initialized when it shouldn't be but
it's just a guess.
--
To view, visit
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3047
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib595733cde108387bc7ee76b1b11ada6a235f13c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
I guess the best here is to use git blame and add the author of those lines
here as a reviewer, he may be able to explain a bit better his intentions when
doing that.
--
To view, visit https://gerrit.osmocom.org/3049
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 2:
Let's pay attention once we merge this to see how osmo-gsm-tester behaves.
--
To view, visit https://gerrit.osmocom.org/3047
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib595733cde108387bc7ee76b1b11ada6a235f13c
Max has submitted this change and it was merged.
Change subject: Add missing include for abis.h header file
..
Add missing include for abis.h header file
This fixes compilation warning:
implicit declaration of function
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/3037/2/src/osmo-bts-trx/scheduler_trx.c
File src/osmo-bts-trx/scheduler_trx.c:
Line 1473: if (elapsed_fn >= 135774)
where does this number comes from?
--
To view, visit https://gerrit.osmocom.org/3037
To unsubscribe, visit
62 matches
Mail list logo
