Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3264
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ecad584a1bc9b97693b199abd1ec2e5f6ce156d
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/3264/1/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:
Line 1198: /* Delet an addressbook entry */
Delete
--
To view, visit https://gerrit.osmocom.org/3264
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3264
to look at the new patch set (#2).
cosmetic: fixup comment
Change-Id: I8ecad584a1bc9b97693b199abd1ec2e5f6ce156d
---
M src/osmo_ss7_vty.c
1 file changed, 1
Harald Welte has submitted this change and it was merged.
Change subject: rtp-amr: Describe requirement to recieve all PH-DATA.ind events
..
rtp-amr: Describe requirement to recieve all PH-DATA.ind events
Change-Id:
Patch Set 2:
We've talked with the result that we're going to have an libosmo-mgcp-legacy
library clearly marked as such, to keep the namespace open for new development
of the osmo-mgw. I still need a logging category for it = I'd still like to add
this DLMGCP category.
--
To view, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3273
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a78b3398c36a8107fa1809ba9b89235980f0e4f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3274
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8efda2387e0e5e95700b070dab8f8dd427fa562d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3181
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09c587e2d59472cbde852d467d457254746d9e67
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: rtp-amr: Fix typo and trailing whitespace
..
rtp-amr: Fix typo and trailing whitespace
Change-Id: I8efda2387e0e5e95700b070dab8f8dd427fa562d
---
M
Patch Set 2:
> I really would prefer not to have a system-installed library with a
> "stable" API for MGCP based on the existing code.
The alternative is to copy the previous internal libmgcp around. We would have
copies in osmo-mgw, osmo-msc and osmo-bsc.
osmo-msc uses MGCP client code that
Review at https://gerrit.osmocom.org/3271
vty: command to set local ip of ASP
The local ip of an ASP can not be set, while the same is possible
for the remote ip.
Add VTY command to set the local ip of an ASP
Change-Id: I115b87b08bdc4b07772b7afb9c25bc713e79945a
---
M src/osmo_ss7_vty.c
1
Review at https://gerrit.osmocom.org/3272
lc15-mgr: update parameter write
Better match upstream lc15 code:
* fsync on parameter write
* use runtime dir for parameter storage
Change-Id: Iac150bf2ebffc5fa9544b0f3b19cd647996fc8b6
Related: SYS#3728
---
M contrib/sysmobts-mgr.service
M
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3272
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac150bf2ebffc5fa9544b0f3b19cd647996fc8b6
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/3272/2//COMMIT_MSG
Commit Message:
Line 9: Better match upstream lc15 code:
actually, it's not uptream. we are upstream. We match close r to the vendor
fork from of a vendor who doesn't seem to care to merge his changes upstream :/
--
Patch Set 1:
please clarify when/how this is used. The existing VTY interface is designed
to be compatible with the Cisco ITP. The specification of the local IP address
(on a SG/STP) is done at the time you bind the given M3UA or SUA listener
process, see xua_local_ip_cmd
Is this command
Patch Set 5:
waiting for neels to see if his comments are adressed.
The global list for globally unique name lookup will be a separate patch, or
what is the plan here?
--
To view, visit https://gerrit.osmocom.org/3103
To unsubscribe, visit https://gerrit.osmocom.org/settings
Harald Welte has submitted this change and it was merged.
Change subject: osmo-gsm-tester: jenkins fixes: install JDK, SSH instructions
..
osmo-gsm-tester: jenkins fixes: install JDK, SSH instructions
Add instructions to
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3103
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib49ab623055e9ada7f95e0163ba7e33c5f6f99cb
Gerrit-PatchSet: 5
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3266
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2c1adc2ddee3be016e4d253451593b19dbe133a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Review at https://gerrit.osmocom.org/3273
rtp-amr: Describe requirement to recieve all PH-DATA.ind events
Change-Id: I4a78b3398c36a8107fa1809ba9b89235980f0e4f
---
M OsmoBTS/rtp-amr-docinfo.xml
M OsmoBTS/rtp-amr.adoc
2 files changed, 59 insertions(+), 35 deletions(-)
git pull
Review at https://gerrit.osmocom.org/3274
rtp-amr: Fix typo and trailing whitespace
Change-Id: I8efda2387e0e5e95700b070dab8f8dd427fa562d
---
M OsmoBTS/rtp-amr.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Patch Set 1:
Note: we use this as a default config for corresponding image.
--
To view, visit https://gerrit.osmocom.org/3252
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc4a4314a8b48e4000de445f4f05795e1a2d8b
Gerrit-PatchSet: 1
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3273/1/OsmoBTS/rtp-amr.adoc
File OsmoBTS/rtp-amr.adoc:
Line 27: In the case of Nutaq GSM PHY and API, option fBFILevel is set to a
ridiculously
> I think it's better to refer to BTS models explicitly instead of company na
I'm using this
lc15-mgr: update parameter read/write
Better match upstream lc15 code:
* fsync on parameter write
* use permanent storage directly for parameters
Change-Id: Iac150bf2ebffc5fa9544b0f3b19cd647996fc8b6
Related: SYS#3728
---
M src/osmo-bts-litecell15/misc/lc15bts_par.c
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3267
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia067dc5b0bdef07b90ab57f89e8ba6b2a794eb4a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3268
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf3285d7bb921d212cb8945e835be2c81189fb87
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Max has submitted this change and it was merged.
Change subject: lc15-mgr: update parameter read/write
..
lc15-mgr: update parameter read/write
Better match upstream lc15 code:
* fsync on parameter write
* use permanent
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3273/1/OsmoBTS/rtp-amr.adoc
File OsmoBTS/rtp-amr.adoc:
Line 27: In the case of Nutaq GSM PHY and API, option fBFILevel is set to a
ridiculously
I think it's better to refer to BTS models explicitly instead of company name
as it's less
Patch Set 1:
Next nice change would be to swap places of right foot (release+date) with
right header (page number).
However, I spent some time trying to find how to replace the content of the
right header (with \rhead and similar) but I was unable to change it.
--
To view, visit
Review at https://gerrit.osmocom.org/3276
all manuals: Move date and release from center head to right foot
Otherwise long doc titles (top left) run on top of release and date
making it impossible to read any of them correctly.
Change-Id: I685a981a5cfd82214d1d654aa1553a844c2af157
---
M
Review at https://gerrit.osmocom.org/3275
lc15: fix BTS revision and hw options
* remove typo in logging
* add missing return statement
* fix compilation warnings
* add detailed logging for supported GSM band and related errors
Change-Id: I73bccd81ec56845ba11b939937b295eb0f51b4a8
Related:
Review at https://gerrit.osmocom.org/3277
lc15: port lc15bts-mgr changes
Change-Id: Iabbaedc84594150a4e5445c16dd1f6f89858
Related: SYS#3679
---
M doc/examples/litecell15/lc15bts-mgr.cfg
M include/osmo-bts/phy_link.h
M src/common/Makefile.am
M src/osmo-bts-litecell15/Makefile.am
M
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3275/1/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:
Line 1508: LOGP(DL1C, LOGL_DEBUG, "BTS hw support band %s\n",
gsm_band_name(fl1h->hw_info.band_support));
> If it's not called that often, it's probably a
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3275
to look at the new patch set (#2).
lc15: fix BTS revision and hw options
* remove typo in logging
* add missing return statement
* fix compilation warnings
* add detailed logging for
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3275/1/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:
Line 1508: LOGP(DL1C, LOGL_DEBUG, "BTS hw support band %s\n",
gsm_band_name(fl1h->hw_info.band_support));
> dsp and fpga version are already printed by
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3277
to look at the new patch set (#2).
lc15: port lc15bts-mgr changes
Change-Id: Iabbaedc84594150a4e5445c16dd1f6f89858
Related: SYS#3679
---
M doc/examples/litecell15/lc15bts-mgr.cfg
M
Review at https://gerrit.osmocom.org/3278
bsc_vty: Add VTY command to test CTRL TRAP feature
Using this new command (introduced in OsmoBSC + OsmoNITB), you can
simulate the generation of TRAP events for testin purposes.
start the control interface monitor as an example client program:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3252
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc4a4314a8b48e4000de445f4f05795e1a2d8b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3275
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bccd81ec56845ba11b939937b295eb0f51b4a8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3252
to look at the new patch set (#2).
lc15: make default config usable
* add trx-calibration path
* change GSM band to 900
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3187
to look at the new patch set (#2).
move openbsc.git's iu.h, iu.c, iu_vty.c here as iu_client* NOT FOR MERGE
*** NOT FOR MERGE: use SCCP address book: the libsccp address
Harald Welte has submitted this change and it was merged.
Change subject: lc15: fix BTS revision and hw options
..
lc15: fix BTS revision and hw options
* remove typo in logging
* add missing return statement
* fix compilation
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3275
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73bccd81ec56845ba11b939937b295eb0f51b4a8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3252
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc4a4314a8b48e4000de445f4f05795e1a2d8b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: lc15: make default config usable
..
lc15: make default config usable
* add trx-calibration path
* change GSM band to 900
Change-Id:
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/3277/2//COMMIT_MSG
Commit Message:
Line 6:
port from where? Which changes from which branch of which repository, up to
which point (git commit ID) are included in this patch? THis information is
what we will need later on to
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/3187/2/include/osmocom/ranap/iu_client.h
File include/osmocom/ranap/iu_client.h:
Line 31:struct gprs_ra_id ra_id;
I decided to keep the gprs_ra_id. It is named such because it contains a rac on
top of the usual circuit-switched
47 matches
Mail list logo
