[PATCH] libosmocore[master]: add osmo_fd_setup() convenience function to fill-in osmo_fd

2017-08-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/3500 add osmo_fd_setup() convenience function to fill-in osmo_fd This basically follows the concept of osmo_timer_setup() and allows the caller to fill-in all configurable fields of osmo_fd in one line of code, rather than open-coding it in 5 lines

[PATCH] osmo-iuh[master]: iu_client: derive local SCCP addr from sccp instance

2017-08-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3507 iu_client: derive local SCCP addr from sccp instance ranap_iu_init() is passed an sccp instance that has a local primary point code. Use this primary PC by default as the local address for IuCS and IuPS clients. Remove the current vty command 'iu

[PATCH] osmo-iuh[master]: add /debian package support

2017-08-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3506 add /debian package support Change-Id: I985805aea0e48fe70619de8b81206098e4e37613 --- A debian/changelog A debian/compat A debian/control A debian/copyright A debian/libosmo-ranap-dev.install A debian/libosmo-ranap0.install A debian/osmo-hnbgw.install A

osmo-iuh[master]: add /debian package support

2017-08-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/3506/1/debian/copyright File debian/copyright: Line 11:2016-2017 sysmocom s.f.m.c. GmbH interesting list of copyrights :) https://gerrit.osmocom.org/#/c/3506/1/debian/rules File

[PATCH] osmo-iuh[master]: add /debian package support

2017-08-12 Thread lynxis lazus
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3506 to look at the new patch set (#2). add /debian package support Change-Id: I985805aea0e48fe70619de8b81206098e4e37613 --- A debian/changelog A debian/compat A

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/x86_64

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 180s]

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/x86_64

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/x86_64

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64

2017-08-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

[PATCH] openbsc[master]: libcommon: Fix log output for bts>0.

2017-08-12 Thread Alexander Chemeris
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3185 to look at the new patch set (#3). libcommon: Fix log output for bts>0. Fixes regression probably introduced in c696cc28. For bts>0 logging doesn't show bts number correctly when

openbsc[master]: libcommon: Fix log output for bts>0.

2017-08-12 Thread Alexander Chemeris
Patch Set 3: Harald - I've added a test. Hope it's enough. It doesn't look like the build failure is due to my change.. Not sure if I need to do anything? -- To view, visit https://gerrit.osmocom.org/3185 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] openggsn[master]: libgtp: Delete PDP context on receiving GTPv1 Error Indication

2017-08-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/3503 libgtp: Delete PDP context on receiving GTPv1 Error Indication When a peer GSN receives a GPDU for an unknown PDP context, it sends a GTP Error Indication. This Error Indication should be used to delete the offending PDP context locally. In GTPv1,

[PATCH] openbsc[master]: Migrate from gprs_apn_to_str() to libosmocore osmo_apn_to_str()

2017-08-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/3504 Migrate from gprs_apn_to_str() to libosmocore osmo_apn_to_str() In 2015, Jacob moved/copied related functions to libosmocore, but for some reason didn't remove the copies here. Let's follow-up on that and remove duplicated code. The libosmocore

openbsc[master]: sgsn_vty: Don't assume pdp->lib is always valid

2017-08-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3505 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3184877f9709db65f5f93a98403f2ef5b04a8ca Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] openggsn[master]: libgtp: Delete PDP context on receiving GTPv1 Error Indication

2017-08-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libgtp: Delete PDP context on receiving GTPv1 Error Indication .. libgtp: Delete PDP context on receiving GTPv1 Error Indication When a peer GSN

[PATCH] openbsc[master]: sgsn_vty: Don't assume pdp->lib is always valid

2017-08-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/3505 sgsn_vty: Don't assume pdp->lib is always valid We can only print libgtp pdp information if a library context is attached to this pdp context. This is not always the case, particuarly during some teardown scenarios. Change-Id:

openggsn[master]: libgtp: Delete PDP context on receiving GTPv1 Error Indication

2017-08-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3503 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e843f9ef1d6fd7868cc992e083c0891d16b6da9 Gerrit-PatchSet: 1 Gerrit-Project: openggsn Gerrit-Branch: master

[PATCH] openggsn[master]: Properly format IMSI before using it in trap

2017-08-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/3501 Properly format IMSI before using it in trap For some reason Max' commits introducing the CTRL/trap interface about one year ago didn't convert the IMSI to its actual textual representation before usign it in the CTRL interface. Let's clean that up by

[PATCH] openggsn[master]: libgtp: Add missing mandatory IEs in GTP Error Indication

2017-08-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/3502 libgtp: Add missing mandatory IEs in GTP Error Indication Change-Id: Iadd1fe3de7c476576a4409f22f5e84e9eade6b6e --- M gtp/gtp.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/openggsn refs/changes/02/3502/1

openggsn[master]: Properly format IMSI before using it in trap

2017-08-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3501 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b20d2e47a29de266d93a7ddd5e6877f7e346a63 Gerrit-PatchSet: 1 Gerrit-Project: openggsn Gerrit-Branch: master

[MERGED] openggsn[master]: Properly format IMSI before using it in trap

2017-08-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Properly format IMSI before using it in trap .. Properly format IMSI before using it in trap For some reason Max' commits introducing the CTRL/trap

[MERGED] openggsn[master]: libgtp: Add missing mandatory IEs in GTP Error Indication

2017-08-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libgtp: Add missing mandatory IEs in GTP Error Indication .. libgtp: Add missing mandatory IEs in GTP Error Indication Change-Id:

openggsn[master]: libgtp: Add missing mandatory IEs in GTP Error Indication

2017-08-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3502 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadd1fe3de7c476576a4409f22f5e84e9eade6b6e Gerrit-PatchSet: 1 Gerrit-Project: openggsn Gerrit-Branch: master

libosmocore[master]: add osmo_fd_setup() convenience function to fill-in osmo_fd

2017-08-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3500 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dbf19ea22fd65302bfc5424c10418d1b7939094 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53a65164a6cc4abc6bf57d9a8dc275cf21c90222 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] libosmocore[master]: add osmo_fd_setup() convenience function to fill-in osmo_fd

2017-08-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add osmo_fd_setup() convenience function to fill-in osmo_fd .. add osmo_fd_setup() convenience function to fill-in osmo_fd This basically follows the

[MERGED] libsmpp34[master]: add esm_class definitions

2017-08-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add esm_class definitions .. add esm_class definitions Add special message attributes definitions that are associated with the short message. Thus, we

libsmpp34[master]: add esm_class definitions

2017-08-12 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3473 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65 Gerrit-PatchSet: 2 Gerrit-Project: libsmpp34 Gerrit-Branch: master

[MERGED] openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling .. libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling