date:20170819

osmo-bts[master]: osmo-bts-trx: Increase a maximum allowed MS power reduction ...

2017-08-19 Thread Alexander Chemeris


Patch Set 3:

> you mention 2dB here, but your change seems to change it from 2 to 4dB ?

Thank you! That's clearly a typo. Fixed in the new patch.

-- 
To view, visit https://gerrit.osmocom.org/3562
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58785513e5739474b881ed7f2a312ecc690e7e60
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] osmo-bts[master]: osmo-bts-trx: Increase a maximum allowed MS power reduction ...

2017-08-19 Thread Alexander Chemeris

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3562

to look at the new patch set (#3).

osmo-bts-trx: Increase a maximum allowed MS power reduction step from 2dB to 
4dB.

We tend to start MS with high power to make sure distant phones get good QoS,
but this also means that we need to reduce their power rather quickly. OTOH
we can't make this step too high because this may lead to power output
oscillation. From my (manual, limited) testing 4dB looks like a reasonable
compromise.

Change-Id: I58785513e5739474b881ed7f2a312ecc690e7e60
---
M src/osmo-bts-trx/loops.h
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/62/3562/3

diff --git a/src/osmo-bts-trx/loops.h b/src/osmo-bts-trx/loops.h
index 613d2d0..c0458c5 100644
--- a/src/osmo-bts-trx/loops.h
+++ b/src/osmo-bts-trx/loops.h
@@ -7,7 +7,7 @@
 
 /* how much power levels do we raise/lower as maximum (1 level = 2 dB) */
 #define MS_RAISE_MAX 4
-#define MS_LOWER_MAX 1
+#define MS_LOWER_MAX 2
 
 /*
  * loops api

-- 
To view, visit https://gerrit.osmocom.org/3562
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58785513e5739474b881ed7f2a312ecc690e7e60
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-bts[master]: osmo-bts-trx: Increase a maximum allowed MS power reduction ...

2017-08-19 Thread Alexander Chemeris

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/3562

to look at the new patch set (#2).

osmo-bts-trx: Increase a maximum allowed MS power reduction step from 2dB to 
4dB.

We tend to start MS with high power to make sure distant phones get good QoS,
but this also means that we need to reduce their power rather quickly. OTOH
we can't make this step too high because this may lead to power output
oscillation. From my (manual, limited) testing 4dB look like a reasonable
compromise.

Change-Id: I58785513e5739474b881ed7f2a312ecc690e7e60
---
M src/osmo-bts-trx/loops.h
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/62/3562/2

diff --git a/src/osmo-bts-trx/loops.h b/src/osmo-bts-trx/loops.h
index 613d2d0..c0458c5 100644
--- a/src/osmo-bts-trx/loops.h
+++ b/src/osmo-bts-trx/loops.h
@@ -7,7 +7,7 @@
 
 /* how much power levels do we raise/lower as maximum (1 level = 2 dB) */
 #define MS_RAISE_MAX 4
-#define MS_LOWER_MAX 1
+#define MS_LOWER_MAX 2
 
 /*
  * loops api

-- 
To view, visit https://gerrit.osmocom.org/3562
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58785513e5739474b881ed7f2a312ecc690e7e60
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmo-bts[master]: osmo-bts-trx: Remove an unused variable. Resolves a compiler...

2017-08-19 Thread Alexander Chemeris

Alexander Chemeris has submitted this change and it was merged.

Change subject: osmo-bts-trx: Remove an unused variable. Resolves a compiler 
warning.
..


osmo-bts-trx: Remove an unused variable. Resolves a compiler warning.

Change-Id: I2464e872f81021cbc3ccbc4e2e32c394d6afcf70
---
M src/osmo-bts-trx/loops.c
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index 8d6e5d7..3da805c 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -251,7 +251,6 @@
struct gsm_bts_trx *trx = l1t->trx;
struct gsm_lchan *lchan = >ts[L1SAP_CHAN2TS(chan_nr)]
.lchan[l1sap_chan2ss(chan_nr)];
-   int c_i;
 
/* check if loop is enabled */
if (!chan_state->amr_loop)
@@ -276,9 +275,6 @@
 
/* calculate average (reuse ber variable) */
ber = chan_state->ber_sum / chan_state->ber_num;
-
-   /* FIXME: calculate C/I from BER */
-   c_i = ber * 100;
 
/* reset bit errors */
chan_state->ber_num = 0;

-- 
To view, visit https://gerrit.osmocom.org/3561
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2464e872f81021cbc3ccbc4e2e32c394d6afcf70
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-bts[master]: osmo-bts-trx: Fix MS power control loop.

2017-08-19 Thread Alexander Chemeris


Patch Set 2:

> Please also see http://osmocom.org/issues/1851 and
 > http://osmocom.org/issues/1622 in this context

Thanks for pointing! I didn't realize we don't even follow the standard..

-- 
To view, visit https://gerrit.osmocom.org/3560
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I713e39b882db32a0d17aa04790d16fa79afa1fb1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-bts[master]: osmo-bts-trx: Fix MS power control loop.

2017-08-19 Thread Alexander Chemeris

Alexander Chemeris has submitted this change and it was merged.

Change subject: osmo-bts-trx: Fix MS power control loop.
..


osmo-bts-trx: Fix MS power control loop.

The following two commits from 2014-12-06 introduced a new variable to control
MS power - ms_power_ctrl, but kept the old ms_power variable in place. They
have also changed the meaning of the ms_power variable - it now keeps original
RSL configured value. So when much later osmo-trx-bts code was merged to master
the code was compiling fine and this change in the meaning was overlooked.

In osmo-bts:
579651bf300de002731dfd3bd39985c9fd15616c power/sysmobts: Add a manual ms power 
level control
In OpenBSC:
f6f86b0eec18da165db136b14bf2db87fde4b4ac osmo-bts: Introduce new struct for a 
power loop in the BTS code

Change-Id: I713e39b882db32a0d17aa04790d16fa79afa1fb1
---
M src/osmo-bts-trx/l1_if.c
M src/osmo-bts-trx/loops.c
2 files changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index f69e587..c629a61 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -509,7 +509,7 @@
 
LOGP(DMEAS, LOGL_DEBUG, "RX L1 frame %s fn=%u chan_nr=0x%02x MS 
pwr=%ddBm rssi=%.1f dBFS "
"ber=%.2f%% (%d/%d bits) L1_ta=%d rqd_ta=%d toa=%.2f\n",
-   gsm_lchan_name(lchan), fn, chan_nr, 
ms_pwr_dbm(lchan->ts->trx->bts->band, lchan->ms_power),
+   gsm_lchan_name(lchan), fn, chan_nr, 
ms_pwr_dbm(lchan->ts->trx->bts->band, lchan->ms_power_ctrl.current),
rssi, ber*100, n_errors, n_bits_total, lchan->meas.l1_info[1], 
lchan->rqd_ta, toa);
 
l1if_fill_meas_res(, chan_nr, lchan->rqd_ta + toa, ber, rssi, fn);
diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c
index 8070e80..8d6e5d7 100644
--- a/src/osmo-bts-trx/loops.c
+++ b/src/osmo-bts-trx/loops.c
@@ -48,7 +48,7 @@
uint16_t arfcn = trx->arfcn;
int8_t new_power;
 
-   new_power = lchan->ms_power - (diff >> 1);
+   new_power = lchan->ms_power_ctrl.current - (diff >> 1);
 
if (diff == 0)
return 0;
@@ -66,12 +66,12 @@
}
 
/* a higher value means a lower level (and vice versa) */
-   if (new_power > lchan->ms_power + MS_LOWER_MAX)
-   new_power = lchan->ms_power + MS_LOWER_MAX;
-   else if (new_power < lchan->ms_power - MS_RAISE_MAX)
-   new_power = lchan->ms_power - MS_RAISE_MAX;
+   if (new_power > lchan->ms_power_ctrl.current + MS_LOWER_MAX)
+   new_power = lchan->ms_power_ctrl.current + MS_LOWER_MAX;
+   else if (new_power < lchan->ms_power_ctrl.current - MS_RAISE_MAX)
+   new_power = lchan->ms_power_ctrl.current - MS_RAISE_MAX;
 
-   if (lchan->ms_power == new_power) {
+   if (lchan->ms_power_ctrl.current == new_power) {
LOGP(DLOOP, LOGL_INFO, "Keeping MS new_power of trx=%u "
"chan_nr=0x%02x at control level %d (%d dBm)\n",
trx->nr, chan_nr, new_power,
@@ -83,11 +83,11 @@
LOGP(DLOOP, LOGL_INFO, "%s MS new_power of trx=%u chan_nr=0x%02x from "
"control level %d (%d dBm) to %d (%d dBm)\n",
(diff > 0) ? "Raising" : "Lowering",
-   trx->nr, chan_nr, lchan->ms_power,
-   MS_PWR_DBM(arfcn, lchan->ms_power), new_power,
+   trx->nr, chan_nr, lchan->ms_power_ctrl.current,
+   MS_PWR_DBM(arfcn, lchan->ms_power_ctrl.current), new_power,
MS_PWR_DBM(arfcn, new_power));
 
-   lchan->ms_power = new_power;
+   lchan->ms_power_ctrl.current = new_power;
 
return 0;
 }
@@ -159,8 +159,8 @@
/* change RSSI */
LOGP(DLOOP, LOGL_DEBUG, "Lowest RSSI: %d Target RSSI: %d Current "
"MS power: %d (%d dBm) of trx=%u chan_nr=0x%02x\n", rssi,
-   trx_target_rssi, lchan->ms_power,
-   MS_PWR_DBM(trx->arfcn, lchan->ms_power),
+   trx_target_rssi, lchan->ms_power_ctrl.current,
+   MS_PWR_DBM(trx->arfcn, lchan->ms_power_ctrl.current),
trx->nr, chan_nr);
ms_power_diff(lchan, chan_nr, trx_target_rssi - rssi);
 

-- 
To view, visit https://gerrit.osmocom.org/3560
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I713e39b882db32a0d17aa04790d16fa79afa1fb1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.10/x86_64

2017-08-19 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  222s] | 
[  222s] | This file was extended by libosmocore config.status 0.9.6.20170819, 
which was
[  222s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  222s] | 
[  222s] |   CONFIG_FILES= 
[  222s] |   CONFIG_HEADERS  = 
[  222s] |   CONFIG_LINKS= 
[  222s] |   CONFIG_COMMANDS = 
[  222s] |   $ ./config.status Doxyfile.core
[  222s] | 
[  222s] | on cumulus3
[  222s] | 
[  222s] | config.status:1172: creating Doxyfile.core
[  222s] 
[  222s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  222s] make[1]: *** [override_dh_auto_test] Error 1
[  222s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  222s] debian/rules:15: recipe for target 'build' failed
[  222s] make: *** [build] Error 2
[  222s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  222s] 
[  222s] cumulus3 failed "build libosmocore_0.9.6.20170819.dsc" at Sat Aug 19 
19:54:10 UTC 2017.
[  222s] 
[  222s] ### VM INTERACTION START ###
[  224s] [  213.866756] reboot: Power down
[  224s] ### VM INTERACTION END ###
[  224s] 
[  224s] cumulus3 failed "build libosmocore_0.9.6.20170819.dsc" at Sat Aug 19 
19:54:13 UTC 2017.
[  224s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.10/x86_64

2017-08-19 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  222s] | 
[  222s] | This file was extended by libosmocore config.status 0.9.6.20170819, 
which was
[  222s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  222s] | 
[  222s] |   CONFIG_FILES= 
[  222s] |   CONFIG_HEADERS  = 
[  222s] |   CONFIG_LINKS= 
[  222s] |   CONFIG_COMMANDS = 
[  222s] |   $ ./config.status Doxyfile.core
[  222s] | 
[  222s] | on cumulus3
[  222s] | 
[  222s] | config.status:1172: creating Doxyfile.core
[  222s] 
[  222s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  222s] make[1]: *** [override_dh_auto_test] Error 1
[  222s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  222s] debian/rules:15: recipe for target 'build' failed
[  222s] make: *** [build] Error 2
[  222s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  222s] 
[  222s] cumulus3 failed "build libosmocore_0.9.6.20170819.dsc" at Sat Aug 19 
19:54:10 UTC 2017.
[  222s] 
[  222s] ### VM INTERACTION START ###
[  224s] [  213.866756] reboot: Power down
[  224s] ### VM INTERACTION END ###
[  224s] 
[  224s] cumulus3 failed "build libosmocore_0.9.6.20170819.dsc" at Sat Aug 19 
19:54:13 UTC 2017.
[  224s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

osmo-bts[master]: osmo-bts-trx: Fix MS power control loop.

2017-08-19 Thread Harald Welte


Patch Set 1:

Please also see http://osmocom.org/issues/1851 and 
http://osmocom.org/issues/1622 in this context

-- 
To view, visit https://gerrit.osmocom.org/3560
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I713e39b882db32a0d17aa04790d16fa79afa1fb1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bts[master]: osmo-bts-trx: Fix MS power control loop.

2017-08-19 Thread Harald Welte


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3560
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I713e39b882db32a0d17aa04790d16fa79afa1fb1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bts[master]: osmo-bts-trx: Remove an unused variable. Resolves a compiler...

2017-08-19 Thread Harald Welte


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/3561
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2464e872f81021cbc3ccbc4e2e32c394d6afcf70
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-bts[master]: osmo-bts-trx: Increase a maximum allowed MS power reduction ...

2017-08-19 Thread Harald Welte


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/3562/1//COMMIT_MSG
Commit Message:

Line 12: oscilation. From my (manual, limited) testing 2dB look like a 
reasonable
you mention 2dB here, but your change seems to change it from 2 to 4dB ?


-- 
To view, visit https://gerrit.osmocom.org/3562
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58785513e5739474b881ed7f2a312ecc690e7e60
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

osmo-bts[master]: osmo-bts-trx: Increase a maximum allowed MS power reduction ...

[PATCH] osmo-bts[master]: osmo-bts-trx: Increase a maximum allowed MS power reduction ...

[PATCH] osmo-bts[master]: osmo-bts-trx: Increase a maximum allowed MS power reduction ...

[MERGED] osmo-bts[master]: osmo-bts-trx: Remove an unused variable. Resolves a compiler...

osmo-bts[master]: osmo-bts-trx: Fix MS power control loop.

[MERGED] osmo-bts[master]: osmo-bts-trx: Fix MS power control loop.

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.10/x86_64

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.10/x86_64

osmo-bts[master]: osmo-bts-trx: Fix MS power control loop.

osmo-bts[master]: osmo-bts-trx: Fix MS power control loop.

osmo-bts[master]: osmo-bts-trx: Remove an unused variable. Resolves a compiler...

osmo-bts[master]: osmo-bts-trx: Increase a maximum allowed MS power reduction ...

12 matches

Site Navigation

Mail list logo

Footer information