osmo-iuh[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3688 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fc4a0ce4ca29f8b76e189d040097f3e63298ba5 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master

libosmo-sccp[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3684 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a2223b1a059fbb832948decf11f9237fad389f2 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

openggsn[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3686 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I036ed452826b9a6848d22d45bdcc95e20a110b8b Gerrit-PatchSet: 1 Gerrit-Project: openggsn Gerrit-Branch: master

osmo-bts[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3681 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bce234a5b8133c81b3ea8757e05de56d3aa15d8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

libosmo-abis[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3682 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60d480ce6fb761ac8e15318dbe2c591359a51c3c Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master

osmo-hlr[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3687 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ea5be60d2a3cf8442f58e1121b13074e2e6a08 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master

libosmo-netif[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3683 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6048a69c9e0cc15010de643330aeb2a7271b2a6 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master

[MERGED] osmo-hlr[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use value string check from osmo-ci .. Use value string check from osmo-ci Change-Id: I56ea5be60d2a3cf8442f58e1121b13074e2e6a08 --- M contrib/jenkins.sh

[MERGED] libosmo-sccp[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use value string check from osmo-ci .. Use value string check from osmo-ci Change-Id: I1a2223b1a059fbb832948decf11f9237fad389f2 --- M contrib/jenkins.sh

[MERGED] libosmo-netif[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use value string check from osmo-ci .. Use value string check from osmo-ci Change-Id: Id6048a69c9e0cc15010de643330aeb2a7271b2a6 --- M contrib/jenkins.sh

[MERGED] osmo-bts[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use value string check from osmo-ci .. Use value string check from osmo-ci Change-Id: I5bce234a5b8133c81b3ea8757e05de56d3aa15d8 --- M

[MERGED] openggsn[master]: Use value string check from osmo-ci

2017-08-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use value string check from osmo-ci .. Use value string check from osmo-ci Change-Id: I036ed452826b9a6848d22d45bdcc95e20a110b8b --- M contrib/jenkins.sh

[PATCH] openbsc[master]: Use verify_value_string_arrays_are_terminated from osmo-ci

2017-08-26 Thread Harald Welte
Review at https://gerrit.osmocom.org/3692 Use verify_value_string_arrays_are_terminated from osmo-ci verify_value_string_arrays_are_terminated has recently been moved from libosmocore.git to osmo-ci.git and the person doing this seems to have forgotten to update openbsc.git Change-Id:

[MERGED] libosmocore[master]: Update release helper

2017-08-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Update release helper .. Update release helper * add reference to semver spec * use 'patch' release by default * unify debian/changelog distro update

[PATCH] openbsc[master]: Use verify_value_string_arrays_are_terminated from osmo-ci

2017-08-26 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3692 to look at the new patch set (#4). Use verify_value_string_arrays_are_terminated from osmo-ci verify_value_string_arrays_are_terminated has recently been moved from libosmocore.git to

[PATCH] osmo-msc[master]: Use value string check from osmo-ci

2017-08-26 Thread Neels Hofmeyr
Use value string check from osmo-ci Necessary since libosmocore I513835be2d931d0a931cdfc996f361a451bc1a15 removes the script from libosmocore/contrib. Change-Id: I02d7e1c0151c687fd9341d21a09ca15cbf5a1938 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull

osmo-msc[master]: Use value string check from osmo-ci

2017-08-26 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3693 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02d7e1c0151c687fd9341d21a09ca15cbf5a1938 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] libosmocore[master]: umts aka: add sqn_ms out-param, print SQN.MS in osmo-auc-gen

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3704 umts aka: add sqn_ms out-param, print SQN.MS in osmo-auc-gen When doing UMTS AKA with AUTS, it can be interesting to know the SQN.MS that was encoded in the AUTS. The only way to know this is to provide it as a separate out-parameter from

[PATCH] libosmocore[master]: osmo-auc-gen: umts: add --ind-len arg

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3701 osmo-auc-gen: umts: add --ind-len arg osmo-auc-gen so far does not allow indicating the IND bit length of SQN. A default of 5 serves most practical cases, nevertheless we should allow passing arbitrary IND lengths. Enhance the test suite to test

[PATCH] libosmocore[master]: cosmetic: umts aka: tweak comments for sqn and ind

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3703 cosmetic: umts aka: tweak comments for sqn and ind Clearly indicate that 'sqn' is an in *and* out-parameter. Clarify the effect of 'ind'. Change-Id: Ia40cd4ddf35f4fbe895b45b8ea59378f5ce9eb1f --- M include/osmocom/crypt/auth.h 1 file changed, 2

[PATCH] libosmocore[master]: osmo-auc-gen: umts: print out the IND of the SQN used

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3702 osmo-auc-gen: umts: print out the IND of the SQN used Make ind_mask available in the main(){} scope, in order to print out IND = SQN & ind_mask. Adjust test suite expectations. Related: OS#2465 Change-Id: I91eac53c4af66a58b9372d9baf5781fc9f29b1fc ---

[PATCH] libosmocore[master]: cosmetic: test for osmo-auc-gen: print error for missing binary

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3696 cosmetic: test for osmo-auc-gen: print error for missing binary Change-Id: I98c23ae6378a16cf3b76c90d4ea0dfcf61ff3033 --- M tests/osmo-auc-gen/osmo-auc-gen_test.sh 1 file changed, 6 insertions(+), 0 deletions(-) git pull

[PATCH] libosmocore[master]: osmo-auc-gen: umts: remove erratic SQN.MS printout

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3697 osmo-auc-gen: umts: remove erratic SQN.MS printout osmo-auc-gen tries to be helpful by deriving the SQN.MS from the SQN that resulted from AUTS + milenage_gen_vec(), but there is actually no way to derive the actual AUTS SQN.MS from the resulting SQN.

[PATCH] libosmocore[master]: osmo-auc-gen: umts: use default of ind_bitlen = 5 instead of 0

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3699 osmo-auc-gen: umts: use default of ind_bitlen = 5 instead of 0 Most USIM out there seem to use IND-length = 5 bits, so do sysmousim-sjs1. Currently from initialization we are using an IND length of zero in osmo-auc-gen, which produces confusing SQN

osmo-msc[master]: Use value string check from osmo-ci

2017-08-26 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3693 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02d7e1c0151c687fd9341d21a09ca15cbf5a1938 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-msc[master]: Use value string check from osmo-ci

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3693 Use value string check from osmo-ci Change-Id: I02d7e1c0151c687fd9341d21a09ca15cbf5a1938 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/93/3693/1 diff --git

[PATCH] osmo-msc[master]: NOT FOR MERGE combined changes from openbsc.git for gerrit c...

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3695 NOT FOR MERGE combined changes from openbsc.git for gerrit checking Change-Id: Id072aa07793aceca66bd74950bc40dd504982a55 --- M configure.ac M contrib/jenkins.sh M doc/examples/osmo-bsc/osmo-bsc.cfg M include/openbsc/Makefile.am M

[PATCH] libosmocore[master]: osmo-auc-gen: umts: add --ind arg

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3700 osmo-auc-gen: umts: add --ind arg During UMTS AKA, the caller typically indicates which IND slot the next used SQN should belong to. Without this option, osmo-auc-gen will always produce SQN from IND-slot 0. Add --ind option. Enhance the

[PATCH] libosmocore[master]: osmo-auc-gen: umts: properly request --sqn

2017-08-26 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3698 osmo-auc-gen: umts: properly request --sqn The user supplied an --sqn to generate a vector for, but milenage_gen_vec() performs a nontrivial SQN increment before generating the vector. To end up with the user supplied SQN, we need to reverse this

[ABANDON] osmo-msc[master]: NOT FOR MERGE combined changes from openbsc.git for gerrit c...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: NOT FOR MERGE combined changes from openbsc.git for gerrit checking .. Abandoned -- To view, visit https://gerrit.osmocom.org/3695 To unsubscribe, visit

[MERGED] osmo-msc[master]: Use value string check from osmo-ci

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Use value string check from osmo-ci .. Use value string check from osmo-ci Necessary since libosmocore I513835be2d931d0a931cdfc996f361a451bc1a15

[MERGED] osmo-msc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling .. libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling

[MERGED] osmo-msc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: update database to accomodate SMS status-report fields .. libmsc: update database to accomodate SMS status-report fields SMPP DELIVER_SM

[MERGED] osmo-msc[master]: utils: smpp_mirror: bounce Delivery Receipts as Delivery Ack...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: utils: smpp_mirror: bounce Delivery Receipts as Delivery Acknowledgments .. utils: smpp_mirror: bounce Delivery Receipts as Delivery Acknowledgments

[MERGED] osmo-msc[master]: Migrate from gprs_apn_to_str() to libosmocore osmo_apn_to_str()

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Migrate from gprs_apn_to_str() to libosmocore osmo_apn_to_str() .. Migrate from gprs_apn_to_str() to libosmocore osmo_apn_to_str() In 2015, Jacob

[MERGED] osmo-msc[master]: Treat SIGTERM just like SIGINT in our programs

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Treat SIGTERM just like SIGINT in our programs .. Treat SIGTERM just like SIGINT in our programs When somebody kills the process, it's best to handle

[MERGED] osmo-msc[master]: gbproxy: log signal value as text

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: gbproxy: log signal value as text .. gbproxy: log signal value as text Change-Id: I6ed923f5c60a8d64305f4b8e90d1362d6510e1c5 --- M src/gprs/gb_proxy.c 1

[MERGED] osmo-msc[master]: NITB: remove 'help' output about '-a' option that is removed...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: NITB: remove 'help' output about '-a' option that is removed for ages .. NITB: remove 'help' output about '-a' option that is removed for ages This

[MERGED] osmo-msc[master]: handover_logic: set correct link to bts for subscriber_conne...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: handover_logic: set correct link to bts for subscriber_connection in case of moving this connection to another bts .. handover_logic: set correct link

[MERGED] osmo-msc[master]: libmsc: use SMPP34_DELIVERY_RECEIPT_* in libsmpp34

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: use SMPP34_DELIVERY_RECEIPT_* in libsmpp34 .. libmsc: use SMPP34_DELIVERY_RECEIPT_* in libsmpp34 Use new definitions in libsmpp34 to set the

[MERGED] osmo-msc[master]: Fix gsm_pchan2chan_nr() to use RSL_CHAN_OSMO_PDCH

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Fix gsm_pchan2chan_nr() to use RSL_CHAN_OSMO_PDCH .. Fix gsm_pchan2chan_nr() to use RSL_CHAN_OSMO_PDCH When converting from GSM_PCHAN_PDCH, we should

[MERGED] osmo-msc[master]: libmsc: gsm340_gen_oa_sub() may return negative value

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: gsm340_gen_oa_sub() may return negative value .. libmsc: gsm340_gen_oa_sub() may return negative value gsm340_gen_oa() returns a negative value

[MERGED] osmo-msc[master]: libmsc: Fix wrong handling of user_message_reference parameter

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: Fix wrong handling of user_message_reference parameter .. libmsc: Fix wrong handling of user_message_reference parameter libsmpp34 already

[MERGED] osmo-msc[master]: libcommon: Fix log output for bts>0.

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libcommon: Fix log output for bts>0. .. libcommon: Fix log output for bts>0. Fixes regression probably introduced in c696cc28. For bts>0 logging

[MERGED] osmo-msc[master]: increase libsmpp34 version requirement to 1.12

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: increase libsmpp34 version requirement to 1.12 .. increase libsmpp34 version requirement to 1.12 Only 1.12 contains some of the #defines that we're

[MERGED] osmo-msc[master]: LIBMSC: Use sms->text, not sms->user_data to construct repor...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: LIBMSC: Use sms->text, not sms->user_data to construct report body .. LIBMSC: Use sms->text, not sms->user_data to construct report body gsm_04_11.c

[MERGED] osmo-msc[master]: mgcp_osmux: Remove unused parameter

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: mgcp_osmux: Remove unused parameter .. mgcp_osmux: Remove unused parameter Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3 --- M

[MERGED] osmo-msc[master]: libmsc: remove dead code in sms_route_mt_sms()

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: remove dead code in sms_route_mt_sms() .. libmsc: remove dead code in sms_route_mt_sms() The following branch: if (!rc &&

[MERGED] osmo-msc[master]: RSL: Allow disabling of BCCH/SACCH filling for given SI type

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: RSL: Allow disabling of BCCH/SACCH filling for given SI type .. RSL: Allow disabling of BCCH/SACCH filling for given SI type If we want to instruct the

[MERGED] osmo-msc[master]: SGSN: Fix RAN information exposed on GTP during PDP CTX CREATE

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: SGSN: Fix RAN information exposed on GTP during PDP CTX CREATE .. SGSN: Fix RAN information exposed on GTP during PDP CTX CREATE In the PDP Context

[MERGED] osmo-msc[master]: libmsc: use new smpp34 esm_class definitions

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: use new smpp34 esm_class definitions .. libmsc: use new smpp34 esm_class definitions Replace magic numbers by esm_class definitions, which have

[MERGED] osmo-msc[master]: gbproxy: log unhandled BSSGP PDU as text

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: gbproxy: log unhandled BSSGP PDU as text .. gbproxy: log unhandled BSSGP PDU as text Change-Id: Ibe3c8bd353b3a178e26b0936f25b2e1959f9990c --- M

[MERGED] osmo-msc[master]: libmsc: Remove comment not applying anymore

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: Remove comment not applying anymore .. libmsc: Remove comment not applying anymore The change-id I7276d356d805a83ebeec72b02c8563b7135ea0b6

[MERGED] osmo-msc[master]: libmsc: Use actual delivery time in delivery reports.

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: Use actual delivery time in delivery reports. .. libmsc: Use actual delivery time in delivery reports. Set the time on the status report to the

[MERGED] osmo-msc[master]: sgsn_vty: Don't assume pdp->lib is always valid

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: sgsn_vty: Don't assume pdp->lib is always valid .. sgsn_vty: Don't assume pdp->lib is always valid We can only print libgtp pdp information if a

[MERGED] osmo-msc[master]: check for missing result of rate_ctr_group_alloc()

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: check for missing result of rate_ctr_group_alloc() .. check for missing result of rate_ctr_group_alloc() In case the counter group allocation fails, we

[MERGED] osmo-msc[master]: sgsn: Fill the cch_pdp with a value coming from the tlv stru...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: sgsn: Fill the cch_pdp with a value coming from the tlv structure .. sgsn: Fill the cch_pdp with a value coming from the tlv structure For some GGSNs

[MERGED] osmo-msc[master]: libmsc: remove duplicate lines in deliver_to_esme()

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: remove duplicate lines in deliver_to_esme() .. libmsc: remove duplicate lines in deliver_to_esme() This code is accidentally doing the same

[MERGED] osmo-msc[master]: Support for TS 04.14 conformance test commands

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Support for TS 04.14 conformance test commands .. Support for TS 04.14 conformance test commands Change-Id: Ib27edbfc8ccdedf00589ec715ced7bed435fa94c

[MERGED] osmo-msc[master]: Fix BTS attribute requests

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Fix BTS attribute requests .. Fix BTS attribute requests * fix BTS numbers: use 0 to indicate given BTS and 0xFF to indicate all BTS' as it's

[MERGED] osmo-msc[master]: utils: smpp_mirror: temporarily munch SMPP delivery receipts

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: utils: smpp_mirror: temporarily munch SMPP delivery receipts .. utils: smpp_mirror: temporarily munch SMPP delivery receipts Just munch and log SMPP

[MERGED] osmo-msc[master]: smpp: fix return cause

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: smpp: fix return cause .. smpp: fix return cause Return cause 38 when default SMPP route is unavailable. This is better than cause 1. Change-Id:

[MERGED] osmo-msc[master]: 04.08: find a portable way to obtain the timezone offset

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: 04.08: find a portable way to obtain the timezone offset .. 04.08: find a portable way to obtain the timezone offset Portable GMT offset calculation to

[MERGED] osmo-msc[master]: libbsc: Add VTY command to re-send the SYSTEM INFORMATION to...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libbsc: Add VTY command to re-send the SYSTEM INFORMATION to BTS .. libbsc: Add VTY command to re-send the SYSTEM INFORMATION to BTS This is useful if

[MERGED] osmo-msc[master]: bsc_api: Fix copy+paste error in printing name of RR STATUS PDU

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: bsc_api: Fix copy+paste error in printing name of RR STATUS PDU .. bsc_api: Fix copy+paste error in printing name of RR STATUS PDU Change-Id:

[MERGED] osmo-msc[master]: timer vty: also print the default value in cmd doc

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: timer vty: also print the default value in cmd doc .. timer vty: also print the default value in cmd doc Rationale: allows seeing all timer defaults at

[MERGED] osmo-msc[master]: Add VTY commands for experimentation with TS 04.14 commands

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Add VTY commands for experimentation with TS 04.14 commands .. Add VTY commands for experimentation with TS 04.14 commands TS 04.14 (TS 44.014)

[MERGED] osmo-msc[master]: LIBMSC: Place correct dst address in status report

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: LIBMSC: Place correct dst address in status report .. LIBMSC: Place correct dst address in status report gsm_04_11.c:

[MERGED] osmo-msc[master]: utils: smpp_mirror: reflect message reference TLV

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: utils: smpp_mirror: reflect message reference TLV .. utils: smpp_mirror: reflect message reference TLV Useful to test the delivery receipt support.

[MERGED] osmo-msc[master]: libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40 status report .. libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40 status

[MERGED] osmo-msc[master]: gtphob: check for missing result of rate_ctr_group_alloc()

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: gtphob: check for missing result of rate_ctr_group_alloc() .. gtphob: check for missing result of rate_ctr_group_alloc() In case the counter group

[MERGED] osmo-msc[master]: libmsc: Fix VTY output for handover counters.

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: Fix VTY output for handover counters. .. libmsc: Fix VTY output for handover counters. Handover countrs belong to BSC, but we mistakenly take

[MERGED] osmo-msc[master]: libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms()

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms() .. libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms() Move the sms

[MERGED] osmo-msc[master]: mgcp: Fix uplink activation of Osmux stream

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: mgcp: Fix uplink activation of Osmux stream .. mgcp: Fix uplink activation of Osmux stream Commit 575420637981828b64c1292ada015d7170b89390 introduced

[MERGED] osmo-msc[master]: libmsc: add support for SMPP delivery receipts

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: add support for SMPP delivery receipts .. libmsc: add support for SMPP delivery receipts If the mobile phone requests a status report via SMS,

[MERGED] osmo-msc[master]: smpp: Fix compilation warning

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: smpp: Fix compilation warning .. smpp: Fix compilation warning I already stumbled into 2 compilation environments which had Werror enabled for

[MERGED] osmo-msc[master]: bsc_vty: Don't allow timers of zero (0)

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: bsc_vty: Don't allow timers of zero (0) .. bsc_vty: Don't allow timers of zero (0) It typically doesn't make sense to configure any of the GSM RR timer

[MERGED] osmo-msc[master]: Fix regression causing loss of static system-information mes...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Fix regression causing loss of static system-information messages .. Fix regression causing loss of static system-information messages In commit

[MERGED] osmo-msc[master]: remove code disabling T3109 if configured to 0

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: remove code disabling T3109 if configured to 0 .. remove code disabling T3109 if configured to 0 We no longer permit timers with a 0 value, so this

[MERGED] osmo-msc[master]: GSM timers: User reasonable defaults; don't save if equal de...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: GSM timers: User reasonable defaults; don't save if equal default .. GSM timers: User reasonable defaults; don't save if equal default A number of the

[MERGED] osmo-msc[master]: libmsc: report status report request flag from SMPP SUBMIT_SM

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: report status report request flag from SMPP SUBMIT_SM .. libmsc: report status report request flag from SMPP SUBMIT_SM Restore the sms status

[MERGED] osmo-msc[master]: vty: add 'default' keyword to timer config

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: vty: add 'default' keyword to timer config .. vty: add 'default' keyword to timer config Change-Id: I4e837e8bedfad7ac4fd50048ecb016ddb37c2397 --- M

[MERGED] osmo-msc[master]: libmsc: support GSM 03.40 status report for nitb

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: support GSM 03.40 status report for nitb .. libmsc: support GSM 03.40 status report for nitb This patch adds support for GSM 03.40 in nitb

[MERGED] osmo-msc[master]: gsm_bts_trx_set_system_infos(): Disable non-existing SI

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: gsm_bts_trx_set_system_infos(): Disable non-existing SI .. gsm_bts_trx_set_system_infos(): Disable non-existing SI If we previously had a given SI

[MERGED] osmo-msc[master]: bsc_vty: Add VTY command to test CTRL TRAP feature

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: bsc_vty: Add VTY command to test CTRL TRAP feature .. bsc_vty: Add VTY command to test CTRL TRAP feature Using this new command (introduced in OsmoBSC

[MERGED] osmo-msc[master]: libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM messages .. libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM messages

[MERGED] osmo-msc[master]: cosmetic: vty for timers: remove obsolete range check

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: cosmetic: vty for timers: remove obsolete range check .. cosmetic: vty for timers: remove obsolete range check The VTY parsing already ensures the

[MERGED] osmo-msc[master]: libmsc: remove 'deferred' parameter in sms_route_mt_sms()

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: remove 'deferred' parameter in sms_route_mt_sms() .. libmsc: remove 'deferred' parameter in sms_route_mt_sms() No need to cache the sms object,

[MERGED] osmo-msc[master]: libmsc: do not leak pending SMPP command object on error path

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: do not leak pending SMPP command object on error path .. libmsc: do not leak pending SMPP command object on error path Make sure the SMPP

[MERGED] osmo-msc[master]: jenkins.sh: Proper error message if local environment isn't ...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins.sh: Proper error message if local environment isn't set up .. jenkins.sh: Proper error message if local environment isn't set up Change-Id:

[MERGED] osmo-msc[master]: utils: smpp_mirror: set registered_delivery field in SMPP SU...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: utils: smpp_mirror: set registered_delivery field in SMPP SUBMIT_SM .. utils: smpp_mirror: set registered_delivery field in SMPP SUBMIT_SM To test

[MERGED] osmo-msc[master]: smpp_smsc.c: Log on sending deliver_sm message

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: smpp_smsc.c: Log on sending deliver_sm message .. smpp_smsc.c: Log on sending deliver_sm message Change-Id: Ie16294df6d5bc0065f8d2b49320ead61f535f271

[MERGED] osmo-msc[master]: gsm_04_11: get rid of unused parameter in sms_route_mt_sms()

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: gsm_04_11: get rid of unused parameter in sms_route_mt_sms() .. gsm_04_11: get rid of unused parameter in sms_route_mt_sms() This parameter is unused,

[MERGED] osmo-msc[master]: libmsc: missing bit shift in status report flag when stored ...

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: libmsc: missing bit shift in status report flag when stored in sms object .. libmsc: missing bit shift in status report flag when stored in sms object

[MERGED] osmo-msc[master]: sgsn: Convert cch_pdp to host order for libgtp

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: sgsn: Convert cch_pdp to host order for libgtp .. sgsn: Convert cch_pdp to host order for libgtp libgtp is calling gtpie_tv2 which will convert this

[MERGED] osmo-msc[master]: sgsn_test: Fix wrong definition of wrap func

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: sgsn_test: Fix wrong definition of wrap func .. sgsn_test: Fix wrong definition of wrap func Commit 058cd573d8 added 2 new pointer parameters to

[MERGED] osmo-msc[master]: transaction: reject calls from unidentified subscribers

2017-08-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: transaction: reject calls from unidentified subscribers .. transaction: reject calls from unidentified subscribers A valid subscriber is indespensible

[PATCH] osmo-msc[master]: Implement AoIP, port to M3UA SIGTRAN (large addition and ref...

2017-08-26 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3486 to look at the new patch set (#5). Implement AoIP, port to M3UA SIGTRAN (large addition and refactoring) This was originally a long series of commits converging to the final result

[PATCH] osmo-msc[master]: move libiu to osmo-iuh/libosmo-ranap

2017-08-26 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3489 to look at the new patch set (#4). move libiu to osmo-iuh/libosmo-ranap Remove libiu here, use the functions from libosmo-ranap instead, by applying the ranap_ / RANAP_

[PATCH] osmo-msc[master]: replace internal libmgcp with libosmo-legacy-mgcp

2017-08-26 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3492 to look at the new patch set (#4). replace internal libmgcp with libosmo-legacy-mgcp Change-Id: Ic99d681759edce11564da62500c2aac5cf5fffe2 --- M configure.ac M

  1   2   >