[MERGED] openbsc[master]: mgcp_protocol: Don't print osmux stats if it is off

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mgcp_protocol: Don't print osmux stats if it is off .. mgcp_protocol: Don't print osmux stats if it is off Otherwise we get Osmux stats during a session

openbsc[master]: mgcp_protocol: Don't print osmux stats if it is off

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6599 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I814b2051edc85ad5cbd04c96b785c208f6606683 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: bsc-nat: Enable octet-aligned when ensuring mode set

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6598 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4db7f6d18f650f36f3186965096771f748de5fd Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: HO: vty: clearly mark 'handover foo' as legacy alias for 'ha...

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: vty: clearly mark 'handover foo' as legacy alias for 'handover1 foo' .. HO: vty: clearly mark 'handover foo' as legacy alias for 'handover1 foo'

osmo-bsc[master]: HO: vty: clearly mark 'handover foo' as legacy alias for 'ha...

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6601 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86be674d82242f9ca73a4d0040015c1c79f2422d Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

libosmocore[master]: Support for more cell ID list types in libosmocore.

2018-02-19 Thread Harald Welte
Patch Set 4: The concept oft lac/RAC/Rai/cid/CGI is mich More generic than 08.08. We should use some generic type to represent one such identity -- To view, visit https://gerrit.osmocom.org/6509 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-msc[master]: VLR tests: add function to generate ID RESP

2018-02-19 Thread Harald Welte
Patch Set 1: Does it really make sense to improve the capabilities of the unit treats here? Why not simply add more / future tests to ttcn3? -- To view, visit https://gerrit.osmocom.org/6460 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-pcu[master]: Use explicit type for pcu_lsb()

2018-02-19 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6105 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0bef691e17e4331c7c4b491661e36173d85388a Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[MERGED] osmo-pcu[master]: Use explicit type for pcu_lsb()

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use explicit type for pcu_lsb() .. Use explicit type for pcu_lsb() It's only used for byte-long input so we can specify input and output types

[PATCH] osmo-bsc[master]: Permit set of multiple different A5 ciphers

2018-02-19 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6544 to look at the new patch set (#4). Permit set of multiple different A5 ciphers So far, the administrator had to pick one particular cipher which would then be used

osmo-bsc[master]: Structural reform: Get rid of osmo_bsc_sccp_con

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6542 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd2b733477ee90d24dec369755a00f1c39c93f39 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: Structural reform: Get rid of osmo_bsc_sccp_con

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Structural reform: Get rid of osmo_bsc_sccp_con .. Structural reform: Get rid of osmo_bsc_sccp_con There was always a 1:1 correspondence between

osmo-bsc[master]: logging: Remove obsolete log categories

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6543 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b39429f71c0faefdf8158a82093cfb19f44809e Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: Permit set of multiple different A5 ciphers

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6544 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d1c8131855bcab2392b4f27f6216bdb2fae10e0 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-pcu[master]: Update header includes

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Update header includes .. Update header includes Many files include unnecessary headers and don't include headers which are actually used. Because of

[MERGED] osmo-pcu[master]: Move paging generation into PDCH

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Move paging generation into PDCH .. Move paging generation into PDCH Previously paging was prepared inside BTS function and than handed over to PDCH

[MERGED] osmo-pcu[master]: Move include guard to the top

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Move include guard to the top .. Move include guard to the top Having explicit include above the douible-include guard defines is potential source for

osmo-ttcn3-hacks[master]: Add tests for OS#2714, "close RSL connections from unknown U...

2018-02-19 Thread Harald Welte
Patch Set 3: You wrote "fixed" but I don't see that next patch yet? -- To view, visit https://gerrit.osmocom.org/6406 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a947d7411a016e4d7650031396cae3575756453 Gerrit-PatchSet: 3

osmo-pcu[master]: Simplify TS alloc: split USF/UL allocation

2018-02-19 Thread Harald Welte
Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3930 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I563dc10827ce68295553f88f3bf2e1fc0ba595c1 Gerrit-PatchSet: 12 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Simplify TS alloc: separate capacity computation

2018-02-19 Thread Harald Welte
Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3934 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd88fc7ff818ea2a041eae61c5d457926a0df0f2 Gerrit-PatchSet: 11 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Simplify TS alloc: split allocation

2018-02-19 Thread Harald Welte
Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3906 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied45ae380c345bc76fe9d6fd9a6184d1109f83f2 Gerrit-PatchSet: 17 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[MERGED] osmocom-bb[jolly/testing]: build: Fix typo in the CFLAGS-variable for libosmodsp

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: build: Fix typo in the CFLAGS-variable for libosmodsp .. build: Fix typo in the CFLAGS-variable for libosmodsp Change-Id:

[MERGED] osmo-mgw[master]: osmo-mgw: Add talloc context introspection via VTY

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-mgw: Add talloc context introspection via VTY .. osmo-mgw: Add talloc context introspection via VTY This requires libosmocore with Change-Id

libosmocore[master]: fsm: allow graceful exit on FSM termination

2018-02-19 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6452 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fdda9fe994753f975a658c0f3fb3615949cc8bb Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-msc[master]: libmsc: Pretend MNCC requested release in handle_error()

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6505 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7669d29cf5be3e4a60a1d121edbfcf9056f6d82b Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmocom-bb[jolly/testing]: build: Fix typo in the CFLAGS-variable for libosmodsp

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6364 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida258588538a8a76d97a8c1e8855b2fd28c63be7 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

[MERGED] osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: transceiver: Fix RSP SETSLOT format .. transceiver: Fix RSP SETSLOT format According to osmo-trx README: SETSLOT sets the format of the uplink timeslots

osmocom-bb[sylvain/testing]: transceiver: Fix RSP SETSLOT format

2018-02-19 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/6457 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

[MERGED] osmocom-bb[sylvain/testing]: transceiver: Fix RSP SETSLOT format

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: transceiver: Fix RSP SETSLOT format .. transceiver: Fix RSP SETSLOT format According to osmo-trx README: SETSLOT sets the format of the uplink timeslots

osmo-pcu[master]: Move include guard to the top

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6195 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5114a63ce00b03c8eed23565d52969250bd505cc Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Move paging generation into PDCH

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6193 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I389fb16b6e54040770c21f88edbcb8e045636928 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Update header includes

2018-02-19 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6100 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c9f488a43b099c72b2d30d3245e7ba50872fc00 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Move PDCH-related functions into separate files

2018-02-19 Thread Harald Welte
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6053 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie05e25361e6741a81b024679f9675c98d4923683 Gerrit-PatchSet: 5 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Simplify TS alloc: split off RX mask computation

2018-02-19 Thread Harald Welte
Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3913 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I731726a096bba7ee97499e5cbe3e7401869d7392 Gerrit-PatchSet: 13 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Simplify TS alloc: constify max dl slot func

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6224 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic90930d98560459eab0054cb9e1625cb99db61c8 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Simplify TS alloc: don't use PDCH for free TFI

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6223 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie154866900453d232a890f7b9a30911b451525a1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-bsc[master]: HO: cfg: separate hodec1 from hodec2 parameters

2018-02-19 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6471 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6475b2543b18d21710a6d774b214cb484f36ec8e Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: vty: Permit codec-list containing both full-rate and half-ra...

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6419 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0822f57c41cedeeb7f069be540f3a851752a23 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: vty: Permit codec-list containing both full-rate and half-ra...

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: Permit codec-list containing both full-rate and half-rate codecs .. vty: Permit codec-list containing both full-rate and half-rate codecs Once

[MERGED] gapk[master]: Ignore build products

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Ignore build products .. Ignore build products Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 --- M .gitignore 1 file changed, 3 insertions(+), 0

gapk[master]: Ignore build products

2018-02-19 Thread Harald Welte
Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6383 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 Gerrit-PatchSet: 3 Gerrit-Project: gapk Gerrit-Branch:

osmo-ttcn3-hacks[master]: Ignore symlinks and build byproducts

2018-02-19 Thread Harald Welte
Patch Set 3: Sorry, this is clearly not the right approach. -- To view, visit https://gerrit.osmocom.org/6285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91 Gerrit-PatchSet: 3 Gerrit-Project:

osmo-pcu[master]: Remove ASAN preprocessor warning

2018-02-19 Thread Harald Welte
Patch Set 3: Why is this needed? Free on NULL is well defined and permitted -- To view, visit https://gerrit.osmocom.org/6001 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaabb4203a282be6779d7ab29de3f827b0ca6462 Gerrit-PatchSet: 3

osmo-msc[master]: VLR: fix potential NULL dereference

2018-02-19 Thread Harald Welte
Patch Set 1: Heels? -- To view, visit https://gerrit.osmocom.org/6388 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-bts[master]: Cosmetic fixes for power ramping code.

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Cosmetic fixes for power ramping code. .. Cosmetic fixes for power ramping code. Fix typos in 2 comments. Change-Id:

osmo-pcu[master]: Simplify TS alloc: move slot assignment

2018-02-19 Thread Harald Welte
Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3905 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64cf78c5cfc78664766f9769dd5cde632dab92b0 Gerrit-PatchSet: 15 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[PATCH] osmo-bsc[master]: SIGTRAN: correct wrong log category

2018-02-19 Thread dexter
Review at https://gerrit.osmocom.org/6588 SIGTRAN: correct wrong log category osmo_bsc_sigtran.c uses DRANAP instead of DMSC in two places, this is not correct. - change wrong DRANAP to DMSC Change-Id: I1594d1906cf7d053d00fff52e9dc0ddfd097ed6e --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file

pysim[master]: transport/serial: Fix serial transport

2018-02-19 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/6573 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fcc97d505a5369f9f14d4a2abda92b7114a58cd Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch: master

[MERGED] pysim[master]: transport/serial: Fix serial transport

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: transport/serial: Fix serial transport .. transport/serial: Fix serial transport Fix a typo that broke the serial transport. Change-Id:

osmo-msc[master]: libmsc: Close connection after sending a service reject

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+1 Do we have any tests for this yet? -- To view, visit https://gerrit.osmocom.org/6503 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfa39fdbe5bb764f8ea2bbf8c5442e15e01cadbb Gerrit-PatchSet: 2 Gerrit-Project:

osmo-msc[master]: libmsc: Bump conn FSM on trans_free()

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6504 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I131313aa326dd01b3e81e1ade18a4afd32385c15 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmocore[master]: contrib/jenkins_arch.sh: Fix script comparison and arm support

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6480 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic53a675963cae328b296b4abaed9524451153271 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: contrib/jenkins_arch.sh: Fix script comparison and arm support

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: contrib/jenkins_arch.sh: Fix script comparison and arm support .. contrib/jenkins_arch.sh: Fix script comparison and arm support Change-Id:

osmo-pcu[master]: Simplify TS alloc: move slot check into functions

2018-02-19 Thread Harald Welte
Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3935 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic39e848da47dc11357782362fdf6206d2c1457c2 Gerrit-PatchSet: 11 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: Simplify TS alloc: replace debug printer

2018-02-19 Thread Harald Welte
Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3929 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia13855877b2145cb57b1646f5562b2af3b87bcfb Gerrit-PatchSet: 13 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-bsc[master]: HO: vty: rename ho decision 1 vty to 'handover1' with 'hando...

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6500 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7305ae7c04cc70082cd80d42b2ba32ffa399f51a Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: cosmetic: adjust copyrights on handover_cfg.c, _vty.c

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6521 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3856cf34d85d6354510a94960fe5ce810c10bc7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: HO: Implement load based handover, as handover_decision_2.c

2018-02-19 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6499 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie597eae82722baf32546331e443dd9d94f1f25e6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bts[master]: rsl: do not allow MODE MODIFY request with unsupp. codec/rate

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: rsl: do not allow MODE MODIFY request with unsupp. codec/rate .. rsl: do not allow MODE MODIFY request with unsupp. codec/rate When the BSC sends a MODE

osmo-bts[master]: rsl: do not allow MODE MODIFY request with unsupp. codec/rate

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6097 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9b222b7ab19ece90591718bc562b3a8c5e02023 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-msc[master]: VLR: fix potential NULL dereference

2018-02-19 Thread Harald Welte
Harald Welte has restored this change. Change subject: VLR: fix potential NULL dereference .. Restored Wrong abandon -- To view, visit https://gerrit.osmocom.org/6388 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmo-msc[master]: VLR: fix potential NULL dereference

2018-02-19 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: VLR: fix potential NULL dereference .. Abandoned Please don't spend time on tghis -- To view, visit https://gerrit.osmocom.org/6388 To unsubscribe, visit

[MERGED] osmo-pcu[master]: Simplify TS alloc: split USF/UL allocation

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Simplify TS alloc: split USF/UL allocation .. Simplify TS alloc: split USF/UL allocation * move USF allocation into separate function * document USF

[MERGED] osmo-pcu[master]: Simplify TS alloc: split off RX mask computation

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Simplify TS alloc: split off RX mask computation .. Simplify TS alloc: split off RX mask computation Move computation of RX mask into separate function

[MERGED] osmo-pcu[master]: Simplify TS alloc: split allocation

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Simplify TS alloc: split allocation .. Simplify TS alloc: split allocation * generalize TS allocation and move it into separate function * move

osmo-pcu[master]: TS alloc: expand tests log

2018-02-19 Thread Harald Welte
Patch Set 25: Please avoid the single/multi and up/DL in every log statement and rather use an inline function ior the like -- To view, visit https://gerrit.osmocom.org/3895 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-pcu[master]: Simplify TS alloc: separate capacity computation

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Simplify TS alloc: separate capacity computation .. Simplify TS alloc: separate capacity computation Move TRX capacity computation into separate

[PATCH] osmo-ttcn3-hacks[master]: Add tests for OS#2714, "close RSL connections from unknown U...

2018-02-19 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6406 to look at the new patch set (#4). Add tests for OS#2714, "close RSL connections from unknown Unit ID". This adds two new tests: One for RSL, and a second one which performs the same

osmo-bsc[master]: Permit set of multiple different A5 ciphers

2018-02-19 Thread Harald Welte
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6544 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d1c8131855bcab2392b4f27f6216bdb2fae10e0 Gerrit-PatchSet: 5 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: SIGTRAN: correct wrong log category

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6588 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1594d1906cf7d053d00fff52e9dc0ddfd097ed6e Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-msc[master]: libmsc: Pretend MNCC requested release in handle_error()

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libmsc: Pretend MNCC requested release in handle_error() .. libmsc: Pretend MNCC requested release in handle_error() Send a release request to the MS so

[PATCH] osmo-bsc[master]: bssmap_handle_assignm_req(): Don't print log statemens in ma...

2018-02-19 Thread dexter
Review at https://gerrit.osmocom.org/6591 bssmap_handle_assignm_req(): Don't print log statemens in malloc failure case Change-Id: I85528689b5298a13c60ae80fabd8d66459f730a9 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 1 insertion(+), 4 deletions(-) git pull

[MERGED] osmo-ttcn3-hacks[master]: Add tests for OS#2714, "close RSL connections from unknown U...

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add tests for OS#2714, "close RSL connections from unknown Unit ID". .. Add tests for OS#2714, "close RSL connections from unknown Unit ID". This adds

osmo-ttcn3-hacks[master]: Add tests for OS#2714, "close RSL connections from unknown U...

2018-02-19 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6406 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a947d7411a016e4d7650031396cae3575756453 Gerrit-PatchSet: 6 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-bts[master]: sysmo+lc15: Add missign include for readv/writev

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sysmo+lc15: Add missign include for readv/writev .. sysmo+lc15: Add missign include for readv/writev This avoids compiler warnings like this:

osmo-bts[master]: trx: make l1if_fill_meas_res() static

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6597 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If988a7679f3a9253fab1a4d177a276d8ecaf794f Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: sysmo+lc15: Add missign include for readv/writev

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6596 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic67d369a3ca33bfa636ace9f272f1c7257de86e1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: sysmo: Fix compiler warnings in eeprom.c

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sysmo: Fix compiler warnings in eeprom.c .. sysmo: Fix compiler warnings in eeprom.c This avoids compiler warnings like

osmo-bts[master]: sysmo: Fix compiler warnings in eeprom.c

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6595 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic748038e6f25ec18ccb4a2f2503ca567fb00a586 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bsc[master]: Add support for Access Control Class ramping.

2018-02-19 Thread Stefan Sperling
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6324 to look at the new patch set (#7). Add support for Access Control Class ramping. Access Control Class (ACC) ramping is used to slowly make the cell available to an

[PATCH] osmo-ttcn3-hacks[master]: Add tests for OS#2714, "close RSL connections from unknown U...

2018-02-19 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6406 to look at the new patch set (#6). Add tests for OS#2714, "close RSL connections from unknown Unit ID". This adds two new tests: One for RSL, and a second one which performs the same

[PATCH] osmo-bsc[master]: chan_compat_with_mode: signalling works over all channel types

2018-02-19 Thread dexter
Review at https://gerrit.osmocom.org/6592 chan_compat_with_mode: signalling works over all channel types chan_compat_with_mode() currently only considered the requirements of voice/csd services. It failed to realize that GSM48_CMODE_SIGN can also be performed over a SDCCH, resulting in

osmo-ttcn3-hacks[master]: Add tests for OS#2714, "close RSL connections from unknown U...

2018-02-19 Thread Stefan Sperling
Patch Set 4: > You wrote "fixed" but I don't see that next patch yet? It seems I somehow forgot to push this patchset to gerrit. Sorry about that. I've just pushed it. -- To view, visit https://gerrit.osmocom.org/6406 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-bsc[master]: Align syntax of "handover" + "assignment" command with that...

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+1 @neels (or others): Do you think we should install an alias for backwards compatibility? I think it's not worth it. It's not a config node (i.e. no old config files relevant) and only a debugging command anyway... -- To view, visit https://gerrit.osmocom.org/6593

[PATCH] osmo-bsc[master]: Permit set of multiple different A5 ciphers

2018-02-19 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6544 to look at the new patch set (#5). Permit set of multiple different A5 ciphers So far, the administrator had to pick one particular cipher which would then be used

[PATCH] osmo-bsc[master]: Align syntax of "handover" + "assignment" command with that...

2018-02-19 Thread dexter
Review at https://gerrit.osmocom.org/6593 Align syntax of "handover" + "assignment" command with that of lchan act/deact We already have other commands that operate on a given bts/trx/ts/ss, let's make sure they have a shared/common syntax for consistency. This also fixes the issue that the

[PATCH] osmo-bsc[master]: bsc_vty: Merge more VTY documentation string #defines

2018-02-19 Thread dexter
Review at https://gerrit.osmocom.org/6594 bsc_vty: Merge more VTY documentation string #defines Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f --- M src/libbsc/bsc_vty.c 1 file changed, 13 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc

[MERGED] osmo-bsc[master]: SIGTRAN: correct wrong log category

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: SIGTRAN: correct wrong log category .. SIGTRAN: correct wrong log category osmo_bsc_sigtran.c uses DRANAP instead of DMSC in two places, this is not

osmo-bsc[master]: bsc_vty: Merge more VTY documentation string #defines

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6594 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: Permit set of multiple different A5 ciphers

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Permit set of multiple different A5 ciphers .. Permit set of multiple different A5 ciphers So far, the administrator had to pick one particular cipher

[MERGED] osmo-bsc[master]: logging: Remove obsolete log categories

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: logging: Remove obsolete log categories .. logging: Remove obsolete log categories About half of our log categories/subsystems were inherited from

[MERGED] osmo-bsc[master]: bssmap_handle_assignm_req(): Don't print log statemens in ma...

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bssmap_handle_assignm_req(): Don't print log statemens in malloc failure case .. bssmap_handle_assignm_req(): Don't print log statemens in malloc

osmo-bsc[master]: chan_compat_with_mode: signalling works over all channel types

2018-02-19 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6592 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ffcbd32ccd2617c897edb3b904f56bacd0684f Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: bssmap_handle_assignm_req(): Use more conscise error/log mes...

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bssmap_handle_assignm_req(): Use more conscise error/log message texts .. bssmap_handle_assignm_req(): Use more conscise error/log message texts

[MERGED] osmo-bsc[master]: bssmap_handle_assignm_req(): Use proper cause values

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bssmap_handle_assignm_req(): Use proper cause values .. bssmap_handle_assignm_req(): Use proper cause values The BSSMAP Cause value should give a clear

[MERGED] osmo-bsc[master]: chan_compat_with_mode: signalling works over all channel types

2018-02-19 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: chan_compat_with_mode: signalling works over all channel types .. chan_compat_with_mode: signalling works over all channel types chan_compat_with_mode()

libosmocore[master]: Support for more cell ID list types in libosmocore.

2018-02-19 Thread Stefan Sperling
Patch Set 4: > > The concept oft lac/RAC/Rai/cid/CGI is mich More generic than > > 08.08. We should use some generic type to represent one such > > identity > > In gsm23003.h we alreay have various structures that could be > re-used, I presume? Two of them can be used: osmo_cell_global_id

libosmocore[master]: Support for more cell ID list types in libosmocore.

2018-02-19 Thread Harald Welte
Patch Set 4: > The concept oft lac/RAC/Rai/cid/CGI is mich More generic than > 08.08. We should use some generic type to represent one such > identity In gsm23003.h we alreay have various structures that could be re-used, I presume? -- To view, visit https://gerrit.osmocom.org/6509 To

[PATCH] osmo-bts[master]: sysmo+lc15: Add missign include for readv/writev

2018-02-19 Thread Harald Welte
Review at https://gerrit.osmocom.org/6596 sysmo+lc15: Add missign include for readv/writev This avoids compiler warnings like this: ../../src/osmo-bts-sysmo/l1_transp_hw.c:130:13: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]

[PATCH] osmo-bts[master]: trx: make l1if_fill_meas_res() static

2018-02-19 Thread Harald Welte
Review at https://gerrit.osmocom.org/6597 trx: make l1if_fill_meas_res() static it's not used anywhere outside of l1_if.c, so make it a static function Change-Id: If988a7679f3a9253fab1a4d177a276d8ecaf794f --- M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/l1_if.h 2 files changed, 1

  1   2   >