osmo-bsc[master]: HO: fix minor issues found by coverity

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6630 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68e8ed3a1e8659edb47ac3e8a10508f17a3f5670 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bts[master]: vty: display bts features in vty command show bts

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: display bts features in vty command show bts .. vty: display bts features in vty command show bts The VTY command show bts does not display the bts

osmo-mgw[master]: mgcp_client: detect SDP section-start parsing errors

2018-02-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6640 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62a2453cd9e2e7d5408423161fa65ec9c9989f98 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[MERGED] osmo-bsc[master]: HO: fix minor issues found by coverity

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: fix minor issues found by coverity .. HO: fix minor issues found by coverity handover_decision_2: - lchan->conn should never be NULL, but if it is,

[MERGED] libosmo-sccp[master]: contrib: jenkins.sh: Disable doxygen in libosmocore build

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: contrib: jenkins.sh: Disable doxygen in libosmocore build .. contrib: jenkins.sh: Disable doxygen in libosmocore build Change-Id:

osmo-sip-connector[master]: contrib: jenkins.sh: Disable doxygen in libosmocore build

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6625 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7befa0cb4e72a6ad086e3c2d290546dbf22f1676 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sip-connector Gerrit-Branch:

libosmocore[master]: introduce GSM_MCC_MNC_INVALID

2018-02-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6664 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieee7add0bd6d94cf84743a49794bbcd38561b72f Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-mgw[master]: mgcp_client: cosmetic: clean up SDP params parsing

2018-02-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6639 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf1df761270777a142bc8ace75f2a10918314f73 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-bts[master]: octphy: ensure all BTS models set features

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6642 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26765a64153368016921c2ac115b1c4aec9bc5e4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: bts: use feature list instead of speech codec table

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: use feature list instead of speech codec table .. bts: use feature list instead of speech codec table osmo-bts has a table of pchan/channel mode

osmo-bts[master]: vty: display bts features in vty command show bts

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6643 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I509f2a7bbfa96c70bdfea4ff2488ee371e914620 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] libosmocore[master]: ports.h: Add VTY and CTRL ports for osmo-trx

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ports.h: Add VTY and CTRL ports for osmo-trx .. ports.h: Add VTY and CTRL ports for osmo-trx Change-Id: Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9 --- M

libosmocore[master]: ports.h: Add VTY and CTRL ports for osmo-trx

2018-02-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6623 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmo-abis[master]: contrib: jenkins.sh: Disable doxygen in libosmocore build

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6622 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52fc3931ef072075561858bb7173f58a8503e499 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master

[MERGED] osmo-sip-connector[master]: contrib: jenkins.sh: Disable doxygen in libosmocore build

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: contrib: jenkins.sh: Disable doxygen in libosmocore build .. contrib: jenkins.sh: Disable doxygen in libosmocore build Change-Id:

[MERGED] osmo-iuh[master]: contrib: jenkins.sh: Disable doxygen in libosmocore build

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: contrib: jenkins.sh: Disable doxygen in libosmocore build .. contrib: jenkins.sh: Disable doxygen in libosmocore build Change-Id:

libosmo-sccp[master]: contrib: jenkins.sh: Disable doxygen in libosmocore build

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6621 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7abc8862a63d448408ae43802da689fe436a0ff0 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

osmo-iuh[master]: contrib: jenkins.sh: Disable doxygen in libosmocore build

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6624 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12d995c0c993483ed940fc173904d6e686fbe0ab Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master

osmo-trx[master]: vty: Implement VTY cfg parsing for current parameters

2018-02-22 Thread Harald Welte
Patch Set 1: I think the test related config items should be more visibly test related? -- To view, visit https://gerrit.osmocom.org/6650 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie084c1b30b63f91c6e7640832ec1797d9e813832

[PATCH] osmo-msc[master]: mcgp: let the MGW allocate the MGCP endpoint

2018-02-22 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6319 to look at the new patch set (#2). mcgp: let the MGW allocate the MGCP endpoint osmo-msc still uses endpoints that are allocated locally by the MGCP-Client. Since osmo-mgw now supports

[PATCH] osmo-bts[master]: osmo-bts-virtual: Shut down gracefully on socket creation fa...

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6674 osmo-bts-virtual: Shut down gracefully on socket creation failure Don't simply crash if creation of the multicast socket fails Change-Id: Ie87b6684b3aa7f21742e4cf21533e980485c1230 --- M src/osmo-bts-virtual/l1_if.c M src/osmo-bts-virtual/virtual_um.c

[PATCH] osmo-msc[master]: msc_mgcp: use more conceise error msg on truncation

2018-02-22 Thread dexter
Review at https://gerrit.osmocom.org/6673 msc_mgcp: use more conceise error msg on truncation When a truncation check (osmo_strlcpy()) fails handle_error() is called with MGCP_ERR_NOMEM as cause code. Which finally results in an "out of memory" message. MGCP_ERR_NOMEM is only used for failed

[PATCH] osmo-bts[master]: osmo-bts-virtual: Generate PRIM_INFO_MEAS (with bogus values)

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6675 osmo-bts-virtual: Generate PRIM_INFO_MEAS (with bogus values) The problem is that measurement processing above L1SAP requires/expects those PRIM_INFO_MEAS indications from the bts specific parts. Otherwise it will never generate even uplink-only

[PATCH] osmo-bts[master]: osmo-bts-virtual: Make use of LOGL1S() macro for context

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6677 osmo-bts-virtual: Make use of LOGL1S() macro for context In Change-Id I5703b46c8a59fe00a3cdc063bcf72872980ec5e5 we introduced LOGL1S and starte to use in in common/scheduler.c as well as osmo-bts-trx but somehow we didn't introduce it in

osmo-bts[master]: osmo-bts-virtual: Shut down gracefully on socket creation fa...

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6674 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie87b6684b3aa7f21742e4cf21533e980485c1230 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: osmo-bts-virtual: Generate PRIM_INFO_MEAS (with bogus values)

2018-02-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6675 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48f73293cb4f0ab4c657dfd00e7ddd032a3c030f Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-trx[master]: vty: Implement VTY cfg parsing for current parameters

2018-02-22 Thread Pau Espin Pedrol
Patch Set 1: > I think the test related config items should be more visibly test > related? Sorry I don't get what you mean here, can you elaborate a bit more? -- To view, visit https://gerrit.osmocom.org/6650 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

[PATCH] osmo-bts[master]: Introduce + use LOG/DEBUGP with frame number prefixing/printing

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6676 Introduce + use LOG/DEBUGP with frame number prefixing/printing Let's make sure whenever we do have a frame number, we print it as context in the related log line Change-Id: I751d5ddb3322fce489bc241459738cbcc55c890b --- M include/osmo-bts/logging.h M

[MERGED] osmo-bts[master]: osmo-bts-virtual: Shut down gracefully on socket creation fa...

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bts-virtual: Shut down gracefully on socket creation failure .. osmo-bts-virtual: Shut down gracefully on socket creation failure Don't simply

[PATCH] osmocom-bb[fixeria/trx]: remove gsm48_encode_classmark1() which is now in libosmocore

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6679 remove gsm48_encode_classmark1() which is now in libosmocore libosmocore since I78f6968edaa3ed535673411fb2a80060a472290f has this function, no need to have a local copy here. Change-Id: I3f7c83ad0624839ce42864c70396a4397b21f514 --- M

[PATCH] libosmocore[master]: gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-dig...

2018-02-22 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6663 to look at the new patch set (#3). gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-digit MNC gsm48_mnc_from_str() preserves leading zeros in the string and is useful for VTY

[PATCH] osmo-bts[master]: osmo-bts-virtual: Make sure PRIM_INFO_MEAS have non-zero fra...

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6678 osmo-bts-virtual: Make sure PRIM_INFO_MEAS have non-zero frame number Measurement reports fed into L1SAP so far had their frame number always set to zero, resulting in higher-layer common code aboe L1SAP to never detect the end of the measurement

osmo-bsc[master]: use gsm48_ra_id instead of buf

2018-02-22 Thread Neels Hofmeyr
Patch Set 1: > Would be also great to have a minimalistic commit description, > i.e. where do we use gsm48_ra_id and why? indeed. I usually write and arrange a bunch of patches and populate the commit log later. This time I missed a few commit logs it seems. -- To view, visit

[PATCH] osmo-bsc[master]: abis_nm / ipa_nanobts_omlattr: use gsm48_ra_id instead of buf

2018-02-22 Thread Neels Hofmeyr
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6667 to look at the new patch set (#2). abis_nm / ipa_nanobts_omlattr: use gsm48_ra_id instead of buf Move from using deprecated gsm48_construct_ra(), which uses a buf, to

osmo-bsc[master]: abis_nm / ipa_nanobts_omlattr: use gsm48_ra_id instead of buf

2018-02-22 Thread Vadim Yanitskiy
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6667 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d3908fb8ca1e2e669d257b5d59b40675fa85d06 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] libosmo-abis[master]: contrib: jenkins.sh: Disable doxygen in libosmocore build

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: contrib: jenkins.sh: Disable doxygen in libosmocore build .. contrib: jenkins.sh: Disable doxygen in libosmocore build Change-Id:

[PATCH] osmo-bts[master]: Introduce + use LOG/DEBUGP with frame number prefixing/printing

2018-02-22 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6676 to look at the new patch set (#2). Introduce + use LOG/DEBUGP with frame number prefixing/printing Let's make sure whenever we do have a frame number, we print it as context in the

osmo-iuh[master]: ensure unique CellIDs in HNB-GW

2018-02-22 Thread Stefan Sperling
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6602/1/src/hnbgw_hnbap.c File src/hnbgw_hnbap.c: Line 430: talloc_free(name); > At this point I ask myself: who is deallocating a rejected hnb_context? As Good question. It seems that the hnb context should live as

osmo-iuh[master]: ensure unique CellIDs in HNB-GW

2018-02-22 Thread Stefan Sperling
Patch Set 1: Do we need a new callback which gets invoked by osmo_stream_srv_write() when it finds that the tx queue is empty? -- To view, visit https://gerrit.osmocom.org/6602 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-bts[master]: Introduce + use LOG/DEBUGP with frame number prefixing/printing

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Introduce + use LOG/DEBUGP with frame number prefixing/printing .. Introduce + use LOG/DEBUGP with frame number prefixing/printing Let's make sure

osmo-bts[master]: Introduce + use LOG/DEBUGP with frame number prefixing/printing

2018-02-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6676 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I751d5ddb3322fce489bc241459738cbcc55c890b Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: osmo-bts-virtual: Make use of LOGL1S() macro for context

2018-02-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6677 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b5fd3b7982b9119becda844531108f64c68d19f Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: osmo-bts-virtual: Make use of LOGL1S() macro for context

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bts-virtual: Make use of LOGL1S() macro for context .. osmo-bts-virtual: Make use of LOGL1S() macro for context In Change-Id

osmo-iuh[master]: ensure unique CellIDs in HNB-GW

2018-02-22 Thread Harald Welte
Patch Set 1: argh. stupid tablets with unusable sccreen keyboard: "ACK to all of Neels Comments" -- To view, visit https://gerrit.osmocom.org/6602 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd441eb2b6b75dfbe001b49b01bea015ca6e11c

[MERGED] osmo-bts[master]: osmo-bts-virtual: Generate PRIM_INFO_MEAS (with bogus values)

2018-02-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bts-virtual: Generate PRIM_INFO_MEAS (with bogus values) .. osmo-bts-virtual: Generate PRIM_INFO_MEAS (with bogus values) The problem is that

[PATCH] osmocom-bb[master]: host/trxcon/scheduler: process frames in advance

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6790 host/trxcon/scheduler: process frames in advance In order to get the transceiver more time to process bursts, the L1 scheduler should process the frames and send the bursts in advance (a few frames before), like OsmoBTS does. By default, the advance

[PATCH] osmocom-bb[master]: host/trxcon/l1ctl.c: handle L1CTL_TRAFFIC_REQ

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6802 host/trxcon/l1ctl.c: handle L1CTL_TRAFFIC_REQ Change-Id: Ibdf2d4f6aa464250a4c6951af86c06eb3fd3b98b --- M src/host/trxcon/l1ctl.c 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb

[PATCH] osmocom-bb[master]: fake_trx/clck_gen.py: reset the clck_src when calling stop()

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6795 fake_trx/clck_gen.py: reset the clck_src when calling stop() Change-Id: I1043f71a2cbe856a0cb605db8a7feab9defa6afd --- M src/target/fake_trx/clck_gen.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull

[PATCH] osmocom-bb[master]: host/trxcon/scheduler: always print error messages

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6805 host/trxcon/scheduler: always print error messages Some error messages previously had incorrect logging level 'debug'. We aren't going to hide anything, right? Let's print them! Change-Id: I85fb37292046b667386bfe26b9bbb000600e1c6f --- M

[PATCH] osmocom-bb[master]: host/trxcon/trx_if.c: get rid of useless commands

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6792 host/trxcon/trx_if.c: get rid of useless commands The 'SETMAXDLY' command is used on the BTS side to limit maximal Time of Arrival for access bursts. As we don't receive RACH bursts on the MS side, the command is useless. The 'SETRXGAIN' command is

[PATCH] osmocom-bb[master]: common/l1ctl.c move TCH bit-ordering to the firmware

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6801 common/l1ctl.c move TCH bit-ordering to the firmware Previously, TCH frames coming from L1 were reordered to the RTP format. Moreover, the implementation had a few problems: - L1CTL is not the best place for such manipulations; - payloads with

[PATCH] osmocom-bb[master]: trxcon/scheduler: share chan / prim identification helpers

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6814 trxcon/scheduler: share chan / prim identification helpers Because they would be also used outside. Change-Id: Ic8af9d7c72fdb124caef82e35170f92b84e16eb9 --- M src/host/trxcon/sched_prim.c M src/host/trxcon/sched_trx.h 2 files changed, 9 insertions(+),

[PATCH] osmocom-bb[master]: trxcon/scheduler: move prim management outside lchan handlers

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6808 trxcon/scheduler: move prim management outside lchan handlers Previously, each lchan handler used to obtain and delete primitives from a timeslot's tranmit queue itself. This approach entails many potential problems and bugs: - The lchan handlers

[PATCH] osmocom-bb[master]: host/trxcon/scheduler: drop meaningless memset call

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6799 host/trxcon/scheduler: drop meaningless memset call Change-Id: I18a938cef350632673cfc820beed5e42f40d89e7 --- M src/host/trxcon/sched_lchan_xcch.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb

[PATCH] osmocom-bb[master]: host/trxcon/scheduler: add initial TCH/F channel support

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6803 host/trxcon/scheduler: add initial TCH/F channel support This change implements basic TCH/F lchan handlers for both data reception and transmission. Only FACCH (signaling), FR and EFR payloads are supported at the moment. Change-Id:

[PATCH] osmo-mgw[master]: enable osmo_fsm vty commands in libosmo-mgcp-client vty

2018-02-22 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/6842 enable osmo_fsm vty commands in libosmo-mgcp-client vty Call osmo_fsm_vty_add_cmds() to make osmo_fsm VTY commands available in libosmo-mgcp-client's VTY interface. Change-Id: If772edc304a9f342a57fb548f26908256cc9e6e5 Related: OS#2967 --- M

[PATCH] osmocom-bb[master]: L1CTL/L1CTL_CRYPTO_REQ: add key length and channel info

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6810 L1CTL/L1CTL_CRYPTO_REQ: add key length and channel info Previously, the L1CTL_CRYPTO_REQ message contained only a ciphering algorithm and actual Kc key to be used. The key length was calculated manually using the MSGB API. Let's avoid manual

[PATCH] osmocom-bb[master]: trxcon/scheduler: reset lchan state after deactivation

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6815 trxcon/scheduler: reset lchan state after deactivation Let's assume that a logical channel, which was already in use, is activated again for a new connection. As we don't reset the state variables, such as burst masks or ciphering data, it may cause an

[PATCH] osmocom-bb[master]: host/trxcon/scheduler: use GSM_MACBLOCK_LEN definition

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6800 host/trxcon/scheduler: use GSM_MACBLOCK_LEN definition Change-Id: Ie3b27ecb62d6f0e84f2e3ec0c1558e32bb213d33 --- M src/host/trxcon/sched_lchan_common.c M src/host/trxcon/sched_lchan_xcch.c 2 files changed, 8 insertions(+), 5 deletions(-) git pull

[PATCH] osmocom-bb[master]: trxcon/scheduler: use linuxlist API for lchan management

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6817 trxcon/scheduler: use linuxlist API for lchan management As there is no any order relation between logical channels, it's better to use the linuxlist API instead of talloc array. Change-Id: I5a78582c77ed1ab33817d240e065dc4cd4708199 --- M

[PATCH] osmocom-bb[master]: trxcon/scheduler: deactivate lchans when resetting / deletin...

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6816 trxcon/scheduler: deactivate lchans when resetting / deleting TS Previously, when resetting or deleting a timeslot, we did not deactivate the logical channels, relaying on talloc hierarchical nature. This approach may cause some problems, e.g. on

[PATCH] osmocom-bb[master]: trxcon/scheduler: preprocess UL bursts before sending

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6811 trxcon/scheduler: preprocess UL bursts before sending Having a possibility to preprocess UL burst before sending to transceiver is required for the further ciphering support integration and probably some other tasks. Change-Id:

[PATCH] osmocom-bb[master]: trxcon/scheduler: FIX: return NULL from TCH dequeue function

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6813 trxcon/scheduler: FIX: return NULL from TCH dequeue function Initially it was expected that a TCH transmit queue could contain TCH and FACCH primitives only. But there are also SACCH primitives, which are also being stored there. So, let's drop the

[PATCH] osmocom-bb[master]: trxcon/scheduler: implement A5/X ciphering support

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6812 trxcon/scheduler: implement A5/X ciphering support This change implements the A5/X ciphering support transparently for the logical channel handlers. In other words, a DL burst is deciphered before being passed to a handler, and an UL burst is ciphered

[PATCH] osmocom-bb[master]: trxcon/scheduler: prioritize FACCH correctly

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6809 trxcon/scheduler: prioritize FACCH correctly Previously we used to compare two consecutive first primitives, taken from a transmit queue. This approach may cause some delay, which is critical for FACCH e.g. in case of handover. Let's walk through a

[PATCH] osmocom-bb[master]: trxcon/scheduler: BUGFIX: distinguish between SACCH and FACCH

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6806 trxcon/scheduler: BUGFIX: distinguish between SACCH and FACCH Both SACCH and FACCH messages have the same 23-byte length, both are being queued together within a single transimt queue. So, previously a SACCH frame could be picked by TCH burst handler,

[ABANDON] osmocom-bb[master]: host/trxcon/l1ctl.c: implement L1CTL_CCCH_MODE_{REQ/CONF}

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/l1ctl.c: implement L1CTL_CCCH_MODE_{REQ/CONF} .. Abandoned -- To view, visit https://gerrit.osmocom.org/6704 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon: handle L1CTL_FBSB_REQ inside l1ctl.c

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: handle L1CTL_FBSB_REQ inside l1ctl.c .. Abandoned -- To view, visit https://gerrit.osmocom.org/6699 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon: handle ccch_mode from L1CTL_FBSB_REQ

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: handle ccch_mode from L1CTL_FBSB_REQ .. Abandoned -- To view, visit https://gerrit.osmocom.org/6694 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon: store arfcn and band in trx_instance

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: store arfcn and band in trx_instance .. Abandoned -- To view, visit https://gerrit.osmocom.org/6693 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon: send L1CTL_DATA_IND directly from lchan handler

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: send L1CTL_DATA_IND directly from lchan handler .. Abandoned -- To view, visit https://gerrit.osmocom.org/6701 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon: bind L1CTL link with TRX and vice versa

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: bind L1CTL link with TRX and vice versa .. Abandoned -- To view, visit https://gerrit.osmocom.org/6698 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: add basic clock counter

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: add basic clock counter .. Abandoned -- To view, visit https://gerrit.osmocom.org/6688 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon: fix NULL-pointer deference

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: fix NULL-pointer deference .. Abandoned -- To view, visit https://gerrit.osmocom.org/6684 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon: initial release of L1CTL handlers

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: initial release of L1CTL handlers .. Abandoned -- To view, visit https://gerrit.osmocom.org/6687 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: fix channel deactivation

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: fix channel deactivation .. Abandoned -- To view, visit https://gerrit.osmocom.org/6702 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon: link trxcon against libosmocoding

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: link trxcon against libosmocoding .. Abandoned -- To view, visit https://gerrit.osmocom.org/6695 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon: handle L1CTL_RESET_REQ inside l1ctl.c

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon: handle L1CTL_RESET_REQ inside l1ctl.c .. Abandoned -- To view, visit https://gerrit.osmocom.org/6700 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: add basic GSM PHY definitions

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: add basic GSM PHY definitions .. Abandoned -- To view, visit https://gerrit.osmocom.org/6690 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: implement management functions

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: implement management functions .. Abandoned -- To view, visit https://gerrit.osmocom.org/6691 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: implement xCCH decoding

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: implement xCCH decoding .. Abandoned -- To view, visit https://gerrit.osmocom.org/6696 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: implement SCH decoding

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: implement SCH decoding .. Abandoned -- To view, visit https://gerrit.osmocom.org/6697 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon/l1ctl.c: implement L1CTL_FBSB_CONF

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/l1ctl.c: implement L1CTL_FBSB_CONF .. Abandoned -- To view, visit https://gerrit.osmocom.org/6703 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon/trx_if.c: handle clock indications

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/trx_if.c: handle clock indications .. Abandoned -- To view, visit https://gerrit.osmocom.org/6689 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: handle bursts from TRX interface

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: handle bursts from TRX interface .. Abandoned -- To view, visit https://gerrit.osmocom.org/6692 To unsubscribe, visit

[PATCH] osmocom-bb[master]: fake_trx: implement a new tool for TRX protocol sniffing

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6821 fake_trx: implement a new tool for TRX protocol sniffing This change introduces a new tool, which could be used to sniff a single connection between L1 and TRX in both directions, filter captured bursts by direction, timeslot and/or frame number, and

[PATCH] osmocom-bb[master]: fake_trx/burst_send.py: implement DATA capture support

2018-02-22 Thread Harald Welte
Review at https://gerrit.osmocom.org/6836 fake_trx/burst_send.py: implement DATA capture support Previously, this tool was only able to read a hand-crafted text file with bursts and send them via the DATA interface. This is not so useful... This change implements support of reading DATA

[ABANDON] osmocom-bb[master]: fake_trx/ctrl_cmd.py: add help and basic command line options

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: fake_trx/ctrl_cmd.py: add help and basic command line options .. Abandoned -- To view, visit https://gerrit.osmocom.org/6785 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon/trx_ic.c: use osmo_ubit2sbit() from libosmocore

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/trx_ic.c: use osmo_ubit2sbit() from libosmocore .. Abandoned -- To view, visit https://gerrit.osmocom.org/6791 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: fake_trx: correct brief descriptions of files

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: fake_trx: correct brief descriptions of files .. Abandoned -- To view, visit https://gerrit.osmocom.org/6789 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: use new libosmocoding API for RACH

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: use new libosmocoding API for RACH .. Abandoned -- To view, visit https://gerrit.osmocom.org/6797 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: fake_trx: implement classes for DATA messages

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: fake_trx: implement classes for DATA messages .. Abandoned -- To view, visit https://gerrit.osmocom.org/6823 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: add initial TCH/F channel support

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: add initial TCH/F channel support .. Abandoned -- To view, visit https://gerrit.osmocom.org/6803 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: common/l1ctl.c move TCH bit-ordering to the firmware

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: common/l1ctl.c move TCH bit-ordering to the firmware .. Abandoned -- To view, visit https://gerrit.osmocom.org/6801 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: trxcon/scheduler: move prim management outside lchan handlers

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: trxcon/scheduler: move prim management outside lchan handlers .. Abandoned -- To view, visit https://gerrit.osmocom.org/6808 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: trxcon/scheduler: drop meaningless TODO comment

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: trxcon/scheduler: drop meaningless TODO comment .. Abandoned -- To view, visit https://gerrit.osmocom.org/6818 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmocom-bb[master]: trxcon/scheduler: deactivate lchans when resetting / deletin...

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: trxcon/scheduler: deactivate lchans when resetting / deleting TS .. Abandoned -- To view, visit https://gerrit.osmocom.org/6816 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: trxcon/scheduler: implement A5/X ciphering support

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: trxcon/scheduler: implement A5/X ciphering support .. Abandoned -- To view, visit https://gerrit.osmocom.org/6812 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: drop meaningless memset call

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: drop meaningless memset call .. Abandoned -- To view, visit https://gerrit.osmocom.org/6799 To unsubscribe, visit

[ABANDON] osmocom-bb[master]: host/trxcon/scheduler: use GSM_MACBLOCK_LEN definition

2018-02-22 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: host/trxcon/scheduler: use GSM_MACBLOCK_LEN definition .. Abandoned -- To view, visit https://gerrit.osmocom.org/6800 To unsubscribe, visit

  1   2   3   4   >