[MERGED] osmo-ttcn3-hacks[master]: gitignore vim swp files

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gitignore vim swp files .. gitignore vim swp files Change-Id: I2d60ad2365c7fd82210ee1dac96fabab19617280 --- M .gitignore 1 file changed, 1 insertion(+),

[MERGED] osmo-gsm-tester[master]: ms: Add a first test to use all parts of the system

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ms: Add a first test to use all parts of the system .. ms: Add a first test to use all parts of the system This is an interim solution but is bringing

[MERGED] osmo-ci[master]: ansible: hosts: add host2-deb8build-ansible host2-deb9build-...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: hosts: add host2-deb8build-ansible host2-deb9build-ansible .. ansible: hosts: add host2-deb8build-ansible host2-deb9build-ansible Change-Id:

[MERGED] osmo-gsm-tester[master]: ms: Create template for the osmocom-bb mobile application

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ms: Create template for the osmocom-bb mobile application .. ms: Create template for the osmocom-bb mobile application Change-Id:

[MERGED] osmo-gsm-tester[master]: ms: Create a simple epoll (or kqueue) based event loop

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ms: Create a simple epoll (or kqueue) based event loop .. ms: Create a simple epoll (or kqueue) based event loop Create a C-like single process event

[MERGED] osmo-ci[master]: ansible: osmocom-jenkins-slave: don't install recommend pack...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: osmocom-jenkins-slave: don't install recommend packages .. ansible: osmocom-jenkins-slave: don't install recommend packages libuhd-dev would

[MERGED] osmo-ci[master]: ansible: create a new group coverity-slaves to choose the ta...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: create a new group coverity-slaves to choose the target of coverity .. ansible: create a new group coverity-slaves to choose the target of

osmo-ci[master]: ansible: hosts: use inventory with ansible_host to have more...

2018-04-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7592 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0888e9b66cd1077dcdada97fb5ee2d56def516e3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] osmo-gsm-tester[master]: ms: Add a main function to start all of it

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ms: Add a main function to start all of it .. ms: Add a main function to start all of it Add a main file to start everything. All parameters need to be

[MERGED] osmo-gsm-tester[master]: ms: Add lua script support utilities

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ms: Add lua script support utilities .. ms: Add lua script support utilities Add a JSON encoder and a small module to sent registration and other events

[MERGED] osmo-ci[master]: ansible jenkins-slave: only setup ttcn3_slave on debian stretch

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible jenkins-slave: only setup ttcn3_slave on debian stretch .. ansible jenkins-slave: only setup ttcn3_slave on debian stretch Change-Id:

[MERGED] osmo-gsm-tester[master]: ms: Create a starter for virtphy and mobile application

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ms: Create a starter for virtphy and mobile application .. ms: Create a starter for virtphy and mobile application In the long run we might not want to

osmo-ci[master]: ansible: hosts: add build2-deb8build-ansible build2-deb9buil...

2018-04-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7591 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iede01ab10f0a9582b3a3a9a3ebbbc684b94a3c0a Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible jenkins-slave: only setup ttcn3_slave on debian stretch

2018-04-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7597 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf043008890da94098986468e1fd3d9578810206 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: create a new group coverity-slaves to choose the ta...

2018-04-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7593 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b09ca50db938c5c7087a74e5d2575412a916ff6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] osmo-gsm-tester[master]: ms: Lua part of location update testing

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ms: Lua part of location update testing .. ms: Lua part of location update testing The lua part to start the MS and then signal the first successful

osmo-ci[master]: jobs/update-osmo*: add new nodes to the update jobs

2018-04-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7595 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib103b3343d582f7a78f0c4cec00c94078a078584 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: install eclipse-titan

2018-04-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7596 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I354271b7c573484b7f538a5a4bb29753a950d5f9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

Jenkins build is back to normal : master-osmo-gmr » a1=default,a2=default,a3=default,osmocom-master-debian9 #333

2018-04-05 Thread jenkins
See

Build failed in Jenkins: master-osmo-bts » sysmo, superfemto_v3.0.1pre,default,osmocom-master-debian9 #465

2018-04-05 Thread jenkins
See -- Started by upstream project "master-osmo-bts" build number 465 originally

osmo-bts[master]: fix activation of osmocom-style dynamic PDCH as TCH/F or TCH/H

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+1 let's see what neels has to say -- To view, visit https://gerrit.osmocom.org/7652 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14ae4c4ed2aae0966e5cb5116cf024d6bd890237 Gerrit-PatchSet: 1 Gerrit-Project:

osmo-ttcn3-hacks[master]: add compare-results.sh, call from start-testsuite.sh

2018-04-05 Thread Neels Hofmeyr
Patch Set 1: for illustration, I tested the new msc fsm with this and got: Comparing expected results /osmo-ttcn3-hacks/msc/expected-results.log against results in junit-xml-105.log xfail->pass MSC_Tests.TC_cr_before_reset pass

osmo-ttcn3-hacks[master]: add compare-results.sh, call from start-testsuite.sh

2018-04-05 Thread Neels Hofmeyr
Patch Set 1: (in case anyone wonders, I faked this one for testing the script and it was left over by accident, it's not really xfail: > xfail->pass MSC_Tests.TC_cr_before_reset So the FSM really fixes only 6 tests, not 7.) -- To view, visit https://gerrit.osmocom.org/7646 To

libosmo-netif[master]: stream.c: osmo_stream_cli_open2: Remove wrong assumption in ...

2018-04-05 Thread Pau Espin Pedrol
Patch Set 1: I was having the same concerns why looking at this. I was thinking more in the differentiation between "temporary" errors or more "permanent" errors, which would not be solved over time, but ended up concluding what you see in this commit. I thought of different scenarios, but

osmo-ttcn3-hacks[master]: add compare-results.sh, call from start-testsuite.sh

2018-04-05 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 re-add earlier +2, patch set just fixed a manual edit of msc's expected results that should not have gotten into the patch. -- To view, visit https://gerrit.osmocom.org/7646 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] osmo-ttcn3-hacks[master]: add compare-results.sh, call from start-testsuite.sh

2018-04-05 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7646 to look at the new patch set (#2). add compare-results.sh, call from start-testsuite.sh Compare current test results to the expected results, and exit in error on

[PATCH] osmo-bts[master]: fix activation of osmocom-style dynamic PDCH as TCH/F or TCH/H

2018-04-05 Thread Harald Welte
Review at https://gerrit.osmocom.org/7652 fix activation of osmocom-style dynamic PDCH as TCH/F or TCH/H in change-id Iebd2571726d1284a7431b3f9b23ad3185e832ed1 we introduced tighter validation on whether the requested channel number matches the underlying physical channel configuration.

[MERGED] osmo-ci[master]: ansible: install eclipse-titan

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: install eclipse-titan .. ansible: install eclipse-titan Change-Id: I354271b7c573484b7f538a5a4bb29753a950d5f9 --- M

osmo-ci[master]: ansible: osmocom-jenkins-slave: don't install recommend pack...

2018-04-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7590 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6859b8180916a8e172d32030da06ba6fa27d5c45 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: hosts: add host2-deb8build-ansible host2-deb9build-...

2018-04-05 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7594 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0a21f24483b2c1c6ea56e366c5858eee50f17e1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] osmo-ci[master]: jobs/update-osmo*: add new nodes to the update jobs

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jobs/update-osmo*: add new nodes to the update jobs .. jobs/update-osmo*: add new nodes to the update jobs Change-Id:

[MERGED] osmo-ci[master]: ansible: hosts: add build2-deb8build-ansible build2-deb9buil...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: hosts: add build2-deb8build-ansible build2-deb9build-ansible slaves .. ansible: hosts: add build2-deb8build-ansible build2-deb9build-ansible

[MERGED] osmo-ci[master]: ansible: hosts: use inventory with ansible_host to have more...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: hosts: use inventory with ansible_host to have more readable ansible output .. ansible: hosts: use inventory with ansible_host to have more

[MERGED] osmo-gsm-tester[master]: ms: Create an event server to handle Unix datagram messages

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ms: Create an event server to handle Unix datagram messages .. ms: Create an event server to handle Unix datagram messages Create an EventServer that

[PATCH] osmo-bts[master]: contrib: jenkins_bts_model: Fix bashism expr

2018-04-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7654 contrib: jenkins_bts_model: Fix bashism expr In posix shell, = is valid and == is not. Change-Id: I5c027039d12c5e455a8f8a0878f88ab30c168db4 --- M contrib/jenkins_bts_model.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull

[PATCH] osmo-ttcn3-hacks[master]: fix MSC.TC_lu_clear_request: allow LU Reject, forbid 2nd Cle...

2018-04-05 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7653 to look at the new patch set (#2). fix MSC.TC_lu_clear_request: allow LU Reject, forbid 2nd Clear Cmd When the MS sends a Clear Request in the middle of a Location Updating, it should

[PATCH] osmo-ttcn3-hacks[master]: fix TC_lu_clear_request: allow LU Reject message, forbid sec...

2018-04-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7653 fix TC_lu_clear_request: allow LU Reject message, forbid second Clear Cmd When the MS sends a Clear Request in the middle of a Location Updating, it should be permitted for the MSC to send a Location Updating Reject back. Extend with an alt that also

osmo-ttcn3-hacks[master]: add compare-results.sh, call from start-testsuite.sh

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7646 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87d62a8be73d73a5eeff61a842e7c27a0066079d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Add first tests about IPA style dynamic PDCH

2018-04-05 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7644 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56d8b0284e8e4eee4ce6454f7a495ee09c40fe42 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] libosmocore[master]: socket.c: osmo_sock_init2: connect: Several logic fixes and ...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: socket.c: osmo_sock_init2: connect: Several logic fixes and log improvements .. socket.c: osmo_sock_init2: connect: Several logic fixes and log

[MERGED] libosmocore[master]: socket.c: osmo_sock_init2: bind: Several logic fixes and log...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: socket.c: osmo_sock_init2: bind: Several logic fixes and log improvements .. socket.c: osmo_sock_init2: bind: Several logic fixes and log improvements

[MERGED] osmo-hlr[master]: more robust usage of osmo_timer API for osmo-hlr luop timer

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: more robust usage of osmo_timer API for osmo-hlr luop timer .. more robust usage of osmo_timer API for osmo-hlr luop timer Use osmo_timer_setup() to set

[MERGED] libosmocore[master]: socket.c: osmo_sock_init: Several logic fixes and log improv...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: socket.c: osmo_sock_init: Several logic fixes and log improvements .. socket.c: osmo_sock_init: Several logic fixes and log improvements See

libosmocore[master]: gsm0480: fix: don't overwrite the data of RELEASE_COMPLETE

2018-04-05 Thread Harald Welte
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7631 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c8529749a48ca0c4b2e93f4fa2d61468c18 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] osmo-ttcn3-hacks[master]: bts: Add first tests about IPA style dynamic PDCH

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add first tests about IPA style dynamic PDCH .. bts: Add first tests about IPA style dynamic PDCH Change-Id:

libosmocore[master]: GSUP: add USSD messages support according to 3GPP TS 09.02

2018-04-05 Thread Harald Welte
Patch Set 3: Code-Review+1 looks fine, let's wait for OSmoMSC patches -- To view, visit https://gerrit.osmocom.org/7600 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie17a78043a35fffbdd59e80fd2b2da39cce5e532 Gerrit-PatchSet: 3

libosmo-netif[master]: stream.c: osmo_stream_cli_open2: Remove wrong assumption in ...

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+1 I'm not entirely sure if this is the right approach. Aren't there fatal/permanent causes in which connect() can fail and there's no point in trying to reconnect? I mean, if the connection is refused or times out, reconnecting is fine. But what if the local port

libosmocore[master]: GSUP: add USSD messages support according to 3GPP TS 09.02

2018-04-05 Thread Vadim Yanitskiy
Patch Set 3: > looks fine, let's wait for OSmoMSC patches Thanks. Will upload them soon. And, a little modification here is required. -- To view, visit https://gerrit.osmocom.org/7600 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: add compare-results.sh, call from start-testsuite.sh

2018-04-05 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: add compare-results.sh, call from start-testsuite.sh .. add compare-results.sh, call from start-testsuite.sh Compare current test results to the

Build failed in Jenkins: master-osmo-gmr » a1=default,a2=default,a3=default,osmocom-master-debian9 #334

2018-04-05 Thread jenkins
See -- Started by upstream project "master-osmo-gmr" build number 334 originally caused by: Started by upstream

Build failed in Jenkins: master-osmo-gmr » a1=default,a2=default,a3=default,osmocom-master-debian9 #332

2018-04-05 Thread jenkins
See -- Started by upstream project "master-osmo-gmr" build number 332 originally caused by: Started by upstream

Jenkins build is back to normal : master-osmo-bts » sysmo,superfemto_v3.0.1pre,default,osmocom-master-debian9 #466

2018-04-05 Thread jenkins
See

Build failed in Jenkins: master-osmo-bts » sysmo, superfemto_v3.0.1pre,default,osmocom-master-debian9 #467

2018-04-05 Thread jenkins
See -- Started by upstream project "master-osmo-bts" build number 467 originally

[PATCH] libosmocore[master]: use osmo_init_logging2() with proper talloc ctx

2018-04-05 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7637 to look at the new patch set (#2). use osmo_init_logging2() with proper talloc ctx Ironically, when deprecating osmo_init_logging() in I216837780e9405fdaec8059c63d10699c695b360, I

osmo-ci[master]: jenkins: add osmo-gsm-tester-build jobs

2018-04-05 Thread Pau Espin Pedrol
Patch Set 5: lynxis, can you validate and merge them? Is there something else missing? -- To view, visit https://gerrit.osmocom.org/7019 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085

[PATCH] docker-playground[master]: root Makefile: fix ttcn3-msc-test rule, drop an extra .PHONY

2018-04-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7643 root Makefile: fix ttcn3-msc-test rule, drop an extra .PHONY Change-Id: I098d9d84d9ce89b1dab204b90d2cd7ee7b3f19c9 --- M Makefile 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground

osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-04-05 Thread Pau Espin Pedrol
Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6230 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3064f4c3c4c7af5d3491f850090516e541f4d3 Gerrit-PatchSet: 8 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: bts: Add first five dynamic PDCH tests

2018-04-05 Thread Harald Welte
Review at https://gerrit.osmocom.org/7641 bts: Add first five dynamic PDCH tests NOTE: This needs changes to your osmo-bsc.cfg, as it will now need an osmocom-style dyn PDCH on TS4, and an IPA-style dny PDCH on TS3. --- a/ttcn3-bts-test/osmo-bsc.cfg +++ b/ttcn3-bts-test/osmo-bsc.cfg @@

[PATCH] osmo-ttcn3-hacks[master]: BTS_Tests: Prepare for ConnHdlr with PCU socket access

2018-04-05 Thread Harald Welte
Review at https://gerrit.osmocom.org/7640 BTS_Tests: Prepare for ConnHdlr with PCU socket access For upcoming dynamic PDCH activation/deactivation tests we would like to access the PCU socket from ConnHdlr, rather than test_CT. Let's prepare for that. Change-Id:

[PATCH] osmo-ttcn3-hacks[master]: PCUIF_Types: Fix bit-order of pdch_mask

2018-04-05 Thread Harald Welte
Review at https://gerrit.osmocom.org/7639 PCUIF_Types: Fix bit-order of pdch_mask The bit-string type should be indexed by timeslot number, i.e. the first element [0] should equal timeslot 0, the last one TS7 Change-Id: Ib89689abd998d4940895ba04f49eb140888bc73f --- M library/PCUIF_Types.ttcn

[PATCH] osmo-bts[master]: rsl_tx_dyn_pdch_ack: Add missing FRAME_NR information element

2018-04-05 Thread Harald Welte
Review at https://gerrit.osmocom.org/7638 rsl_tx_dyn_pdch_ack: Add missing FRAME_NR information element It seems that the IPA PDCH ACT ACK contains not only the channel number, but also the frame number. Let's make sure we're as close as possible to other implementations to ensure maximum

[MERGED] libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info' cmd) .. ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info'

libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

2018-04-05 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24232be7dcf7be79f4def91ddc8b8f8005b56318 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: ctrl: test deferred cmd, show current failure

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ctrl: test deferred cmd, show current failure .. ctrl: test deferred cmd, show current failure Handling a deferred command currently deallocates the

[MERGED] libosmocore[master]: cosmetic: flatten ctrl_handle_msg()

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: flatten ctrl_handle_msg() .. cosmetic: flatten ctrl_handle_msg() Change-Id: I3a711f5c974b7f56e27b333d390d1a706fb57007 --- M

docker-playground[master]: root Makefile: fix ttcn3-msc-test rule, drop an extra .PHONY

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7643 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I098d9d84d9ce89b1dab204b90d2cd7ee7b3f19c9 Gerrit-PatchSet: 1 Gerrit-Project: docker-playground Gerrit-Branch:

docker-playground[master]: fix 'make -C subdir': use $(CURDIR) instead of $PWD

2018-04-05 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7633 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dd0fd1ad89fdee18fdbea851ccc831ad60aeccf Gerrit-PatchSet: 2 Gerrit-Project: docker-playground Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: bts: Add first two tests about IPA style dynamic PDCH

2018-04-05 Thread Harald Welte
Review at https://gerrit.osmocom.org/7644 bts: Add first two tests about IPA style dynamic PDCH Change-Id: I56d8b0284e8e4eee4ce6454f7a495ee09c40fe42 --- M bts/BTS_Tests.ttcn 1 file changed, 112 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[MERGED] docker-playground[master]: fix 'make -C subdir': use $(CURDIR) instead of $PWD

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix 'make -C subdir': use $(CURDIR) instead of $PWD .. fix 'make -C subdir': use $(CURDIR) instead of $PWD $(PWD) reflects the dir of 'make' invocation,

osmo-ttcn3-hacks[master]: PCUIF_Types: Fix bit-order of pdch_mask

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7639 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib89689abd998d4940895ba04f49eb140888bc73f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Add first five dynamic PDCH tests

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7641 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a42531dcab4772d538fda462343605b8feb Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: bts: Add first five dynamic PDCH tests

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add first five dynamic PDCH tests .. bts: Add first five dynamic PDCH tests NOTE: This needs changes to your osmo-bsc.cfg, as it will now need an

[MERGED] osmo-ttcn3-hacks[master]: PCUIF_Types: Fix bit-order of pdch_mask

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: PCUIF_Types: Fix bit-order of pdch_mask .. PCUIF_Types: Fix bit-order of pdch_mask The bit-string type should be indexed by timeslot number, i.e. the

[MERGED] osmo-ttcn3-hacks[master]: BTS_Tests: Prepare for ConnHdlr with PCU socket access

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BTS_Tests: Prepare for ConnHdlr with PCU socket access .. BTS_Tests: Prepare for ConnHdlr with PCU socket access For upcoming dynamic PDCH

osmo-ttcn3-hacks[master]: BTS_Tests: Prepare for ConnHdlr with PCU socket access

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7640 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8811dd87f737f326f7ed8f652aa6f552c3f05f8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: RSL_Types: Fix msg_disc of IPA PDCH ACT/DEACT + inverse temp...

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7642 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I170a90391859d71e1f96a72205487cccba5b6ae7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: RSL_Types: Fix msg_disc of IPA PDCH ACT/DEACT + inverse temp...

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL_Types: Fix msg_disc of IPA PDCH ACT/DEACT + inverse templates .. RSL_Types: Fix msg_disc of IPA PDCH ACT/DEACT + inverse templates The

Build failed in Jenkins: master-libosmocore » a2=default,a3=default,amd64,osmocom-master-debian9 #189

2018-04-05 Thread jenkins
See Changes: [Neels Hofmeyr] ctrl: test deferred cmd, show current failure [Neels Hofmeyr] ctrl: fix deferred commands (and hence fix

libosmocore[master]: ctrl: test deferred cmd, show current failure

2018-04-05 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7636 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbc847fc583bdd8e5e53a008258805e634ea12b4 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-bts[master]: rsl_tx_dyn_pdch_ack: Add missing FRAME_NR information element

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7638 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe7988e9ef374e8c7d9429777fb32322d90c2024 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: fox chan_nr_is_dchan() for RSL_CHAN_OSMO_PDCH

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fox chan_nr_is_dchan() for RSL_CHAN_OSMO_PDCH .. fox chan_nr_is_dchan() for RSL_CHAN_OSMO_PDCH When writing chan_nr_is_dchan() in Change-Id:

[MERGED] osmo-bts[master]: rsl_tx_dyn_pdch_ack: Add missing FRAME_NR information element

2018-04-05 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: rsl_tx_dyn_pdch_ack: Add missing FRAME_NR information element .. rsl_tx_dyn_pdch_ack: Add missing FRAME_NR information element It seems that the IPA

[PATCH] libosmocore[master]: socket.c: osmo_sock_init2: Several logic fixes and log impro...

2018-04-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7645 socket.c: osmo_sock_init2: Several logic fixes and log improvements After investigating osmo-msc showing this log message and looking at the code, it's a bit difficult to find out what's going on in the code: socket.c:224 unable to bind socket:

libosmocore[master]: socket.c: osmo_sock_init2: connect: Several logic fixes and ...

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7648 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f7577b9f498ae9d388ed1f79f6ca0ec6f09664 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: socket.c: osmo_sock_init: Several logic fixes and log improv...

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7649 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4889e777d8627fdfb52c97ab3ab353b6ed34aab2 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: socket.c: osmo_sock_init2: connect: Several logic fixes and ...

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7648 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f7577b9f498ae9d388ed1f79f6ca0ec6f09664 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: socket.c: osmo_sock_init2: bind: Several logic fixes and log...

2018-04-05 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7645 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1854422ad92dadf33ed4d849e15c0380c3bf1626 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmo-netif[master]: stream.c: osmo_stream_cli_open2: Remove wrong assumption in ...

2018-04-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7650 stream.c: osmo_stream_cli_open2: Remove wrong assumption in reconnect decision Documentation of osmo_sock_init2 doesn't provide information of any specific value of errno set/expected after running the function. It is incorrect to expect a specific

[MERGED] osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

2018-04-05 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. Change subject: ms: Create a cumulative distribution function class .. ms: Create a cumulative distribution function class We are using the CDF to decide which

[PATCH] osmo-ttcn3-hacks[master]: bts: Add first tests about IPA style dynamic PDCH

2018-04-05 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7644 to look at the new patch set (#2). bts: Add first tests about IPA style dynamic PDCH Change-Id: I56d8b0284e8e4eee4ce6454f7a495ee09c40fe42 --- M bts/BTS_Tests.ttcn 1 file changed, 181

osmo-bsc[master]: vty: re-add 'timeout-ping' and 'timeout-pong' as dummy commands

2018-04-05 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7634 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95a5bad1ade66ded849cfc20bebb7fc522aecc38 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] libosmocore[master]: socket.c: osmo_sock_init: Several logic fixes and log improv...

2018-04-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7649 socket.c: osmo_sock_init: Several logic fixes and log improvements See explanations in previous commit. Change-Id: I4889e777d8627fdfb52c97ab3ab353b6ed34aab2 --- M src/socket.c 1 file changed, 16 insertions(+), 8 deletions(-) git pull

[PATCH] libosmocore[master]: socket.c: osmo_sock_init2: connect: Several logic fixes and ...

2018-04-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7648 socket.c: osmo_sock_init2: connect: Several logic fixes and log improvements See explanations in previous commits. Change-Id: Ib2f7577b9f498ae9d388ed1f79f6ca0ec6f09664 --- M src/socket.c 1 file changed, 17 insertions(+), 8 deletions(-) git pull

[PATCH] osmo-ttcn3-hacks[master]: add compare-results.sh, call from start-testsuite.sh

2018-04-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7646 add compare-results.sh, call from start-testsuite.sh Compare current test results to the expected results, and exit in error on discrepancies. Add compare-result.sh: (trivially) grep junit xml output to determine which tests passed and which didn't,

[PATCH] osmo-ttcn3-hacks[master]: gitignore vim swp files

2018-04-05 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7647 gitignore vim swp files Change-Id: I2d60ad2365c7fd82210ee1dac96fabab19617280 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/7647/1 diff --git a/.gitignore

osmo-ttcn3-hacks[master]: gitignore vim swp files

2018-04-05 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7647 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d60ad2365c7fd82210ee1dac96fabab19617280 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: add compare-results.sh, call from start-testsuite.sh

2018-04-05 Thread Harald Welte
Patch Set 1: I'm not convinced, once again, sorry. I believe we had this discussion and the conclusion was that we split the tests into two TTCN-3 modules so we have BTS_Tests and BTS_Tests_xfail or something like that? Also, I'm quite critical of this in general. We should focus on fixing

[PATCH] libosmocore[master]: socket.c: osmo_sock_init2: bind: Several logic fixes and log...

2018-04-05 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7645 to look at the new patch set (#2). socket.c: osmo_sock_init2: bind: Several logic fixes and log improvements After investigating osmo-msc showing this log message and looking at the

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #78

2018-04-05 Thread jenkins
See -- [...truncated 3.69 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

[MERGED] libosmocore[master]: fix ctrl_test sanitizer issues

2018-04-05 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix ctrl_test sanitizer issues .. fix ctrl_test sanitizer issues Add logging to root ctx, add msgb ctx to root ctx, free wqueue to simulate the msgb

  1   2   >