Jenkins build is back to normal : master-osmo-bts » sysmo,superfemto_v3.1,default,osmocom-master-debian9 #596

[jenkins]

See 

Build failed in Jenkins: master-osmo-bts » sysmo,superfemto_v3.1,default,osmocom-master-debian9 #595

[jenkins]

See 


--
[...truncated 58.74 KB...]
flag during linking and do at least one of the following:
   - add LIBDIR to the 'LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the 'LD_RUN_PATH' environment variable
 during linking
   - use the '-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to '/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in src/codec
make[2]: Entering directory 
'
  CC   gsm610.lo
  CC   gsm620.lo
  CC   gsm660.lo
  CC   gsm690.lo
  CC   ecu_fr.lo
  CCLD libosmocodec.la
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p 
'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmocodec.la 
'
libtool: warning: relinking 'libosmocodec.la'
libtool: install: (cd 

 /bin/bash 
"
  --silent --tag CC --mode=relink gcc -Wall -g -O2 -DBUILDING_LIBOSMOCORE -Wall 
-version-info 1:0:1 -no-undefined -o libosmocodec.la -rpath 

 gsm610.lo gsm620.lo gsm660.lo gsm690.lo ecu_fr.lo ../../src/libosmocore.la )
libtool: install: /usr/bin/install -c .libs/libosmocodec.so.0.1.0T 

libtool: install: (cd 

 && { ln -s -f libosmocodec.so.0.1.0 libosmocodec.so.0 || { rm -f 
libosmocodec.so.0 && ln -s libosmocodec.so.0.1.0 libosmocodec.so.0; }; })
libtool: install: (cd 

 && { ln -s -f libosmocodec.so.0.1.0 libosmocodec.so || { rm -f libosmocodec.so 
&& ln -s libosmocodec.so.0.1.0 libosmocodec.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocodec.lai 

libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/sbin" 
ldconfig -n 

--
Libraries have been installed in:
   


If you ever happen to want to link against installed 

Build failed in Jenkins: master-rtl-sdr » a1=default,a2=default,a3=default,osmocom-master-debian9 #24

[jenkins]

See 


--
[...truncated 93.29 KB...]
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
Making dvi in src
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi-am'.
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
make[1]: Entering directory 
'
make  check-recursive
make[2]: Entering directory 
'
Making check in include
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory 
'
Making check in src
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory 
'
make[3]: Entering directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
make[1]: Entering directory 
'
make  install-recursive
make[2]: Entering directory 
'
Making install in include
make[3]: Entering directory 
'
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644 ../../../include/rtl-sdr.h 
../../../include/rtl-sdr_export.h 
'
make[4]: Leaving directory 

[PATCH] libosmocore[master]: lapdm: Implement SABM related constraints

[Harald Welte]

Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/7960

to look at the new patch set (#2).

lapdm: Implement SABM related constraints

* MO SAPI0 establishment *must always* have L3 payload for contention
  resolution
* SAPI3 establishment *must never* use contention resolution
* MT establish must never use contention resolution

Change-Id: I8c2c103cdc7f9a45d7b2080c572f559fc3db58e4
Closes: OS#2370
---
M src/gsm/lapdm.c
1 file changed, 45 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/7960/2

diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c
index ae21ccd..1e81bff 100644
--- a/src/gsm/lapdm.c
+++ b/src/gsm/lapdm.c
@@ -48,6 +48,8 @@
 #include 
 #include 
 
+#define LAPD_U_SABM 0x7
+
 /* TS 04.06 Figure 4 / Section 3.2 */
 #define LAPDm_LPD_NORMAL  0
 #define LAPDm_LPD_SMSCB  1
@@ -537,6 +539,42 @@
return rc;
 }
 
+/* determine if receiving a given LAPDm message is not permitted */
+static int lapdm_rx_not_permitted(const struct lapdm_entity *le,
+ const struct lapd_msg_ctx *lctx)
+{
+   /* we currently only implement SABM related checks here */
+   if (lctx->format != LAPD_FORM_U || lctx->s_u != LAPD_U_SABM)
+   return 0;
+
+   if (le->mode == LAPDM_MODE_BTS) {
+   if (le == >lapdm_ch->lapdm_acch) {
+   /* no contention resolution on SACCH */
+   if (lctx->length > 0)
+   return RLL_CAUSE_SABM_INFO_NOTALL;
+   } else {
+   switch (lctx->sapi) {
+   case 0:
+   /* SAPI0 must use contention resolution, i.e. 
L3 payload must exist */
+   if (lctx->length == 0)
+   return RLL_CAUSE_UFRM_INC_PARAM;
+   break;
+   case 3:
+   /* SAPI3 doesn't support contention resolution 
*/
+   if (lctx->length > 0)
+   return RLL_CAUSE_SABM_INFO_NOTALL;
+   break;
+   }
+   }
+   } else if (le->mode == LAPDM_MODE_MS) {
+   /* contention resolution (L3 present) is only sent by MS, but
+* never received by it */
+   if (lctx->length > 0)
+   return RLL_CAUSE_SABM_INFO_NOTALL;
+   }
+   return 0;
+}
+
 /* input into layer2 (from layer 1) */
 static int l2_ph_data_ind(struct msgb *msg, struct lapdm_entity *le,
uint8_t chan_nr, uint8_t link_id)
@@ -674,6 +712,13 @@
}
/* store context for messages from lapd */
memcpy(>mctx, , sizeof(mctx.dl->mctx));
+   rc =lapdm_rx_not_permitted(le, );
+   if (rc > 0) {
+   LOGP(DLLAPD, LOGL_NOTICE, "received message not 
permitted");
+   msgb_free(msg);
+   rsl_rll_error(rc, );
+   return -EINVAL;
+   }
/* send to LAPD */
rc = lapd_ph_data_ind(msg, );
break;

-- 
To view, visit https://gerrit.osmocom.org/7960
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c2c103cdc7f9a45d7b2080c572f559fc3db58e4
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 

[PATCH] libosmocore[master]: lapdm: Fix back-pointer from lapdm_entity to lapdm_channel

[Harald Welte]

Review at  https://gerrit.osmocom.org/8034

lapdm: Fix back-pointer from lapdm_entity to lapdm_channel

It seems that during all those years it has never been noted that
the back-pointer from the lapdm_entity to the lapdm_channel was
never initialized.  Let's fix that.

Change-Id: Iaca66cd6a2c9f315561e365b51163927868fc346
---
M src/gsm/lapdm.c
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/8034/1

diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c
index 6a16012..ae21ccd 100644
--- a/src/gsm/lapdm.c
+++ b/src/gsm/lapdm.c
@@ -169,8 +169,10 @@
 void lapdm_channel_init(struct lapdm_channel *lc, enum lapdm_mode mode)
 {
lapdm_entity_init(>lapdm_acch, mode, 2);
+   lc->lapdm_acch.lapdm_ch = lc;
/* FIXME: this depends on chan type */
lapdm_entity_init(>lapdm_dcch, mode, 1);
+   lc->lapdm_dcch.lapdm_ch = lc;
 }
 
 /*! flush and release all resoures in LAPDm entity */

-- 
To view, visit https://gerrit.osmocom.org/8034
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaca66cd6a2c9f315561e365b51163927868fc346
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 

[MERGED] docker-playground[master]: Add osmo-*-latest Dockerfiles

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Add osmo-*-latest Dockerfiles
..


Add osmo-*-latest Dockerfiles

Those containers are using the OBS-built "latest" packages on Debian 9

Change-Id: I6a564206dd81743deb1eb27eca7081bc333d7434
---
A osmo-bsc-latest/.release
A osmo-bsc-latest/Dockerfile
A osmo-bsc-latest/Makefile
A osmo-bsc-latest/Release.key
A osmo-bsc-latest/osmo-bsc.cfg
A osmo-bts-latest/.release
A osmo-bts-latest/Dockerfile
A osmo-bts-latest/Makefile
A osmo-bts-latest/Release.key
A osmo-bts-latest/osmo-bts.cfg
A osmo-bts-latest/respawn.sh
A osmo-ggsn-latest/.release
A osmo-ggsn-latest/Dockerfile
A osmo-ggsn-latest/Makefile
A osmo-ggsn-latest/Release.key
A osmo-ggsn-latest/osmo-ggsn.cfg
A osmo-hlr-latest/.release
A osmo-hlr-latest/Dockerfile
A osmo-hlr-latest/Makefile
A osmo-hlr-latest/Release.key
A osmo-hlr-latest/osmo-hlr.cfg
A osmo-hnbgw-latest/.release
A osmo-hnbgw-latest/Dockerfile
A osmo-hnbgw-latest/Makefile
A osmo-hnbgw-latest/Release.key
A osmo-hnbgw-latest/osmo-hnbgw.cfg
A osmo-mgw-latest/.release
A osmo-mgw-latest/Dockerfile
A osmo-mgw-latest/Makefile
A osmo-mgw-latest/Release.key
A osmo-mgw-latest/osmo-mgw.cfg
A osmo-msc-latest/.release
A osmo-msc-latest/Dockerfile
A osmo-msc-latest/Makefile
A osmo-msc-latest/Release.key
A osmo-msc-latest/osmo-msc.cfg
A osmo-sgsn-latest/.release
A osmo-sgsn-latest/Dockerfile
A osmo-sgsn-latest/Makefile
A osmo-sgsn-latest/Release.key
A osmo-sgsn-latest/osmo-sgsn.cfg
A osmo-sip-latest/.release
A osmo-sip-latest/Dockerfile
A osmo-sip-latest/Makefile
A osmo-sip-latest/Release.key
A osmo-sip-latest/osmo-sip-connector.cfg
A osmo-stp-latest/.release
A osmo-stp-latest/Dockerfile
A osmo-stp-latest/Makefile
A osmo-stp-latest/Release.key
A osmo-stp-latest/osmo-stp.cfg
51 files changed, 1,337 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/osmo-bsc-latest/.release b/osmo-bsc-latest/.release
new file mode 100644
index 000..07f178d
--- /dev/null
+++ b/osmo-bsc-latest/.release
@@ -0,0 +1,2 @@
+release=0.0.0
+tag=osmo-bsc-latest-0.0.0
diff --git a/osmo-bsc-latest/Dockerfile b/osmo-bsc-latest/Dockerfile
new file mode 100644
index 000..1682dea
--- /dev/null
+++ b/osmo-bsc-latest/Dockerfile
@@ -0,0 +1,34 @@
+FROM debian:stretch
+
+MAINTAINER Harald Welte 
+
+ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/;
+
+COPY   Release.key /tmp/Release.key
+
+RUNapt-get update && \
+   apt-get install -y --no-install-recommends \
+   gnupg
+
+RUNapt-key add /tmp/Release.key && \
+   rm /tmp/Release.key && \
+   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-latest.list
+
+ADD$OSMOCOM_REPO/Release /tmp/Release
+RUNapt-get update && \
+   apt-get install -y --no-install-recommends \
+   telnet \
+   osmo-bsc \
+   osmo-bsc-ipaccess-utils && \
+   apt-get clean
+
+WORKDIR/tmp
+
+VOLUME /data
+
+COPY   osmo-bsc.cfg /data/osmo-bsc.cfg
+
+WORKDIR/data
+CMD["/usr/bin/osmo-bsc", "-c", "/data/osmo-bsc.cfg"]
+
+EXPOSE 3003 3002 4242
diff --git a/osmo-bsc-latest/Makefile b/osmo-bsc-latest/Makefile
new file mode 100644
index 000..8d0e10b
--- /dev/null
+++ b/osmo-bsc-latest/Makefile
@@ -0,0 +1 @@
+include ../make/Makefile
diff --git a/osmo-bsc-latest/Release.key b/osmo-bsc-latest/Release.key
new file mode 100644
index 000..e656238
--- /dev/null
+++ b/osmo-bsc-latest/Release.key
@@ -0,0 +1,20 @@
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: GnuPG v1.4.5 (GNU/Linux)
+
+mQENBFJBt/wBCADAht3d/ilNuyzaXYw/QwTRvmjyoDvfXw+H/3Fvk1zlDZoiKPPc
+a1wCVBINUZl7vYM2OXqbJwYa++JP2Q48xKSvC6thbRc/YLievkbcvTemf7IaREfl
+CTjoYpoqXHa9kHMw1aALDm8CNU88jZmnV7v9L6hKkbYDxie+jpoj7D6B9JlxgNJ4
+5dQyRNsFGVcIl4Vplt1HyGc5Q5nQI/VgS2rlF/IOXmhRQBc4LEDdU8R2IKnkU4ee
+S7TWanAigGAQhxGuCkS39/CWzc1DhLhjlNhBl/+RTPejkqJtAy00ZLps3+RqUN1Y
+CU/Fsr7aRlYVGqQ/BlptwV0XQ2VVYJX2oEBBABEBAAG0MG5ldHdvcmsgT0JTIFBy
+b2plY3QgPG5ldHdvcmtAYnVpbGQub3BlbnN1c2Uub3JnPokBPAQTAQIAJgUCWmMc
+aQIbAwUJDEAUbQYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJEGLrGgkXKA3fjsoI
+ALSXmXzFCpTxg8a6tvXkqddY/qAmeBMNUf7hslI9wN3leNmCrnuHS8TbHWYJZgtw
+8M5fKL3aRQYaIiqqm1XOUF0OqwYNDj5V3y38mM68NYOkzgSP7foMwZp9Y0TlGhtI
+L8weA+2RUjB4hwwGMAYMqkRZyKW3NhPqdlGGoXac1ilwEyGXFHdOLbkhtyS+P2yb
+/EvaKIN5cMLzRZKeYgdp9WuAirV+yV/SDbgvabW098lrWhGLltlRRDQgMV883p8I
+ERMI1wlLFZGnHL3mfBWGeQ24M/DaBOdXQDtfBLCJ9nGztmDBUb8i6GFWU7nD2TGi
+8mYUsED1ZDwO/0jdvJ4gSluIRgQTEQIABgUCUkG3/AAKCRA7MBG3a51lIzhdAJ9v
+d6XPffMZRcCGgDEY5OaTn/MsCQCgrXbeZpFJgnirSrc8rRonvzYFiF4=
+=Gvly
+-END PGP PUBLIC KEY BLOCK-
diff --git a/osmo-bsc-latest/osmo-bsc.cfg b/osmo-bsc-latest/osmo-bsc.cfg
new file mode 100644
index 000..4176cae
--- /dev/null
+++ b/osmo-bsc-latest/osmo-bsc.cfg
@@ -0,0 +1,360 @@
+!
+! OsmoBSC (1.0.1.122-630df) configuration saved from vty
+!!

docker-playground[master]: Add osmo-*-latest Dockerfiles

[Harald Welte]

Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.osmocom.org/8030
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a564206dd81743deb1eb27eca7081bc333d7434
Gerrit-PatchSet: 1
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

[MERGED] libosmocore[master]: control_if: Avoid heap-use-after-free in osmo_wqueue_bfd_cb

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: control_if: Avoid heap-use-after-free in osmo_wqueue_bfd_cb
..


control_if: Avoid heap-use-after-free in osmo_wqueue_bfd_cb

Imagine following scenario:
1- client connects to CTRL iface, a new conn is created with POLL_READ
enabled.
2- A non-related event happens which triggers a TRAP to be sent. As a
result, the wqueue for the conn has now enabled POLL_WRITE, and message
will be sent next time we go through osmo_main_select().
3- At the same time, we receive the GET cmd from the CTRL client, which
means POLL_READ event will be also triggered next time we call
osmo_main_select().
4- osmo_main_select triggers osmo_wqueue_bfd_cb with both READ/WRITE
flags set.
5- The read_cb of wqueue is executed first. The handler closes the CTRL
conn for some reason, freeing the osmo_fd struct and returns.
6- osmo_qeueue_bfd_cb keeps using the already freed osmo_fd and calls
write_cb.

So in step 6 we get a heap-use-after-free catched by AddressSanitizer:

20180424135406115 DLCTRL <0018> control_if.c:506 accept()ed 
new CTRL connection from (r=10.42.42.1:53910<->l=10.42.42.7:4249)
20180424135406116 DLCTRL <0018> control_cmd.c:378 Command: GET 
bts.0.oml-connection-state
20180424135406117 DLINP <0013> bts_ipaccess_nanobts.c:417 
Identified BTS 1/0/0
20180424135406118 DNM <0005> abis_nm.c:1628 Get 
Attr (bts=0)
20180424135406118 DNM <0005> abis_nm.c:1628 Get 
Attr (bts=0)
20180424135406118 DCTRL <000e> osmo_bsc_ctrl.c:158 BTS 
connection (re)established, sending TRAP.
20180424135406119 DLCTRL <0018> control_if.c:173 close()d CTRL 
connection (r=10.42.42.1:53910<->l=10.42.42.7:4249)
=
==12301==ERROR: AddressSanitizer: heap-use-after-free on address 0x61103e04 
at pc 0x7f23091c3a2f bp 0x7ffc0cb73ff0 sp 0x7ffc0cb73fe8
READ of size 4 at 0x61103e04 thread T0
#0 0x7f23091c3a2e in osmo_wqueue_bfd_cb 
/home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bsc/libosmocore/src/write_queue.c:65
#1 0x7f23091ad5d8 in osmo_fd_disp_fds 
/home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bsc/libosmocore/src/select.c:216
#2 0x7f23091ad5d8 in osmo_select_main 
/home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bsc/libosmocore/src/select.c:256
#3 0x56538bdb7a26 in main 
/home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bsc/osmo-bsc/src/osmo-bsc/osmo_bsc_main.c:532
#4 0x7f23077532e0 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
#5 0x56538bdb8999 in _start 
(/home/jenkins/workspace/osmo-gsm-tester_run-prod/trial-896/inst/osmo-bsc/bin/osmo-bsc+0x25)

Fixes: OS#3206

Change-Id: I84d10caaadcfa6bd46ba8756ca89aa0badcfd2e3
---
M include/osmocom/core/write_queue.h
M src/ctrl/control_if.c
2 files changed, 25 insertions(+), 22 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/core/write_queue.h 
b/include/osmocom/core/write_queue.h
index 2303f87..071621d 100644
--- a/include/osmocom/core/write_queue.h
+++ b/include/osmocom/core/write_queue.h
@@ -42,11 +42,11 @@
/*! actual linked list implementing the queue */
struct llist_head msg_queue;
 
-   /*! call-back in case qeueue is readable */
+   /*! call-back in case qeueue is readable. Return -EBADF if fd is freed 
inside cb. */
int (*read_cb)(struct osmo_fd *fd);
-   /*! call-back in case qeueue is writable */
+   /*! call-back in case qeueue is writable. Return -EBADF if fd is freed 
inside cb. */
int (*write_cb)(struct osmo_fd *fd, struct msgb *msg);
-   /*! call-back in case qeueue has exceptions */
+   /*! call-back in case qeueue has exceptions. Return -EBADF if fd is 
freed inside cb. */
int (*except_cb)(struct osmo_fd *fd);
 };
 
diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c
index cc613ee..0ba2512 100644
--- a/src/ctrl/control_if.c
+++ b/src/ctrl/control_if.c
@@ -327,7 +327,7 @@
 
 static int handle_control_read(struct osmo_fd * bfd)
 {
-   int ret = -1;
+   int ret;
struct osmo_wqueue *queue;
struct ctrl_connection *ccon;
struct msgb *msg = NULL;
@@ -337,27 +337,28 @@
ccon = container_of(queue, struct ctrl_connection, write_queue);
 
ret = ipa_msg_recv_buffered(bfd->fd, , >pending_msg);
-   if (ret <= 0) {
-   if (ret == -EAGAIN)
-   /* received part of a message, it is stored in 
ccon->pending_msg and there's
-* nothing left to do now. */
-   return 0;
+   if (ret == 0) {
/* msg was already discarded. */
-   if (ret == 0) {
-  

[MERGED] libosmocore[master]: configure: Check separately for lib implementing dlopen and ...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: configure: Check separately for lib implementing dlopen and 
dlsym
..


configure: Check separately for lib implementing dlopen and dlsym

Sometimes the library probiding dlopen is not the same one providing
dlsym.
This is the case when compiling with AddressSanitizer enabled. In this
case, AC_SEARCH_LIBS([dlopen]...) reports no lib is required, but tests
using dlsym still require to link against -ldl.

Change-Id: Ic619b0885688066b60c97caf1e2c7e5402c1d9f7
---
M configure.ac
M src/Makefile.am
M tests/Makefile.am
3 files changed, 8 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index 7f2aabd..6f56176 100644
--- a/configure.ac
+++ b/configure.ac
@@ -58,8 +58,10 @@
 AC_CHECK_HEADERS(execinfo.h sys/select.h sys/socket.h syslog.h ctype.h 
netinet/tcp.h)
 # for src/conv.c
 AC_FUNC_ALLOCA
-AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""])
-AC_SUBST(LIBRARY_DL)
+AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DLOPEN="$LIBS";LIBS=""])
+AC_SUBST(LIBRARY_DLOPEN)
+AC_SEARCH_LIBS([dlsym], [dl dld], [LIBRARY_DLSYM="$LIBS";LIBS=""])
+AC_SUBST(LIBRARY_DLSYM)
 # for src/backtrace.c
 AC_CHECK_LIB(execinfo, backtrace, BACKTRACE_LIB=-lexecinfo, BACKTRACE_LIB=)
 AC_SUBST(BACKTRACE_LIB)
diff --git a/src/Makefile.am b/src/Makefile.am
index 60b76b5..2a77d5e 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -49,7 +49,7 @@
 
 if ENABLE_PLUGIN
 libosmocore_la_SOURCES += plugin.c
-libosmocore_la_LIBADD += $(LIBRARY_DL)
+libosmocore_la_LIBADD += $(LIBRARY_DLOPEN)
 endif
 
 if ENABLE_MSGFILE
diff --git a/tests/Makefile.am b/tests/Makefile.am
index cca128d..70b5cb8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -132,17 +132,17 @@
 $(top_builddir)/src/gsm/libosmogsm.la
 
 gb_gprs_bssgp_test_SOURCES = gb/gprs_bssgp_test.c
-gb_gprs_bssgp_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DL) \
+gb_gprs_bssgp_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
   $(top_builddir)/src/gsm/libosmogsm.la
 
 gb_gprs_ns_test_SOURCES = gb/gprs_ns_test.c
-gb_gprs_ns_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DL) \
+gb_gprs_ns_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
$(top_builddir)/src/gsm/libosmogsm.la
 
 logging_logging_test_SOURCES = logging/logging_test.c
 
 fr_fr_test_SOURCES = fr/fr_test.c
-fr_fr_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la $(LIBRARY_DL) \
+fr_fr_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
   $(top_builddir)/src/gsm/libosmogsm.la
 
 codec_codec_test_SOURCES = codec/codec_test.c

-- 
To view, visit https://gerrit.osmocom.org/8033
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic619b0885688066b60c97caf1e2c7e5402c1d9f7
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

libosmocore[master]: configure: Check separately for lib implementing dlopen and ...

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8033
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic619b0885688066b60c97caf1e2c7e5402c1d9f7
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] libosmocore[master]: configure: Check separately for lib implementing dlopen and ...

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/8033

configure: Check separately for lib implementing dlopen and dlsym

Sometimes the library probiding dlopen is not the same one providing
dlsym.
This is the case when compiling with AddressSanitizer enabled. In this
case, AC_SEARCH_LIBS([dlopen]...) reports no lib is required, but tests
using dlsym still require to link against -ldl.

Change-Id: Ic619b0885688066b60c97caf1e2c7e5402c1d9f7
---
M configure.ac
M src/Makefile.am
M tests/Makefile.am
3 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/8033/1

diff --git a/configure.ac b/configure.ac
index 7f2aabd..6f56176 100644
--- a/configure.ac
+++ b/configure.ac
@@ -58,8 +58,10 @@
 AC_CHECK_HEADERS(execinfo.h sys/select.h sys/socket.h syslog.h ctype.h 
netinet/tcp.h)
 # for src/conv.c
 AC_FUNC_ALLOCA
-AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""])
-AC_SUBST(LIBRARY_DL)
+AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DLOPEN="$LIBS";LIBS=""])
+AC_SUBST(LIBRARY_DLOPEN)
+AC_SEARCH_LIBS([dlsym], [dl dld], [LIBRARY_DLSYM="$LIBS";LIBS=""])
+AC_SUBST(LIBRARY_DLSYM)
 # for src/backtrace.c
 AC_CHECK_LIB(execinfo, backtrace, BACKTRACE_LIB=-lexecinfo, BACKTRACE_LIB=)
 AC_SUBST(BACKTRACE_LIB)
diff --git a/src/Makefile.am b/src/Makefile.am
index 60b76b5..2a77d5e 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -49,7 +49,7 @@
 
 if ENABLE_PLUGIN
 libosmocore_la_SOURCES += plugin.c
-libosmocore_la_LIBADD += $(LIBRARY_DL)
+libosmocore_la_LIBADD += $(LIBRARY_DLOPEN)
 endif
 
 if ENABLE_MSGFILE
diff --git a/tests/Makefile.am b/tests/Makefile.am
index cca128d..70b5cb8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -132,17 +132,17 @@
 $(top_builddir)/src/gsm/libosmogsm.la
 
 gb_gprs_bssgp_test_SOURCES = gb/gprs_bssgp_test.c
-gb_gprs_bssgp_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DL) \
+gb_gprs_bssgp_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
   $(top_builddir)/src/gsm/libosmogsm.la
 
 gb_gprs_ns_test_SOURCES = gb/gprs_ns_test.c
-gb_gprs_ns_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DL) \
+gb_gprs_ns_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
$(top_builddir)/src/gsm/libosmogsm.la
 
 logging_logging_test_SOURCES = logging/logging_test.c
 
 fr_fr_test_SOURCES = fr/fr_test.c
-fr_fr_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la $(LIBRARY_DL) \
+fr_fr_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
   $(top_builddir)/src/gsm/libosmogsm.la
 
 codec_codec_test_SOURCES = codec/codec_test.c

-- 
To view, visit https://gerrit.osmocom.org/8033
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic619b0885688066b60c97caf1e2c7e5402c1d9f7
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

[MERGED] osmo-hlr[master]: Bump version: 0.2.0.3-1b8a → 0.2.1

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: Bump version: 0.2.0.3-1b8a → 0.2.1
..


Bump version: 0.2.0.3-1b8a → 0.2.1

Change-Id: I9c457e9baeb546bfefacacd48996902e587a
---
M debian/changelog
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index dce4dd4..3763f55 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+osmo-hlr (0.2.1) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * fix luop crash: use buffer for APN that remains valid
+  * add gsup_test to catch OS#3231
+  * add error handling to osmo_gsup_configure_wildcard_apn()
+
+ -- Pau Espin Pedrol   Fri, 04 May 2018 18:41:35 +0200
+
 osmo-hlr (0.2.0) unstable; urgency=medium
 
   [ Neels Hofmeyr ]

-- 
To view, visit https://gerrit.osmocom.org/8032
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c457e9baeb546bfefacacd48996902e587a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

libosmocore[master]: control_if: Avoid heap-use-after-free in osmo_wqueue_bfd_cb

[Harald Welte]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/8031
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84d10caaadcfa6bd46ba8756ca89aa0badcfd2e3
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

osmo-hlr[master]: Bump version: 0.2.0.3-1b8a → 0.2.1

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8032
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c457e9baeb546bfefacacd48996902e587a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

libosmocore[master]: configure.ac: check clock_gettime for glib < 2.17

[Pau Espin Pedrol]

Patch Set 1: Code-Review-1

-- 
To view, visit https://gerrit.osmocom.org/7907
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice853d85ffe859b1d4df48b91b050c24d85c861b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

libosmocore[master]: configure.ac: check clock_gettime for glib < 2.17

[Pau Espin Pedrol]

Patch Set 1:

Similar thing is already done for ldl in libosmocore:

configure.ac:
AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""])
AC_SUBST(LIBRARY_DL)

src/Makefile.am:
52:libosmocore_la_LIBADD += $(LIBRARY_DL)

-- 
To view, visit https://gerrit.osmocom.org/7907
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice853d85ffe859b1d4df48b91b050c24d85c861b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-HasComments: No

[PATCH] osmo-hlr[master]: Bump version: 0.2.0.3-1b8a → 0.2.1

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/8032

Bump version: 0.2.0.3-1b8a → 0.2.1

Change-Id: I9c457e9baeb546bfefacacd48996902e587a
---
M debian/changelog
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/32/8032/1

diff --git a/debian/changelog b/debian/changelog
index dce4dd4..3763f55 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+osmo-hlr (0.2.1) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * fix luop crash: use buffer for APN that remains valid
+  * add gsup_test to catch OS#3231
+  * add error handling to osmo_gsup_configure_wildcard_apn()
+
+ -- Pau Espin Pedrol   Fri, 04 May 2018 18:41:35 +0200
+
 osmo-hlr (0.2.0) unstable; urgency=medium
 
   [ Neels Hofmeyr ]

-- 
To view, visit https://gerrit.osmocom.org/8032
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c457e9baeb546bfefacacd48996902e587a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

[PATCH] libosmocore[master]: control_if: Avoid heap-use-after-free in osmo_wqueue_bfd_cb

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/8031

control_if: Avoid heap-use-after-free in osmo_wqueue_bfd_cb

Imagine following scenario:
1- client connects to CTRL iface, a new conn is created with POLL_READ
enabled.
2- A non-related event happens which triggers a TRAP to be sent. As a
result, the wqueue for the conn has now enabled POLL_WRITE, and message
will be sent next time we go through osmo_main_select().
3- At the same time, we receive the GET cmd from the CTRL client, which
means POLL_READ event will be also triggered next time we call
osmo_main_select().
4- osmo_main_select triggers osmo_wqueue_bfd_cb with both READ/WRITE
flags set.
5- The read_cb of wqueue is executed first. The handler closes the CTRL
conn for some reason, freeing the osmo_fd struct and returns.
6- osmo_qeueue_bfd_cb keeps using the already freed osmo_fd and calls
write_cb.

So in step 6 we get a heap-use-after-free catched by AddressSanitizer:

20180424135406115 DLCTRL <0018> control_if.c:506 accept()ed 
new CTRL connection from (r=10.42.42.1:53910<->l=10.42.42.7:4249)
20180424135406116 DLCTRL <0018> control_cmd.c:378 Command: GET 
bts.0.oml-connection-state
20180424135406117 DLINP <0013> bts_ipaccess_nanobts.c:417 
Identified BTS 1/0/0
20180424135406118 DNM <0005> abis_nm.c:1628 Get 
Attr (bts=0)
20180424135406118 DNM <0005> abis_nm.c:1628 Get 
Attr (bts=0)
20180424135406118 DCTRL <000e> osmo_bsc_ctrl.c:158 BTS 
connection (re)established, sending TRAP.
20180424135406119 DLCTRL <0018> control_if.c:173 close()d CTRL 
connection (r=10.42.42.1:53910<->l=10.42.42.7:4249)
=
==12301==ERROR: AddressSanitizer: heap-use-after-free on address 0x61103e04 
at pc 0x7f23091c3a2f bp 0x7ffc0cb73ff0 sp 0x7ffc0cb73fe8
READ of size 4 at 0x61103e04 thread T0
#0 0x7f23091c3a2e in osmo_wqueue_bfd_cb 
/home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bsc/libosmocore/src/write_queue.c:65
#1 0x7f23091ad5d8 in osmo_fd_disp_fds 
/home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bsc/libosmocore/src/select.c:216
#2 0x7f23091ad5d8 in osmo_select_main 
/home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bsc/libosmocore/src/select.c:256
#3 0x56538bdb7a26 in main 
/home/osmocom-build/jenkins/workspace/osmo-gsm-tester_build-osmo-bsc/osmo-bsc/src/osmo-bsc/osmo_bsc_main.c:532
#4 0x7f23077532e0 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
#5 0x56538bdb8999 in _start 
(/home/jenkins/workspace/osmo-gsm-tester_run-prod/trial-896/inst/osmo-bsc/bin/osmo-bsc+0x25)

Fixes: OS#3206

Change-Id: I84d10caaadcfa6bd46ba8756ca89aa0badcfd2e3
---
M include/osmocom/core/write_queue.h
M src/ctrl/control_if.c
2 files changed, 25 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/8031/1

diff --git a/include/osmocom/core/write_queue.h 
b/include/osmocom/core/write_queue.h
index 2303f87..071621d 100644
--- a/include/osmocom/core/write_queue.h
+++ b/include/osmocom/core/write_queue.h
@@ -42,11 +42,11 @@
/*! actual linked list implementing the queue */
struct llist_head msg_queue;
 
-   /*! call-back in case qeueue is readable */
+   /*! call-back in case qeueue is readable. Return -EBADF if fd is freed 
inside cb. */
int (*read_cb)(struct osmo_fd *fd);
-   /*! call-back in case qeueue is writable */
+   /*! call-back in case qeueue is writable. Return -EBADF if fd is freed 
inside cb. */
int (*write_cb)(struct osmo_fd *fd, struct msgb *msg);
-   /*! call-back in case qeueue has exceptions */
+   /*! call-back in case qeueue has exceptions. Return -EBADF if fd is 
freed inside cb. */
int (*except_cb)(struct osmo_fd *fd);
 };
 
diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c
index cc613ee..0ba2512 100644
--- a/src/ctrl/control_if.c
+++ b/src/ctrl/control_if.c
@@ -327,7 +327,7 @@
 
 static int handle_control_read(struct osmo_fd * bfd)
 {
-   int ret = -1;
+   int ret;
struct osmo_wqueue *queue;
struct ctrl_connection *ccon;
struct msgb *msg = NULL;
@@ -337,27 +337,28 @@
ccon = container_of(queue, struct ctrl_connection, write_queue);
 
ret = ipa_msg_recv_buffered(bfd->fd, , >pending_msg);
-   if (ret <= 0) {
-   if (ret == -EAGAIN)
-   /* received part of a message, it is stored in 
ccon->pending_msg and there's
-* nothing left to do now. */
-   return 0;
+   if (ret == 0) {
/* msg was already discarded. */
-   if (ret == 0) {
-   control_close_conn(ccon);
-   ret = -EIO;
-   }
-   else
-   LOGP(DLCTRL, LOGL_ERROR, 

[PATCH] docker-playground[master]: Add osmo-*-latest Dockerfiles

[Harald Welte]

Review at  https://gerrit.osmocom.org/8030

Add osmo-*-latest Dockerfiles

Those containers are using the OBS-built "latest" packages on Debian 9

Change-Id: I6a564206dd81743deb1eb27eca7081bc333d7434
---
A osmo-bsc-latest/.release
A osmo-bsc-latest/Dockerfile
A osmo-bsc-latest/Makefile
A osmo-bsc-latest/Release.key
A osmo-bsc-latest/osmo-bsc.cfg
A osmo-bts-latest/.release
A osmo-bts-latest/Dockerfile
A osmo-bts-latest/Makefile
A osmo-bts-latest/Release.key
A osmo-bts-latest/osmo-bts.cfg
A osmo-bts-latest/respawn.sh
A osmo-ggsn-latest/.release
A osmo-ggsn-latest/Dockerfile
A osmo-ggsn-latest/Makefile
A osmo-ggsn-latest/Release.key
A osmo-ggsn-latest/osmo-ggsn.cfg
A osmo-hlr-latest/.release
A osmo-hlr-latest/Dockerfile
A osmo-hlr-latest/Makefile
A osmo-hlr-latest/Release.key
A osmo-hlr-latest/osmo-hlr.cfg
A osmo-hnbgw-latest/.release
A osmo-hnbgw-latest/Dockerfile
A osmo-hnbgw-latest/Makefile
A osmo-hnbgw-latest/Release.key
A osmo-hnbgw-latest/osmo-hnbgw.cfg
A osmo-mgw-latest/.release
A osmo-mgw-latest/Dockerfile
A osmo-mgw-latest/Makefile
A osmo-mgw-latest/Release.key
A osmo-mgw-latest/osmo-mgw.cfg
A osmo-msc-latest/.release
A osmo-msc-latest/Dockerfile
A osmo-msc-latest/Makefile
A osmo-msc-latest/Release.key
A osmo-msc-latest/osmo-msc.cfg
A osmo-sgsn-latest/.release
A osmo-sgsn-latest/Dockerfile
A osmo-sgsn-latest/Makefile
A osmo-sgsn-latest/Release.key
A osmo-sgsn-latest/osmo-sgsn.cfg
A osmo-sip-latest/.release
A osmo-sip-latest/Dockerfile
A osmo-sip-latest/Makefile
A osmo-sip-latest/Release.key
A osmo-sip-latest/osmo-sip-connector.cfg
A osmo-stp-latest/.release
A osmo-stp-latest/Dockerfile
A osmo-stp-latest/Makefile
A osmo-stp-latest/Release.key
A osmo-stp-latest/osmo-stp.cfg
51 files changed, 1,337 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/30/8030/1

diff --git a/osmo-bsc-latest/.release b/osmo-bsc-latest/.release
new file mode 100644
index 000..07f178d
--- /dev/null
+++ b/osmo-bsc-latest/.release
@@ -0,0 +1,2 @@
+release=0.0.0
+tag=osmo-bsc-latest-0.0.0
diff --git a/osmo-bsc-latest/Dockerfile b/osmo-bsc-latest/Dockerfile
new file mode 100644
index 000..1682dea
--- /dev/null
+++ b/osmo-bsc-latest/Dockerfile
@@ -0,0 +1,34 @@
+FROM debian:stretch
+
+MAINTAINER Harald Welte 
+
+ARG
OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/;
+
+COPY   Release.key /tmp/Release.key
+
+RUNapt-get update && \
+   apt-get install -y --no-install-recommends \
+   gnupg
+
+RUNapt-key add /tmp/Release.key && \
+   rm /tmp/Release.key && \
+   echo "deb " $OSMOCOM_REPO " ./" > 
/etc/apt/sources.list.d/osmocom-latest.list
+
+ADD$OSMOCOM_REPO/Release /tmp/Release
+RUNapt-get update && \
+   apt-get install -y --no-install-recommends \
+   telnet \
+   osmo-bsc \
+   osmo-bsc-ipaccess-utils && \
+   apt-get clean
+
+WORKDIR/tmp
+
+VOLUME /data
+
+COPY   osmo-bsc.cfg /data/osmo-bsc.cfg
+
+WORKDIR/data
+CMD["/usr/bin/osmo-bsc", "-c", "/data/osmo-bsc.cfg"]
+
+EXPOSE 3003 3002 4242
diff --git a/osmo-bsc-latest/Makefile b/osmo-bsc-latest/Makefile
new file mode 100644
index 000..8d0e10b
--- /dev/null
+++ b/osmo-bsc-latest/Makefile
@@ -0,0 +1 @@
+include ../make/Makefile
diff --git a/osmo-bsc-latest/Release.key b/osmo-bsc-latest/Release.key
new file mode 100644
index 000..e656238
--- /dev/null
+++ b/osmo-bsc-latest/Release.key
@@ -0,0 +1,20 @@
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: GnuPG v1.4.5 (GNU/Linux)
+
+mQENBFJBt/wBCADAht3d/ilNuyzaXYw/QwTRvmjyoDvfXw+H/3Fvk1zlDZoiKPPc
+a1wCVBINUZl7vYM2OXqbJwYa++JP2Q48xKSvC6thbRc/YLievkbcvTemf7IaREfl
+CTjoYpoqXHa9kHMw1aALDm8CNU88jZmnV7v9L6hKkbYDxie+jpoj7D6B9JlxgNJ4
+5dQyRNsFGVcIl4Vplt1HyGc5Q5nQI/VgS2rlF/IOXmhRQBc4LEDdU8R2IKnkU4ee
+S7TWanAigGAQhxGuCkS39/CWzc1DhLhjlNhBl/+RTPejkqJtAy00ZLps3+RqUN1Y
+CU/Fsr7aRlYVGqQ/BlptwV0XQ2VVYJX2oEBBABEBAAG0MG5ldHdvcmsgT0JTIFBy
+b2plY3QgPG5ldHdvcmtAYnVpbGQub3BlbnN1c2Uub3JnPokBPAQTAQIAJgUCWmMc
+aQIbAwUJDEAUbQYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJEGLrGgkXKA3fjsoI
+ALSXmXzFCpTxg8a6tvXkqddY/qAmeBMNUf7hslI9wN3leNmCrnuHS8TbHWYJZgtw
+8M5fKL3aRQYaIiqqm1XOUF0OqwYNDj5V3y38mM68NYOkzgSP7foMwZp9Y0TlGhtI
+L8weA+2RUjB4hwwGMAYMqkRZyKW3NhPqdlGGoXac1ilwEyGXFHdOLbkhtyS+P2yb
+/EvaKIN5cMLzRZKeYgdp9WuAirV+yV/SDbgvabW098lrWhGLltlRRDQgMV883p8I
+ERMI1wlLFZGnHL3mfBWGeQ24M/DaBOdXQDtfBLCJ9nGztmDBUb8i6GFWU7nD2TGi
+8mYUsED1ZDwO/0jdvJ4gSluIRgQTEQIABgUCUkG3/AAKCRA7MBG3a51lIzhdAJ9v
+d6XPffMZRcCGgDEY5OaTn/MsCQCgrXbeZpFJgnirSrc8rRonvzYFiF4=
+=Gvly
+-END PGP PUBLIC KEY BLOCK-
diff --git a/osmo-bsc-latest/osmo-bsc.cfg b/osmo-bsc-latest/osmo-bsc.cfg
new file mode 100644
index 000..4176cae
--- /dev/null
+++ b/osmo-bsc-latest/osmo-bsc.cfg
@@ -0,0 +1,360 @@
+!
+! OsmoBSC (1.0.1.122-630df) configuration saved from vty
+!!
+password foo
+!
+log stderr
+  logging filter all 1
+  logging color 1
+  logging print category 0
+  logging timestamp 

Jenkins build is back to normal : master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #112

[jenkins]

See 

[MERGED] osmo-hlr[master]: add error handling to osmo_gsup_configure_wildcard_apn()

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: add error handling to osmo_gsup_configure_wildcard_apn()
..


add error handling to osmo_gsup_configure_wildcard_apn()

Follow-up to I83d9ef2868bbb01e3f1ddb7920fe735aca172b15 as requested in code 
review.

Change-Id: Ifcee1e0d275741c1172b208600851861adb13238
---
M src/gsup_server.c
M src/gsup_server.h
M src/hlr.c
M src/luop.c
4 files changed, 20 insertions(+), 8 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsup_server.c b/src/gsup_server.c
index 03a6f56..07d4feb 100644
--- a/src/gsup_server.c
+++ b/src/gsup_server.c
@@ -337,15 +337,16 @@
 
 /* Set GSUP message's pdp_infos[0] to a wildcard APN.
  * Use the provided apn_buf to store the produced APN data. This must remain 
valid until
- * osmo_gsup_encode() is done. */
-void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
- uint8_t *apn_buf, size_t apn_buf_size)
+ * osmo_gsup_encode() is done. Return 0 if an entry was added, -ENOMEM if the 
provided buffer is too
+ * small. */
+int osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
+uint8_t *apn_buf, size_t apn_buf_size)
 {
int l;
 
l = osmo_apn_from_str(apn_buf, apn_buf_size, "*");
if (l <= 0)
-   return;
+   return -ENOMEM;
 
gsup->pdp_infos[0].apn_enc = apn_buf;
gsup->pdp_infos[0].apn_enc_len = l;
@@ -353,4 +354,6 @@
gsup->num_pdp_infos = 1;
/* FIXME: use real value: */
gsup->pdp_infos[0].context_id = 1;
+
+   return 0;
 }
diff --git a/src/gsup_server.h b/src/gsup_server.h
index b52b783..66c1a9c 100644
--- a/src/gsup_server.h
+++ b/src/gsup_server.h
@@ -53,5 +53,5 @@
 
 void osmo_gsup_server_destroy(struct osmo_gsup_server *gsups);
 
-void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
- uint8_t *apn_buf, size_t apn_buf_size);
+int osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
+uint8_t *apn_buf, size_t apn_buf_size);
diff --git a/src/hlr.c b/src/hlr.c
index cab34f0..1c72f45 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -98,7 +98,11 @@
 
/* FIXME: PDP infos - use more fine-grained access 
control
   instead of wildcard APN */
-   osmo_gsup_configure_wildcard_apn(, apn, 
sizeof(apn));
+   if (osmo_gsup_configure_wildcard_apn(, apn, 
sizeof(apn))) {
+   LOGP(DMAIN, LOGL_ERROR, "%s: Error: cannot 
encode wildcard APN\n",
+subscr->imsi);
+   continue;
+   }
} else if (co->supports_cs) {
gsup.cn_domain = OSMO_GSUP_CN_DOMAIN_CS;
} else {
diff --git a/src/luop.c b/src/luop.c
index edf4c51..db7b3c9 100644
--- a/src/luop.c
+++ b/src/luop.c
@@ -242,7 +242,12 @@
if (luop->is_ps) {
/* FIXME: PDP infos - use more fine-grained access control
   instead of wildcard APN */
-   osmo_gsup_configure_wildcard_apn(, apn, sizeof(apn));
+   if (osmo_gsup_configure_wildcard_apn(, apn, sizeof(apn))) {
+   LOGP(DMAIN, LOGL_ERROR, "%s: Error: cannot encode 
wildcard APN\n",
+luop->subscr.imsi);
+   lu_op_tx_error(luop, GMM_CAUSE_PROTO_ERR_UNSPEC);
+   return;
+   }
}
 
/* Send ISD to new VLR/SGSN */

-- 
To view, visit https://gerrit.osmocom.org/8029
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcee1e0d275741c1172b208600851861adb13238
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

[MERGED] osmo-hlr[master]: add gsup_test to catch OS#3231

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: add gsup_test to catch OS#3231
..


add gsup_test to catch OS#3231

Encode an Insert Subscr Data with is_ps == true to trigger the encoding bug
described in OS#3231, i.e. show that it is fixed.

Move osmo_gsup_addr_send() to a separate .c file, so that it can be overridden
in the regression test to just dump the msgb instead.

I used this test to reproduce issue OS#3231, and now that it's here we might as
well keep it, and possibly expand on it in the future.

Related: OS#3231
Change-Id: Id1453351758f3e1a9ff03bd99fefaf51886e77da
---
M configure.ac
M src/Makefile.am
A src/gsup_send.c
M src/luop.c
M src/luop.h
M tests/Makefile.am
A tests/gsup/Makefile.am
A tests/gsup/gsup_test.c
A tests/gsup/gsup_test.err
A tests/gsup/gsup_test.ok
M tests/testsuite.at
11 files changed, 191 insertions(+), 17 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index a632a1d..cedba45 100644
--- a/configure.ac
+++ b/configure.ac
@@ -104,5 +104,6 @@
tests/auc/Makefile
tests/auc/gen_ts_55_205_test_sets/Makefile
tests/gsup_server/Makefile
+   tests/gsup/Makefile
tests/db/Makefile
)
diff --git a/src/Makefile.am b/src/Makefile.am
index 60fc479..ea5023d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -52,6 +52,7 @@
rand_urandom.c \
hlr_vty.c \
hlr_vty_subscr.c \
+   gsup_send.c \
$(NULL)
 
 osmo_hlr_LDADD = \
diff --git a/src/gsup_send.c b/src/gsup_send.c
new file mode 100644
index 000..b2c4e02
--- /dev/null
+++ b/src/gsup_send.c
@@ -0,0 +1,45 @@
+/* (C) 2018 by sysmocom - s.f.m.c. GmbH 
+ *
+ * All Rights Reserved
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see .
+ *
+ */
+
+/* This is kept separate to be able to override the actual sending functions 
from unit tests. */
+
+#include 
+
+#include "gsup_server.h"
+#include "gsup_router.h"
+
+#include 
+
+/* Send a msgb to a given address using routing */
+int osmo_gsup_addr_send(struct osmo_gsup_server *gs,
+   const uint8_t *addr, size_t addrlen,
+   struct msgb *msg)
+{
+   struct osmo_gsup_conn *conn;
+
+   conn = gsup_route_find(gs, addr, addrlen);
+   if (!conn) {
+   DEBUGP(DLGSUP, "Cannot find route for addr %s\n", addr);
+   msgb_free(msg);
+   return -ENODEV;
+   }
+
+   return osmo_gsup_conn_send(conn, msg);
+}
+
diff --git a/src/luop.c b/src/luop.c
index 54c3884..edf4c51 100644
--- a/src/luop.c
+++ b/src/luop.c
@@ -165,23 +165,6 @@
luop->state = new_state;
 }
 
-/* Send a msgb to a given address using routing */
-int osmo_gsup_addr_send(struct osmo_gsup_server *gs,
-   const uint8_t *addr, size_t addrlen,
-   struct msgb *msg)
-{
-   struct osmo_gsup_conn *conn;
-
-   conn = gsup_route_find(gs, addr, addrlen);
-   if (!conn) {
-   DEBUGP(DMAIN, "Cannot find route for addr %s\n", addr);
-   msgb_free(msg);
-   return -ENODEV;
-   }
-
-   return osmo_gsup_conn_send(conn, msg);
-}
-
 /*! Transmit UPD_LOC_ERROR and destroy lu_operation */
 void lu_op_tx_error(struct lu_operation *luop, enum gsm48_gmm_cause cause)
 {
diff --git a/src/luop.h b/src/luop.h
index 053a025..d690243 100644
--- a/src/luop.h
+++ b/src/luop.h
@@ -28,6 +28,7 @@
 #include 
 
 #include "db.h"
+#include "gsup_server.h"
 
 #define CANCEL_TIMEOUT_SECS30
 #define ISD_TIMEOUT_SECS   30
diff --git a/tests/Makefile.am b/tests/Makefile.am
index f1cc710..58679ed 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -2,6 +2,7 @@
auc \
gsup_server \
db \
+   gsup \
$(NULL)
 
 # The `:;' works around a Bash 3.2 bug when the output is not writeable.
diff --git a/tests/gsup/Makefile.am b/tests/gsup/Makefile.am
new file mode 100644
index 000..7c33dbd
--- /dev/null
+++ b/tests/gsup/Makefile.am
@@ -0,0 +1,41 @@
+AM_CPPFLAGS = \
+   $(all_includes) \
+   -I$(top_srcdir)/src \
+   $(NULL)
+
+AM_CFLAGS = \
+   -Wall \
+   -ggdb3 \
+   $(LIBOSMOCORE_CFLAGS) \
+   $(LIBOSMOGSM_CFLAGS) \
+   

osmo-hlr[master]: add gsup_test to catch OS#3231

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8028
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1453351758f3e1a9ff03bd99fefaf51886e77da
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-hlr[master]: fix luop crash: use buffer for APN that remains valid

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: fix luop crash: use buffer for APN that remains valid
..


fix luop crash: use buffer for APN that remains valid

In osmo_gsup_configure_wildcard_apn(), do not compose APN into a local buffer
that becomes invalid as soon as the function exits. Instead, use a caller
provided buf.

Fixes OS#3231 crash:

  ==20030==ERROR: AddressSanitizer: stack-buffer-underflow on address 
0x7fffd9c0 at pc 0x76e9b6c2 bp 0x7fffd900 sp 0x7fffd0b0
  READ of size 2 at 0x7fffd9c0 thread T0
  #0 0x76e9b6c1  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x766c1)
  #1 0x76314419 in tlv_put 
../../../../src/libosmocore/include/osmocom/gsm/tlv.h:107
  #2 0x76314419 in msgb_tlv_put 
../../../../src/libosmocore/include/osmocom/gsm/tlv.h:299
  #3 0x76314419 in encode_pdp_info 
../../../../src/libosmocore/src/gsm/gsup.c:419
  #4 0x76314419 in osmo_gsup_encode 
../../../../src/libosmocore/src/gsm/gsup.c:535
  #5 0x55580016 in _luop_tx_gsup ../../../src/osmo-hlr/src/luop.c:54
  #6 0x555809d8 in lu_op_tx_insert_subscr_data 
../../../src/osmo-hlr/src/luop.c:264
  #7 0x5558b356 in rx_upd_loc_req ../../../src/osmo-hlr/src/hlr.c:306
  #8 0x5558b356 in read_cb ../../../src/osmo-hlr/src/hlr.c:365
  #9 0x55586671 in osmo_gsup_server_read_cb 
../../../src/osmo-hlr/src/gsup_server.c:105
  #10 0x75b35911 in ipa_server_conn_read 
../../../src/libosmo-abis/src/input/ipa.c:356
  #11 0x75b35911 in ipa_server_conn_cb 
../../../src/libosmo-abis/src/input/ipa.c:387
  #12 0x75e5541f in osmo_fd_disp_fds 
../../../src/libosmocore/src/select.c:216
  #13 0x75e5541f in osmo_select_main 
../../../src/libosmocore/src/select.c:256
  #14 0x555791b6 in main ../../../src/osmo-hlr/src/hlr.c:600
  #15 0x74707a86 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x21a86)
  #16 0x55579679 in _start (/usr/local/bin/osmo-hlr+0x25679)

  Address 0x7fffd9c0 is located in stack of thread T0 at offset 16 in frame
  #0 0x763131ff in osmo_gsup_encode 
../../../../src/libosmocore/src/gsm/gsup.c:481

This frame has 1 object(s):
  [32, 64) 'bcd_buf' <== Memory access at offset 16 underflows this variable

Related: OS#3231
Change-Id: I83d9ef2868bbb01e3f1ddb7920fe735aca172b15
---
M src/gsup_server.c
M src/gsup_server.h
M src/hlr.c
M src/luop.c
4 files changed, 15 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsup_server.c b/src/gsup_server.c
index 24ba738..03a6f56 100644
--- a/src/gsup_server.c
+++ b/src/gsup_server.c
@@ -335,16 +335,19 @@
talloc_free(gsups);
 }
 
-void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup)
+/* Set GSUP message's pdp_infos[0] to a wildcard APN.
+ * Use the provided apn_buf to store the produced APN data. This must remain 
valid until
+ * osmo_gsup_encode() is done. */
+void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
+ uint8_t *apn_buf, size_t apn_buf_size)
 {
int l;
-   uint8_t apn[APN_MAXLEN];
 
-   l = osmo_apn_from_str(apn, sizeof(apn), "*");
+   l = osmo_apn_from_str(apn_buf, apn_buf_size, "*");
if (l <= 0)
return;
 
-   gsup->pdp_infos[0].apn_enc = apn;
+   gsup->pdp_infos[0].apn_enc = apn_buf;
gsup->pdp_infos[0].apn_enc_len = l;
gsup->pdp_infos[0].have_info = 1;
gsup->num_pdp_infos = 1;
diff --git a/src/gsup_server.h b/src/gsup_server.h
index 3d36bff..b52b783 100644
--- a/src/gsup_server.h
+++ b/src/gsup_server.h
@@ -53,4 +53,5 @@
 
 void osmo_gsup_server_destroy(struct osmo_gsup_server *gsups);
 
-void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup);
+void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
+ uint8_t *apn_buf, size_t apn_buf_size);
diff --git a/src/hlr.c b/src/hlr.c
index 195e5d2..cab34f0 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "db.h"
 #include "hlr.h"
@@ -67,6 +68,7 @@
uint8_t *peer;
int peer_len;
uint8_t msisdn_enc[43]; /* TODO use constant; TS 24.008 
10.5.4.7 */
+   uint8_t apn[APN_MAXLEN];
int len;
struct msgb *msg_out;
 
@@ -96,7 +98,7 @@
 
/* FIXME: PDP infos - use more fine-grained access 
control
   instead of wildcard APN */
-   osmo_gsup_configure_wildcard_apn();
+   osmo_gsup_configure_wildcard_apn(, apn, 
sizeof(apn));
} else if (co->supports_cs) {
gsup.cn_domain = OSMO_GSUP_CN_DOMAIN_CS;
} else {

osmo-hlr[master]: add error handling to osmo_gsup_configure_wildcard_apn()

[Pau Espin Pedrol]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/8029
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcee1e0d275741c1172b208600851861adb13238
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[PATCH] osmo-hlr[master]: add error handling to osmo_gsup_configure_wildcard_apn()

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/8029

add error handling to osmo_gsup_configure_wildcard_apn()

Follow-up to I83d9ef2868bbb01e3f1ddb7920fe735aca172b15 as requested in code 
review.

Change-Id: Ifcee1e0d275741c1172b208600851861adb13238
---
M src/gsup_server.c
M src/gsup_server.h
M src/hlr.c
M src/luop.c
4 files changed, 20 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/29/8029/1

diff --git a/src/gsup_server.c b/src/gsup_server.c
index 03a6f56..07d4feb 100644
--- a/src/gsup_server.c
+++ b/src/gsup_server.c
@@ -337,15 +337,16 @@
 
 /* Set GSUP message's pdp_infos[0] to a wildcard APN.
  * Use the provided apn_buf to store the produced APN data. This must remain 
valid until
- * osmo_gsup_encode() is done. */
-void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
- uint8_t *apn_buf, size_t apn_buf_size)
+ * osmo_gsup_encode() is done. Return 0 if an entry was added, -ENOMEM if the 
provided buffer is too
+ * small. */
+int osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
+uint8_t *apn_buf, size_t apn_buf_size)
 {
int l;
 
l = osmo_apn_from_str(apn_buf, apn_buf_size, "*");
if (l <= 0)
-   return;
+   return -ENOMEM;
 
gsup->pdp_infos[0].apn_enc = apn_buf;
gsup->pdp_infos[0].apn_enc_len = l;
@@ -353,4 +354,6 @@
gsup->num_pdp_infos = 1;
/* FIXME: use real value: */
gsup->pdp_infos[0].context_id = 1;
+
+   return 0;
 }
diff --git a/src/gsup_server.h b/src/gsup_server.h
index b52b783..66c1a9c 100644
--- a/src/gsup_server.h
+++ b/src/gsup_server.h
@@ -53,5 +53,5 @@
 
 void osmo_gsup_server_destroy(struct osmo_gsup_server *gsups);
 
-void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
- uint8_t *apn_buf, size_t apn_buf_size);
+int osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
+uint8_t *apn_buf, size_t apn_buf_size);
diff --git a/src/hlr.c b/src/hlr.c
index cab34f0..1c72f45 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -98,7 +98,11 @@
 
/* FIXME: PDP infos - use more fine-grained access 
control
   instead of wildcard APN */
-   osmo_gsup_configure_wildcard_apn(, apn, 
sizeof(apn));
+   if (osmo_gsup_configure_wildcard_apn(, apn, 
sizeof(apn))) {
+   LOGP(DMAIN, LOGL_ERROR, "%s: Error: cannot 
encode wildcard APN\n",
+subscr->imsi);
+   continue;
+   }
} else if (co->supports_cs) {
gsup.cn_domain = OSMO_GSUP_CN_DOMAIN_CS;
} else {
diff --git a/src/luop.c b/src/luop.c
index edf4c51..db7b3c9 100644
--- a/src/luop.c
+++ b/src/luop.c
@@ -242,7 +242,12 @@
if (luop->is_ps) {
/* FIXME: PDP infos - use more fine-grained access control
   instead of wildcard APN */
-   osmo_gsup_configure_wildcard_apn(, apn, sizeof(apn));
+   if (osmo_gsup_configure_wildcard_apn(, apn, sizeof(apn))) {
+   LOGP(DMAIN, LOGL_ERROR, "%s: Error: cannot encode 
wildcard APN\n",
+luop->subscr.imsi);
+   lu_op_tx_error(luop, GMM_CAUSE_PROTO_ERR_UNSPEC);
+   return;
+   }
}
 
/* Send ISD to new VLR/SGSN */

-- 
To view, visit https://gerrit.osmocom.org/8029
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcee1e0d275741c1172b208600851861adb13238
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

osmo-hlr[master]: fix luop crash: use buffer for APN that remains valid

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8027
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83d9ef2868bbb01e3f1ddb7920fe735aca172b15
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] osmo-hlr[master]: fix luop crash: use buffer for APN that remains valid

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/8027

fix luop crash: use buffer for APN that remains valid

In osmo_gsup_configure_wildcard_apn(), do not compose APN into a local buffer
that becomes invalid as soon as the function exits. Instead, use a caller
provided buf.

Fixes OS#3231 crash:

  ==20030==ERROR: AddressSanitizer: stack-buffer-underflow on address 
0x7fffd9c0 at pc 0x76e9b6c2 bp 0x7fffd900 sp 0x7fffd0b0
  READ of size 2 at 0x7fffd9c0 thread T0
  #0 0x76e9b6c1  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x766c1)
  #1 0x76314419 in tlv_put 
../../../../src/libosmocore/include/osmocom/gsm/tlv.h:107
  #2 0x76314419 in msgb_tlv_put 
../../../../src/libosmocore/include/osmocom/gsm/tlv.h:299
  #3 0x76314419 in encode_pdp_info 
../../../../src/libosmocore/src/gsm/gsup.c:419
  #4 0x76314419 in osmo_gsup_encode 
../../../../src/libosmocore/src/gsm/gsup.c:535
  #5 0x55580016 in _luop_tx_gsup ../../../src/osmo-hlr/src/luop.c:54
  #6 0x555809d8 in lu_op_tx_insert_subscr_data 
../../../src/osmo-hlr/src/luop.c:264
  #7 0x5558b356 in rx_upd_loc_req ../../../src/osmo-hlr/src/hlr.c:306
  #8 0x5558b356 in read_cb ../../../src/osmo-hlr/src/hlr.c:365
  #9 0x55586671 in osmo_gsup_server_read_cb 
../../../src/osmo-hlr/src/gsup_server.c:105
  #10 0x75b35911 in ipa_server_conn_read 
../../../src/libosmo-abis/src/input/ipa.c:356
  #11 0x75b35911 in ipa_server_conn_cb 
../../../src/libosmo-abis/src/input/ipa.c:387
  #12 0x75e5541f in osmo_fd_disp_fds 
../../../src/libosmocore/src/select.c:216
  #13 0x75e5541f in osmo_select_main 
../../../src/libosmocore/src/select.c:256
  #14 0x555791b6 in main ../../../src/osmo-hlr/src/hlr.c:600
  #15 0x74707a86 in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x21a86)
  #16 0x55579679 in _start (/usr/local/bin/osmo-hlr+0x25679)

  Address 0x7fffd9c0 is located in stack of thread T0 at offset 16 in frame
  #0 0x763131ff in osmo_gsup_encode 
../../../../src/libosmocore/src/gsm/gsup.c:481

This frame has 1 object(s):
  [32, 64) 'bcd_buf' <== Memory access at offset 16 underflows this variable

Related: OS#3231
Change-Id: I83d9ef2868bbb01e3f1ddb7920fe735aca172b15
---
M src/gsup_server.c
M src/gsup_server.h
M src/hlr.c
M src/luop.c
4 files changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/27/8027/1

diff --git a/src/gsup_server.c b/src/gsup_server.c
index 24ba738..03a6f56 100644
--- a/src/gsup_server.c
+++ b/src/gsup_server.c
@@ -335,16 +335,19 @@
talloc_free(gsups);
 }
 
-void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup)
+/* Set GSUP message's pdp_infos[0] to a wildcard APN.
+ * Use the provided apn_buf to store the produced APN data. This must remain 
valid until
+ * osmo_gsup_encode() is done. */
+void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
+ uint8_t *apn_buf, size_t apn_buf_size)
 {
int l;
-   uint8_t apn[APN_MAXLEN];
 
-   l = osmo_apn_from_str(apn, sizeof(apn), "*");
+   l = osmo_apn_from_str(apn_buf, apn_buf_size, "*");
if (l <= 0)
return;
 
-   gsup->pdp_infos[0].apn_enc = apn;
+   gsup->pdp_infos[0].apn_enc = apn_buf;
gsup->pdp_infos[0].apn_enc_len = l;
gsup->pdp_infos[0].have_info = 1;
gsup->num_pdp_infos = 1;
diff --git a/src/gsup_server.h b/src/gsup_server.h
index 3d36bff..b52b783 100644
--- a/src/gsup_server.h
+++ b/src/gsup_server.h
@@ -53,4 +53,5 @@
 
 void osmo_gsup_server_destroy(struct osmo_gsup_server *gsups);
 
-void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup);
+void osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup,
+ uint8_t *apn_buf, size_t apn_buf_size);
diff --git a/src/hlr.c b/src/hlr.c
index 195e5d2..cab34f0 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "db.h"
 #include "hlr.h"
@@ -67,6 +68,7 @@
uint8_t *peer;
int peer_len;
uint8_t msisdn_enc[43]; /* TODO use constant; TS 24.008 
10.5.4.7 */
+   uint8_t apn[APN_MAXLEN];
int len;
struct msgb *msg_out;
 
@@ -96,7 +98,7 @@
 
/* FIXME: PDP infos - use more fine-grained access 
control
   instead of wildcard APN */
-   osmo_gsup_configure_wildcard_apn();
+   osmo_gsup_configure_wildcard_apn(, apn, 
sizeof(apn));
} else if (co->supports_cs) {
gsup.cn_domain = OSMO_GSUP_CN_DOMAIN_CS;
} else {
diff --git a/src/luop.c b/src/luop.c
index 7150b64..54c3884 100644
--- a/src/luop.c
+++ b/src/luop.c
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 
 

[PATCH] osmo-hlr[master]: add gsup_test to catch OS#3231

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/8028

add gsup_test to catch OS#3231

Encode an Insert Subscr Data with is_ps == true to trigger the encoding bug
described in OS#3231, i.e. show that it is fixed.

Move osmo_gsup_addr_send() to a separate .c file, so that it can be overridden
in the regression test to just dump the msgb instead.

I used this test to reproduce issue OS#3231, and now that it's here we might as
well keep it, and possibly expand on it in the future.

Related: OS#3231
Change-Id: Id1453351758f3e1a9ff03bd99fefaf51886e77da
---
M configure.ac
M src/Makefile.am
A src/gsup_send.c
M src/luop.c
M src/luop.h
M tests/Makefile.am
A tests/gsup/Makefile.am
A tests/gsup/gsup_test.c
A tests/gsup/gsup_test.err
A tests/gsup/gsup_test.ok
M tests/testsuite.at
11 files changed, 191 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/28/8028/1

diff --git a/configure.ac b/configure.ac
index a632a1d..cedba45 100644
--- a/configure.ac
+++ b/configure.ac
@@ -104,5 +104,6 @@
tests/auc/Makefile
tests/auc/gen_ts_55_205_test_sets/Makefile
tests/gsup_server/Makefile
+   tests/gsup/Makefile
tests/db/Makefile
)
diff --git a/src/Makefile.am b/src/Makefile.am
index 60fc479..ea5023d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -52,6 +52,7 @@
rand_urandom.c \
hlr_vty.c \
hlr_vty_subscr.c \
+   gsup_send.c \
$(NULL)
 
 osmo_hlr_LDADD = \
diff --git a/src/gsup_send.c b/src/gsup_send.c
new file mode 100644
index 000..b2c4e02
--- /dev/null
+++ b/src/gsup_send.c
@@ -0,0 +1,45 @@
+/* (C) 2018 by sysmocom - s.f.m.c. GmbH 
+ *
+ * All Rights Reserved
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see .
+ *
+ */
+
+/* This is kept separate to be able to override the actual sending functions 
from unit tests. */
+
+#include 
+
+#include "gsup_server.h"
+#include "gsup_router.h"
+
+#include 
+
+/* Send a msgb to a given address using routing */
+int osmo_gsup_addr_send(struct osmo_gsup_server *gs,
+   const uint8_t *addr, size_t addrlen,
+   struct msgb *msg)
+{
+   struct osmo_gsup_conn *conn;
+
+   conn = gsup_route_find(gs, addr, addrlen);
+   if (!conn) {
+   DEBUGP(DLGSUP, "Cannot find route for addr %s\n", addr);
+   msgb_free(msg);
+   return -ENODEV;
+   }
+
+   return osmo_gsup_conn_send(conn, msg);
+}
+
diff --git a/src/luop.c b/src/luop.c
index 54c3884..edf4c51 100644
--- a/src/luop.c
+++ b/src/luop.c
@@ -165,23 +165,6 @@
luop->state = new_state;
 }
 
-/* Send a msgb to a given address using routing */
-int osmo_gsup_addr_send(struct osmo_gsup_server *gs,
-   const uint8_t *addr, size_t addrlen,
-   struct msgb *msg)
-{
-   struct osmo_gsup_conn *conn;
-
-   conn = gsup_route_find(gs, addr, addrlen);
-   if (!conn) {
-   DEBUGP(DMAIN, "Cannot find route for addr %s\n", addr);
-   msgb_free(msg);
-   return -ENODEV;
-   }
-
-   return osmo_gsup_conn_send(conn, msg);
-}
-
 /*! Transmit UPD_LOC_ERROR and destroy lu_operation */
 void lu_op_tx_error(struct lu_operation *luop, enum gsm48_gmm_cause cause)
 {
diff --git a/src/luop.h b/src/luop.h
index 053a025..d690243 100644
--- a/src/luop.h
+++ b/src/luop.h
@@ -28,6 +28,7 @@
 #include 
 
 #include "db.h"
+#include "gsup_server.h"
 
 #define CANCEL_TIMEOUT_SECS30
 #define ISD_TIMEOUT_SECS   30
diff --git a/tests/Makefile.am b/tests/Makefile.am
index f1cc710..58679ed 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -2,6 +2,7 @@
auc \
gsup_server \
db \
+   gsup \
$(NULL)
 
 # The `:;' works around a Bash 3.2 bug when the output is not writeable.
diff --git a/tests/gsup/Makefile.am b/tests/gsup/Makefile.am
new file mode 100644
index 000..7c33dbd
--- /dev/null
+++ b/tests/gsup/Makefile.am
@@ -0,0 +1,41 @@
+AM_CPPFLAGS = \
+   $(all_includes) \
+   -I$(top_srcdir)/src \
+   $(NULL)
+
+AM_CFLAGS = \
+   -Wall \
+   -ggdb3 \
+   $(LIBOSMOCORE_CFLAGS) \
+   $(LIBOSMOGSM_CFLAGS) \
+   $(LIBOSMOABIS_CFLAGS) \
+   $(NULL)
+
+AM_LDFLAGS = \
+   $(NULL)
+
+EXTRA_DIST = \
+   gsup_test.ok \
+   gsup_test.err \
+   

osmo-ttcn3-hacks[master]: make PCU tests send PS paging requests on BVCI zero

[Harald Welte]

Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/8020/1/library/NS_Emulation.ttcn
File library/NS_Emulation.ttcn:

Line 266:   NSCP.send(t_NS_Send(g_conn_id, 
t_NS_UNITDATA(t_SduCtrlB, ud_req.bvci, enc)));
this ud_req.bvci is comming from the user (BSSGP). So the BSSGP_Emulation can 
already send both via its point-to-point BVCI or via signaling (0) by setting 
it properly.  I don't think we need any changes in this file.


-- 
To view, visit https://gerrit.osmocom.org/8020
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0437123b04b7320a4f690f0646578c57abf6bc87
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

osmo-ttcn3-hacks[master]: make PCU tests send PS paging requests on BVCI zero

[Harald Welte]

Patch Set 1: Code-Review-1

(2 comments)

tis is not what we really need, sorry.  We'd want to have a second port upwards 
to the user, so the user (testcase) can specify if he wants to send something 
through PTP or signaling BVCI.  Towards the bottom (NS), I would assume the 
single port is sufficient.

https://gerrit.osmocom.org/#/c/8020/1/library/BSSGP_Emulation.ttcn
File library/BSSGP_Emulation.ttcn:

Line 538:   [] BSSGP_SP.receive(tr_BSSGP_PS_PAGING(0)) -> value bs_pdu 
sender vc_conn {
I would argue this template should match all BSSGP messages for BVCI=0 
(signaling), not just PS-PAGING.


Line 539:   BSCP_SIG.send(f_BnsUdReq(bs_pdu, g_cfg.bvci));
also here, probably best to use BVCI=0?


-- 
To view, visit https://gerrit.osmocom.org/8020
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0437123b04b7320a4f690f0646578c57abf6bc87
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

[MERGED] osmo-trx[master]: doc: examples: Add umtrx sample config

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: doc: examples: Add umtrx sample config
..


doc: examples: Add umtrx sample config

Change-Id: Id38de0bbbe75e5e6bbb0de2eecb7d1984786d528
---
A doc/examples/osmo-trx-umtrx.cfg
1 file changed, 22 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Alexander Chemeris: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/doc/examples/osmo-trx-umtrx.cfg b/doc/examples/osmo-trx-umtrx.cfg
new file mode 100644
index 000..b7a73b0
--- /dev/null
+++ b/doc/examples/osmo-trx-umtrx.cfg
@@ -0,0 +1,22 @@
+log stderr
+  logging filter all 1
+  logging color 1
+  logging print category 1
+  logging timestamp 1
+  logging level all info
+!
+line vty
+ no login
+!
+trx
+ bind-ip 127.0.0.1
+ remote-ip 127.0.0.1
+ base-port 5700
+ dev-args 
addr=192.168.10.2,pa=NONE,pa_power_max_dbm=23,fifo_ctrl_window=0,status_port=12345
+ egprs disable
+ tx-sps 4
+ rx-sps 4
+ rssi-offset 38
+ rt-prio 18
+ chan 0
+ chan 1

-- 
To view, visit https://gerrit.osmocom.org/7890
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id38de0bbbe75e5e6bbb0de2eecb7d1984786d528
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: ttsou 

osmo-trx[master]: doc: examples: Add umtrx sample config

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/7890
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38de0bbbe75e5e6bbb0de2eecb7d1984786d528
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

osmo-trx[master]: doc: examples: Add umtrx sample config

[Alexander Chemeris]

Patch Set 1:

Yes, Pau is correct.

-- 
To view, visit https://gerrit.osmocom.org/7890
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38de0bbbe75e5e6bbb0de2eecb7d1984786d528
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

osmo-trx[master]: doc: examples: Add umtrx sample config

[Pau Espin Pedrol]

Patch Set 1:

> > Does anybody disagree with this? can we merge it?
 > 
 > nobody has yet adressed Alexander Chemeris' coment ?

As far as I understand, his comment was a response refusing Vadim's approach, 
and I think the patch is fine as it is now.

Can any of you guys confirm?

-- 
To view, visit https://gerrit.osmocom.org/7890
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38de0bbbe75e5e6bbb0de2eecb7d1984786d528
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

osmo-trx[master]: doc: examples: Add umtrx sample config

[Harald Welte]

Patch Set 1:

> Does anybody disagree with this? can we merge it?

nobody has yet adressed Alexander Chemeris' coment ?

-- 
To view, visit https://gerrit.osmocom.org/7890
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38de0bbbe75e5e6bbb0de2eecb7d1984786d528
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

osmo-trx[master]: doc: examples: Add umtrx sample config

[Pau Espin Pedrol]

Patch Set 1: Code-Review+1

Does anybody disagree with this? can we merge it?

-- 
To view, visit https://gerrit.osmocom.org/7890
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38de0bbbe75e5e6bbb0de2eecb7d1984786d528
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: ttsou 
Gerrit-HasComments: No

openbsc[master]: debian/changelog: change last release for unreleased to unst...

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8025
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife77f6ddd45465b0a5fce80e51e3e64428787b91
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] openbsc[master]: debian/changelog: change last release for unreleased to unst...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: debian/changelog: change last release for unreleased to unstable
..


debian/changelog: change last release for unreleased to unstable

Otherwise osmo-release.mk overrides contents of last release.

Change-Id: Ife77f6ddd45465b0a5fce80e51e3e64428787b91
---
M debian/changelog
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index 08636ef..ab33e8e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-openbsc (1.0.0) UNRELEASED; urgency=medium
+openbsc (1.0.0) unstable; urgency=medium
 
   [ Holger Hans Peter Freyther ]
   * Revert "gprs: Use RAND_bytes for p-tmsi"

-- 
To view, visit https://gerrit.osmocom.org/8025
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife77f6ddd45465b0a5fce80e51e3e64428787b91
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmo-ggsn[master]: Bump version: 1.2.0.1-36c4 → 1.2.1

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Bump version: 1.2.0.1-36c4 → 1.2.1
..


Bump version: 1.2.0.1-36c4 → 1.2.1

Change-Id: I4a8bdcbee300296496f039b90795ff981018e17d
---
M debian/changelog
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index 83fd823..6588dca 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+osmo-ggsn (1.2.1) unstable; urgency=medium
+
+  * debian/rules: Fix debian packaging after 1.2.0 release
+
+ -- Pau Espin Pedrol   Fri, 04 May 2018 12:19:58 +0200
+
 osmo-ggsn (1.2.0) unstable; urgency=medium
 
   [ Neels Hofmeyr ]

-- 
To view, visit https://gerrit.osmocom.org/8024
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a8bdcbee300296496f039b90795ff981018e17d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-ggsn[master]: Bump version: 1.2.0.1-36c4 → 1.2.1

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8024
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a8bdcbee300296496f039b90795ff981018e17d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] openbsc[master]: Bump version: 1.0.0.45-2b362-dirty → 1.1.0

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: Bump version: 1.0.0.45-2b362-dirty → 1.1.0
..


Bump version: 1.0.0.45-2b362-dirty → 1.1.0

Change-Id: I04ccac3ce79b58d5ef0b3c0503ef38708dac05ff
---
M debian/changelog
M openbsc/configure.ac
2 files changed, 75 insertions(+), 13 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index ab33e8e..a157b2e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,65 @@
+openbsc (1.1.0) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * debian/rules: show testsuite.log when tests are failing
+  * vty: skip installing cmds now always installed by default
+  * vty: skip installing cmds now always installed by default
+  * sms.db: silence libdbi warnings on out-of-range index
+  * fix build: gprs_ra_id_by_bts(): ensure to init all values
+  * backport support for 3-digit MNC with leading zeros
+  * Migrate from OpenSSL to osmo_get_rand_id()
+
+  [ Harald Welte ]
+  * osmo-bsc: Print NOTICE message on unimplemented BSSMAP UDT
+  * osmo-bsc-sccplite: Implement incoming RESET procedure
+  * mgcp_transcoding_test: Add LIBOSMOABIS_CFLAGS
+  * sysinfo: Fix regression causing missing L2 Pseudo-Length in SI5/SI6
+(Closes: #3059)
+
+  [ Pau Espin Pedrol ]
+  * Use type bool for boolean fields in gsm48_si_ro_info
+  * vty: Add cmd to configure 3g Early Classmark Sending
+  * mgcp_protocol: Don't print osmux stats if it is off
+  * bsc: Improve handling of paging_request return value
+  * bsc: paging: Fix losing paging messages for BTS
+  * libbsc: set_net_mcc_mnc_apply: Fix memleak on parsing incorrect mcc mnc
+  * bsc_nat: ctrl: fix memleak on reply receival
+  * bsc_nat: forward_to_bsc: remove one level of indentation
+  * bsc_nat: forward_to_bsc: Fix memleak on send failure
+  * bsc_nat: Drop redundant ccon ptr in bsc_cmd_list
+  * bsc_nat: ctrl: Fix crash on receveing bsc reply
+  * nat: Add jitter buffer on the uplink receiver
+  * smpp_smsc_conf: Fix heap-use-after-free
+  * chan_alloc.c: Fix log var formatting issues
+  * mgcp: switch to new osmux output APIs
+  * debian/changelog: change last release for unreleased to unstable
+
+  [ Max ]
+  * Fix tests after rate_ctr change
+
+  [ Vadim Yanitskiy ]
+  * libmsc: add support for both comp128v2 and comp128v3
+  * gsm_04_80.h: use '#pragma once' instead of includes
+  * gsm_04_80.h: cosmetic: whitespace fix
+  * src/libmsc/ussd.c: drop useless forward declaration
+
+  [ Stefan Sperling ]
+  * Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.
+  * bts chan_load: ignore unusable BTS
+  * Add stat items for the BTS's channel load average and T3122.
+  * Add support for Access Control Class ramping.
+  * fix a format string error in bts_update_t3122_chan_load()
+  * fix initialization of acc ramping
+  * only log actual access control class ramping changes
+  * ensure that acc_ramp_init() is only called once
+  * trigger acc ramping based on trx rf-locked state
+  * rename helper functions in the acc ramp code to avoid confusion
+  * trigger acc ramping on state-changed-event reports
+  * only trigger acc ramping if trx 0 is usable and unlocked
+  * fix handling of state changes in acc ramping
+
+ -- Pau Espin Pedrol   Fri, 04 May 2018 12:45:08 +0200
+
 openbsc (1.0.0) unstable; urgency=medium
 
   [ Holger Hans Peter Freyther ]
diff --git a/openbsc/configure.ac b/openbsc/configure.ac
index 7183fda..2c3045a 100644
--- a/openbsc/configure.ac
+++ b/openbsc/configure.ac
@@ -39,19 +39,19 @@
 AC_SUBST(LIBRARY_DL)
 
 
-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.9.5)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.3.0)
-PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.9.5)
-PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.2.0)
-PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 0.6.4)
-PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.0.1)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.5.0)
+PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.2.0)
 
 # Enabke/disable the NAT?
 AC_ARG_ENABLE([nat], [AS_HELP_STRING([--enable-nat], [Build the BSC NAT. 
Requires SCCP])],
 [osmo_ac_build_nat="$enableval"],[osmo_ac_build_nat="no"])
 if test "$osmo_ac_build_nat" = "yes" ; then
-PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 0.0.2)
+PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 0.9.0)
 fi
 AM_CONDITIONAL(BUILD_NAT, test "x$osmo_ac_build_nat" = "xyes")
 AC_SUBST(osmo_ac_build_nat)
@@ -60,7 +60,7 @@
 AC_ARG_ENABLE([osmo-bsc], [AS_HELP_STRING([--enable-osmo-bsc], [Build the Osmo 
BSC])],
 

openbsc[master]: Bump version: 1.0.0.45-2b362-dirty → 1.1.0

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8026
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04ccac3ce79b58d5ef0b3c0503ef38708dac05ff
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] libasn1c[master]: Bump version: 0.9.30.1-3dc5 → 0.9.31

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: Bump version: 0.9.30.1-3dc5 → 0.9.31
..


Bump version: 0.9.30.1-3dc5 → 0.9.31

Change-Id: I8d192b1d29a47729a7c728dc35448e2daf6b9743
---
M debian/changelog
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index 26b8e9c..e7480c2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+libasn1c (0.9.31) unstable; urgency=medium
+
+  [ Alexander Couzens ]
+  * debian: set VERSION to fix version in .pc files
+
+ -- Pau Espin Pedrol   Fri, 04 May 2018 12:15:34 +0200
+
 libasn1c (0.9.30) unstable; urgency=medium
 
   * configure.ac: Use git-version-gen to set VERSION

-- 
To view, visit https://gerrit.osmocom.org/8023
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d192b1d29a47729a7c728dc35448e2daf6b9743
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

[PATCH] openbsc[master]: Bump version: 1.0.0.45-2b362-dirty → 1.1.0

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/8026

Bump version: 1.0.0.45-2b362-dirty → 1.1.0

Change-Id: I04ccac3ce79b58d5ef0b3c0503ef38708dac05ff
---
M debian/changelog
M openbsc/configure.ac
2 files changed, 75 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/26/8026/1

diff --git a/debian/changelog b/debian/changelog
index ab33e8e..a157b2e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,65 @@
+openbsc (1.1.0) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * debian/rules: show testsuite.log when tests are failing
+  * vty: skip installing cmds now always installed by default
+  * vty: skip installing cmds now always installed by default
+  * sms.db: silence libdbi warnings on out-of-range index
+  * fix build: gprs_ra_id_by_bts(): ensure to init all values
+  * backport support for 3-digit MNC with leading zeros
+  * Migrate from OpenSSL to osmo_get_rand_id()
+
+  [ Harald Welte ]
+  * osmo-bsc: Print NOTICE message on unimplemented BSSMAP UDT
+  * osmo-bsc-sccplite: Implement incoming RESET procedure
+  * mgcp_transcoding_test: Add LIBOSMOABIS_CFLAGS
+  * sysinfo: Fix regression causing missing L2 Pseudo-Length in SI5/SI6
+(Closes: #3059)
+
+  [ Pau Espin Pedrol ]
+  * Use type bool for boolean fields in gsm48_si_ro_info
+  * vty: Add cmd to configure 3g Early Classmark Sending
+  * mgcp_protocol: Don't print osmux stats if it is off
+  * bsc: Improve handling of paging_request return value
+  * bsc: paging: Fix losing paging messages for BTS
+  * libbsc: set_net_mcc_mnc_apply: Fix memleak on parsing incorrect mcc mnc
+  * bsc_nat: ctrl: fix memleak on reply receival
+  * bsc_nat: forward_to_bsc: remove one level of indentation
+  * bsc_nat: forward_to_bsc: Fix memleak on send failure
+  * bsc_nat: Drop redundant ccon ptr in bsc_cmd_list
+  * bsc_nat: ctrl: Fix crash on receveing bsc reply
+  * nat: Add jitter buffer on the uplink receiver
+  * smpp_smsc_conf: Fix heap-use-after-free
+  * chan_alloc.c: Fix log var formatting issues
+  * mgcp: switch to new osmux output APIs
+  * debian/changelog: change last release for unreleased to unstable
+
+  [ Max ]
+  * Fix tests after rate_ctr change
+
+  [ Vadim Yanitskiy ]
+  * libmsc: add support for both comp128v2 and comp128v3
+  * gsm_04_80.h: use '#pragma once' instead of includes
+  * gsm_04_80.h: cosmetic: whitespace fix
+  * src/libmsc/ussd.c: drop useless forward declaration
+
+  [ Stefan Sperling ]
+  * Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.
+  * bts chan_load: ignore unusable BTS
+  * Add stat items for the BTS's channel load average and T3122.
+  * Add support for Access Control Class ramping.
+  * fix a format string error in bts_update_t3122_chan_load()
+  * fix initialization of acc ramping
+  * only log actual access control class ramping changes
+  * ensure that acc_ramp_init() is only called once
+  * trigger acc ramping based on trx rf-locked state
+  * rename helper functions in the acc ramp code to avoid confusion
+  * trigger acc ramping on state-changed-event reports
+  * only trigger acc ramping if trx 0 is usable and unlocked
+  * fix handling of state changes in acc ramping
+
+ -- Pau Espin Pedrol   Fri, 04 May 2018 12:45:08 +0200
+
 openbsc (1.0.0) unstable; urgency=medium
 
   [ Holger Hans Peter Freyther ]
diff --git a/openbsc/configure.ac b/openbsc/configure.ac
index 7183fda..2c3045a 100644
--- a/openbsc/configure.ac
+++ b/openbsc/configure.ac
@@ -39,19 +39,19 @@
 AC_SUBST(LIBRARY_DL)
 
 
-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.9.5)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.3.0)
-PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.9.5)
-PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.2.0)
-PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 0.6.4)
-PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.0.1)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 0.11.0)
+PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.5.0)
+PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.2.0)
 
 # Enabke/disable the NAT?
 AC_ARG_ENABLE([nat], [AS_HELP_STRING([--enable-nat], [Build the BSC NAT. 
Requires SCCP])],
 [osmo_ac_build_nat="$enableval"],[osmo_ac_build_nat="no"])
 if test "$osmo_ac_build_nat" = "yes" ; then
-PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 0.0.2)
+PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 0.9.0)
 fi
 AM_CONDITIONAL(BUILD_NAT, test "x$osmo_ac_build_nat" = "xyes")
 AC_SUBST(osmo_ac_build_nat)
@@ -60,7 +60,7 @@
 AC_ARG_ENABLE([osmo-bsc], [AS_HELP_STRING([--enable-osmo-bsc], [Build the Osmo 
BSC])],
 [osmo_ac_build_bsc="$enableval"],[osmo_ac_build_bsc="no"])
 if test "$osmo_ac_build_bsc" = "yes" ; then
-PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 

[PATCH] openbsc[master]: debian/changelog: change last release for unreleased to unst...

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/8025

debian/changelog: change last release for unreleased to unstable

Otherwise osmo-release.mk overrides contents of last release.

Change-Id: Ife77f6ddd45465b0a5fce80e51e3e64428787b91
---
M debian/changelog
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/25/8025/1

diff --git a/debian/changelog b/debian/changelog
index 08636ef..ab33e8e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-openbsc (1.0.0) UNRELEASED; urgency=medium
+openbsc (1.0.0) unstable; urgency=medium
 
   [ Holger Hans Peter Freyther ]
   * Revert "gprs: Use RAND_bytes for p-tmsi"

-- 
To view, visit https://gerrit.osmocom.org/8025
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife77f6ddd45465b0a5fce80e51e3e64428787b91
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

libasn1c[master]: Bump version: 0.9.30.1-3dc5 → 0.9.31

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8023
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d192b1d29a47729a7c728dc35448e2daf6b9743
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[PATCH] libasn1c[master]: Bump version: 0.9.30.1-3dc5 → 0.9.31

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/8023

Bump version: 0.9.30.1-3dc5 → 0.9.31

Change-Id: I8d192b1d29a47729a7c728dc35448e2daf6b9743
---
M debian/changelog
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/23/8023/1

diff --git a/debian/changelog b/debian/changelog
index 26b8e9c..e7480c2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+libasn1c (0.9.31) unstable; urgency=medium
+
+  [ Alexander Couzens ]
+  * debian: set VERSION to fix version in .pc files
+
+ -- Pau Espin Pedrol   Fri, 04 May 2018 12:15:34 +0200
+
 libasn1c (0.9.30) unstable; urgency=medium
 
   * configure.ac: Use git-version-gen to set VERSION

-- 
To view, visit https://gerrit.osmocom.org/8023
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d192b1d29a47729a7c728dc35448e2daf6b9743
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

[PATCH] osmo-ggsn[master]: Bump version: 1.2.0.1-36c4 → 1.2.1

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/8024

Bump version: 1.2.0.1-36c4 → 1.2.1

Change-Id: I4a8bdcbee300296496f039b90795ff981018e17d
---
M debian/changelog
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/24/8024/1

diff --git a/debian/changelog b/debian/changelog
index 83fd823..6588dca 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+osmo-ggsn (1.2.1) unstable; urgency=medium
+
+  * debian/rules: Fix debian packaging after 1.2.0 release
+
+ -- Pau Espin Pedrol   Fri, 04 May 2018 12:19:58 +0200
+
 osmo-ggsn (1.2.0) unstable; urgency=medium
 
   [ Neels Hofmeyr ]

-- 
To view, visit https://gerrit.osmocom.org/8024
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a8bdcbee300296496f039b90795ff981018e17d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

osmo-ggsn[master]: debian/rules: Fix debian packaging after 1.2.0 release

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8022
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib54f231943348c06acecd6f413b2c96b24f6db28
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] osmo-ggsn[master]: debian/rules: Fix debian packaging after 1.2.0 release

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: debian/rules: Fix debian packaging after 1.2.0 release
..


debian/rules: Fix debian packaging after 1.2.0 release

The 1.2.0 release bumped lib version to 3 and updated the debian package
file accordingly, but forgot to increase dh_strip line in debian/rules.

Change-Id: Ib54f231943348c06acecd6f413b2c96b24f6db28
---
M debian/rules
M gtp/Makefile.am
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/rules b/debian/rules
index 57fe24c..bcf1931 100755
--- a/debian/rules
+++ b/debian/rules
@@ -16,7 +16,7 @@
 
 override_dh_strip:
dh_strip -posmo-ggsn --dbg-package=osmo-ggsn-dbg
-   dh_strip -plibgtp2 --dbg-package=libgtp-dbg
+   dh_strip -plibgtp3 --dbg-package=libgtp-dbg
 
 override_dh_autoreconf:
echo $(VERSION) > .tarball-version
diff --git a/gtp/Makefile.am b/gtp/Makefile.am
index 7a41a88..449292c 100644
--- a/gtp/Makefile.am
+++ b/gtp/Makefile.am
@@ -1,7 +1,9 @@
 # This is _NOT_ the library release version, it's an API version.
 # Please read chapter "Library interface versions" of the libtool documentation
 # before making any modifications: 
https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
+# If major=current-age is increased, remember to update the dh_strip line in 
debian/rules!
 LIBVERSION=3:0:0
+
 lib_LTLIBRARIES = libgtp.la
 
 include_HEADERS = gtp.h pdp.h gtpie.h

-- 
To view, visit https://gerrit.osmocom.org/8022
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib54f231943348c06acecd6f413b2c96b24f6db28
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-ggsn[master]: debian/rules: Fix debian packaging after 1.2.0 release

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/8022

to look at the new patch set (#2).

debian/rules: Fix debian packaging after 1.2.0 release

The 1.2.0 release bumped lib version to 3 and updated the debian package
file accordingly, but forgot to increase dh_strip line in debian/rules.

Change-Id: Ib54f231943348c06acecd6f413b2c96b24f6db28
---
M debian/rules
M gtp/Makefile.am
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/22/8022/2

diff --git a/debian/rules b/debian/rules
index 57fe24c..bcf1931 100755
--- a/debian/rules
+++ b/debian/rules
@@ -16,7 +16,7 @@
 
 override_dh_strip:
dh_strip -posmo-ggsn --dbg-package=osmo-ggsn-dbg
-   dh_strip -plibgtp2 --dbg-package=libgtp-dbg
+   dh_strip -plibgtp3 --dbg-package=libgtp-dbg
 
 override_dh_autoreconf:
echo $(VERSION) > .tarball-version
diff --git a/gtp/Makefile.am b/gtp/Makefile.am
index 7a41a88..449292c 100644
--- a/gtp/Makefile.am
+++ b/gtp/Makefile.am
@@ -1,7 +1,9 @@
 # This is _NOT_ the library release version, it's an API version.
 # Please read chapter "Library interface versions" of the libtool documentation
 # before making any modifications: 
https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
+# If major=current-age is increased, remember to update the dh_strip line in 
debian/rules!
 LIBVERSION=3:0:0
+
 lib_LTLIBRARIES = libgtp.la
 
 include_HEADERS = gtp.h pdp.h gtpie.h

-- 
To view, visit https://gerrit.osmocom.org/8022
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib54f231943348c06acecd6f413b2c96b24f6db28
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder

[PATCH] osmo-ggsn[master]: debian/rules: Fix debian packaging after 1.2.0 release

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/8022

debian/rules: Fix debian packaging after 1.2.0 release

The 1.2.0 release bumped lib version to 3 and updated the debian package
gile accordingly, but forgot to increase dh_strip line in debian/rules.

Change-Id: Ib54f231943348c06acecd6f413b2c96b24f6db28
---
M debian/rules
M gtp/Makefile.am
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/22/8022/1

diff --git a/debian/rules b/debian/rules
index 57fe24c..bcf1931 100755
--- a/debian/rules
+++ b/debian/rules
@@ -16,7 +16,7 @@
 
 override_dh_strip:
dh_strip -posmo-ggsn --dbg-package=osmo-ggsn-dbg
-   dh_strip -plibgtp2 --dbg-package=libgtp-dbg
+   dh_strip -plibgtp3 --dbg-package=libgtp-dbg
 
 override_dh_autoreconf:
echo $(VERSION) > .tarball-version
diff --git a/gtp/Makefile.am b/gtp/Makefile.am
index 7a41a88..449292c 100644
--- a/gtp/Makefile.am
+++ b/gtp/Makefile.am
@@ -1,7 +1,9 @@
 # This is _NOT_ the library release version, it's an API version.
 # Please read chapter "Library interface versions" of the libtool documentation
 # before making any modifications: 
https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
+# If major=current-age is increased, remember to update the dh_strip line in 
debian/rules!
 LIBVERSION=3:0:0
+
 lib_LTLIBRARIES = libgtp.la
 
 include_HEADERS = gtp.h pdp.h gtpie.h

-- 
To view, visit https://gerrit.osmocom.org/8022
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib54f231943348c06acecd6f413b2c96b24f6db28
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 

[MERGED] osmo-bsc[master]: bsc_api/GSCON: prevent unnecessary channel mode modifications

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: bsc_api/GSCON: prevent unnecessary channel mode modifications
..


bsc_api/GSCON: prevent unnecessary channel mode modifications

gsm0808_assign_req() checks if the new channel mode is compatible
with the new mode. If it is, it does a gsm48_lchan_modify(), but
it does not actually check if the new mode is equal to the current
mode.

- skip when the channel is compatible and the new mode is equal to
  the old mode.

- send the ASSIGNMENT COMPLETE directly from ST_ACTIVE when no
  mode modify was necessary.

Change-Id: I86a2d52836c54d2dbd77441b182f757327ec7262
Related: OS#2936
---
M src/libbsc/bsc_api.c
M src/libbsc/bsc_subscr_conn_fsm.c
2 files changed, 19 insertions(+), 9 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c
index 142efef..19859cf 100644
--- a/src/libbsc/bsc_api.c
+++ b/src/libbsc/bsc_api.c
@@ -296,16 +296,17 @@
}
 }
 
-/**
- * Send a GSM08.08 Assignment Request. Right now this does not contain the
- * audio codec type or the allowed rates for the config. It is assumed that
- * this is for audio handling only. In case the current channel does not allow
- * the selected mode a new one will be allocated.
- *
- * TODO: Add multirate configuration, make it work for more than audio.
- */
+/*! Send a GSM08.08 Assignment Request. Right now this does not contain the
+ *  audio codec type or the allowed rates for the config. In case the current
+ *  channel does not allow the selected mode a new one will be allocated.
+ *  \param[out] conn related subscriber connection
+ *  \param[in] chan_mode mode of the channel (see enum gsm48_chan_mode)
+ *  \param[in] full_rate select full rate or half rate channel
+ *  \returns 0 on success, 1 when no operation is neccessary, -1 on failure */
 int gsm0808_assign_req(struct gsm_subscriber_connection *conn, int chan_mode, 
int full_rate)
 {
+   /* TODO: Add multirate configuration, make it work for more than audio. 
*/
+
struct bsc_api *api;
api = conn->network->bsc_api;
 
@@ -313,6 +314,11 @@
if (handle_new_assignment(conn, chan_mode, full_rate) != 0)
goto error;
} else {
+   /* Check if the channel is already in the requested mode, if
+* yes, we skip unnecessary channel mode modify operations. */
+   if (conn->lchan->tch_mode == chan_mode)
+   return 1;
+
if (chan_mode == GSM48_CMODE_SPEECH_AMR)
handle_mr_config(conn, conn->lchan, full_rate);
 
diff --git a/src/libbsc/bsc_subscr_conn_fsm.c b/src/libbsc/bsc_subscr_conn_fsm.c
index b5e7e7d..7f53f1b 100644
--- a/src/libbsc/bsc_subscr_conn_fsm.c
+++ b/src/libbsc/bsc_subscr_conn_fsm.c
@@ -438,7 +438,11 @@
 * change back to ST_ACTIVE (here) immediately. */
rc = gsm0808_assign_req(conn, 
conn->user_plane.chan_mode,
conn->user_plane.full_rate);
-   if (rc != 0) {
+
+   if (rc == 1) {
+   send_ass_compl(conn->lchan, fi, false);
+   return;
+   } else if (rc != 0) {
resp = 
gsm0808_create_assignment_failure(GSM0808_CAUSE_EQUIPMENT_FAILURE, NULL);
sigtran_send(conn, resp, fi);
return;

-- 
To view, visit https://gerrit.osmocom.org/8019
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86a2d52836c54d2dbd77441b182f757327ec7262
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

osmo-bsc[master]: bsc_api/GSCON: prevent unnecessary channel mode modifications

[Harald Welte]

Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8019
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86a2d52836c54d2dbd77441b182f757327ec7262
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

libasn1c[master]: debian: set VERSION to fix version in .pc files

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/8021
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65401786cf9eb63d3445f548dc13c1d3f9f4c1ea
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[MERGED] libasn1c[master]: debian: set VERSION to fix version in .pc files

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: debian: set VERSION to fix version in .pc files
..


debian: set VERSION to fix version in .pc files

The pkgconf file contains an unknown version which result in failure
of other packages which depend on a minimum version (osmo-iuh)

Change-Id: I65401786cf9eb63d3445f548dc13c1d3f9f4c1ea
---
M debian/rules
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/rules b/debian/rules
index 267bea9..a1039b0 100755
--- a/debian/rules
+++ b/debian/rules
@@ -32,7 +32,10 @@
 # Vendor-related variables such as DEB_VENDOR:
 #include /usr/share/dpkg/vendor.mk
 # Package-related variables such as DEB_DISTRIBUTION
-#include /usr/share/dpkg/pkg-info.mk
+include /usr/share/dpkg/pkg-info.mk
+
+VERSION := $(shell echo '$(DEB_VERSION)' | sed -e 's/[+-].*//' -e 's/~//g')
+
 #
 # You may alternatively set them susing a simple script such as:
 # DEB_VENDOR ?= $(shell dpkg-vendor --query  Vendor)
@@ -44,6 +47,10 @@
 %:
dh $@ --with autoreconf
 
+override_dh_autoreconf:
+   echo $(VERSION) > .tarball-version
+   dh_autoreconf
+
 # debmake generated override targets
 # Set options for ./configure
 #CONFIGURE_FLAGS = 

-- 
To view, visit https://gerrit.osmocom.org/8021
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65401786cf9eb63d3445f548dc13c1d3f9f4c1ea
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

libasn1c[master]: debian: set VERSION to fix version in .pc files

[Pau Espin Pedrol]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/8021
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65401786cf9eb63d3445f548dc13c1d3f9f4c1ea
Gerrit-PatchSet: 1
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[PATCH] osmo-bsc[master]: bsc_api/GSCON: prevent unnecessary channel mode modifications

[dexter]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/8019

to look at the new patch set (#2).

bsc_api/GSCON: prevent unnecessary channel mode modifications

gsm0808_assign_req() checks if the new channel mode is compatible
with the new mode. If it is, it does a gsm48_lchan_modify(), but
it does not actually check if the new mode is equal to the current
mode.

- skip when the channel is compatible and the new mode is equal to
  the old mode.

- send the ASSIGNMENT COMPLETE directly from ST_ACTIVE when no
  mode modify was necessary.

Change-Id: I86a2d52836c54d2dbd77441b182f757327ec7262
Related: OS#2936
---
M src/libbsc/bsc_api.c
M src/libbsc/bsc_subscr_conn_fsm.c
2 files changed, 19 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/8019/2

diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c
index 142efef..19859cf 100644
--- a/src/libbsc/bsc_api.c
+++ b/src/libbsc/bsc_api.c
@@ -296,16 +296,17 @@
}
 }
 
-/**
- * Send a GSM08.08 Assignment Request. Right now this does not contain the
- * audio codec type or the allowed rates for the config. It is assumed that
- * this is for audio handling only. In case the current channel does not allow
- * the selected mode a new one will be allocated.
- *
- * TODO: Add multirate configuration, make it work for more than audio.
- */
+/*! Send a GSM08.08 Assignment Request. Right now this does not contain the
+ *  audio codec type or the allowed rates for the config. In case the current
+ *  channel does not allow the selected mode a new one will be allocated.
+ *  \param[out] conn related subscriber connection
+ *  \param[in] chan_mode mode of the channel (see enum gsm48_chan_mode)
+ *  \param[in] full_rate select full rate or half rate channel
+ *  \returns 0 on success, 1 when no operation is neccessary, -1 on failure */
 int gsm0808_assign_req(struct gsm_subscriber_connection *conn, int chan_mode, 
int full_rate)
 {
+   /* TODO: Add multirate configuration, make it work for more than audio. 
*/
+
struct bsc_api *api;
api = conn->network->bsc_api;
 
@@ -313,6 +314,11 @@
if (handle_new_assignment(conn, chan_mode, full_rate) != 0)
goto error;
} else {
+   /* Check if the channel is already in the requested mode, if
+* yes, we skip unnecessary channel mode modify operations. */
+   if (conn->lchan->tch_mode == chan_mode)
+   return 1;
+
if (chan_mode == GSM48_CMODE_SPEECH_AMR)
handle_mr_config(conn, conn->lchan, full_rate);
 
diff --git a/src/libbsc/bsc_subscr_conn_fsm.c b/src/libbsc/bsc_subscr_conn_fsm.c
index b5e7e7d..7f53f1b 100644
--- a/src/libbsc/bsc_subscr_conn_fsm.c
+++ b/src/libbsc/bsc_subscr_conn_fsm.c
@@ -438,7 +438,11 @@
 * change back to ST_ACTIVE (here) immediately. */
rc = gsm0808_assign_req(conn, 
conn->user_plane.chan_mode,
conn->user_plane.full_rate);
-   if (rc != 0) {
+
+   if (rc == 1) {
+   send_ass_compl(conn->lchan, fi, false);
+   return;
+   } else if (rc != 0) {
resp = 
gsm0808_create_assignment_failure(GSM0808_CAUSE_EQUIPMENT_FAILURE, NULL);
sigtran_send(conn, resp, fi);
return;

-- 
To view, visit https://gerrit.osmocom.org/8019
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86a2d52836c54d2dbd77441b182f757327ec7262
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Build failure of network:osmocom:latest/openbsc in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_9.0/armv7l

Package network:osmocom:latest/openbsc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[ 1290s] Makefile:736: recipe for target 'check-local' failed
[ 1290s] make[5]: *** [check-local] Error 1
[ 1290s] make[5]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[ 1290s] Makefile:586: recipe for target 'check-am' failed
[ 1290s] make[4]: *** [check-am] Error 2
[ 1290s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[ 1290s] Makefile:438: recipe for target 'check-recursive' failed
[ 1290s] make[3]: *** [check-recursive] Error 1
[ 1290s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/tests'
[ 1290s] Makefile:520: recipe for target 'check-recursive' failed
[ 1290s] make[2]: *** [check-recursive] Error 1
[ 1290s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[ 1290s] Makefile:811: recipe for target 'check' failed
[ 1290s] make[1]: *** [check] Error 2
[ 1290s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[ 1290s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[ 1290s] debian/rules:13: recipe for target 'build' failed
[ 1290s] make: *** [build] Error 2
[ 1290s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[ 1290s] 
[ 1290s] armbuild23 failed "build openbsc_1.0.0.dsc" at Fri May  4 06:02:20 UTC 
2018.
[ 1290s] 
[ 1290s] ### VM INTERACTION START ###
[ 1293s] [ 1232.688787] SysRq : Power Off
[ 1293s] [ 1232.714313] reboot: Power down
[ 1294s] ### VM INTERACTION END ###
[ 1294s] 
[ 1294s] armbuild23 failed "build openbsc_1.0.0.dsc" at Fri May  4 06:02:24 UTC 
2018.
[ 1294s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)