Change in osmo-bts[master]: lc15: Fix incorrect cast of hLayer1

2018-06-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9530 Change subject: lc15: Fix incorrect cast of hLayer1 .. lc15: Fix incorrect cast of hLayer1 Change-Id:

Change in osmo-bts[master]: jenkins_*.sh: add --enable-werror to configure flags

2018-06-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9536 Change subject: jenkins_*.sh: add --enable-werror to configure flags .. jenkins_*.sh: add --enable-werror to configure flags Change-Id:

Change in osmo-bts[master]: lc15: fsync requires fd instead of file stream

2018-06-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9535 Change subject: lc15: fsync requires fd instead of file stream .. lc15: fsync requires fd instead of file stream Change-Id:

Change in osmo-bts[master]: lc15: Fix several u32 vs HANDLE compile warnings

2018-06-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9531 Change subject: lc15: Fix several u32 vs HANDLE compile warnings .. lc15: Fix several u32 vs HANDLE compile warnings Change-Id:

Change in osmo-bts[master]: lc15: led_sleep_cb: pass correct ptr to llist_move_tail

2018-06-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9534 Change subject: lc15: led_sleep_cb: pass correct ptr to llist_move_tail .. lc15: led_sleep_cb: pass correct ptr to llist_move_tail Fix

Change in osmo-bts[master]: lc15: rewrite and refactor code to print hwversion description

2018-06-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9533 Change subject: lc15: rewrite and refactor code to print hwversion description .. lc15: rewrite and refactor code to print hwversion

Change in osmo-bts[master]: lc15: vty: Add missing include for lchan_deactivate

2018-06-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9532 Change subject: lc15: vty: Add missing include for lchan_deactivate .. lc15: vty: Add missing include for lchan_deactivate Fixes

Change in osmo-bsc[master]: Add missing event string name for GSCON_EV_LCLS_FAIL

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9537 Change subject: Add missing event string name for GSCON_EV_LCLS_FAIL .. Add missing event string name for GSCON_EV_LCLS_FAIL Change-Id:

Change in osmo-bsc[master]: bsc_subscr_conn_fsm: BSC must not release SCCP connection

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9538 Change subject: bsc_subscr_conn_fsm: BSC must not release SCCP connection .. bsc_subscr_conn_fsm: BSC must not release SCCP connection 3GPP

Change in osmo-bsc[master]: remove traces of osmo-bsc_nat in python test (osmoappdesc/test_runner)

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9527 ) Change subject: remove traces of osmo-bsc_nat in python test (osmoappdesc/test_runner) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: Add missing event string name for GSCON_EV_LCLS_FAIL

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9537 ) Change subject: Add missing event string name for GSCON_EV_LCLS_FAIL .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: remove traces of osmo-bsc_nat in python test (osmoappdesc/test_runner)

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9527 ) Change subject: remove traces of osmo-bsc_nat in python test (osmoappdesc/test_runner) .. remove traces of osmo-bsc_nat in python

Change in libosmocore[master]: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9528 ) Change subject: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag() .. Patch Set 2: (2 comments)

Change in libosmocore[master]: gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie()

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9529 ) Change subject: gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie() .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: Add missing event string name for GSCON_EV_LCLS_FAIL

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9537 ) Change subject: Add missing event string name for GSCON_EV_LCLS_FAIL .. Add missing event string name for GSCON_EV_LCLS_FAIL

Change in osmo-bts[master]: lc15: Fix several u32 vs HANDLE compile warnings

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9531 ) Change subject: lc15: Fix several u32 vs HANDLE compile warnings .. Patch Set 1: while I like this kind of cleanup patches, I am very

Change in osmo-bts[master]: lc15: vty: Add missing include for lchan_deactivate

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9532 ) Change subject: lc15: vty: Add missing include for lchan_deactivate .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: lc15: rewrite and refactor code to print hwversion description

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9533 ) Change subject: lc15: rewrite and refactor code to print hwversion description .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: lc15: fsync requires fd instead of file stream

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9535 ) Change subject: lc15: fsync requires fd instead of file stream .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: Avoid duplicate DISC.req in TC_bssmap_clear_does_not_cause_bssma...

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9542 Change subject: bsc: Avoid duplicate DISC.req in TC_bssmap_clear_does_not_cause_bssmap_reset() .. bsc: Avoid duplicate DISC.req in

Change in osmo-ttcn3-hacks[master]: BSC_Tests: ensure different RA+FN in *_does_not_cause_bssmap_reset()

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9541 Change subject: BSC_Tests: ensure different RA+FN in *_does_not_cause_bssmap_reset() .. BSC_Tests: ensure different RA+FN in

Change in osmo-ttcn3-hacks[master]: bts: no need to import GSM_RR_Types twice

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9540 Change subject: bts: no need to import GSM_RR_Types twice .. bts: no need to import GSM_RR_Types twice Change-Id:

Change in osmo-ttcn3-hacks[master]: bsc: Don't expect BSC to release SCCP in LCLS.TC_lcls_connect_clear()

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9539 Change subject: bsc: Don't expect BSC to release SCCP in LCLS.TC_lcls_connect_clear() .. bsc: Don't expect BSC to release SCCP in

Change in osmo-ttcn3-hacks[master]: bsc: Don't expect BSC to release SCCP in LCLS.TC_lcls_connect_clear()

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9539 ) Change subject: bsc: Don't expect BSC to release SCCP in LCLS.TC_lcls_connect_clear() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: Don't expect BSC to release SCCP in LCLS.TC_lcls_connect_clear()

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9539 ) Change subject: bsc: Don't expect BSC to release SCCP in LCLS.TC_lcls_connect_clear() .. bsc: Don't expect BSC to release SCCP in

Change in osmo-ttcn3-hacks[master]: bts: no need to import GSM_RR_Types twice

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9540 ) Change subject: bts: no need to import GSM_RR_Types twice .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9540

Change in osmo-ttcn3-hacks[master]: bts: no need to import GSM_RR_Types twice

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9540 ) Change subject: bts: no need to import GSM_RR_Types twice .. bts: no need to import GSM_RR_Types twice Change-Id:

Change in osmo-ttcn3-hacks[master]: BSC_Tests: ensure different RA+FN in *_does_not_cause_bssmap_reset()

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9541 ) Change subject: BSC_Tests: ensure different RA+FN in *_does_not_cause_bssmap_reset() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: Avoid duplicate DISC.req in TC_bssmap_clear_does_not_cause_bssma...

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9542 ) Change subject: bsc: Avoid duplicate DISC.req in TC_bssmap_clear_does_not_cause_bssmap_reset() .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: bsc: Avoid duplicate DISC.req in TC_bssmap_clear_does_not_cause_bssma...

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9542 ) Change subject: bsc: Avoid duplicate DISC.req in TC_bssmap_clear_does_not_cause_bssmap_reset() .. bsc: Avoid duplicate DISC.req in

Change in osmo-ttcn3-hacks[master]: BSC_Tests: ensure different RA+FN in *_does_not_cause_bssmap_reset()

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9541 ) Change subject: BSC_Tests: ensure different RA+FN in *_does_not_cause_bssmap_reset() .. BSC_Tests: ensure different RA+FN in

Change in osmo-ci[master]: verify_value_string_arrays_are_terminated.py: allow dir args and no args

2018-06-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9544 Change subject: verify_value_string_arrays_are_terminated.py: allow dir args and no args .. verify_value_string_arrays_are_terminated.py:

Change in osmo-ci[master]: jobs: gerrit: use debian-9

2018-06-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9545 Change subject: jobs: gerrit: use debian-9 .. jobs: gerrit: use debian-9 This is the same as done for the master builds in

Change in osmo-ci[master]: verify_value_string_arrays_are_terminated.py: allow terminating with ...

2018-06-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9543 Change subject: verify_value_string_arrays_are_terminated.py: allow terminating with '{}' .. verify_value_string_arrays_are_terminated.py:

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #151

2018-06-11 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in pysim[master]: csv: fix missing import (broken CSV support)

2018-06-11 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9546 Change subject: csv: fix missing import (broken CSV support) .. csv: fix missing import (broken CSV support) with Change

Change in osmo-ttcn3-hacks[master]: bsc: Reduce TC_bssap_rlsd_does_not_cause_bssmap_reset to 4 lchan

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9547 Change subject: bsc: Reduce TC_bssap_rlsd_does_not_cause_bssmap_reset to 4 lchan .. bsc: Reduce TC_bssap_rlsd_does_not_cause_bssmap_reset to 4

Change in osmo-msc[master]: libmsc/gsm_04_80.c: make the API abstract from ss_request struct

2018-06-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/9555 Change subject: libmsc/gsm_04_80.c: make the API abstract from ss_request struct .. libmsc/gsm_04_80.c: make the API abstract from

Change in osmo-msc[master]: libmsc/gsm_04_08.c: expose gsm48_tx_simple()

2018-06-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/9553 Change subject: libmsc/gsm_04_08.c: expose gsm48_tx_simple() .. libmsc/gsm_04_08.c: expose gsm48_tx_simple() This function could be also

Change in osmo-msc[master]: libmsc/gsm_09_11.c: properly indicate transaction errors

2018-06-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/9554 Change subject: libmsc/gsm_09_11.c: properly indicate transaction errors .. libmsc/gsm_09_11.c: properly indicate transaction errors

Change in osmo-msc[master]: Use proper naming for GSM TS 09.11 implementation

2018-06-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/9552 Change subject: Use proper naming for GSM TS 09.11 implementation .. Use proper naming for GSM TS 09.11 implementation During a long time,

Change in osmo-ci[master]: verify_value_string_arrays_are_terminated.py: allow dir args and no args

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9544 ) Change subject: verify_value_string_arrays_are_terminated.py: allow dir args and no args .. Patch Set 1: not sure why that's needed or

Change in osmo-ci[master]: verify_value_string_arrays_are_terminated.py: allow terminating with ...

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9543 ) Change subject: verify_value_string_arrays_are_terminated.py: allow terminating with '{}' .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: jobs: gerrit: use debian-9

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9545 ) Change subject: jobs: gerrit: use debian-9 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9545 To unsubscribe,

Change in osmo-ttcn3-hacks[master]: bsc: Add TC_chan_rel_hard_rlsd_ms_dead

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9548 Change subject: bsc: Add TC_chan_rel_hard_rlsd_ms_dead .. bsc: Add TC_chan_rel_hard_rlsd_ms_dead In this test case, the MSC performs a hard

Change in libosmocore[master]: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()

2018-06-11 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9528 to look at the new patch set (#3). Change subject: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()

Change in libosmocore[master]: gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie()

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9529 ) Change subject: gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie() .. gsm/gsm0480: refactor and expose

Change in libosmocore[master]: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9528 ) Change subject: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag() .. gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag() In some

Change in pysim[master]: csv: fix missing import (broken CSV support)

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9546 ) Change subject: csv: fix missing import (broken CSV support) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie()

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9529 ) Change subject: gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: Reduce TC_bssap_rlsd_does_not_cause_bssmap_reset to 4 lchan

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9547 ) Change subject: bsc: Reduce TC_bssap_rlsd_does_not_cause_bssmap_reset to 4 lchan .. bsc: Reduce

Change in osmo-ttcn3-hacks[master]: bsc: Reduce TC_bssap_rlsd_does_not_cause_bssmap_reset to 4 lchan

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9547 ) Change subject: bsc: Reduce TC_bssap_rlsd_does_not_cause_bssmap_reset to 4 lchan .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9528 ) Change subject: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag() .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: Add TC_chan_rel_hard_rlsd_ms_dead

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9548 ) Change subject: bsc: Add TC_chan_rel_hard_rlsd_ms_dead .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9548 To

Change in libosmocore[master]: gsup: Add osmo_gsup_get_err_msg_type() function

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9549 Change subject: gsup: Add osmo_gsup_get_err_msg_type() function .. gsup: Add osmo_gsup_get_err_msg_type() function This function can be used

Change in libosmocore[master]: gsup: Add osmo_gsup_get_err_msg_type() function

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9549 ) Change subject: gsup: Add osmo_gsup_get_err_msg_type() function .. gsup: Add osmo_gsup_get_err_msg_type() function This function can

Change in osmo-hlr[master]: Return proper GSUP error in case of too short IMSI

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9550 Change subject: Return proper GSUP error in case of too short IMSI .. Return proper GSUP error in case of too short IMSI This fixes

Change in libosmocore[master]: gsup: Add osmo_gsup_get_err_msg_type() function

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9549 ) Change subject: gsup: Add osmo_gsup_get_err_msg_type() function .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: Add TC_chan_rel_hard_rlsd_ms_dead

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9548 ) Change subject: bsc: Add TC_chan_rel_hard_rlsd_ms_dead .. bsc: Add TC_chan_rel_hard_rlsd_ms_dead In this test case, the MSC performs

Change in osmo-hlr[master]: Return proper GSUP error in case of too short IMSI

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9550 ) Change subject: Return proper GSUP error in case of too short IMSI .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: Return proper GSUP error in case of too short IMSI

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9550 ) Change subject: Return proper GSUP error in case of too short IMSI .. Return proper GSUP error in case of too short IMSI This fixes

Change in osmo-ttcn3-hacks[master]: hlr: Update expected-results

2018-06-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9551 Change subject: hlr: Update expected-results .. hlr: Update expected-results as of Change-Id Change-Id:

Change in osmo-ttcn3-hacks[master]: hlr: Update expected-results

2018-06-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9551 ) Change subject: hlr: Update expected-results .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9551 To

Change in osmo-ttcn3-hacks[master]: hlr: Update expected-results

2018-06-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9551 ) Change subject: hlr: Update expected-results .. hlr: Update expected-results as of Change-Id Change-Id: