Change in libosmocore[master]: Print error message if application fails to call rate_ctr_init()

2019-05-09 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13919 ) Change subject: Print error message if application fails to call rate_ctr_init() .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: msc: Separate as_GSUP_SAI from f_mm_auth

2019-05-09 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13937 Change subject: msc: Separate as_GSUP_SAI from f_mm_auth .. msc: Separate as_GSUP_SAI from f_mm_auth In some cases we might want to match on

Change in osmo-ttcn3-hacks[master]: msc: Permit optional authentication before reject/timeout

2019-05-09 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13936 Change subject: msc: Permit optional authentication before reject/timeout .. msc: Permit optional authentication before reject/timeout Tests

Change in osmo-ttcn3-hacks[master]: msc: Don't require protocolExtensions in RANAP Paging

2019-05-09 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13935 Change subject: msc: Don't require protocolExtensions in RANAP Paging .. msc: Don't require protocolExtensions in RANAP Paging We were using

Change in osmo-msc[master]: ran_a_make_handover_request(): allow no encryption

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13938 Change subject: ran_a_make_handover_request(): allow no encryption .. ran_a_make_handover_request(): allow no encryption Fixes: coverity

Change in osmo-msc[master]: make msc_a_vsub() and others NULL-safe

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13939 Change subject: make msc_a_vsub() and others NULL-safe .. make msc_a_vsub() and others NULL-safe Fixes: coverity CID 198451 Change-Id:

Change in osmo-msc[master]: no HO call forwarding if no RTP stream

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13940 Change subject: no HO call forwarding if no RTP stream .. no HO call forwarding if no RTP stream Fixes: coverity CID 198447 Related:

Change in osmo-msc[master]: SMPP: Don't accept password or system-id exceeding spec length

2019-05-09 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13930 ) Change subject: SMPP: Don't accept password or system-id exceeding spec length .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-msc[master]: msub_check_for_release(): Initialize msc_role_a_c

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13932 ) Change subject: msub_check_for_release(): Initialize msc_role_a_c .. msub_check_for_release(): Initialize msc_role_a_c This fixes

Change in libosmo-sccp[master]: stp: Ensure telnet uses STP talloc context, not NULL context

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13933 ) Change subject: stp: Ensure telnet uses STP talloc context, not NULL context .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: msub_check_for_release(): Initialize msc_role_a_c

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13932 ) Change subject: msub_check_for_release(): Initialize msc_role_a_c .. Patch Set 1: merging this quickly to fix our osmo-msc master build in

Change in osmo-ccid-firmware[master]: add async library with ring on TX

2019-05-09 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13677 to look at the new patch set (#11). Change subject: add async library with ring on TX .. add async library with ring

Change in osmo-ccid-firmware[master]: add debug command to communicate with card

2019-05-09 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13943 to look at the new patch set (#3). Change subject: add debug command to communicate with card .. add debug command

Change in osmo-ccid-firmware[master]: configure GCLK for ISO baud rates

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13781 ) Change subject: configure GCLK for ISO baud rates .. configure GCLK for ISO baud rates the SERCOMM clock triplet 0.5 MHz (100 MHz /

Change in osmo-ccid-firmware[master]: output 50 MHz for RMII

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13780 ) Change subject: output 50 MHz for RMII .. output 50 MHz for RMII in hardware revision 2 the Ethernet PHY RMII_CLOCK input clock is

Change in osmo-ccid-firmware[master]: add function to set baudrate

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13845 ) Change subject: add function to set baudrate .. add function to set baudrate it will set the GCLK as SERCOM core clock with the

Change in osmo-msc[master]: add DUSSD logging category

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13942 ) Change subject: add DUSSD logging category .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-ccid-firmware[master]: UART_debug now uses the async library with tx ring

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13678 ) Change subject: UART_debug now uses the async library with tx ring .. Patch Set 11: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: add async library with ring on TX

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13677 ) Change subject: add async library with ring on TX .. add async library with ring on TX the standard async library expected the

Change in osmo-ccid-firmware[master]: UART_debug now uses the async library with tx ring

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13678 ) Change subject: UART_debug now uses the async library with tx ring .. UART_debug now uses the async library with tx ring Change-Id:

Change in osmo-ccid-firmware[master]: add async library with ring on TX

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13677 ) Change subject: add async library with ring on TX .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13677 To

Change in osmo-ccid-firmware[master]: switch UART_debug to ASYNC

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13673 ) Change subject: switch UART_debug to ASYNC .. switch UART_debug to ASYNC using the synchronous HAL library causes RX overflow after

Change in osmo-ccid-firmware[master]: add slot_set_isorate to the baud rate using ISO 7816 values

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13847 ) Change subject: add slot_set_isorate to the baud rate using ISO 7816 values .. add slot_set_isorate to the baud rate using ISO 7816

Change in osmo-msc[master]: libmsc/gsm_04_08.c: clarify IMEI rejection in gsm48_rx_mm_serv_req()

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13944 ) Change subject: libmsc/gsm_04_08.c: clarify IMEI rejection in gsm48_rx_mm_serv_req() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc/gsm_04_08.c: fix: print proper length value

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13906 ) Change subject: libmsc/gsm_04_08.c: fix: print proper length value .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: add ISO 7816-3 definitions and utilities

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13846 ) Change subject: add ISO 7816-3 definitions and utilities .. add ISO 7816-3 definitions and utilities Change-Id:

Change in osmo-msc[master]: call_leg: remove unused event MSC_EV_CALL_LEG_RTP_RELEASED

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13945 ) Change subject: call_leg: remove unused event MSC_EV_CALL_LEG_RTP_RELEASED .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-msc[master]: add DUSSD logging category

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13942 Change subject: add DUSSD logging category .. add DUSSD logging category Change-Id: Id7e04c9f5088334cd5ec6cfdb6a9b3a2a7e7fda0 --- M

Change in osmo-ccid-firmware[master]: switch UART_debug to ASYNC

2019-05-09 Thread Kévin Redon
Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/13673 ) Change subject: switch UART_debug to ASYNC .. Patch Set 9: > I still don't like the fact that this looses serial output pretty > much all

Change in osmo-msc[master]: no HO call forwarding if no RTP stream

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13940 ) Change subject: no HO call forwarding if no RTP stream .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: call_leg: document the parent_event_* items

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13946 ) Change subject: call_leg: document the parent_event_* items .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: LOG_TRANS: store subsys in trans, unify USSD logging back to DMM

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13941 Change subject: LOG_TRANS: store subsys in trans, unify USSD logging back to DMM .. LOG_TRANS: store subsys in trans, unify USSD logging

Change in osmo-ccid-firmware[master]: add debug command to communicate with card

2019-05-09 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13943 Change subject: add debug command to communicate with card .. add debug command to communicate with card currently the read-iccid command

Change in osmo-ccid-firmware[master]: add async library with ring on TX

2019-05-09 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13677 to look at the new patch set (#10). Change subject: add async library with ring on TX .. add async library with ring

Change in osmo-ttcn3-hacks[master]: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Han...

2019-05-09 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13947 Change subject: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Handover tests") .. Revert partial of 0ac6315212a3 ("msc:

Change in osmo-ttcn3-hacks[master]: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Han...

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13947 ) Change subject: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Handover tests") .. Patch Set 1: Code-Review+2 -- To

Change in osmo-ccid-firmware[master]: switch UART_debug to ASYNC

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13673 ) Change subject: switch UART_debug to ASYNC .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13673 To

Change in osmo-msc[master]: libmsc/gsm_04_08.c: fix: print proper length value

2019-05-09 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13906 to look at the new patch set (#3). Change subject: libmsc/gsm_04_08.c: fix: print proper length value

Change in osmo-msc[master]: call_leg: document the parent_event_* items

2019-05-09 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13946 ) Change subject: call_leg: document the parent_event_* items .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: call_leg: remove unused event MSC_EV_CALL_LEG_RTP_RELEASED

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13945 Change subject: call_leg: remove unused event MSC_EV_CALL_LEG_RTP_RELEASED .. call_leg: remove unused event MSC_EV_CALL_LEG_RTP_RELEASED

Change in osmo-ttcn3-hacks[master]: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Han...

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13947 ) Change subject: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Handover tests") .. Patch Set 1: Code-Review-1 the

Change in osmo-msc[master]: libmsc/gsm_04_08.c: clarify IMEI rejection in gsm48_rx_mm_serv_req()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13944 Change subject: libmsc/gsm_04_08.c: clarify IMEI rejection in gsm48_rx_mm_serv_req() .. libmsc/gsm_04_08.c: clarify IMEI rejection in

Change in osmo-msc[master]: call_leg: document the parent_event_* items

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13946 Change subject: call_leg: document the parent_event_* items .. call_leg: document the parent_event_* items Change-Id:

Change in osmo-msc[master]: LOG_TRANS: store subsys in trans, unify USSD logging back to DMM

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13941 ) Change subject: LOG_TRANS: store subsys in trans, unify USSD logging back to DMM .. Patch Set 1: Code-Review+2 (2 comments)

Change in osmo-msc[master]: no HO call forwarding if no RTP stream

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13940 ) Change subject: no HO call forwarding if no RTP stream .. Patch Set 1: Code-Review+1 Fine with me in general. -- To view, visit

Change in osmo-msc[master]: libmsc/gsm_04_08.c: refactor CM Service Request parsing

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13907 ) Change subject: libmsc/gsm_04_08.c: refactor CM Service Request parsing .. Set Ready For Review -- To view, visit

Change in osmo-msc[master]: libmsc/ran_peer.c: fix msgb memleak in ran_peer_rx_reset()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13953 Change subject: libmsc/ran_peer.c: fix msgb memleak in ran_peer_rx_reset() .. libmsc/ran_peer.c: fix msgb memleak in ran_peer_rx_reset()

Change in osmo-msc[master]: libmsc/ran_peer.c: fix msgb memleak in ran_peer_rx_reset()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13953 ) Change subject: libmsc/ran_peer.c: fix msgb memleak in ran_peer_rx_reset() .. libmsc/ran_peer.c: fix msgb memleak in

Change in libosmo-sccp[master]: osmo-stp: register VTY commands for talloc context introspection

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13954 Change subject: osmo-stp: register VTY commands for talloc context introspection .. osmo-stp: register VTY commands for talloc context

Change in osmo-msc[master]: call_leg: document the parent_event_* items

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13946 ) Change subject: call_leg: document the parent_event_* items .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13955 ) Change subject: osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML .. osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on

Change in osmocom-bb[master]: trxcon/trx_if.c: use read() call instead of recv()

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13956 ) Change subject: trxcon/trx_if.c: use read() call instead of recv() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon/trx_if.c: use ssize_t for return value of read()

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13958 ) Change subject: trxcon/trx_if.c: use ssize_t for return value of read() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Fix IMSI table lookup on RANAP paging

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13959 ) Change subject: RAN_Emulation: Fix IMSI table lookup on RANAP paging .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Fix IMSI table lookup on RANAP paging

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13959 ) Change subject: RAN_Emulation: Fix IMSI table lookup on RANAP paging .. RAN_Emulation: Fix IMSI table lookup on RANAP paging We

Change in osmocom-bb[master]: trxcon/trx_if.c: print error message if read() call fails

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13957 ) Change subject: trxcon/trx_if.c: print error message if read() call fails .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13955 ) Change subject: osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML .. Patch Set 1: Code-Review+2 -- To view, visit

Build failed in Jenkins: master-osmo-sip-connector » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #1389

2019-05-09 Thread jenkins
See -- [...truncated 11.08 KB...] checking if gcc supports -fno-rtti -fno-exceptions... no

Change in osmo-bts[master]: osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13955 Change subject: osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML .. osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML

Change in osmo-msc[master]: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13655 ) Change subject: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length .. Set Ready For Review -- To view, visit

Change in osmo-bts[master]: osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13955 ) Change subject: osmo-bts-sysmo: fix: indicate BTS_FEAT_CBCH support on OML .. Patch Set 1: I have very limited experience with sysmoBTS,

Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Fix IMSI table lookup on RANAP paging

2019-05-09 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13959 Change subject: RAN_Emulation: Fix IMSI table lookup on RANAP paging .. RAN_Emulation: Fix IMSI table lookup on RANAP paging We need to

Change in osmocom-bb[master]: trxcon/trx_if.c: use read() call instead of recv()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13956 Change subject: trxcon/trx_if.c: use read() call instead of recv() .. trxcon/trx_if.c: use read() call instead of recv() According to the

Change in osmocom-bb[master]: trxcon/trx_if.c: print error message if read() call fails

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13957 Change subject: trxcon/trx_if.c: print error message if read() call fails .. trxcon/trx_if.c: print error message if read() call fails

Change in osmocom-bb[master]: trxcon/trx_if.c: use ssize_t for return value of read()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13958 Change subject: trxcon/trx_if.c: use ssize_t for return value of read() .. trxcon/trx_if.c: use ssize_t for return value of read()

Change in osmocom-bb[master]: trxcon/trx_if.c: use ssize_t for return value of read()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13958 ) Change subject: trxcon/trx_if.c: use ssize_t for return value of read() .. trxcon/trx_if.c: use ssize_t for return value of

Change in osmo-msc[master]: libmsc/ran_peer.c: fix msgb memleak in ran_peer_rx_reset()

2019-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13953 ) Change subject: libmsc/ran_peer.c: fix msgb memleak in ran_peer_rx_reset() .. Patch Set 1: Code-Review+2 excellent, this code is from

Change in osmocom-bb[master]: trxcon/trx_if.c: use read() call instead of recv()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13956 ) Change subject: trxcon/trx_if.c: use read() call instead of recv() .. trxcon/trx_if.c: use read() call instead of recv()

Change in osmocom-bb[master]: trxcon/trx_if.c: print error message if read() call fails

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13957 ) Change subject: trxcon/trx_if.c: print error message if read() call fails .. trxcon/trx_if.c: print error message if read() call

Change in libosmocore[master]: fix typo in FSM description

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13951 ) Change subject: fix typo in FSM description .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13951 To

Change in libosmocore[master]: fix typo in FSM description

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13951 ) Change subject: fix typo in FSM description .. fix typo in FSM description Change-Id: I3559e9c0769b708cee0d1b221b60960c62f15bd4 ---

Change in osmo-msc[master]: ran_a_make_handover_request(): allow no encryption

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13938 ) Change subject: ran_a_make_handover_request(): allow no encryption .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: LOG_TRANS: store subsys in trans, unify USSD logging back to DMM

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13941 ) Change subject: LOG_TRANS: store subsys in trans, unify USSD logging back to DMM .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: no HO call forwarding if no RTP stream

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13940 ) Change subject: no HO call forwarding if no RTP stream .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13940 To

Change in osmo-msc[master]: make msc_a_vsub() and others NULL-safe

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13939 ) Change subject: make msc_a_vsub() and others NULL-safe .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13939 To

Change in libosmocore[master]: Add MO-FALLBACK-VALUE SGsAP IE

2019-05-09 Thread Omar Ramadan
Omar Ramadan has uploaded this change for review. ( https://gerrit.osmocom.org/13952 Change subject: Add MO-FALLBACK-VALUE SGsAP IE .. Add MO-FALLBACK-VALUE SGsAP IE In testing against a particular EPC, the

Change in libosmocore[master]: Add MO-FALLBACK-VALUE SGsAP IE

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13952 ) Change subject: Add MO-FALLBACK-VALUE SGsAP IE .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13952 To

Change in osmocom-bb[master]: trxcon/l1ctl.c: pass band_arfcn to l1ctl_tx_rach_conf()

2019-05-09 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12613 to look at the new patch set (#3). Change subject: trxcon/l1ctl.c: pass band_arfcn to l1ctl_tx_rach_conf() ..

Change in osmocom-bb[master]: trxcon/l1ctl.c: init DL info header in l1ctl_tx_rach_conf()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13948 Change subject: trxcon/l1ctl.c: init DL info header in l1ctl_tx_rach_conf() .. trxcon/l1ctl.c: init DL info header in l1ctl_tx_rach_conf()

Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13723 ) Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence .. Patch Set 4: Verified+1 Code-Review+2 I really

Change in osmo-ccid-firmware[master]: add function to transfer TPDU

2019-05-09 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13949 Change subject: add function to transfer TPDU .. add function to transfer TPDU this function takes care of reading and writing the complete

Change in osmo-bts[master]: README.md: remove OS#1865 from 'Known limitations'

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13741 ) Change subject: README.md: remove OS#1865 from 'Known limitations' .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13723 ) Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence .. Patch Set 5: > I would appreciate if you remove

Change in osmocom-bb[master]: trxcon/l1ctl.c: init DL info header in l1ctl_tx_rach_conf()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13948 ) Change subject: trxcon/l1ctl.c: init DL info header in l1ctl_tx_rach_conf() .. trxcon/l1ctl.c: init DL info header in

Change in osmocom-bb[master]: trxcon/l1ctl.c: pass band_arfcn to l1ctl_tx_rach_conf()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12613 ) Change subject: trxcon/l1ctl.c: pass band_arfcn to l1ctl_tx_rach_conf() .. trxcon/l1ctl.c: pass band_arfcn to

Change in osmocom-bb[master]: trxcon/l1ctl.c: init DL info header in l1ctl_tx_rach_conf()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13948 ) Change subject: trxcon/l1ctl.c: init DL info header in l1ctl_tx_rach_conf() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx

2019-05-09 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() w/o MM ctx .. Patch Set 2: Code-Review-1 I think the problem lies somewhere else.

Change in libosmocore[master]: fix typo in FSM description

2019-05-09 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13951 Change subject: fix typo in FSM description .. fix typo in FSM description Change-Id: I3559e9c0769b708cee0d1b221b60960c62f15bd4 --- M

Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

2019-05-09 Thread Alexander Chemeris
Alexander Chemeris has posted comments on this change. ( https://gerrit.osmocom.org/13723 ) Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence .. Patch Set 5: > > I would appreciate if you

Change in libosmocore[master]: Add MO-FALLBACK-VALUE SGsAP IE

2019-05-09 Thread Omar Ramadan
Omar Ramadan has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/13952 ) Change subject: Add MO-FALLBACK-VALUE SGsAP IE .. Add MO-FALLBACK-VALUE SGsAP IE In testing against a particular EPC, the

Change in osmocom-bb[master]: trxcon/l1ctl.c: pass band_arfcn to l1ctl_tx_rach_conf()

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12613 ) Change subject: trxcon/l1ctl.c: pass band_arfcn to l1ctl_tx_rach_conf() .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Han...

2019-05-09 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/13947 ) Change subject: Revert partial of 0ac6315212a3 ("msc: add inter-BSC and inter-MSC Handover tests") .. Patch Set 1: > the problem here is

Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

2019-05-09 Thread Alexander Chemeris
Alexander Chemeris has posted comments on this change. ( https://gerrit.osmocom.org/13723 ) Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence .. Patch Set 4: > I really appreciate all the

Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

2019-05-09 Thread Alexander Chemeris
Alexander Chemeris has submitted this change and it was merged. ( https://gerrit.osmocom.org/13723 ) Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence .. osmo-bts-trx: distinguish 11-bit Access

Change in osmo-ccid-firmware[master]: finish implementing sim-iccid

2019-05-09 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13950 Change subject: finish implementing sim-iccid .. finish implementing sim-iccid Change-Id: I71b5832703a60c0c967fa2c6bc0eec56883962c5 --- M

Change in libosmo-sccp[master]: stp: Ensure telnet uses STP talloc context, not NULL context

2019-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13933 ) Change subject: stp: Ensure telnet uses STP talloc context, not NULL context .. stp: Ensure telnet uses STP talloc context, not NULL

Change in osmo-msc[master]: msub_check_for_release(): Initialize msc_role_a_c

2019-05-09 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13932 ) Change subject: msub_check_for_release(): Initialize msc_role_a_c .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: no HO call forwarding if no RTP stream

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13940 ) Change subject: no HO call forwarding if no RTP stream .. Patch Set 1: (1 comment)

Change in libosmocore[master]: Fix osmo_quote_str_c() for strings larger than 32 bytes

2019-05-09 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13901 ) Change subject: Fix osmo_quote_str_c() for strings larger than 32 bytes .. Patch Set 5: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: make msc_a_vsub() and others NULL-safe

2019-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13939 ) Change subject: make msc_a_vsub() and others NULL-safe .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13939

  1   2   >