Change in ...osmo-iuh[master]: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw

2019-08-23 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15268 ) Change subject: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw .. hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw

Change in ...osmo-iuh[master]: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15268 ) Change subject: hnbgw_vty.c: fix: properly pass pointer to g_hnb_gw .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...osmo-mgw[master]: fix crashes: don't assert on incoming RTP packet size

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15242 ) Change subject: fix crashes: don't assert on incoming RTP packet size .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...osmo-mgw[master]: mgcp_send(): stop looping on conversion error

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15243 ) Change subject: mgcp_send(): stop looping on conversion error .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: ggsn: Update test xfail->pass in expected-results.xml

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 ) Change subject: ggsn: Update test xfail->pass in expected-results.xml .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: ggsn: Add missing v4v6 tests in expected-results.xml

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 ) Change subject: ggsn: Add missing v4v6 tests in expected-results.xml .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp46_act_deact_apn4

2019-08-23 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262 ) Change subject: ggsn: Introduce test TC_pdp46_act_deact_apn4 .. ggsn: Introduce test TC_pdp46_act_deact_apn4

Change in ...osmo-ttcn3-hacks[master]: ggsn: Update test xfail->pass in expected-results.xml

2019-08-23 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15261 ) Change subject: ggsn: Update test xfail->pass in expected-results.xml .. ggsn: Update test xfail->pass in

Change in ...osmo-ttcn3-hacks[master]: ggsn: Add missing v4v6 tests in expected-results.xml

2019-08-23 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15260 ) Change subject: ggsn: Add missing v4v6 tests in expected-results.xml .. ggsn: Add missing v4v6 tests in

Change in ...osmo-trx[master]: Drop old setPriority related code

2019-08-23 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15258 ) Change subject: Drop old setPriority related code .. Drop old setPriority related code This code is not needed anymore

Change in ...osmo-trx[master]: Drop old setPriority related code

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15258 ) Change subject: Drop old setPriority related code .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp46_act_deact_apn4

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15262 ) Change subject: ggsn: Introduce test TC_pdp46_act_deact_apn4 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 ) Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected .. Patch Set 1: Code-Review+1 -- To view,

Change in ...osmo-sgsn[master]: gprs_gmm.c: Add spec document to function documentation

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15264 ) Change subject: gprs_gmm.c: Add spec document to function documentation .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-sgsn[master]: gprs_gmm.c: Print value_string of reject cause

2019-08-23 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 ) Change subject: gprs_gmm.c: Print value_string of reject cause .. gprs_gmm.c: Print value_string of reject cause

Change in ...osmo-sgsn[master]: gprs_gmm.c: Add spec document to function documentation

2019-08-23 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15264 ) Change subject: gprs_gmm.c: Add spec document to function documentation .. gprs_gmm.c: Add spec document to function

Change in ...osmo-sgsn[master]: gprs_gmm.c: Print value_string of reject cause

2019-08-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15263 ) Change subject: gprs_gmm.c: Print value_string of reject cause .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: Cosmetic: l1sap.h: change /* !< to /*!

2019-08-23 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15269 Change subject: Cosmetic: l1sap.h: change /* !< to /*!< .. Cosmetic: l1sap.h: change /* !< to /*!< Change-Id:

Change in ...osmo-bts[master]: Cosmetic: virtual: l1sap.c: fix typos

2019-08-23 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15270 Change subject: Cosmetic: virtual: l1sap.c: fix typos .. Cosmetic: virtual: l1sap.c: fix typos Change-Id:

Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH

2019-08-23 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. virtual: set link quality for GSMTAP_CHANNEL_RACH Don't ignore

Change in ...osmo-ci[master]: gerrit-verifications: fix osmo-bts cmd

2019-08-23 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/15272 Change subject: gerrit-verifications: fix osmo-bts cmd .. gerrit-verifications: fix osmo-bts cmd Fixes:

Change in ...osmo-ci[master]: gerrit-verifications: fix osmo-bts cmd

2019-08-23 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15272 ) Change subject: gerrit-verifications: fix osmo-bts cmd .. Patch Set 1: Verified+1 Code-Review+2 Super trivial and tested, merging

Change in ...osmo-ci[master]: gerrit-verifications: fix osmo-bts cmd

2019-08-23 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/15272 ) Change subject: gerrit-verifications: fix osmo-bts cmd .. gerrit-verifications: fix osmo-bts cmd Fixes:

Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH

2019-08-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 1: Code-Review-1 (1 comment)

Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH

2019-08-23 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 1: (Jenkins failures are unrelated, retriggered) --

Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH

2019-08-23 Thread osmith
Hello pespin, fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15271 to look at the new patch set (#2). Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH

Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH

2019-08-23 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 2: (1 comment)

Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH

2019-08-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...osmo-bts[master]: Cosmetic: virtual: l1sap.c: fix typos

2019-08-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15270 ) Change subject: Cosmetic: virtual: l1sap.c: fix typos .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: Cosmetic: l1sap.h: change /* !< to /*!

2019-08-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15269 ) Change subject: Cosmetic: l1sap.h: change /* !< to /*!< .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-bts[master]: Cosmetic: virtual: l1sap.c: fix typos

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15270 ) Change subject: Cosmetic: virtual: l1sap.c: fix typos .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-bts[master]: Cosmetic: virtual: l1sap.c: fix typos

2019-08-23 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15270 ) Change subject: Cosmetic: virtual: l1sap.c: fix typos .. Cosmetic: virtual: l1sap.c: fix typos Change-Id:

Change in ...libosmocore[master]: Cosmetic: l1sap.h: change /* !< to /*!

2019-08-23 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15269 ) Change subject: Cosmetic: l1sap.h: change /* !< to /*!< .. Cosmetic: l1sap.h: change /* !< to /*!< Change-Id:

Change in ...libosmocore[master]: Cosmetic: l1sap.h: change /* !< to /*!

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15269 ) Change subject: Cosmetic: l1sap.h: change /* !< to /*!< .. Patch Set 1: Code-Review+2 -- To view, visit

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of

Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of

Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_18.10/i586

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_18.10/i586 Package network:osmocom:nightly/libosmo-netif failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last

Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Change in ...osmo-bts[master]: virtual: set link quality for GSMTAP_CHANNEL_RACH

2019-08-23 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15271 ) Change subject: virtual: set link quality for GSMTAP_CHANNEL_RACH .. virtual: set link quality for GSMTAP_CHANNEL_RACH Don't

Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected

2019-08-23 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 ) Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected .. Patch Set 1: (1 comment)

Change in ...osmo-ggsn[master]: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15259 ) Change subject: libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected .. Patch Set 1: (1 comment)

Change in ...osmo-ggsn[master]: ggsn: Split application lifecycle related code into ggsn_main.c

2019-08-23 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15249 to look at the new patch set (#2). Change subject: ggsn: Split application lifecycle related code into ggsn_main.c

Change in ...osmo-ggsn[master]: ggsn: Move PCO handling code into its own file

2019-08-23 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15246 to look at the new patch set (#2). Change subject: ggsn: Move PCO handling code into its own file ..

Change in ...osmo-ggsn[master]: ggsn: Implement echo req/resp and recovery

2019-08-23 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 to look at the new patch set (#2). Change subject: ggsn: Implement echo req/resp and recovery .. ggsn:

Change in ...osmo-python-tests[master]: Add osmo_interact_exec.py

2019-08-23 Thread pespin
Hello osmith, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15273 to review the following change. Change subject: Add osmo_interact_exec.py .. Add

Change in ...osmo-python-tests[master]: vty.py: Fix endl removed when pkt buffer content ends exactly on a ne...

2019-08-23 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15274 Change subject: vty.py: Fix endl removed when pkt buffer content ends exactly on a newline char .. vty.py: Fix endl

Change in ...osmo-python-tests[master]: Add osmo_interact_exec.py

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15273 ) Change subject: Add osmo_interact_exec.py .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-python-tests[master]: Add osmo_interact_exec.py

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/15273 ) Change subject: Add osmo_interact_exec.py .. Patch Set 1: Code-Review-2 This one was pushed by error by myself,

Change in ...osmo-ggsn[master]: ggsn: Implement echo req/resp and recovery

2019-08-23 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 to look at the new patch set (#3). Change subject: ggsn: Implement echo req/resp and recovery .. ggsn:

Change in ...osmo-ggsn[master]: doc: Update vty reference xml file

2019-08-23 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15275 Change subject: doc: Update vty reference xml file .. doc: Update vty reference xml file Change-Id:

Change in ...osmo-bsc[master]: lchan_select.c: tune log level in lchan_select_by_type()

2019-08-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15276 Change subject: lchan_select.c: tune log level in lchan_select_by_type() .. lchan_select.c: tune log level in lchan_select_by_type()

Change in ...osmo-bsc[master]: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()

2019-08-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 Change subject: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC() .. abis_nm.c: handle_manufact_report(): use LOGP(), not

Change in ...osmo-bsc[master]: lchan_select.c: tune log level in lchan_select_by_type()

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15276 ) Change subject: lchan_select.c: tune log level in lchan_select_by_type() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-bsc[master]: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 ) Change subject: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC() .. Patch Set 1: (2 comments)

Change in ...osmo-bsc[master]: abis_nm.c: use LOGP() macro instead of LOGPC()

2019-08-23 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277 to look at the new patch set (#2). Change subject: abis_nm.c: use LOGP() macro instead of LOGPC() ..

Change in ...osmo-bsc[master]: abis_nm.c: use LOGP() macro instead of LOGPC()

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 ) Change subject: abis_nm.c: use LOGP() macro instead of LOGPC() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...osmo-bsc[master]: abis_nm.c: use LOGP() macro instead of LOGPC()

2019-08-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 ) Change subject: abis_nm.c: use LOGP() macro instead of LOGPC() .. Patch Set 2: (2 comments)

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

2019-08-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap

2019-08-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15279 Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap .. osmobts_sock.cpp: pcu_sock_read(): use stack buffer,

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

2019-08-23 Thread fixeria
Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 to look at the new patch set (#2). Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 ) Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. Patch Set 2: (1 comment)

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15279 ) Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15279 ) Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap .. Patch Set 2: Are you sure msgb is not retrieved

Change in ...osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference

2019-08-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15281 Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference .. gprs_bssgp_destroy(): fix NULL-pointer dereference The

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): further simplify the code

2019-08-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15280 Change subject: osmobts_sock.cpp: pcu_sock_read(): further simplify the code .. osmobts_sock.cpp: pcu_sock_read(): further simplify

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

2019-08-23 Thread fixeria
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 to look at the new patch set (#3). Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap

2019-08-23 Thread fixeria
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/15279 to look at the new patch set (#3). Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

2019-08-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 ) Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. Patch Set 3: (1 comment)

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap

2019-08-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15279 ) Change subject: osmobts_sock.cpp: pcu_sock_read(): use stack buffer, not heap .. Patch Set 3: > Patch Set 2: > > Are you sure msgb

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 ) Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...osmo-pcu[master]: osmobts_sock.cpp: pcu_sock_read(): further simplify the code

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15280 ) Change subject: osmobts_sock.cpp: pcu_sock_read(): further simplify the code .. Patch Set 1: (1 comment)

Change in ...osmo-pcu[master]: gprs_bssgp_destroy(): fix NULL-pointer dereference

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15281 ) Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference .. Patch Set 1: Code-Review-1 (1 comment)

Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp_act2_recovery

2019-08-23 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15283 Change subject: ggsn: Introduce test TC_pdp_act2_recovery .. ggsn: Introduce test TC_pdp_act2_recovery Some code is moved out

Change in ...osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp_act_restart_ctr_echo

2019-08-23 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15282 Change subject: ggsn: Introduce test TC_pdp_act_restart_ctr_echo .. ggsn: Introduce test TC_pdp_act_restart_ctr_echo VTY

Change in ...docker-playground[master]: ttcn3-ggsn: Disable echo-timer test when running against latest

2019-08-23 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/15284 Change subject: ttcn3-ggsn: Disable echo-timer test when running against latest .. ttcn3-ggsn: Disable echo-timer test when

Change in ...osmo-ggsn[master]: ggsn: Implement echo req/resp and recovery

2019-08-23 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15267 ) Change subject: ggsn: Implement echo req/resp and recovery .. Patch Set 4: Tested now with TTCN3 -- To view, visit

Change in ...osmo-msc[master]: smpp_openbsc.c: check acl before deref it

2019-08-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15285 ) Change subject: smpp_openbsc.c: check acl before deref it .. Patch Set 1: Code-Review+1 -- To view, visit

Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of

Change in ...osmo-msc[master]: smpp_openbsc.c: check acl before deref it

2019-08-23 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15285 Change subject: smpp_openbsc.c: check acl before deref it .. smpp_openbsc.c: check acl before deref it All other calls check

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64

2019-08-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of