Change in osmo-sgsn[master]: gprs_gmm.c: Send XID reset with received TLLI

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16151 ) Change subject: gprs_gmm.c: Send XID reset with received TLLI .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_req_id_req_ra_update

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16016 ) Change subject: sgsn: Introduce test TC_attach_req_id_req_ra_update .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: gprs_gmm.c: Send XID reset with received TLLI

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16151 ) Change subject: gprs_gmm.c: Send XID reset with received TLLI .. gprs_gmm.c: Send XID reset with received TLLI Otherwise lower layers will

Change in osmo-sgsn[master]: Improve logging in gprs_llc.c code

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16147 ) Change subject: Improve logging in gprs_llc.c code .. Improve logging in gprs_llc.c code Change-Id:

Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_req_id_req_ra_update

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16016 ) Change subject: sgsn: Introduce test TC_attach_req_id_req_ra_update .. sgsn: Introduce test TC_attach_req_id_req_ra_update The

Change in osmo-ttcn3-hacks[master]: msc: add sdp to MNCC

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16032 ) Change subject: msc: add sdp to MNCC .. msc: add sdp to MNCC SDP is added to the MNCC protocol in osmo-msc

Change in osmo-ttcn3-hacks[master]: msc: fix Iu mo call

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15939 ) Change subject: msc: fix Iu mo call .. msc: fix Iu mo call Change-Id: I0ead36333ab665147b8d222070ea5cf8afc555ec --- M

Change in osmo-sgsn[master]: gprs_llc.c: Use enum instead of hardcoded value

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16150 ) Change subject: gprs_llc.c: Use enum instead of hardcoded value .. gprs_llc.c: Use enum instead of hardcoded value Change-Id:

Change in osmo-sip-connector[master]: exit if the sip agent failed to start

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 ) Change subject: exit if the sip agent failed to start .. exit if the sip agent failed to start When the sip agent start fails (i.e.

Change in osmo-sip-connector[master]: exit if the sip agent failed to start

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 ) Change subject: exit if the sip agent failed to start .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: free USB buffer when allocation failed

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16097 ) Change subject: free USB buffer when allocation failed .. Patch Set 1: (1 comment)

Change in osmo-msc[master]: Fix some typos

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16074 ) Change subject: Fix some typos .. Fix some typos Fix typos and common misspellings in code comments and log messages. Change-Id:

Change in osmo-msc[master]: Fix some typos

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16074 ) Change subject: Fix some typos .. Patch Set 3: Code-Review+2 (1 comment)

Change in osmo-bts[master]: remove dummy UL measurement results for lost sacch frames

2019-11-23 Thread laforge
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14762 ) Change subject: remove dummy UL measurement results for lost sacch frames .. Abandoned -- To view, visit

Change in osmo-trx[master]: Initial XTRX support

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 ) Change subject: Initial XTRX support .. Patch Set 3: @ipse, @sergey, @mold, can we please get some feedback to move this ahead? It

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_mo_ping_pong

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15681 ) Change subject: pcu: Introduce test TC_mo_ping_pong .. Patch Set 6: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_mo_ping_pong

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15681 ) Change subject: pcu: Introduce test TC_mo_ping_pong .. pcu: Introduce test TC_mo_ping_pong Ideally some more checks should be done on

Change in osmo-trx[master]: CommonLibs: check HAVE_CONFIG_H before including it

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15684 ) Change subject: CommonLibs: check HAVE_CONFIG_H before including it .. Patch Set 2: @ipse, @sergey, @mold, can we please get some

Change in libosmocore[master]: vty/vty.c: log received commands from telnet interface

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 ) Change subject: vty/vty.c: log received commands from telnet interface .. Patch Set 6: do we have any other opinions than mine

Change in osmo-pcu[master]: PTCCH: properly handle RTS.req for PCU_IF_SAPI_PTCCH

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16083 ) Change subject: PTCCH: properly handle RTS.req for PCU_IF_SAPI_PTCCH .. PTCCH: properly handle RTS.req for PCU_IF_SAPI_PTCCH Change-Id:

Change in osmo-pcu[master]: pcuif_proto.h: extend RACH.ind with TRX / TS numbers

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16084 ) Change subject: pcuif_proto.h: extend RACH.ind with TRX / TS numbers .. pcuif_proto.h: extend RACH.ind with TRX / TS numbers Since there can

Change in osmo-pcu[master]: PTCCH: implement basic message codec and API

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16082 ) Change subject: PTCCH: implement basic message codec and API .. PTCCH: implement basic message codec and API Change-Id:

Change in docker-playground[master]: Update ttcn3-*/jenkins.sh to log stdout+stderr of process to log file

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16064 ) Change subject: Update ttcn3-*/jenkins.sh to log stdout+stderr of process to log file .. Update ttcn3-*/jenkins.sh to log

Change in docker-playground[master]: respawn.sh: Add logging and limit loop iterations

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16137 ) Change subject: respawn.sh: Add logging and limit loop iterations .. Patch Set 1: Code-Review+2 -- To view, visit

Change in docker-playground[master]: respawn.sh: Add logging and limit loop iterations

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16137 ) Change subject: respawn.sh: Add logging and limit loop iterations .. respawn.sh: Add logging and limit loop iterations Since we'll

Change in osmo-pcu[master]: PTCCH: properly handle RTS.req for PCU_IF_SAPI_PTCCH

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16083 ) Change subject: PTCCH: properly handle RTS.req for PCU_IF_SAPI_PTCCH .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: HLR: Add test for generating EPS (LTE) tuples with separation bit == 1

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15366 ) Change subject: HLR: Add test for generating EPS (LTE) tuples with separation bit == 1 .. Patch Set 1: Code-Review+2 --

Change in osmo-bsc[master]: fsm: use deferred deallocation

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15841 ) Change subject: fsm: use deferred deallocation .. fsm: use deferred deallocation Since osmo-bsc uses the MGCP client FSMs, it is required to

Change in osmo-pcu[master]: PTCCH: implement basic message codec and API

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16082 ) Change subject: PTCCH: implement basic message codec and API .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: pcuif_proto.h: extend RACH.ind with TRX / TS numbers

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16084 ) Change subject: pcuif_proto.h: extend RACH.ind with TRX / TS numbers .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: fsm: use deferred deallocation

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15841 ) Change subject: fsm: use deferred deallocation .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: change format of 'last LU seen'

2019-11-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15359 ) Change subject: change format of 'last LU seen' .. Patch Set 3: Code-Review-1 (1 comment)

Change in osmo-ci[master]: osmocom_build_deps.yml: Move from python-nwdiag to python3-nwdiag

2019-11-23 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/16176 ) Change subject: osmocom_build_deps.yml: Move from python-nwdiag to python3-nwdiag .. osmocom_build_deps.yml: Move from

Change in osmo-ci[master]: WIP: coverity: Make sure curl is installed, as our coverity upload jo...

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14506 ) Change subject: WIP: coverity: Make sure curl is installed, as our coverity upload job needs it .. Patch Set 2: Verified+1

Change in osmo-ci[master]: WIP: coverity: Make sure curl is installed, as our coverity upload jo...

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14506 ) Change subject: WIP: coverity: Make sure curl is installed, as our coverity upload job needs it .. WIP: coverity: Make sure curl is installed,

Change in osmo-ci[master]: dockerfile: Add 'dahdi-source' for libosmo-abis

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16033 ) Change subject: dockerfile: Add 'dahdi-source' for libosmo-abis .. Patch Set 2: Verified+1 -- To view, visit

Change in osmo-ci[master]: dockerfile: Add 'dahdi-source' for libosmo-abis

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16033 ) Change subject: dockerfile: Add 'dahdi-source' for libosmo-abis .. dockerfile: Add 'dahdi-source' for libosmo-abis Change-Id:

Change in osmo-ci[master]: WIP: coverity: Make sure curl is installed, as our coverity upload jo...

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14506 ) Change subject: WIP: coverity: Make sure curl is installed, as our coverity upload job needs it .. Set Ready For Review -- To

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2019-11-23 Thread fixeria
fixeria has uploaded a new patch set (#5) to the change originally created by Max. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Use libosmocore

Change in libosmocore[master]: make use of OTC_GLOBAL when allocating library-internal contexts

2019-11-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13338 ) Change subject: make use of OTC_GLOBAL when allocating library-internal contexts .. Patch Set 15: (1 comment)

Change in osmo-ci[master]: osmocom_build_deps.yml: Move from python-nwdiag to python3-nwdiag

2019-11-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16176 ) Change subject: osmocom_build_deps.yml: Move from python-nwdiag to python3-nwdiag .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Use libosmocore constant for IMSI length in ACL entry Presumably

Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12224 ) Change subject: Use libosmocore constant for IMSI length in ACL entry .. Patch Set 5: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: PTCCH: properly handle RACH.ind for PCU_IF_SAPI_PTCCH

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16085 ) Change subject: PTCCH: properly handle RACH.ind for PCU_IF_SAPI_PTCCH .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: PTCCH: properly handle RACH.ind for PCU_IF_SAPI_PTCCH

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16085 ) Change subject: PTCCH: properly handle RACH.ind for PCU_IF_SAPI_PTCCH .. PTCCH: properly handle RACH.ind for PCU_IF_SAPI_PTCCH Change-Id:

Change in osmo-ttcn3-hacks[master]: GSUP_Types: Add support for GSUP_IE_RAT_TYPE

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15365 ) Change subject: GSUP_Types: Add support for GSUP_IE_RAT_TYPE .. Set Ready For Review -- To view, visit

Change in osmo-ci[master]: osmocom_build_deps.yml: Move from python-nwdiag to python3-nwdiag

2019-11-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16176 ) Change subject: osmocom_build_deps.yml: Move from python-nwdiag to python3-nwdiag .. osmocom_build_deps.yml: Move from python-nwdiag to

Change in osmo-ci[master]: osmocom_build_deps.yml: Move from python-nwdiag to python3-nwdiag

2019-11-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16176 ) Change subject: osmocom_build_deps.yml: Move from python-nwdiag to python3-nwdiag .. Patch Set 1: Verified+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: GSUP_Types: Add support for GSUP_IE_RAT_TYPE

2019-11-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15365 ) Change subject: GSUP_Types: Add support for GSUP_IE_RAT_TYPE .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: RSL: Wrong CCCH_CONFIG in SI3 causes a lot of MO call setup failed wh...

2019-11-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15909 ) Change subject: RSL: Wrong CCCH_CONFIG in SI3 causes a lot of MO call setup failed when the BTS configured with none combined CCCH mode.

Change in osmo-pcu[master]: PTCCH: properly handle RACH.ind for PCU_IF_SAPI_PTCCH

2019-11-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16085 ) Change subject: PTCCH: properly handle RACH.ind for PCU_IF_SAPI_PTCCH .. Patch Set 4: This change is ready for review. -- To

Change in osmo-trx[master]: Initial XTRX support

2019-11-23 Thread ipse
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15685 ) Change subject: Initial XTRX support .. Patch Set 3: > @ipse, @sergey, @mold, can we please get some feedback to move this ahead? >

Change in osmocom-bb[master]: trx_toolkit/clck_gen.py: turn CLCKGen's thread into a daemon

2019-11-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16178 ) Change subject: trx_toolkit/clck_gen.py: turn CLCKGen's thread into a daemon .. trx_toolkit/clck_gen.py: turn CLCKGen's thread

Change in osmocom-bb[master]: trx_toolkit/clck_gen.py: refactor CLCKGen to use a single thread

2019-11-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16177 ) Change subject: trx_toolkit/clck_gen.py: refactor CLCKGen to use a single thread .. trx_toolkit/clck_gen.py: refactor CLCKGen to

Change in osmocom-bb[master]: trx_toolkit/clck_gen.py: drop unneeded debug print()

2019-11-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16179 ) Change subject: trx_toolkit/clck_gen.py: drop unneeded debug print() .. trx_toolkit/clck_gen.py: drop unneeded debug print()