[PATCH] osmo-trx[master]: sigProcLib: Check return status on downsampling

2017-03-28 Thread Tom Tsou
Review at https://gerrit.osmocom.org/2172 sigProcLib: Check return status on downsampling Improper length values will cause the polyphase resampler rotation to fail. Check return and return NULL on error. Change-Id: I3ad22f9fd7a20754f589c04258dcca3770474a9b Fixes: Coverity CID 165235 --- M

[PATCH] osmo-trx[master]: sigProcLib: Remove unreachable code and no-effect checks

2017-03-28 Thread Tom Tsou
Review at https://gerrit.osmocom.org/2171 sigProcLib: Remove unreachable code and no-effect checks Unreachable path and negative value inspection on unsigned types. Change-Id: If53b4b03550b0a7656c808cfe96806252153eb2f Fixes: Coverity CID 165239, 165238, 165236 --- M

osmo-trx[master]: sigProcLib: Fix negative value check on unsigned value

2017-03-28 Thread Tom Tsou
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2163 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d7d1bceb5fe66e69345db93a74e3e0773a2257 Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master

[MERGED] osmo-trx[master]: sigProcLib: Add operator<< to print CorrType to a string.

2017-03-28 Thread Alexander Chemeris
Alexander Chemeris has submitted this change and it was merged. Change subject: sigProcLib: Add operator<< to print CorrType to a string. .. sigProcLib: Add operator<< to print CorrType to a string. Change-Id:

[MERGED] osmo-trx[master]: Move BURST_THRESH from Transceiver.cpp to sigProcLib.h to ma...

2017-03-28 Thread Alexander Chemeris
Alexander Chemeris has submitted this change and it was merged. Change subject: Move BURST_THRESH from Transceiver.cpp to sigProcLib.h to make it reusable. .. Move BURST_THRESH from Transceiver.cpp to sigProcLib.h to make it

[MERGED] osmo-trx[master]: Move Transceiver::detectBurst() to sigProcLib to make it reu...

2017-03-28 Thread Alexander Chemeris
Alexander Chemeris has submitted this change and it was merged. Change subject: Move Transceiver::detectBurst() to sigProcLib to make it reusable. .. Move Transceiver::detectBurst() to sigProcLib to make it reusable.