[PATCH] pysim[master]: fix writing of ICCID for sysmo-usim-sjs1

2017-04-05 Thread dexter
Hello Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2175 to look at the new patch set (#3). fix writing of ICCID for sysmo-usim-sjs1 The programming procedure for sysmo-usim-sjs1 lacks writing the ICCID. This commit adds the missing call to

[ABANDON] pysim[master]: fixup

2017-04-05 Thread dexter
dexter has abandoned this change. Change subject: fixup .. Abandoned -- To view, visit https://gerrit.osmocom.org/2230 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id:

[PATCH] osmo-bts[master]: Name systemd service after the software

2017-04-05 Thread Pau Espin Pedrol
Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2225 to look at the new patch set (#2). Name systemd service after the software Binary name was changed from sysmobts to osmo-bts but the service file

osmo-trx[master]: Configuration: Fix const and signedness compile warnings

2017-04-05 Thread Tom Tsou
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2221 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701559814b2aee6f84f10e612f128da40f6a51c1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[PATCH] libosmocore[master]: gsm0808: make gsm0808_create_reset_ack() accessible

2017-04-05 Thread dexter
Review at https://gerrit.osmocom.org/2229 gsm0808: make gsm0808_create_reset_ack() accessible The create function to generate the RESET ACKNOWLEDGE message is not accessible from outside, as it does not appear in limosmogsm.map. It also has not testcase. This commit adds

[MERGED] osmo-iuh[master]: asn1tostruct.py: specify python version in shebang

2017-04-05 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: asn1tostruct.py: specify python version in shebang .. asn1tostruct.py: specify python version in shebang The script is expected to be run using python

osmo-iuh[master]: asn1tostruct.py: specify python version in shebang

2017-04-05 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2228 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eb95351538a64f2b23d638824972818591b1b66 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master

[PATCH] openbsc[master]: abis: log known ACKs and unknown messages

2017-04-05 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2227 to look at the new patch set (#3). abis: log known ACKs and unknown messages Log expected ACK messages and unhandled messages to aid in troubleshooting. Change-Id:

openbsc[master]: abis: log known ACKs and unknown messages

2017-04-05 Thread Harald Welte
Patch Set 2: Code-Review-2 (1 comment) https://gerrit.osmocom.org/#/c/2227/2/openbsc/src/libbsc/abis_nm.c File openbsc/src/libbsc/abis_nm.c: Line 700: btstype2str(bts->type)); The BTS type is not useful here (it is static configuratoin for one given BTS number). The MO

libosmo-sccp[master]: Add new 'osmo_ss7' SS7 core code with M3UA, ASP/AS FSM, ...

2017-04-05 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2209 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I375eb80f01acc013094851d91d1debc12bc7 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

libosmocore[master]: gsm0808: Add create functions for BSS_MAP_MSG_ASSIGMENT_RQST

2017-04-05 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2184 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d1d455a1e1cf95407e23ded7b7defbcf2dd6ff0 Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-bts[master]: Name systemd service after the software

2017-04-05 Thread Max
Patch Set 1: I wonder if it's worth it to merge common parts with debian/osmo-bts-trx.service? -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf

[PATCH] openbsc[master]: abis: log known ACKs and unknown messages

2017-04-05 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2227 to look at the new patch set (#2). abis: log known ACKs and unknown messages Log expected ACK messages and unhandled messages to aid in troubleshooting. Change-Id:

[PATCH] libosmocore[master]: gsm0808: Add create functions for CIPHER MODE COMMAND

2017-04-05 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2182 to look at the new patch set (#5). gsm0808: Add create functions for CIPHER MODE COMMAND gsm0808.h/c lacks functionality to generate CIPHER MODE COMMAND messages. These

[PATCH] libosmocore[master]: gsm0808: Add AoIP specific elements to gsm0808_create_... fu...

2017-04-05 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2178 to look at the new patch set (#5). gsm0808: Add AoIP specific elements to gsm0808_create_... functions the classic A implementation in libosmocore lacks support for AoIP

[PATCH] libosmocore[master]: gsm0808: Add create functions for BSS_MAP_MSG_ASSIGMENT_RQST

2017-04-05 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2184 to look at the new patch set (#6). gsm0808: Add create functions for BSS_MAP_MSG_ASSIGMENT_RQST gsm0808.h/c lacks functionality to generate BSS_MAP_MSG_ASSIGMENT_RQST

[MERGED] osmo-gsm-manuals[master]: gb.adoc: Add info to NS-over-UDP example

2017-04-05 Thread daniel
daniel has submitted this change and it was merged. Change subject: gb.adoc: Add info to NS-over-UDP example .. gb.adoc: Add info to NS-over-UDP example Change-Id: I5b6d2fb284336614da28e0d1b01c7e8c26725f81 --- M

[PATCH] osmo-iuh[master]: asn1tostruct.py: specify python version in shebang

2017-04-05 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2228 asn1tostruct.py: specify python version in shebang The script is expected to be run using python 2.x, but nowadays some distros are already using python 3 as default, which will fail to run this script. This change fixes compilation in my Archlinux

[MERGED] openbsc[master]: python: fix Null logger

2017-04-05 Thread Max
Max has submitted this change and it was merged. Change subject: python: fix Null logger .. python: fix Null logger Change-Id: Ie120273eabbc670e9f19ba365508688a810a2773 Related: SYS#3028 --- M openbsc/contrib/twisted_ipa.py 1