[MERGED] libosmocore[master]: core/conv: implement optimized Viterbi decoder

2017-04-10 Thread Tom Tsou
Tom Tsou has submitted this change and it was merged. Change subject: core/conv: implement optimized Viterbi decoder .. core/conv: implement optimized Viterbi decoder Add a separate, faster convolution decoding implementation f

libosmocore[master]: core/conv: implement optimized Viterbi decoder

2017-04-10 Thread Tom Tsou
Patch Set 6: Code-Review+1 Verified+1 -- To view, visit https://gerrit.osmocom.org/1337 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74d355274b4176a7d924f91ef3c96912ce338fb2 Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch:

Build failure of network:osmocom:nightly/osmo-stp in xUbuntu_16.04/i586

2017-04-10 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build log:

Build failure of network:osmocom:nightly/osmo-stp in xUbuntu_16.10/x86_64

2017-04-10 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build l

Build failure of network:osmocom:nightly/osmo-stp in xUbuntu_16.04/x86_64

2017-04-10 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build l

Build failure of network:osmocom:nightly/osmo-stp in Debian_8.0/i586

2017-04-10 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/Debian_8.0/i586 Package network:osmocom:nightly/osmo-stp failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build log: [ 90

Build failure of network:osmocom:nightly/osmo-stp in Debian_8.0/x86_64

2017-04-10 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-stp failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-stp in xUbuntu_16.10/i586

2017-04-10 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build log:

[PATCH] openbsc[master]: build: iu: use libosmo-sccp tag 'old_sua'

2017-04-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2293 build: iu: use libosmo-sccp tag 'old_sua' libosmo-sccp master is moving ahead, openbsc --enable-iu needs an older version. Change-Id: Id74a802fd2ca65f4b6c2079550fbb6b0af3e8340 --- M contrib/jenkins.sh 1 file changed, 5 insertions(+), 1 deletion(-)

libosmo-netif[master]: stream.c: Fix endianness handling of PPID and STREAM_ID

2017-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2290 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I777174ca2915c6de0063db41a745c71b4a09bbec Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master G

libosmo-sccp[master]: xUA: Fix endianness handling of PPID and STREAM_ID

2017-04-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2291 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51c87314ef9ba6415e7e89980699ab07e787ed5d Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

[MERGED] libosmo-netif[master]: stream.c: Fix endianness handling of PPID and STREAM_ID

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: stream.c: Fix endianness handling of PPID and STREAM_ID .. stream.c: Fix endianness handling of PPID and STREAM_ID In their infinite wisdom, the inventor

libosmo-sccp[master]: (attempted) fix for SCCP CC without user data

2017-04-10 Thread Harald Welte
Patch Set 1: Code-Review-1 even if it fixes the issue, the commit message needs work -- To view, visit https://gerrit.osmocom.org/2292 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If91edb526cbcd792ec5ebcb4518cf848feb69391 Gerrit-PatchS

[MERGED] libosmo-sccp[master]: xUA: Fix endianness handling of PPID and STREAM_ID

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xUA: Fix endianness handling of PPID and STREAM_ID .. xUA: Fix endianness handling of PPID and STREAM_ID In their infinite wisdom, the inventors of SCTP

[PATCH] libosmo-sccp[master]: (attempted) fix for SCCP CC without user data

2017-04-10 Thread Harald Welte
Review at https://gerrit.osmocom.org/2292 (attempted) fix for SCCP CC without user data Change-Id: If91edb526cbcd792ec5ebcb4518cf848feb69391 --- M src/sccp_scoc.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/92/2292/1 dif

[PATCH] libosmo-sccp[master]: xUA: Fix endianness handling of PPID and STREAM_ID

2017-04-10 Thread Harald Welte
Review at https://gerrit.osmocom.org/2291 xUA: Fix endianness handling of PPID and STREAM_ID In their infinite wisdom, the inventors of SCTP designed an API (the sockets API described in RFC6458), where some members are in host byte order (like the stream identifier), while other members are in

[PATCH] libosmo-netif[master]: stream.c: Fix endianness handling of PPID and STREAM_ID

2017-04-10 Thread Harald Welte
Review at https://gerrit.osmocom.org/2290 stream.c: Fix endianness handling of PPID and STREAM_ID In their infinite wisdom, the inventors of SCTP designed an API (the sockets API described in RFC6458), where some members are in host byte order (like the stream identifier), while other members a

[PATCH] openbsc[master]: Save PCU version reported by BTS

2017-04-10 Thread Max
Review at https://gerrit.osmocom.org/2289 Save PCU version reported by BTS When BTS reports PCU disconnect - clear it. Change-Id: Idb32c73036413ee912f633604150ee17b611cfa7 Related: OS#1615 --- M openbsc/src/libbsc/abis_nm.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://ger

[PATCH] osmo-bts[master]: Signal to BSC when PCU disconnects

2017-04-10 Thread Max
Review at https://gerrit.osmocom.org/2288 Signal to BSC when PCU disconnects Change-Id: I41a731bd719aee0bbb98d3236405fb3a7f3ddec0 Related: OS#1615 --- M src/common/pcu_sock.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/2288

[PATCH] openbsc[master]: Use libosmocore for SW Description parsing

2017-04-10 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2166 to look at the new patch set (#7). Use libosmocore for SW Description parsing Requires libosmocore with Ib63b6b5e83b8914864fc7edd789f8958cdc993cd. Change-Id: Ib94db414e94a2a1f234ac6f1c

[PATCH] openbsc[master]: nat: Fix initial buffer size parameter for getline

2017-04-10 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2287 nat: Fix initial buffer size parameter for getline According to man, lineptr must be set to null AND n to 0. Change-Id: I36683884106b97ef697264716de13813c00da9bc --- M openbsc/src/osmo-bsc_nat/bsc_nat_rewrite_trie.c 1 file changed, 1 insertion(+), 1 de

[PATCH] libosmocore[master]: Add SW Description (de)marshalling

2017-04-10 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2165 to look at the new patch set (#13). Add SW Description (de)marshalling * data structure representing 3GPP TS 52.021 ยง9.4.62 SW Description * function to serialize it into

[PATCH] openbsc[master]: Move string - BTS type conversion to shared header

2017-04-10 Thread Max
Review at https://gerrit.osmocom.org/2286 Move string - BTS type conversion to shared header Move value_string definition and corresponding functions to shared header to make it re-usable by OsmoBTS. While at it - rename for consistency and make functions inline. Change-Id: Ida94725a6fce968443

[PATCH] openbsc[master]: nat: Use equal func in bsc_sccp

2017-04-10 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2285 nat: Use equal func in bsc_sccp It is defined in the file and used twice in there, so let's use it for all of them which makes code smaller and more clear. Change-Id: I9fac7cabedff74f8f6293ad8b54420229b80aa71 --- M openbsc/src/osmo-bsc_nat/bsc_sccp.c 1

osmo-trx[master]: buildenv: Split up SSE3 and SSE4.1 code

2017-04-10 Thread Harald Welte
Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2134 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I846e190e92f1258cd412d1b2d79b539e204e04b3 Gerrit-PatchSet: 4 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit

libosmo-sccp[master]: Add osmo-stp executable as new "Osmocom Signaling Transfer P...

2017-04-10 Thread Harald Welte
Patch Set 2: Code-Review-1 the debug logging hack should be removed, and the xua_servers public export needs to be revisited. -- To view, visit https://gerrit.osmocom.org/2281 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32227b8d312

[MERGED] osmo-bts[master]: Handle TXT indication from OsmoPCU

2017-04-10 Thread Max
Max has submitted this change and it was merged. Change subject: Handle TXT indication from OsmoPCU .. Handle TXT indication from OsmoPCU * handle OML message * handle OsmoPCU version message * show stored PCU version in 'show

osmo-bts[master]: Handle TXT indication from OsmoPCU

2017-04-10 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2087 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e73198501487a5b1076bf83390b85538d5af73 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

[PATCH] libosmo-sccp[master]: Add osmo-stp executable as new "Osmocom Signaling Transfer P...

2017-04-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2281 to look at the new patch set (#2). Add osmo-stp executable as new "Osmocom Signaling Transfer Point" osmo-stp is able to define multiple M3UA and/or SUA application servers (AS) as well

[MERGED] libosmo-sccp[master]: Allow clients to specify local IP/port

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Allow clients to specify local IP/port .. Allow clients to specify local IP/port Change-Id: Ief7ce8181442fd0f51c34cf598269ed3a6beacea --- M examples/m3ua

[MERGED] libosmo-sccp[master]: Add osmo_sccp_get_ss7() accessor function

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add osmo_sccp_get_ss7() accessor function .. Add osmo_sccp_get_ss7() accessor function as 'struct osmo_sccp_instance' is opaque to the user application,

[MERGED] libosmo-sccp[master]: osmo_ss7: Fix segfault when routing MTP-TRANSFER.req to ASP ...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Fix segfault when routing MTP-TRANSFER.req to ASP without sctp connection .. osmo_ss7: Fix segfault when routing MTP-TRANSFER.req to ASP withou

[MERGED] libosmo-sccp[master]: m3ua_example: Add talloc reporting

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: m3ua_example: Add talloc reporting .. m3ua_example: Add talloc reporting This can be used to check for memory leaks while running the example code. Chan

[MERGED] libosmo-sccp[master]: sigtran: fix various memory leaks (msgb and xua_msg)

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sigtran: fix various memory leaks (msgb and xua_msg) .. sigtran: fix various memory leaks (msgb and xua_msg) The general rule for 'struct xua_msg' is now

[MERGED] libosmo-sccp[master]: protocol/m3ua.h: Add definition for RKM reg/dereg result codes

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: protocol/m3ua.h: Add definition for RKM reg/dereg result codes .. protocol/m3ua.h: Add definition for RKM reg/dereg result codes Change-Id: I16db7847e205

[MERGED] libosmo-sccp[master]: Add osmo_ss7_find_free_rctx() function to get unused rctx

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add osmo_ss7_find_free_rctx() function to get unused rctx .. Add osmo_ss7_find_free_rctx() function to get unused rctx Change-Id: I0186e25a1b3a325c6b0e3f

[MERGED] libosmo-sccp[master]: xua_cli_conn_cb: Print flags as hex, not decimal.

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_cli_conn_cb: Print flags as hex, not decimal. .. xua_cli_conn_cb: Print flags as hex, not decimal. Change-Id: Idcf861cfdc6c14d7d3bafbf2e243da5db6e2f3

[MERGED] libosmo-sccp[master]: xua_srv_conn_cb(): Print sctp_recvmsg flags (line in xua_cli...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_srv_conn_cb(): Print sctp_recvmsg flags (line in xua_cli_conn_cb()) .. xua_srv_conn_cb(): Print sctp_recvmsg flags (line in xua_cli_conn_cb()) Chang

[MERGED] libosmo-sccp[master]: osmo_ss7: Add support for dynamic ASP registration

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Add support for dynamic ASP registration .. osmo_ss7: Add support for dynamic ASP registration if osmo_xua_server.cfg.accept_dyn_reg is set, th

[MERGED] libosmo-sccp[master]: Add M3UA RKM (routing key management) support, SGW side only

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add M3UA RKM (routing key management) support, SGW side only .. Add M3UA RKM (routing key management) support, SGW side only Change-Id: I9b1cf438a42519c0

[MERGED] libosmo-sccp[master]: M3UA: Properly reject invalid/unknown routing context

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: Properly reject invalid/unknown routing context .. M3UA: Properly reject invalid/unknown routing context This was discovered (and fix validated) us

[MERGED] libosmo-sccp[master]: osmo_sccp_make_addr_pc_ssn(): Set routing indicator

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_sccp_make_addr_pc_ssn(): Set routing indicator .. osmo_sccp_make_addr_pc_ssn(): Set routing indicator When we crate a sccp address with PC+SSN, we s

[MERGED] libosmo-sccp[master]: osmo_ss7: Fix msgb memory leaks in error paths (asp not conn...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Fix msgb memory leaks in error paths (asp not connected) .. osmo_ss7: Fix msgb memory leaks in error paths (asp not connected) Change-Id: I031

[MERGED] libosmo-sccp[master]: M3UA: Reject Message Class XFER / Type != DATA

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: Reject Message Class XFER / Type != DATA .. M3UA: Reject Message Class XFER / Type != DATA This was discovered (and fix validated) using m3ua-sgp-m

[MERGED] libosmo-sccp[master]: M3UA: Send "Unexpected Message" when receiving ASP_UP-ACK in...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: Send "Unexpected Message" when receiving ASP_UP-ACK in ACTIVE .. M3UA: Send "Unexpected Message" when receiving ASP_UP-ACK in ACTIVE Change-Id: Ib

[MERGED] libosmo-sccp[master]: M3UA: Send opportunistic ASPACT-ACK to ASPACT-REQ in ACTIVE ...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: Send opportunistic ASPACT-ACK to ASPACT-REQ in ACTIVE state .. M3UA: Send opportunistic ASPACT-ACK to ASPACT-REQ in ACTIVE state This was discover

[MERGED] libosmo-sccp[master]: xua: report N-ERROR and N-NOTIFY primitives to layer manager

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua: report N-ERROR and N-NOTIFY primitives to layer manager .. xua: report N-ERROR and N-NOTIFY primitives to layer manager Change-Id: I5c2060f0397d2bf5

[MERGED] libosmo-sccp[master]: m3ua: Remove inbound routing context before routing

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: m3ua: Remove inbound routing context before routing .. m3ua: Remove inbound routing context before routing After verifying the routing context of an inco

[MERGED] libosmo-sccp[master]: osmo_ss7: default point-code format for parsing/printing wit...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: default point-code format for parsing/printing without ss7_instance .. osmo_ss7: default point-code format for parsing/printing without ss7_ins

[MERGED] libosmo-sccp[master]: move layer_manager from xua_asp_fsm priv to osmo_ss7_asp

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: move layer_manager from xua_asp_fsm priv to osmo_ss7_asp .. move layer_manager from xua_asp_fsm priv to osmo_ss7_asp ... this way it is publicly accessib

[MERGED] libosmo-sccp[master]: m3ua: cosmetic clanup. We can simply return the M3UA errror...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: m3ua: cosmetic clanup. We can simply return the M3UA errror code .. m3ua: cosmetic clanup. We can simply return the M3UA errror code Change-Id: I6ed04

[MERGED] libosmo-sccp[master]: xua_msg: Add xua_from_nested() helper function for nested IEs

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_msg: Add xua_from_nested() helper function for nested IEs .. xua_msg: Add xua_from_nested() helper function for nested IEs ... and add a test case to

[MERGED] libosmo-sccp[master]: M3UA: Respond with "Unexpected Message" if ASPTM is received...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: Respond with "Unexpected Message" if ASPTM is received too soon .. M3UA: Respond with "Unexpected Message" if ASPTM is received too soon This was

[MERGED] libosmo-sccp[master]: M3UA: Make sure to reject unsupported traffic mode types

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: Make sure to reject unsupported traffic mode types .. M3UA: Make sure to reject unsupported traffic mode types This was discovered (and fix validat

[MERGED] libosmo-sccp[master]: send M-SCTP_ESTABLISH.ind to Layer Manager

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: send M-SCTP_ESTABLISH.ind to Layer Manager .. send M-SCTP_ESTABLISH.ind to Layer Manager Change-Id: I2904f8ebd97036690ba8a9525b31354c0252123b --- M src/o

[MERGED] libosmo-sccp[master]: M3UA: Ensure XFER messages are not sent on stream 0

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: Ensure XFER messages are not sent on stream 0 .. M3UA: Ensure XFER messages are not sent on stream 0 According to the RFC, Stream ID 0 MUST not be

[MERGED] libosmo-sccp[master]: M3UA: Handle opportunistic ASPIA in INACTIVE state

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: Handle opportunistic ASPIA in INACTIVE state .. M3UA: Handle opportunistic ASPIA in INACTIVE state This was discovered (and fix validated) using m3

[MERGED] libosmo-sccp[master]: xua: move notfiy parameters from xua_internal to sigtran_sap...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua: move notfiy parameters from xua_internal to sigtran_sap and rename them .. xua: move notfiy parameters from xua_internal to sigtran_sap and rename t

[MERGED] libosmo-sccp[master]: osmo_ss7: make OVERRIDE the default traffic mode type (0)

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: make OVERRIDE the default traffic mode type (0) .. osmo_ss7: make OVERRIDE the default traffic mode type (0) Change-Id: Ie83fa0a403dcfc582d6bb5

[MERGED] libosmo-sccp[master]: xua_asp_fsm: Always return BEAT-ACK for BEAT, including BEAT...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_asp_fsm: Always return BEAT-ACK for BEAT, including BEAT DATA IE .. xua_asp_fsm: Always return BEAT-ACK for BEAT, including BEAT DATA IE The RFCs sa

[MERGED] libosmo-sccp[master]: M3UA: RKM DEREG-REQ should contain routing context, not rout...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: M3UA: RKM DEREG-REQ should contain routing context, not routing key .. M3UA: RKM DEREG-REQ should contain routing context, not routing key The mandatory

[MERGED] libosmo-sccp[master]: xua_as_fsm: Include routing context (if configured) in NTFY ...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_as_fsm: Include routing context (if configured) in NTFY message .. xua_as_fsm: Include routing context (if configured) in NTFY message Change-Id: I1

[MERGED] libosmo-sccp[master]: m3ua: Include RC IE of AS in Tx; validate RC IE on Rx

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: m3ua: Include RC IE of AS in Tx; validate RC IE on Rx .. m3ua: Include RC IE of AS in Tx; validate RC IE on Rx Change-Id: I7db36a23185f82d8d68e318afe89ec

[MERGED] libosmo-sccp[master]: sccp: add osmo_sccp_user_{get, set}_priv() API function

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sccp: add osmo_sccp_user_{get,set}_priv() API function .. sccp: add osmo_sccp_user_{get,set}_priv() API function As 'struct osmo_sccp_user' is private, w

[MERGED] libosmo-sccp[master]: add converter functions between osmo_ss7 and m3ua traffic mo...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add converter functions between osmo_ss7 and m3ua traffic mode types .. add converter functions between osmo_ss7 and m3ua traffic mode types Change-Id:

[MERGED] libosmo-sccp[master]: xua: Remove library-internal DXUA log subsystem

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua: Remove library-internal DXUA log subsystem .. xua: Remove library-internal DXUA log subsystem We don't really need those thre log messages, and we c

[MERGED] libosmo-sccp[master]: Add example program how to use M3UA+SCCP client and server

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add example program how to use M3UA+SCCP client and server .. Add example program how to use M3UA+SCCP client and server This is an example tool that can

[MERGED] libosmo-sccp[master]: SUA: Port to new osmo_ss7 and SCCP code

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: SUA: Port to new osmo_ss7 and SCCP code .. SUA: Port to new osmo_ss7 and SCCP code If we use the infrastructure provided by osmo_ss7 on the lower layer a

[MERGED] libosmo-sccp[master]: sua: Extend address parsing with GT, RI and IPv4 support

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sua: Extend address parsing with GT, RI and IPv4 support .. sua: Extend address parsing with GT, RI and IPv4 support Change-Id: I186df77cbdbedfe1a60b855b

[MERGED] libosmo-sccp[master]: Add tests for xUA code + SCCP/SUA transcoding

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add tests for xUA code + SCCP/SUA transcoding .. Add tests for xUA code + SCCP/SUA transcoding Change-Id: I7ce038d72dca18fb83d5a12519c9a48267e52ab8 --- M

[MERGED] libosmo-sccp[master]: sua.c: Replace sua_msgb_alloc() with new sccp_msgb_alloc()

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sua.c: Replace sua_msgb_alloc() with new sccp_msgb_alloc() .. sua.c: Replace sua_msgb_alloc() with new sccp_msgb_alloc() Change-Id: I7067a85dcc5dda66f4b1

[MERGED] libosmo-sccp[master]: Add SCCP <-> SUA message transcoding routines

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add SCCP <-> SUA message transcoding routines .. Add SCCP <-> SUA message transcoding routines Change-Id: I8151a9b08a0b0ca97b9c73105ad4548512ce3be8 --- M

[MERGED] libosmo-sccp[master]: Add new SCCP implementation

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add new SCCP implementation .. Add new SCCP implementation This is an implementation of SCCP as specified in ITO-T Q.71x, particularly the SCRC (routing)

[MERGED] libosmo-sccp[master]: remove tests/sigtran: it's not a test case

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: remove tests/sigtran: it's not a test case .. remove tests/sigtran: it's not a test case in tests/* we have unit tests that are run as part of the autote

[MERGED] libosmo-sccp[master]: sccp_sap license header was missing

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sccp_sap license header was missing .. sccp_sap license header was missing Change-Id: I442634ca74d9c4cd386726a9d6b933a12f45afc5 --- M src/sccp_sap.c 1 fi

[PATCH] libosmo-netif[master]: api doc: Call the variable by the right ("crx") name

2017-04-10 Thread Holger Freyther
Review at https://gerrit.osmocom.org/2284 api doc: Call the variable by the right ("crx") name While "ctx" would be consistent with the rest of libosmocore and other places, the "crx" occurs so frequently I don't think it is a typo. So change the API docs to "crx" and leave the code as is. Cha

libosmo-sccp[master]: sccp_scoc: Move osmo_prim_event_map to libosmocore

2017-04-10 Thread Harald Welte
Patch Set 4: -Code-Review -- To view, visit https://gerrit.osmocom.org/2255 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f22ae2e8d786bfe4bbb84e8eb9f8ae4d93d899 Gerrit-PatchSet: 4 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ger

[ABANDON] libosmo-sccp[master]: sccp_scoc: Move osmo_prim_event_map to libosmocore

2017-04-10 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: sccp_scoc: Move osmo_prim_event_map to libosmocore .. Abandoned as the libosmcore change has already been merged to master, this change had to be merged into the main "ne

libosmo-sccp[master]: sua: Extend address parsing with GT, RI and IPv4 support

2017-04-10 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2211 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I186df77cbdbedfe1a60b855be3626b6766f4681c Gerrit-PatchSet: 6 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: Add new SCCP implementation

2017-04-10 Thread Harald Welte
Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2215 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916e895d9a4914b05483fe12ab5251f206d10dee Gerrit-PatchSet: 7 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

[PATCH] libosmo-sccp[master]: sua: Extend address parsing with GT, RI and IPv4 support

2017-04-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2211 to look at the new patch set (#6). sua: Extend address parsing with GT, RI and IPv4 support Change-Id: I186df77cbdbedfe1a60b855be3626b6766f4681c --- M src/sua.c 1 file changed, 104 inse

[PATCH] libosmo-sccp[master]: Add new SCCP implementation

2017-04-10 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2215 to look at the new patch set (#7). Add new SCCP implementation This is an implementation of SCCP as specified in ITO-T Q.71x, particularly the SCRC (routing), SCLC (Connectionless) and

[MERGED] libosmo-sccp[master]: xua_msg: Add MTP routing label to 'struct xua_msg'

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_msg: Add MTP routing label to 'struct xua_msg' .. xua_msg: Add MTP routing label to 'struct xua_msg' Higher-layer protocols (particularly SCCP) requi

[MERGED] libosmo-sccp[master]: xua_msg: Add support for encoding IPv4 addr in osmo_sccp_addr

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_msg: Add support for encoding IPv4 addr in osmo_sccp_addr .. xua_msg: Add support for encoding IPv4 addr in osmo_sccp_addr Change-Id: I956f069ce4cea7

[MERGED] libosmo-sccp[master]: Add mtp_sap.h file with definitions for MTP-USER SAP

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add mtp_sap.h file with definitions for MTP-USER SAP .. Add mtp_sap.h file with definitions for MTP-USER SAP The ITU-T Q.70x series describe a MTP-USER S

[MERGED] libosmo-sccp[master]: xua_msg: Add support for encoding Global Title in osmo_sccp_...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_msg: Add support for encoding Global Title in osmo_sccp_addr .. xua_msg: Add support for encoding Global Title in osmo_sccp_addr Change-Id: I4668fd0f

[MERGED] libosmo-sccp[master]: sua: Make use of xua_msg_dialect

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sua: Make use of xua_msg_dialect .. sua: Make use of xua_msg_dialect We fill in the data structures of a xua_msg_dialect and make use of it for generic m

[MERGED] libosmo-sccp[master]: xua_msg: Add support for msg_event_maps

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_msg: Add support for msg_event_maps .. xua_msg: Add support for msg_event_maps msg_event_maps facilitate the mapping from a xUA message (class + type

[MERGED] libosmo-sccp[master]: License headers: Should always have been GPLv2-or-later

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: License headers: Should always have been GPLv2-or-later .. License headers: Should always have been GPLv2-or-later libosmo-sigtran is GPLv2-or-later, the

[MERGED] libosmo-sccp[master]: xua_msg: Add concept of xua_msg_class and xua_msg_dialect

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_msg: Add concept of xua_msg_class and xua_msg_dialect .. xua_msg: Add concept of xua_msg_class and xua_msg_dialect A xua_msg_class repreents one xUA

[MERGED] libosmo-sccp[master]: xua_msg: Add xua_msg_free_tag() and xua_msg_copy_part()

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua_msg: Add xua_msg_free_tag() and xua_msg_copy_part() .. xua_msg: Add xua_msg_free_tag() and xua_msg_copy_part() ... also, mark input to xua_msg_find_t

[MERGED] libosmo-sccp[master]: sua.h: Add #define for the varius SUA protocol errors

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sua.h: Add #define for the varius SUA protocol errors .. sua.h: Add #define for the varius SUA protocol errors again using m3ua.h definitions as base whe

[MERGED] libosmo-sccp[master]: sua.h: Define more IEIs; base definitions on m3ua.h

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sua.h: Define more IEIs; base definitions on m3ua.h .. sua.h: Define more IEIs; base definitions on m3ua.h A lot of IEIs are identical between the differ

[MERGED] libosmo-sccp[master]: sccp_sap: Add routing indication (RI) to osmo_sccp_addr

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sccp_sap: Add routing indication (RI) to osmo_sccp_addr .. sccp_sap: Add routing indication (RI) to osmo_sccp_addr Change-Id: I4dd23150f4c588b6430c22fc0c

[MERGED] libosmo-sccp[master]: gitignore: add 'tags' files as created by 'make ctags'

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gitignore: add 'tags' files as created by 'make ctags' .. gitignore: add 'tags' files as created by 'make ctags' Change-Id: I9e4ec0e07b996092a1f4e6a01911

[MERGED] libosmo-sccp[master]: sccp_sap: Use zero-terminated string for GT digits in osmo_s...

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sccp_sap: Use zero-terminated string for GT digits in osmo_sccp_addr .. sccp_sap: Use zero-terminated string for GT digits in osmo_sccp_addr This is mor

[MERGED] libosmo-sccp[master]: gitignore: use one wildcard line for all test executables

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gitignore: use one wildcard line for all test executables .. gitignore: use one wildcard line for all test executables Change-Id: I53ce43fa8e09646dec56c6

[MERGED] libosmo-sccp[master]: sccp_sap: Add support for N-NOTICE.indication

2017-04-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sccp_sap: Add support for N-NOTICE.indication .. sccp_sap: Add support for N-NOTICE.indication Change-Id: I6656889b4333e9909cf1c60c24dfc754281547b4 --- M

libosmo-netif[master]: stream/datagram: Ensure reliable close/destroy

2017-04-10 Thread Holger Freyther
Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/2253/3/src/datagram.c File src/datagram.c: PS3, Line 196: osmo_sock_init2 > Thanks for your review! Howeveer, if it was >= 0 a few lines above, we wou To be honest I have to see how it is used. So just by reviewing this file I see.. osm

libosmo-netif[master]: stream/datagram: Ensure reliable close/destroy

2017-04-10 Thread Harald Welte
Patch Set 3: > > once again I'm at a loss. This patch passes "make check" without > > any problem on my FreeBSD 10 VM. > > Apparently something (the VM? FreeBSD?) stalled for 10s leading to > the sigalarm handler being called. I re-triggered the build.. and > it didn't run into a timeout.

  1   2   >