[MERGED] osmo-gsm-tester[master]: resources.conf: take out 10.42.42.1

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: resources.conf: take out 10.42.42.1 .. resources.conf: take out 10.42.42.1 This seems to be the default address used to communicate via SSH with the

[PATCH] osmo-gsm-tester[master]: resources.conf: take out 10.42.42.1

2017-05-28 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2776 resources.conf: take out 10.42.42.1 This seems to be the default address used to communicate via SSH with the sysmoBTS. Whichever process ends up getting this address sees all of the SSH in its pcap (for the AoIP build it tends to be OsmoHLR). We

[MERGED] osmo-gsm-tester[master]: fix: refresh dbus object when interfaces have changed

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix: refresh dbus object when interfaces have changed .. fix: refresh dbus object when interfaces have changed This solves the KeyError problems when

[MERGED] osmo-gsm-tester[master]: fix osmo-bts-trx: missing patch to use new event_loop

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix osmo-bts-trx: missing patch to use new event_loop .. fix osmo-bts-trx: missing patch to use new event_loop Change-Id:

osmo-gsm-tester[master]: fix osmo-bts-trx: missing patch to use new event_loop

2017-05-28 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 pushing through because this is obvious. -- To view, visit https://gerrit.osmocom.org/2774 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I640258d8451aff1633cba7390df5430da50d0b0b Gerrit-PatchSet: 1

[MERGED] osmo-gsm-tester[master]: fix multi-suite runs: implement modem cleanup

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix multi-suite runs: implement modem cleanup .. fix multi-suite runs: implement modem cleanup After a suite was done, the modem object would linger.

osmo-gsm-tester[master]: fix multi-suite runs: implement modem cleanup

2017-05-28 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 pushing through because this is needed to fix multiple suite runs, to get a proper test run with current master. -- To view, visit https://gerrit.osmocom.org/2772 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] osmo-gsm-tester[master]: fix log: print suite-run separator in proper place

2017-05-28 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2773 fix log: print suite-run separator in proper place error was introduced by 0ffb41440661631fa1d520c152be4cf8ebd4c46b 'Add JUnit XML reports; refactor test reporting' Change-Id: I9acf1a840277979a19a2019c69e4562ff7fe2ca0 --- M src/osmo-gsm-tester.py M

[PATCH] osmo-gsm-tester[master]: fix osmo-bts-trx: missing patch to use new event_loop

2017-05-28 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2774 fix osmo-bts-trx: missing patch to use new event_loop Change-Id: I640258d8451aff1633cba7390df5430da50d0b0b --- M src/osmo_gsm_tester/bts_osmotrx.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull

[MERGED] osmo-gsm-tester[master]: fix: free resources when a suite run is done

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix: free resources when a suite run is done .. fix: free resources when a suite run is done Add missing code to free resources, not upon program exit,

[MERGED] osmo-gsm-tester[master]: fix: None error on unavailable resources

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix: None error on unavailable resources .. fix: None error on unavailable resources If not a single resource of a wanted item was left, we ran into a

osmo-gsm-tester[master]: fix: None error on unavailable resources

2017-05-28 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 pushing through because obvious -- To view, visit https://gerrit.osmocom.org/2770 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1849a74cb227964e7c3ac06852582baa2333697 Gerrit-PatchSet: 1 Gerrit-Project:

[PATCH] osmo-gsm-tester[master]: fix: free resources when a suite run is done

2017-05-28 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2771 fix: free resources when a suite run is done Add missing code to free resources, not upon program exit, but when a suite is done. This allows running more than one suite in a row. Change-Id: Ic017a1cf07052f5e48812c8553fba6f972d280f0 Related: OS#2301

osmo-ci[master]: Use stow for dependency management

2017-05-28 Thread Harald Welte
Patch Set 1: Code-Review-1 What I'm missing here is some more background. Call me old, but I didn't even know what stow was prior to doing a search after seeing this commit. Unless I'm the only one on the planet not knowing stow, it deserves some description in the commitlog, with a pointer

libosmocore[master]: socket: Add osmo_sock_init2_ofd() function

2017-05-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2744 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c655a4af64fb80497a5aaa811cce8005dba9cd9 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: socket: Add osmo_sock_init2_ofd() function

2017-05-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: socket: Add osmo_sock_init2_ofd() function .. socket: Add osmo_sock_init2_ofd() function Will be used by osmo-bts-trx Change-Id:

osmo-bts[master]: trx: Save osmotrx base-port vty properties

2017-05-28 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2746 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0898a8c4eb3899fc1c0f6b17da33b8c7851b90d6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-trx[master]: sigProcLib: Fix number of tail bits in random Normal Bursts ...

2017-05-28 Thread Harald Welte
Patch Set 1: nothing in the commit message indicates that this is about gneration of a random burst only. It reads almost like it adresses normal(non-random) bursts? -- To view, visit https://gerrit.osmocom.org/2762 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-trx[master]: PRBS: a Pseudo-random binary sequence (PRBS) generator class.

2017-05-28 Thread Harald Welte
Patch Set 1: I would really prefer to haee generic code like this implemented as part of libosmocore. There is nothing "TRX specific" about it, and PRBS sequences are used virtually anywhere for testing, whether on wired or wireless interfaces in telecoms. -- To view, visit

osmo-trx[master]: BitVector: Remove Generator class.

2017-05-28 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2763 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1509e785c1187ebdafe5b2518bd298fbbd1cd036 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[MERGED] openbsc[master]: bsc_vty.c: Further simplify vty_get_ts()

2017-05-28 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_vty.c: Further simplify vty_get_ts() .. bsc_vty.c: Further simplify vty_get_ts() We can also move the string-to-numeric conversion inside

openbsc[master]: bsc_vty.c: Further simplify vty_get_ts()

2017-05-28 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2766 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a74ed06e90e39d39f53fff39bb96df172728c0e Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: bsc_vty.c: Add command for manual [de]actiovation of logical...

2017-05-28 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2759 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44fc3904678eb48bd3ab1a3da8c0c265fa082e0d Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

[PATCH] osmo-gsm-tester[master]: contrib/jenkins: more aggressively exclude docs

2017-05-28 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2768 contrib/jenkins: more aggressively exclude docs Completely discard prefix/share/doc in builds. There was still ~1.2Mb from libosmo-netif around. Exception: osmo-hlr installs a bootstrap sql in prefix/share/doc/osmo-hlr, so leave that script as-is.

[MERGED] osmo-gsm-tester[master]: fix osmo-bts-trx: add config: 'osmotrx tx-attenuation oml'

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix osmo-bts-trx: add config: 'osmotrx tx-attenuation oml' .. fix osmo-bts-trx: add config: 'osmotrx tx-attenuation oml' Before this, the network

osmo-gsm-tester[master]: fix osmo-bts-trx: add config: 'osmotrx tx-attenuation oml'

2017-05-28 Thread Neels Hofmeyr
Patch Set 3: Code-Review+2 pushing through, fairly trivial and tested -- To view, visit https://gerrit.osmocom.org/2730 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c026b5691033127eef766d82566c39cc070e14a Gerrit-PatchSet: 3

[PATCH] osmo-gsm-tester[master]: default suites: enable osmo-bts-trx (Ettus B210)

2017-05-28 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2735 to look at the new patch set (#3). default suites: enable osmo-bts-trx (Ettus B210) Change-Id: I5dce732ed21f34988aa014add4d2d611dd0c44fc --- M example/default-suites.conf 1 file

osmo-gsm-tester[master]: default suites: enable osmo-bts-trx

2017-05-28 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2735/1/example/default-suites.conf File example/default-suites.conf: Line 2: - sms:trx > Do we have already a osmo-bts-trx in place for the tests? I though I was go Your task is about the sysmocell, which is also using osmo-bts-trx. This

[MERGED] osmo-gsm-tester[master]: contrib/jenkins: cosmetic: add some spacing in log output

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: contrib/jenkins: cosmetic: add some spacing in log output .. contrib/jenkins: cosmetic: add some spacing in log output Change-Id:

osmo-gsm-tester[master]: contrib/jenkins: cosmetic: add some spacing in log output

2017-05-28 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 pushing through... let me know later in case of complaints -- To view, visit https://gerrit.osmocom.org/2729 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7238d8610f2be3e074f366861782e010d814e94

osmo-gsm-manuals[master]: OsmoGSMTester: add rtprio conf, tweak core dump conf

2017-05-28 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2722 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I284c3bfb15e914f1f6ab00f15874fe5ea6190c5c Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

[MERGED] osmo-gsm-manuals[master]: apply rename of resource nitb_iface to ip_address

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: apply rename of resource nitb_iface to ip_address .. apply rename of resource nitb_iface to ip_address See osmo-gsm-tester change-id

[MERGED] osmo-gsm-tester[master]: debug: config logging before templates: use pprint and an al...

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: debug: config logging before templates: use pprint and an all-caps label .. debug: config logging before templates: use pprint and an all-caps label

[MERGED] osmo-gsm-tester[master]: config: nitb template: move ip_address to nitb.ip_address

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: config: nitb template: move ip_address to nitb.ip_address .. config: nitb template: move ip_address to nitb.ip_address It's the NITB's address, so it

[MERGED] osmo-gsm-tester[master]: nitb config: set: logging color 1, category 1

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: nitb config: set: logging color 1, category 1 .. nitb config: set: logging color 1, category 1 Change-Id: Icd9022f5732caac65d16fc49f2ed7833199523de ---

[MERGED] osmo-gsm-tester[master]: rename resource nitb_iface to ip_address

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: rename resource nitb_iface to ip_address .. rename resource nitb_iface to ip_address I would like to use the IP addresses also for OsmoBSC processes,

[MERGED] osmo-gsm-tester[master]: contrib: add jenkins-build-osmo-msc.sh

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: contrib: add jenkins-build-osmo-msc.sh .. contrib: add jenkins-build-osmo-msc.sh Change-Id: I2d5520cab0ad09f23e3ba49404385af80acf56f6 --- A

[MERGED] osmo-gsm-tester[master]: resource error logging that is easier to understand

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: resource error logging that is easier to understand .. resource error logging that is easier to understand Log what a suite requested, what it has

[MERGED] osmo-gsm-tester[master]: MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP .. MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP Change-Id:

[MERGED] osmo-gsm-tester[master]: resources.conf: more IP addresses

2017-05-28 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: resources.conf: more IP addresses .. resources.conf: more IP addresses The upcoming BSC+MSC+HLR+MGCPGW style will need four IP addresses. I found six

osmo-gsm-tester[master]: MSC+BSC: add test api to run OsmoMSC and OsmoBSC with AoIP

2017-05-28 Thread Neels Hofmeyr
Patch Set 5: Code-Review+2 re-adding earlier +2 lost from minor rebase conflict resolution -- To view, visit https://gerrit.osmocom.org/2719 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5842e8f1cba8e8e6bedfc08540efcafe207159cb

osmo-gsm-tester[master]: resource error logging that is easier to understand

2017-05-28 Thread Neels Hofmeyr
Patch Set 3: Code-Review+2 pushing this on, if anything is left open I shall follow up with a patch -- To view, visit https://gerrit.osmocom.org/2705 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-gsm-tester[master]: bts: add remote_addr() function

2017-05-28 Thread Neels Hofmeyr
Patch Set 5: Code-Review+2 For some odd reason gerrit still show's Pau's -1 here even though he gave +2 later on. -- To view, visit https://gerrit.osmocom.org/2715 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] osmo-gsm-tester[master]: resource error logging that is easier to understand

2017-05-28 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2705 to look at the new patch set (#3). resource error logging that is easier to understand Log what a suite requested, what it has reserved and the complete resource state. Change-Id:

[PATCH] osmo-gsm-tester[master]: bts: add remote_addr() function

2017-05-28 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2715 to look at the new patch set (#5). bts: add remote_addr() function To start an MGCPGW, we so far need the BTS address in advance (should get fixed at some point, but

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.04/i586

2017-05-28 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/i586 Package network:osmocom:nightly/libosmocore failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of

osmo-trx[master]: WIP:sigProcLib: Reduce burst detection window for NB.

2017-05-28 Thread Alexander Chemeris
Patch Set 1: Tom, could you explain why did you set search window to -/+6 symbols? My experiments showed that at least `tail` should be set to 3 in order for `max_toa` to actually represent maximum TOA. And same for `head` - from my experiments I think it should be 3. -- To view, visit

[PATCH] osmo-trx[master]: WIP:sigProcLib: Reduce burst detection window for NB.

2017-05-28 Thread Alexander Chemeris
Review at https://gerrit.osmocom.org/2765 WIP:sigProcLib: Reduce burst detection window for NB. Otherwise we detect bursts with search window far beyond specified. Change-Id: If3cb40d2311504a13c03e1fbccad663ac201d9a4 --- M Transceiver52M/sigProcLib.cpp 1 file changed, 2 insertions(+), 2

[PATCH] osmo-trx[master]: PRBS: a Pseudo-random binary sequence (PRBS) generator class.

2017-05-28 Thread Alexander Chemeris
Review at https://gerrit.osmocom.org/2764 PRBS: a Pseudo-random binary sequence (PRBS) generator class. Implemeted with a Galois LFSR for speed and flexibility compared to Fibonacci version. Aliases for three popular PRBS' are added for convenience - PRBS9, PRBS15 and PRBS64. Note that we

[PATCH] osmo-trx[master]: BitVector: Remove Generator class.

2017-05-28 Thread Alexander Chemeris
Review at https://gerrit.osmocom.org/2763 BitVector: Remove Generator class. It is not used in osmo-trx, because we're not doing FEC or CRC checks. Change-Id: I1509e785c1187ebdafe5b2518bd298fbbd1cd036 --- M CommonLibs/BitVector.cpp M CommonLibs/BitVector.h 2 files changed, 0 insertions(+), 86

[PATCH] libosmocore[master]: core/conv: do not mix up AVX and SSE code

2017-05-28 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2760 to look at the new patch set (#3). core/conv: do not mix up AVX and SSE code According to GCC's wiki: If you specify command-line switches such as -msse, the compiler could use the

[PATCH] libosmocore[master]: core/conv: do not mix up AVX and SSE code

2017-05-28 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2760 to look at the new patch set (#2). core/conv: do not mix up AVX and SSE code According to GCC's wiki: If you specify command-line switches such as -msse, the compiler could use the

libosmocore[master]: core/conv: do not mix up AVX and SSE code

2017-05-28 Thread Vadim Yanitskiy
Patch Set 1: > Vadim, > > Is sse+avx code just a copy of the sse code? In this case we should > move it to an include file and then include into .c files to avoid > code duplication. Both files are almost the same, excluding the SSE_BROADCAST definition. Great idea with creating an include

libosmocore[master]: core/conv: do not mix up AVX and SSE code

2017-05-28 Thread Alexander Chemeris
Patch Set 1: Vadim, Is sse+avx code just a copy of the sse code? In this case we should move it to an include file and then include into .c files to avoid code duplication. -- To view, visit https://gerrit.osmocom.org/2760 To unsubscribe, visit https://gerrit.osmocom.org/settings

openbsc[master]: Enable optional static builds

2017-05-28 Thread Alexander Chemeris
Patch Set 1: Max, thank you for working on this! Are you able to build tests when static build is enabled? Also, do you know have patches to enable static build for all library dependencies? Btw, would it be possible to enable static build in Jenkins after this is merged to make sure we

[PATCH] libosmocore[master]: core/conv: do not mix up AVX and SSE code

2017-05-28 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/2760 core/conv: do not mix up AVX and SSE code According to GCC's wiki: If you specify command-line switches such as -msse, the compiler could use the extended instruction sets even if the built-ins are not used explicitly in the program. For this reason,