Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2788/1/src/gsm/Makefile.am
File src/gsm/Makefile.am:
Line 26:gsm0411_utils.c gsm0411_smc.c gsm0411_smr.c
gsm0414.c \
That file seems missing ;)
--
To view, visit https://gerrit.osmocom.org/2788
To unsubscribe,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2775
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b17fce0b3b05594fd9038b54e5b65f5127bd0a4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: default suites: enable osmo-bts-trx (Ettus B210)
..
default suites: enable osmo-bts-trx (Ettus B210)
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: core/conv: do not mix up AVX and SSE code
..
core/conv: do not mix up AVX and SSE code
According to GCC's wiki:
If you specify command-line switches
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2781
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ecd8f9e73c05236f2cdc186f58b3d0ba552283f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 5: Verified+1
test run on osmo-gsm-tester was successful with this patch applied
--
To view, visit https://gerrit.osmocom.org/2760
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I042cc76258df7e4c6c90a73af3d0a6e75999b2b0
Patch Set 5: Code-Review+2
Since 34e228a9bcf3ac37287bb5e684ace46818740f3b ("core/conv: add x86 SSE support
for Viterbi decoder") osmo-bts-trx threw a SIGILL on the osmo-gsm-tester main
unit. With this patch applied, the problem is fixed.
--
To view, visit https://gerrit.osmocom.org/2760
To
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/2765/1//COMMIT_MSG
Commit Message:
PS1, Line 7: W
I this is still WIP, I am not sure it should be submitted to gerit? If it's not
WIP, it should not say so.
Line 9: Otherwise we detect bursts with search window far beyond specified.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2785
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f91be97c8bf81a87681814bf81d3a5a9950e54
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: OML: fix Coverity-reported issues
..
OML: fix Coverity-reported issues
* CID 169803: Null pointer dereferences
* CID 169802: Incorrect expression
Harald Welte has submitted this change and it was merged.
Change subject: Add version to phy_instance
..
Add version to phy_instance
Change-Id: I5b2352b8d15e9b0d8616fcd526b4902d247e4693
Related: OS#1614
---
M
Patch Set 1: Code-Review-1
(4 comments)
https://gerrit.osmocom.org/#/c/2786/1/src/common/oml.c
File src/common/oml.c:
Line 173: static inline struct msgb *add_trx_attr(struct gsm_bts_trx *trx)
naming. The function is called add_something. But In reality it allocates a
message and returns it?
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/2783
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b61131b9930afd03357c0b66947ee856d58cc46
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2784
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b2352b8d15e9b0d8616fcd526b4902d247e4693
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/2783/1/openbsc/src/libbsc/abis_nm.c
File openbsc/src/libbsc/abis_nm.c:
Line 495: sw_len = ari_len - (unreported + 2);
This code is way too complex and hand-crafted for my taste, sorry. We have
magic offsets that get added in some
Harald Welte has submitted this change and it was merged.
Change subject: Add chapter on Cell Broadcast Support in Osmocom (to BSC+NITB
manual)
..
Add chapter on Cell Broadcast Support in Osmocom (to BSC+NITB manual)
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2790
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c621def499dc0564d31eb9440e22e79948a5466
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2793
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0eee4f514fb8fd81c052bb44a4facba898d6afb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: SMS tokens: add modem name to SMS message
..
cosmetic: SMS tokens: add modem name to SMS message
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2768
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f3f3cfed0f56099bdff93b11a0009c1caef67c8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: l1_if: Add inline functions to check dsp/fgpa version at runtime
..
l1_if: Add inline functions to check dsp/fgpa version at runtime
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2791
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ba0301b55cc283aa6a441899f84357e28a97321
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2775/1/suites/sms/mo_mt_sms.py
File suites/sms/mo_mt_sms.py:
Line 14
> Why is this not needed anymore with this patch?
It was never needed, only a show case to illustrate what kind of things I'd
like to be able to do in test scripts.
Neels Hofmeyr has submitted this change and it was merged.
Change subject: log.Origin: return self on __enter__
..
log.Origin: return self on __enter__
Allows using 'with some_origin() as foo:' constructs.
Not used actively,
Review at https://gerrit.osmocom.org/2793
sysmobts: Re-order the bit-endianness of every HR codec parameter
The so-called "RTP mode" of the DSP contains a bug on all firmware
versions < 5.3.3 which causes the bit-order within each of the
non-aligned codec parameters to be wrong. Introduce a
Review at https://gerrit.osmocom.org/2792
l1_if: Add inline functions to check dsp/fgpa version at runtime
Change-Id: Iddae9c8de33aca6663dca77908fa4852ad704ce9
---
M src/osmo-bts-sysmo/l1_if.h
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts
Review at https://gerrit.osmocom.org/2791
vty: Remove command for manual channel activation/deactivation
OsmoBTS won't run without being connected to a BSC. The BTS wouldn't
start to transmit if the BSC doesn't properly initialize it. So if we
want to activate some channels manually for
Harald Welte has submitted this change and it was merged.
Change subject: Consistently check for minimum attribute/TLV length in RSL and
OML
..
Consistently check for minimum attribute/TLV length in RSL and OML
Make more use
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: Remove duplicate parsing of NM_ATT_CONN_FAIL_CRIT
..
osmo-bts-trx: Remove duplicate parsing of NM_ATT_CONN_FAIL_CRIT
For some reason,
Harald Welte has submitted this change and it was merged.
Change subject: l1sap.c: Add spec reference to link timeout implementation
..
l1sap.c: Add spec reference to link timeout implementation
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2752
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c4eee65711c49bc8ba4675221b1d5fd16198e9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/x86_64
Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2762
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377029556c8b681b3ba3b635bf19572b34546ea
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2412
to look at the new patch set (#12).
measurement: fix measurement computation
Timing advance is currently not taken into account when computing
the measurement results, this commit
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2389
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic871eed6dcbc7d10aca6cd11dbc803b3e6da449f
Gerrit-PatchSet: 9
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2790
Add chapter on Cell Broadcast Support in Osmocom (to BSC+NITB manual)
Change-Id: I2c621def499dc0564d31eb9440e22e79948a5466
---
M OsmoBSC/osmobsc-usermanual.adoc
M OsmoNITB/osmonitb-usermanual.adoc
A common/chapters/cell-broadcast.adoc
A
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2389
to look at the new patch set (#9).
measurement: Improve log output
The debug log does not print much information about the measured
rxlev and rxqual values. This commit
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-sysmo: Include frame number in MEAS IND
..
osmo-bts-sysmo: Include frame number in MEAS IND
l1_if.c does not generate struct osmo_phsap_prim
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2789
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bab40c30d727395eb3096026810917407419cd7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2789
osmo-bts-sysmo: Include frame number in MEAS IND
l1_if.c does not generate struct osmo_phsap_prim l1sap properly.
The (logical) frame number is not included in this struct. This
renders the logic that processes the reported measurements non
functional,
Patch Set 1:
Harald - I agree that in general it would make sense to have PRBS in
libosmocore. But I'm not very familiar with the libosmocore coding style, so I
would appreciate to commit this patch as is to osmo-trx and then move the code
to libosmocore later if someone more familiar with it
Review at https://gerrit.osmocom.org/2788
Add header file with definitions for GSM TS 04.14 / 3GPP TS 44.014
Change-Id: I1f4fc2761b55a4f83544c1c3793ab67fec9fc120
---
M include/Makefile.am
A include/osmocom/gsm/protocol/gsm_04_14.h
M src/gsm/Makefile.am
M src/gsm/libosmogsm.map
4 files changed,
Review at https://gerrit.osmocom.org/2787
Update L3 protocol discriminator definitions
Change-Id: Ia699d3494b93b7f88c36338e4960b35c42a29b9c
---
M include/osmocom/gsm/protocol/gsm_04_08.h
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Patch Set 1:
> Are you able to build tests when static build is enabled?
Tried ./configure --enable-static - no issues with make check, all seems to be
ok.
> Also, do you know have patches to enable static build for all library
> dependencies?
Which one? I thought all the Osmocom libraries
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2760
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I042cc76258df7e4c6c90a73af3d0a6e75999b2b0
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2785
OML: fix Coverity-reported issues
* CID 169803: Null pointer dereferences
* CID 169802: Incorrect expression
Change-Id: Ib3f91be97c8bf81a87681814bf81d3a5a9950e54
Related: OS#1614
---
M src/common/oml.c
1 file changed, 6 insertions(+), 2 deletions(-)
Review at https://gerrit.osmocom.org/2786
Extend Get Attribute responder
* detect if attributes are requested for BTS or TRX and act accordingly
* report TRX phy version
* report TRX nominal power
Note: including phy_link.h to onl.c somehow breaks the tests so we have
to add stub functions to
Review at https://gerrit.osmocom.org/2783
Get TRX attributes
Request per-TRX attributes in addition to BTS attributes.
Change-Id: I2b61131b9930afd03357c0b66947ee856d58cc46
Related: OS#1614
---
M openbsc/include/openbsc/gsm_data_shared.h
M openbsc/src/libbsc/abis_nm.c
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2782
to look at the new patch set (#2).
core/conv: combine Viterbi implementation into a single dir
Change-Id: Ifbcb020c1302e49de2a9afe8567f851a16a023e6
---
M src/Makefile.am
R
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2780
to look at the new patch set (#2).
ofono_client: Fix race condition when checking for required features
I got a backtrace in which the modem was lacking feature 'net'. That
happens for
Review at https://gerrit.osmocom.org/2781
core/conv: rename viterbi_gen.c to viterbi_generic.c
Let's avoid confusion with generated files which have
ending with _gen.* as well.
Change-Id: I3ecd8f9e73c05236f2cdc186f58b3d0ba552283f
---
M src/Makefile.am
R src/viterbi_generic.c
2 files changed,
Review at https://gerrit.osmocom.org/2782
core/conv: combine Viterbi implementation into a single dir
Change-Id: Ifbcb020c1302e49de2a9afe8567f851a16a023e6
---
M src/Makefile.am
R src/viterbi/viterbi.c
R src/viterbi/viterbi_generic.c
R src/viterbi/viterbi_sse.c
R src/viterbi/viterbi_sse_avx.c
R
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2760
to look at the new patch set (#4).
core/conv: do not mix up AVX and SSE code
According to GCC's wiki:
If you specify command-line switches such as -msse, the compiler
could use
Review at https://gerrit.osmocom.org/2780
ofono_client: Fix race condition when checking for required features
I got a backtrace in which the modem was lacking feature 'net'. That
happens for 2 reasons:
1- net feature is not shown unless the modem is Online (at least for
sierra modems)
2- Even
Patch Set 10: Code-Review-1
(1 comment)
Please do not submit. all --enable-iu axes [1] are failing.
[1]
https://jenkins.blobb.me/job/openBSC_multi-configuration_withArtifacts_testRefactoring/
https://gerrit.osmocom.org/#/c/2465/8/scripts/osmo-build.sh
File scripts/osmo-build.sh:
Line 1:
Pau Espin Pedrol has abandoned this change.
Change subject: ofono_client: Implement network registration during connect()
..
Abandoned
New rebased changeset in https://gerrit.osmocom.org/#/c/2779/
--
To view, visit
Review at https://gerrit.osmocom.org/2779
ofono_client: Implement network registration during connect()
Also add a new simple test to check network registration is working
Change-Id: I8d9eb47eac1044550d3885adb55105c304b0c15c
---
M src/osmo_gsm_tester/ofono_client.py
M
Patch Set 2:
> Yes, I learned this "the hard way". My point is: The commit message
> should clearly state that this is only for generation of random
> test bursts and not a general bug in actual TRX code.
Ok, I've updated the commit message to make it more obvious.
--
To view, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2762
to look at the new patch set (#2).
sigProcLib: Fix number of tail bits in random Normal Bursts and zero Stealing
Bits.
This bug only affects generation of normal bursts filled with
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2778
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d2fcaabbc74730f6f491a2b2d5c784ccafc6602
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2777
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9079470584777dcc31f85f9bf0808f479156ccb
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: libbsc: Create pcu-socket only as specified in config file
..
libbsc: Create pcu-socket only as specified in config file
Since commit
Review at https://gerrit.osmocom.org/2778
don't re-implement osmo_talloc_replace_string()
osmo_talloc_replace_string() was introducd into libosmocore in 2014, see
commit f3c7e85d05f7b2b7bf093162b776f71b2bc6420d
There's no reason for us to re-implement this as bsc_replace_string
here.
Review at https://gerrit.osmocom.org/2777
libbsc: Create pcu-socket only as specified in config file
Since commit b4999b60d48bcbb5aa575973d068e07ab672e095 we created PCU
sockets at hard-coded paths in the filesystem by default for all BTSs.
This is inflexible and prevents the use of multiple
Harald Welte has submitted this change and it was merged.
Change subject: octphy: remove old event control code
..
octphy: remove old event control code
Event handling is done internally in the Octasic BTS. When the TRX is
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1980
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0652627495f6a9bcb0da2431b8beb839bc22062b
Gerrit-PatchSet: 12
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
Yes, I learned this "the hard way". My point is: The commit message should
clearly state that this is only for generation of random test bursts and not a
general bug in actual TRX code.
--
To view, visit https://gerrit.osmocom.org/2762
To unsubscribe, visit
Patch Set 1:
Harald, this function is used only when we generate bursts locally at osmo-trx,
which is currently only used for generation of test random bursts.
--
To view, visit https://gerrit.osmocom.org/2762
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 3: Code-Review-1
(1 comment)
In general, I'd prefer to avoid confusion with generated code which is in files
ending with _gen.* as well. Calling it viterbi_generic.c would be much better.
https://gerrit.osmocom.org/#/c/2760/3/src/viterbi_gen.c
File src/viterbi_gen.c:
Line 145: void
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2776/2/example/resources.conf
File example/resources.conf:
Line 4
I remember from previous patches that you needed this amount of different
addresses due to the current amount of different processes? It would be good to
filte rport 22
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2769
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a6463ee39761775305dd2272c24f248552db4ad
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
71 matches
Mail list logo
