[MERGED] osmo-trx[master]: uhd: Always specify samples-per-symbol for device lookup

2017-06-27 Thread Tom Tsou
Tom Tsou has submitted this change and it was merged. Change subject: uhd: Always specify samples-per-symbol for device lookup .. uhd: Always specify samples-per-symbol for device lookup Fix MCBTS device setup where the map

osmo-trx[master]: uhd: Always specify samples-per-symbol for device lookup

2017-06-27 Thread Tom Tsou
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3062 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56e939285d585cc38efa6c329e30e3acebb734eb Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master

[PATCH] osmo-trx[master]: uhd: Always specify samples-per-symbol for device lookup

2017-06-27 Thread Tom Tsou
Hello Max, Alexander Chemeris, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3062 to look at the new patch set (#2). uhd: Always specify samples-per-symbol for device lookup Fix MCBTS device setup where the map access was failing on the

osmo-trx[master]: uhd: Always specify samples-per-symbol for device lookup

2017-06-27 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/3062/1//COMMIT_MSG Commit Message: Line 18: Fixes: Bug #2341 "osmo-trx-m is broken" would be good to use the OS#2341 notation: Fixes: OS#2341 [...] ...to ensure we can evaluate the relation automatically. See point 4 in

osmo-trx[master]: uhd: Always specify samples-per-symbol for device lookup

2017-06-27 Thread Alexander Chemeris
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3062 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56e939285d585cc38efa6c329e30e3acebb734eb Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-06-27 Thread André Boddenberg
Patch Set 13: Now, it's a shell and not a bash script as suggested by Max. All comments (PS11) should be addressed. Furthermore osmo-build.sh checks whether all functions in contrib/jenkins.sh and build scripts like osmo-deps.sh and osmo-build-dep.sh are available and fails elsewise (fail

[PATCH] osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-06-27 Thread André Boddenberg
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2465 to look at the new patch set (#13). Introduce artifacts holding dependencies to speed up builds. Basically, osmo-build.sh holds logic to check whether the necessary

[PATCH] osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-06-27 Thread André Boddenberg
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2465 to look at the new patch set (#12). Introduce artifacts holding dependencies to speed up builds. Basically, osmo-build.sh holds logic to check whether the necessary

[MERGED] osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

2017-06-27 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: Revert "osmo-bts-trx config: remove settsc" .. Revert "osmo-bts-trx config: remove settsc" According to pespin, this makes all osmo-bts-trx test

osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

2017-06-27 Thread Pau Espin Pedrol
Patch Set 1: Without reverting this patch, we end up in an scenario in which the 2 MS are registered but then they unregister at some point later, the tets fail with a Wait Timeout on registration. -- To view, visit https://gerrit.osmocom.org/3068 To unsubscribe, visit

osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

2017-06-27 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3068 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a3db0d060203ad6540c9a3cc7735e273ee0048 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

2017-06-27 Thread Neels Hofmeyr
Neels Hofmeyr has reverted this change. Change subject: Revert "osmo-bts-trx config: remove settsc" .. Uploaded patch set 1. -- To view, visit https://gerrit.osmocom.org/3068 To unsubscribe, visit

[PATCH] osmo-gsm-tester[master]: Revert "osmo-bts-trx config: remove settsc"

2017-06-27 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3068 Revert "osmo-bts-trx config: remove settsc" According to pespin, this makes all osmo-bts-trx test runs fail. We will still figure out the details, but for the time being let's go with the known working config. This reverts commit

osmo-bts[master]: RSL: receive and send multiple SI2q messages

2017-06-27 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+1 Indeed, it seems the issue came from a commit introduced yesterday in osmo-gsm-tester which was removing settsc as it is going to be removed in osmo-bts by a series of upcoming patches, but until that's included, removing the settsc config makes all trx jobs fail

[PATCH] osmo-bts[master]: trx: avoid deacting lchan on LCHAN_REL_ACT_REACT

2017-06-27 Thread Max
Review at https://gerrit.osmocom.org/3067 trx: avoid deacting lchan on LCHAN_REL_ACT_REACT * do not deactivate lchan when called with LCHAN_REL_ACT_REACT * add fixme comment It's unclear yet if any special steps are required for osmo-bts-trx so let's just make it compatible with setups [1]

[PATCH] libosmocore[master]: deb: fix build by adding libosmogb doc package

2017-06-27 Thread Max
Review at https://gerrit.osmocom.org/3066 deb: fix build by adding libosmogb doc package Change-Id: I3fe45feaee4033c17e25c4c0552d54a81d9b44f5 Fixes: OS#2340 --- M debian/control A debian/libosmogb-doc.doc-base A debian/libosmogb-doc.install M debian/rules 4 files changed, 24 insertions(+), 0

[ABANDON] osmo-pcu[master]: Cleanup TBF state handling

2017-06-27 Thread Max
Max has abandoned this change. Change subject: Cleanup TBF state handling .. Abandoned -- To view, visit https://gerrit.osmocom.org/2858 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon

[ABANDON] libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-27 Thread Max
Max has abandoned this change. Change subject: Add and use macros to set/get/clear/toggle bit flags .. Abandoned Harald is not convinced. -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit

osmo-bts[master]: RSL: receive and send multiple SI2q messages

2017-06-27 Thread Max
Patch Set 2: I've run osmo-gsm-tester manually and got exactly the same errors with current master - see http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_manual-run-all/4/#showFailuresLink So it seems like it have nothing to do with my patch or at least some other

openbsc[master]: lchan: add members for BFI

2017-06-27 Thread dexter
Patch Set 2: > Isn't this basically the link failure counter "s" ? which we also > already have in lchan->s ? > > If there's something mandate by specs but we're missing it, pleaes > include relevant spec references in the commit log. I thin GSM 05.08 Chapter 5 (Radio link failure) is the

[PATCH] osmo-ci[master]: Add value string termination check from libosmocore

2017-06-27 Thread Max
Add value string termination check from libosmocore The script by Neels Hofmeyr has actually nothing to do with libosmocore itself - it's a generic build-time check used by jenkins so it should be part of this repo to avoid extra checkout of libosmocore just for this

[PATCH] osmo-ci[master]: Add value string termination check from libosmcore

2017-06-27 Thread Max
Review at https://gerrit.osmocom.org/3065 Add value string termination check from libosmcore The script by Neels Hofmeyr has actually nothing to with libosmocore itself - it's a generic build-time check used by jenkins so it should be part of this repo to avoid extra