[PATCH] osmo-pcu[master]: README: Clarify that fixed allocations have been revmoved fr...

2017-07-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/3389 README: Clarify that fixed allocations have been revmoved from 3GPP specs In Release 5, Fixed Allocations were removed as part of a "GPRS simplification project" inside 3PGPP. This means that any MS compatible with Rel-5 or higher may not support it,

[MERGED] osmo-pcu[master]: GSMTAP: Fix channel type for data blocks: PDTCH instead of P...

2017-07-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: GSMTAP: Fix channel type for data blocks: PDTCH instead of PACCH .. GSMTAP: Fix channel type for data blocks: PDTCH instead of PACCH PACCH is used only

[MERGED] osmo-pcu[master]: GSMTAP: Ad PTCCH as separate gsmtap category

2017-07-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: GSMTAP: Ad PTCCH as separate gsmtap category .. GSMTAP: Ad PTCCH as separate gsmtap category This allows us to send GSMTAP for PTCCH only if requested

[MERGED] osmo-pcu[master]: GSMTAP: Fix logical channel of downlink PTCCH

2017-07-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: GSMTAP: Fix logical channel of downlink PTCCH .. GSMTAP: Fix logical channel of downlink PTCCH Change-Id: I29ecc968d56d4d0165cffa206297c42d6fb02cf4 ---

osmo-pcu[master]: GSMTAP: Ad PTCCH as separate gsmtap category

2017-07-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3388 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id720f4bebdce7f6152fbbe05036638c5866e Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: GSMTAP: Fix logical channel of downlink PTCCH

2017-07-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3387 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29ecc968d56d4d0165cffa206297c42d6fb02cf4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: GSMTAP: Fix channel type for data blocks: PDTCH instead of P...

2017-07-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3386 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c912e17d8c8d4178096679a541e61eeeb4b6643 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[MERGED] libosmocore[master]: Rename GSMTAP_CHANNEL_PDCH to GSMTAP_CHANNEL_PDTCH

2017-07-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Rename GSMTAP_CHANNEL_PDCH to GSMTAP_CHANNEL_PDTCH .. Rename GSMTAP_CHANNEL_PDCH to GSMTAP_CHANNEL_PDTCH PDCH is the physical channel, while actually we

[PATCH] osmo-pcu[master]: GSMTAP: Fix logical channel of downlink PTCCH

2017-07-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/3387 GSMTAP: Fix logical channel of downlink PTCCH Change-Id: I29ecc968d56d4d0165cffa206297c42d6fb02cf4 --- M src/pcu_l1_if.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/3387/1 diff

[PATCH] osmo-pcu[master]: GSMTAP: Fix channel type for data blocks: PDTCH instead of P...

2017-07-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/3386 GSMTAP: Fix channel type for data blocks: PDTCH instead of PACCH PACCH is used only for RLC/MAC control messages, while PDTCH is used for data. Change-Id: I6c912e17d8c8d4178096679a541e61eeeb4b6643 --- M src/bts.cpp M src/gprs_rlcmac_sched.cpp 2 files

[PATCH] osmo-pcu[master]: GSMTAP: Ad PTCCH as separate gsmtap category

2017-07-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/3388 GSMTAP: Ad PTCCH as separate gsmtap category This allows us to send GSMTAP for PTCCH only if requested by user/vty Change-Id: Id720f4bebdce7f6152fbbe05036638c5866e --- M src/bts.h M src/pcu_l1_if.cpp M src/pcu_vty.c 3 files changed, 5

libosmocore[master]: Rename GSMTAP_CHANNEL_PDCH to GSMTAP_CHANNEL_PDTCH

2017-07-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3385 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6782d2247846e2db29fc58d98684970a66db948 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: Rename GSMTAP_CHANNEL_PDCH to GSMTAP_CHANNEL_PDTCH

2017-07-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/3385 Rename GSMTAP_CHANNEL_PDCH to GSMTAP_CHANNEL_PDTCH PDCH is the physical channel, while actually we want to talk about PDTCH the logical channel. Introduce backwards compatibility define. Change-Id: Id6782d2247846e2db29fc58d98684970a66db948 --- M

osmo-pcu[master]: Remove #warnings that have been adressed since 2015

2017-07-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3382 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a1767bc7cab01048e851fd4e63112bc676d6c78 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[MERGED] osmo-pcu[master]: Remove #warnings that have been adressed since 2015

2017-07-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Remove #warnings that have been adressed since 2015 .. Remove #warnings that have been adressed since 2015 In commit

[MERGED] osmo-pcu[master]: BSSGP: Improve logging of received messages

2017-07-29 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSSGP: Improve logging of received messages .. BSSGP: Improve logging of received messages We now differentiate clearly between messages that a) we

osmo-pcu[master]: BSSGP: Improve logging of received messages

2017-07-29 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3383 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie32f5771d49960547ec5d7611f96a74facc1b035 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[PATCH] osmo-pcu[master]: Forward GPRS SUSPEND REQ from BTS to SGSN using BSSGP

2017-07-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/3384 Forward GPRS SUSPEND REQ from BTS to SGSN using BSSGP As specified in 3GPP TS 03.60 Section 16.2.1 and 44.018 Section 3.4.15, a Class B MS is sending a "RR GPRS SUSPEND REQ" via a DCCH to the BTS if it wants to suspend GPRS services. As of Change-Id

[PATCH] osmo-pcu[master]: Remove #warnings that have been adressed since 2015

2017-07-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/3382 Remove #warnings that have been adressed since 2015 In commit 939904672961fa7e28397e27f942a7d1fff4bbdf the lookup by TLLI, TLLI-OLD and IMSI has been implemented, but the corresponding compile-time warning was never removed. Change-Id:

[PATCH] osmo-pcu[master]: BSSGP: Improve logging of received messages

2017-07-29 Thread Harald Welte
Review at https://gerrit.osmocom.org/3383 BSSGP: Improve logging of received messages We now differentiate clearly between messages that a) we don't expect based on our reading of the spec b) we have not implemented yet (but should) c) we do not even know of Also, unify the log string

[PATCH] libosmocore[master]: gsm0480: refactor the parse_process_uss_req()

2017-07-29 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3375 to look at the new patch set (#2). gsm0480: refactor the parse_process_uss_req() This change reduces the degree of code nesting using the 'follow by contradiction' pattern. Change-Id:

[PATCH] libosmocore[master]: gsm0480: handle GSM0480_OP_CODE_PROCESS_USS_DATA

2017-07-29 Thread Vadim Yanitskiy
gsm0480: handle GSM0480_OP_CODE_PROCESS_USS_DATA Change-Id: I470290c2b544555e53cedd849b1d6a961db7b5a4 --- M src/gsm/gsm0480.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/3380/2 diff --git a/src/gsm/gsm0480.c

[PATCH] libosmocore[master]: gsm0480: handle USS_NOTIFY and USS_REQUEST with PROCESS_USS_REQ

2017-07-29 Thread Vadim Yanitskiy
gsm0480: handle USS_NOTIFY and USS_REQUEST with PROCESS_USS_REQ Change-Id: If7cc6a966dfc17d37e22338ecc1f239f908a9f2e --- M src/gsm/gsm0480.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/3379/2 diff --git

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2017-07-29 Thread Vadim Yanitskiy
gsm0480: expose the gsm0480_parse_ss_facility_ie() Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb --- M include/osmocom/gsm/gsm0480.h M src/gsm/gsm0480.c M src/gsm/libosmogsm.map 3 files changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore

[PATCH] libosmocore[master]: gsm0480: handle GSM0480_CTYPE_RETURN_RESULT

2017-07-29 Thread Vadim Yanitskiy
gsm0480: handle GSM0480_CTYPE_RETURN_RESULT Change-Id: I8fb2856acbbf4c53e7d53200a37bc8f79e763bcf --- M src/gsm/gsm0480.c 1 file changed, 84 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/78/3378/2 diff --git a/src/gsm/gsm0480.c

[PATCH] libosmocore[master]: gsm0480: parse GSM0480_MTYPE_FACILITY separately

2017-07-29 Thread Vadim Yanitskiy
gsm0480: parse GSM0480_MTYPE_FACILITY separately Change-Id: I6e029c436a50fa8c2823ea39c5d123ee701becfa --- M src/gsm/gsm0480.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/3377/2 diff --git a/src/gsm/gsm0480.c

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

2017-07-29 Thread Vadim Yanitskiy
gsm0480: handle UnstructuredSS request with DSC != 0x0F Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 --- M src/gsm/gsm0480.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/3376/2 diff --git a/src/gsm/gsm0480.c

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3381 gsm0480: expose the gsm0480_parse_ss_facility_ie() Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb --- M include/osmocom/gsm/gsm0480.h M src/gsm/gsm0480.c M src/gsm/libosmogsm.map 3 files changed, 8 insertions(+), 6 deletions(-) git pull

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3376 gsm0480: handle UnstructuredSS request with DSC != 0x0F Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 --- M src/gsm/gsm0480.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore

[PATCH] libosmocore[master]: gsm0480: refactor the parse_process_uss_req()

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3375 gsm0480: refactor the parse_process_uss_req() This change reduces the degree of code nesting using the 'follow by contradiction' pattern. Change-Id: I467f75794c5ac9df75c001245b18bbdfcfaadd88 --- M src/gsm/gsm0480.c 1 file changed, 20 insertions(+), 19

[PATCH] libosmocore[master]: gsm0480: handle GSM0480_OP_CODE_PROCESS_USS_DATA

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3380 gsm0480: handle GSM0480_OP_CODE_PROCESS_USS_DATA Change-Id: I470290c2b544555e53cedd849b1d6a961db7b5a4 --- M src/gsm/gsm0480.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/3380/1

[PATCH] libosmocore[master]: gsm0480: handle GSM0480_CTYPE_RETURN_RESULT

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3378 gsm0480: handle GSM0480_CTYPE_RETURN_RESULT Change-Id: I8fb2856acbbf4c53e7d53200a37bc8f79e763bcf --- M src/gsm/gsm0480.c 1 file changed, 84 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/78/3378/1

[PATCH] libosmocore[master]: gsm0480: parse GSM0480_MTYPE_FACILITY separately

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3377 gsm0480: parse GSM0480_MTYPE_FACILITY separately Change-Id: I6e029c436a50fa8c2823ea39c5d123ee701becfa --- M src/gsm/gsm0480.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/3377/1

[PATCH] libosmocore[master]: gsm0480: handle USS_NOTIFY and USS_REQUEST with PROCESS_USS_REQ

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3379 gsm0480: handle USS_NOTIFY and USS_REQUEST with PROCESS_USS_REQ Change-Id: If7cc6a966dfc17d37e22338ecc1f239f908a9f2e --- M src/gsm/gsm0480.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore

[PATCH] libosmocore[master]: gsm0480: modify USSD structures to support external handling

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3374 gsm0480: modify USSD structures to support external handling This change adds the following new fields to ss_request struct: - message_type - GSM 04.80 Chapter 2.2 - component_type - GSM 04.80 Chapter 3.6.2 - error_code - GSM 04.80 Chapter 3.6.6

[PATCH] libosmocore[master]: gsm0480: drop length check in gsm0480_decode_ss_request()

2017-07-29 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/3373 gsm0480: drop length check in gsm0480_decode_ss_request() According to GSM 04.80 Section 2.5 'Release complete' Table 2.5, the 'RELEASE COMPLETE' message payload is optional, so let's drop length check in gsm0480_decode_ss_request(). Change-Id: