Harald Welte has submitted this change and it was merged.
Change subject: ippool: Extend pool to work with /64 prefixes
..
ippool: Extend pool to work with /64 prefixes
In IPv6 GPRS, we actually don't want to allocate an
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3457
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cf700b6baf195a2e5fbea000531f801acaaa443
Gerrit-PatchSet: 2
Gerrit-Project: openggsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3341
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37395169d364050e45e99793c495a9848a4f8601
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: safer osmo_sccp_make_addr_pc_ssn(): clear all values
..
safer osmo_sccp_make_addr_pc_ssn(): clear all values
Make sure that all values of the resulting
Harald Welte has submitted this change and it was merged.
Change subject: vty: hide SG commands when running as ASP
..
vty: hide SG commands when running as ASP
The SG (signal gateway) requires an extra set of VTY commands in
Harald Welte has submitted this change and it was merged.
Change subject: sccp: fix creating of the default route in simple client
..
sccp: fix creating of the default route in simple client
The simple client
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3452
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7516fa5509bade4ba10e9d8eaa3e46cfe3696b3a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3453
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I707bcd790f4c6d0f618e41163b51d2179ea3aeaf
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3454
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05ff75ef7dfae639886bbd09fe35f03a8af9d988
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: tlv: add [msgb_]t16lv_put() for 16bit tag + 8 bit len TLVs
..
tlv: add [msgb_]t16lv_put() for 16bit tag + 8 bit len TLVs
In the Protocol Configuration
Harald Welte has submitted this change and it was merged.
Change subject: Add osmo_gprs_{ul,dl}_block_size_{bits,bytes} functions
..
Add osmo_gprs_{ul,dl}_block_size_{bits,bytes} functions
Those functions can be used to look
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3408
to look at the new patch set (#7).
Support setting TUN device IPv6 address + prefix
As we can now have PDP contexts with IPv6 user IP payload,
it is useful to extend the TUN related
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3460
to look at the new patch set (#2).
IPv6: in46_addr: OSMO_ASSERT() in case of unsupported calls
There's a bit of trickery with the ip_pool and it's "lengty=8" IPv6
prefix handling,
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3458
to look at the new patch set (#2).
IPv6: Implement IPv6 prefix assignment via ICMPv6 router advertisement
The 3GPP specs are quite strange when it comes to how an IPv6 address
or
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3459
to look at the new patch set (#2).
IPv6: Support PCO for IPv6 DNS addresses
In IPv6, DNS server information is not passed along as IPCP6 like
in IPv5 with IPCP. The reason is that
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3455
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9799130e2eba8fae8c4480fbb8a900c30232b694
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: ippool_new(): const-ify input arguments
..
ippool_new(): const-ify input arguments
Change-Id: If3e53584e8c9c1f06bba4c183c9fd65fae913904
---
M
Harald Welte has submitted this change and it was merged.
Change subject: lib/tun.h: Remove non-endian-safe redefinition of IP header
..
lib/tun.h: Remove non-endian-safe redefinition of IP header
We can simply use 'struct
Harald Welte has submitted this change and it was merged.
Change subject: ippool: Add IPv6 support to IP pool implementation
..
ippool: Add IPv6 support to IP pool implementation
Extend the IP pool implementation to be able to
Harald Welte has submitted this change and it was merged.
Change subject: ggsn: Send proper errors in create_context_ind()
..
ggsn: Send proper errors in create_context_ind()
When we receive PDP context requests for unknown
Harald Welte has submitted this change and it was merged.
Change subject: IPv6 support for user IP
..
IPv6 support for user IP
This patch enables the use of IPv6 PDP contexts. The phone will
have to request an IPv6
Harald Welte has submitted this change and it was merged.
Change subject: Proper fix for "Force Dynamic IP" in Create PDP CTX
..
Proper fix for "Force Dynamic IP" in Create PDP CTX
An EUA length of *2* octets indicates dynamic
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3456
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic993d8abdc90897cb55276f01ae3b8a5eadf5a0d
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: in46_addr: Add new function in46a_prefix_equal()
..
in46_addr: Add new function in46a_prefix_equal()
This function is used to compare an IPv6 address
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3406
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c3bf32a98e5daf99d6eaeac8c9f95cc7574774
Gerrit-PatchSet: 6
Gerrit-Project: openggsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: make point codes configurable by SCCP address book
..
make point codes configurable by SCCP address book
In the vty config, use the SCCP address book to
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3403
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98cc4bf634d6be9a7bf8c03a24e629455fcafc8
Gerrit-PatchSet: 5
Gerrit-Project: openggsn
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3394
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33a7ba11eb7c2d9a5dc74d10fb0cf04bf664477b
Gerrit-PatchSet: 3
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Review at https://gerrit.osmocom.org/3459
IPv6: Support PCO for IPv6 DNS addresses
In IPv6, DNS server information is not passed along as IPCP6 like
in IPv5 with IPCP. The reason is that IPCP6 (for PPP) doesn't
support passing DNS server information. Rather, the relevant RFCs
indicate DHCPv6
Review at https://gerrit.osmocom.org/3460
IPv6: in46_addr: OSMO_ASSERT() in case of unsupported calls
There's a bit of trickery with the ip_pool and it's "lengty=8" IPv6
prefix handling, let's make sure we don't accidentially call any
support functions with addresses of wrong length.
Review at https://gerrit.osmocom.org/3456
in46_addr: Add new function in46a_prefix_equal()
This function is used to compare an IPv6 address against another,
using the smaller of the two prefix lengths.
Change-Id: Ic993d8abdc90897cb55276f01ae3b8a5eadf5a0d
---
M lib/in46_addr.c
M
Review at https://gerrit.osmocom.org/3458
IPv6: Implement IPv6 prefix assignment via ICMPv6 router advertisement
The 3GPP specs are quite strange when it comes to how an IPv6 address
or rather prefix is assigned to an IPv6 PDP context. The designated
method for allocating the IPv6 address via
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3406
to look at the new patch set (#6).
IPv6 support for user IP
This patch enables the use of IPv6 PDP contexts. The phone will
have to request an IPv6 End-user-Address, and the GGSN will
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3407
to look at the new patch set (#6).
ggsn: Send proper errors in create_context_ind()
When we receive PDP context requests for unknown PDP types or if
we run out of dynamic addresses, we
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3405
to look at the new patch set (#6).
ippool_new(): const-ify input arguments
Change-Id: If3e53584e8c9c1f06bba4c183c9fd65fae913904
---
M lib/ippool.c
M lib/ippool.h
2 files changed, 2
Review at https://gerrit.osmocom.org/3457
ippool: Extend pool to work with /64 prefixes
In IPv6 GPRS, we actually don't want to allocate an individual v6
address (like in IPv4), but we want to allocate a prefix. The
standard prefix lengh is 8 bytes, i.e. a /64 prefix. This patch
extends the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3404
to look at the new patch set (#6).
lib/tun.h: Remove non-endian-safe redefinition of IP header
We can simply use 'struct iphdr' from netinet/ip.h to achieve
the same goal (and be
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3403
to look at the new patch set (#5).
ippool: Add IPv6 support to IP pool implementation
Extend the IP pool implementation to be able to manage both pools
of 32bit addresses (IPv4) as
Review at https://gerrit.osmocom.org/3455
tlv: add [msgb_]t16lv_put() for 16bit tag + 8 bit len TLVs
In the Protocol Configuration Options IE (see 3GPP TS 24.008 10.5.6.3)
there is yet another new TLV format (derived from PPP IPCP/LCP/...)
which uses 16bit tag and 8bit length. Let's add
Review at https://gerrit.osmocom.org/3454
Add osmo_gprs_{ul,dl}_block_size_{bits,bytes} functions
Those functions can be used to look up the size of (E)GPRS blocks.
Change-Id: I05ff75ef7dfae639886bbd09fe35f03a8af9d988
---
M include/osmocom/gprs/gprs_rlc.h
M src/gsm/gprs_rlc.c
M
Review at https://gerrit.osmocom.org/3453
vty: hide SG commands when running as ASP
The SG (signal gateway) requires an extra set of VTY commands in
order to be fully configurable. These VTY commands do not make
sense in a situation where libosmo-sccp is used to implement an
ASP (application
Review at https://gerrit.osmocom.org/3452
sccp: fix creating of the default route in simple client
The simple client (osmo_sccp_simple_client_on_ss7_id() and
osmo_sccp_simple_client) does not create a default route if
the user has already created an AS via VTY.
Check the presence of a default
Neels Hofmeyr has abandoned this change.
Change subject: apply ctx arg to osmo_ss7_vty_init_asp()
..
Abandoned
now part of 'make point codes configurable by SCCP address book'
https://gerrit.osmocom.org/3394
--
To view,
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3394
to look at the new patch set (#3).
make point codes configurable by SCCP address book
In the vty config, use the SCCP address book to configure the local and remote
SCCP
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40
status report
..
libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: support GSM 03.40 status report for nitb
..
libmsc: support GSM 03.40 status report for nitb
This patch adds support for GSM 03.40 in nitb
Patch Set 4: Verified+1
--
To view, visit https://gerrit.osmocom.org/3437
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70e534840308ed315f7add440351e649de3f907
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: utils: smpp_mirror: bounce Delivery Receipts as Delivery
Acknowledgments
..
utils: smpp_mirror: bounce Delivery Receipts as Delivery
Patch Set 4: Verified+1
--
To view, visit https://gerrit.osmocom.org/3436
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I877e228d8e174430f700631edbf9955972da7892
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 4: Verified+1
(1 comment)
https://gerrit.osmocom.org/#/c/3435/1/openbsc/src/libmsc/db.c
File openbsc/src/libmsc/db.c:
Line 375: /* Just like v3, but there is a new message reference field for
status reports,
> "just like v5"?
Right, just like v3 actually.
--
To view, visit
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: update database to accomodate SMS status-report fields
..
libmsc: update database to accomodate SMS status-report fields
SMPP DELIVER_SM
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3443
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b3e1171da467519750b201849ec892a1e318129
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Add pcu-socket vty config
..
Add pcu-socket vty config
osmo-bts already supports configuring a different path for the bts<->pcu
socket by using the
Harald Welte has submitted this change and it was merged.
Change subject: TRX: Remove global variables, move SETBSIC/SETTSC handling into
phy_link
..
TRX: Remove global variables, move SETBSIC/SETTSC handling into phy_link
Harald Welte has submitted this change and it was merged.
Change subject: l1sap/osmo-bts-sysmo: Improve logging
..
l1sap/osmo-bts-sysmo: Improve logging
Change-Id: I339db0e5f3fd5e44bac974f2447afc80388802af
---
M
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3044/4//COMMIT_MSG
Commit Message:
PS4, Line 10: transceiver is a property
> What is a property?
property: https://en.wikipedia.org/wiki/Property_(programming)
and no, my original sentence is what I want. "[The question of]
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3038
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I339db0e5f3fd5e44bac974f2447afc80388802af
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: ws in log
..
cosmetic: ws in log
Change-Id: If5a56ec170d4e91ce070f6fa9c9cfe5bbc121186
---
M src/sccp2sua.c
1 file changed, 1 insertion(+), 1
Harald Welte has submitted this change and it was merged.
Change subject: sccp-addr vty: set RI to SSN_PC when setting a point-code
..
sccp-addr vty: set RI to SSN_PC when setting a point-code
Change-Id:
Patch Set 4:
> Patch Set 4: Verified+1
Not sure why I am permitted to Verify this... :-/
--
To view, visit https://gerrit.osmocom.org/3438
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cc7bb4ebadde0940f44d10c3df34707b0615160
Harald Welte has submitted this change and it was merged.
Change subject: add osmo_sccp_addr_name() and three value_string[]s
..
add osmo_sccp_addr_name() and three value_string[]s
osmo_sccp_addr_dump() just prints the raw
Harald Welte has submitted this change and it was merged.
Change subject: constify ss7_instance arg of osmo_ss7_pointcode_print()
..
constify ss7_instance arg of osmo_ss7_pointcode_print()
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: fix osmo_sccp_addr_dump(): actually print RI
..
fix osmo_sccp_addr_dump(): actually print RI
Adjust xua_test accordingly.
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: introduce OSMO_SCCP_RI_NONE to indicate unset RI
..
introduce OSMO_SCCP_RI_NONE to indicate unset RI
Allows to automatically set an RI in future change
Harald Welte has submitted this change and it was merged.
Change subject: sccp_helpers: check buf len in append_to_buf()
..
sccp_helpers: check buf len in append_to_buf()
Change-Id: I2e6d656871f952be8e719573fedf2154832841d7
Harald Welte has submitted this change and it was merged.
Change subject: consistency: use OSMO_SS7_PC_INVALID for osmo_sccp_user
..
consistency: use OSMO_SS7_PC_INVALID for osmo_sccp_user
A previous patch added ss7_instance
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3355
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0f0c89b7335d9da24161bfac8234be214ca00c
Gerrit-PatchSet: 4
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3451
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8684c9b559712072c772012890bbf7efa7c8eb35
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3450
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5715bf03a4de7713a7a809dfd821c700255ba8c
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 4: Verified+1
--
To view, visit https://gerrit.osmocom.org/3438
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cc7bb4ebadde0940f44d10c3df34707b0615160
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: TRX: Remove bogus extern global variable declarations
..
TRX: Remove bogus extern global variable declarations
Those global variable declarations for
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3438
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cc7bb4ebadde0940f44d10c3df34707b0615160
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: utils: smpp_mirror: temporarily munch SMPP delivery receipts
..
utils: smpp_mirror: temporarily munch SMPP delivery receipts
Just munch and log
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: utils: smpp_mirror: set registered_delivery field in SMPP
SUBMIT_SM
..
utils: smpp_mirror: set registered_delivery field in SMPP SUBMIT_SM
To test
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: add support for SMPP delivery receipts
..
libmsc: add support for SMPP delivery receipts
If the mobile phone requests a status report via
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: report status report request flag from SMPP SUBMIT_SM
..
libmsc: report status report request flag from SMPP SUBMIT_SM
Restore the sms
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: missing bit shift in status report flag when stored in
sms object
..
libmsc: missing bit shift in status report flag when stored in sms
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3435
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7276d356d805a83ebeec72b02c8563b7135ea0b6
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Pablo Neira Ayuso has submitted this change and it was merged.
Change subject: libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM
messages
..
libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM messages
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/3428
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59af60fa89cd10ae973c5e122789e3e03e3728ee
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3435
to look at the new patch set (#4).
libmsc: update database to accomodate SMS status-report fields
SMPP DELIVER_SM messages with esm_class = Delivery
Patch Set 1: Code-Review-1
lynxis, let's enhance the copyright notice as in above comments
--
To view, visit https://gerrit.osmocom.org/3440
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I135d975b84027d51cb1dc534e04dd314bbd20289
Patch Set 4:
Now using 0x to mark invalid PC, this commit spread out into three:
adding the invalid value, ensuring set primary_pc, and then adjusting
osmo_sccp_user to use the same invalidity marking.
--
To view, visit https://gerrit.osmocom.org/3355
To unsubscribe, visit
Review at https://gerrit.osmocom.org/3450
add OSMO_SS7_PC_INVALID, add osmo_ss7_pc_is_valid()
Introduce OSMO_SS7_PC_INVALID to mark an unset point code.
Add static osmo_ss7_pc_is_valid() (name matches schema of
osmo_ss7_pc_is_local()).
In osmo_ss7_pointcode_print(), return "(no PC)" if
Review at https://gerrit.osmocom.org/3451
consistency: use OSMO_SS7_PC_INVALID for osmo_sccp_user
A previous patch added ss7_instance primary_pc validity checks by means of
OSMO_SS7_PC_INVALID. To be consistent, also adjust sccp_user accordingly.
(see I7f0f0c89b7335d9da24161bfac8234be214ca00c)
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3355
to look at the new patch set (#4).
ensure valid primary_pc in osmo_ss7_instance
Initialize osmo_ss7_instance.cfg.primary_pc = OSMO_SS7_PC_INVALID.
Adjust all code paths using
Patch Set 3:
> Can it work here?
I don't believe so, SQLITE3 ALTER TABLE is limited to adding new columns to the
end of the table. Probably why it's done like this in previous db version
upgrades.
https://www.sqlite.org/lang_altertable.html
--
To view, visit https://gerrit.osmocom.org/3435
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b5f934fc3bd00b0467d90029d3053b16594186
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2:
Hi Harald, thank you for a reminder. I'll try to find some time to extend the
patch.
--
To view, visit https://gerrit.osmocom.org/3185
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Vadim Yanitskiy, Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3045
to look at the new patch set (#5).
TRX: Remove bogus extern global variable declarations
Those global variable declarations for non-existing variables were
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b5f934fc3bd00b0467d90029d3053b16594186
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3400
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c79e42c5e08b28fe8182555302a5505fbbaa313
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 4: Code-Review+1
Maxim has added the 'Related: OS#1848' label in the previous
patch set. I think it makes sense to keep it.
--
To view, visit https://gerrit.osmocom.org/3045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 3: Verified+1
--
To view, visit https://gerrit.osmocom.org/3429
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac05252253f8933a3875b4904599b7a225191a4b
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3437
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70e534840308ed315f7add440351e649de3f907
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3436
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I877e228d8e174430f700631edbf9955972da7892
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3434/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 637: rc = sms_route_mt_sms(conn, sms_report);
> if mem is up, the program will likely not do *anything* useful anymore. Ins
It is our
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3429
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac05252253f8933a3875b4904599b7a225191a4b
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 3:
Have you considered using ALTER TABLE? Can it work here?
--
To view, visit https://gerrit.osmocom.org/3435
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7276d356d805a83ebeec72b02c8563b7135ea0b6
Gerrit-PatchSet: 3
1 - 100 of 181 matches
Mail list logo
