Patch Set 1:
Could you put a backtrace into the commit message?
--
To view, visit https://gerrit.osmocom.org/3467
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I306dad9b78e3becaef14c5305ec25c312feefe3c
Gerrit-PatchSet: 1
Gerrit-Project:
Harald Welte has submitted this change and it was merged.
Change subject: libmsc: Remove comment not applying anymore
..
libmsc: Remove comment not applying anymore
The change-id I7276d356d805a83ebeec72b02c8563b7135ea0b6 added
Harald Welte has submitted this change and it was merged.
Change subject: libmsc: gsm340_gen_oa_sub() may return negative value
..
libmsc: gsm340_gen_oa_sub() may return negative value
gsm340_gen_oa() returns a negative value i
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3465
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I204f098c8f2a480405446113e2181b2c53700cf3
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3461
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47215d7d89771730a7f84efa8aeeb187a0911fdb
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3466
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc7dd412b7580c451e716b73ef7549826c60b0d9
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 1:
could we have a unit test case to avoid regressions here? Also, is this an
overlap with gerrit 266 or 3257?
--
To view, visit https://gerrit.osmocom.org/3467
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I306dad9b78e3becae
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/3350/5/tests/msc_vlr/msc_vlr_tests.c
File tests/msc_vlr/msc_vlr_tests.c:
Line 168: log("MSC <--%s-- MS: %s",
> unrelated to the current patch: In general, we have shown the MS always on
agreed, no idea why I got the direction wrong
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3468
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9e697e8b198e4f58a79e59aaf2e649e84a3eb63
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Ge
Neels Hofmeyr has submitted this change and it was merged.
Change subject: sccp: prefix default parameters of osmo_sccp_simple_client()
..
sccp: prefix default parameters of osmo_sccp_simple_client()
The simple client takes cer
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3271
to look at the new patch set (#3).
vty: command to set local ip of ASP
The local ip of an ASP can not be set, while the same is possible
for the remote ip.
Add VTY command to set the l
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3468
to look at the new patch set (#2).
sccp: prefix default parameters of osmo_sccp_simple_client()
The simple client takes certain parameters (pc, ip and port
numbers) which serve as a fal
Review at https://gerrit.osmocom.org/3468
sccp: prefix default parameters of osmo_sccp_simple_client()
The simple client takes certain parameters (pc, ip and port
numbers) which serve as a fallback default in case the user
did not configure any suitable parameters via the VTY.
Prefix all defau
Review at https://gerrit.osmocom.org/3467
lapd_core: Fix crash in lapd_est_req() function
lapd_est_req() function could be called on uninitialized lapd link
(before lapd_dl_init() and after lapd_dl_exit() functions) due to
invalid usage on higher levels.
In order to prevent using uninitialized
Review at https://gerrit.osmocom.org/3466
handover_logic: set correct link to bts for subscriber_connection in case of
moving this connection to another bts
In case of successful completion of handover gsm_subscriber_connection could be
moved from one bts to another,
so connection link to bts
Patch Set 4:
> > Can it work here?
> I don't believe so, SQLITE3 ALTER TABLE is limited to adding new
> columns to the end of the table. Probably why it's done like this
> in previous db version upgrades.
> https://www.sqlite.org/lang_altertable.html
IIRC in the past we wanted to change the
Review at https://gerrit.osmocom.org/3465
libmsc: Remove comment not applying anymore
The change-id I7276d356d805a83ebeec72b02c8563b7135ea0b6 added msg_ref to
the databse but forgot to remove the comment stating it's not being
stored.
Change-Id: I204f098c8f2a480405446113e2181b2c53700cf3
---
M
Patch Set 1: Code-Review+2
Tested on the main unit. Pcap files still contain the whole information and
this way we don't record unrelated stuff.
--
To view, visit https://gerrit.osmocom.org/3464
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Chang
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: util: ip_to_iface: Return secondary iface if present
..
util: ip_to_iface: Return secondary iface if present
In the following example setup, if osmo-
Review at https://gerrit.osmocom.org/3464
util: ip_to_iface: Return secondary iface if present
In the following example setup, if osmo-nitb is listening
on 10.42.42.2, we want to return eth1:0 instead of eth1.
ip addr show eth1
3: eth1: mtu 1500 qdisc pfifo_fast state UP
group default qlen 1
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: esme: Add cleanup function to avoid cascade failure of tests
..
esme: Add cleanup function to avoid cascade failure of tests
In commit 6100b629e55ed4
Patch Set 1: Code-Review+2
Tested locally in an env where an esme test fails and then the next one used to
fail too due to the hanging old conn.
--
To view, visit https://gerrit.osmocom.org/3463
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Chang
Review at https://gerrit.osmocom.org/3463
esme: Add cleanup function to avoid cascade failure of tests
In commit 6100b629e55ed4aa319f46ad797741131b9da8e7 I assumed esme
already had a cleanup function, which doesn't seem to be the case. This
means if a test calls esme.connect() and fails afterwa
Patch Set 1: Code-Review+2
This commit was reverted a while ago because merge of the osmo-bts was delayed
for a while, and meanwhile removing the config option broke the tests. Now that
the osmo-bts commit is merged, tests are failing because the option doesn't
exist anymore. I rebased it on t
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-bts-trx config: remove settsc
..
osmo-bts-trx config: remove settsc
In osmo-bts change I51aeb17661dfd63ff347f7b2c0d7ffa383ec814c the settsc conf
Review at https://gerrit.osmocom.org/3462
osmo-bts-trx config: remove settsc
In osmo-bts change I51aeb17661dfd63ff347f7b2c0d7ffa383ec814c the settsc config
item is being removed. To be able to test it, drop the settsc option from the
config.
Change-Id: I58002a84b6b0104de4fb5c7cade27b263e375c1f
Review at https://gerrit.osmocom.org/3461
libmsc: gsm340_gen_oa_sub() may return negative value
gsm340_gen_oa() returns a negative value if the output buffer that the
caller passes is too small, so we have to check the return value of this
function.
Fixes: CID 174178
Fixes: CID 174179
Change-I
27 matches
Mail list logo
