Patch Set 7:
...and what with the build failure?
--
To view, visit https://gerrit.osmocom.org/4334
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2882b7ca31a3219c676986e85045fa08a425d7a
Gerrit-PatchSet: 7
Gerrit-Project: osmo-bsc
Patch Set 7: Code-Review-1
(11 comments)
https://gerrit.osmocom.org/#/c/4334/4/src/osmo-bsc/osmo_bsc_mgcp.c
File src/osmo-bsc/osmo_bsc_mgcp.c:
Line 130:
> I am not so sure about this. While developing this the OSMO_ASSERT() helped
yes, that's fine. Just consider that for the future. I
Patch Set 1: Code-Review+2
+2 for triviality
--
To view, visit https://gerrit.osmocom.org/4596
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e49ceba6b0a8dffd331e5707667d9bb007f3ec7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix compiler warnings: return 0 in main(), in 3 tests
..
fix compiler warnings: return 0 in main(), in 3 tests
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: debian/rules: show testsuite.log when tests are failing
..
debian/rules: show testsuite.log when tests are failing
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: vlr: rename auth_tuple_max_use_count to _reuse_
..
cosmetic: vlr: rename auth_tuple_max_use_count to _reuse_
The name
Neels Hofmeyr has submitted this change and it was merged.
Change subject: vty: drop deprecated 'logging level sms...'
..
vty: drop deprecated 'logging level sms...'
No need to drag legacy VTY from osmo-nitb to osmo-msc.
Neels Hofmeyr has submitted this change and it was merged.
Change subject: defaults: assign TMSI by default
..
defaults: assign TMSI by default
When using ciphering, the TMSI is an important part of the ciphering. To guard
Neels Hofmeyr has submitted this change and it was merged.
Change subject: vty: make auth tuple reuse configurable
..
vty: make auth tuple reuse configurable
Change-Id: Iba6253d9bf8d4a9d9f6f26ba045e6c7f0dc7f8f2
---
M
Neels Hofmeyr has submitted this change and it was merged.
Change subject: msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt
..
msc_vlr_tests: fix rebuild: rebuild when src/ libs were rebuilt
Before this, a code
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/Debian_8.0/x86_64
Package network:osmocom:latest/libosmocore failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest libosmocore
Last lines of build
Review at https://gerrit.osmocom.org/4602
drop osmo_sgsn.cfg from src/gprs dir
There is a semantically identical config in doc/examples/osmo-sgsn.
Change-Id: I9b9c502afbddcfc02ea70aa8317e0d2f37276c38
---
D src/gprs/osmo_sgsn.cfg
1 file changed, 0 insertions(+), 23 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4603
change default config filename to osmo-sgsn.cfg, not osmo_sgsn.cfg
All other Osmocom programs I know of have a default config file using a dash.
Comply.
Change-Id: If804da17a7481e79e000fe40ae0d9c4be9722e61
---
M src/gprs/sgsn_main.c
1 file changed, 1
Review at https://gerrit.osmocom.org/4601
cosmetic: use name 'mgw' instead of 'mgcpgw'
'mgcpgw' was a working title for the new 'osmo-mgw'. Rather use the name 'mgw'
now.
Change-Id: Icf65bd1daa52b280d73e56b6267b3c81ed1c5487
---
R src/osmo_gsm_tester/osmo_mgw.py
M
Review at https://gerrit.osmocom.org/4600
msc cfg: apply mgcp_client vty rename from 'mgcpgw' to 'mgw'
osmo-mgw.git is changing the mgcp_client_vty API to use 'mgw' instead of
'mgcpgw'. Fix builds after that patch is merged.
Depends: I1d43d42929dc9162e57640499526fb7cadbcfbe6
Change-Id:
Review at https://gerrit.osmocom.org/4598
mgcp client: vty: tweak doc strings
Fix errors like "remote bind address", mention 'MGW' instead of 'MGCP gateway',
minor typos and wording tweaks.
Change-Id: Ie1a408f9e651c5fb3424a84ceaaa603e20ad595c
---
M src/libosmo-mgcp-client/mgcp_client_vty.c
1
Review at https://gerrit.osmocom.org/4599
examples: apply mgcp_client vty rename from 'mgcpgw' to 'mgw'
osmo-mgw.git is changing the mgcp_client_vty API to use 'mgw' instead of
'mgcpgw'. Fix example configs after that patch is merged.
Depends: I1d43d42929dc9162e57640499526fb7cadbcfbe6
Review at https://gerrit.osmocom.org/4597
mgcp-client vty: use name 'mgw' instead of 'mgcpgw'
'mgcpgw' was a working title for the osmo-mgw. Before this takes hold out
there, let's rename the VTY commands to 'mgw'. I'd rather have some local
fallout in our testing environments now than drag
Review at https://gerrit.osmocom.org/4596
fix compiler warnings: return 0 in main(), in 3 tests
Change-Id: I9e49ceba6b0a8dffd331e5707667d9bb007f3ec7
---
M tests/gtp/gtpie_test.c
M tests/lib/in46a_test.c
M tests/lib/ippool_test.c
3 files changed, 3 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4595
osmocom-nightly-packages: Build latest libgtpnl
libgtpnl is the userspace library for using kenrel GTP-U support,
which is used by openggsn (and will be used by osmo-ggsn).
Change-Id: Iad600a36cb658bbd874b4587ec514f49703d6a45
---
M
Patch Set 5: Code-Review-1
(1 comment)
We hit this issue in one of our installations, so I'm glad to see a work to
resolve this. In that case though, we just increased the length of the
automatically generated extensions to make sure they never overflow.
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/4576/3/jobs/gerrit-verifications.yml
File jobs/gerrit-verifications.yml:
Line 44: combination_filter: '!(arch=="arm-none-eabi" &&
label=="FreeBSD_amd64")'
also drop this line
--
To view, visit
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: mobile: register the talloc context introspection command
..
mobile: register the talloc context introspection command
This change registers the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4593
to look at the new patch set (#2).
Enable GnuTLS fallback
On systems with GNU/Linux kernel older than 3.17 (Debian 8 "jessie" for
example) the osmo_get_rand_id() would always return
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3820
to look at the new patch set (#3).
Migrate from OpenSSL to osmo_get_rand_id()
This avoids potential licensing incompatibility and makes integration of
Debian packaging patches easier.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3819
to look at the new patch set (#3).
Migrate from OpenSSL to osmo_get_rand_id()
This avoids potential licensing incompatibility and makes integration of
Debian packaging patches easier.
Review at https://gerrit.osmocom.org/4593
Enable GnuTLS fallback
On systems with GNU/Linux kernel older than 3.17 (Debian 7 "wheezy" for
example) the osmo_get_rand_id() would always return failure. To support
such systems, let's add fallback code which uses GnuTLS library. It have
to be
Review at https://gerrit.osmocom.org/4592
utils: move linked libraries into common variable
Change-Id: I54f4e439cc232d926b42ddba9648d4f5e7487c3e
---
M utils/Makefile.am
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Review at https://gerrit.osmocom.org/4591
Move additional libraries to appropriate place
According to
https://www.gnu.org/software/automake/manual/automake.html#Libtool-Flags
the libraries supposed to be added to *_LDADD or *_LIBADD
while *_LDFLAGS should contain additional libtool linking
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/Debian_8.0/x86_64
Package network:osmocom:latest/libosmocore failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest libosmocore
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/aarch64
Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-msc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/armv7l
Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:latest osmo-msc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_9.0/armv7l
Package network:osmocom:latest/osmo-bsc failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:latest osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/libosmo-netif failed to build in
xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmo-netif
Last
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_9.0/aarch64
Package network:osmocom:latest/osmo-bsc failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:latest osmo-bsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/Debian_9.0/aarch64
Package network:osmocom:latest/libasn1c failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:latest libasn1c
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/xUbuntu_17.04/x86_64
Package network:osmocom:latest/libasn1c failed to build in xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest libasn1c
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/xUbuntu_17.04/i586
Package network:osmocom:latest/libasn1c failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:latest libasn1c
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/xUbuntu_17.10/x86_64
Package network:osmocom:latest/libasn1c failed to build in xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest libasn1c
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/xUbuntu_16.10/i586
Package network:osmocom:latest/libasn1c failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:latest libasn1c
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/xUbuntu_16.04/i586
Package network:osmocom:latest/libasn1c failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:latest libasn1c
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/xUbuntu_16.10/x86_64
Package network:osmocom:latest/libasn1c failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest libasn1c
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/Debian_9.0/i586
Package network:osmocom:latest/libasn1c failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:latest libasn1c
Last lines of build log:
[ 191s]
Max has abandoned this change.
Change subject: Bump version: 0.0.7 → 0.0.8
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/4318
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: abandon
Max has abandoned this change.
Change subject: deb: install .service files
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/4315
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: abandon
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4576
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c6d2a17c3cf9d8c78c3675995493e30cbc6be0d
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Max has abandoned this change.
Change subject: Initialize logging before initializing rate_ctr
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/4411
To unsubscribe, visit https://gerrit.osmocom.org/settings
Max has abandoned this change.
Change subject: Move all rate counter related code together
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/4413
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4551
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbdedc1581fa23abe9ed99cef3918592b25f30b3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4489
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8aa657c4bf62ef62549fbe9dc15ce3fb018d8d9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: jenkins: use osmo-clean-workspace.sh before and after build
..
jenkins: use osmo-clean-workspace.sh before and after build
See osmo-ci change
53 matches
Mail list logo
