Neels Hofmeyr has submitted this change and it was merged.
Change subject: mgcp_client_test makefile: add update_exp target
..
mgcp_client_test makefile: add update_exp target
Change-Id:
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5111
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cda082c46ab5734873cbb39b313037d86777589
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1:
hmm, good idea actually. I'll try to generalize next time I come across it.
--
To view, visit https://gerrit.osmocom.org/5111
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cda082c46ab5734873cbb39b313037d86777589
Neels Hofmeyr has submitted this change and it was merged.
Change subject: mgcp_client: add transaction cleanup
..
mgcp_client: add transaction cleanup
So far, if an MGCP message is sent, the transaction gets enqueued, but
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5155
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74fbcd7e853e24b1225ecc4c19304134b8467c9b
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5156
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I881d3e87daa19f4e6f4f5bd30fe95906129e60ef
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Put useful information in RTCP SDES.
..
Put useful information in RTCP SDES.
The RTCP Sender Description is supposed to contain useful information
to
Review at https://gerrit.osmocom.org/5156
mobile: Return the name of the configured "MS"
In lua osmo.ms():name() will print the name/number of the MS. This
can be used by scripting code to use in events and then be analyzed.
Change-Id: I881d3e87daa19f4e6f4f5bd30fe95906129e60ef
---
M
Review at https://gerrit.osmocom.org/5155
mobile: Simplify code and check the cb ref in load_cb
Change parameters and check if the cb_ref is valid or not.
Change-Id: I74fbcd7e853e24b1225ecc4c19304134b8467c9b
---
M src/host/layer23/src/mobile/script_lua.c
1 file changed, 14 insertions(+), 21
Harald Welte has submitted this change and it was merged.
Change subject: Add a new osmo_rtp_set_source_desc() function to set the RTCP
SDES items
..
Add a new osmo_rtp_set_source_desc() function to set the RTCP SDES items
Harald Welte has submitted this change and it was merged.
Change subject: Edit Project Config
..
Edit Project Config
Change-Id: If483e89aeb53426fac3a4d57bdecc00025cf174b
---
M project.config
1 file changed, 1 insertion(+), 0
Review at https://gerrit.osmocom.org/5152
Edit Project Config
Change-Id: I41a0a5caede1145d06c44a324d00bb6f71a9ca49
---
0 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/52/5152/1
--
To view, visit https://gerrit.osmocom.org/5152
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5154
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If483e89aeb53426fac3a4d57bdecc00025cf174b
Gerrit-PatchSet: 2
Gerrit-Project: gapk
Gerrit-Branch:
Review at https://gerrit.osmocom.org/5154
Edit Project Config
Change-Id: If483e89aeb53426fac3a4d57bdecc00025cf174b
---
M project.config
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/54/5154/2
diff --git a/project.config
Edit Project Config
Change-Id: If483e89aeb53426fac3a4d57bdecc00025cf174b
---
M project.config
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/54/5154/2
diff --git a/project.config b/project.config
index 563d43e..ecbce11 100644
---
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5152
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41a0a5caede1145d06c44a324d00bb6f71a9ca49
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: rsl.c: Log RTP socket related errors as DRTP, not DRSL
..
rsl.c: Log RTP socket related errors as DRTP, not DRSL
The respective errors/events occur as a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5150
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee575121248ea541f7abc49055e49ec2d30904c0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
> I think lynxis saw this one last week
yes, that' why I fixed it and I'm linking to the Osmocom redmine issue you
created :)
--
To view, visit https://gerrit.osmocom.org/5151
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1:
I think lynxis saw this one last week
--
To view, visit https://gerrit.osmocom.org/5151
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bcac5fcebfc24760432eb66be258a01d78f65f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Review at https://gerrit.osmocom.org/5151
ggsn.c: Fix byte order of IPCP IPv4 DNS servers
... this probably didn't show up as 8.8.8.8 is dual-endian. doh!
The address was already in network byte order, but msgb_put_u32 "of
course" expects host byte order, ending up the wrong way in the actual
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5139
to look at the new patch set (#4).
Remove utils imported from openbsc, fix building remaining util smpp_mirror
Related: OS#2522
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5139
to look at the new patch set (#3).
Remove utils imported from openbsc, fix building remaining util smpp_mirror
Change-Id: If7e1af11cdac8587bb4d66fb4eacee4b79945359
---
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5138
to look at the new patch set (#2).
Add missing CFLAGS
Change-Id: I67b5d797a80b55e01dcdbb8c782748b049cf9199
---
M src/libcommon-cs/Makefile.am
M src/libcommon/Makefile.am
Patch Set 1:
(2 comments)
> (2 comments)
https://gerrit.osmocom.org/#/c/5138/1/src/utils/Makefile.am
File src/utils/Makefile.am:
Line 12:$(LIBOSMOSCCP_CFLAGS) \
> which of the utilities needs SCCP?
Correct, this is unneeded, I'll fix and resubmit.
Line 127:
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Move starting/stopping a MS into a separate function
..
mobile: Move starting/stopping a MS into a separate function
Move the check if within
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Use new LOGPSRCC macro to print multiple values
..
mobile: Use new LOGPSRCC macro to print multiple values
We need continuation to avoid
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Add LUA as debug category to the applications
..
mobile: Add LUA as debug category to the applications
Change-Id:
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Add initial support for scripting support
..
mobile: Add initial support for scripting support
Right now the script will be executed once it
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Notify MM status changes and generate primitive op ind
..
mobile: Notify MM status changes and generate primitive op ind
Notify once the mm
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Inform the primitive layer about status and new sms
..
mobile: Inform the primitive layer about status and new sms
Inform the layer about new
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Create "ms" singleton for struct osmocom_ms
..
mobile: Create "ms" singleton for struct osmocom_ms
Make the MS the script is associated with
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Add osmo.timeout for lua code to have timeouts
..
mobile: Add osmo.timeout for lua code to have timeouts
Allow to callback into lua code
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Search for lua5.3 and link to it
..
mobile: Search for lua5.3 and link to it
I will be adding a high-level async scripting interface to the
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Begin with a primitive interface on top of the code
..
mobile: Begin with a primitive interface on top of the code
We want the script
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Directly inform the primitive layer about an event
..
mobile: Directly inform the primitive layer about an event
Forward started/shutdown
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Fix compiler warning on printing ptrdiff_t
..
mobile: Fix compiler warning on printing ptrdiff_t
The "msg->tail - msg->l4h" subtract two
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5150
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee575121248ea541f7abc49055e49ec2d30904c0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Declare struct osmocom/vty to be self includeable
..
mobile: Declare struct osmocom/vty to be self includeable
In file included from
Review at https://gerrit.osmocom.org/5150
UHDDevice.cpp: add USRP B205mini support
The B205mini is similar to the B200mini and runs OsmoTRX just
fine, so let's make OsmoTRX recogonize and support it too.
Change-Id: Iee575121248ea541f7abc49055e49ec2d30904c0
---
M Transceiver52M/UHDDevice.cpp
1
Patch Set 3: Code-Review+1
I don't have equipment right now to test this, but the code looks good on the
first glance.
Just one comment - is this requirement of sending the first frame number
documented in the parameters of the relevant functions? That would be great to
have it there to
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-octphy: Remove bogus warning about BS_AG_BLKS_RES
..
osmo-bts-octphy: Remove bogus warning about BS_AG_BLKS_RES
Contrary to osmo-bts-sysmo, the
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: add missing log prefix
..
cosmetic: add missing log prefix
the log messages have prefixes that mark important phases (CRCX/BTS,
etc...). Some
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: correct sourcecode formatting
..
cosmetic: correct sourcecode formatting
add missing line break
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: use fsm pointer from parameter list
..
cosmetic: use fsm pointer from parameter list
the parameter list of osmo-fsm callbacks contains a
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: do not cast void pointer
..
cosmetic: do not cast void pointer
remove the casting of void *data, just assign directly
Change-Id:
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4984
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e37630e315b3602da2f14e2364bb76be9dd2894
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5143
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia356dc2a8d5120f9d6262bf8eb25c32fe71e76c9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Describe our normal (non-gerrit) build jobs in
jenkins-job-builder
..
Describe our normal (non-gerrit) build jobs in jenkins-job-builder
after the
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5144
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd950660cdc3417e82b0a8f4ce2b1efde880cb7a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: jobs: master-builds: osmo-bsc is now also a downstream of
osmo-mgw
..
jobs: master-builds: osmo-bsc is now also a downstream of osmo-mgw
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: jobs: master-builds: apply various initial fixes
..
jobs: master-builds: apply various initial fixes
libosmo-sccp, osmo-ggsn: The osmo-gsm-tester builds
Harald Welte has submitted this change and it was merged.
Change subject: jobs: master-builds: libosmo-sigtran should trigger bsc and iuh
..
jobs: master-builds: libosmo-sigtran should trigger bsc and iuh
osmo-iuh in turn
Harald Welte has submitted this change and it was merged.
Change subject: jobs: rename normal-builds.yml to master-builds.yml
..
jobs: rename normal-builds.yml to master-builds.yml
Also apply the rename in the job names
Harald Welte has submitted this change and it was merged.
Change subject: jobs: master-branches: trigger sgsn from iuh
..
jobs: master-branches: trigger sgsn from iuh
osmo-sgsn uses libosmo-ranap and hence should be triggered
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5140
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If623e573e49d4f1a409139c112afbc34e4cc450e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5142
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c63108bd845ee723d565c34e930bb68bef
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4737
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I456f6b6b5e1a14ed6c8cb0dcc5140093d3c61ef6
Gerrit-PatchSet: 9
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5141
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2ad9c90a0986d1304cd53383d3df5b375f23ac8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5100
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4aa5ff212fa6bead8f620abaecc6a0b51a99fec
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5101
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9dcf7fd9116985aa060ba027ba74107a19223a
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5041
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9348b3ed71a8490c03edda954402ab954f645b7c
Gerrit-PatchSet: 4
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4840
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3ace33d6ba4e904b1ff8e271a02d6334a58
Gerrit-PatchSet: 7
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5041
to look at the new patch set (#4).
mobile: Declare struct osmocom/vty to be self includeable
In file included from settings.c:27:0:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4737
to look at the new patch set (#9).
mobile: Add initial support for scripting support
Right now the script will be executed once it is loaded. Make sure
to write it into
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5100
to look at the new patch set (#3).
mobile: Move starting/stopping a MS into a separate function
Move the check if within the mobile app there is no other active
MS using
Review at https://gerrit.osmocom.org/5149
mobile: Fix compiler warning on printing ptrdiff_t
The "msg->tail - msg->l4h" subtract two unsigned char*
pointers and should result in a ptrdiff_t. Fix the
compiler warning by using "%ti" in the printf.
Fixes:
gsm411_sms.c: In function
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5101
to look at the new patch set (#3).
mobile: Notify MM status changes and generate primitive op ind
Notify once the mm state has been changed. Unfortunaley one state
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4840
to look at the new patch set (#7).
mobile: Create "ms" singleton for struct osmocom_ms
Make the MS the script is associated with accessible to lua. Provide
access to IMSI
Holger Freyther has restored this change.
Change subject: mobile: Declare struct osmocom/vty to be self includeable
..
Restored
Not a WIP patch ;)
--
To view, visit https://gerrit.osmocom.org/5041
To unsubscribe, visit
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/5138/1/src/utils/Makefile.am
File src/utils/Makefile.am:
Line 12:$(LIBOSMOSCCP_CFLAGS) \
which of the utilities needs SCCP?
Line 127: $(LIBOSMOSCCP_CFLAGS) \
for sure, meas_json doesn't need SCCP or MGCP,
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5139
to look at the new patch set (#2).
Remove utils imported from openbsc, fix building remaining util smpp_mirror
Related: OS#2522
Change-Id: If7e1af11cdac8587bb4d66fb4eacee4b79945359
---
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5139
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7e1af11cdac8587bb4d66fb4eacee4b79945359
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 4: Code-Review+1
let's wait for Minh or somebody else to be able to re-test this.
--
To view, visit https://gerrit.osmocom.org/5030
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I929ce3703dc57acf8db569ae0e346265644d0b3c
Hello Max, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5030
to look at the new patch set (#4).
DTX: avoid illegal character contained in DTX FSM allocation which causes BTS
crash
Problem:
lchan->tch.dtx.dl_amr_fsm struct
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5136
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5145
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice794f9e0c6caeea1c67520c12efbfa375d1fb82
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5145
to look at the new patch set (#2).
Add a new osmo_rtp_set_source_desc() function to set the RTCP SDES items
This allows the users of libosmotrau to set the content of the SDES
items to
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5145/1/src/trau/osmo_ortp.c
File src/trau/osmo_ortp.c:
Line 500: LOGP(DLMIB, LOGL_DEBUG, "%s(rs=%p, len=%u, marker=%d,
duration=%u, ts=%u\n",
unrelated change slipped in
--
To view, visit https://gerrit.osmocom.org/5145
To
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5136
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1065ae9c400bb5240a63ab8213aee59aeb9ceeff
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5147
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6ce7188354d3a0517661c9648854ec829ef1cac
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5148
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1038b8dc57bdaf05493cd8479355b960275ea41
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5146
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52e6f9865492a2f757a37860eb92a3dc49e174ef
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5148
osmo-bts-octphy: Remove bogus warning about BS_AG_BLKS_RES
Contrary to osmo-bts-sysmo, the OCTPHY-2G does not have different L1
SAPI for AGCH and PCH. It uses cOCTVC1_GSM_SAPI_ENUM_PCH_AGCH for both,
and we convert that to the cbits=0x12 (Downlink
Put useful information in RTCP SDES.
The RTCP Sender Description is supposed to contain useful information
to identify the source of the RTP stream. So far, it only contained
compile-time default data of libortp. Let's put the BTS UnitID, the
lchan number and the OsmoBTS version in there.
rsl.c: Log RTP socket related errors as DRTP, not DRSL
The respective errors/events occur as a result of calling osmo_rtp_*
API, and are clearly more fitting into the DRTP category than the DRSL,
even though the respective actions are triggered by RSL.
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5136
to look at the new patch set (#3).
osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS
The upper layers (L1SAP, the common part of L1) *always* require frame
numbers in the
Review at https://gerrit.osmocom.org/5146
rsl.c: Log RTP socket related errors as DRTP, not DRSL
The respective errors/events occur as a result of calling osmo_rtp_*
API, and are clearly more fitting into the DRTP category than the DRSL,
even though the respective actions are triggered by RSL.
Review at https://gerrit.osmocom.org/5147
Put useful information in RTCP SDES.
The RTCP Sender Description is supposed to contain useful information
to identify the source of the RTP stream. So far, it only contained
compile-time default data of libortp. Let's put the BTS UnitID, the
lchan
Review at https://gerrit.osmocom.org/5145
Add a new osmo_rtp_set_source_desc() function to set the RTCP SDES items
This allows the users of libosmotrau to set the content of the SDES
items to something more useful than their compile-time defaults.
Change-Id:
Patch Set 1:
> are we sure that the individual programs each actually use all of
> the libraries you have listed in their CFLAGS now? We typically
> don't list all libraries' CFLAGS for each of the programs/libraries.
> We only do so, if they actually use definitions/symbols from that
>
Harald Welte has submitted this change and it was merged.
Change subject: measurment.c: Introduce INFO category for DMEAS logging
..
measurment.c: Introduce INFO category for DMEAS logging
There's no point in either having
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/5141/2/jobs/master-builds.yml
File jobs/master-builds.yml:
Line 1: # All master branch verification builds,
https://jenkins.osmocom.org/jenkins/view/master/
since you're referring to a master "view", it makes sense to also
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5140
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If623e573e49d4f1a409139c112afbc34e4cc450e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5142
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c63108bd845ee723d565c34e930bb68bef
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5143
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia356dc2a8d5120f9d6262bf8eb25c32fe71e76c9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5144
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd950660cdc3417e82b0a8f4ce2b1efde880cb7a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1:
are we sure that the individual programs each actually use all of the libraries
you have listed in their CFLAGS now? We typically don't list all libraries'
CFLAGS for each of the programs/libraries. We only do so, if they actually use
definitions/symbols from that library.
--
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5139
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7e1af11cdac8587bb4d66fb4eacee4b79945359
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
99 matches
Mail list logo
