Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/5684/2/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:
Line 651: return hex2oct(mcc[1] & mcc[0] & mnc[2] & mcc[2] & mnc[1] &
mnc[0]);
looks proper now, except for the case of a two-digit MNC, where
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5689
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4dda6938e1650b4bcaac45809a4763f86f5a9794
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
Curious. As committer you should be able to abandon the commit regardless of
group membership. Is "abandon" button is missing from web ui?
--
To view, visit https://gerrit.osmocom.org/5690
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5689
to look at the new patch set (#3).
TLVP_PRESENT() should not return TRUE after tlv_parse() fails.
If the length provided in the patcket exceeds the buffer length,
tlv_parse() returns
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5689
to look at the new patch set (#2).
TLVP_PRESENT() should not return TRUE after tlv_parse() fails.
If the length provided in the patcket exceeds the buffer length,
tlv_parse() returns
Patch Set 1: Code-Review-1
The commit was added solely to discard it. Trying to do that but I suppose I
don't have enough rights to do that. Is group "gr-gsm Reviewers" linked to
gr-gsm project.
--
To view, visit https://gerrit.osmocom.org/5690
To unsubscribe, visit
Review at https://gerrit.osmocom.org/5690
Just a change to be discarded in gerrit
Change-Id: Ice89f3757e9ef672e7b8910f19d5e9512f94ba04
---
M TESTING.md
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/90/5690/1
diff --git
Review at https://gerrit.osmocom.org/5689
TLVP_PRESENT() should not return TRUE after tlv_parse() fails.
If the length provided in the patcket exceeds the buffer length,
tlv_parse() returns -2 but leaves tlv.val and tlv.len initializd.
Many callers of tlv_parse() do not check its return
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/5424/2/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:
Line 328: msg->l3h = msgb_put(msg, TLVP_LEN(,
GSM0808_IE_LAYER_3_INFORMATION));
msgb_put() will panic if the length value provided in the data packet
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/5367/4/src/bts.cpp
File src/bts.cpp:
Line 1039: new_tbf->state_flags &= ~(1 <<
GPRS_RLCMAC_FLAG_CCCH);
We could remove this line as well, couldn't we? The flag is already cleared by
check_n_clear if we enter this
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/5421/3/include/osmocom/codec/ecu.h
File include/osmocom/codec/ecu.h:
Line 9: uint8_t frame_backup[40];
Still unsure about this. I just used the length which
is bigger than known values of supported codecs.
Any ideas?
--
To
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5688
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie90e85ca8d9ec3175a58dde60525e0b7d6daf608
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5687
libgsmhr/libgsmhr.c: fix memory leak after gsmhr_exit()
During the HR codec initialization, a part of the state is
allocated, but not freed at exit. Let's fix this.
Found during debugging with Valgrind:
4,932 bytes in 1 blocks are definitely lost in
Review at https://gerrit.osmocom.org/5688
Fix BENCHMARK_STOP call for both AMR and FR codecs
The BENCHMARK_STOP should be called with a correct codec type and
a correct operation type (encode or decode). Otherwise the results
could be incorrect.
Change-Id:
Patch Set 5:
(2 comments)
https://gerrit.osmocom.org/#/c/5652/5/src/gb/gprs_bssgp.c
File src/gb/gprs_bssgp.c:
Line 256: gsm48_encode_ra((struct gsm48_ra_id *)buf, raid);
This code could cause unaligned access on some hardware platforms because we do
not know if 'buf' is already aligned.
Patch Set 2:
Hi Max,
I definitely like the idea of using the '/usr/bin/env STH'
instead of hardcoded '/usr/bin/python2' binary reference.
But I am not sure, should we immediately reject Python 2
support? Is it discussed anywhere?
--
To view, visit https://gerrit.osmocom.org/5657
To
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5678
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d51e35424a26eab7d38152e13f3ac6fd3f3997c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Max has submitted this change and it was merged.
Change subject: Send email on update-* job failures
..
Send email on update-* job failures
Notify intern@ if either update-osmo-ci or update-osmo-python jobs
failed. Those are
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5683
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf8baf4bf5670efaa8689ca7386597fe2797bda
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/5684/1/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:
Line 651: return hex2oct(mcc[1] & mcc[0] & mnc[2] & mcc[2] & mnc[1] &
mnc[0]);
> my doubt is confirmed by http://www.etsi.org/deliver/etsi_ts/148000_148099/
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5684
to look at the new patch set (#2).
Fix f_enc_mcc_mnc() to return a properly encoded MCC/MNC triple octet.
With help from Daniel Willmann.
Change-Id:
Patch Set 1:
The odd thing I don't understand yet is why we should replace H only in some
places while in others it seems to break egprs. Any ideas?
--
To view, visit https://gerrit.osmocom.org/5686
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Review at https://gerrit.osmocom.org/5686
Fix wrong encoding of LH bits
Introduce functions to set L/H bits using bitvec_set_bit() with proper
enum from libosmocore instead of bitvec_write_field() with hardcoded
numeric values. Adjust tests accordingly. While at it, clarify
spec-related
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5685
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b6e03087fc2dfecb6235c5ed1494d3c9b4bbf0e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5684/1/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:
Line 651: return hex2oct(mcc[1] & mcc[0] & mcc[2] & mcc[2] & mnc[1] &
mnc[0]);
> (commented too fast, reading the spec now)
my doubt is confirmed by
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/5684
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a5317e425d15acd463aa94c683676cacd54e0b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5424
to look at the new patch set (#2).
libmsc: a_iface_bssap.c: Fix compilation warning
Fixes following compilation warning:
osmo-msc/src/libmsc/a_iface_bssap.c:328:11:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: oml.c: Fix use of htons instead of ntohs
..
oml.c: Fix use of htons instead of ntohs
In oml_ipa_mo_set_attr_cell, as well as we do in other set
Review at https://gerrit.osmocom.org/5685
Show the BTS number for outgoing paging commands in debug log.
Change-Id: I7b6e03087fc2dfecb6235c5ed1494d3c9b4bbf0e
---
M src/libbsc/paging.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5684/1/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:
Line 651: return hex2oct(mcc[1] & mcc[0] & mcc[2] & mcc[2] & mnc[1] &
mnc[0]);
> IIRC there is an 0xf involved ... seems to me we want what gsm48_construct_
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5684/1/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:
Line 651: return hex2oct(mcc[1] & mcc[0] & mcc[2] & mcc[2] & mnc[1] &
mnc[0]);
> mcc[2] twice? ... oh wait, this is ttcn, until I realized I was completely
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5684/1/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:
Line 651: return hex2oct(mcc[1] & mcc[0] & mcc[2] & mcc[2] & mnc[1] &
mnc[0]);
> mcc[2] twice? ... oh wait, this is ttcn, until I realized I was completely
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5684/1/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:
Line 651: return hex2oct(mcc[1] & mcc[0] & mcc[2] & mcc[2] & mnc[1] &
mnc[0]);
mcc[2] twice? ... oh wait, this is ttcn, until I realized I was completely
Patch Set 1:
See https://gerrit.osmocom.org/#/c/5684/ instead.
--
To view, visit https://gerrit.osmocom.org/5682
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3970382450dd728db68845a6414add8e027706ba
Gerrit-PatchSet: 1
Gerrit-Project:
Review at https://gerrit.osmocom.org/5684
Fix f_enc_mcc_mnc() to return a properly encoded MCC/MNC triple octet.
With help from Daniel Willmann.
Change-Id: I99a5317e425d15acd463aa94c683676cacd54e0b
Related: OS#2754
---
M library/BSSMAP_Templates.ttcn
1 file changed, 1 insertion(+), 1
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5680
to look at the new patch set (#2).
Use gsm48_encode_ra() for RAI encoding
It has stricter type signature which increase the chance of spotting
misuse either via compiler warning or
Review at https://gerrit.osmocom.org/5683
cosmetic: update ipaccess_bts_handle_ccm()
* mark internal function parameter as const
* log unit IDs
Change-Id: Ifcf8baf4bf5670efaa8689ca7386597fe2797bda
---
M src/input/ipaccess.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull
Stefan Sperling has abandoned this change.
Change subject: Fix f_enc_mcc_mnc() to return a properly encoded MCC/MNC triple
octet.
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/5682
To unsubscribe, visit
Stefan Sperling has abandoned this change.
Change subject: HACK: Work around IPA CCM bug in OsmoBSC
..
Abandoned
Accidental submission.
--
To view, visit https://gerrit.osmocom.org/5681
To unsubscribe, visit
Review at https://gerrit.osmocom.org/5681
HACK: Work around IPA CCM bug in OsmoBSC
OsmoBSC has some misunderstanding about how IPA CCM works and hence
we need to work around this until that bug is fixed in OsmoBSC.
See https://osmocom.org/issues/2718
Change-Id:
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5676
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I039fac5ca9cd41812225f0982ccc9289f11c6f1a
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/5630/2//COMMIT_MSG
Commit Message:
Line 16: https://gerrit.osmocom.org/#/c/5628/
we usually add a tag like
Depends: (libosmocore)
--
To view, visit https://gerrit.osmocom.org/5630
To unsubscribe, visit
Review at https://gerrit.osmocom.org/5680
Use gsm48_encode_ra() for RAI encoding
It has strickter type signature which increase the chance of spotting
misuse either via compiler warning or with automated scan. This also
paves the way for gsm48_construct_ra() deprecation in libosmocore.
Max has submitted this change and it was merged.
Change subject: Use existing function for TLLI encoding
..
Use existing function for TLLI encoding
Use bssgp_msgb_tlli_put() instead of copy-pasted code.
Change-Id:
Patch Set 1:
> > in little-endian hosts, htons and ntohs are actually the same
> function
>
> Does it mean that on BE host it won't work? Nor sure if anyone ever
> tested it actually, just curious because it confuses me too.
AFAIK on BE hosts, they are still the same function, but in this
Max has submitted this change and it was merged.
Change subject: RSL: print link state per-TRX
..
RSL: print link state per-TRX
Change-Id: Ie6fad70b4b11d0bb4927b22e32e842422658ba53
Fixes: OS#2715
---
M src/libbsc/bsc_vty.c
1
Max has submitted this change and it was merged.
Change subject: vty: fix OML link state printing
..
vty: fix OML link state printing
Always print newline regardless of BTS uptime availability.
Change-Id:
Max has submitted this change and it was merged.
Change subject: cosmetic: remove duplicated code
..
cosmetic: remove duplicated code
Change-Id: I16c446ef7dc66769826f6e8ae118d8b07bbf6930
---
M src/libbsc/bsc_vty.c
M
Max has submitted this change and it was merged.
Change subject: Add function to properly encode RAI
..
Add function to properly encode RAI
Add gsm48_encode_ra() which takes appropriate struct as [out] parameter
instead of
Max has submitted this change and it was merged.
Change subject: Fix RAI construction
..
Fix RAI construction
The gsm48_construct_ra() expect 6-byte buffer while ra_id.digits is
3-byte buffer. The function fills in LAC and RAC
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5651
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfda930012c792452f9fd695ed7acf46365f1df
Gerrit-PatchSet: 5
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5652
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5655
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06d60566a19dcae701f8648c19fbd8db6d586f77
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5658
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c446ef7dc66769826f6e8ae118d8b07bbf6930
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5660
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib80049fe66de17bc7acfbb774a30075f40a44dee
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5659
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6fad70b4b11d0bb4927b22e32e842422658ba53
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review-1
Let's not merge this until OS#2821 is fixed.
--
To view, visit https://gerrit.osmocom.org/5661
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f845420c0b23f81b076ef6a403d5969260811a
Gerrit-PatchSet: 1
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5657
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d34aed124b00c5dd2ab1bcc84bbfa8c620282cc
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5661
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f845420c0b23f81b076ef6a403d5969260811a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5664
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42bd3dc601465a4ac6a6e2bf8c4af736547d4838
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: a_iface_tx_assignment: fix log lvl for "Sending Assignment..."
..
a_iface_tx_assignment: fix log lvl for "Sending Assignment..."
Change-Id:
Patch Set 2: Code-Review+1
I'll update nightly jenkins job once this is merged and sdk is rebuilt.
--
To view, visit https://gerrit.osmocom.org/5676
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: abisip-find: add --interval option
..
abisip-find: add --interval option
Change-Id: I9540054bdda185b2585209289cee565f61f33dcf
---
M
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5590
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9540054bdda185b2585209289cee565f61f33dcf
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: error log: sccp_scoc.c: log failure to create/resolve conn_id
..
error log: sccp_scoc.c: log failure to create/resolve conn_id
Tweak the FIXMEs to
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5572
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib235ff8e264aaf0c2e9794f464a3ba7b54816f3d
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1:
> in little-endian hosts, htons and ntohs are actually the same function
Does it mean that on BE host it won't work? Nor sure if anyone ever tested it
actually, just curious because it confuses me too.
--
To view, visit https://gerrit.osmocom.org/5675
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I144175b89f8058f6f8dedfa931c6768d9c43b70e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: gprs_gmm: Convert warning message to pragma message
..
gprs_gmm: Convert warning message to pragma message
This way we can enable -Werror in builds to
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: tests: sgsn_test: Use proper formatting and remove
uneeded semicolons
..
cosmetic: tests: sgsn_test: Use proper formatting and remove uneeded
Harald Welte has submitted this change and it was merged.
Change subject: tests: sgsn_test: Define wrap APIs with correct parameters
..
tests: sgsn_test: Define wrap APIs with correct parameters
Fixes following compilation
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5669
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0819026a99f45df96ee6de26a71c16128e79cb8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: gprs_gmm: Remove trailing whitespace
..
cosmetic: gprs_gmm: Remove trailing whitespace
Change-Id: Ie2466268fbc4699a366856d467660b17e3f7e307
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5671
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2b9a618f4219df9e013095beff52c20aacbc79e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5670
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2466268fbc4699a366856d467660b17e3f7e307
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Max has submitted this change and it was merged.
Change subject: Print FN delta on L1 errors
..
Print FN delta on L1 errors
Change-Id: Ieb99c970eafb25b504c2b85221fb12d5a3c39789
---
M src/common/l1sap.c
1 file changed, 2
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5667
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fcb3d460d8becb4cc917fc8d27bfc7e49d50b90
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo_bsc_bssap.c: Fix discard of const qualifier in assignment
..
osmo_bsc_bssap.c: Fix discard of const qualifier in assignment
Fixes following
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5674
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeab5a822d50ac1267362f57196b80073a7901f9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4900
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d47b8a27f683060a2facf2dbecff8d00c19ce9
Gerrit-PatchSet: 4
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5675
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf65f8a4b871b0fa2e84ad6cd2188d4e34f704b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Max has submitted this change and it was merged.
Change subject: Remove osmotestvty.py from python 3 installation
..
Remove osmotestvty.py from python 3 installation
This script is actually not python 3 compatible yet despite
Harald Welte has submitted this change and it was merged.
Change subject: osmo-mgw: Use libosmocore socket abstraction
..
osmo-mgw: Use libosmocore socket abstraction
There's no need for us to use the sockets API directly: We
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5679
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb99c970eafb25b504c2b85221fb12d5a3c39789
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5662
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a40960920dbc594192530c3a145f9a5d2a9c81
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5679
Print FN delta on L1 errors
Change-Id: Ieb99c970eafb25b504c2b85221fb12d5a3c39789
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/79/5679/1
diff --git
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5678
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d51e35424a26eab7d38152e13f3ac6fd3f3997c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5677
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief11b75acc973dc7aeaac9c2298a21dc5390efe4
Gerrit-PatchSet: 2
Gerrit-Project: python/osmo-python-tests
Review at https://gerrit.osmocom.org/5678
Send email on update-* job failures
Notify intern@ if either update-osmo-ci or update-osmo-python jobs
failed. Those are essential for our CI and test infrastructure so we
should look into related failures right away.
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5677
to look at the new patch set (#2).
Remove osmotestvty.py from python 3 installation
This script is actually not python 3 compatible yet despite passing
current tests. Let's not install
Review at https://gerrit.osmocom.org/5677
Remove osmotestvty.py from python 3 installation
This script is actually not python 3 compatible yet despite passing
current tests. Let's not install it for python 3 until we can figure out
a way to catch this incompatibility with test code.
meta-toolchain-osmo: Create valid symlink independent of poky version
Some automated jenkins jobs may want to download latest generated SDK
built nightly with latest poky version. As the SDK filename depends on
the poky version, if the poky version is bumped (eg. 2.3.1->2.3.2) then
the jenkins
Review at https://gerrit.osmocom.org/5676
meta-toolchain-osmo: Create valid symlink indepdenent of poky version
Some automated jenkins jobs may want to download latest generated SDK
built nightly with latest poky version. As the SDK filename depends on
the poky version, if the poky version is
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5662/1/src/gprs/gprs_llc.c
File src/gprs/gprs_llc.c:
Line 375: if (!(msgb_tlli(msg) == mmctx->gb.llme->tlli
> Global negation is harder to read and I don't think we use this style anywh
to show that the patch does not modify
Patch Set 1:
> That's odd. How was it working before? Do we need corresponding fix
> on the BSC side?
I'm always confused by bit/byte-order stuff, but afaiu in little-endian hosts,
htons and ntohs are actually the same function which basically do a swap
between first and second byte, so the
Patch Set 1:
I think this should come before Werror patch.
--
To view, visit https://gerrit.osmocom.org/5673
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5667
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fcb3d460d8becb4cc917fc8d27bfc7e49d50b90
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1:
I think we should just drop the warning completely and make a ticket to track
the issue (if it's not exist already). Using source code as a tracker
replacement never really worked.
--
To view, visit https://gerrit.osmocom.org/5671
To unsubscribe, visit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5670
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2466268fbc4699a366856d467660b17e3f7e307
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1:
That's odd. How was it working before? Do we need corresponding fix on the BSC
side?
--
To view, visit https://gerrit.osmocom.org/5675
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
1 - 100 of 111 matches
Mail list logo
