libosmocore[master]: gsm0480: modify USSD structures to support external handling

Patch Set 4: Code-Review+1 Sorry,missed that patch -- To view, visit https://gerrit.osmocom.org/3374 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f8972b86cd4dcb54b643a24b5794a87c8758073 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore

libosmocore[master]: gsm0480: increase the MAX_LEN_USSD_STRING to 182

Patch Set 3: Code-Review-1 Please move the description of this calculation from the commit message to a comment. It should be easily understood when you browse the code. -- To view, visit https://gerrit.osmocom.org/5712 To unsubscribe, visit https://gerrit.osmocom.org/settings

libosmocore[master]: gsm0480: modify USSD structures to support external handling

Patch Set 4: > Sorry, forgot to ask this: > What happened to this change? > Do you plan to submit it as a separate patch? > > #define MAX_LEN_USSD_STRING182 It's already submitted, see the next one in this set. I decided to do that separately because it requires a bit more detailed

[PATCH] pysim[master]: Checking in pySim-fairwaves-prog.py utility.

Review at https://gerrit.osmocom.org/5746 Checking in pySim-fairwaves-prog.py utility. This utility is an example utility for programming Fairwaves SIM cards. The original pySim-prog.py utility is already bloated with features and is difficult to modify so we decided to create a leaner and

[PATCH] pysim[master]: Make derive_milenage_opc and calculate_luhn publicly availab...

Review at https://gerrit.osmocom.org/5745 Make derive_milenage_opc and calculate_luhn publicly available through utils.py Change-Id: I2effc85fd55da0981de0ada74dcb28b7e8e56a01 --- M pySim-prog.py M pySim/utils.py 2 files changed, 22 insertions(+), 19 deletions(-) git pull

libosmocore[master]: gsm0480: modify USSD structures to support external handling

Patch Set 4: Code-Review-1 Sorry, forgot to ask this: What happened to this change? Do you plan to submit it as a separate patch? > #define MAX_LEN_USSD_STRING 182 -- To view, visit https://gerrit.osmocom.org/3374 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

libosmocore[master]: gsm0480: parse GSM0480_MTYPE_FACILITY separately

Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3377 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e029c436a50fa8c2823ea39c5d123ee701becfa Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm0480: handle GSM0480_CTYPE_RETURN_RESULT

Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3378 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fb2856acbbf4c53e7d53200a37bc8f79e763bcf Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3381 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm0480: skip length check for 'RELEASE COMPLETE' message

Patch Set 6: Code-Review+1 The code looks proper now. -- To view, visit https://gerrit.osmocom.org/3373 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63b7f8ce403169a9dbdbdb031db16693de2196d6 Gerrit-PatchSet: 6 Gerrit-Project:

libosmocore[master]: gsm0480: modify USSD structures to support external handling

Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3374 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f8972b86cd4dcb54b643a24b5794a87c8758073 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm0480: clean up the parse_process_uss_req() code

Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3375 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I467f75794c5ac9df75c001245b18bbdfcfaadd88 Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: ussd_test.c: fix rc / len debug output confusion

Review at https://gerrit.osmocom.org/5744 ussd_test.c: fix rc / len debug output confusion Both len and rc values were swapped in the test output. Change-Id: Iebd82531c6ced5d16b15dad4ff4ce654c82db309 --- M tests/ussd/ussd_test.c M tests/ussd/ussd_test.ok 2 files changed, 52 insertions(+), 52

[PATCH] libosmocore[master]: gsm0480: handle GSM0480_OP_CODE_PROCESS_USS_DATA

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3380 to look at the new patch set (#6). gsm0480: handle GSM0480_OP_CODE_PROCESS_USS_DATA Change-Id: I470290c2b544555e53cedd849b1d6a961db7b5a4 --- M

[PATCH] libosmocore[master]: gsm0480: handle GSM0480_CTYPE_RETURN_RESULT

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3378 to look at the new patch set (#6). gsm0480: handle GSM0480_CTYPE_RETURN_RESULT Change-Id: I8fb2856acbbf4c53e7d53200a37bc8f79e763bcf --- M

[PATCH] libosmocore[master]: gsm0480: clean up the parse_process_uss_req() code

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3375 to look at the new patch set (#6). gsm0480: clean up the parse_process_uss_req() code This change reduces the degree of code nesting... Change-Id:

[PATCH] libosmocore[master]: gsm0480: increase the MAX_LEN_USSD_STRING to 182

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5712 to look at the new patch set (#3). gsm0480: increase the MAX_LEN_USSD_STRING to 182 According to the GSM 04.80 (version 5.0.0) specification Annex A "Expanded ASN.1 Module

[PATCH] libosmocore[master]: gsm0480: modify USSD structures to support external handling

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3374 to look at the new patch set (#4). gsm0480: modify USSD structures to support external handling This change renames the 'ss_request' struct to 'gsm0480_ss_request', and adds the

[PATCH] libosmocore[master]: gsm0480: handle USS_NOTIFY and USS_REQUEST with PROCESS_USS_REQ

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3379 to look at the new patch set (#6). gsm0480: handle USS_NOTIFY and USS_REQUEST with PROCESS_USS_REQ Change-Id:

[PATCH] libosmocore[master]: gsm0480: skip length check for 'RELEASE COMPLETE' message

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3373 to look at the new patch set (#6). gsm0480: skip length check for 'RELEASE COMPLETE' message According to GSM 04.80 Section 2.5 'Release complete' Table 2.5, the 'RELEASE

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3381 to look at the new patch set (#6). gsm0480: expose the gsm0480_parse_ss_facility_ie() Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb --- M

[PATCH] libosmocore[master]: gsm0480: parse GSM0480_MTYPE_FACILITY separately

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3377 to look at the new patch set (#6). gsm0480: parse GSM0480_MTYPE_FACILITY separately Change-Id: I6e029c436a50fa8c2823ea39c5d123ee701becfa --- M

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3376 to look at the new patch set (#6). gsm0480: handle UnstructuredSS request with DSC != 0x0F Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 --- M

[PATCH] osmo-trx[master]: utils/convolvtest: Remove uneeded libosmocore dependency

Review at https://gerrit.osmocom.org/5741 utils/convolvtest: Remove uneeded libosmocore dependency Change-Id: I1742146c31cadec8ce8afbbdae5777f076b212d4 --- M utils/convolvetest/Makefile M utils/convolvetest/main.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-trx[master]: tests: Migrate convtest util to autotest infrastructure

Review at https://gerrit.osmocom.org/5743 tests: Migrate convtest util to autotest infrastructure Change-Id: Ie682abf7e83de436d0f37f9f6e0664cb2f4d0c9e --- M configure.ac M tests/Makefile.am A tests/Transceiver52M/Makefile.am R tests/Transceiver52M/convolve_test.c R

[PATCH] osmo-trx[master]: Move ARCH_LA to Makefile.common

Review at https://gerrit.osmocom.org/5742 Move ARCH_LA to Makefile.common It will later be used by other directories too (tests/Transceiver52M). Change-Id: I0ca9b7fc5e1377db971cb7da0b3496ba8d61c716 --- M Makefile.common M Transceiver52M/Makefile.am 2 files changed, 6 insertions(+), 6

[PATCH] openbsc[master]: gsm_04_80.h: cosmetic: whitespace fix

Review at https://gerrit.osmocom.org/5738 gsm_04_80.h: cosmetic: whitespace fix Change-Id: Ife129bc8b01122444511f6ee52e30cd6367f8593 --- M openbsc/include/openbsc/gsm_04_80.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc

[PATCH] openbsc[master]: src/libmsc/ussd.c: drop useless forward declaration

Review at https://gerrit.osmocom.org/5739 src/libmsc/ussd.c: drop useless forward declaration There is no any significant reason to define static function 'send_own_number' after the code that calls it. Change-Id: I8d804398cfa460eaa5a5f84f0ed90909488d0bdd --- M openbsc/src/libmsc/ussd.c 1

[PATCH] openbsc[master]: gsm0480: fix GSM 04.80 libosmocore API / ABI compatibility

Review at https://gerrit.osmocom.org/5740 gsm0480: fix GSM 04.80 libosmocore API / ABI compatibility Since the I5f8972b86cd4dcb54b643a24b5794a87c8758073, the GSM 04.80 libosmocore API / ABI is changed in order to facilitate external USSD interface development. The only affected part of OpenBSC

[PATCH] openbsc[master]: gsm_04_80.h: use '#pragma once' instead of includes

Review at https://gerrit.osmocom.org/5737 gsm_04_80.h: use '#pragma once' instead of includes This is a common include guard way for Osmocom projects. Change-Id: I9b84e5d87068aba4926d6950b4c419be837bbcc3 --- M openbsc/include/openbsc/gsm_04_80.h 1 file changed, 1 insertion(+), 4 deletions(-)

[PATCH] osmo-msc[master]: gsm0480: fix GSM 04.80 libosmocore API / ABI compatibility

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5735 to look at the new patch set (#2). gsm0480: fix GSM 04.80 libosmocore API / ABI compatibility Since the I5f8972b86cd4dcb54b643a24b5794a87c8758073, the GSM 04.80 libosmocore API / ABI

[PATCH] osmo-msc[master]: src/libmsc/ussd.c: drop useless forward declaration

Review at https://gerrit.osmocom.org/5734 src/libmsc/ussd.c: drop useless forward declaration There is no any significant reason to define static function 'send_own_number' after the code that calls it. Change-Id: I7f76f278c09489dccd96921610e8d06efa679ff2 --- M src/libmsc/ussd.c 1 file

[PATCH] osmo-msc[master]: msc/gsm_04_80.h: use '#pragma once' instead of includes

Review at https://gerrit.osmocom.org/5733 msc/gsm_04_80.h: use '#pragma once' instead of includes This is a common include guard way for Osmocom projects. Change-Id: I5a12a742719d4deba0b9dfa8bb330c1986a727f6 --- M include/osmocom/msc/gsm_04_80.h 1 file changed, 1 insertion(+), 4 deletions(-)

[PATCH] osmo-msc[master]: gsm0480: fix GSM 04.80 libosmocore API / ABI compatibility

Review at https://gerrit.osmocom.org/5735 gsm0480: fix GSM 04.80 libosmocore API / ABI compatibility Since the I5f8972b86cd4dcb54b643a24b5794a87c8758073, the GSM 04.80 libosmocore API / ABI is changed in order to facilitate external USSD interface development. The only affected part of OsmoMSC

[PATCH] osmo-msc[master]: msc/gsm_04_80.h: clean up useless declarations

Review at https://gerrit.osmocom.org/5732 msc/gsm_04_80.h: clean up useless declarations This change removes a few USSD specific declarations, which are not actually used now, and probably accidentally migrated from legacy OpenBSC. Change-Id: Id57a24b92790d3ce0f9c7343d060f511e2b979c7 --- M

osmo-trx[master]: Set up GNU Autotest infrastructure

Patch Set 2: > According to the commit description, both LogTest.err and > LogTest.ok > are related to a single disabled test. I am not sure we really need > these files, if the test is disabled itself... It's not the only disabled test I do the same here for other tests which are not

osmo-trx[master]: Set up GNU Autotest infrastructure

Patch Set 2: According to the commit description, both LogTest.err and LogTest.ok are related to a single disabled test. I am not sure we really need these files, if the test is disabled itself... -- To view, visit https://gerrit.osmocom.org/5706 To unsubscribe, visit

osmo-trx[master]: cosmetic: AUTHORS: fix trailing whitespace

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5724 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92d9ad9a0fd69e88928a8f57920d39dcda67d59d Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

osmo-trx[master]: Set up GNU Autotest infrastructure

Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5706 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d6ba625968be09297642d18090c496490e9b8fc Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master

osmo-bsc[master]: bsc/gsm_04_80.h: use '#pragma once' instead of includes

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5731 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee73e24a2438b6081a5d569db7d48725b564ee3a Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] osmo-bsc[master]: bsc/gsm_04_80.h: use '#pragma once' instead of includes

Review at https://gerrit.osmocom.org/5731 bsc/gsm_04_80.h: use '#pragma once' instead of includes This is a common include guard way for Osmocom projects. Change-Id: Iee73e24a2438b6081a5d569db7d48725b564ee3a --- M include/osmocom/bsc/gsm_04_80.h 1 file changed, 1 insertion(+), 4 deletions(-)

[PATCH] osmo-pcu[master]: Rewrite Packet Downlink Assignment

Review at https://gerrit.osmocom.org/5727 Rewrite Packet Downlink Assignment Use bitvec_set_*() directly without external write pointer tracking to simplify the code. This is part of IA Rest Octets (3GPP TS 44.018 §10.5.2.16) which is the last part of the message so it should not interfere

[PATCH] osmo-pcu[master]: Rewrite EGPRS Packet Uplink Assignment

Review at https://gerrit.osmocom.org/5726 Rewrite EGPRS Packet Uplink Assignment Use bitvec_set_*() directly without external write pointer tracking to simplify the code. This is part of IA Rest Octets (3GPP TS 44.018 §10.5.2.16) which is the last part of the message so it should not interfere

[PATCH] osmo-pcu[master]: Rewrite Packet Uplink Assignment

Review at https://gerrit.osmocom.org/5728 Rewrite Packet Uplink Assignment Use bitvec_set_*() directly without external write pointer tracking to simplify the code. This is part of IA Rest Octets (3GPP TS 44.018 §10.5.2.16) which is the last part of the message so it should not interfere with

[PATCH] osmo-pcu[master]: cosmetic: inline single-use helper

Review at https://gerrit.osmocom.org/5730 cosmetic: inline single-use helper Change-Id: I5ec54ccd9c4bf8344fbd1dce91e8707f6b17b2f7 --- M src/encoding.cpp 1 file changed, 6 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/5730/1 diff --git

[PATCH] osmo-bsc[master]: bsc/gsm_04_80.h: clean up useless declarations

bsc/gsm_04_80.h: clean up useless declarations This change removes a few USSD specific declarations, which are not actually used now, and probably accidentally migrated from legacy OpenBSC. Change-Id: I060223349971a7fce169a018bf16eb91f0e20342 --- M include/osmocom/bsc/gsm_04_80.h 1 file

[PATCH] osmo-bts[master]: osmo-bts-trx: perform error concealment for FR frames

Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5214 to look at the new patch set (#9). osmo-bts-trx: perform error concealment for FR frames When a bad voice frame is received, it is replaced by a silence frame. This may

[PATCH] libosmocore[master]: libosmocodec: implement ECU (Error Concealment Unit) for FR

Hello dexter, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5421 to look at the new patch set (#4). libosmocodec: implement ECU (Error Concealment Unit) for FR When a bad GSM voice frame is received, it's being replaced by a silence frame.

libosmocore[master]: libosmocodec: implement ECU (Error Concealment Unit) for FR

Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/5421/3/include/osmocom/codec/ecu.h File include/osmocom/codec/ecu.h: Line 9: uint8_t frame_backup[40]; > When I see this right, than this originally was struct ecu_fr_ctx Ok, agree with you. I'll modify the change. -- To view,

[MERGED] osmo-bsc[master]: cosmetic: mgcp: remove duplicate logging

dexter has submitted this change and it was merged. Change subject: cosmetic: mgcp: remove duplicate logging .. cosmetic: mgcp: remove duplicate logging do not print an additional log lines when the mgcp FSM gets halted. This

[PATCH] libosmocore[master]: gsm0480: clean up the parse_process_uss_req() code

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3375 to look at the new patch set (#5). gsm0480: clean up the parse_process_uss_req() code This change reduces the degree of code nesting... Change-Id:

[PATCH] libosmocore[master]: gsm0480: handle GSM0480_CTYPE_RETURN_RESULT

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3378 to look at the new patch set (#5). gsm0480: handle GSM0480_CTYPE_RETURN_RESULT Change-Id: I8fb2856acbbf4c53e7d53200a37bc8f79e763bcf --- M

[MERGED] osmo-bsc[master]: mgcp: log file and line of calls to handle_error()

dexter has submitted this change and it was merged. Change subject: mgcp: log file and line of calls to handle_error() .. mgcp: log file and line of calls to handle_error() When the FSM runs into an error condition

[PATCH] libosmocore[master]: gsm0480: drop length check in gsm0480_decode_ss_request()

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3373 to look at the new patch set (#5). gsm0480: drop length check in gsm0480_decode_ss_request() According to GSM 04.80 Section 2.5 'Release complete' Table 2.5, the 'RELEASE

[PATCH] libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3381 to look at the new patch set (#5). gsm0480: expose the gsm0480_parse_ss_facility_ie() Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb --- M

[PATCH] libosmocore[master]: gsm0480: increase the MAX_LEN_USSD_STRING to 182

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5712 to look at the new patch set (#2). gsm0480: increase the MAX_LEN_USSD_STRING to 182 According to the GSM 04.80 (version 5.0.0) specification Annex A "Expanded ASN.1 Module

[PATCH] libosmocore[master]: gsm0480: parse GSM0480_MTYPE_FACILITY separately

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3377 to look at the new patch set (#5). gsm0480: parse GSM0480_MTYPE_FACILITY separately Change-Id: I6e029c436a50fa8c2823ea39c5d123ee701becfa --- M

[PATCH] libosmocore[master]: gsm0480: handle GSM0480_OP_CODE_PROCESS_USS_DATA

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3380 to look at the new patch set (#5). gsm0480: handle GSM0480_OP_CODE_PROCESS_USS_DATA Change-Id: I470290c2b544555e53cedd849b1d6a961db7b5a4 --- M

libosmocore[master]: gsm0480: increase the MAX_LEN_USSD_STRING to 182

Patch Set 1: > Would be nice to have more detailed spec reference - which > chapter/paragraph exactly states that? Also, 160 * 8 / 7 is around > 182.86 - you sure we shouldn't use 183 chars? Ok, I'll upload more detailed description soon. Regarding to 182.86, you have: 160 * 8 = 1280 bits

[PATCH] libosmocore[master]: gsm0480: handle USS_NOTIFY and USS_REQUEST with PROCESS_USS_REQ

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3379 to look at the new patch set (#5). gsm0480: handle USS_NOTIFY and USS_REQUEST with PROCESS_USS_REQ Change-Id:

[MERGED] osmo-bts[master]: meas_test: fix header file references

dexter has submitted this change and it was merged. Change subject: meas_test: fix header file references .. meas_test: fix header file references The unittest module meas_test.c contains a lot of unused header files as the

[PATCH] libosmocore[master]: gsm0480: handle UnstructuredSS request with DSC != 0x0F

Hello Alexander Chemeris, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3376 to look at the new patch set (#5). gsm0480: handle UnstructuredSS request with DSC != 0x0F Change-Id: I73d602f6f20b0afe7600d16bbd432069ae7be788 --- M

libosmocore[master]: libosmocodec: implement ECU (Error Concealment Unit) for FR

Patch Set 3: (1 comment) > (1 comment) https://gerrit.osmocom.org/#/c/5421/3/include/osmocom/codec/ecu.h File include/osmocom/codec/ecu.h: Line 9: uint8_t frame_backup[40]; > Still unsure about this. I just used the length which When I see this right, than this originally was struct

osmo-trx[master]: Set up GNU Autotest infrastructure

Patch Set 2: > Why move to tests/CommonLibs/ instead of just tests/ ? Because it's testing stuff from CommonLibs directory. We may want to test stuff from other parts, and this way is a lot clearer which part of the code is it testing. We do the same in osmo-ggsn (subdirs gtp, lib). -- To

osmo-trx[master]: Set up GNU Autotest infrastructure

Patch Set 2: Why move to tests/CommonLibs/ instead of just tests/ ? -- To view, visit https://gerrit.osmocom.org/5706 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d6ba625968be09297642d18090c496490e9b8fc Gerrit-PatchSet: 2

osmo-trx[master]: cosmetic: AUTHORS: fix trailing whitespace

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5724 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92d9ad9a0fd69e88928a8f57920d39dcda67d59d Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[PATCH] osmo-trx[master]: Set up GNU Autotest infrastructure

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5706 to look at the new patch set (#2). Set up GNU Autotest infrastructure Test files are moved from CommonLibs/ to tests/CommonLibs/. Some tests are disabled in autotest because they

[PATCH] osmo-trx[master]: cosmetic: AUTHORS: fix trailing whitespace

Review at https://gerrit.osmocom.org/5724 cosmetic: AUTHORS: fix trailing whitespace Change-Id: I92d9ad9a0fd69e88928a8f57920d39dcda67d59d --- M AUTHORS 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/24/5724/1 diff --git

[PATCH] osmo-trx[master]: tests: Sockets: adapt to have reproducible output and enable...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5711 to look at the new patch set (#2). tests: Sockets: adapt to have reproducible output and enable autotest Change-Id: I5414076c6846b849973bcdeb3f2358b28dcb004c --- M

[PATCH] osmo-trx[master]: tests: InterThread: adapt to have reproducible output and en...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5707 to look at the new patch set (#2). tests: InterThread: adapt to have reproducible output and enable autotest Change-Id: I05d4067890b526bd72d2eb31cf76de43ee11e80f --- M

osmo-trx[master]: tests: Timeval: adapt to have reproducible output and enable...

Patch Set 1: > This is odd - if test output is always empty, how can we be sure > that the test was executed at all? I think it's better to log at > least what kind of test is executing. Even better would be to log > smth in case of error instead of using assert: if we hit assert > than we

[MERGED] osmo-trx[master]: cosmetic: Remove trailing whitespace

Pau Espin Pedrol has submitted this change and it was merged. Change subject: cosmetic: Remove trailing whitespace .. cosmetic: Remove trailing whitespace Change-Id: I64c8dbad3fc42bcb8dd4ac9b16bbd9c59a0cf5d5 --- M AUTHORS M

[MERGED] osmo-trx[master]: Logger: Stop using Log.File and Log.Level from config

Pau Espin Pedrol has submitted this change and it was merged. Change subject: Logger: Stop using Log.File and Log.Level from config .. Logger: Stop using Log.File and Log.Level from config This is a required step towards

[MERGED] osmo-trx[master]: Logger: Stop using Log.Alarms.Max from config

Pau Espin Pedrol has submitted this change and it was merged. Change subject: Logger: Stop using Log.Alarms.Max from config .. Logger: Stop using Log.Alarms.Max from config This is a first step towards removing

[MERGED] osmo-trx[master]: Remove Configuration module and libsqlite dependency

Pau Espin Pedrol has submitted this change and it was merged. Change subject: Remove Configuration module and libsqlite dependency .. Remove Configuration module and libsqlite dependency Change-Id:

[PATCH] osmo-ci[master]: Install setuptools in docker images

Review at https://gerrit.osmocom.org/5723 Install setuptools in docker images Make sure that python-setuptools are installed for both python v2 and v3 to make sure osmo-python-tests can be installed. Change-Id: I3ecd96af2e2c0c7d141977639103d71e46c0cdc5 Related: OS#2821 --- M

osmo-trx[master]: Set up GNU Autotest infrastructure

Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/5706/1/AUTHORS File AUTHORS: Line 3: # > Great thing, but unrelated ;) separate change (5700)? It slipped in unintentionally, I'll move it to a new path. https://gerrit.osmocom.org/#/c/5706/1/CommonLibs/Makefile.am File

libosmocore[master]: gsm0480: modify USSD structures to support external handling

Patch Set 3: > the old version of the library will no longer work Which osmo-* are actually using it? Do we have patches for them too? Would be nice to reference them in commit message or to clarify why it's unnecessary. This would help to unsure that we won't break build of some other

libosmocore[master]: gsm0480: increase the MAX_LEN_USSD_STRING to 182

Patch Set 1: Would be nice to have more detailed spec reference - which chapter/paragraph exactly states that? Also, 160 * 8 / 7 is around 182.86 - you sure we shouldn't use 183 chars? -- To view, visit https://gerrit.osmocom.org/5712 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-trx[master]: tests: Timeval: adapt to have reproducible output and enable...

Patch Set 1: This is odd - if test output is always empty, how can we be sure that the test was executed at all? I think it's better to log at least what kind of test is executing. Even better would be to log smth in case of error instead of using assert: if we hit assert than we don't know

pysim[master]: cards: Add Fairwaves SIM implementation.

Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5722 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia10ac433d3b0482bdf727c31f65a10042152797b Gerrit-PatchSet: 3 Gerrit-Project: pysim Gerrit-Branch: master

pysim[master]: Add methods to get ATR for a card or a link.

Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5717 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic12e4b115d24a8b7e483a5603dd6cec90ad289cc Gerrit-PatchSet: 2 Gerrit-Project: pysim Gerrit-Branch: master

osmo-trx[master]: Sockets.cpp: Fix initialization of UDD socket

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5710 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e1b7e743a781abdcf69aa9842b30be893633433 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

osmo-trx[master]: tests: InterThread: adapt to have reproducible output and en...

Patch Set 1: Should tests/CommonLibs/InterthreadTest.ok be empty? May we remove one? -- To view, visit https://gerrit.osmocom.org/5707 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05d4067890b526bd72d2eb31cf76de43ee11e80f

pysim[master]: cards: Add Fairwaves SIM implementation.

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/5722/1/pySim/cards.py File pySim/cards.py: Line 589: > Whitespace... Fixed -- To view, visit https://gerrit.osmocom.org/5722 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-trx[master]: Set up GNU Autotest infrastructure

Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/5706/1/AUTHORS File AUTHORS: Line 3: # Great thing, but unrelated ;) separate change (5700)? https://gerrit.osmocom.org/#/c/5706/1/CommonLibs/Makefile.am File CommonLibs/Makefile.am: Line 41: # ReportingTest Should we keep this?

[PATCH] pysim[master]: cards: Add Fairwaves SIM implementation.

cards: Add Fairwaves SIM implementation. Change-Id: Ia10ac433d3b0482bdf727c31f65a10042152797b --- M pySim/cards.py 1 file changed, 145 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/22/5722/3 diff --git a/pySim/cards.py b/pySim/cards.py index

pysim[master]: Add methods to get ATR for a card or a link.

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/5717/1/pySim/transport/serial.py File pySim/transport/serial.py: Line 94: > Whitespace... Thanks, fixed. -- To view, visit https://gerrit.osmocom.org/5717 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] pysim[master]: Add methods to get ATR for a card or a link.

Add methods to get ATR for a card or a link. Implemented for both serial and PCSC readers. Change-Id: Ic12e4b115d24a8b7e483a5603dd6cec90ad289cc --- M pySim/commands.py M pySim/transport/pcsc.py M pySim/transport/serial.py 3 files changed, 19 insertions(+), 2 deletions(-) git pull

pysim[master]: cards: Add Fairwaves SIM implementation.

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/5722/1/pySim/cards.py File pySim/cards.py: Line 589: Whitespace... -- To view, visit https://gerrit.osmocom.org/5722 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

pysim[master]: cards: Implement card type autodetection based on ATR.

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5721 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1099a96626c0ce74243b47a8fdfa25b0d76a1ef3 Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch: master

pysim[master]: pySim-prog: Replace magic numbers with a readable EF file name.

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda7d5a4132971e884f6d760baf20cd33025a2af Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch: master

pysim[master]: pySim-prog: ADM code can be longer 8 digits, it's implementa...

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5719 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87d61764eeba4bcf7525ee4778cb8f244930db9b Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch: master

pysim[master]: cards: Extend Card class with access functions for some of t...

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5718 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb7227fa7ebc837fccab456cbfad529f6ee81a28 Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch: master

pysim[master]: Add methods to get ATR for a card or a link.

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/5717/1/pySim/transport/serial.py File pySim/transport/serial.py: Line 94: Whitespace... -- To view, visit https://gerrit.osmocom.org/5717 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

pysim[master]: utils: Fix documentation. 3+3=6 digits equals 3 bytes, not 6

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5716 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2722d788a69976e1c64a9caf6cf3049af27f9a30 Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch: master

pysim[master]: ts_51_011: A file with MF/DF/EF constants from TS 51 011

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5714 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38f5d36d16b41b5d516a6a3e2ec1d09637883932 Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch: master

pysim[master]: Fix comment: Ki -> OPC

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5713 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I566cf7bc658c730b4381c0f145bfc4f805cca42a Gerrit-PatchSet: 1 Gerrit-Project: pysim Gerrit-Branch: master