Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/armv7l
Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/aarch64
Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.04/i586
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/i586
Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_8.0/i586
Package network:osmocom:nightly/osmo-trx failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/i586
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
Patch Set 7:
> but then, all the other routines in this function
> don't seem to follow that rule.
Moreover, for some functions here a positive return
value means 'success', while rc=0 indicates an error ;)
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit
Patch Set 1:
> please keep in mind that osmo-nitb is obsolete. We generally have
> a policy to only apply bug-fixes, and only upon explicit request.
> All development work has been at the post-NITB repositories for 1.5
> years by now. Still, this patch is trivial enough to merge it.
Yes,
Alexander Huemer has submitted this change and it was merged.
Change subject: Use stow for dependency management
..
Use stow for dependency management
This commit introduces the usage of GNU stow[1] for dependency
management.
Patch Set 4: Verified+1
--
To view, visit https://gerrit.osmocom.org/2691
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5012419495a656912b7b71e4f76ce102c6b63a
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Max has abandoned this change.
Change subject: Expand bitvec_write_field()
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/4292
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: abandon
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5209
to look at the new patch set (#7).
TBF: log source of state transitions
We use the same approach for osmo_fsm: when state transition happens,
it's not very useful to
Max has abandoned this change.
Change subject: cosmetic: inline single-use helper
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/5730
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5774
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bb6792ab061edd3d688e387fa69cd8637617dee
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Max has submitted this change and it was merged.
Change subject: Fix missing OsmoPCU gerrit verification
..
Fix missing OsmoPCU gerrit verification
The [yes, no] tuple was automatically converted to [True, False] by the
Max has submitted this change and it was merged.
Change subject: Fix jenkins.sh to match jenkins job axis filter
..
Fix jenkins.sh to match jenkins job axis filter
The 'yes/no' values are automatically converted to True/False
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5770
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idac6e53b1e0addbcb5b6c99b8051e1e0ad26bc5b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 4:
> yes, we need a +V vote that someone verifies that the patch works
> when applied to current master. In the lack of an automatic test on
> jenkins, someone should run this manually and add V+1
bump: Alexander, I assumed you could verify and add your V+1 vote?
--
To view, visit
Review at https://gerrit.osmocom.org/5774
README: also hint at /n/home/dub8/.config/jenkins_job_builder/jenkins_jobs.ini
Change-Id: I8bb6792ab061edd3d688e387fa69cd8637617dee
---
M jobs/README.adoc
1 file changed, 6 insertions(+), 3 deletions(-)
git pull
Harald Welte has abandoned this change.
Change subject: Deprecate old counter functions
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/5015
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5692
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a72d36d777ba582815b2cdef8130ee88c060b54
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1:
just quoting the "yes" "no" would spare us the rest of the changes,
because then everything uses "yes" "no" like it did before jjb.
But since the patches are already here I'd be fine. Can you verify that it
works and V+1 plz
--
To view, visit https://gerrit.osmocom.org/5770
To
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5692
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a72d36d777ba582815b2cdef8130ee88c060b54
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5768
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8fc9e782bcf8fa6e2e957d02e7d73c3a7c2bca8
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: logging-gsmtap: send only basename of source file
..
logging-gsmtap: send only basename of source file
GSMTAP doesn't have a lot of space for the source
Harald Welte has submitted this change and it was merged.
Change subject: Notify per email about master branch build failure
..
Notify per email about master branch build failure
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5772
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2100c8345d1f07f488de8170348fec9f877dd9b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1:
> WHat's the expected way to verify this? I push it to jenkins using
> the jenkins job builder tools and then I retrigger a gerrit commit
> to see if it works nice? Then I Verify+1 and merge it. Fine with
> that?
Yes
--
To view, visit https://gerrit.osmocom.org/5759
To
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5769
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb8eb04e3a5c9c5dcc9b99c83425d2604378f960
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: docker osmo jenkins: osmo-py-tests: use contrib/jenkins.sh to
install
..
docker osmo jenkins: osmo-py-tests: use contrib/jenkins.sh to install
No need
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5770
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idac6e53b1e0addbcb5b6c99b8051e1e0ad26bc5b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Don't access TBF internals in vty functions
..
Don't access TBF internals in vty functions
Obtain corresponding window object of UL/DL TBF by using
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5771
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89bcd2c2b0b6f120d40d20fd43c1e516de3e3950
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Add rate counter dumper
..
Add rate counter dumper
This simple tool dump all the rate counters available via ctrl interface
to cvs file (or stdout).
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5029
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12b369434e4ee9b38f92872f297e1f3d4f0698c2
Gerrit-PatchSet: 14
Gerrit-Project: python/osmo-python-tests
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5772
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2100c8345d1f07f488de8170348fec9f877dd9b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Remove unused bsc_version.c
..
Remove unused bsc_version.c
Change-Id: Ib3f52c3e4cbd08b28f99d613aa18c6b00c71ead9
---
M debian/copyright
M
Max has submitted this change and it was merged.
Change subject: gtphub: make rate_ctr unique
..
gtphub: make rate_ctr unique
* compute unique rate counter index when allocating new gtphub tunnel
* propagate rate counter
Review at https://gerrit.osmocom.org/5773
Remove unused bsc_version.c
Change-Id: Ib3f52c3e4cbd08b28f99d613aa18c6b00c71ead9
---
M debian/copyright
M src/libcommon/Makefile.am
D src/libcommon/bsc_version.c
3 files changed, 0 insertions(+), 32 deletions(-)
git pull
Max has abandoned this change.
Change subject: Fix wrong encoding of LH bits
..
Abandoned
Superseded by "rewrite rest octets" patch series.
--
To view, visit https://gerrit.osmocom.org/5686
To unsubscribe, visit
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5029
to look at the new patch set (#14).
Add rate counter dumper
This simple tool dump all the rate counters available via ctrl interface
to cvs file (or
Review at https://gerrit.osmocom.org/5772
Fix jenkins.sh to match jenkins job axis filter
The 'yes/no' values are automatically converted to True/False upon
jenkins job instantiation. Let's use those directly.
Change-Id: Ib2100c8345d1f07f488de8170348fec9f877dd9b
---
M contrib/jenkins.sh
1
Patch Set 1:
WHat's the expected way to verify this? I push it to jenkins using the jenkins
job builder tools and then I retrigger a gerrit commit to see if it works nice?
Then I Verify+1 and merge it. Fine with that?
--
To view, visit https://gerrit.osmocom.org/5759
To unsubscribe, visit
Review at https://gerrit.osmocom.org/5771
Don't access TBF internals in vty functions
Obtain corresponding window object of UL/DL TBF by using proper accessor
function instead of direct access to private member.
Change-Id: I89bcd2c2b0b6f120d40d20fd43c1e516de3e3950
---
M
Review at https://gerrit.osmocom.org/5770
Fix missing OsmoPCU gerrit verification
The [yes, no] tuple was automatically converted to [True, False] by the
jenkins-job-builder but the combination filter still used old literal
check. Fix this by using boolean from the very beginning.
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5209
to look at the new patch set (#5).
TBF: log source of state transitions
We use the same approach for osmo_fsm: when state transition happens,
it's not very useful to
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5686/1/src/encoding.cpp
File src/encoding.cpp:
Line 83:*write_index += 2;
why +2? I don't get it. we are setting a single bit, aren't we?
--
To view, visit https://gerrit.osmocom.org/5686
To unsubscribe, visit
Max has submitted this change and it was merged.
Change subject: TBF: unify EGPRS window calculation
..
TBF: unify EGPRS window calculation
Move actual calculation into shared function and use it to set window
size for TBF.
Max has submitted this change and it was merged.
Change subject: Avoid code duplication in TBF test
..
Avoid code duplication in TBF test
Move repetitive checks into corresponding macros to avoid copy-pasted
code. This also
Max has submitted this change and it was merged.
Change subject: TBF: move window parameters to UL/DL level
..
TBF: move window parameters to UL/DL level
The UL and DL TBF use different classes implementing window
management.
Max has submitted this change and it was merged.
Change subject: TBF-DL: move priority computation into function
..
TBF-DL: move priority computation into function
Improve readability by moving priority computation into
Harald Welte has submitted this change and it was merged.
Change subject: Test control connection status query for MSC 0.
..
Test control connection status query for MSC 0.
This new test exercises the new
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5632
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55faa1ec413629234e24831dbc05d8b0afec8099
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5666
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If841d403010a73722ff69617a51719421febab56
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5685/1/src/libbsc/paging.c
File src/libbsc/paging.c:
Line 89:LOGP(DPAG, LOGL_INFO, "Going to send paging commands: bts: %d
imsi: %s tmsi: "
it's typically best practise to use something like "(bts=%d) " at the beginning
of the
Max has submitted this change and it was merged.
Change subject: TBF-UL: add simpler test helper
..
TBF-UL: add simpler test helper
Add function to set both V_R and V_Q values to 0 which is useful for TBF
test.
Related:
Harald Welte has submitted this change and it was merged.
Change subject: iu_client.c: Remove unusued variable
..
iu_client.c: Remove unusued variable
Change-Id: If841d403010a73722ff69617a51719421febab56
---
M src/iu_client.c
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5029
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12b369434e4ee9b38f92872f297e1f3d4f0698c2
Gerrit-PatchSet: 13
Gerrit-Project: python/osmo-python-tests
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5524
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e07f95c36de369bcd0691b8d0fd47c844abe5da
Gerrit-PatchSet: 4
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5673
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I042b4918bc74955cc5162fad8c16d989402c29a1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5604
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I112307b5eaf494062b2e8498ff2e9217fb8db925
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Enable sanitize for CI tests
..
Enable sanitize for CI tests
Change-Id: I112307b5eaf494062b2e8498ff2e9217fb8db925
---
M contrib/jenkins.sh
1 file
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5672
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd110c4eaecab5268e1f87c11ba96460bda274ee
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5656
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If189b7166a29a87ffb17a7a9bc560f674851fd53
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Clarify RACH-related interfaces
..
Clarify RACH-related interfaces
* make is_11bit parameter into bool
* remove is_single_block() from public interface
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/5424/2/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:
Line 328: msg->l3h = msgb_put(msg, TLVP_LEN(,
GSM0808_IE_LAYER_3_INFORMATION));
> msgb_put() will panic if the length value provided in the data packet excee
The
Harald Welte has submitted this change and it was merged.
Change subject: Fix BENCHMARK_STOP call for both AMR and FR codecs
..
Fix BENCHMARK_STOP call for both AMR and FR codecs
The BENCHMARK_STOP should be called with a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5688
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie90e85ca8d9ec3175a58dde60525e0b7d6daf608
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: libgsmhr/libgsmhr.c: fix memory leak after gsmhr_exit()
..
libgsmhr/libgsmhr.c: fix memory leak after gsmhr_exit()
During the HR codec initialization, a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5687
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9ead89c2272782de8d928f29753e6a523cf8834
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5209
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I348ba89bdda2b44c7019e9c893c764ee08c80bec
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: TBF: cleanup state flag handling
..
TBF: cleanup state flag handling
* introduce generic function to check whether particular flag was set
for'a TBF
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5367
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4560280c72f91700f2e19c6c7f6658dc29625c2
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Make TBF state private
..
Make TBF state private
Let's make sure no external function can mess with the TBF state.
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5207
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I217f4c4bac21dd584c8682928a080a1a6e9507e1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2:
how was this tested/velidated? gb_proxy changes are risky unless we start
adding automatic testing for it either in osmo-gsm-tester or in osmo-ttcn3-test.
--
To view, visit https://gerrit.osmocom.org/5680
To unsubscribe, visit https://gerrit.osmocom.org/settings
Harald Welte has submitted this change and it was merged.
Change subject: Deprecate gsm48_construct_ra()
..
Deprecate gsm48_construct_ra()
It's just a tiny wrapper around gsm48_encode_ra() with less strict type
signature.
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5337
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I719abfbd5b88c694cbbd69d5c4dcb42baaca91b2
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5340
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b55aa8947db65f7206adcf53ea32b74a831d9e6
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5338
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7aa72f5aa66c5e9c255542c066b5494c098aab2
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5421
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06a21f60db01bfe1c2b838f93866fad1d53fdcd1
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/5752/3/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:
Line 367:
(unrelated whitespace change)
Line 392: if (page_subscriber(msc, bts,
tmsi, lac, mi_string,
Patch Set 1:
ok, so we can reuse some of the functions introduced in the previous patch? Is
that the purpose? If so, it needs to be stated/explained.
--
To view, visit https://gerrit.osmocom.org/5727
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1:
I don't really see why the new code is an improvement over the old code. Also,
I fail to see how this relates to OS#1526, so I guess it warrants an
explanation in the commitlog
--
To view, visit https://gerrit.osmocom.org/5726
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5729
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b17be78a46c0bc17516b7c90f35aa4768010ae4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review-1
you don't know if this might be needed from other(future) code, so i'd simply
keep it
--
To view, visit https://gerrit.osmocom.org/5730
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: bsc/gsm_04_80.h: clean up useless declarations
..
bsc/gsm_04_80.h: clean up useless declarations
This change removes a few USSD specific declarations,
Harald Welte has submitted this change and it was merged.
Change subject: bsc/gsm_04_80.h: use '#pragma once' instead of includes
..
bsc/gsm_04_80.h: use '#pragma once' instead of includes
This is a common include guard way
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5731
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee73e24a2438b6081a5d569db7d48725b564ee3a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5725
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I060223349971a7fce169a018bf16eb91f0e20342
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Allow multiple 'log gsmtap' sinks
..
Allow multiple 'log gsmtap' sinks
Previously we've checked for existing log target with a given hostname
from vty
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5747
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fd8bda9e07d403a54735da30addb742e56538a2
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5769
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb8eb04e3a5c9c5dcc9b99c83425d2604378f960
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5769
docker osmo jenkins: osmo-py-tests: use contrib/jenkins.sh to install
No need to duplicate the install steps we have in osmo-python-tests/contrib
now. Also runs the tests.
Change-Id: Ibb8eb04e3a5c9c5dcc9b99c83425d2604378f960
---
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5745
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2effc85fd55da0981de0ada74dcb28b7e8e56a01
Gerrit-PatchSet: 1
Gerrit-Project: pysim
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5722
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia10ac433d3b0482bdf727c31f65a10042152797b
Gerrit-PatchSet: 3
Gerrit-Project: pysim
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5721
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1099a96626c0ce74243b47a8fdfa25b0d76a1ef3
Gerrit-PatchSet: 2
Gerrit-Project: pysim
Gerrit-Branch: master
Patch Set 1: Verified+1
actually, since the build of the docker images is currently broken, rather
merge now and verify by seeing whether the failure is fixed.
--
To view, visit https://gerrit.osmocom.org/5723
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: Install setuptools in docker images
..
Install setuptools in docker images
Make sure that python-setuptools are installed for both python v2 and v3
to
1 - 100 of 177 matches
Mail list logo
