Patch Set 9:
I don't remember off the top of my head. If it's not used in OpenBSC or in the
SIP proxy, then I guess this is not required.
--
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5857
to look at the new patch set (#4).
logging: use enum to set timestamp format
In preparation of adding a new timestamp format, refactor to use an enum to
pick the timestamp style.
Intro
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5861
to look at the new patch set (#2).
logging vty: add 'logging print timestamp', deprecate other timestamp cmds
Currently we have
logging timestamp (0|1)
logging print extended-timest
Patch Set 1: Code-Review-2
see comment on https://gerrit.osmocom.org/5857
--
To view, visit https://gerrit.osmocom.org/5861
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58c792dda3cbcf8618648ba4429c27fa398a9e15
Gerrit-PatchSet: 1
Gerri
Patch Set 4: Code-Review-2
see comment on https://gerrit.osmocom.org/5857
--
To view, visit https://gerrit.osmocom.org/5815
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd5192ea835e24b12fe057cc1ab56e9572d75c0
Gerrit-PatchSet: 4
Gerri
Patch Set 3: Code-Review-2
meh, now I notice that I was wrong about 'logging timestamp' ... for some
reason I thought it logs the seconds since epoch, while it prints a ctime()
string like 'Thu Jan 18 02:27:19 2018' ... so I named the enum val wrongly and
might not have started with separating
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5813
to look at the new patch set (#4).
logging vty: add 'logging print file (0|1|basename)' cmd
Add a VTY command that allows configuring the output of source filename. So
far, this was not
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5857
to look at the new patch set (#3).
logging: use enum to set timestamp format
In preparation of adding a new timestamp format, refactor to use an enum to
pick the timestamp style.
Intro
Review at https://gerrit.osmocom.org/5861
logging vty: add 'logging print timestamp', deprecate other timestamp cmds
Currently we have
logging timestamp (0|1)
logging print extended-timestamp (0|1)
With the recently added timestamp style enum values, use the convenient gap of
'logging prin
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5815
to look at the new patch set (#4).
logging: allow adding separators to the extended-timestamp
Add a log target config to allow separating the extended timestamp.
Before: 201801160144346
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/5844/1/tests/Makefile.am
File tests/Makefile.am:
Line 5: $(top_builddir)/src/vty/libosmovty.la \
> Seems like unrelated cosmetic change, but we shouldn't consider it merge bl
This is the main change of this patch. It is not cosmet
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jenkins_common.sh: fix build_bts distcheck for more than one
conf_flag
..
jenkins_common.sh: fix build_bts distcheck for more than one conf_flag
Passin
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5813
to look at the new patch set (#3).
logging: vty: add 'logging print file (0|1|basename)' cmd
Add a VTY command that allows configuring the output of source filename. So
far, this was no
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5814
to look at the new patch set (#3).
logging: allow to log only the basename of each source
In the C API, add another enum log_file_type value, and when set print only the
b
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: logging: if color is disabled, don't print ""
..
cosmetic: logging: if color is disabled, don't print ""
If color output is disabled, skip the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5857
to look at the new patch set (#2).
logging: use enum to set timestamp format
In preparation of adding a new timestamp format, refactor to use an enum to
pick the timestamp style.
Intro
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5812
to look at the new patch set (#3).
logging: separate the '<000b>' subsys from filename logging
Add a separate flag and API to switch the category-in-hex output:
log_set_pr
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5819
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0caea2a2a8e6bd07432fd73bae72b42b1ce022cd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5854
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7018ded23fe51f364f248ade111aaa80ef46187e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/5860
sccp_types.h: Fix value for SCCP_REFUSAL_UNEQUIPPED_USER
It seems we have been sending the wrong numeric value in SCCP connection
refusal due to an unqeuipped user. It turns out our list of refusal
causes was missing one entry, causing an off-by-one fo
Patch Set 9:
The semantics for "--enable-sysmocom-bts" remains exactly the same as before:
look for includes in default directory.
--
To view, visit https://gerrit.osmocom.org/5818
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94ea8ba
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5859
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23d5b75825a667e4f043d16a12b841cd8f01af5e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Own
Max has submitted this change and it was merged.
Change subject: Don't run OsmoPCU tests in parallel
..
Don't run OsmoPCU tests in parallel
The vty and ctrl tests are enabled by default and are run on hard-coded
ports. This cau
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5852
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2702c71cd268ca688e9ecc264f8cd1257c27899
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Own
Max has submitted this change and it was merged.
Change subject: Install pip tool into containers
..
Install pip tool into containers
The pip(2|3) tool is the officially recommended tool to deal with Python
packages [1] with mu
Harald Welte has submitted this change and it was merged.
Change subject: Merge branch 'fixeria/lib' into master
..
Merge branch 'fixeria/lib' into master
The previous GAPK implementation was represented by a single
executable.
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5778
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c6d4a9d326ee49153e4ad83823d094831c112da
Gerrit-PatchSet: 2
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Own
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5852
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2702c71cd268ca688e9ecc264f8cd1257c27899
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-
Patch Set 3:
I think recent changes to RO encoding in OsmoPCU made this obsolete. Could you
try the latest master and check if there're still issues?
--
To view, visit https://gerrit.osmocom.org/3991
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-
Harald Welte has submitted this change and it was merged.
Change subject: Set V_N and V_B to known initial state
..
Set V_N and V_B to known initial state
Reset V_N and V_B in UL/DL window class constructors to make sure we
alw
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5786
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e14ffa913b49c5394229220de9165cdfaabdf19
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: jenkins.sh: Disable building doxygen for deps
..
jenkins.sh: Disable building doxygen for deps
Don't clutter build logs with irrelevant output.
Change-I
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5858
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1784baa519c10ab0ab3e600f373c27a6c8ae4c6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5859
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23d5b75825a667e4f043d16a12b841cd8f01af5e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-
Harald Welte has submitted this change and it was merged.
Change subject: TBF: log source of state transitions
..
TBF: log source of state transitions
We use the same approach for osmo_fsm: when state transition happens,
it's n
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5209
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I348ba89bdda2b44c7019e9c893c764ee08c80bec
Gerrit-PatchSet: 8
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5858
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1784baa519c10ab0ab3e600f373c27a6c8ae4c6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/5859
Don't run OsmoPCU tests in parallel
The vty and ctrl tests are enabled by default and are run on hard-coded
ports. This causes some builds to fail when run in parallel.
Change-Id: I23d5b75825a667e4f043d16a12b841cd8f01af5e
---
M jobs/gerrit-verification
Review at https://gerrit.osmocom.org/5858
jenkins.sh: Disable building doxygen for deps
Don't clutter build logs with irrelevant output.
Change-Id: If1784baa519c10ab0ab3e600f373c27a6c8ae4c6
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom
Review at https://gerrit.osmocom.org/5857
logging: use enum to set timestamp format
In preparation of adding a new timestamp format, refactor to use an enum to
pick the timestamp style.
Introduce log_set_print_timestamp2() to be able to pass an enum value directly
(for future additions). Make
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5814
to look at the new patch set (#2).
logging: allow to log only the basename of each source
In the VTY print filename command, add another parameter 'basename' to yield:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5813
to look at the new patch set (#2).
logging: vty: add 'logging print file (0|1|with-cat)' cmd
Add a VTY command that allows configuring the output of source filename. So
far, this was no
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5815
to look at the new patch set (#2).
logging: allow adding separators to the extended-timestamp
Add a log target config to allow separating the extended timestamp.
Before: 201801160144346
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5812
to look at the new patch set (#2).
logging: separate the '<000b>' subsys from filename logging
Do not include the category as hex in the log_set_print_filename() flag, add
Patch Set 2: Code-Review+1
> @tnt: any feedbackk on this patch series?
Harald, @tnt answered in IRC:
> (19:13:39) tnt: fixeria: gapk lib looks fine to me from a
> quick glance. I tend to agree with Harald's comment on the ML
Both issues you mentioned were resolved.
--
To view, visit https://
Hello Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5778
to look at the new patch set (#2).
Merge branch 'fixeria/lib' into master
The previous GAPK implementation was represented by a single
executable. So, all audio transcoding operations were
Review at https://gerrit.osmocom.org/5854
bts-trx: trx_if.c: trx_ctrl_read_cb: Move error handling to end of func
The move includes a small logic change: If there's a mismatch between
the rsp and the cmd, now we bts_shutdown instead of blindly skipping
expected RSP and continuing with sending t
Review at https://gerrit.osmocom.org/5855
bts-trx: trx_if.c: Improve parsing of received RSP messages from TRX
First the cached CMD sent (struct trx_ctrl_msg) is reworked to have the
cmdname and the params in different buffers for easier comparison with
RSP later.
For the receive path (trx_ctr
Review at https://gerrit.osmocom.org/5856
bts-trx: Detect duplicated responses for retransmitted commands
It was detected that under some conditions, osmo-trx (with limesdr)
may take a long time to answer to CMDs, which means trx_ctrl_timer will
trigger re-transmitting the last sent but yet una
Review at https://gerrit.osmocom.org/5853
bts-trx: trx_if.c: Log timedout+retransmitted CMD
Change-Id: Ib573c86a1640640c2a61e80fe1f1412b30342b1a
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/53/5
Max has abandoned this change.
Change subject: Drop vty tests
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/5850
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-
Review at https://gerrit.osmocom.org/5852
Install pip tool into containers
The pip(2|3) tool is the officially recommended tool to deal with Python
packages [1] with much greater flexibility compared to invoking setup.py
directly. As a preparation step for using it to install
osmo-python-tests
Harald Welte has submitted this change and it was merged.
Change subject: MNCC_Types: Add templates for most MNCC messages
..
MNCC_Types: Add templates for most MNCC messages
This adds templates for sending and receiving MNCC m
Harald Welte has submitted this change and it was merged.
Change subject: MNCC: Add some useful templates / helper functions
..
MNCC: Add some useful templates / helper functions
Change-Id: I59374f9f17600bd405b52dd3a0bcdb39b9ac
Harald Welte has submitted this change and it was merged.
Change subject: MNCC: Make sure all unused fields are set to omit, not 'unbound'
..
MNCC: Make sure all unused fields are set to omit, not 'unbound'
Change-Id: I0ef3afa1
Harald Welte has submitted this change and it was merged.
Change subject: MNCC_Types: Add enumerated for cause location + cause coding
..
MNCC_Types: Add enumerated for cause location + cause coding
Change-Id: If67691a7a18cdde7
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5849
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If67691a7a18cdde726dfcab48fdfc7b29bd518b4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5848
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ef3afa19d4ad5e011a7c0d86f8367461608e163
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5847
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59374f9f17600bd405b52dd3a0bcdb39b9ac9adc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5846
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77665aaf589bdaa9dc0aa6a5daa431fafdc2b383
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: Fix missing OsmoPCU master build
..
Fix missing OsmoPCU master build
Similar to Idac6e53b1e0addbcb5b6c99b8051e1e0ad26bc5b fix the master
branch builds.
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5851
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdd53a7cb037324a568e8eab529716e030e00583
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: mas
Harald Welte has submitted this change and it was merged.
Change subject: fsm: fix double llist_del in osmo_fsm_inst_term()
..
fsm: fix double llist_del in osmo_fsm_inst_term()
llist_del(&fi->proc.child) is executed always, reg
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5831
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b33d508c8a11b72fbf30125088a882894d9e6ac
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Review at https://gerrit.osmocom.org/5851
Fix missing OsmoPCU master build
Similar to Idac6e53b1e0addbcb5b6c99b8051e1e0ad26bc5b fix the master
branch builds.
Change-Id: Icdd53a7cb037324a568e8eab529716e030e00583
---
M jobs/master-builds.yml
1 file changed, 6 insertions(+), 6 deletions(-)
gi
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5832
to look at the new patch set (#2).
fsm: add functions for unlinking and changing parents
At the moment it is not possible to unlink a child from from
its parent, nor is it possible to a
Patch Set 1:
> llist_del Form an empty list is a safe Operation. So is tzhis a
> purely cosmetic fix orcdid you See any real world issue?
Yes, https://gerrit.osmocom.org/5832 causes a segfault in osmo_fsm_inst_term()
when osmo_fsm_inst_unlink_parent() was called before.
I see a problem with ll
Review at https://gerrit.osmocom.org/5850
Drop vty tests
There're no OsmoPCU-specific tests, just generic check for "show
version" and alike which are verified by other projects anyway. In case
of OsmoPCU those are proved unreliable and cause sporadic failures in
jenkins test. The likely way fo
Review at https://gerrit.osmocom.org/5849
MNCC_Types: Add enumerated for cause location + cause coding
Change-Id: If67691a7a18cdde726dfcab48fdfc7b29bd518b4
---
M library/MNCC_Types.ttcn
1 file changed, 26 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Review at https://gerrit.osmocom.org/5847
MNCC: Add some useful templates / helper functions
Change-Id: I59374f9f17600bd405b52dd3a0bcdb39b9ac9adc
---
M library/MNCC_CodecPort.ttcn
M library/MNCC_Types.ttcn
2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:2
Review at https://gerrit.osmocom.org/5848
MNCC: Make sure all unused fields are set to omit, not 'unbound'
Change-Id: I0ef3afa19d4ad5e011a7c0d86f8367461608e163
---
M library/MNCC_EncDec.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hac
Review at https://gerrit.osmocom.org/5846
MNCC_Types: Add templates for most MNCC messages
This adds templates for sending and receiving MNCC messages from
the external MNCC handler point of view, i.e. as required for MSC
testing. The inverse templates will be needed if we want to implement
em
Harald Welte has submitted this change and it was merged.
Change subject: BSSMAP_Emulation: Initialize ExpectTable before use
..
BSSMAP_Emulation: Initialize ExpectTable before use
The assignment_fr_* tests now go through to th
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5843
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5a128861ae7b1a4cf8158e43c59c52ebd2a20ba
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5842
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24205425c5b6ae5b8a0f6288ba89ea5a1dc4669d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Emulation: Initialize the ConnectionTable
..
RSL_Emulation: Initialize the ConnectionTable
By default all the elements in the conn table seem to be c
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/5844/1/tests/Makefile.am
File tests/Makefile.am:
Line 5: $(top_builddir)/src/vty/libosmovty.la \
Seems like unrelated cosmetic change, but we shouldn't consider it merge
blocker.
Line 151: vty_vty_test_LDADD = $(L
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix -Werror build: logging.c: always use literal with snprintf
..
fix -Werror build: logging.c: always use literal with snprintf
A recent commit added a
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5845
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4eb8a9fab66dcd987986065351b4a06421f1ec
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch:
fix -Werror build: logging.c: always use literal with snprintf
A recent commit added an snprintf that passes a pointer to a literal directly
to snprintf. Since passing pointers to printf formats is a vulnerability in
case user supplied data may be passed in the format, modern compilers warn
again
Review at https://gerrit.osmocom.org/5845
fix -Werror build: logging.c: always use literal with snprintf
A recent commit added an snprintf that passes a pointer to a literal directly
to snprintf. Since passing pointers to printf formats is a vulnerability in
case user supplied data may be passe
Review at https://gerrit.osmocom.org/5844
tests: fix LDADD: link libosmovty from current build
Do not link against the system-wide installed libosmovty during build. Instead,
use the locally built one: add libosmovty.la to LDADD explicitly.
It might be more accurate to add this linking only to
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5842
to look at the new patch set (#2).
RSL_Emulation: Initialize the ConnectionTable
By default all the elements in the conn table seem to be considered
.
f_cid_create() manages to set ra,
Patch Set 1:
Ok, let's keep in this in gerrit until OS#1854 is resolved and than we can
merge this. Updating readme is easily overlooked so thanks for sending this.
--
To view, visit https://gerrit.osmocom.org/5833
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 1:
> I wasn't referring to compilation. Have you tried to run it with
> actual phone and verified that 11-bit RACH was used? The ticket
> referred to in README is still open. I'd be surprised if adding
> support to libosmocore would mean that it'll be automatically used
> in osmo-bt
Patch Set 1: Code-Review-1
I'll make the init routine here a function as well
--
To view, visit https://gerrit.osmocom.org/5842
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24205425c5b6ae5b8a0f6288ba89ea5a1dc4669d
Gerrit-PatchSet: 1
G
Review at https://gerrit.osmocom.org/5842
RSL_Emulation: Initialize the ConnectionTable
By default all the elements in the conn table seem to be considered
.
f_cid_create() manages to set ra, ra_fn and comp_ref in the
ConnectionData element, but checking for
ispresent(ConnectionTable[i].ra) sti
Review at https://gerrit.osmocom.org/5843
BSSMAP_Emulation: Initialize ExpectTable before use
The assignment_fr_* tests now go through to the point where the BSC
sends a CRCX to the mgw.
Change-Id: Ic5a128861ae7b1a4cf8158e43c59c52ebd2a20ba
---
M library/BSSMAP_Emulation.ttcn
1 file changed, 7
Patch Set 2:
Indeed, this was not tested against actual gbproxy. The change is rather
cosmetic: explicit struct type used instead of void * but this can wait until
we have more elaborate test infrastructure for gbproxy.
--
To view, visit https://gerrit.osmocom.org/5680
To unsubscribe, visit h
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5814
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e4d5fb2066f8bf86e59c82d1752b1a843cf58e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5778
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c6d4a9d326ee49153e4ad83823d094831c112da
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Own
Patch Set 1:
@tnt: any feedbackk on this patch series?
--
To view, visit https://gerrit.osmocom.org/5778
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c6d4a9d326ee49153e4ad83823d094831c112da
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Ger
Harald Welte has submitted this change and it was merged.
Change subject: Allow specifying sysmocom headers explicitly
..
Allow specifying sysmocom headers explicitly
The headers for LC1.5 are specified explicitly. Add correspo
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5796
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5248e8b389fd240b4d5a0bcf6c954d6115262462
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: mgcp_network: typo in log
..
cosmetic: mgcp_network: typo in log
Change-Id: Ia7675e52fe1082d21bd68dcf54fe34c0f0326f11
---
M src/libosmo-mgcp/mg
Harald Welte has submitted this change and it was merged.
Change subject: logging: color the log level
..
logging: color the log level
When log_set_use_color() is enabled, color the log level string according to
the log level.
Harald Welte has submitted this change and it was merged.
Change subject: logging: color the log category according to level
..
logging: color the log category according to level
When log_set_use_color() is enabled, color the l
Harald Welte has submitted this change and it was merged.
Change subject: logging: add ability to log the log-level with API and vty
..
logging: add ability to log the log-level with API and vty
Log the log level string after t
Patch Set 5:
Those are 2 different things:
1) osmo_gettimeofday() used inside libosmocore for elapsed time computations in
osmo_timers_*()
2) osmo_gettimeofday() used externally for elapsed time computations
Those are pretty-much independent. The main difference is that corresponding
"struct t
Patch Set 1:
> I would gladly separate the hex category out to its own logging
> config api, the only reason why I'm continuing to tie it with the
> filename is backwards compat. If you agree that we completely untie
> it from the filename (and that changing the logging API behavior is
> acce
1 - 100 of 173 matches
Mail list logo
