Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6077
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d436bd3d1fb0ce8e98526bd7457f4c57667ceb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: TBF: override send function via linker option
..
TBF: override send function via linker option
Use --wrap linker facility to override pcu_sock_send() sim
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6076
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I451f2472070dea2387bfaea45ca5bdd9e3b2276d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6063
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ec229702343343dedcbb242b6d0ed170c858511
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Improve an error message in page_lai_and_lac()
..
Improve an error message in page_lai_and_lac()
This error message is now contained in a loop, and the c
Harald Welte has submitted this change and it was merged.
Change subject: gtp.c: gtp_gpdu_ind: Convert ifelse to switch statement
..
gtp.c: gtp_gpdu_ind: Convert ifelse to switch statement
Change-Id: I99b73f7a6d4100789fa92021c6
Harald Welte has submitted this change and it was merged.
Change subject: gtp.c: Log unsupported GTP version number
..
gtp.c: Log unsupported GTP version number
Change-Id: Idbc6e4c912b958bde5916b87ec53c3c4db70bee0
---
M gtp/gtp
Harald Welte has submitted this change and it was merged.
Change subject: gtp/pdp: Fix trailing whitespace
..
gtp/pdp: Fix trailing whitespace
Change-Id: I1bc65ef9af1144779ee91a2c9b9887233ad15671
---
M gtp/pdp.c
M gtp/pdp.h
2 f
Harald Welte has submitted this change and it was merged.
Change subject: gtp.c: Determine GTP version from header
..
gtp.c: Determine GTP version from header
Change-Id: I843071a090e877fd529e1e0b799df3585bf836d8
---
M gtp/gtp.c
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6070
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00db99ba8de3f3d90e85bf593ed31555eedb439b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Harald Welte has submitted this change and it was merged.
Change subject: protocol: fix missing carriage return
..
protocol: fix missing carriage return
Some of the line breaks lack the \r character, which leads to an
inconsist
Harald Welte has submitted this change and it was merged.
Change subject: gtp.c: Fix trailing whitespace
..
gtp.c: Fix trailing whitespace
Change-Id: I636c81d0c0ff53c97e6aedbc00f90c1325a3d607
---
M gtp/gtp.c
1 file changed, 28
Harald Welte has submitted this change and it was merged.
Change subject: gtp/pdp: Remove unused APIs pdp_ntoeua pdp_euaton
..
gtp/pdp: Remove unused APIs pdp_ntoeua pdp_euaton
Change-Id: I00db99ba8de3f3d90e85bf593ed31555eedb43
Harald Welte has submitted this change and it was merged.
Change subject: gtp.c: gtp_gpdu_ind: Early return to avoid use of uninitialized
var
..
gtp.c: gtp_gpdu_ind: Early return to avoid use of uninitialized var
If the versio
Harald Welte has submitted this change and it was merged.
Change subject: mgcp: add prefix to virtual trunk
..
mgcp: add prefix to virtual trunk
the virtual trunk is addressed without a prefix (just *@domain).
- reorganize fin
Harald Welte has submitted this change and it was merged.
Change subject: client: eliminate destructive head parsing
..
client: eliminate destructive head parsing
While parsing the head of an MGCP response the r->body buffer is
Harald Welte has submitted this change and it was merged.
Change subject: protocol: fix problem with line break and OSMUX
..
protocol: fix problem with line break and OSMUX
The SDP parameter block must be detached from the regu
Harald Welte has submitted this change and it was merged.
Change subject: client: eliminate destructive parameter parsing
..
client: eliminate destructive parameter parsing
The function mgcp_response_parse_params() that is used
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: client: add doxygen comments
..
cosmetic: client: add doxygen comments
The client lacks doxygen apidoc comments
- Add missing doxygen apidoc c
Harald Welte has submitted this change and it was merged.
Change subject: mgcp: permit wildcarded endpoint assignment (CRCX)
..
mgcp: permit wildcarded endpoint assignment (CRCX)
The mgcp protocol in general allows wildcarded e
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5981
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd80afae65accd3b4ddc5d82e5d30385879141c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5935
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia475036f7f3802b1638e0511a5e9162fea1592eb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5880
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2aac3ba0f1f3122dfbb3bf36f74198ecb2b21de5
Gerrit-PatchSet: 5
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: client: add missing mandatory SDP fields
..
client: add missing mandatory SDP fields
The mcgp message generator function mgcp_msg_gen() lacks support
for
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5879
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc95043569191b6f5fbc8fe266b13fcfcab2e48
Gerrit-PatchSet: 5
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: client: make callid in MDCX mandatory
..
client: make callid in MDCX mandatory
An MDCX without call-id does not make much sense. The call-id is
an integr
Review at https://gerrit.osmocom.org/6077
TBF: override send function via linker option
Use --wrap linker facility to override pcu_sock_send() similar to other
Osmo* projects.
Change-Id: Ia3d436bd3d1fb0ce8e98526bd7457f4c57667ceb
---
M tests/Makefile.am
M tests/tbf/TbfTest.cpp
2 files changed,
Patch Set 1:
No need to maintain them as we are not using them. Furthermore, those functions
don't have proper support for IPv6 or IPv4v6 EUAs, so if somebody requires to
convert between them it's actually better to use in46a_to_eua or in46a_from_eua
which provide far better implementation. Is
Patch Set 1:
> My editor fixes it automatically which means otherwise every time I
> need to split the whitespace changes from my actual changes, so I
> think in the end it saves time from other people too.
I think you should be able to configure your editor to refrain from doing so.
It shou
Patch Set 1:
My editor fixes it automatically which means otherwise every time I need to
split the whitespace changes from my actual changes, so I think in the end it
saves time from other people too.
--
To view, visit https://gerrit.osmocom.org/6066
To unsubscribe, visit https://gerrit.osmoc
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5993
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2bcc3a68139e0d935790bcea2ef91eaf6291aa3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Accept SMS for any receiver
..
Accept SMS for any receiver
Accept any SMS and store it in the database, even if the receiver of
the message cannot be det
Harald Welte has submitted this change and it was merged.
Change subject: Delete expired SMS automatically.
..
Delete expired SMS automatically.
Delete expired SMS whenever we are done processing an SMS-related signal.
In order
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6075
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9afc36e2304f1060615219e88dd28821fb74e300
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6074
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d7493404ea05ce2e795958041bbb6cb75a04d31
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6072
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3e23b61a3521bd3c9002d3165ca8eff4361a35e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6071
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99b73f7a6d4100789fa92021c6ec9117869c881b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6069
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bc65ef9af1144779ee91a2c9b9887233ad15671
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 1: Code-Review-1
not really sure what we gain by this?
--
To view, visit https://gerrit.osmocom.org/6070
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00db99ba8de3f3d90e85bf593ed31555eedb439b
Gerrit-PatchSet: 1
Gerrit-Project
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6068
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbc6e4c912b958bde5916b87ec53c3c4db70bee0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6067
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I843071a090e877fd529e1e0b799df3585bf836d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 1: Code-Review+2
is this really worth our time? I wish we had less whitespace patches in our
review queue...
--
To view, visit https://gerrit.osmocom.org/6066
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I636c81d0c0ff53c97e6
Review at https://gerrit.osmocom.org/6075
gtp/gtp.c: Use uint8_t for version param in static functions
Change-Id: I9afc36e2304f1060615219e88dd28821fb74e300
---
M gtp/gtp.c
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/75/607
Review at https://gerrit.osmocom.org/6070
gtp/pdp: Remove unused APIs pdp_ntoeua pdp_euaton
Change-Id: I00db99ba8de3f3d90e85bf593ed31555eedb439b
---
M gtp/pdp.c
M gtp/pdp.h
2 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/70/60
Review at https://gerrit.osmocom.org/6073
gtp/gtp.c: Mark non exported functions as static
Functions not exported in gtp.h should be static.
There's no need to mark functions as extern in the .c file.
Change-Id: Ie61d5c6e0ae45ef3885911cedf71c826ed1705d0
---
M gtp/gtp.c
1 file changed, 16 inser
Review at https://gerrit.osmocom.org/6067
gtp.c: Determine GTP version from header
Change-Id: I843071a090e877fd529e1e0b799df3585bf836d8
---
M gtp/gtp.c
1 file changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/67/6067/1
diff --git a/gtp
Review at https://gerrit.osmocom.org/6071
gtp.c: gtp_gpdu_ind: Convert ifelse to switch statement
Change-Id: I99b73f7a6d4100789fa92021c6ec9117869c881b
---
M gtp/gtp.c
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/71/6071/1
di
Review at https://gerrit.osmocom.org/6074
gtp/gtp.c: Remove unused function char2ul_t
Change-Id: I0d7493404ea05ce2e795958041bbb6cb75a04d31
---
M gtp/gtp.c
1 file changed, 0 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/74/6074/1
diff --git a/g
Review at https://gerrit.osmocom.org/6069
gtp/pdp: Fix trailing whitespace
Change-Id: I1bc65ef9af1144779ee91a2c9b9887233ad15671
---
M gtp/pdp.c
M gtp/pdp.h
2 files changed, 30 insertions(+), 30 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/69/6069/1
diff --git
Review at https://gerrit.osmocom.org/6072
gtp.c: gtp_gpdu_ind: Early return to avoid use of uninitialized var
If the version received is not known, pdp is then uninitalized so we
should not be using it. Let's return an error to inform the caller.
Change-Id: Ib3e23b61a3521bd3c9002d3165ca8eff436
Review at https://gerrit.osmocom.org/6068
gtp.c: Log unsupported GTP version number
Change-Id: Idbc6e4c912b958bde5916b87ec53c3c4db70bee0
---
M gtp/gtp.c
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/68/6068/1
diff --git a/g
Review at https://gerrit.osmocom.org/6066
gtp.c: Fix trailing whitespace
Change-Id: I636c81d0c0ff53c97e6aedbc00f90c1325a3d607
---
M gtp/gtp.c
1 file changed, 28 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/66/6066/1
diff --git a/gtp/gtp.c b/
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/6050/1//COMMIT_MSG
Commit Message:
Line 18: Change-Id: I1c457c1eac20188f67b8379a36cfda3a085fcef4
cosmetic: is it related to https://osmocom.org/issues/2855?
https://gerrit.osmocom.org/#/c/6050/1/src/libmsc/vty_interface_layer3.c
File sr
Max has submitted this change and it was merged.
Change subject: cosmetic: fix whitespace issue with include files
..
cosmetic: fix whitespace issue with include files
Change-Id: I401fe88f5bd1665becd6fe6d4204b3877d548ccc
---
M
Harald Welte has submitted this change and it was merged.
Change subject: Remove an unused variable.
..
Remove an unused variable.
Local variable is_lu in rsl_rx_chan_rqd() has been unused
since commit 6082a377f57901302816a2e57
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6064
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67594afcfa4104e91352d50f40ae9f2bc20f4cd1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Add a VTY command which deletes all expired SMS.
..
Add a VTY command which deletes all expired SMS.
We already delete SMS which have been sent successfu
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6065
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I401fe88f5bd1665becd6fe6d4204b3877d548ccc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5989
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6093b7b5d8db84b19a0aa47c68182566113ee2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Add multislot classes from latest spec
..
Add multislot classes from latest spec
The table B.1 is copy-pasted from 3GPP TS 45.002 and reformatted via
Ema
Harald Welte has submitted this change and it was merged.
Change subject: AllocTest: expand test output
..
AllocTest: expand test output
* print MS classes
* unify and print test mode description
* print additional info on test
Harald Welte has submitted this change and it was merged.
Change subject: Add tests for find_multi_slots()
..
Add tests for find_multi_slots()
* make function public
* add tests
Change-Id: I4174703808335c19341cd5b5f4422496d958
Harald Welte has submitted this change and it was merged.
Change subject: AllocTest: adjust test_alloc_b()
..
AllocTest: adjust test_alloc_b()
This function contains 3 independent test cases. Let's split them into
separate func
Harald Welte has submitted this change and it was merged.
Change subject: AllocTest: remove assumption on max MS class
..
AllocTest: remove assumption on max MS class
So far the allocation was only tested up to hardcoded MS cla
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4072
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ef2eb99c517f25e7d1e71b985a3e0eb3879eb2c
Gerrit-PatchSet: 11
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerr
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4958
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7737f303d97197ef159b14a19c3312a11f07b433
Gerrit-PatchSet: 8
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4957
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a4b8f561a9677f4e9ded33a051a249bd15a6a2
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4960
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7e03a85ce96e7d617cecee963759bae589a3a1a
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4636
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4174703808335c19341cd5b5f4422496d958967f
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5997
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I833c3abd290d2bc5fceec7457e3933c9600e6c24
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6064
to look at the new patch set (#2).
Remove an unused variable.
Local variable is_lu in rsl_rx_chan_rqd() has been unused
since commit 6082a377f57901302816a2e57e75a3f262b7b7e6.
Change-Id
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6053
to look at the new patch set (#2).
Move PDCH-related functions into separate file
The PDCH class and corresponding functions are rather self-contained and
independent from BTS implement
Review at https://gerrit.osmocom.org/6065
cosmetic: fix whitespace issue with include files
Change-Id: I401fe88f5bd1665becd6fe6d4204b3877d548ccc
---
M src/pcu_vty_functions.cpp
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/65/6
Patch Set 1:
I created a task realted to this one a few days ago:
https://osmocom.org/issues/2859
You may want to reference it in the commit and update it acordingly.
--
To view, visit https://gerrit.osmocom.org/6064
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageTyp
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6063
to look at the new patch set (#2).
Improve an error message in page_lai_and_lac()
This error message is now contained in a loop, and the current iteration
does not know whether paging w
Review at https://gerrit.osmocom.org/6064
Remove an unused variable.
Local variable is_lu in rsl_rx_chan_rqd() has been unused
since cOmmit 6082a377f57901302816a2e57e75a3f262b7b7e6.
Change-Id: I67594afcfa4104e91352d50f40ae9f2bc20f4cd1
---
M src/libbsc/abis_rsl.c
1 file changed, 0 insertions(+)
Review at https://gerrit.osmocom.org/6063
Improve an error message in page_lai_and_lac()
This error message is now contained in a loop, and the current iteration
does not know whether paging will fail entirely or if later iterations
will succeed. Update the error message accordingly.
This also
Patch Set 1:
> This seems fine as a quick fix for now,but I'd guess in the long
> term we should asynchronously start a procedure to check if the
> subscriber exists and then send a response back to the MS. If we
> agree that's the best way we can perhaps create a task to not
> forget about i
Patch Set 1:
This seems fine as a quick fix for now,but I'd guess in the long term we should
asynchronously start a procedure to check if the subscriber exists and then
send a response back to the MS. If we agree that's the best way we can perhaps
create a task to not forget about it?
--
To
Patch Set 1:
> Shouldn't we be checking if we can find the subscriber in the
> VLR/HLR instead of blindly accepting?
The VLR/HLR might not be reachable, and we need to immediately ack or reject
the SMS. Harald suggested that it's easier to simply accept any message and
deal with non-existing
Patch Set 1:
This cannot be merged yet because it depends on
https://gerrit.osmocom.org/#/c/5989/
--
To view, visit https://gerrit.osmocom.org/5997
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I833c3abd290d2bc5fceec7457e3933c9600e6c24
Patch Set 2:
This cannot be merged yet because it depends on
https://gerrit.osmocom.org/#/c/5989/
--
To view, visit https://gerrit.osmocom.org/5996
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56cbe716e52b679c4b94f6cbb4a171306975be2e
Patch Set 1:
> The real problem is that somebody hands a too long IMSI to the encoder
Sure, that's not a complete fix, it's just small part of it. We also need TTCN
test, libosmocore test, fix for long imsi source etc.
--
To view, visit https://gerrit.osmocom.org/6010
To unsubscribe, visit ht
Patch Set 1:
This is related to #5994. My problem is that I need some unique number as
session ID. I think the call-id serves this purpose. But since the session
id in the "o" field of the SDP section is mandatory we need to have the
session ID mandatory too. What do you think?
In RFC3435 chapte
84 matches
Mail list logo
