osmo-msc[master]: remove unused VTY command "location updating reject cause"

2018-02-13 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6415 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f39e706477aaf42051877b52d4b3ae1c5f138e Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: remove unused VTY command "location updating reject cause"

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: remove unused VTY command "location updating reject cause" .. remove unused VTY command "location updating reject cause" OsmoMSC is using whatever

[PATCH] osmo-msc[master]: remove dead code (gsm_parse_reg)

2018-02-13 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6423 to look at the new patch set (#2). remove dead code (gsm_parse_reg) Change-Id: I47b0260561a9c2bad65c50c8164873e4c23d61b7 --- M include/osmocom/msc/gsm_data_shared.h M

[PATCH] osmo-msc[master]: remove unused "auth policy" VTY command

2018-02-13 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6417 to look at the new patch set (#3). remove unused "auth policy" VTY command This is yet another unsused bit from the OsmoNITB legacy. Related: OS#2528 Change-Id:

[PATCH] osmo-msc[master]: remove unused "authorized-regexp" VTY command

2018-02-13 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6416 to look at the new patch set (#3). remove unused "authorized-regexp" VTY command This is another left-over VTY command from the OsmoNITB days. If such functionality is desired, it

[MERGED] osmo-hlr[master]: osmo-hlr: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-hlr: Add talloc context introspection via VTY .. osmo-hlr: Add talloc context introspection via VTY This requires libosmocore with Change-Id

osmo-hlr[master]: osmo-hlr: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6421 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2c333b83f85fa69a364e3e342f12f50dbc2f70 Gerrit-PatchSet: 3 Gerrit-Project: osmo-hlr Gerrit-Branch: master

[PATCH] osmo-msc[master]: remove unused VTY command "location updating reject cause"

2018-02-13 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6415 to look at the new patch set (#3). remove unused VTY command "location updating reject cause" OsmoMSC is using whatever reject cause is apropriate in the given situation. This

[PATCH] osmo-hlr[master]: osmo-hlr: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6421 to look at the new patch set (#3). osmo-hlr: Add talloc context introspection via VTY This requires libosmocore with Change-Id I43fc42880b22294d83c565ae600ac65e4f38b30d or later.

osmo-bsc[master]: osmo-bsc: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6420 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1245b6818eb54f5c0c8adddcd3a01ecc7363fb42 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: osmo-bsc: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bsc: Add talloc context introspection via VTY .. osmo-bsc: Add talloc context introspection via VTY This requires libosmocore with Change-Id

[MERGED] osmo-sgsn[master]: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add talloc context introspection via VTY .. Add talloc context introspection via VTY This requires libosmocore with Change-Id

osmo-bsc[master]: osmo-bsc: Add talloc context introspection via VTY

2018-02-13 Thread Vadim Yanitskiy
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6420 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1245b6818eb54f5c0c8adddcd3a01ecc7363fb42 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-msc[master]: osmo-msc: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-msc: Add talloc context introspection via VTY .. osmo-msc: Add talloc context introspection via VTY This requires libosmocore with Change-Id

osmo-msc[master]: osmo-msc: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6422 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I575500bd911f9792ab5ca76eebb1d2682ee34fa3 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-bsc[master]: drop libcommon-cs completely

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6443 drop libcommon-cs completely Change-Id: I07d4a48af3154ee4d904686f230a51b8b8a94ff9 --- M configure.ac M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/common_bsc.h D include/osmocom/bsc/common_cs.h M include/osmocom/bsc/gsm_data.h M

[PATCH] osmo-bsc[master]: libcommon_cs: move gsm48 bits to libbsc

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6440 libcommon_cs: move gsm48 bits to libbsc These functions were originally shared between libmsc and libbsc in the old openbsc.git; now osmo-bsc.git has its own copies, so move them into libbsc. Change-Id: Ie411c2ce8008accee54782a442d6361e50777a54 --- M

[PATCH] osmo-bsc[master]: temp dev: make osmo-bsc_nat compile

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6427 temp dev: make osmo-bsc_nat compile Change-Id: I165499762956b95ebd77c7670dc0ba0d03df59c6 --- M configure.ac M src/Makefile.am M src/osmo-bsc_nat/Makefile.am M src/osmo-bsc_nat/bsc_nat.c 4 files changed, 7 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-bsc[master]: libcommon: eliminate bsc_version.h

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6428 libcommon: eliminate bsc_version.h Move the copyright string into osmo_bsc_main.c. No other users of it exist. Change-Id: I7f48924f484e4e4b98be4ca8bee253e6ea9c0576 --- M src/libcommon/Makefile.am D src/libcommon/bsc_version.c M

[PATCH] osmo-bsc[master]: libcommon-cs: move vty bits to libbsc/bsc_vty.c

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6441 libcommon-cs: move vty bits to libbsc/bsc_vty.c The gsm_network VTY was partly shared between libmsc and libbsc in the old openbsc.git; now osmo-bsc.git has its own copy, so merge all of it into bsc_vty.c. This leaves common_cs_vty.c practically

[PATCH] osmo-bsc[master]: libcommon: eliminate talloc_ctx.c

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6432 libcommon: eliminate talloc_ctx.c Interestingly enough, talloc_ctx_init() actually had not a single caller. While dropping it, see to it that the few contexts that are actually used in osmo-bsc.git are indeed initialized in all the main scopes. Also

[PATCH] osmo-bsc[master]: libcommon-cs: move a_reset.c into libbsc

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6437 libcommon-cs: move a_reset.c into libbsc a_reset.c was originally used by both libmsc and libbsc in the old openbsc.git repository. Now osmo-msc.git has its own copy, and the idea of sharing libcommon-cs is no longer applicable. Move it to libbsc where

[PATCH] osmo-bsc[master]: ipaccess-proxy: don't redefine tall_bsc_ctx

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6433 ipaccess-proxy: don't redefine tall_bsc_ctx Curiously, ipaccess-proxy.c is able to define its own tall_bsc_ctx even though the same should already be linked from gsm_data.c. Declare it extern instead and hence use the one from gsm_data.c. A linking

[PATCH] osmo-bsc[master]: libcommon-cs: move gsm_network_init() into bsc_network_init()

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6438 libcommon-cs: move gsm_network_init() into bsc_network_init() Some part of the network init was common between libbsc and libmsc in the old openbsc.git repository. Now osmo-bsc.git is independent with its own copy of the gsm_network initialization. So

[PATCH] osmo-bsc[master]: gsm_network: drop unused subscr_epxire_timer

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6445 gsm_network: drop unused subscr_epxire_timer Change-Id: I2e34ffb35e244472f8bfc993facc8d6e130f10d9 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc

[PATCH] osmo-bsc[master]: drop unused common.h

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6444 drop unused common.h Change-Id: I7cf4076d7e36ae71d88e70a86d5c2d0640c1146f --- M include/osmocom/bsc/Makefile.am D include/osmocom/bsc/common.h M include/osmocom/bsc/gsm_data.h 3 files changed, 0 insertions(+), 8 deletions(-) git pull

[PATCH] osmo-bsc[master]: libcommon: eliminate socket.c

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6431 libcommon: eliminate socket.c Replace calls to make_sock() with osmo_sock_init_ofd(). Shame on me for not testing every single one in practice, I hope for peer review to confirm that this should be correct... Read closely please! The IPPROTO_GRE

[PATCH] osmo-bsc[master]: libcommon: eliminate debug.c

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6430 libcommon: eliminate debug.c Provide concise log categories for each main scope. Move the complete log categories 1:1 to osmo_bsc_main.c. In bsc_nat.c, omit obviously unused log categories. In tests, omit almost all log categories, except for those

[PATCH] osmo-bsc[master]: drop libcommon completely

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6436 drop libcommon completely Change-Id: Ifa3486f04cdd5fda1e92630dfc1a5f670773bc14 --- M configure.ac M src/Makefile.am M src/ipaccess/Makefile.am D src/libcommon/Makefile.am M src/osmo-bsc/Makefile.am M src/osmo-bsc_nat/Makefile.am M src/utils/Makefile.am

[PATCH] osmo-bsc[master]: gsm_network: drop unused trans_list

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6439 gsm_network: drop unused trans_list Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 --- M include/osmocom/bsc/gsm_data.h M src/libbsc/net_init.c 2 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc

[PATCH] osmo-bsc[master]: libcommon: eliminate common_vty.c

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6429 libcommon: eliminate common_vty.c Move bsc_vty_go_parent() to osmo_bsc_main.c, and greatly simplify. Since I24cbb3f6de111f2d31110c3c484c066f1153aac9 ("VTY: implicit node exit by de-indenting, not parent lookup") in libosmocore, the go_parent_cb no

[PATCH] osmo-bsc[master]: libcommon: join gsm_data_shared.* into gsm_data.*

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6434 libcommon: join gsm_data_shared.* into gsm_data.* The separation of gsm_data_shared.* from gsm_data.* historically allowed compiling parts of it into osmo-bts, which we have dropped since (osmo-bts has its own copy now). Even though gsm_data.* now

[PATCH] osmo-bsc[master]: common_cs.h: mv gsm_encr to gsm_data.h

2018-02-13 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6442 common_cs.h: mv gsm_encr to gsm_data.h This leaves common_cs.h practically empty. Leave its removal to the next patch, which removes libcommon-cs entirely (I07d4a48af3154ee4d904686f230a51b8b8a94ff9). Change-Id:

[MERGED] osmo-ggsn[master]: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add talloc context introspection via VTY .. Add talloc context introspection via VTY This requires libosmocore with Change-Id

[MERGED] libosmocore[master]: talloc_ctx_vty: Fix help strings (missing \n at end of line)

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: talloc_ctx_vty: Fix help strings (missing \n at end of line) .. talloc_ctx_vty: Fix help strings (missing \n at end of line) This was causing build

libosmocore[master]: talloc_ctx_vty: Fix help strings (missing \n at end of line)

2018-02-13 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/6426 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I785c852e3313d20eade79746a7cd485d2d5908ea Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: build: Ensure all .pc files are installed

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: build: Ensure all .pc files are installed .. build: Ensure all .pc files are installed Change-Id: I824e63087021adfda81bd0f867a3fdb5e9efcf7a --- M

libosmocore[master]: build: Ensure all .pc files are installed

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6365 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I824e63087021adfda81bd0f867a3fdb5e9efcf7a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmo-sccp[master]: build: AC_PROG_LIBTOOL is the same as LT_INIT

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: build: AC_PROG_LIBTOOL is the same as LT_INIT .. build: AC_PROG_LIBTOOL is the same as LT_INIT Change-Id: I30f8d289d9dca892e40cd7ed787029fbcafa2dff ---

osmo-ggsn[master]: build: Remove AC_PROG_CXX, C++ is never used

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6366 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifda126ab2e5fdd98317e723aa6b10d964b4519c2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master

libosmo-sccp[master]: build: AC_PROG_LIBTOOL is the same as LT_INIT

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6367 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30f8d289d9dca892e40cd7ed787029fbcafa2dff Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

[MERGED] osmo-ggsn[master]: build: Remove AC_PROG_CXX, C++ is never used

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: build: Remove AC_PROG_CXX, C++ is never used .. build: Remove AC_PROG_CXX, C++ is never used Change-Id: Ifda126ab2e5fdd98317e723aa6b10d964b4519c2 --- M

[MERGED] gapk[master]: Add --enable-sanitize configure option

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add --enable-sanitize configure option .. Add --enable-sanitize configure option Change-Id: Ibb26e5fc73843f3951dbc534653ee7d88e4c80e7 --- M configure.ac

gapk[master]: tests: enable / disable codec tests conditionally

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6375 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4711294c43ff88b17431615883abf96d1ae02a6 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master

gapk[master]: Ignore build products

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6383 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master

gapk[master]: Add --enable-sanitize configure option

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6382 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb26e5fc73843f3951dbc534653ee7d88e4c80e7 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch:

[MERGED] gapk[master]: tests: enable / disable codec tests conditionally

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: tests: enable / disable codec tests conditionally .. tests: enable / disable codec tests conditionally As the libosmogapk actually relies on external

gapk[master]: Add basic CI integration

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 > External packages should be > added as build slave dependencies to ansible. Then please document/communicate this and make sure that all existing slaves (as well as future ones vi ansible) have those dpeendencies installed before creating a related jenkins job

[MERGED] osmo-ggsn[master]: sgsnemu: listen param is a host, not an interface

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sgsnemu: listen param is a host, not an interface .. sgsnemu: listen param is a host, not an interface This param is parsed by gethostbyname() and it's

osmo-ggsn[master]: sgsnemu: listen param is a host, not an interface

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6391 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8ef0e12ddcaf8bfd199a44de0ba4280f05d4431 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master

osmo-ggsn[master]: sgsnemu: Fix bad ptr during context deallocation

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6392 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e563522173a82b265e93b1ef9dc93ced40fefa2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master

[MERGED] osmo-ggsn[master]: sgsnemu: Fix bad ptr during context deallocation

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sgsnemu: Fix bad ptr during context deallocation .. sgsnemu: Fix bad ptr during context deallocation Older commit switched pdp_t to have an array of 2

[MERGED] osmo-ggsn[master]: sgsnemu: fix: no outgoing GTP-U in "createif" mode

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sgsnemu: fix: no outgoing GTP-U in "createif" mode .. sgsnemu: fix: no outgoing GTP-U in "createif" mode in "createif" mode uplink traffic not

osmo-ggsn[master]: sgsnemu: fix: no outgoing GTP-U in "createif" mode

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6385 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd58450548b3a47cb933d70a2e3166c067552b2c Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master

[MERGED] libosmocore[master]: gsmtap.h: define TETRA DMO mode channels

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsmtap.h: define TETRA DMO mode channels .. gsmtap.h: define TETRA DMO mode channels Change-Id: I98976c0ff16a69b2508a79259ed1aeaec51e7549 --- M

libosmocore[master]: gsmtap.h: define TETRA DMO mode channels

2018-02-13 Thread Harald Welte
Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/6376 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98976c0ff16a69b2508a79259ed1aeaec51e7549 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore

[MERGED] osmo-ttcn3-hacks[master]: bsc: Add VTY module to BSC_Tests

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc: Add VTY module to BSC_Tests .. bsc: Add VTY module to BSC_Tests Change-Id: Ia78f1231f56fc5f3b003bccc850ea109ed4ed2d8 --- M bsc/BSC_Tests.cfg M

osmo-ttcn3-hacks[master]: WIP: Prepare MSC_Tests for ability to emulate two BSCs

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6393 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe3ae6ed4181c6ba7501f5443b4f22e3c8abeb3e Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: WIP: Intra-BSC handover testing

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: WIP: Intra-BSC handover testing .. WIP: Intra-BSC handover testing Change-Id: Ic47e639a7c8640c736c84a44780fc8e111a64b52 --- M bsc/BSC_Tests.ttcn M

[MERGED] osmo-ttcn3-hacks[master]: WIP: Prepare MSC_Tests for ability to emulate two BSCs

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: WIP: Prepare MSC_Tests for ability to emulate two BSCs .. WIP: Prepare MSC_Tests for ability to emulate two BSCs Change-Id:

osmo-ttcn3-hacks[master]: WIP: Intra-BSC handover testing

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6398 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47e639a7c8640c736c84a44780fc8e111a64b52 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: MSC_ConnectionHdlr: Add telnet to VTY to each ConnHdlr

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: MSC_ConnectionHdlr: Add telnet to VTY to each ConnHdlr .. MSC_ConnectionHdlr: Add telnet to VTY to each ConnHdlr This allows each ConnHandler to issue

[MERGED] osmo-ttcn3-hacks[master]: RSL_Emulation: Add procedure calls to suspend/resume dchan h...

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL_Emulation: Add procedure calls to suspend/resume dchan handling .. RSL_Emulation: Add procedure calls to suspend/resume dchan handling We introduce

[MERGED] osmo-ttcn3-hacks[master]: RSL_Emulation: Add second RSL/RSL_PROC port for hand-over cases

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL_Emulation: Add second RSL/RSL_PROC port for hand-over cases .. RSL_Emulation: Add second RSL/RSL_PROC port for hand-over cases Also, extend

osmo-ttcn3-hacks[master]: RSL_Emulation: Add procedure calls to suspend/resume dchan h...

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6396 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibef65f87d0d481accbc0e019874dd43b3f9a5dbc Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-msc[master]: VLR: fix potential NULL dereference

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/6388/1/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: Line 3718: conn->vsub = vlr_subscr_get(vsub); a NULL return is only possible if 'vsub' is NULL. I don't think this is valid here. Read the comment above the

libosmo-sccp[master]: SS7: return error on stream opening error

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review-2 we are asking osmo_stream_cli_open2() to do re-connects, so a one-time negative result is just an intermediate notification, and not a final outcome. libosmo-netif will continue to retry to connect. -- To view, visit https://gerrit.osmocom.org/6407 To unsubscribe,

libosmocore[master]: talloc_ctx_vty: Fix help strings (missing \n at end of line)

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6426 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I785c852e3313d20eade79746a7cd485d2d5908ea Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: talloc_ctx_vty: Fix help strings (missing \n at end of line)

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6426 talloc_ctx_vty: Fix help strings (missing \n at end of line) This was causing build failures in applications using this library feature: Documentation error (missing docs): Documentation error (missing docs): Documentation error

osmo-sgsn[master]: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6424 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50eb1c5a28efbe4542e177ce3d0a236e75eecdd0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

osmo-ggsn[master]: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6425 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460efff3a3dfa2c7d955871aca78b37552a29aff Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master

[PATCH] osmo-ggsn[master]: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6425 Add talloc context introspection via VTY This requires libosmocore with Change-Id I43fc42880b22294d83c565ae600ac65e4f38b30d or later. Change-Id: I460efff3a3dfa2c7d955871aca78b37552a29aff --- M ggsn/ggsn.c 1 file changed, 3 insertions(+), 0

[PATCH] osmo-sgsn[master]: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6424 Add talloc context introspection via VTY This requires libosmocore with Change-Id I43fc42880b22294d83c565ae600ac65e4f38b30d or later. Change-Id: I50eb1c5a28efbe4542e177ce3d0a236e75eecdd0 --- M src/gprs/gb_proxy_main.c M src/gprs/gtphub_main.c M

[MERGED] libosmo-abis[master]: IPA: log remote address

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: IPA: log remote address .. IPA: log remote address Wrap IPA logging to always print peer's address to simplify troubleshooting. Change-Id:

libosmo-abis[master]: IPA: log remote address

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6408 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19ebaea45812aad6b3d3480cac0f1f833daf428d Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master

[PATCH] osmo-msc[master]: remove dead code (gsm_parse_reg)

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6423 remove dead code (gsm_parse_reg) Change-Id: I47b0260561a9c2bad65c50c8164873e4c23d61b7 --- M include/osmocom/msc/gsm_data_shared.h M src/libcommon/gsm_data.c 2 files changed, 0 insertions(+), 32 deletions(-) git pull

[PATCH] osmo-msc[master]: remove unused VTY command "location updating reject cause"

2018-02-13 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6415 to look at the new patch set (#2). remove unused VTY command "location updating reject cause" OsmoMSC is using whatever reject cause is apropriate in the given situation. This

[PATCH] osmo-msc[master]: remove unused "authorized-regexp" VTY command

2018-02-13 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6416 to look at the new patch set (#2). remove unused "authorized-regexp" VTY command This is another left-over VTY command from the OsmoNITB days. If such functionality is desired, it

[PATCH] osmo-msc[master]: osmo-msc: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6422 osmo-msc: Add talloc context introspection via VTY This requires libosmocore with Change-Id I43fc42880b22294d83c565ae600ac65e4f38b30d or later. Change-Id: I575500bd911f9792ab5ca76eebb1d2682ee34fa3 --- M src/osmo-msc/msc_main.c 1 file changed, 3

[PATCH] osmo-msc[master]: remove unused "auth policy" VTY command

2018-02-13 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6417 to look at the new patch set (#2). remove unused "auth policy" VTY command This is yet another unsused bit from the OsmoNITB legacy. Related: OS#2528 Change-Id:

[MERGED] osmo-msc[master]: remove unused dyn_ts_allow_tch_f VTY option

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: remove unused dyn_ts_allow_tch_f VTY option .. remove unused dyn_ts_allow_tch_f VTY option This belongs into the BSC and has no relevance in the MSC, as

[MERGED] osmo-msc[master]: remove bsc_api.h and all users - they're all dead code

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: remove bsc_api.h and all users - they're all dead code .. remove bsc_api.h and all users - they're all dead code Related: OS#2528 Change-Id:

[MERGED] osmo-msc[master]: dead code removal

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: dead code removal .. dead code removal Related: OS#2528 Change-Id: I89157c446d66e11adbe3cad587eb34ec40271c12 --- M include/osmocom/msc/gsm_04_08.h M

[MERGED] osmo-msc[master]: gsm_data: remove unused gsm_subscriber_connection members

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm_data: remove unused gsm_subscriber_connection members .. gsm_data: remove unused gsm_subscriber_connection members The mncc_rtp_create_pending and

[PATCH] osmo-hlr[master]: osmo-hlr: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6421 osmo-hlr: Add talloc context introspection via VTY This requires libosmocore with Change-Id I43fc42880b22294d83c565ae600ac65e4f38b30d or later. Change-Id: Ibc2c333b83f85fa69a364e3e342f12f50dbc2f70 --- M src/hlr.c M src/hlr_vty.c 2 files changed, 3

[MERGED] osmo-bts[master]: osmo-bts: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bts: Add talloc context introspection via VTY .. osmo-bts: Add talloc context introspection via VTY This requires libosmocore with Change-Id

osmo-bts[master]: osmo-bts: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6418 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieed87b8109e0095a3d99c30f0b042aa3ee4b6384 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bsc[master]: vty: Permit codec-list containing both full-rate and half-ra...

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6419 vty: Permit codec-list containing both full-rate and half-rate codecs Once upon a time, in the old osmo-bsc-sccplite, there was a restriction of not being able to handle configurations with both TCH/F and TCH/H type codecs. This time is long gone, so

[PATCH] osmo-bsc[master]: osmo-bsc: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6420 osmo-bsc: Add talloc context introspection via VTY This requires libosmocore with Change-Id I43fc42880b22294d83c565ae600ac65e4f38b30d or later. Change-Id: I1245b6818eb54f5c0c8adddcd3a01ecc7363fb42 --- M src/libbsc/bsc_vty.c M

[PATCH] osmo-bts[master]: osmo-bts: Add talloc context introspection via VTY

2018-02-13 Thread Harald Welte
Review at https://gerrit.osmocom.org/6418 osmo-bts: Add talloc context introspection via VTY This requires libosmocore with Change-Id I43fc42880b22294d83c565ae600ac65e4f38b30d or later. Change-Id: Ieed87b8109e0095a3d99c30f0b042aa3ee4b6384 --- M src/common/main.c M src/common/vty.c 2 files

[MERGED] osmo-sgsn[master]: .gitignore: Add m4 files

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: .gitignore: Add m4 files .. .gitignore: Add m4 files Existing m4/ax_check_compile_flag.m4 is skipped from the list of ignored files. Change-Id:

osmo-msc[master]: remove unused "auth policy" VTY command

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6417 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825e659da529257e5edec94d9d59f0e10c1b4c63 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-sgsn[master]: .gitignore: Add m4 files

2018-02-13 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

osmo-msc[master]: remove unused VTY command "location updating reject cause"

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6415 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f39e706477aaf42051877b52d4b3ae1c5f138e Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: remove unused "authorized-regexp" VTY command

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf0897c47388e49ba7886b55acc728a6f7d213fe Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-sgsn[master]: sgsn_libgtp.c: Fix typos and whitespace

2018-02-13 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sgsn_libgtp.c: Fix typos and whitespace .. sgsn_libgtp.c: Fix typos and whitespace Change-Id: Ic223cf378a83051603f58dacf087cc59d9f03890 --- M

osmo-msc[master]: remove bsc_api.h and all users - they're all dead code

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6412 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I332aa8697c98a0d7b3db65f98711275da3d381d7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: remove unused dyn_ts_allow_tch_f VTY option

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6414 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa41d22db81120572d4cd2c0c4c75d258947a42f Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: dead code removal

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6413 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89157c446d66e11adbe3cad587eb34ec40271c12 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: gsm_data: remove unused gsm_subscriber_connection members

2018-02-13 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6411 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I417e23ec53323ddd8e1e5d18952566fe8fd6ac24 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

  1   2   >