Review at https://gerrit.osmocom.org/6517
Makefile: Build gtp-{link,tunnel} by default, but don't install them
They used to be in check_programs, but then this would only build them
during 'make check' which not everyone knows or is using.
Change-Id: Idd2b3a66e5968686e6bbff59dbc89b7673def8dd
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6515
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51431ae7baca33ce5bab085cc3efe25f1a10b6d1
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6514
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf64ed9b14247298ed8b4ab8735627f8235a499
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6513
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I099ae1c663c018da5db884f7e9d52c45af3ed817
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6512
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3266ce36442024f16eaf6afa3f516d201930c41
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6516
utils: add osmo-gsmtap-sink, simplistic UDP receiver
Yes, I know, but this is even simpler than a netcat.
Change-Id: I85499af06bc5a0d757f6071779075e57bb435930
---
M utils/Makefile.am
A utils/osmo-gsmtap-sink.c
2 files changed, 121 insertions(+), 1
Review at https://gerrit.osmocom.org/6515
memleak: _gsmtap_raw_output(): free msg in case of vsnprintf failure
Don't just return, free the allocated msg first.
Change-Id: I51431ae7baca33ce5bab085cc3efe25f1a10b6d1
---
M src/logging_gsmtap.c
1 file changed, 3 insertions(+), 1 deletion(-)
Review at https://gerrit.osmocom.org/6514
memleak: fix all libosmocore callers of gsmtap_sendmsg() to free on failure
gsmtap_sendmsg() does not free the msgb if it returns a failure rc, so the
callers must check the rc and free the msg.
Change-Id: I7cf64ed9b14247298ed8b4ab8735627f8235a499
---
Review at https://gerrit.osmocom.org/6513
memleak: gsmtap_sendmsg(): don't return 0 when no data was written
If less than the msgb size was written by write(), we want to return -EIO.
Hence do not return zero when write() wrote zero bytes, return -EIO in that
case as well.
Previously, if
Review at https://gerrit.osmocom.org/6512
gsmtap_sendmsg(): clarify API doc concerning msgb ownership
Not freeing on error does enable callers to try to re-send as well, so it is a
kind of useful feature, even though I find it likely for callers to either
forget about freeing the msg on error
Harald Welte has submitted this change and it was merged.
Change subject: ttcn3 gerrit verification: Use 'make deps-update' target
..
ttcn3 gerrit verification: Use 'make deps-update' target
In osmo-ttcn3-hacks
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/6511
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabc54182d1d30ef26e4f72fb9db52fd25a6c9800
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: libmsc: bssap: Catch TLV parse failures
..
libmsc: bssap: Catch TLV parse failures
Change-Id: I1d1951f4a5daf200e85c76fea14a35e952491d27
---
M
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: libmsc: bssap: Refactor rx paths to to avoid parse_tlv code
duplication
..
libmsc: bssap: Refactor rx paths to to avoid parse_tlv code duplication
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/5424/4/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:
Line 313: memcpy(msg->l3h, TLVP_VAL(tp, GSM0808_IE_LAYER_3_INFORMATION),
msgb_l3len(msg));
> I still don't get why we would want to copy the payload here. The
Review at https://gerrit.osmocom.org/6511
ttcn3 gerrit verification: Use 'make deps-update' target
In osmo-ttcn3-hacks Idc165425b45872d2eb958a662d03e69aaf60669d
we introduced the new 'deps-update' Makefile target to properly
update all 'deps' repositories without removing them. Let's use it.
Harald Welte has submitted this change and it was merged.
Change subject: fsm: Add a function to change the FSM instance ID later
..
fsm: Add a function to change the FSM instance ID later
Sometimes we want to create an FSM
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6316
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic216e5b11d4440f8e106a297714f4f06c1152945
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6510
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I627fe10e1f5c1f2f23745c906320871024b5c8c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: bts chan_load: ignore unusable BTS
..
bts chan_load: ignore unusable BTS
For unconnected BTS, the channel load would report a "bogus channel load
Review at https://gerrit.osmocom.org/6510
bts chan_load: ignore unusable BTS
For unconnected BTS, the channel load would report a "bogus channel load
sample" every second (on RLL debug). Instead, skip unusable BTS.
This follows up on commit 6cee893a0f2c4e53155a2631aff12a5f615b973d /
Review at https://gerrit.osmocom.org/6509
Support decoding of more cell ID list types in libosmocore.
Extend gsm0808_dec_cell_id_list() with support for more types of
cell identifier lists. The new parsing routines are based on similar
routines used by the paging code in
Review at https://gerrit.osmocom.org/6506
deps/Makefile: Use "git remote set-url" to catch URL changes
In the past, we sometimes had to switch a repository URL (e.g. from
official git repo ot osmocom fork with patches/fixes). The existing
Makefile didn't pick this up during "make update".
Harald Welte has submitted this change and it was merged.
Change subject: Makefile: Add 'deps-update' target to update the deps-repository
..
Makefile: Add 'deps-update' target to update the deps-repository
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: deps/Makefile: Separate 'distclean' from 'clean'
..
deps/Makefile: Separate 'distclean' from 'clean'
'distclean' removes the actual git clones, while
Review at https://gerrit.osmocom.org/6508
Makefile: Add 'deps-update' target to update the deps-repository
Change-Id: Idc165425b45872d2eb958a662d03e69aaf60669d
---
M Makefile
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6508
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc165425b45872d2eb958a662d03e69aaf60669d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6507
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5de68644b397ff7fbca0595a8900b41508d59bde
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6506
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d699ad5087f438e64b84c2e5c6e7320cb9457f6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Review at https://gerrit.osmocom.org/6507
deps/Makefile: Separate 'distclean' from 'clean'
'distclean' removes the actual git clones, while 'clean' now simply
ensures that there are no local changes between to index.
Change-Id: I5de68644b397ff7fbca0595a8900b41508d59bde
---
M deps/Makefile
1
Harald Welte has submitted this change and it was merged.
Change subject: deps/Makefile: Use "git remote set-url" to catch URL changes
..
deps/Makefile: Use "git remote set-url" to catch URL changes
In the past, we sometimes
Harald Welte has submitted this change and it was merged.
Change subject: ttcn3-tcpdump-start.sh: Wait for tcpdump to start recording
..
ttcn3-tcpdump-start.sh: Wait for tcpdump to start recording
We generate some fake transit
Harald Welte has submitted this change and it was merged.
Change subject: ttcn3-tcpdump-start.sh: Wait for pcap file creation to start
test
..
ttcn3-tcpdump-start.sh: Wait for pcap file creation to start test
It was spotted
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6483
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I240d8f1bdb2ca6ad353e60ef15937dc2bd4cbebd
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: ttcn3-tcpdump-stop.sh: Wait to receive last packets before
stopping tcpdump
..
ttcn3-tcpdump-stop.sh: Wait to receive last packets before stopping
Harald Welte has submitted this change and it was merged.
Change subject: ttcn3-tcpdump-start.sh: Log tcpdump output to file
..
ttcn3-tcpdump-start.sh: Log tcpdump output to file
This can be useful in case there was an error
Harald Welte has submitted this change and it was merged.
Change subject: MSC_Tests.f_tc_mo_crcx_ran_reject(): Send release complete to
release
..
MSC_Tests.f_tc_mo_crcx_ran_reject(): Send release complete to release
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6492
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9188111da744f0aafaac02841d36a957bfc8d86
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: MSC_Tests: Set verdicts from inconc to fail
..
MSC_Tests: Set verdicts from inconc to fail
Channels not being closed/cleared at the end of the test is a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6491
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a19541f3276b994ed34a1d3f9920010660a2ddd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 3:
put it back to what it was before, showing hopping TS needs more reflection and
a considerably larger patch...
So, in the presence of hopping TS, the TRX's configured ARFCN has absolutely no
meaning? Otherwise we could merge this as-is and follow up later?
--
To view, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6478
to look at the new patch set (#3).
vty: 'show bts': list the TRXs' ARFCNs
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bsc_vty.c
1 file changed, 8
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 285: vty_out(vty, " ARFCNs:");
> well, I'll believe you right away because this is the first time I've heard
actually the hopping is in the trx->ts, so I need to iterate
Patch Set 2:
argh, it helps to actually compile before submitting m(
--
To view, visit https://gerrit.osmocom.org/6478
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
Gerrit-PatchSet: 2
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6478
to look at the new patch set (#2).
vty: 'show bts': list the TRXs' ARFCNs / MAIO+HSN
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bsc_vty.c
1 file changed, 12
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 285: vty_out(vty, " ARFCNs:");
> looks like this would only work for non-hopping TRXs. I guess we should ha
well, I'll believe you right away because this is the first
Review at https://gerrit.osmocom.org/6504
libmsc: Bump conn FSM on trans_free()
Bumping the conn ensures that the subscriber connection will be closed
if necessary.
Change-Id: I131313aa326dd01b3e81e1ade18a4afd32385c15
---
M src/libmsc/transaction.c
1 file changed, 4 insertions(+), 1
Review at https://gerrit.osmocom.org/6502
libmsc: Add a function to return a unique ID of the subscriber conn
The ID will include the type of connection (GERAN_A, UTRAN_IU) followed
by the SCCP conn_id.
This can be used for the fsm instance ID before we know the IMSI.
Change-Id:
Review at https://gerrit.osmocom.org/6501
iucs: Add a function to return the connection ID for the IU SCCP conn
Change-Id: Ica4a7f463fcf1bd67fe082296cecea8d10f2fc5b
---
M include/osmocom/msc/iucs.h
M src/libmsc/iu_dummy.c
M src/libmsc/iucs.c
3 files changed, 12 insertions(+), 0 deletions(-)
Review at https://gerrit.osmocom.org/6503
libmsc: Close connection after sending a service reject
After we send an MM service reject we should close the connection. Make
sure that we have an fsm instance in any case and signal it to close the
connection right away - not just after a timeout.
Review at https://gerrit.osmocom.org/6505
libmsc: Pretend MNCC requested release in handle_error()
Send a release request to the MS so the connection does not stay open
indefinitely.
Change-Id: I7669d29cf5be3e4a60a1d121edbfcf9056f6d82b
---
M src/libmsc/msc_mgcp.c
1 file changed, 11
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6468
to look at the new patch set (#2).
HO: move penalty timers to own file as proper API
Separate penalty timers API from specific struct members and move to own .h/.c
file, so that future
Review at https://gerrit.osmocom.org/6497
HO: introduce ho decision callbacks
Instead of reacting on S_LCHAN* signals in the handover decision code,
introduce callbacks for the handover decision to be invoked by handover_logic.c
at the appropriate time.
The rationale is explained in a comment
Review at https://gerrit.osmocom.org/6494
handover_logic.c: on HO command, send new lchan's MS power
Change-Id: I90eda8405f2d2eddfb041ca38b34fe30c397e09d
---
M src/libbsc/handover_logic.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/6499
HO: Implement load based handover, as handover_decision_2.c
Change-Id: Ie597eae82722baf32546331e443dd9d94f1f25e6
---
M configure.ac
M doc/examples/osmo-bsc/osmo-bsc.cfg
M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg
M include/osmocom/bsc/Makefile.am
Review at https://gerrit.osmocom.org/6498
HO: cosmetic: getting a chan activ nack on a non-ho lchan is not an error
Change-Id: I66c4f45afda614f874c9cdf0c22552f492315b71
---
M src/libbsc/handover_logic.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6500
HO: vty: rename ho decision 1 vty to 'handover1' with 'handover' alias
Handover decision 2 arguments are now configured by 'handover2 foo'. To match
that scheme, rename the previously 'handover foo' args for handover decision 1
to 'handover1 foo'.
For
Review at https://gerrit.osmocom.org/6495
HO: clearly mark conn penalty timer member for hodec2
The conn's penalty timers will be used only for handover decision 2, make it
clear by a sub-struct.
hodec2 will also initialize the penalty timer list on demand only, so no need
to always
Review at https://gerrit.osmocom.org/6496
HO: cosmetic: handover_decision.c: make process_meas_rep() return void
The function's return value is ignored. An upcoming patch will use this as
callback function and requires a void return.
Change-Id: Id455a8becbb43884e8205d87b0371b216d0119fc
---
M
Review at https://gerrit.osmocom.org/6493
handover_logic.c: always do inter-cell channel activation
In commit [1], the channel activation kind was modified out-of-context to use
Immediate Assignment in case of intra-cell re-assignment. This so far hasn't
worked out in tests, so instead stay
Review at https://gerrit.osmocom.org/6492
MSC_Tests: Set verdicts from inconc to fail
Channels not being closed/cleared at the end of the test is a clear
failure, so don't mark the test as inconc.
Change-Id: Ie9188111da744f0aafaac02841d36a957bfc8d86
---
M msc/BSC_ConnectionHandler.ttcn
M
Review at https://gerrit.osmocom.org/6491
MSC_Tests.f_tc_mo_crcx_ran_reject(): Send release complete to release
Change-Id: I8a19541f3276b994ed34a1d3f9920010660a2ddd
---
M msc/MSC_Tests.ttcn
1 file changed, 7 insertions(+), 1 deletion(-)
git pull
VLR tests: add simple LU generator
Generate LU REQ using function instead of hardcoded hex strings.
Change-Id: Iab8b07b3276b6f6ac0387df14abb98355ea0e99a
Related: OS#2864
---
M tests/msc_vlr/msc_vlr_test_gsm_authen.c
M tests/msc_vlr/msc_vlr_test_gsm_ciph.c
M
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6467/1/src/libbsc/bsc_api.c
File src/libbsc/bsc_api.c:
Line 679: DEBUGP(DHO, "HANDOVER FAILED cause = %s\n",
rr_cause_name(gh->data[0]));
> now we have the same line twice?
the rationale is in the commit log ... should I limit it
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6472
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1148364597f91b5a55666c80c758b61fa56f582
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6471
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6475b2543b18d21710a6d774b214cb484f36ec8e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6483
to look at the new patch set (#2).
ttcn3-tcpdump-stop.sh: Wait to receive last packets before stopping tcpdump
There's a time delay between packets are sent through the system and
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6470
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibea4c20abc50c3d655f6bbb1a643477dfc722c8e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6469
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8222d73085eb777696e365c94214c05d56e6d129
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/6467/1/src/libbsc/bsc_api.c
File src/libbsc/bsc_api.c:
Line 679: DEBUGP(DHO, "HANDOVER FAILED cause = %s\n",
rr_cause_name(gh->data[0]));
now we have the same line twice?
--
To view, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6466
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia91766d8bb8f543f514726ce9508b7747bb2bcb5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6465
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48715864d4b953987c86d93fe1b3a5456f0c4e0f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6484
VLR tests: add simple LU generator
Generate LU REQ using function instead of hardcoded hex strings.
Change-Id: Iab8b07b3276b6f6ac0387df14abb98355ea0e99a
Related: OS#2864
---
M tests/msc_vlr/msc_vlr_test_gsm_authen.c
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6464
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09684dcf2a00e3d930e058cc1c925ad6e59b1468
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
not sure if it's worth keeping the old api *inside* osmo-bsc. You could just
convert the existing callers, or simply add that new argument to the function?
we're not talking about a library here...
--
To view, visit https://gerrit.osmocom.org/6463
To unsubscribe,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6463
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4478ebcaada00897cc38c5a299e07661139ed3c5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6462
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97b6ac05192ad477b246a23ce00c5c91abfd938a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6461
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad9d01cbffa287adce55b3569667b58a2d3556b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6483/1/ttcn3-tcpdump-stop.sh
File ttcn3-tcpdump-stop.sh:
Line 20:prev_count=$count
one could probably also simply compare the file size, rather than running
tcpdump and re-reading the file? Probably no big deal, though.
--
To
Max has submitted this change and it was merged.
Change subject: Add function to encode classmark
..
Add function to encode classmark
The code is based on Osmocom-BB implementation.
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6482
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91cfd84ff5356857a13af1901abfe2204a93f76d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6474
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17a456a27c8e33571f333f4b7efdf61161ebb174
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6473
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d7570bba3c21c017ba38d36185f6ae042967599
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6481
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f6968edaa3ed535673411fb2a80060a472290f
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 285: vty_out(vty, " ARFCNs:");
looks like this would only work for non-hopping TRXs. I guess we should have
some if (!trx->hopping.enabled) around printing trx->arfcn,
Harald Welte has submitted this change and it was merged.
Change subject: vty: 'show bts': fix indenting
..
vty: 'show bts': fix indenting
Add two-space indent to many items.
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: vty: 'show bts': write '(none)' if none are found.
..
vty: 'show bts': write '(none)' if none are found.
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6481
to look at the new patch set (#2).
Add function to encode classmark
The code is based on Osmocom-BB implementation.
Change-Id: I78f6968edaa3ed535673411fb2a80060a472290f
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6474
to look at the new patch set (#2).
ttcn3-tcpdump-start.sh: Wait for pcap file creation to start test
It was spotted in the jenkins artficats that pcap files for some tests
are missing.
Review at https://gerrit.osmocom.org/6482
ttcn3-tcpdump-start.sh: Wait for tcpdump to start recording
We generate some fake transit and we wait until we catch tcpdump already
saved some packet into the pcap file, this way making sure it is already
recording before starting the test.
The -U
Review at https://gerrit.osmocom.org/6483
ttcn3-tcpdump-stop.sh: Wait to receive last packets before stopping tcpdump
There's a time delay between packets are sent through the system and
tcpdump reads, buffers and stores them into the pcap file. We need to
give it more time to process
Review at https://gerrit.osmocom.org/6481
Add function to encode classmark
The code is based on Osmocom-BB implementation.
Change-Id: I78f6968edaa3ed535673411fb2a80060a472290f
---
M include/osmocom/gsm/gsm48.h
M src/gsm/gsm48.c
M src/gsm/libosmogsm.map
3 files changed, 18 insertions(+), 0
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6476
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77039824b85a14b9d7bdfe6d2f717679b6886915
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6477
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34e3c8928871fc41b9551ab0502a42140ccbdda8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6480
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic53a675963cae328b296b4abaed9524451153271
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6480
contrib/jenkins_arch.sh: Fix script comparison and arm support
Change-Id: Ic53a675963cae328b296b4abaed9524451153271
---
M contrib/jenkins_arch.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Review at https://gerrit.osmocom.org/6476
vty: 'show bts': write '(none)' if none are found.
Change-Id: I77039824b85a14b9d7bdfe6d2f717679b6886915
---
M src/libbsc/bsc_vty.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/6477
vty: 'show bts': fix indenting
Add two-space indent to many items.
Change-Id: I34e3c8928871fc41b9551ab0502a42140ccbdda8
---
M src/libbsc/bsc_vty.c
1 file changed, 19 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/6478
vty: 'show bts': list the TRXs' ARFCNs
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bsc_vty.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/6478/1
diff
Review at https://gerrit.osmocom.org/6479
vty: 'show bts': print neighbor cells
Print out the current neighbor cell list, works both for manual and
automatically populated modes.
Change-Id: I57dae0e01b81a6f028b39f3edcaf430251ca8fe2
---
M src/libbsc/bsc_vty.c
1 file changed, 33 insertions(+),
1 - 100 of 141 matches
Mail list logo
