Change in libosmo-sccp[master]: fix memleaks in mtp_user_prim_cb()

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9957 ) Change subject: fix memleaks in mtp_user_prim_cb() .. Patch Set 1: NOTE: I AM NOT 100% SURE ABOUT THIS ONE. Please look closely whether I

Change in libosmo-sccp[master]: fix memleak in m3ua_rx_xfer()

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9958 ) Change subject: fix memleak in m3ua_rx_xfer() .. Patch Set 1: NOTE: I AM NOT 100% SURE ABOUT THIS ONE. Please look closely whether I missed

Change in libosmo-sccp[master]: fix memleak in m3ua_rx_xfer()

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9958 Change subject: fix memleak in m3ua_rx_xfer() .. fix memleak in m3ua_rx_xfer() Change-Id: I6211c8809eefeb94289c4c497553561b043ee619 --- M

Change in libosmo-sccp[master]: fix memleaks in mtp_user_prim_cb()

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9957 Change subject: fix memleaks in mtp_user_prim_cb() .. fix memleaks in mtp_user_prim_cb() After dispatching to scrc_rx_mtp_xfer_ind_xua(),

Change in libosmo-sccp[master]: fix two memleaks in ipa_rx_msg_sccp()

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9956 Change subject: fix two memleaks in ipa_rx_msg_sccp() .. fix two memleaks in ipa_rx_msg_sccp() 1: Do not call xua_msg_alloc() which is later

Change in osmo-bsc[master]: call osmo_xua_msg_tall_ctx_init()

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9955 Change subject: call osmo_xua_msg_tall_ctx_init() .. call osmo_xua_msg_tall_ctx_init() xua_msg allocations should not go unnoticed by our

Change in osmo-bsc[master]: cosmetic: name osmo-bsc's root ctx 'osmo-bsc', not 'openbsc'

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9954 Change subject: cosmetic: name osmo-bsc's root ctx 'osmo-bsc', not 'openbsc' .. cosmetic: name osmo-bsc's root ctx 'osmo-bsc', not 'openbsc'

Change in libosmo-sccp[master]: add osmo_xua_msg_tall_ctx_init()

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9953 Change subject: add osmo_xua_msg_tall_ctx_init() .. add osmo_xua_msg_tall_ctx_init() So far the tall_xua ctx used to allocate from in

Change in libosmo-sccp[master]: cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9952 Change subject: cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr .. cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr Before

Change in libosmo-sccp[master]: fix memleak in ipa_rx_msg_sccp

2018-07-10 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9951 Change subject: fix memleak in ipa_rx_msg_sccp .. fix memleak in ipa_rx_msg_sccp After m3ua_xfer_from_data() has copied the msgb data, we

Change in osmo-ttcn3-hacks[master]: sgsn: Add test to verify restart_ctr during echo req/reply.

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9950 Change subject: sgsn: Add test to verify restart_ctr during echo req/reply. .. sgsn: Add test to verify restart_ctr during echo req/reply.

Change in osmo-ttcn3-hacks[master]: lib: GTP_Emulation: Allow receiving packets with TEID 0

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9949 Change subject: lib: GTP_Emulation: Allow receiving packets with TEID 0 .. lib: GTP_Emulation: Allow receiving packets with TEID 0 Some

Change in osmo-sgsn[master]: vty: Add cmd to disable echo loop explictly

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9948 Change subject: vty: Add cmd to disable echo loop explictly .. vty: Add cmd to disable echo loop explictly Change-Id:

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #180

2018-07-10 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in pysim[master]: tests: add test program to verify pysim-prog.py (and pysim-read.py)

2018-07-10 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9947 Change subject: tests: add test program to verify pysim-prog.py (and pysim-read.py) .. tests: add test program to verify pysim-prog.py (and

Change in osmo-pcu[master]: tbf: Replace '.' in counter names with ':'

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9942 ) Change subject: tbf: Replace '.' in counter names with ':' .. Patch Set 1: Build failure triggered is fixed in next commit, so this one

Change in simtrace2[master]: host sniff: add functions to print flags

2018-07-10 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/9946 Change subject: host sniff: add functions to print flags .. host sniff: add functions to print flags Change-Id:

Change in simtrace2[master]: sniffer: fix inverted reset meaning

2018-07-10 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/9944 Change subject: sniffer: fix inverted reset meaning .. sniffer: fix inverted reset meaning Change-Id:

Change in simtrace2[master]: host sniff: process remaining usb messages in buffer

2018-07-10 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/9945 Change subject: host sniff: process remaining usb messages in buffer .. host sniff: process remaining usb messages in buffer Change-Id:

Change in osmo-pcu[master]: tbf: Replace '.' in counter names with ':'

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9942 Change subject: tbf: Replace '.' in counter names with ':' .. tbf: Replace '.' in counter names with ':' The '.' is illegal character in

Change in osmo-pcu[master]: tbf: Use incrementing id for rate_ctr_group_alloc

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9943 Change subject: tbf: Use incrementing id for rate_ctr_group_alloc .. tbf: Use incrementing id for rate_ctr_group_alloc Wrap-around of var

Change in osmo-ttcn3-hacks[master]: BSC_Tests_LCLS: try call legs with different codec/rate

2018-07-10 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9941 Change subject: BSC_Tests_LCLS: try call legs with different codec/rate .. BSC_Tests_LCLS: try call legs with different codec/rate since the local

Change in osmo-bsc[master]: lcls: do not LCLS call legs with different codecs

2018-07-10 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9940 Change subject: lcls: do not LCLS call legs with different codecs .. lcls: do not LCLS call legs with different codecs It is theoretically possible

Build failed in Jenkins: master-gapk » a1=default,a2=default,a3=default,osmocom-master-debian9 #16

2018-07-10 Thread jenkins
See -- [...truncated 127.18 KB...] checking whether -lc should be explicitly linked in... no checking dynamic linker

Change in libosmocore[master]: vty: fix use-after-free and memleaks in is_cmd_ambiguous()

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9939 ) Change subject: vty: fix use-after-free and memleaks in is_cmd_ambiguous() .. Patch Set 1: (1 comment)

Change in libosmocore[master]: vty: cosmetic: cmd_deopt(): use talloc_strndup(), not memcpy()

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9938 ) Change subject: vty: cosmetic: cmd_deopt(): use talloc_strndup(), not memcpy() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: vty/command.c: talloc from tall_vty_cmd_ctx, not NULL

2018-07-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9937 ) Change subject: vty/command.c: talloc from tall_vty_cmd_ctx, not NULL .. Patch Set 1: Code-Review+2 -- To view, visit

Change in simtrace2[master]: USB: add flags for sniff data and centralise transfer

2018-07-10 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9920 to look at the new patch set (#2). Change subject: USB: add flags for sniff data and centralise transfer .. USB: add

Change in simtrace2[master]: host: set license to GPLv2+

2018-07-10 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9915 to look at the new patch set (#2). Change subject: host: set license to GPLv2+ .. host: set license to GPLv2+

Change in simtrace2[master]: cosmetic: put spaces around operations

2018-07-10 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9919 to look at the new patch set (#2). Change subject: cosmetic: put spaces around operations .. cosmetic: put spaces

Change in simtrace2[master]: replace leading spaces with tabs

2018-07-10 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9918 to look at the new patch set (#2). Change subject: replace leading spaces with tabs .. replace leading spaces with

Change in simtrace2[master]: set linux end of line

2018-07-10 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9917 to look at the new patch set (#2). Change subject: set linux end of line .. set linux end of line Change-Id:

Change in simtrace2[master]: DFU: use central DFU override check

2018-07-10 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9913 to look at the new patch set (#2). Change subject: DFU: use central DFU override check .. DFU: use central DFU

Change in simtrace2[master]: firmware: set license to GPLv2+

2018-07-10 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9916 to look at the new patch set (#2). Change subject: firmware: set license to GPLv2+ .. firmware: set license to GPLv2+

Change in libosmocore[master]: vty: fix use-after-free and memleaks in is_cmd_ambiguous()

2018-07-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9939 ) Change subject: vty: fix use-after-free and memleaks in is_cmd_ambiguous() .. Patch Set 1: (1 comment)

Change in libosmocore[master]: vty: cosmetic: cmd_deopt(): use talloc_strndup(), not memcpy()

2018-07-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9938 ) Change subject: vty: cosmetic: cmd_deopt(): use talloc_strndup(), not memcpy() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: vty/command.c: talloc from tall_vty_cmd_ctx, not NULL

2018-07-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9937 ) Change subject: vty/command.c: talloc from tall_vty_cmd_ctx, not NULL .. Patch Set 1: Code-Review+1 -- To view, visit