Change in osmo-sgsn[master]: debian: add missing build dependencies

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/10943


Change subject: debian: add missing build dependencies
..

debian: add missing build dependencies

Change-Id: I0d552f938224e553187f0b4da06eac90fc025c95
---
M debian/control
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/43/10943/1

diff --git a/debian/control b/debian/control
index 46a6b67..8e34dbe 100644
--- a/debian/control
+++ b/debian/control
@@ -10,6 +10,7 @@
automake,
libtool,
pkg-config,
+   libasn1c-dev,
libtalloc-dev,
libc-ares-dev,
libgtp-dev,
@@ -17,6 +18,7 @@
libosmo-abis-dev,
libosmo-ranap-dev,
libosmo-sccp-dev,
+   libosmo-sigtran-dev,
libosmo-netif-dev
 Standards-Version: 3.9.8
 Vcs-Git: git://git.osmocom.org/osmo-sgsn.git

--
To view, visit https://gerrit.osmocom.org/10943
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d552f938224e553187f0b4da06eac90fc025c95
Gerrit-Change-Number: 10943
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  165s] #define HAVE_SYS_STAT_H 1
[  165s] #define HAVE_STDLIB_H 1
[  165s] #define HAVE_STRING_H 1
[  165s] #define HAVE_MEMORY_H 1
[  165s] #define HAVE_STRINGS_H 1
[  165s] #define HAVE_INTTYPES_H 1
[  165s] #define HAVE_STDINT_H 1
[  165s] #define HAVE_UNISTD_H 1
[  165s] #define HAVE_DLFCN_H 1
[  165s] #define LT_OBJDIR ".libs/"
[  165s] 
[  165s] configure: exit 1
[  165s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf 
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf 
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  165s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  165s] make[1]: *** [override_dh_auto_configure] Error 2
[  165s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  165s] debian/rules:45: recipe for target 'build' failed
[  165s] make: *** [build] Error 2
[  165s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  165s] 
[  165s] armbuild17 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:53:27 UTC 2018.
[  165s] 
[  165s] ### VM INTERACTION START ###
[  168s] [  129.359531] SysRq : Power Off
[  168s] [  129.361126] reboot: Power down
[  168s] ### VM INTERACTION END ###
[  168s] 
[  168s] armbuild17 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:53:30 UTC 2018.
[  168s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  100s] #define HAVE_SYS_STAT_H 1
[  100s] #define HAVE_STDLIB_H 1
[  100s] #define HAVE_STRING_H 1
[  100s] #define HAVE_MEMORY_H 1
[  100s] #define HAVE_STRINGS_H 1
[  100s] #define HAVE_INTTYPES_H 1
[  100s] #define HAVE_STDINT_H 1
[  100s] #define HAVE_UNISTD_H 1
[  100s] #define HAVE_DLFCN_H 1
[  100s] #define LT_OBJDIR ".libs/"
[  100s] 
[  100s] configure: exit 1
[  100s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu 
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  100s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  100s] make[1]: *** [override_dh_auto_configure] Error 2
[  100s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  100s] debian/rules:45: recipe for target 'build' failed
[  100s] make: *** [build] Error 2
[  100s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  100s] 
[  100s] lamb66 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:30:28 UTC 2018.
[  100s] 
[  100s] ### VM INTERACTION START ###
[  103s] [   92.181710] sysrq: SysRq : Power Off
[  103s] [   92.188472] reboot: Power down
[  103s] ### VM INTERACTION END ###
[  103s] 
[  103s] lamb66 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:30:32 UTC 2018.
[  103s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  131s] #define HAVE_SYS_STAT_H 1
[  131s] #define HAVE_STDLIB_H 1
[  131s] #define HAVE_STRING_H 1
[  131s] #define HAVE_MEMORY_H 1
[  131s] #define HAVE_STRINGS_H 1
[  131s] #define HAVE_INTTYPES_H 1
[  131s] #define HAVE_STDINT_H 1
[  131s] #define HAVE_UNISTD_H 1
[  131s] #define HAVE_DLFCN_H 1
[  131s] #define LT_OBJDIR ".libs/"
[  131s] 
[  131s] configure: exit 1
[  131s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu 
--libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  131s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  131s] make[1]: *** [override_dh_auto_configure] Error 2
[  131s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  131s] debian/rules:45: recipe for target 'build' failed
[  131s] make: *** [build] Error 2
[  131s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  131s] 
[  131s] cloud106 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:28:12 UTC 2018.
[  131s] 
[  131s] ### VM INTERACTION START ###
[  134s] [  104.823519] sysrq: SysRq : Power Off
[  134s] [  104.861525] reboot: Power down
[  135s] ### VM INTERACTION END ###
[  135s] 
[  135s] cloud106 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:28:17 UTC 2018.
[  135s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  355s] No package 'libpcsclite' found
[  356s] simtrace2-remsim.o: In function `main':
[  356s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  356s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  356s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:772: undefined 
reference to `osim_uicc_sim_cic_profile'
[  356s] apdu_dispatch.o: In function `apdu_segment_in':
[  356s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  356s] /usr/src/packages/BUILD/host/apdu_dispatch.c:173: undefined reference 
to `osim_uicc_sim_cic_profile'
[  356s] collect2: error: ld returned 1 exit status
[  356s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  356s] make[2]: *** [simtrace2-remsim] Error 1
[  356s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  356s] Makefile:20: recipe for target 'utils' failed
[  356s] make[1]: *** [utils] Error 2
[  356s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  356s] dh_auto_build: make -j1 returned exit code 2
[  356s] debian/rules:4: recipe for target 'build' failed
[  356s] make: *** [build] Error 2
[  356s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  356s] 
[  356s] armbuild13 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:27:13 UTC 2018.
[  356s] 
[  356s] ### VM INTERACTION START ###
[  359s] [  307.742362] SysRq : Power Off
[  359s] [  307.743627] reboot: Power down
[  359s] ### VM INTERACTION END ###
[  359s] 
[  359s] armbuild13 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:27:16 UTC 2018.
[  359s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  151s] #define HAVE_SYS_STAT_H 1
[  151s] #define HAVE_STDLIB_H 1
[  151s] #define HAVE_STRING_H 1
[  151s] #define HAVE_MEMORY_H 1
[  151s] #define HAVE_STRINGS_H 1
[  151s] #define HAVE_INTTYPES_H 1
[  151s] #define HAVE_STDINT_H 1
[  151s] #define HAVE_UNISTD_H 1
[  151s] #define HAVE_DLFCN_H 1
[  151s] #define LT_OBJDIR ".libs/"
[  151s] 
[  151s] configure: exit 1
[  151s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu 
--libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  151s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  151s] make[1]: *** [override_dh_auto_configure] Error 2
[  151s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  151s] debian/rules:45: recipe for target 'build' failed
[  151s] make: *** [build] Error 2
[  151s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  151s] 
[  151s] cloud119 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:26:17 UTC 2018.
[  151s] 
[  151s] ### VM INTERACTION START ###
[  155s] [   98.400762] sysrq: SysRq : Power Off
[  155s] [   98.491971] reboot: Power down
[  156s] ### VM INTERACTION END ###
[  156s] 
[  156s] cloud119 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:26:22 UTC 2018.
[  156s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_18.04/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  101s] #define HAVE_SYS_STAT_H 1
[  101s] #define HAVE_STDLIB_H 1
[  101s] #define HAVE_STRING_H 1
[  101s] #define HAVE_MEMORY_H 1
[  101s] #define HAVE_STRINGS_H 1
[  101s] #define HAVE_INTTYPES_H 1
[  101s] #define HAVE_STDINT_H 1
[  101s] #define HAVE_UNISTD_H 1
[  101s] #define HAVE_DLFCN_H 1
[  101s] #define LT_OBJDIR ".libs/"
[  101s] 
[  101s] configure: exit 1
[  101s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu 
--libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  101s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  101s] make[1]: *** [override_dh_auto_configure] Error 2
[  101s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  101s] debian/rules:45: recipe for target 'build' failed
[  101s] make: *** [build] Error 2
[  101s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  101s] 
[  101s] lamb70 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:23:01 UTC 2018.
[  101s] 
[  101s] ### VM INTERACTION START ###
[  104s] [   93.425389] sysrq: SysRq : Power Off
[  104s] [   93.433146] reboot: Power down
[  104s] ### VM INTERACTION END ###
[  104s] 
[  104s] lamb70 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:23:05 UTC 2018.
[  104s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   98s] #define HAVE_SYS_STAT_H 1
[   98s] #define HAVE_STDLIB_H 1
[   98s] #define HAVE_STRING_H 1
[   98s] #define HAVE_MEMORY_H 1
[   98s] #define HAVE_STRINGS_H 1
[   98s] #define HAVE_INTTYPES_H 1
[   98s] #define HAVE_STDINT_H 1
[   98s] #define HAVE_UNISTD_H 1
[   98s] #define HAVE_DLFCN_H 1
[   98s] #define LT_OBJDIR ".libs/"
[   98s] 
[   98s] configure: exit 1
[   98s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu 
--libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[   98s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[   98s] make[1]: *** [override_dh_auto_configure] Error 255
[   98s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   98s] debian/rules:45: recipe for target 'build' failed
[   98s] make: *** [build] Error 2
[   98s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   98s] 
[   98s] lamb16 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:19:38 UTC 2018.
[   98s] 
[   98s] ### VM INTERACTION START ###
[  101s] [   90.328616] sysrq: SysRq : Power Off
[  102s] [   90.360669] reboot: Power down
[  102s] ### VM INTERACTION END ###
[  102s] 
[  102s] lamb16 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:19:43 UTC 2018.
[  102s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   91s] #define HAVE_SYS_STAT_H 1
[   91s] #define HAVE_STDLIB_H 1
[   91s] #define HAVE_STRING_H 1
[   91s] #define HAVE_MEMORY_H 1
[   91s] #define HAVE_STRINGS_H 1
[   91s] #define HAVE_INTTYPES_H 1
[   91s] #define HAVE_STDINT_H 1
[   91s] #define HAVE_UNISTD_H 1
[   91s] #define HAVE_DLFCN_H 1
[   91s] #define LT_OBJDIR ".libs/"
[   91s] 
[   91s] configure: exit 1
[   91s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu 
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[   91s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[   91s] make[1]: *** [override_dh_auto_configure] Error 2
[   91s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   91s] debian/rules:45: recipe for target 'build' failed
[   91s] make: *** [build] Error 2
[   91s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   91s] 
[   91s] lamb15 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:19:20 UTC 2018.
[   91s] 
[   91s] ### VM INTERACTION START ###
[   94s] [   83.421185] sysrq: SysRq : Power Off
[   94s] [   83.426362] reboot: Power down
[   94s] ### VM INTERACTION END ###
[   94s] 
[   94s] lamb15 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:19:24 UTC 2018.
[   94s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  136s] #define HAVE_SYS_STAT_H 1
[  136s] #define HAVE_STDLIB_H 1
[  136s] #define HAVE_STRING_H 1
[  136s] #define HAVE_MEMORY_H 1
[  136s] #define HAVE_STRINGS_H 1
[  136s] #define HAVE_INTTYPES_H 1
[  136s] #define HAVE_STDINT_H 1
[  136s] #define HAVE_UNISTD_H 1
[  136s] #define HAVE_DLFCN_H 1
[  136s] #define LT_OBJDIR ".libs/"
[  136s] 
[  136s] configure: exit 1
[  136s] dh_auto_configure: ./configure --build=i586-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--libdir=${prefix}/lib/i386-linux-gnu --libexecdir=${prefix}/lib/i386-linux-gnu 
--disable-maintainer-mode --disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  136s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  136s] make[1]: *** [override_dh_auto_configure] Error 255
[  136s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  136s] debian/rules:45: recipe for target 'build' failed
[  136s] make: *** [build] Error 2
[  136s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  136s] 
[  136s] cloud122 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:17:14 UTC 2018.
[  136s] 
[  136s] ### VM INTERACTION START ###
[  137s] Powering off.
[  137s] [   92.963589] reboot: Power down
[  138s] ### VM INTERACTION END ###
[  138s] 
[  138s] cloud122 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:17:17 UTC 2018.
[  138s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_17.10/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   88s] #define HAVE_SYS_STAT_H 1
[   88s] #define HAVE_STDLIB_H 1
[   88s] #define HAVE_STRING_H 1
[   88s] #define HAVE_MEMORY_H 1
[   88s] #define HAVE_STRINGS_H 1
[   88s] #define HAVE_INTTYPES_H 1
[   88s] #define HAVE_STDINT_H 1
[   88s] #define HAVE_UNISTD_H 1
[   88s] #define HAVE_DLFCN_H 1
[   88s] #define LT_OBJDIR ".libs/"
[   88s] 
[   88s] configure: exit 1
[   88s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu 
--libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[   88s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[   88s] make[1]: *** [override_dh_auto_configure] Error 2
[   88s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   88s] debian/rules:45: recipe for target 'build' failed
[   88s] make: *** [build] Error 2
[   88s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   88s] 
[   88s] lamb21 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:16:45 UTC 2018.
[   88s] 
[   88s] ### VM INTERACTION START ###
[   91s] [   79.772678] sysrq: SysRq : Power Off
[   91s] [   79.777944] reboot: Power down
[   91s] ### VM INTERACTION END ###
[   91s] 
[   91s] lamb21 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:16:50 UTC 2018.
[   91s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   75s] #define HAVE_SYS_STAT_H 1
[   75s] #define HAVE_STDLIB_H 1
[   75s] #define HAVE_STRING_H 1
[   75s] #define HAVE_MEMORY_H 1
[   75s] #define HAVE_STRINGS_H 1
[   75s] #define HAVE_INTTYPES_H 1
[   75s] #define HAVE_STDINT_H 1
[   75s] #define HAVE_UNISTD_H 1
[   75s] #define HAVE_DLFCN_H 1
[   75s] #define LT_OBJDIR ".libs/"
[   75s] 
[   75s] configure: exit 1
[   75s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--libdir=${prefix}/lib/x86_64-linux-gnu 
--libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[   75s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[   75s] make[1]: *** [override_dh_auto_configure] Error 255
[   75s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   75s] debian/rules:45: recipe for target 'build' failed
[   75s] make: *** [build] Error 2
[   75s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   75s] 
[   75s] lamb63 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:16:55 UTC 2018.
[   75s] 
[   75s] ### VM INTERACTION START ###
[   76s] Powering off.
[   76s] [   64.792487] reboot: Power down
[   76s] ### VM INTERACTION END ###
[   76s] 
[   76s] lamb63 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
20:16:57 UTC 2018.
[   76s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  217s] No package 'libpcsclite' found
[  217s] simtrace2-remsim.o: In function `main':
[  217s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  217s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  217s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  217s] apdu_dispatch.o: In function `apdu_segment_in':
[  217s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  217s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  217s] collect2: error: ld returned 1 exit status
[  217s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  217s] make[2]: *** [simtrace2-remsim] Error 1
[  217s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  217s] Makefile:20: recipe for target 'utils' failed
[  217s] make[1]: *** [utils] Error 2
[  217s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  217s] dh_auto_build: make -j1 returned exit code 2
[  217s] debian/rules:4: recipe for target 'build' failed
[  217s] make: *** [build] Error 2
[  217s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  217s] 
[  217s] cloud121 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:07:29 UTC 2018.
[  217s] 
[  217s] ### VM INTERACTION START ###
[  220s] [  188.811222] sysrq: SysRq : Power Off
[  220s] [  188.819448] reboot: Power down
[  222s] ### VM INTERACTION END ###
[  222s] 
[  222s] cloud121 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:07:35 UTC 2018.
[  222s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  196s] No package 'libpcsclite' found
[  196s] simtrace2-remsim.o: In function `main':
[  196s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  196s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  196s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  196s] apdu_dispatch.o: In function `apdu_segment_in':
[  196s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  196s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  196s] collect2: error: ld returned 1 exit status
[  196s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  196s] make[2]: *** [simtrace2-remsim] Error 1
[  196s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  196s] Makefile:20: recipe for target 'utils' failed
[  196s] make[1]: *** [utils] Error 2
[  196s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  196s] dh_auto_build: make -j1 returned exit code 2
[  196s] debian/rules:4: recipe for target 'build' failed
[  196s] make: *** [build] Error 2
[  196s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  196s] 
[  196s] lamb59 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:05:47 UTC 2018.
[  196s] 
[  196s] ### VM INTERACTION START ###
[  199s] [  176.502195] sysrq: SysRq : Power Off
[  199s] [  176.511772] reboot: Power down
[  199s] ### VM INTERACTION END ###
[  199s] 
[  199s] lamb59 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:05:50 UTC 2018.
[  199s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  204s] No package 'libpcsclite' found
[  204s] simtrace2-remsim.o: In function `main':
[  204s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  204s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  204s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  204s] apdu_dispatch.o: In function `apdu_segment_in':
[  204s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  204s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  204s] collect2: error: ld returned 1 exit status
[  204s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  204s] make[2]: *** [simtrace2-remsim] Error 1
[  204s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  204s] Makefile:20: recipe for target 'utils' failed
[  204s] make[1]: *** [utils] Error 2
[  204s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  204s] dh_auto_build: make -j1 returned exit code 2
[  204s] debian/rules:4: recipe for target 'build' failed
[  204s] make: *** [build] Error 2
[  204s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  204s] 
[  204s] cloud125 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:04:29 UTC 2018.
[  204s] 
[  204s] ### VM INTERACTION START ###
[  207s] [  180.938984] sysrq: SysRq : Power Off
[  207s] [  180.952643] reboot: Power down
[  208s] ### VM INTERACTION END ###
[  208s] 
[  208s] cloud125 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:04:33 UTC 2018.
[  208s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  241s] No package 'libpcsclite' found
[  241s] simtrace2-remsim.o: In function `main':
[  241s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  241s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  241s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  241s] apdu_dispatch.o: In function `apdu_segment_in':
[  241s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  241s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  241s] collect2: error: ld returned 1 exit status
[  241s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  241s] make[2]: *** [simtrace2-remsim] Error 1
[  241s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  241s] Makefile:20: recipe for target 'utils' failed
[  241s] make[1]: *** [utils] Error 2
[  241s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  241s] dh_auto_build: make -j1 returned exit code 2
[  241s] debian/rules:4: recipe for target 'build' failed
[  241s] make: *** [build] Error 2
[  241s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  241s] 
[  241s] lamb59 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:04:52 UTC 2018.
[  241s] 
[  241s] ### VM INTERACTION START ###
[  244s] [  230.713492] sysrq: SysRq : Power Off
[  244s] [  230.722080] reboot: Power down
[  244s] ### VM INTERACTION END ###
[  244s] 
[  244s] lamb59 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:04:56 UTC 2018.
[  244s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  218s] No package 'libpcsclite' found
[  218s] simtrace2-remsim.o: In function `main':
[  218s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  218s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  218s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  218s] apdu_dispatch.o: In function `apdu_segment_in':
[  218s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  218s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  218s] collect2: error: ld returned 1 exit status
[  218s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  218s] make[2]: *** [simtrace2-remsim] Error 1
[  218s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  218s] Makefile:20: recipe for target 'utils' failed
[  218s] make[1]: *** [utils] Error 2
[  218s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  218s] dh_auto_build: make -j1 returned exit code 2
[  218s] debian/rules:4: recipe for target 'build' failed
[  218s] make: *** [build] Error 2
[  218s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  218s] 
[  218s] lamb58 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:03:21 UTC 2018.
[  218s] 
[  218s] ### VM INTERACTION START ###
[  222s] [  210.957584] sysrq: SysRq : Power Off
[  222s] [  210.988750] reboot: Power down
[  222s] ### VM INTERACTION END ###
[  222s] 
[  222s] lamb58 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:03:25 UTC 2018.
[  222s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  179s] No package 'libpcsclite' found
[  179s] simtrace2-remsim.o: In function `main':
[  179s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  179s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  179s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  179s] apdu_dispatch.o: In function `apdu_segment_in':
[  179s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  179s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  179s] collect2: error: ld returned 1 exit status
[  179s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  179s] make[2]: *** [simtrace2-remsim] Error 1
[  179s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  179s] Makefile:20: recipe for target 'utils' failed
[  179s] make[1]: *** [utils] Error 2
[  179s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  179s] dh_auto_build: make -j1 returned exit code 2
[  179s] debian/rules:4: recipe for target 'build' failed
[  179s] make: *** [build] Error 2
[  179s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  179s] 
[  179s] cloud101 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:02:58 UTC 2018.
[  179s] 
[  179s] ### VM INTERACTION START ###
[  182s] [  155.180057] sysrq: SysRq : Power Off
[  182s] [  155.190301] reboot: Power down
[  184s] ### VM INTERACTION END ###
[  184s] 
[  184s] cloud101 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:03:04 UTC 2018.
[  184s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  183s] No package 'libpcsclite' found
[  183s] simtrace2-remsim.o: In function `main':
[  183s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  183s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  183s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  183s] apdu_dispatch.o: In function `apdu_segment_in':
[  183s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  183s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  183s] collect2: error: ld returned 1 exit status
[  183s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  183s] make[2]: *** [simtrace2-remsim] Error 1
[  183s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  183s] Makefile:20: recipe for target 'utils' failed
[  183s] make[1]: *** [utils] Error 2
[  183s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  183s] dh_auto_build: make -j1 returned exit code 2
[  183s] debian/rules:4: recipe for target 'build' failed
[  183s] make: *** [build] Error 2
[  183s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  183s] 
[  183s] morla3 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:03:04 UTC 2018.
[  183s] 
[  183s] ### VM INTERACTION START ###
[  187s] [  175.110315] sysrq: SysRq : Power Off
[  187s] [  175.170061] reboot: Power down
[  187s] ### VM INTERACTION END ###
[  187s] 
[  187s] morla3 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
20:03:08 UTC 2018.
[  187s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmocom-bb[master]: trxcon/scheduler: introduce TDMA frame math helpers

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10942


Change subject: trxcon/scheduler: introduce TDMA frame math helpers
..

trxcon/scheduler: introduce TDMA frame math helpers

The 'normal' math operations, such as addition and substraction,
are not applicable for TDMA frame numbers because they may result
in out-of-range values.

Having TDMA frame math helpers in a single place would allow
one to avoid possible out-of-range result mistakes.

Change-Id: Ibb66ba846cc3d6c2eaa88414569e5f3751128047
---
M src/host/trxcon/sched_clck.c
M src/host/trxcon/sched_trx.c
M src/host/trxcon/scheduler.h
3 files changed, 16 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/42/10942/1

diff --git a/src/host/trxcon/sched_clck.c b/src/host/trxcon/sched_clck.c
index 56b89a2..8a9527c 100644
--- a/src/host/trxcon/sched_clck.c
+++ b/src/host/trxcon/sched_clck.c
@@ -84,8 +84,7 @@
timespecadd(tv_clock, _duration, tv_clock);
elapsed_us -= FRAME_DURATION_uS;

-   sched->fn_counter_proc = (sched->fn_counter_proc + 1)
-   % GSM_HYPERFRAME;
+   sched->fn_counter_proc = TDMA_FN_INC(sched->fn_counter_proc);

/* Call frame callback */
if (sched->clock_cb)
@@ -143,8 +142,7 @@
/* Calculate elapsed time / frames since last processed fn */
timespecsub(_now, tv_clock, );
elapsed_us = (elapsed.tv_sec * 100) + (elapsed.tv_nsec / 1000);
-   elapsed_fn = (fn + GSM_HYPERFRAME - sched->fn_counter_proc)
-   % GSM_HYPERFRAME;
+   elapsed_fn = TDMA_FN_SUB(fn, sched->fn_counter_proc);

if (elapsed_fn >= 135774)
elapsed_fn -= GSM_HYPERFRAME;
@@ -182,8 +180,7 @@

/* Transmit what we still need to transmit */
while (fn != sched->fn_counter_proc) {
-   sched->fn_counter_proc = (sched->fn_counter_proc + 1)
-   % GSM_HYPERFRAME;
+   sched->fn_counter_proc = TDMA_FN_INC(sched->fn_counter_proc);

/* Call frame callback */
if (sched->clock_cb)
diff --git a/src/host/trxcon/sched_trx.c b/src/host/trxcon/sched_trx.c
index 8bd3c72..e20da39 100644
--- a/src/host/trxcon/sched_trx.c
+++ b/src/host/trxcon/sched_trx.c
@@ -65,8 +65,8 @@
 * Advance frame number, giving the transceiver more
 * time until a burst must be transmitted...
 */
-   fn = (sched->fn_counter_proc + sched->fn_counter_advance)
-   % GSM_HYPERFRAME;
+   fn = TDMA_FN_SUM(sched->fn_counter_proc,
+   sched->fn_counter_advance);

/* Get frame from multiframe */
offset = fn % ts->mf_layout->period;
@@ -608,15 +608,14 @@
}

/* Calculate how many frames have been elapsed */
-   elapsed  = (burst_fn + GSM_HYPERFRAME - ts->mf_last_fn);
-   elapsed %= GSM_HYPERFRAME;
+   elapsed = TDMA_FN_SUB(burst_fn, ts->mf_last_fn);

/**
 * If not too many frames have been elapsed,
 * start counting from last fn + 1
 */
if (elapsed < 10)
-   fn = (ts->mf_last_fn + 1) % GSM_HYPERFRAME;
+   fn = TDMA_FN_INC(ts->mf_last_fn);
else
fn = burst_fn;

@@ -658,7 +657,7 @@
if (fn == burst_fn)
break;

-   fn = (fn + 1) % GSM_HYPERFRAME;
+   fn = TDMA_FN_INC(fn);
}

/* Set last processed frame number */
diff --git a/src/host/trxcon/scheduler.h b/src/host/trxcon/scheduler.h
index 6c3a2f2..6b70b41 100644
--- a/src/host/trxcon/scheduler.h
+++ b/src/host/trxcon/scheduler.h
@@ -8,6 +8,14 @@
 #define GSM_SUPERFRAME (26 * 51)
 #define GSM_HYPERFRAME (2048 * GSM_SUPERFRAME)

+/* TDMA frame number arithmetics */
+#define TDMA_FN_INC(fn) \
+   ((fn + 1) % GSM_HYPERFRAME)
+#define TDMA_FN_SUM(a, b) \
+   ((a + b) % GSM_HYPERFRAME)
+#define TDMA_FN_SUB(a, b) \
+   ((a + GSM_HYPERFRAME - b) % GSM_HYPERFRAME)
+
 enum tdma_sched_clck_state {
SCH_CLCK_STATE_WAIT,
SCH_CLCK_STATE_OK,

--
To view, visit https://gerrit.osmocom.org/10942
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb66ba846cc3d6c2eaa88414569e5f3751128047
Gerrit-Change-Number: 10942
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in osmocom-bb[master]: trxcon/scheduler: fix: don't send BFI in GSM48_CMODE_SIGN mode

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10941


Change subject: trxcon/scheduler: fix: don't send BFI in GSM48_CMODE_SIGN mode
..

trxcon/scheduler: fix: don't send BFI in GSM48_CMODE_SIGN mode

GSM48_CMODE_SIGN means 'signaling only', so we shall not send
bad frame indications in this state. Instead, it makes sense
to send dummy L2 frames like we do for xCCH channels.

Change-Id: Ie39d53522cafab265099076b3194fa96aff217ba
---
M src/host/trxcon/sched_lchan_common.c
M src/host/trxcon/sched_lchan_tchf.c
2 files changed, 11 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/41/10941/1

diff --git a/src/host/trxcon/sched_lchan_common.c 
b/src/host/trxcon/sched_lchan_common.c
index 2767b90..95e496b 100644
--- a/src/host/trxcon/sched_lchan_common.c
+++ b/src/host/trxcon/sched_lchan_common.c
@@ -145,7 +145,6 @@
 size_t sched_bad_frame_ind(uint8_t *l2, struct trx_lchan_state *lchan)
 {
switch (lchan->tch_mode) {
-   case GSM48_CMODE_SIGN:
case GSM48_CMODE_SPEECH_V1:
if (lchan->type == TRXC_TCHF) { /* Full Rate */
memset(l2, 0x00, GSM_FR_BYTES);
@@ -163,6 +162,9 @@
case GSM48_CMODE_SPEECH_AMR: /* Adaptive Multi Rate */
/* FIXME: AMR is not implemented yet */
return 0;
+   case GSM48_CMODE_SIGN:
+   LOGP(DSCH, LOGL_ERROR, "BFI is not allowed in signalling 
mode\n");
+   return 0;
default:
LOGP(DSCH, LOGL_ERROR, "Invalid TCH mode: %u\n", 
lchan->tch_mode);
return 0;
diff --git a/src/host/trxcon/sched_lchan_tchf.c 
b/src/host/trxcon/sched_lchan_tchf.c
index f6465f9..09d504f 100644
--- a/src/host/trxcon/sched_lchan_tchf.c
+++ b/src/host/trxcon/sched_lchan_tchf.c
@@ -151,13 +151,18 @@
n_errors, false, true);

 bfi:
-   /* Bad frame indication */
-   l2_len = sched_bad_frame_ind(l2, lchan);
-
/* Didn't try to decode */
if (n_errors < 0)
n_errors = 116 * 4;

+   /* BFI is not applicable in signalling mode */
+   if (lchan->tch_mode == GSM48_CMODE_SIGN)
+   return sched_send_dt_ind(trx, ts, lchan, NULL, 0,
+   n_errors, true, false);
+
+   /* Bad frame indication */
+   l2_len = sched_bad_frame_ind(l2, lchan);
+
/* Send a BFI frame to the higher layers */
return sched_send_dt_ind(trx, ts, lchan, l2, l2_len,
n_errors, true, true);

--
To view, visit https://gerrit.osmocom.org/10941
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie39d53522cafab265099076b3194fa96aff217ba
Gerrit-Change-Number: 10941
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 

Change in gr-gsm[master]: apps/grgsm_trx: remove redundant unit from freq_offset variable name

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10933 )

Change subject: apps/grgsm_trx: remove redundant unit from freq_offset variable 
name
..

apps/grgsm_trx: remove redundant unit from freq_offset variable name

Frequency is always in Hz so there is no need to add that
information in the variable name.

Change-Id: I509771c3fe072069a680f66b0763ae6825f6d529
---
M apps/grgsm_trx
M python/trx/radio_if.py
2 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve; Verified



diff --git a/apps/grgsm_trx b/apps/grgsm_trx
index b53d12a..efb9c24 100755
--- a/apps/grgsm_trx
+++ b/apps/grgsm_trx
@@ -52,7 +52,7 @@
self.phy_tx_gain = argv.tx_gain
self.phy_rx_antenna = argv.rx_antenna
self.phy_tx_antenna = argv.tx_antenna
-   self.phy_freq_offset_hz = argv.freq_offset
+   self.phy_freq_offset = argv.freq_offset
self.phy_ppm = argv.ppm

# Set up signal handlers
@@ -63,7 +63,7 @@
self.radio = radio_if(self.phy_args, self.phy_sample_rate,
self.phy_rx_gain, self.phy_tx_gain, self.phy_ppm,
self.phy_rx_antenna, self.phy_tx_antenna,
-   self.phy_freq_offset_hz, self.bind_addr,
+   self.phy_freq_offset, self.bind_addr,
self.remote_addr, self.base_port)

# Power measurement emulation
diff --git a/python/trx/radio_if.py b/python/trx/radio_if.py
index a9b0358..85970a9 100644
--- a/python/trx/radio_if.py
+++ b/python/trx/radio_if.py
@@ -85,7 +85,7 @@
def __init__(self, phy_args, phy_sample_rate,
phy_rx_gain, phy_tx_gain, phy_ppm,
phy_rx_antenna, phy_tx_antenna,
-   phy_freq_offset_hz, trx_bind_addr,
+   phy_freq_offset, trx_bind_addr,
trx_remote_addr, trx_base_port):

print("[i] Init Radio interface (L:%s:%u <-> R:%s:%u)"
@@ -97,7 +97,7 @@
self.rx_gain = phy_rx_gain
self.tx_gain = phy_tx_gain
self.ppm = phy_ppm
-   self.freq_offset_hz = phy_freq_offset_hz
+   self.freq_offset = phy_freq_offset

gr.top_block.__init__(self, "GR-GSM TRX")

@@ -279,19 +279,19 @@
return self.ppm / 1.0e6 * 2 * pi * fc / self.sample_rate

def set_rx_freq(self, fc):
-   fc += self.freq_offset_hz
+   fc += self.freq_offset
print("[#] Shifting RX freq. to %s (offset is %s)"
% (eng_notation.num_to_str(fc),
-   eng_notation.num_to_str(self.freq_offset_hz)))
+   eng_notation.num_to_str(self.freq_offset)))
self.phy_src.set_center_freq(fc, 0)
self.rotator_src.set_phase_inc(self.calc_phase_inc(fc))
self.rx_freq = fc

def set_tx_freq(self, fc):
-   fc += self.freq_offset_hz
+   fc += self.freq_offset
print("[#] Shifting TX freq. to %s (offset is %s)"
% (eng_notation.num_to_str(fc),
-   eng_notation.num_to_str(self.freq_offset_hz)))
+   eng_notation.num_to_str(self.freq_offset)))
self.phy_sink.set_center_freq(fc, 0)
self.rotator_sink.set_phase_inc(-self.calc_phase_inc(fc))
self.tx_freq = fc

--
To view, visit https://gerrit.osmocom.org/10933
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I509771c3fe072069a680f66b0763ae6825f6d529
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Krysik 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in gr-gsm[master]: apps/grgsm_trx: remove redundant unit from freq_offset variable name

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10933 )

Change subject: apps/grgsm_trx: remove redundant unit from freq_offset variable 
name
..


Patch Set 1: Verified+1 Code-Review+1


--
To view, visit https://gerrit.osmocom.org/10933
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I509771c3fe072069a680f66b0763ae6825f6d529
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Krysik 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 13 Sep 2018 16:34:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Jenkins build is back to normal : master-osmo-hlr » a1=default,a2=default,a3=default,osmocom-master-debian9 #1256

[jenkins]

See 

Change in osmo-hlr[master]: fix build: adjust test_nodes.vty to logging change

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10939 )

Change subject: fix build: adjust test_nodes.vty to logging change
..


Patch Set 1: Code-Review+2

fast track to fix master build


--
To view, visit https://gerrit.osmocom.org/10939
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia170f8416ebb60c499d2536078f43f28b61d0554
Gerrit-Change-Number: 10939
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 13 Sep 2018 16:24:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: fix build: adjust test_nodes.vty to logging change

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10939 )

Change subject: fix build: adjust test_nodes.vty to logging change
..

fix build: adjust test_nodes.vty to logging change

Since libosmocore
commit eb9284ba577d338f74653fcf09ebca0c397823eb
Change-Id I36f17c131cc70ce5a1aef62fd9693097de230cd4
"logging vty: deprecate 'all', introduce 'force-all'"
,
'logging level all' is replaced by 'force-all'.
Adjust the test script to not expect 'logging level all'.

While at it, remove some more expectations that aren't important.

Change-Id: Ia170f8416ebb60c499d2536078f43f28b61d0554
---
M tests/test_nodes.vty
1 file changed, 1 insertion(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved



diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
index 58f5c61..d2c455f 100644
--- a/tests/test_nodes.vty
+++ b/tests/test_nodes.vty
@@ -107,23 +107,12 @@
 !
 !
 log stderr
-  logging filter all 1
-  logging color 1
-  logging print category 1
-  logging print extended-timestamp 1
-  logging print file 1
-  logging level all notice
+...
   logging level main notice
   logging level db notice
   logging level auc notice
   logging level ss info
 ...
-!
-line vty
- no login
-!
-ctrl
- bind 127.0.0.1
 hlr
  gsup
   bind ip 127.0.0.1

--
To view, visit https://gerrit.osmocom.org/10939
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia170f8416ebb60c499d2536078f43f28b61d0554
Gerrit-Change-Number: 10939
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-hlr[master]: tweak example config

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/10940


Change subject: tweak example config
..

tweak example config

Remove 'logging level all' setting.
Tweak some more logging details (to my current favorite).

Add USSD example for showing the IMSI.

Change-Id: I8296832704d779df5f1b20a595b568c99780e64d
---
M doc/examples/osmo-hlr.cfg
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/40/10940/1

diff --git a/doc/examples/osmo-hlr.cfg b/doc/examples/osmo-hlr.cfg
index 35d942d..54993a9 100644
--- a/doc/examples/osmo-hlr.cfg
+++ b/doc/examples/osmo-hlr.cfg
@@ -5,9 +5,10 @@
   logging filter all 1
   logging color 1
   logging print category 1
-  logging timestamp 1
+  logging print category-hex 0
+  logging print level 1
+  logging print file basename last
   logging print extended-timestamp 1
-  logging level all notice
   logging level main notice
   logging level db notice
   logging level auc notice
@@ -22,3 +23,4 @@
  gsup
   bind ip 127.0.0.1
  ussd route prefix *#100# internal own-msisdn
+ ussd route prefix *#101# internal own-imsi

--
To view, visit https://gerrit.osmocom.org/10940
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8296832704d779df5f1b20a595b568c99780e64d
Gerrit-Change-Number: 10940
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-gsm-tester[master]: Build and use osmo-bsc_mgcp from openbsc.git instead of osmo-mgw.git

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10928 )

Change subject: Build and use osmo-bsc_mgcp from openbsc.git instead of 
osmo-mgw.git
..

Build and use osmo-bsc_mgcp from openbsc.git instead of osmo-mgw.git

In osmo-mgw.git 31b4729f2731c747b8b33c4646dd5ade2ace29bc, osmo-bsc_mgcp
was dropped and the one from openbsc.git must be used.

Change-Id: Ib1c46baf4d36ab18f8064a2234a0ba28a1e7d2c2
---
M contrib/jenkins-build-osmo-mgw.sh
M contrib/jenkins-build-osmo-nitb.sh
M src/osmo_gsm_tester/osmo_mgcpgw.py
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins-build-osmo-mgw.sh 
b/contrib/jenkins-build-osmo-mgw.sh
index 43473c6..5c1ce74 100755
--- a/contrib/jenkins-build-osmo-mgw.sh
+++ b/contrib/jenkins-build-osmo-mgw.sh
@@ -9,4 +9,4 @@
 build_repo libosmo-netif --enable-sanitize --disable-doxygen
 build_repo osmo-mgw --enable-sanitize

-create_bin_tgz "osmo-bsc_mgcp osmo-mgw"
+create_bin_tgz "osmo-mgw"
diff --git a/contrib/jenkins-build-osmo-nitb.sh 
b/contrib/jenkins-build-osmo-nitb.sh
index ef55259..1e3ecc6 100755
--- a/contrib/jenkins-build-osmo-nitb.sh
+++ b/contrib/jenkins-build-osmo-nitb.sh
@@ -12,4 +12,4 @@
 build_repo libosmo-sccp
 build_repo openbsc --enable-smpp --enable-osmo-bsc --enable-nat

-create_bin_tgz osmo-nitb
+create_bin_tgz "osmo-nitb osmo-bsc_mgcp"
diff --git a/src/osmo_gsm_tester/osmo_mgcpgw.py 
b/src/osmo_gsm_tester/osmo_mgcpgw.py
index 82b9149..668e4ce 100644
--- a/src/osmo_gsm_tester/osmo_mgcpgw.py
+++ b/src/osmo_gsm_tester/osmo_mgcpgw.py
@@ -38,7 +38,7 @@
 self.log('Starting osmo-mgcpgw')
 self.run_dir = 
util.Dir(self.suite_run.get_test_run_dir().new_dir(self.name()))
 self.configure()
-inst = 
util.Dir(os.path.abspath(self.suite_run.trial.get_inst('osmo-mgw')))
+inst = 
util.Dir(os.path.abspath(self.suite_run.trial.get_inst('osmo-nitb')))
 binary = inst.child('bin', 'osmo-bsc_mgcp')
 if not os.path.isfile(binary):
 raise RuntimeError('Binary missing: %r' % binary)

--
To view, visit https://gerrit.osmocom.org/10928
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1c46baf4d36ab18f8064a2234a0ba28a1e7d2c2
Gerrit-Change-Number: 10928
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-hlr[master]: fix build: adjust test_nodes.vty to logging change

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/10939


Change subject: fix build: adjust test_nodes.vty to logging change
..

fix build: adjust test_nodes.vty to logging change

Since libosmocore
commit eb9284ba577d338f74653fcf09ebca0c397823eb
Change-Id I36f17c131cc70ce5a1aef62fd9693097de230cd4
"logging vty: deprecate 'all', introduce 'force-all'"
,
'logging level all' is replaced by 'force-all'.
Adjust the test script to not expect 'logging level all'.

While at it, remove some more expectations that aren't important.

Change-Id: Ia170f8416ebb60c499d2536078f43f28b61d0554
---
M tests/test_nodes.vty
1 file changed, 1 insertion(+), 12 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/39/10939/1

diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
index 58f5c61..d2c455f 100644
--- a/tests/test_nodes.vty
+++ b/tests/test_nodes.vty
@@ -107,23 +107,12 @@
 !
 !
 log stderr
-  logging filter all 1
-  logging color 1
-  logging print category 1
-  logging print extended-timestamp 1
-  logging print file 1
-  logging level all notice
+...
   logging level main notice
   logging level db notice
   logging level auc notice
   logging level ss info
 ...
-!
-line vty
- no login
-!
-ctrl
- bind 127.0.0.1
 hlr
  gsup
   bind ip 127.0.0.1

--
To view, visit https://gerrit.osmocom.org/10939
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia170f8416ebb60c499d2536078f43f28b61d0554
Gerrit-Change-Number: 10939
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Build failed in Jenkins: master-osmo-hlr » a1=default,a2=default,a3=default,osmocom-master-debian9 #1255

[jenkins]

See 


--
[...truncated 148.51 KB...]
 KI=beefedcafefaceacedaddeddecadefee

OsmoHLR# subscriber id 1 update aud2g comp128v2 ki 
CededEffacedAceFacedBadFadedBeef

OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v2
 KI=cededeffacedacefacedbadfadedbeef
OsmoHLR# subscriber msisdn 423 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v2
 KI=cededeffacedacefacedbadfadedbeef
OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v2
 KI=cededeffacedacefacedbadfadedbeef

OsmoHLR# subscriber msisdn 423 update aud2g comp128v3 ki 
C01ffedC1cadaeAc1d1f1edAcac1aB0a

OsmoHLR# subscriber msisdn 423 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a
OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g nonsense ki 
BeefedCafeFaceAcedAddedDecadeFee
% Unknown command.
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g milenage ki 
BeefedCafeFaceAcedAddedDecadeFee
% Unknown command.
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g xor ki CoiffedCicadaeAcidifiedAcaciaBoa
% Invalid value for KI: 'CoiffedCicadaeAcidifiedAcaciaBoa'
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g xor ki C01ffedC1cadaeAc1d1f1edAcac1aB0aX
% Invalid value for KI: 'C01ffedC1cadaeAc1d1f1edAcac1aB0aX'
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g none

OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423


OsmoHLR# subscriber imsi 123456789023000 update aud3g ?
  none  Delete 3G authentication data
  milenage  Use Milenage algorithm

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage ?
  k  Set Encryption Key K

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k ?
  K  K as 32 hexadecimal characters

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d ?
  op   Set OP key
  opc  Set OPC key

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc ?
  OP_C  OP or OPC as 32 hexadecimal characters

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc CededEffacedAceFacedBadFadedBeef ?
  [ind-bitlen]  Set IND bit length

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc CededEffacedAceFacedBadFadedBeef 
ind-bitlen ?
  [<0-28>]  IND bit length value (default: 5)

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc CededEffacedAceFacedBadFadedBeef

OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
3G auth: MILENAGE
 K=deaf0ff1ced0d0dabbedd1ced1cef00d
 OPC=cededeffacedacefacedbadfadedbeef
 IND-bitlen=5


OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d op DeafBeddedBabeAcceededFadedDecaf

OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
3G auth: MILENAGE
 K=deaf0ff1ced0d0dabbedd1ced1cef00d
 OP=deafbeddedbabeacceededfadeddecaf
 IND-bitlen=5

OsmoHLR# subscriber imsi 123456789023000 update aud3g none

OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc CededEffacedAceFacedBadFadedBeef 
ind-bitlen 23

OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
3G auth: MILENAGE
 K=deaf0ff1ced0d0dabbedd1ced1cef00d
 OPC=cededeffacedacefacedbadfadedbeef
 IND-bitlen=23

OsmoHLR# subscriber imsi 

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  152s] #define HAVE_SYS_STAT_H 1
[  152s] #define HAVE_STDLIB_H 1
[  152s] #define HAVE_STRING_H 1
[  152s] #define HAVE_MEMORY_H 1
[  152s] #define HAVE_STRINGS_H 1
[  152s] #define HAVE_INTTYPES_H 1
[  152s] #define HAVE_STDINT_H 1
[  152s] #define HAVE_UNISTD_H 1
[  152s] #define HAVE_DLFCN_H 1
[  152s] #define LT_OBJDIR ".libs/"
[  152s] 
[  152s] configure: exit 1
[  152s] dh_auto_configure: ./configure --build=i586-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--libdir=${prefix}/lib/i386-linux-gnu --libexecdir=${prefix}/lib/i386-linux-gnu 
--disable-maintainer-mode --disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  152s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  152s] make[1]: *** [override_dh_auto_configure] Error 255
[  152s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  152s] debian/rules:45: recipe for target 'build' failed
[  152s] make: *** [build] Error 2
[  152s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  152s] 
[  152s] cloud129 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
16:05:57 UTC 2018.
[  152s] 
[  152s] ### VM INTERACTION START ###
[  154s] Powering off.
[  154s] [  106.553244] reboot: Power down
[  155s] ### VM INTERACTION END ###
[  155s] 
[  155s] cloud129 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
16:06:01 UTC 2018.
[  155s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failed in Jenkins: master-osmo-hlr » a1=default,a2=default,a3=default,osmocom-master-debian9 #1254

[jenkins]

See 


--
[...truncated 149.83 KB...]
 KI=beefedcafefaceacedaddeddecadefee

OsmoHLR# subscriber id 1 update aud2g comp128v2 ki 
CededEffacedAceFacedBadFadedBeef

OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v2
 KI=cededeffacedacefacedbadfadedbeef
OsmoHLR# subscriber msisdn 423 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v2
 KI=cededeffacedacefacedbadfadedbeef
OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v2
 KI=cededeffacedacefacedbadfadedbeef

OsmoHLR# subscriber msisdn 423 update aud2g comp128v3 ki 
C01ffedC1cadaeAc1d1f1edAcac1aB0a

OsmoHLR# subscriber msisdn 423 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a
OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g nonsense ki 
BeefedCafeFaceAcedAddedDecadeFee
% Unknown command.
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g milenage ki 
BeefedCafeFaceAcedAddedDecadeFee
% Unknown command.
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g xor ki CoiffedCicadaeAcidifiedAcaciaBoa
% Invalid value for KI: 'CoiffedCicadaeAcidifiedAcaciaBoa'
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g xor ki C01ffedC1cadaeAc1d1f1edAcac1aB0aX
% Invalid value for KI: 'C01ffedC1cadaeAc1d1f1edAcac1aB0aX'
OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
2G auth: COMP128v3
 KI=c01ffedc1cadaeac1d1f1edacac1ab0a

OsmoHLR# subscriber id 1 update aud2g none

OsmoHLR# subscriber id 1 show
ID: 1
IMSI: 123456789023000
MSISDN: 423


OsmoHLR# subscriber imsi 123456789023000 update aud3g ?
  none  Delete 3G authentication data
  milenage  Use Milenage algorithm

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage ?
  k  Set Encryption Key K

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k ?
  K  K as 32 hexadecimal characters

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d ?
  op   Set OP key
  opc  Set OPC key

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc ?
  OP_C  OP or OPC as 32 hexadecimal characters

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc CededEffacedAceFacedBadFadedBeef ?
  [ind-bitlen]  Set IND bit length

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc CededEffacedAceFacedBadFadedBeef 
ind-bitlen ?
  [<0-28>]  IND bit length value (default: 5)

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc CededEffacedAceFacedBadFadedBeef

OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
3G auth: MILENAGE
 K=deaf0ff1ced0d0dabbedd1ced1cef00d
 OPC=cededeffacedacefacedbadfadedbeef
 IND-bitlen=5


OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d op DeafBeddedBabeAcceededFadedDecaf

OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
3G auth: MILENAGE
 K=deaf0ff1ced0d0dabbedd1ced1cef00d
 OP=deafbeddedbabeacceededfadeddecaf
 IND-bitlen=5

OsmoHLR# subscriber imsi 123456789023000 update aud3g none

OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423

OsmoHLR# subscriber imsi 123456789023000 update aud3g milenage k 
Deaf0ff1ceD0d0DabbedD1ced1ceF00d opc CededEffacedAceFacedBadFadedBeef 
ind-bitlen 23

OsmoHLR# subscriber imsi 123456789023000 show
ID: 1
IMSI: 123456789023000
MSISDN: 423
3G auth: MILENAGE
 K=deaf0ff1ced0d0dabbedd1ced1cef00d
 OPC=cededeffacedacefacedbadfadedbeef
 IND-bitlen=23

OsmoHLR# subscriber imsi 

Jenkins build is back to normal : master-osmo-sip-connector » a1=default,a2=default,a3=default,osmocom-master-debian9 #698

[jenkins]

See 

Change in osmo-sgsn[master]: debian: Add missing dependencies to build with IU support

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10938


Change subject: debian: Add missing dependencies to build with IU support
..

debian: Add missing dependencies to build with IU support

Change-Id: Ic8bfef3a72d5e8ba7ecf1f4fb27f7007c5fa5f19
---
M debian/control
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/38/10938/1

diff --git a/debian/control b/debian/control
index 46a6b67..7822561 100644
--- a/debian/control
+++ b/debian/control
@@ -17,7 +17,10 @@
libosmo-abis-dev,
libosmo-ranap-dev,
libosmo-sccp-dev,
-   libosmo-netif-dev
+   libosmo-netif-dev,
+   libasn1c-dev (>= 0.9.28),
+   libosmo-sigtran-dev (>= 0.10.0),
+   libosmo-ranap-dev (>= 0.3.0)
 Standards-Version: 3.9.8
 Vcs-Git: git://git.osmocom.org/osmo-sgsn.git
 Vcs-Browser: https://git.osmocom.org/osmo-sgsn

--
To view, visit https://gerrit.osmocom.org/10938
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8bfef3a72d5e8ba7ecf1f4fb27f7007c5fa5f19
Gerrit-Change-Number: 10938
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  106s] #define HAVE_SYS_STAT_H 1
[  106s] #define HAVE_STDLIB_H 1
[  106s] #define HAVE_STRING_H 1
[  106s] #define HAVE_MEMORY_H 1
[  106s] #define HAVE_STRINGS_H 1
[  106s] #define HAVE_INTTYPES_H 1
[  106s] #define HAVE_STDINT_H 1
[  106s] #define HAVE_UNISTD_H 1
[  106s] #define HAVE_DLFCN_H 1
[  106s] #define LT_OBJDIR ".libs/"
[  106s] 
[  106s] configure: exit 1
[  106s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf 
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf 
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  106s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  106s] make[1]: *** [override_dh_auto_configure] Error 2
[  106s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  106s] debian/rules:45: recipe for target 'build' failed
[  106s] make: *** [build] Error 2
[  106s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  106s] 
[  106s] armbuild21 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:49:53 UTC 2018.
[  106s] 
[  106s] ### VM INTERACTION START ###
[  109s] [   96.369743] SysRq : Power Off
[  109s] [   96.371855] reboot: Power down
[  109s] ### VM INTERACTION END ###
[  109s] 
[  109s] armbuild21 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:49:56 UTC 2018.
[  109s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-bts[master]: add vty config for GSMTAP-SAPI remote host (-i)

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10808 )

Change subject: add vty config for GSMTAP-SAPI remote host (-i)
..


Patch Set 2:

the gsmtap host setting only has effect during program startup, the vty command 
doesn't actively change over to another address -- my aim was to configure ot 
from .cfg file to not have to change the cmdline, not to switch it in the 
running program ... then again, maybe it should be doing that?

Or, even if it doesn't do it yet, keep that option for the future and not even 
start supporting arbitrary host names now?


--
To view, visit https://gerrit.osmocom.org/10808
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1
Gerrit-Change-Number: 10808
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Sep 2018 15:49:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  142s] #define HAVE_SYS_STAT_H 1
[  142s] #define HAVE_STDLIB_H 1
[  142s] #define HAVE_STRING_H 1
[  142s] #define HAVE_MEMORY_H 1
[  142s] #define HAVE_STRINGS_H 1
[  142s] #define HAVE_INTTYPES_H 1
[  142s] #define HAVE_STDINT_H 1
[  142s] #define HAVE_UNISTD_H 1
[  142s] #define HAVE_DLFCN_H 1
[  142s] #define LT_OBJDIR ".libs/"
[  142s] 
[  142s] configure: exit 1
[  142s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu 
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  142s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  142s] make[1]: *** [override_dh_auto_configure] Error 2
[  142s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  142s] debian/rules:45: recipe for target 'build' failed
[  142s] make: *** [build] Error 2
[  142s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  142s] 
[  142s] lamb51 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:48:27 UTC 2018.
[  142s] 
[  142s] ### VM INTERACTION START ###
[  145s] [  132.269169] sysrq: SysRq : Power Off
[  145s] [  132.290351] reboot: Power down
[  145s] ### VM INTERACTION END ###
[  145s] 
[  145s] lamb51 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:48:31 UTC 2018.
[  145s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_18.04/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  154s] #define HAVE_SYS_STAT_H 1
[  154s] #define HAVE_STDLIB_H 1
[  154s] #define HAVE_STRING_H 1
[  154s] #define HAVE_MEMORY_H 1
[  154s] #define HAVE_STRINGS_H 1
[  154s] #define HAVE_INTTYPES_H 1
[  154s] #define HAVE_STDINT_H 1
[  154s] #define HAVE_UNISTD_H 1
[  154s] #define HAVE_DLFCN_H 1
[  154s] #define LT_OBJDIR ".libs/"
[  154s] 
[  154s] configure: exit 1
[  154s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu 
--libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  154s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  154s] make[1]: *** [override_dh_auto_configure] Error 2
[  154s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  154s] debian/rules:45: recipe for target 'build' failed
[  154s] make: *** [build] Error 2
[  154s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  154s] 
[  154s] cloud104 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:47:17 UTC 2018.
[  154s] 
[  154s] ### VM INTERACTION START ###
[  157s] [  135.412494] sysrq: SysRq : Power Off
[  157s] [  135.451252] reboot: Power down
[  158s] ### VM INTERACTION END ###
[  158s] 
[  158s] cloud104 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:47:22 UTC 2018.
[  158s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in libosmocore[master]: logging vty: deprecate the 'everything' keyword

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10885 )

Change subject: logging vty: deprecate the 'everything' keyword
..

logging vty: deprecate the 'everything' keyword

The 'logging level all everything' has not had an effect for some time now. The
plan is to bring back its old functionality, but to keep it deprecated and
rather define a less confusing name.

* Deprecate 'everything'.
* Do not write 'everything' during 'write file' or 'show running-config', which
  we curiously still do until now.

BTW, the reason why we need to compose a complete list of categories for the
deprecated 'everything' command is explained in detail in the commit log for
I3b083f27e3d751ccec258880ae7676e9af959a63

Change-Id: Ib75fedb0572570a61bb34ee729a2af86cf5f16da
---
M src/logging.c
M src/vty/logging_vty.c
M tests/logging/logging_vty_test.vty
3 files changed, 35 insertions(+), 30 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/logging.c b/src/logging.c
index 7c2d61f..67470a5 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -64,7 +64,6 @@
 LLIST_HEAD(osmo_log_target_list);
 
 static const struct value_string loglevel_strs[] = {
-   { 0,"EVERYTHING" },
{ LOGL_DEBUG,   "DEBUG" },
{ LOGL_INFO,"INFO" },
{ LOGL_NOTICE,  "NOTICE" },
diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index 2b001bc..6758dd2 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -320,7 +320,7 @@
cmd->doc = doc_str;
 }

-/* logging level (all|) (everything|debug|...|fatal) */
+/* logging level (all|) (debug|...|fatal) */
 DEFUN(logging_level,
   logging_level_cmd,
   NULL, /* cmdstr is dynamically set in logging_vty_add_cmds(). */
@@ -338,11 +338,6 @@
return CMD_WARNING;
}

-   if (strcmp(argv[1], "everything") == 0) { /* FIXME: remove this check 
once 'everything' is phased out */
-   vty_out(vty, "%% Ignoring deprecated logging level %s%s", 
argv[1], VTY_NEWLINE);
-   return CMD_SUCCESS;
-   }
-
/* Check for special case where we want to set global log level */
if (!strcmp(argv[0], "all")) {
log_set_log_level(tgt, level);
@@ -360,6 +355,15 @@
return CMD_SUCCESS;
 }

+/* logging level (all|) everything */
+DEFUN_DEPRECATED(deprecated_logging_level_everything, 
deprecated_logging_level_everything_cmd,
+NULL, /* cmdstr is dynamically set in logging_vty_add_cmds(). 
*/
+NULL) /* same thing for helpstr. */
+{
+   vty_out(vty, "%% Ignoring deprecated logging level 'everything' 
keyword%s", VTY_NEWLINE);
+   return CMD_SUCCESS;
+}
+
 DEFUN(logging_set_category_mask,
   logging_set_category_mask_cmd,
   "logging set-log-mask MASK",
@@ -858,8 +862,9 @@
VTY_NEWLINE);

/* stupid old osmo logging API uses uppercase strings... */
-   vty_out(vty, "  logging level all %s%s", 
osmo_str_tolower(log_level_str(tgt->loglevel)),
-   VTY_NEWLINE);
+   if (tgt->loglevel)
+   vty_out(vty, "  logging level all %s%s", 
osmo_str_tolower(log_level_str(tgt->loglevel)),
+   VTY_NEWLINE);

for (i = 0; i < osmo_log_info->num_cat; i++) {
const struct log_category *cat = >categories[i];
@@ -896,7 +901,7 @@
 {
struct cmd_element *cmd = talloc_zero(ctx, struct cmd_element);
OSMO_ASSERT(cmd);
-   cmd->string = talloc_asprintf(cmd, "logging level %s 
(everything|debug|info|notice|error|fatal)",
+   cmd->string = talloc_asprintf(cmd, "logging level %s 
(debug|info|notice|error|fatal)",
name);
printf("%s\n", cmd->string);
cmd->func = log_deprecated_func;
@@ -924,12 +929,16 @@
install_element_ve(_set_category_mask_cmd);
install_element_ve(_set_category_mask_old_cmd);

-   /* logging level (all|) (everything|debug|...|fatal) */
+   /* logging level (all|) (debug|...|fatal) */
gen_logging_level_cmd_strs(_level_cmd,
-  "(everything|" LOG_LEVEL_ARGS ")",
-  EVERYTHING_STR LOG_LEVEL_STRS);
+  "(" LOG_LEVEL_ARGS ")",
+  LOG_LEVEL_STRS);
+   /* logging level (all|) everything */
+   gen_logging_level_cmd_strs(_logging_level_everything_cmd,
+  "everything", EVERYTHING_STR);

install_element_ve(_level_cmd);
+   install_element_ve(_logging_level_everything_cmd);
install_element_ve(_logging_vty_cmd);
install_element_ve(_alarms_cmd);

@@ -943,6 +952,7 @@
install_element(CFG_LOG_NODE, _prnt_level_cmd);
install_element(CFG_LOG_NODE, _prnt_file_cmd);
install_element(CFG_LOG_NODE, 

Change in libosmocore[master]: logging vty: deprecate 'all', introduce 'force-all'

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10888 )

Change subject: logging vty: deprecate 'all', introduce 'force-all'
..

logging vty: deprecate 'all', introduce 'force-all'

Add 'logging level force-all ' and 'no logging level force-all' as new
names for 'logging level all ' and 'logging level all everything'.

Resurrect the functionality of 'logging level all everything' -- even if it is
still deprecated because the name is confusing, it is now just an alias for
'no logging level force-all'.

Show in logging_vty_test.vty that we can now again lift the global logging
clamp, both with the new commands as well as with the deprecated ones.
Also show that 'force-all' is written back properly, if set.

Change-Id: I36f17c131cc70ce5a1aef62fd9693097de230cd4
---
M src/vty/logging_vty.c
M tests/logging/logging_vty_test.vty
2 files changed, 190 insertions(+), 33 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index c8e8520..3b1d8c6 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -43,9 +43,15 @@
 #define LOG_STR "Configure logging sub-system\n"
 #define LEVEL_STR "Set the log level for a specified category\n"

-#define CATEGORY_ALL_STR "Global setting for all subsystems\n"
+#define CATEGORY_ALL_STR "Deprecated alias for 'force-all'\n"
+#define FORCE_ALL_STR \
+   "Globally force all logging categories to a specific level. This is 
released by the" \
+   " 'no logging level force-all' command. Note: any 'logging level 
 '" \
+   " commands will have no visible effect after this, until the forced 
level is released.\n"
+#define NO_FORCE_ALL_STR \
+   "Release any globally forced log level set with 'logging level 
force-all '\n"

-#define LOG_LEVEL_ARGS "debug|info|notice|error|fatal"
+#define LOG_LEVEL_ARGS "(debug|info|notice|error|fatal)"
 #define LOG_LEVEL_STRS \
"Log debug messages and higher levels\n" \
"Log informational messages and higher levels\n" \
@@ -53,7 +59,7 @@
"Log error messages and higher levels\n" \
"Log only fatal messages\n"

-#define EVERYTHING_STR "Don't use. It doesn't log anything\n"
+#define EVERYTHING_STR "Deprecated alias for 'no logging level force-all'\n"

 /*! \file logging_vty.c
  *  Configuration of logging from VTY
@@ -307,11 +313,10 @@
OSMO_ASSERT(cmd->string == NULL);
OSMO_ASSERT(cmd->doc == NULL);

-   osmo_talloc_asprintf(tall_log_ctx, cmd_str, "logging level (all|");
+   osmo_talloc_asprintf(tall_log_ctx, cmd_str, "logging level (");
osmo_talloc_asprintf(tall_log_ctx, doc_str,
 LOGGING_STR
-LEVEL_STR
-CATEGORY_ALL_STR);
+LEVEL_STR);
add_category_strings(_str, _str, osmo_log_info);
osmo_talloc_asprintf(tall_log_ctx, cmd_str, ") %s", level_args);
osmo_talloc_asprintf(tall_log_ctx, doc_str, "%s", level_strs);
@@ -320,7 +325,7 @@
cmd->doc = doc_str;
 }

-/* logging level (all|) (debug|...|fatal) */
+/* logging level () (debug|...|fatal) */
 DEFUN(logging_level,
   logging_level_cmd,
   NULL, /* cmdstr is dynamically set in logging_vty_add_cmds(). */
@@ -338,12 +343,6 @@
return CMD_WARNING;
}

-   /* Check for special case where we want to set global log level */
-   if (!strcmp(argv[0], "all")) {
-   log_set_log_level(tgt, level);
-   return CMD_SUCCESS;
-   }
-
if (category < 0) {
vty_out(vty, "Invalid category `%s'%s", argv[0], VTY_NEWLINE);
return CMD_WARNING;
@@ -355,7 +354,7 @@
return CMD_SUCCESS;
 }

-/* logging level (all|) everything */
+/* logging level () everything */
 DEFUN_DEPRECATED(deprecated_logging_level_everything, 
deprecated_logging_level_everything_cmd,
 NULL, /* cmdstr is dynamically set in logging_vty_add_cmds(). 
*/
 NULL) /* same thing for helpstr. */
@@ -364,6 +363,35 @@
return CMD_SUCCESS;
 }

+DEFUN(logging_level_force_all, logging_level_force_all_cmd,
+  "logging level force-all " LOG_LEVEL_ARGS,
+  LOGGING_STR LEVEL_STR FORCE_ALL_STR LOG_LEVEL_STRS)
+{
+   struct log_target *tgt = osmo_log_vty2tgt(vty);
+   int level = log_parse_level(argv[0]);
+   log_set_log_level(tgt, level);
+   return CMD_SUCCESS;
+}
+
+DEFUN(no_logging_level_force_all, no_logging_level_force_all_cmd,
+  "no logging level force-all",
+  NO_STR LOGGING_STR LEVEL_STR NO_FORCE_ALL_STR)
+{
+   struct log_target *tgt = osmo_log_vty2tgt(vty);
+   log_set_log_level(tgt, 0);
+   return CMD_SUCCESS;
+}
+
+/* 'logging level all (debug|...|fatal)' */

Change in libosmocore[master]: logging vty: write: check logging levels validity

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10887 )

Change subject: logging vty: write: check logging levels validity
..

logging vty: write: check logging levels validity

Change-Id: If683b1272ad2d5b402b91c52c496aa7975bc6315
---
M include/osmocom/core/logging_internal.h
M src/logging.c
M src/vty/logging_vty.c
3 files changed, 25 insertions(+), 8 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/core/logging_internal.h 
b/include/osmocom/core/logging_internal.h
index 55b1bbd..a510f83 100644
--- a/include/osmocom/core/logging_internal.h
+++ b/include/osmocom/core/logging_internal.h
@@ -8,6 +8,7 @@

 extern void *tall_log_ctx;
 extern const struct log_info *osmo_log_info;
+extern const struct value_string loglevel_strs[];

 void assert_loginfo(const char *src);

diff --git a/src/logging.c b/src/logging.c
index 67470a5..e7cc472 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -63,7 +63,7 @@
 void *tall_log_ctx = NULL;
 LLIST_HEAD(osmo_log_target_list);

-static const struct value_string loglevel_strs[] = {
+const struct value_string loglevel_strs[] = {
{ LOGL_DEBUG,   "DEBUG" },
{ LOGL_INFO,"INFO" },
{ LOGL_NOTICE,  "NOTICE" },
diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c
index 6758dd2..c8e8520 100644
--- a/src/vty/logging_vty.c
+++ b/src/vty/logging_vty.c
@@ -861,21 +861,37 @@
get_value_string(logging_print_file_args, tgt->print_filename2),
VTY_NEWLINE);

-   /* stupid old osmo logging API uses uppercase strings... */
-   if (tgt->loglevel)
-   vty_out(vty, "  logging level all %s%s", 
osmo_str_tolower(log_level_str(tgt->loglevel)),
-   VTY_NEWLINE);
+   if (tgt->loglevel) {
+   const char *level_str = get_value_string_or_null(loglevel_strs, 
tgt->loglevel);
+   level_str = osmo_str_tolower(level_str);
+   if (!level_str)
+   vty_out(vty, "%% Invalid log level %u for 'all'%s", 
tgt->loglevel, VTY_NEWLINE);
+   else
+   vty_out(vty, "  logging level all %s%s", level_str, 
VTY_NEWLINE);
+   }

for (i = 0; i < osmo_log_info->num_cat; i++) {
const struct log_category *cat = >categories[i];
+   const char *cat_name;
+   const char *level_str;

/* skip empty entries in the array */
if (!osmo_log_info->cat[i].name)
continue;

-   /* stupid old osmo logging API uses uppercase strings... */
-   vty_out(vty, "  logging level %s", 
osmo_str_tolower(osmo_log_info->cat[i].name+1));
-   vty_out(vty, " %s%s", 
osmo_str_tolower(log_level_str(cat->loglevel)), VTY_NEWLINE);
+   /* Note: cat_name references the static buffer returned by 
osmo_str_tolower(), will
+* become invalid after next osmo_str_tolower() invocation. */
+   cat_name = osmo_str_tolower(osmo_log_info->cat[i].name+1);
+
+   level_str = get_value_string_or_null(loglevel_strs, 
cat->loglevel);
+   if (!level_str) {
+   vty_out(vty, "%% Invalid log level %u for %s%s", 
cat->loglevel, cat_name,
+   VTY_NEWLINE);
+   continue;
+   }
+
+   vty_out(vty, "  logging level %s", cat_name);
+   vty_out(vty, " %s%s", osmo_str_tolower(level_str), VTY_NEWLINE);
}

return 1;

--
To view, visit https://gerrit.osmocom.org/10887
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If683b1272ad2d5b402b91c52c496aa7975bc6315
Gerrit-Change-Number: 10887
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in libosmocore[master]: jenkins: add --enable-external-tests

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10890 )

Change subject: jenkins: add --enable-external-tests
..

jenkins: add --enable-external-tests

Run the new logging_vty_test.vty VTY transcript test in our CI.

Change-Id: Ic4ec1f6c131da50b3956f16f0b49375f387196b3
---
M contrib/jenkins_amd64.sh
M contrib/jenkins_arm.sh
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins_amd64.sh b/contrib/jenkins_amd64.sh
index c3af378..cd7b666 100755
--- a/contrib/jenkins_amd64.sh
+++ b/contrib/jenkins_amd64.sh
@@ -15,7 +15,8 @@

 prep_build "$src_dir" "$build_dir"

-"$src_dir"/configure  --disable-silent-rules --enable-static 
$ENABLE_SANITIZE --enable-werror
+"$src_dir"/configure  --disable-silent-rules --enable-static 
$ENABLE_SANITIZE --enable-werror \
+--enable-external-tests

 run_make
 }
diff --git a/contrib/jenkins_arm.sh b/contrib/jenkins_arm.sh
index 1d72f2f..e3a6cd1 100755
--- a/contrib/jenkins_arm.sh
+++ b/contrib/jenkins_arm.sh
@@ -18,6 +18,7 @@
--enable-embedded \
--disable-doxygen \
--disable-shared \
+   --enable-external-tests \
CFLAGS="-Os -ffunction-sections -fdata-sections -nostartfiles 
-nodefaultlibs $WERROR_FLAGS"

 $MAKE $PARALLEL_MAKE

--
To view, visit https://gerrit.osmocom.org/10890
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4ec1f6c131da50b3956f16f0b49375f387196b3
Gerrit-Change-Number: 10890
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in libosmocore[master]: logging vty: rewrite 'logging level' vty cmd generation

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10884 )

Change subject: logging vty: rewrite 'logging level' vty cmd generation
..

logging vty: rewrite 'logging level' vty cmd generation

Completely drop the implementations of log_vty_command_{str,description}().
These functions have been public API once, marked as deprecated since
c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7 (March 2017). I considered to keep
them, or reduce them to useless stubs, but it is quite silly, really. These
functions are completely and utterly useless outside of libosmocore. Any
program linking these deserves to fail.

Re-implement vty logging level command gen, in logging_vty.c. logging.c is
simply the wrong place for that.

Introduce logging_internal.h to share logging definitions to logging_vty.c
without publishing as API.

Introduce static gen_logging_level_cmd_strs() to compose a list of category
arguments with their descriptions for VTY commands. Use osmo_talloc_asprintf()
instead of the previous error prone and chaotic strlen() counting method.

Do not dynamically generate log level arguments, just keep static strings. We
are super unlikely to ever change the log levels we have.

No changes in logging_vty_test.vty: proves that there is no functional change.

All of this, besides introducing basic sanity, is cosmetic preparation to be
able to re-use the generic command generation code for arbitrary commands with
category or level args (for deprecated and new keywords).

Rationale: I want to hide 'all' and 'everything' from the VTY command
documentation, by means of deprecating. I first tried to simply define a
deprecated 'logging level CAT everything' command:

  logging level (all|rsl|rr|...) (debug|info|notice|error|fatal)
  logging level CAT everything   # <- deprecated and hidden

But unfortunately, command matching doesn't work as intended when the CAT
argument reflects a valid category; I want it to invoke the deprecated function
as soon as the 'everything' keyword follows, but it stays stuck to the "valid"
command when the category argument matches an explicit keyword in that list,
and will throw an error on the following 'everything' keyword. I.e.:

  logging level rsl everything
  % Unknown command  # <-- leads to config file parse error

  logging level unknown_string everything
  % Ignoring deprecated 'everything'  # <-- works only for invalid categories

So I need to define 'everything' separately, again with a list of each valid
category instead of a generic CAT arg.

Change-Id: I3b083f27e3d751ccec258880ae7676e9af959a63
---
M include/Makefile.am
M include/osmocom/core/logging.h
A include/osmocom/core/logging_internal.h
M src/logging.c
M src/vty/logging_vty.c
5 files changed, 82 insertions(+), 172 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/Makefile.am b/include/Makefile.am
index ef8ec65..19695d1 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -152,7 +152,10 @@
 endif

 noinst_HEADERS = \
-   osmocom/gsm/kasumi.h osmocom/gsm/gea.h
+   osmocom/gsm/kasumi.h \
+   osmocom/gsm/gea.h \
+   osmocom/core/logging_internal.h \
+   $(NULL)

 osmocom/core/bit%gen.h: osmocom/core/bitXXgen.h.tpl
$(AM_V_GEN)$(MKDIR_P) $(dir $@)
diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h
index c60143d..295e5a8 100644
--- a/include/osmocom/core/logging.h
+++ b/include/osmocom/core/logging.h
@@ -374,10 +374,6 @@
 void log_add_target(struct log_target *target);
 void log_del_target(struct log_target *target);

-/* Generate command string for VTY use */
-const char *log_vty_command_string() OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE;
-const char *log_vty_command_description() OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE;
-
 struct log_target *log_target_find(int type, const char *fname);
 extern struct llist_head osmo_log_target_list;

diff --git a/include/osmocom/core/logging_internal.h 
b/include/osmocom/core/logging_internal.h
new file mode 100644
index 000..55b1bbd
--- /dev/null
+++ b/include/osmocom/core/logging_internal.h
@@ -0,0 +1,14 @@
+#pragma once
+
+/*! \defgroup logging_internal Osmocom logging internals
+ *  @{
+ * \file logging_internal.h */
+
+#include 
+
+extern void *tall_log_ctx;
+extern const struct log_info *osmo_log_info;
+
+void assert_loginfo(const char *src);
+
+/*! @} */
diff --git a/src/logging.c b/src/logging.c
index de0f2b0..7c2d61f 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -35,7 +35,6 @@
 #include 
 #include 
 #include 
-#include 

 #ifdef HAVE_STRINGS_H
 #include 
@@ -61,12 +60,10 @@
 struct log_info *osmo_log_info;

 static struct log_context log_context;
-static void *tall_log_ctx = NULL;
+void *tall_log_ctx = NULL;
 LLIST_HEAD(osmo_log_target_list);

-#define LOGLEVEL_DEFS  6   /* Number of loglevels.*/
-
-static const struct value_string 

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   91s] #define HAVE_SYS_STAT_H 1
[   91s] #define HAVE_STDLIB_H 1
[   91s] #define HAVE_STRING_H 1
[   91s] #define HAVE_MEMORY_H 1
[   91s] #define HAVE_STRINGS_H 1
[   91s] #define HAVE_INTTYPES_H 1
[   91s] #define HAVE_STDINT_H 1
[   91s] #define HAVE_UNISTD_H 1
[   91s] #define HAVE_DLFCN_H 1
[   91s] #define LT_OBJDIR ".libs/"
[   91s] 
[   91s] configure: exit 1
[   91s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu 
--libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[   91s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[   91s] make[1]: *** [override_dh_auto_configure] Error 255
[   91s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   91s] debian/rules:45: recipe for target 'build' failed
[   91s] make: *** [build] Error 2
[   91s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   91s] 
[   91s] lamb51 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:45:50 UTC 2018.
[   91s] 
[   91s] ### VM INTERACTION START ###
[   94s] [   82.302037] sysrq: SysRq : Power Off
[   94s] [   82.307159] reboot: Power down
[   94s] ### VM INTERACTION END ###
[   94s] 
[   94s] lamb51 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:45:54 UTC 2018.
[   94s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  152s] #define HAVE_SYS_STAT_H 1
[  152s] #define HAVE_STDLIB_H 1
[  152s] #define HAVE_STRING_H 1
[  152s] #define HAVE_MEMORY_H 1
[  152s] #define HAVE_STRINGS_H 1
[  152s] #define HAVE_INTTYPES_H 1
[  152s] #define HAVE_STDINT_H 1
[  152s] #define HAVE_UNISTD_H 1
[  152s] #define HAVE_DLFCN_H 1
[  152s] #define LT_OBJDIR ".libs/"
[  152s] 
[  152s] configure: exit 1
[  152s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu 
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  152s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  152s] make[1]: *** [override_dh_auto_configure] Error 2
[  152s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  152s] debian/rules:45: recipe for target 'build' failed
[  152s] make: *** [build] Error 2
[  152s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  152s] 
[  152s] cloud119 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:45:08 UTC 2018.
[  152s] 
[  152s] ### VM INTERACTION START ###
[  155s] [  115.811625] sysrq: SysRq : Power Off
[  155s] [  115.828436] reboot: Power down
[  156s] ### VM INTERACTION END ###
[  156s] 
[  156s] cloud119 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:45:13 UTC 2018.
[  156s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  136s] #define HAVE_SYS_STAT_H 1
[  136s] #define HAVE_STDLIB_H 1
[  136s] #define HAVE_STRING_H 1
[  136s] #define HAVE_MEMORY_H 1
[  136s] #define HAVE_STRINGS_H 1
[  136s] #define HAVE_INTTYPES_H 1
[  136s] #define HAVE_STDINT_H 1
[  136s] #define HAVE_UNISTD_H 1
[  136s] #define HAVE_DLFCN_H 1
[  136s] #define LT_OBJDIR ".libs/"
[  136s] 
[  136s] configure: exit 1
[  136s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu 
--libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  136s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  136s] make[1]: *** [override_dh_auto_configure] Error 2
[  136s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  136s] debian/rules:45: recipe for target 'build' failed
[  136s] make: *** [build] Error 2
[  136s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  136s] 
[  136s] cloud105 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:43:39 UTC 2018.
[  136s] 
[  136s] ### VM INTERACTION START ###
[  139s] [   98.499591] sysrq: SysRq : Power Off
[  139s] [   98.543224] reboot: Power down
[  141s] ### VM INTERACTION END ###
[  141s] 
[  141s] cloud105 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:43:45 UTC 2018.
[  141s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in openbsc[master]: nat: return -EBADF in read wqueue cb on fd closed

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10937


Change subject: nat: return -EBADF in read wqueue cb on fd closed
..

nat: return -EBADF in read wqueue cb on fd closed

bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd
bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd..

Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/37/10937/1

diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 8cc0f2d..c8a9e74 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -864,7 +864,7 @@
msc_con->name, ret);

bsc_msc_lost(msc_con);
-   return -1;
+   return -EBADF;
}

LOGP(DNAT, LOGL_DEBUG,

--
To view, visit https://gerrit.osmocom.org/10937
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
Gerrit-Change-Number: 10937
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_9.0/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   75s] #define HAVE_SYS_STAT_H 1
[   75s] #define HAVE_STDLIB_H 1
[   75s] #define HAVE_STRING_H 1
[   75s] #define HAVE_MEMORY_H 1
[   75s] #define HAVE_STRINGS_H 1
[   75s] #define HAVE_INTTYPES_H 1
[   75s] #define HAVE_STDINT_H 1
[   75s] #define HAVE_UNISTD_H 1
[   75s] #define HAVE_DLFCN_H 1
[   75s] #define LT_OBJDIR ".libs/"
[   75s] 
[   75s] configure: exit 1
[   75s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu 
--libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[   75s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[   75s] make[1]: *** [override_dh_auto_configure] Error 2
[   75s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   75s] debian/rules:45: recipe for target 'build' failed
[   75s] make: *** [build] Error 2
[   75s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   75s] 
[   75s] lamb15 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:41:07 UTC 2018.
[   75s] 
[   75s] ### VM INTERACTION START ###
[   78s] [   66.897077] sysrq: SysRq : Power Off
[   78s] [   66.908940] reboot: Power down
[   78s] ### VM INTERACTION END ###
[   78s] 
[   78s] lamb15 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:41:10 UTC 2018.
[   78s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   96s] #define HAVE_SYS_STAT_H 1
[   96s] #define HAVE_STDLIB_H 1
[   96s] #define HAVE_STRING_H 1
[   96s] #define HAVE_MEMORY_H 1
[   96s] #define HAVE_STRINGS_H 1
[   96s] #define HAVE_INTTYPES_H 1
[   96s] #define HAVE_STDINT_H 1
[   96s] #define HAVE_UNISTD_H 1
[   96s] #define HAVE_DLFCN_H 1
[   96s] #define LT_OBJDIR ".libs/"
[   96s] 
[   96s] configure: exit 1
[   96s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--libdir=${prefix}/lib/x86_64-linux-gnu 
--libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[   96s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[   96s] make[1]: *** [override_dh_auto_configure] Error 255
[   96s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   96s] debian/rules:45: recipe for target 'build' failed
[   96s] make: *** [build] Error 2
[   96s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   96s] 
[   96s] lamb62 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:38:59 UTC 2018.
[   96s] 
[   96s] ### VM INTERACTION START ###
[   97s] Powering off.
[   97s] [   84.312409] reboot: Power down
[   97s] ### VM INTERACTION END ###
[   97s] 
[   97s] lamb62 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:39:01 UTC 2018.
[   97s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  192s] No package 'libpcsclite' found
[  192s] simtrace2-remsim.o: In function `main':
[  192s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  192s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  192s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  192s] apdu_dispatch.o: In function `apdu_segment_in':
[  192s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  192s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  192s] collect2: error: ld returned 1 exit status
[  192s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  192s] make[2]: *** [simtrace2-remsim] Error 1
[  192s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  192s] Makefile:20: recipe for target 'utils' failed
[  192s] make[1]: *** [utils] Error 2
[  192s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  192s] dh_auto_build: make -j1 returned exit code 2
[  192s] debian/rules:4: recipe for target 'build' failed
[  192s] make: *** [build] Error 2
[  192s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  192s] 
[  192s] lamb56 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:36:40 UTC 2018.
[  192s] 
[  192s] ### VM INTERACTION START ###
[  195s] [  182.640718] sysrq: SysRq : Power Off
[  195s] [  182.646091] reboot: Power down
[  195s] ### VM INTERACTION END ###
[  195s] 
[  195s] lamb56 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:36:43 UTC 2018.
[  195s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_17.10/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[   64s] #define HAVE_SYS_STAT_H 1
[   64s] #define HAVE_STDLIB_H 1
[   64s] #define HAVE_STRING_H 1
[   64s] #define HAVE_MEMORY_H 1
[   64s] #define HAVE_STRINGS_H 1
[   64s] #define HAVE_INTTYPES_H 1
[   64s] #define HAVE_STDINT_H 1
[   64s] #define HAVE_UNISTD_H 1
[   64s] #define HAVE_DLFCN_H 1
[   64s] #define LT_OBJDIR ".libs/"
[   64s] 
[   64s] configure: exit 1
[   64s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu 
--libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[   64s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[   64s] make[1]: *** [override_dh_auto_configure] Error 2
[   64s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   64s] debian/rules:45: recipe for target 'build' failed
[   64s] make: *** [build] Error 2
[   64s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   64s] 
[   64s] sheep82 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:36:19 UTC 2018.
[   64s] 
[   64s] ### VM INTERACTION START ###
[   67s] [   60.056160] sysrq: SysRq : Power Off
[   67s] [   60.062080] reboot: Power down
[   67s] ### VM INTERACTION END ###
[   67s] 
[   67s] sheep82 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:36:22 UTC 2018.
[   67s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  125s] #define HAVE_SYS_STAT_H 1
[  125s] #define HAVE_STDLIB_H 1
[  125s] #define HAVE_STRING_H 1
[  125s] #define HAVE_MEMORY_H 1
[  125s] #define HAVE_STRINGS_H 1
[  125s] #define HAVE_INTTYPES_H 1
[  125s] #define HAVE_STDINT_H 1
[  125s] #define HAVE_UNISTD_H 1
[  125s] #define HAVE_DLFCN_H 1
[  125s] #define LT_OBJDIR ".libs/"
[  125s] 
[  125s] configure: exit 1
[  125s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr 
--includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/i386-linux-gnu 
--libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  125s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  125s] make[1]: *** [override_dh_auto_configure] Error 255
[  125s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  125s] debian/rules:45: recipe for target 'build' failed
[  125s] make: *** [build] Error 2
[  125s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  125s] 
[  125s] cloud117 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:33:51 UTC 2018.
[  125s] 
[  125s] ### VM INTERACTION START ###
[  129s] [  104.462561] sysrq: SysRq : Power Off
[  129s] [  104.502560] reboot: Power down
[  130s] ### VM INTERACTION END ###
[  130s] 
[  130s] cloud117 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:33:56 UTC 2018.
[  130s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  229s] No package 'libpcsclite' found
[  229s] simtrace2-remsim.o: In function `main':
[  229s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  229s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  229s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  229s] apdu_dispatch.o: In function `apdu_segment_in':
[  229s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  229s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  229s] collect2: error: ld returned 1 exit status
[  229s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  229s] make[2]: *** [simtrace2-remsim] Error 1
[  229s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  229s] Makefile:20: recipe for target 'utils' failed
[  229s] make[1]: *** [utils] Error 2
[  229s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  229s] dh_auto_build: make -j1 returned exit code 2
[  229s] debian/rules:4: recipe for target 'build' failed
[  229s] make: *** [build] Error 2
[  229s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  229s] 
[  229s] cloud115 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:29:59 UTC 2018.
[  229s] 
[  229s] ### VM INTERACTION START ###
[  232s] [  180.599056] sysrq: SysRq : Power Off
[  232s] [  180.642425] reboot: Power down
[  233s] ### VM INTERACTION END ###
[  233s] 
[  233s] cloud115 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:30:03 UTC 2018.
[  233s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  526s] No package 'libpcsclite' found
[  526s] simtrace2-remsim.o: In function `main':
[  526s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  526s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  526s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  526s] apdu_dispatch.o: In function `apdu_segment_in':
[  526s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  526s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  526s] collect2: error: ld returned 1 exit status
[  526s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  526s] make[2]: *** [simtrace2-remsim] Error 1
[  526s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  526s] Makefile:20: recipe for target 'utils' failed
[  526s] make[1]: *** [utils] Error 2
[  526s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  526s] dh_auto_build: make -j1 returned exit code 2
[  526s] debian/rules:4: recipe for target 'build' failed
[  526s] make: *** [build] Error 2
[  526s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  526s] 
[  526s] lamb55 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:23:38 UTC 2018.
[  526s] 
[  526s] ### VM INTERACTION START ###
[  529s] [  510.097866] sysrq: SysRq : Power Off
[  529s] [  510.118185] reboot: Power down
[  529s] ### VM INTERACTION END ###
[  529s] 
[  529s] lamb55 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:23:42 UTC 2018.
[  529s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-sgsn in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_8.0/i586

Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-sgsn

Last lines of build log:
[  107s] #define HAVE_STDLIB_H 1
[  107s] #define HAVE_STRING_H 1
[  107s] #define HAVE_MEMORY_H 1
[  107s] #define HAVE_STRINGS_H 1
[  107s] #define HAVE_INTTYPES_H 1
[  107s] #define HAVE_STDINT_H 1
[  107s] #define HAVE_UNISTD_H 1
[  107s] #define HAVE_DLFCN_H 1
[  107s] #define LT_OBJDIR ".libs/"
[  107s] 
[  107s] configure: exit 1
[  107s] dh_auto_configure: ./configure -[   84.328168] serial8250: too much 
work for irq4
[  107s] -build=i586-linux-gnu --prefix=/usr --includedir=${prefix}/include 
--mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc 
--localstatedir=/var --libdir=${prefix}/lib/i386-linux-gnu 
--libexecdir=${prefix}/lib/i386-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking --enable-iu 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  107s] debian/rules:51: recipe for target 'override_dh_auto_configure' failed
[  107s] make[1]: *** [override_dh_auto_configure] Error 255
[  107s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  107s] debian/rules:45: recipe for target 'build' failed
[  107s] make: *** [build] Error 2
[  107s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  107s] 
[  107s] wildcard2 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:22:09 UTC 2018.
[  107s] 
[  107s] ### VM INTERACTION START ###
[  109s] Powering off.
[  109s] [   85.513711] reboot: Power down
[  112s] ### VM INTERACTION END ###
[  112s] 
[  112s] wildcard2 failed "build osmo-sgsn_1.3.0.45.f7198.dsc" at Thu Sep 13 
15:22:15 UTC 2018.
[  112s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  136s] No package 'libpcsclite' found
[  136s] simtrace2-remsim.o: In function `main':
[  136s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  136s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  136s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  136s] apdu_dispatch.o: In function `apdu_segment_in':
[  136s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  136s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  136s] collect2: error: ld returned 1 exit status
[  136s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  136s] make[2]: *** [simtrace2-remsim] Error 1
[  136s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  136s] Makefile:20: recipe for target 'utils' failed
[  136s] make[1]: *** [utils] Error 2
[  136s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  136s] dh_auto_build: make -j1 returned exit code 2
[  136s] debian/rules:4: recipe for target 'build' failed
[  136s] make: *** [build] Error 2
[  136s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  136s] 
[  136s] lamb20 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:21:25 UTC 2018.
[  136s] 
[  136s] ### VM INTERACTION START ###
[  139s] [  129.956439] sysrq: SysRq : Power Off
[  139s] [  129.960821] reboot: Power down
[  139s] ### VM INTERACTION END ###
[  139s] 
[  139s] lamb20 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:21:28 UTC 2018.
[  139s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/i586

Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  210s] No package 'libpcsclite' found
[  210s] simtrace2-remsim.o: In function `main':
[  210s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  210s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  210s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  210s] apdu_dispatch.o: In function `apdu_segment_in':
[  210s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  210s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  210s] collect2: error: ld returned 1 exit status
[  210s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  210s] make[2]: *** [simtrace2-remsim] Error 1
[  210s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  210s] Makefile:20: recipe for target 'utils' failed
[  210s] make[1]: *** [utils] Error 2
[  210s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  210s] dh_auto_build: make -j1 returned exit code 2
[  210s] debian/rules:4: recipe for target 'build' failed
[  210s] make: *** [build] Error 2
[  210s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  210s] 
[  210s] lamb28 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:18:59 UTC 2018.
[  210s] 
[  210s] ### VM INTERACTION START ###
[  213s] [  189.719049] sysrq: SysRq : Power Off
[  213s] [  189.736263] reboot: Power down
[  213s] ### VM INTERACTION END ###
[  213s] 
[  213s] lamb28 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:19:03 UTC 2018.
[  213s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  213s] No package 'libpcsclite' found
[  213s] simtrace2-remsim.o: In function `main':
[  213s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  213s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  213s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  213s] apdu_dispatch.o: In function `apdu_segment_in':
[  213s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  213s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  213s] collect2: error: ld returned 1 exit status
[  213s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  213s] make[2]: *** [simtrace2-remsim] Error 1
[  213s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  213s] Makefile:20: recipe for target 'utils' failed
[  213s] make[1]: *** [utils] Error 2
[  213s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  213s] dh_auto_build: make -j1 returned exit code 2
[  213s] debian/rules:4: recipe for target 'build' failed
[  213s] make: *** [build] Error 2
[  213s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  213s] 
[  213s] lamb28 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:18:54 UTC 2018.
[  213s] 
[  213s] ### VM INTERACTION START ###
[  217s] [  194.218806] sysrq: SysRq : Power Off
[  217s] [  194.229411] reboot: Power down
[  217s] ### VM INTERACTION END ###
[  217s] 
[  217s] lamb28 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:18:59 UTC 2018.
[  217s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  110s] No package 'libpcsclite' found
[  110s] simtrace2-remsim.o: In function `main':
[  110s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  110s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  110s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  110s] apdu_dispatch.o: In function `apdu_segment_in':
[  110s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  110s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  110s] collect2: error: ld returned 1 exit status
[  110s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  110s] make[2]: *** [simtrace2-remsim] Error 1
[  110s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  110s] Makefile:20: recipe for target 'utils' failed
[  110s] make[1]: *** [utils] Error 2
[  110s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  110s] dh_auto_build: make -j1 returned exit code 2
[  110s] debian/rules:4: recipe for target 'build' failed
[  110s] make: *** [build] Error 2
[  110s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  110s] 
[  110s] sheep83 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:16:41 UTC 2018.
[  110s] 
[  110s] ### VM INTERACTION START ###
[  114s] [  106.586866] sysrq: SysRq : Power Off
[  114s] [  106.593185] reboot: Power down
[  114s] ### VM INTERACTION END ###
[  114s] 
[  114s] sheep83 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:16:44 UTC 2018.
[  114s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Jenkins build is back to normal : master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #245

[jenkins]

See 

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  111s] No package 'libpcsclite' found
[  111s] simtrace2-remsim.o: In function `main':
[  111s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:664: undefined 
reference to `osim_uicc_sim_cic_profile'
[  111s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  111s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  111s] apdu_dispatch.o: In function `apdu_segment_in':
[  111s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_uicc_sim_cic_profile'
[  111s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  111s] collect2: error: ld returned 1 exit status
[  111s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  111s] make[2]: *** [simtrace2-remsim] Error 1
[  111s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  111s] Makefile:20: recipe for target 'utils' failed
[  111s] make[1]: *** [utils] Error 2
[  111s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  111s] dh_auto_build: make -j1 returned exit code 2
[  111s] debian/rules:4: recipe for target 'build' failed
[  111s] make: *** [build] Error 2
[  111s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  111s] 
[  111s] build70 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:12:39 UTC 2018.
[  111s] 
[  111s] ### VM INTERACTION START ###
[  114s] [  102.278340] sysrq: SysRq : Power Off
[  114s] [  102.280030] reboot: Power down
[  114s] ### VM INTERACTION END ###
[  114s] 
[  114s] build70 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
15:12:43 UTC 2018.
[  114s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l

Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  299s] No package 'libpcsclite' found
[  299s] simtrace2-remsim.o: In function `main':
[  299s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:689: undefined 
reference to `osim_reader_open'
[  299s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:695: undefined 
reference to `osim_card_open'
[  299s] /usr/src/packages/BUILD/host/simtrace2-remsim.c:772: undefined 
reference to `osim_uicc_sim_cic_profile'
[  299s] apdu_dispatch.o: In function `apdu_segment_in':
[  299s] /usr/src/packages/BUILD/host/apdu_dispatch.c:84: undefined reference 
to `osim_determine_apdu_case'
[  299s] /usr/src/packages/BUILD/host/apdu_dispatch.c:173: undefined reference 
to `osim_uicc_sim_cic_profile'
[  299s] collect2: error: ld returned 1 exit status
[  299s] Makefile:9: recipe for target 'simtrace2-remsim' failed
[  299s] make[2]: *** [simtrace2-remsim] Error 1
[  299s] make[2]: Leaving directory '/usr/src/packages/BUILD/host'
[  299s] Makefile:20: recipe for target 'utils' failed
[  299s] make[1]: *** [utils] Error 2
[  299s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  299s] dh_auto_build: make -j1 returned exit code 2
[  299s] debian/rules:4: recipe for target 'build' failed
[  299s] make: *** [build] Error 2
[  299s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  299s] 
[  299s] armbuild04 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
14:55:53 UTC 2018.
[  299s] 
[  299s] ### VM INTERACTION START ###
[  302s] [  270.804503] SysRq : Power Off
[  302s] [  270.807379] reboot: Power down
[  302s] ### VM INTERACTION END ###
[  302s] 
[  302s] armbuild04 failed "build simtrace2_0.5.1.15.5b5d.dsc" at Thu Sep 13 
14:55:56 UTC 2018.
[  302s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in openbsc[master]: nat: Remove misleading comment

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10936 )

Change subject: nat: Remove misleading comment
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10936/1/openbsc/src/osmo-bsc_nat/bsc_nat.c
File openbsc/src/osmo-bsc_nat/bsc_nat.c:

https://gerrit.osmocom.org/#/c/10936/1/openbsc/src/osmo-bsc_nat/bsc_nat.c@1356
PS1, Line 1356: send_pong(bsc);
it's being sent here. Am I missing something?



--
To view, visit https://gerrit.osmocom.org/10936
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ca95d46f4ace1da4025d12302422dbfa578354
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:48:05 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in openbsc[master]: nat: Remove misleading comment

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10936


Change subject: nat: Remove misleading comment
..

nat: Remove misleading comment

PONG is being sent a as an answer to PING a few lines above in same
function.

Change-Id: I88ca95d46f4ace1da4025d12302422dbfa578354
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/36/10936/1

diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 0e69528..8cc0f2d 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1369,7 +1369,6 @@
return bsc_nat_handle_ctrlif_msg(bsc, msg);
}

-   /* FIXME: Currently no PONG is sent to the BSC */
/* FIXME: Currently no ID ACK is sent to the BSC */
forward_sccp_to_msc(bsc, msg, _closed);
return fd_closed ? -EBADF : 0;

--
To view, visit https://gerrit.osmocom.org/10936
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88ca95d46f4ace1da4025d12302422dbfa578354
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Build failed in Jenkins: master-osmo-sip-connector » a1=default,a2=default,a3=default,osmocom-master-debian9 #697

[jenkins]

See 


--
[...truncated 9.91 KB...]
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for pkg-config... /usr/bin/pkg-config
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.20... yes
checking for ANSI C header files... (cached) yes
checking execinfo.h usability... yes
checking execinfo.h presence... yes
checking for execinfo.h... yes
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking sys/timerfd.h usability... yes
checking sys/timerfd.h presence... yes
checking for sys/timerfd.h... yes
checking syslog.h usability... yes
checking syslog.h presence... yes
checking for syslog.h... yes
checking ctype.h usability... yes
checking ctype.h presence... yes
checking for ctype.h... yes
checking netinet/tcp.h usability... yes
checking netinet/tcp.h presence... yes
checking for netinet/tcp.h... yes
checking for size_t... yes
checking for working alloca.h... yes
checking for alloca... yes
checking for library containing dlopen... -ldl
checking for library containing dlsym... -ldl
checking for backtrace in -lexecinfo... no
checking for doxygen... /usr/bin/doxygen
checking whether SYS_getrandom is declared... yes
checking if gcc supports -fvisibility=hidden... yes
checking for clock_gettime... yes
checking for localtime_r... yes
checking whether struct tm has tm_gmtoff member... yes
checking for TALLOC... yes
checking for PCSC... yes
checking for LIBGNUTLS... yes
checking whether to enable VTY/CTRL tests... no
checking whether C compiler accepts -mavx2... yes
checking whether C compiler accepts -mssse3... yes
checking whether C compiler accepts -msse4.1... yes
checking whether gcc has __builtin_cpu_supports built-in... yes
CFLAGS="-g -O2 -DBUILDING_LIBOSMOCORE -Wall"
CPPFLAGS=" -DBUILDING_LIBOSMOCORE -Wall"
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating libosmocore.pc
config.status: creating libosmocodec.pc
config.status: creating libosmocoding.pc
config.status: creating libosmovty.pc
config.status: creating libosmogsm.pc
config.status: creating libosmogb.pc
config.status: creating libosmoctrl.pc
config.status: creating libosmosim.pc
config.status: creating include/Makefile
config.status: creating src/Makefile
config.status: creating src/vty/Makefile
config.status: creating src/codec/Makefile
config.status: creating src/coding/Makefile
config.status: creating src/sim/Makefile
config.status: creating src/gsm/Makefile
config.status: creating src/gb/Makefile
config.status: creating src/ctrl/Makefile
config.status: creating src/pseudotalloc/Makefile
config.status: creating tests/Makefile
config.status: creating tests/atlocal
config.status: creating utils/Makefile
config.status: creating Doxyfile.core
config.status: creating Doxyfile.gsm
config.status: creating Doxyfile.vty
config.status: creating Doxyfile.codec
config.status: creating Doxyfile.coding
config.status: creating Doxyfile.gb
config.status: creating Doxyfile.ctrl
config.status: creating Makefile
config.status: creating config.h
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
configure: WARNING: unrecognized options: --with-systemdsystemunitdir
+ make -j 8 install
echo 0.12.0.50-2c79 > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory 
'
Making install in include
make[2]: Entering directory 
'
  GEN  osmocom/gsm/gsm0503.h
Generating header file...
Generate 'xcch' declaration
Generate 'rach' declaration
Generate 'rach_ext' declaration
Generate 'sch' declaration
Generate 'cs2' declaration
Generate 'cs3' declaration
Generate 'cs2_np' declaration
Generate 'cs3_np' declaration
Generate 

Change in openbsc[master]: nat: Remove misleading comment

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/10935 )

Change subject: nat: Remove misleading comment
..

nat: Remove misleading comment

Code is already doing stuff with the connection (fd).

Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/35/10935/2
--
To view, visit https://gerrit.osmocom.org/10935
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
Gerrit-Change-Number: 10935
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-CC: Jenkins Builder (102)

Change in openbsc[master]: nat: Remove misleading comment

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10935


Change subject: nat: Remove misleading comment
..

nat: Remove misleading comment

Code is already doing stuff with the connection (fd).

Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/35/10935/1

diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 0c91d04..7463f02 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1423,7 +1423,6 @@
if (rc != 0)
LOGP(DNAT, LOGL_ERROR, "Failed to set IP_TOS: %s\n", 
strerror(errno));

-   /* todo... do something with the connection */
/* todo... use GNUtls to see if we want to trust this as a BTS */

/*

--
To view, visit https://gerrit.osmocom.org/10935
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
Gerrit-Change-Number: 10935
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-trx[master]: cosmetic: Use proper whitespace in several for loops

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10856 )

Change subject: cosmetic: Use proper whitespace in several for loops
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10856
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82bdeb8a3fa38f3d125e8cbccc3eddbf2b8d8f58
Gerrit-Change-Number: 10856
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:27:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: cosmetic: Use proper whitespace in several for loops

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10856 )

Change subject: cosmetic: Use proper whitespace in several for loops
..

cosmetic: Use proper whitespace in several for loops

Change-Id: I82bdeb8a3fa38f3d125e8cbccc3eddbf2b8d8f58
---
M Transceiver52M/device/usrp1/USRPDevice.cpp
M tests/Transceiver52M/convolve_test.c
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/usrp1/USRPDevice.cpp 
b/Transceiver52M/device/usrp1/USRPDevice.cpp
index 758ee55..5d19514 100644
--- a/Transceiver52M/device/usrp1/USRPDevice.cpp
+++ b/Transceiver52M/device/usrp1/USRPDevice.cpp
@@ -398,7 +398,7 @@

 // read USRP packets, parse and save A/D data as needed
 readLen = m_uRx->read((void *)readBuf,readLen,overrun);
-for(int pktNum = 0; pktNum < (readLen/512); pktNum++) {
+for (int pktNum = 0; pktNum < (readLen/512); pktNum++) {
   // tmpBuf points to start of a USB packet
   uint32_t* tmpBuf = (uint32_t *) (readBuf+pktNum*512/4);
   TIMESTAMP pktTimestamp = usrp_to_host_u32(tmpBuf[1]);
diff --git a/tests/Transceiver52M/convolve_test.c 
b/tests/Transceiver52M/convolve_test.c
index 88624af..54bc7a1 100644
--- a/tests/Transceiver52M/convolve_test.c
+++ b/tests/Transceiver52M/convolve_test.c
@@ -18,7 +18,7 @@
 void gen_floats(float *vect, int len)
 {
int i;
-   for(i=0;ihttps://gerrit.osmocom.org/10856
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I82bdeb8a3fa38f3d125e8cbccc3eddbf2b8d8f58
Gerrit-Change-Number: 10856
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: gsm0808: implement BSSMAP Classmark Request

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10911 )

Change subject: gsm0808: implement BSSMAP Classmark Request
..

gsm0808: implement BSSMAP Classmark Request

Related: OS#3043
Change-Id: I4a2e1d3923e33912579c4180aa1ff8e8f5abb7e7
---
M include/osmocom/gsm/gsm0808.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
3 files changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 5ae0af8..f4fc7c4 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -51,6 +51,7 @@
   const uint8_t *cipher_response_mode);
 struct msgb *gsm0808_create_cipher_complete(struct msgb *layer3, uint8_t 
alg_id);
 struct msgb *gsm0808_create_cipher_reject(uint8_t cause);
+struct msgb *gsm0808_create_classmark_request();
 struct msgb *gsm0808_create_classmark_update(const uint8_t *cm2, uint8_t 
cm2_len,
 const uint8_t *cm3, uint8_t 
cm3_len);
 struct msgb *gsm0808_create_sapi_reject(uint8_t link_id);
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index e3b10d0..9a9f70e 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -341,6 +341,19 @@
return msg;
 }

+/*! Create BSSMAP Classmark Request message
+ *  \returns callee-allocated msgb with BSSMAP Classmark Request message */
+struct msgb *gsm0808_create_classmark_request()
+{
+   struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, 
BSSMAP_MSG_HEADROOM,
+  "classmark-request");
+   if (!msg)
+   return NULL;
+
+   msgb_v_put(msg, BSS_MAP_MSG_CLASSMARK_RQST);
+   msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, 
msgb_length(msg));
+   return msg;
+}

 /*! Create BSSMAP Classmark Update message
  *  \param[in] cm2 Classmark 2
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 60d6ed8..0c40c88 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -156,6 +156,7 @@
 gsm0808_create_cipher;
 gsm0808_create_cipher_complete;
 gsm0808_create_cipher_reject;
+gsm0808_create_classmark_request;
 gsm0808_create_classmark_update;
 gsm0808_create_clear_command;
 gsm0808_create_clear_complete;

--
To view, visit https://gerrit.osmocom.org/10911
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a2e1d3923e33912579c4180aa1ff8e8f5abb7e7
Gerrit-Change-Number: 10911
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bts[master]: measurement: remove missed interval end detection

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10814 )

Change subject: measurement: remove missed interval end detection
..

measurement: remove missed interval end detection

The function is_meas_overdue() was introduced to allow
lchan_meas_process_measurement() to detect when the end of a measurement
interval has been missed. Interval ends may be missed when the SACCH
block of the related measurement interval gets lost. This is due to the
fact that the SACCH block is used as a trigger to start the measurement
result computation.

The idea behind is_meas_overdue() was to check the frame number of the
current measurement against the frame number of the previous measurement
in order to see if there was a measurement for SACCH in between or not.
Unfortunately SACCH and TCH Voice data is not necessarly processed in
order by each phy. Depending on the phy there may be a jitter between
the timing of SACCH and TCH Voice. Depending on the phy this jitter may
be enough to mess up the timing so that we see a SACCH block earlier
than expected. So we can not use the current frame number of TCH Voice
measurements to check for missed SACCH blocks.

Change-Id: Idfdbf64c1f965f35c12559b3995e2b746c74ee9e
Related: OS#3502
Related: OS#2975
---
M include/osmo-bts/measurement.h
M src/common/measurement.c
M tests/meas/meas_test.c
M tests/meas/meas_test.ok
4 files changed, 2 insertions(+), 733 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/measurement.h b/include/osmo-bts/measurement.h
index b4fc35b..a2367c8 100644
--- a/include/osmo-bts/measurement.h
+++ b/include/osmo-bts/measurement.h
@@ -16,6 +16,4 @@

 int is_meas_complete(struct gsm_lchan *lchan, uint32_t fn);

-bool is_meas_overdue(struct gsm_lchan *lchan, uint32_t *fn_missed_end, 
uint32_t fn);
-
 #endif
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 8f0470a..8d1babd 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -240,32 +240,6 @@
return 0;
 }

-/* Same as above, but the inverse function */
-static uint8_t translate_tch_meas_rep_fn104_inv(uint8_t fn_mod)
-{
-   switch (fn_mod) {
-   case 103:
-   return 25;
-   case 12:
-   return 38;
-   case 25:
-   return 51;
-   case 38:
-   return 64;
-   case 51:
-   return 77;
-   case 64:
-   return 90;
-   case 77:
-   return 103;
-   case 90:
-   return 12;
-   }
-
-   /* Invalid / not of interest */
-   return 0;
-}
-
 /* determine if a measurement period ends at the given frame number
  * (this function is only used internally, it is public to call it from
  * unit-tests) */
@@ -322,99 +296,6 @@
return rc;
 }

-/* Check if a measurement period is overdue. This situation may occur when the
- * SACCH frame that closes the measurement interval was not received. Then the
- * end of the measurement will not be detected. Using this function we can
- * detect if we missed a measurement period end and we also find the frame
- * number of the lost SACCH frame. (this function is only used internally,
- * it is public to call it from unit-tests) */
-bool is_meas_overdue(struct gsm_lchan *lchan, uint32_t *fn_missed_end, 
uint32_t fn)
-{
-   uint32_t fn_mod;
-   uint32_t last_fn_mod;
-   uint32_t fn_rounded;
-   uint8_t interval_end;
-   uint8_t modulus;
-   const uint8_t *tbl;
-   enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts);
-
-   /* On the very first measurement we will not be able to do this check
-* as we do not have a reference yet. So we have to assume that we
-* did not miss the interval end yet. */
-   if (lchan->meas.last_fn == LCHAN_FN_DUMMY)
-   return false;
-
-   /* Determine the interval ending and the modulus to calculate with */
-   switch (pchan) {
-   case GSM_PCHAN_TCH_F:
-   modulus = 104;
-   interval_end = tchf_meas_rep_fn104_by_ts[lchan->ts->nr];
-   interval_end = translate_tch_meas_rep_fn104_inv(interval_end);
-   break;
-   case GSM_PCHAN_TCH_H:
-   modulus = 104;
-   if (lchan->nr == 0)
-   tbl = tchh0_meas_rep_fn104_by_ts;
-   else
-   tbl = tchh1_meas_rep_fn104_by_ts;
-   interval_end = tbl[lchan->ts->nr];
-   interval_end = translate_tch_meas_rep_fn104_inv(interval_end);
-   break;
-   case GSM_PCHAN_SDCCH8_SACCH8C:
-   case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
-   modulus = 102;
-   interval_end = sdcch8_meas_rep_fn102_by_ss[lchan->nr];
-   break;
-   case 

Change in osmo-bts[master]: measurement: fix unit-test test_lchan_meas_process_measurement

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10815 )

Change subject: measurement: fix unit-test test_lchan_meas_process_measurement
..

measurement: fix unit-test test_lchan_meas_process_measurement

The unit test that tests lchan_meas_process_measurement() only inputs
test data to lchan_meas_process_measurement() but it is not checked if
the interval end could be detected or not.

- Add a return code to lchan_meas_process_measurement()
- Ensure that the return code is checked in the unit-test

Change-Id: I9e00ce683e8c44528804f65181dbfed9e85e3aed
Related: OS#2975
---
M include/osmo-bts/measurement.h
M src/common/measurement.c
M tests/meas/meas_test.c
3 files changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/measurement.h b/include/osmo-bts/measurement.h
index a2367c8..4f04ffa 100644
--- a/include/osmo-bts/measurement.h
+++ b/include/osmo-bts/measurement.h
@@ -8,7 +8,7 @@

 int lchan_meas_check_compute(struct gsm_lchan *lchan, uint32_t fn);

-void lchan_meas_process_measurement(struct gsm_lchan *lchan, struct 
bts_ul_meas *ulm, uint32_t fn);
+int lchan_meas_process_measurement(struct gsm_lchan *lchan, struct bts_ul_meas 
*ulm, uint32_t fn);

 void lchan_meas_reset(struct gsm_lchan *lchan);

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 8d1babd..33b1c11 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -706,10 +706,10 @@
  * l1sap.c every time a measurement indication is received. It collects the
  * measurement samples and automatically detects the end of the measurement
  * interval. */
-void lchan_meas_process_measurement(struct gsm_lchan *lchan, struct 
bts_ul_meas *ulm, uint32_t fn)
+int lchan_meas_process_measurement(struct gsm_lchan *lchan, struct bts_ul_meas 
*ulm, uint32_t fn)
 {
lchan_new_ul_meas(lchan, ulm, fn);
-   lchan_meas_check_compute(lchan, fn);
+   return lchan_meas_check_compute(lchan, fn);
 }

 /* Reset all measurement related struct members to their initial values. This
diff --git a/tests/meas/meas_test.c b/tests/meas/meas_test.c
index 8f50479..d4f3fe6 100644
--- a/tests/meas/meas_test.c
+++ b/tests/meas/meas_test.c
@@ -315,6 +315,7 @@
unsigned int fn = 0;
unsigned int fn104;
struct bts_ul_meas ulm;
+   int rc;

printf("\n\n");
printf("===\n");
@@ -347,7 +348,8 @@
if (dropouts == false || i % 4) {
if (ulm.is_sub == 1)
printf("(now adding SUB measurement sample 
%u)\n", fn);
-   lchan_meas_process_measurement(lchan, , fn);
+   rc = lchan_meas_process_measurement(lchan, , fn);
+   OSMO_ASSERT(rc == 0);
} else if (ulm.is_sub == 1)
printf("(leaving out SUB measurement sample for frame 
number %u)\n", fn);
else
@@ -363,7 +365,8 @@
if (fn % 104 == 39 && no_sacch == false) {
printf("(now adding SUB measurement sample for SACCH 
block at frame number %u)\n", fn);
ulm.is_sub = 1;
-   lchan_meas_process_measurement(lchan, , fn - 1);
+   rc = lchan_meas_process_measurement(lchan, , fn - 
1);
+   OSMO_ASSERT(rc);
} else if (fn % 104 == 39 && no_sacch == true)
printf("(leaving out SUB measurement sample for SACCH 
block at frame number %u)\n", fn);
}

--
To view, visit https://gerrit.osmocom.org/10815
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e00ce683e8c44528804f65181dbfed9e85e3aed
Gerrit-Change-Number: 10815
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bts[master]: cosmetic: fix typo in comment

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10908 )

Change subject: cosmetic: fix typo in comment
..

cosmetic: fix typo in comment

Change-Id: I6a1147e2a3858475c99c99ceb33d7d416f3cac6c
---
M src/common/measurement.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/measurement.c b/src/common/measurement.c
index 1e547c8..8f0470a 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -823,7 +823,7 @@

 /* Process a single uplink measurement sample. This function is called from
  * l1sap.c every time a measurement indication is received. It collects the
- * measurement samples and automatically detects the end oft the measurement
+ * measurement samples and automatically detects the end of the measurement
  * interval. */
 void lchan_meas_process_measurement(struct gsm_lchan *lchan, struct 
bts_ul_meas *ulm, uint32_t fn)
 {

--
To view, visit https://gerrit.osmocom.org/10908
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a1147e2a3858475c99c99ceb33d7d416f3cac6c
Gerrit-Change-Number: 10908
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bts[master]: measurement: remove missed interval end detection

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10814 )

Change subject: measurement: remove missed interval end detection
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10814
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfdbf64c1f965f35c12559b3995e2b746c74ee9e
Gerrit-Change-Number: 10814
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:27:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: cosmetic: fix typo in comment

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10908 )

Change subject: cosmetic: fix typo in comment
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10908
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a1147e2a3858475c99c99ceb33d7d416f3cac6c
Gerrit-Change-Number: 10908
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:26:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: cosmetic: Remove duplicate semicolon and whitespace

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10934


Change subject: cosmetic: Remove duplicate semicolon and whitespace
..

cosmetic: Remove duplicate semicolon and whitespace

Change-Id: Ib36b8937d1210488784ebae6917cb1b4c871c9d4
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/34/10934/1

diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 45f53bc..0c91d04 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1208,7 +1208,7 @@
}

/* hand data to a side channel */
-   if (bsc_ussd_check(con, parsed, msg) == 
1)
+   if (bsc_ussd_check(con, parsed, msg) == 
1)
con->con_local = 
NAT_CON_END_USSD;

/*
@@ -1703,7 +1703,7 @@
nat->msc_con->connection_loss = msc_connection_was_lost;
nat->msc_con->connected = msc_connection_connected;
nat->msc_con->write_queue.read_cb = ipaccess_msc_read_cb;
-   nat->msc_con->write_queue.write_cb = ipaccess_msc_write_cb;;
+   nat->msc_con->write_queue.write_cb = ipaccess_msc_write_cb;
nat->msc_con->write_queue.bfd.data = nat->msc_con;
bsc_msc_connect(nat->msc_con);


--
To view, visit https://gerrit.osmocom.org/10934
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib36b8937d1210488784ebae6917cb1b4c871c9d4
Gerrit-Change-Number: 10934
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-bts[master]: measurement: fix unit-test test_lchan_meas_process_measurement

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10815 )

Change subject: measurement: fix unit-test test_lchan_meas_process_measurement
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10815
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e00ce683e8c44528804f65181dbfed9e85e3aed
Gerrit-Change-Number: 10815
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:26:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: debian-repo-install-test: new binary package test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10862 )

Change subject: debian-repo-install-test: new binary package test
..


Patch Set 6: Code-Review+1

I would +2 it, but I'll give Neels the last word.


--
To view, visit https://gerrit.osmocom.org/10862
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f0a8b4f0ccd706cd1af98fe25accd6fd410e007
Gerrit-Change-Number: 10862
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:15:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: logging vty: write: check logging levels validity

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10887 )

Change subject: logging vty: write: check logging levels validity
..


Patch Set 2: Code-Review+2

this has just seen merge conflict resolution after abandoning the 
loglevel_strs_lower[] array. re-adding +2


--
To view, visit https://gerrit.osmocom.org/10887
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If683b1272ad2d5b402b91c52c496aa7975bc6315
Gerrit-Change-Number: 10887
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:13:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: debian-repo-install-test: new binary package test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10862 )

Change subject: debian-repo-install-test: new binary package test
..


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/testdata/repo-install-test.sh
File debian-repo-install-test/testdata/repo-install-test.sh:

https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/testdata/repo-install-test.sh@49
PS6, Line 49:   osmo-bsc --version
it's not really the task at hand, but in the past we also had the problem that 
some packages would generate UNKNOWN as version string.  So as we're calling 
all binaries with --version anyway, it might be a good idea to also check that 
there's no UNKNOWN string present in the output?

I guess the best would be to add the above new test as a new function, so the 
test output (ends up in jenkins console log) would clearly state what failed.

Feel free to come up with whatever way you think is best, and we should do this 
in a follow-up patch to this current patch.



--
To view, visit https://gerrit.osmocom.org/10862
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f0a8b4f0ccd706cd1af98fe25accd6fd410e007
Gerrit-Change-Number: 10862
Gerrit-PatchSet: 6
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:14:12 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: Keep track of all mobiles and copy them to unstarted later

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10684 )

Change subject: Keep track of all mobiles and copy them to unstarted later
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10684
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id72b7ce8821cf53ac0d5e4a141b9a2b66242e2a3
Gerrit-Change-Number: 10684
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:14:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: logging vty: add VTY transcript test

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10883 )

Change subject: logging vty: add VTY transcript test
..

logging vty: add VTY transcript test

I am setting out to refactor various details about logging. To show the effect,
I am first adding this new test to illustrate the exact effects on the various
osmo programs.

Add logging_vty_test.c as a standalone program that simply defines a few
logging categories and opens a telnet vty to play with.

Add logging_vty_test.vty, as an osmo_verify_transcript_vty.py test script.

Add --enable-external-tests to configure.ac, to enable running
logging_vty_test.vty during 'make check'.

Also allow running 'make vty-test' without the need to first configure with
--enable-external-tests (a flexibility I've missed many times over in the other
osmo source trees).

Add a Makefile.am stub for external CTRL tests, basically a copy-paste from
osmo-msc.git. I doubt that libosmocore will get python driven CTRL interface
testing any time soon, but if so we will know to not run it concurrently.

Change-Id: I948e832a33131f8eab98651d6010ceb0ccbc9a9c
---
M configure.ac
M tests/Makefile.am
A tests/logging/logging_vty_test.c
A tests/logging/logging_vty_test.vty
4 files changed, 530 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/configure.ac b/configure.ac
index dd5f15b..bc3358a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -296,6 +296,21 @@
CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
 fi

+AC_ARG_ENABLE([external_tests],
+   AC_HELP_STRING([--enable-external-tests],
+   [Include the VTY/CTRL tests in make check 
[default=no]]),
+   [enable_ext_tests="$enableval"],[enable_ext_tests="no"])
+if test "x$enable_ext_tests" = "xyes" ; then
+   AM_PATH_PYTHON
+   AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmo_verify_transcript_vty.py,yes)
+if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then
+   AC_MSG_ERROR([Please install 
git://osmocom.org/python/osmo-python-tests to run the VTY/CTRL tests.])
+   fi
+fi
+AC_MSG_CHECKING([whether to enable VTY/CTRL tests])
+AC_MSG_RESULT([$enable_ext_tests])
+AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes")
+
 CFLAGS="$CFLAGS -DBUILDING_LIBOSMOCORE -Wall"
 CPPFLAGS="$CPPFLAGS -DBUILDING_LIBOSMOCORE -Wall"

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 5d07695..18d4bb4 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -24,7 +24,9 @@
 abis/abis_test endian/endian_test sercomm/sercomm_test \
 prbs/prbs_test gsm23003/gsm23003_test  \
 codec/codec_ecu_fr_test timer/clk_override_test\
-oap/oap_client_test
+oap/oap_client_test\
+logging/logging_vty_test   \
+$(NULL)

 if ENABLE_MSGFILE
 check_PROGRAMS += msgfile/msgfile_test
@@ -148,6 +150,9 @@

 logging_logging_test_SOURCES = logging/logging_test.c

+logging_logging_vty_test_SOURCES = logging/logging_vty_test.c
+logging_logging_vty_test_LDADD = $(LDADD) $(top_builddir)/src/vty/libosmovty.la
+
 fr_fr_test_SOURCES = fr/fr_test.c
 fr_fr_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
   $(top_builddir)/src/vty/libosmovty.la \
@@ -280,6 +285,7 @@
 check-local: atconfig $(TESTSUITE)
cat /proc/cpuinfo
$(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)
+   $(MAKE) $(AM_MAKEFLAGS) ext-tests

 installcheck-local: atconfig $(TESTSUITE)
$(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \
@@ -298,3 +304,25 @@
 conv/gsm0503_test_vectors.c: $(top_srcdir)/utils/conv_gen.py 
$(top_srcdir)/utils/conv_codes_gsm.py
$(AM_V_GEN)python $(top_srcdir)/utils/conv_gen.py gen_vectors gsm \
--target-path $(builddir)/conv
+
+if ENABLE_EXT_TESTS
+ext-tests:
+# don't run vty and ctrl tests concurrently so that the ports don't conflict
+   $(MAKE) vty-test
+   $(MAKE) ctrl-test
+else
+ext-tests:
+   echo "Not running python-based external tests (determined at 
configure-time)"
+endif
+
+# To update the VTY script from current application behavior,
+# pass -u to osmo_verify_transcript_vty.py by doing:
+#   make vty-test U=-u
+vty-test:
+   osmo_verify_transcript_vty.py -v \
+   -p 42042 \
+   -r "$(top_builddir)/tests/logging/logging_vty_test" \
+   $(U) $(srcdir)/logging/*.vty
+
+ctrl-test:
+   echo "No CTRL tests exist currently"
diff --git a/tests/logging/logging_vty_test.c b/tests/logging/logging_vty_test.c
new file mode 100644
index 000..806a460
--- /dev/null
+++ b/tests/logging/logging_vty_test.c
@@ -0,0 +1,296 @@
+/* test program 

Change in libosmocore[master]: logging: define lower-case loglevel value_string[]

[Neels Hofmeyr]

Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/10886 )

Change subject: logging: define lower-case loglevel value_string[]
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/10886
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie55d732281bdf74324e1dd7f8a2ba91d11409851
Gerrit-Change-Number: 10886
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 

Change in libosmocore[master]: logging vty: write: check logging levels validity

[Neels Hofmeyr]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10887

to look at the new patch set (#2).

Change subject: logging vty: write: check logging levels validity
..

logging vty: write: check logging levels validity

Change-Id: If683b1272ad2d5b402b91c52c496aa7975bc6315
---
M include/osmocom/core/logging_internal.h
M src/logging.c
M src/vty/logging_vty.c
3 files changed, 25 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/10887/2
--
To view, visit https://gerrit.osmocom.org/10887
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If683b1272ad2d5b402b91c52c496aa7975bc6315
Gerrit-Change-Number: 10887
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: fix tests linking: don't use system installed libs

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/5844 )

Change subject: fix tests linking: don't use system installed libs
..

fix tests linking: don't use system installed libs

Do not link against the system-wide installed libosmo* libs when building the
regression test programs. Always use the locally built ones.

Linking some libosmo libraries causes libtool to pull in other libosmo libs
even though they were not explicitly named. For example, ctrl_test explicitly
links libosmoctrl, but this also has dependencies to libosmovty and libosmogsm:

  ldd src/ctrl/.libs/libosmoctrl.so | grep osmo
libosmocore.so.11 => /usr/local/lib/libosmocore.so.11 (0x7f26c26d4000)
libosmogsm.so.10 => /usr/local/lib/libosmogsm.so.10 (0x7f26c22bb000)
libosmovty.so.4 => /usr/local/lib/libosmovty.so.4 (0x7f26c2171000)

If we omit explicit LDADD of these dependencies in the Makefile.am, libtool
will take the first canonical place to find them, which may just be the already
installed older versions of the same libs, which may or may not be compatible
with the current build. In any case, it is never intended to link installed
libs.

All library dependencies are listed by this quick script:

  cd libosmocore
  for l in $(find . -name "*.so") ; do echo; echo "$l"; ldd $l | grep libosmo; 
done

  ./.libs/libosmocore.so

  ./coding/.libs/libosmocoding.so
libosmocore.so.11 => /usr/local/lib/libosmocore.so.11 (0x7f25fc3c2000)
libosmogsm.so.10 => /usr/local/lib/libosmogsm.so.10 (0x7f25fbfa9000)
libosmocodec.so.0 => /usr/local/lib/libosmocodec.so.0 (0x7f25fbf9b000)

  ./codec/.libs/libosmocodec.so
libosmocore.so.11 => /usr/local/lib/libosmocore.so.11 (0x7fb4c900d000)

  ./ctrl/.libs/libosmoctrl.so
libosmocore.so.11 => /usr/local/lib/libosmocore.so.11 (0x7f5df5129000)
libosmogsm.so.10 => /usr/local/lib/libosmogsm.so.10 (0x7f5df4d1)
libosmovty.so.4 => /usr/local/lib/libosmovty.so.4 (0x7f5df4bc6000)

  ./gb/.libs/libosmogb.so
libosmocore.so.11 => /usr/local/lib/libosmocore.so.11 (0x7f788e536000)
libosmovty.so.4 => /usr/local/lib/libosmovty.so.4 (0x7f788e3ec000)
libosmogsm.so.10 => /usr/local/lib/libosmogsm.so.10 (0x7f788dfd3000)

  ./vty/.libs/libosmovty.so
libosmocore.so.11 => /usr/local/lib/libosmocore.so.11 (0x7f3b7ed21000)

  ./gsm/.libs/libosmogsm.so
libosmocore.so.11 => /usr/local/lib/libosmocore.so.11 (0x7fc69472e000)

  ./sim/.libs/libosmosim.so
libosmocore.so.11 => /usr/local/lib/libosmocore.so.11 (0x7f2f6412d000)
libosmogsm.so.10 => /usr/local/lib/libosmogsm.so.10 (0x7f2f63d14000)

Add all explicit linking of all required library dependencies in all regression
test programs, as shown by above listing.

Example for reproducing a problem:

In libosmocore.a, introduce a new function, and call that from libosmovty code.
For example, I made loglevel_strs non-static in logging.c, and used that in
logging_vty.c. Build and install this in a place where libtool can find it.
Then go back to before this change and rebuild. You will see that linking
ctrl_test (before this patch) then complains about libosmovty requiring the
loglevel_strs symbol which it cannot find in libosmocore.so.

Change-Id: Id084e6e6efd25cd62b1bd7a4fc7c5985c39130c6
---
M tests/Makefile.am
1 file changed, 13 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/tests/Makefile.am b/tests/Makefile.am
index 072bb4a..5d07695 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -76,7 +76,10 @@
 abis_abis_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la

 ctrl_ctrl_test_SOURCES = ctrl/ctrl_test.c
-ctrl_ctrl_test_LDADD = $(LDADD) $(top_builddir)/src/ctrl/libosmoctrl.la
+ctrl_ctrl_test_LDADD = $(LDADD) \
+   $(top_builddir)/src/ctrl/libosmoctrl.la \
+   $(top_builddir)/src/gsm/libosmogsm.la \
+   $(top_builddir)/src/vty/libosmovty.la

 gea_gea_test_SOURCES = gea/gea_test.c
 gea_gea_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la
@@ -130,20 +133,24 @@

 gb_bssgp_fc_test_SOURCES = gb/bssgp_fc_test.c
 gb_bssgp_fc_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la \
+$(top_builddir)/src/vty/libosmovty.la \
 $(top_builddir)/src/gsm/libosmogsm.la

 gb_gprs_bssgp_test_SOURCES = gb/gprs_bssgp_test.c
 gb_gprs_bssgp_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
+  $(top_builddir)/src/vty/libosmovty.la \
   $(top_builddir)/src/gsm/libosmogsm.la

 gb_gprs_ns_test_SOURCES = gb/gprs_ns_test.c
 gb_gprs_ns_test_LDADD = $(LDADD) $(top_builddir)/src/gb/libosmogb.la 
$(LIBRARY_DLSYM) \
+   $(top_builddir)/src/vty/libosmovty.la \

Change in osmo-msc[master]: Install sample cfg file to /etc/osmocom

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10919 )

Change subject: Install sample cfg file to /etc/osmocom
..

Install sample cfg file to /etc/osmocom

Change-Id: I19f3755f7637dfc017a89f503831f7df8098a919
---
M debian/osmo-msc.install
M doc/examples/Makefile.am
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/osmo-msc.install b/debian/osmo-msc.install
index 1e7f22f..e4b9646 100644
--- a/debian/osmo-msc.install
+++ b/debian/osmo-msc.install
@@ -1,3 +1,4 @@
+etc/osmocom/osmo-msc.cfg
 lib/systemd/system/osmo-msc.service
 usr/bin/osmo-msc
 usr/share/doc/osmo-msc/examples/osmo-msc/osmo-msc.cfg 
usr/share/doc/osmo-msc/examples
diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index 530c3fa..af36318 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -1,3 +1,11 @@
+OSMOCONF_FILES = \
+   osmo-msc/osmo-msc.cfg
+
+osmoconfdir = $(sysconfdir)/osmocom
+osmoconf_DATA = $(OSMOCONF_FILES)
+
+EXTRA_DIST = $(OSMOCONF_FILES)
+
 CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,'

 dist-hook:

--
To view, visit https://gerrit.osmocom.org/10919
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19f3755f7637dfc017a89f503831f7df8098a919
Gerrit-Change-Number: 10919
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-msc[master]: Install sample cfg file to /etc/osmocom

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10919 )

Change subject: Install sample cfg file to /etc/osmocom
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10919
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19f3755f7637dfc017a89f503831f7df8098a919
Gerrit-Change-Number: 10919
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Sep 2018 14:08:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: Install sample cfg file to /etc/osmocom

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10915 )

Change subject: Install sample cfg file to /etc/osmocom
..

Install sample cfg file to /etc/osmocom

Change-Id: I2ac73f426d9489fcd64c2eea547eb1f3ec26ae2c
---
M debian/osmo-hlr.install
M doc/examples/Makefile.am
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/osmo-hlr.install b/debian/osmo-hlr.install
index 5a7c37b..1b2cb56 100644
--- a/debian/osmo-hlr.install
+++ b/debian/osmo-hlr.install
@@ -1,3 +1,4 @@
+/etc/osmocom/osmo-hlr.cfg
 /lib/systemd/system/osmo-hlr.service
 /usr/bin/osmo-hlr
 /usr/bin/osmo-hlr-db-tool
diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index 530c3fa..fa8ab9b 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -1,3 +1,8 @@
+osmoconfdir = $(sysconfdir)/osmocom
+osmoconf_DATA = osmo-hlr.cfg
+
+EXTRA_DIST = osmo-hlr.cfg
+
 CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,'

 dist-hook:

--
To view, visit https://gerrit.osmocom.org/10915
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ac73f426d9489fcd64c2eea547eb1f3ec26ae2c
Gerrit-Change-Number: 10915
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-hlr[master]: Move doc/Makefile.am to doc/examples/Makefile.am

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10914 )

Change subject: Move doc/Makefile.am to doc/examples/Makefile.am
..

Move doc/Makefile.am to doc/examples/Makefile.am

Change-Id: I89ef3abe86e7ceb7b389ac1cb227ea065bfbce37
---
M configure.ac
M doc/Makefile.am
A doc/examples/Makefile.am
3 files changed, 24 insertions(+), 22 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/configure.ac b/configure.ac
index 368f1cc..99f7829 100644
--- a/configure.ac
+++ b/configure.ac
@@ -114,6 +114,7 @@
 AC_OUTPUT(
Makefile
doc/Makefile
+   doc/examples/Makefile
src/Makefile
src/gsupclient/Makefile
include/Makefile
diff --git a/doc/Makefile.am b/doc/Makefile.am
index e0e5380..aee2d7b 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -1,22 +1 @@
-CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,'
-
-dist-hook:
-   for f in $$($(CFG_FILES)); do \
-   j="$(distdir)/$$f" && \
-   mkdir -p "$$(dirname $$j)" && \
-   $(INSTALL_DATA) $(srcdir)/$$f $$j; \
-   done
-
-install-data-hook:
-   for f in $$($(CFG_FILES)); do \
-   j="$(DESTDIR)$(docdir)/$$f" && \
-   mkdir -p "$$(dirname $$j)" && \
-   $(INSTALL_DATA) $(srcdir)/$$f $$j; \
-   done
-
-uninstall-hook:
-   @$(PRE_UNINSTALL)
-   for f in $$($(CFG_FILES)); do \
-   j="$(DESTDIR)$(docdir)/$$f" && \
-   $(RM) $$j; \
-   done
+SUBDIRS = examples
diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
new file mode 100644
index 000..530c3fa
--- /dev/null
+++ b/doc/examples/Makefile.am
@@ -0,0 +1,22 @@
+CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,'
+
+dist-hook:
+   for f in $$($(CFG_FILES)); do \
+   j="$(distdir)/$$f" && \
+   mkdir -p "$$(dirname $$j)" && \
+   $(INSTALL_DATA) $(srcdir)/$$f $$j; \
+   done
+
+install-data-hook:
+   for f in $$($(CFG_FILES)); do \
+   j="$(DESTDIR)$(docdir)/examples/$$f" && \
+   mkdir -p "$$(dirname $$j)" && \
+   $(INSTALL_DATA) $(srcdir)/$$f $$j; \
+   done
+
+uninstall-hook:
+   @$(PRE_UNINSTALL)
+   for f in $$($(CFG_FILES)); do \
+   j="$(DESTDIR)$(docdir)/examples/$$f" && \
+   $(RM) $$j; \
+   done

--
To view, visit https://gerrit.osmocom.org/10914
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89ef3abe86e7ceb7b389ac1cb227ea065bfbce37
Gerrit-Change-Number: 10914
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-msc[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10896 )

Change subject: Install systemd services with autotools
..

Install systemd services with autotools

Change-Id: I3a87d5ad4cb43efdcfc25828144f825f4d3b1594
---
M Makefile.am
M configure.ac
A contrib/Makefile.am
A contrib/systemd/Makefile.am
M debian/osmo-msc.install
D debian/osmo-msc.service
M debian/rules
7 files changed, 31 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Verified



diff --git a/Makefile.am b/Makefile.am
index 2f0a786..9f3644f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -12,12 +12,16 @@
doc \
include \
src \
+   contrib \
tests \
$(NULL)

 BUILT_SOURCES = $(top_srcdir)/.version
 EXTRA_DIST = git-version-gen osmoappdesc.py .version

+DISTCHECK_CONFIGURE_FLAGS = \
+   --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
+
 @RELMAKE@

 $(top_srcdir)/.version:
diff --git a/configure.ac b/configure.ac
index 03acc0c..2d8dc42 100644
--- a/configure.ac
+++ b/configure.ac
@@ -181,6 +181,22 @@
 AC_MSG_RESULT([$enable_ext_tests])
 AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes")

+# https://www.freedesktop.org/software/systemd/man/daemon.html
+AC_ARG_WITH([systemdsystemunitdir],
+ [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
+ [with_systemdsystemunitdir=auto])
+AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o 
"x$with_systemdsystemunitdir" = "xauto"], [
+ def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir 
systemd)
+
+ AS_IF([test "x$def_systemdsystemunitdir" = "x"],
+   [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"],
+[AC_MSG_ERROR([systemd support requested but pkg-config unable to query 
systemd package])])
+with_systemdsystemunitdir=no],
+   [with_systemdsystemunitdir="$def_systemdsystemunitdir"])])
+AS_IF([test "x$with_systemdsystemunitdir" != "xno"],
+  [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])])
+AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"])
+
 AC_MSG_RESULT([CFLAGS="$CFLAGS"])
 AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])

@@ -203,4 +219,6 @@
 tests/msc_vlr/Makefile
 doc/Makefile
 doc/examples/Makefile
+contrib/Makefile
+contrib/systemd/Makefile
 Makefile)
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
new file mode 100644
index 000..3439c97
--- /dev/null
+++ b/contrib/Makefile.am
@@ -0,0 +1 @@
+SUBDIRS = systemd
diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
new file mode 100644
index 000..8648172
--- /dev/null
+++ b/contrib/systemd/Makefile.am
@@ -0,0 +1,5 @@
+if HAVE_SYSTEMD
+EXTRA_DIST = osmo-msc.service
+systemdsystemunit_DATA = \
+  osmo-msc.service
+endif
diff --git a/debian/osmo-msc.install b/debian/osmo-msc.install
index 6b84b8f..1e7f22f 100644
--- a/debian/osmo-msc.install
+++ b/debian/osmo-msc.install
@@ -1,3 +1,4 @@
+lib/systemd/system/osmo-msc.service
 usr/bin/osmo-msc
 usr/share/doc/osmo-msc/examples/osmo-msc/osmo-msc.cfg 
usr/share/doc/osmo-msc/examples
 usr/share/doc/osmo-msc/examples/osmo-msc/osmo-msc_custom-sccp.cfg 
usr/share/doc/osmo-msc/examples
diff --git a/debian/osmo-msc.service b/debian/osmo-msc.service
deleted file mode 12
index 784b8b5..000
--- a/debian/osmo-msc.service
+++ /dev/null
@@ -1 +0,0 @@
-../contrib/systemd/osmo-msc.service
\ No newline at end of file
diff --git a/debian/rules b/debian/rules
index 15e79da..1cf3a35 100755
--- a/debian/rules
+++ b/debian/rules
@@ -42,11 +42,11 @@

 # main packaging script based on dh7 syntax
 %:
-   dh $@ --with autoreconf
+   dh $@ --with autoreconf

 # debmake generated override targets
 # Set options for ./configure
-CONFIGURE_FLAGS += --enable-iu --enable-smpp
+CONFIGURE_FLAGS += --enable-iu --enable-smpp 
--with-systemdsystemunitdir=/lib/systemd/system
 override_dh_auto_configure:
dh_auto_configure -- $(CONFIGURE_FLAGS)
 #

--
To view, visit https://gerrit.osmocom.org/10896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a87d5ad4cb43efdcfc25828144f825f4d3b1594
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-msc[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10896 )

Change subject: Install systemd services with autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a87d5ad4cb43efdcfc25828144f825f4d3b1594
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Sep 2018 13:59:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: Install sample cfg file to /etc/osmocom

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10926 )

Change subject: Install sample cfg file to /etc/osmocom
..

Install sample cfg file to /etc/osmocom

Change-Id: I080ae6a4c4f92dd8df055efd25e308f8a3377d34
---
M debian/osmo-bsc-mgcp.install
M debian/osmocom-bsc-nat.install
M debian/osmocom-bsc-sccplite.install
M debian/osmocom-nitb.install
M openbsc/doc/examples/Makefile.am
R openbsc/doc/examples/osmo-bsc_mgcp/osmo-bsc-mgcp.cfg
R openbsc/doc/examples/osmo-bsc_nat/osmo-bsc-nat.cfg
R openbsc/doc/examples/osmo-nitb/bs11/osmo-nitb.cfg
R openbsc/doc/examples/osmo-nitb/nanobts/osmo-nitb.cfg
R openbsc/doc/examples/osmo-nitb/rbs2308/osmo-nitb.cfg
R openbsc/doc/examples/osmo-nitb/sysmobts/osmo-nitb.cfg
M openbsc/osmoappdesc.py
M openbsc/tests/ctrl_test_runner.py
M openbsc/tests/smpp_test_runner.py
M openbsc/tests/vty_test_runner.py
15 files changed, 34 insertions(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/osmo-bsc-mgcp.install b/debian/osmo-bsc-mgcp.install
index 828fb31..8f9b74f 100644
--- a/debian/osmo-bsc-mgcp.install
+++ b/debian/osmo-bsc-mgcp.install
@@ -1,2 +1,3 @@
+etc/osmocom/osmo-bsc-mgcp.cfg
 lib/systemd/system/osmo-bsc-mgcp.service
 usr/bin/osmo-bsc_mgcp
diff --git a/debian/osmocom-bsc-nat.install b/debian/osmocom-bsc-nat.install
index d6cabe2..ba134d1 100644
--- a/debian/osmocom-bsc-nat.install
+++ b/debian/osmocom-bsc-nat.install
@@ -1,2 +1,3 @@
+/etc/osmocom/osmo-bsc-nat.cfg
 /lib/systemd/system/osmo-bsc-nat.service
 /usr/bin/osmo-bsc_nat
diff --git a/debian/osmocom-bsc-sccplite.install 
b/debian/osmocom-bsc-sccplite.install
index 67c50cb..872333e 100644
--- a/debian/osmocom-bsc-sccplite.install
+++ b/debian/osmocom-bsc-sccplite.install
@@ -1,2 +1,3 @@
+/etc/osmocom/osmo-bsc-sccplite.cfg
 /lib/systemd/system/osmo-bsc-sccplite.service
 /usr/bin/osmo-bsc-sccplite
diff --git a/debian/osmocom-nitb.install b/debian/osmocom-nitb.install
index 78e8f77..87ed7e2 100644
--- a/debian/osmocom-nitb.install
+++ b/debian/osmocom-nitb.install
@@ -1,3 +1,4 @@
+/etc/osmocom/osmo-nitb.cfg
 /lib/systemd/system/osmo-nitb.service
 /usr/bin/osmo-nitb
 openbsc/contrib/*.py usr/bin/
diff --git a/openbsc/doc/examples/Makefile.am b/openbsc/doc/examples/Makefile.am
index 530c3fa..2b8336f 100644
--- a/openbsc/doc/examples/Makefile.am
+++ b/openbsc/doc/examples/Makefile.am
@@ -1,3 +1,21 @@
+
+OSMOCONF_FILES = \
+   osmo-nitb/sysmobts/osmo-nitb.cfg \
+   osmo-bsc_mgcp/osmo-bsc-mgcp.cfg
+
+if BUILD_NAT
+OSMOCONF_FILES += osmo-bsc_nat/osmo-bsc-nat.cfg
+endif
+
+if BUILD_BSC
+OSMOCONF_FILES += osmo-bsc-sccplite/osmo-bsc-sccplite.cfg
+endif
+
+osmoconfdir = $(sysconfdir)/osmocom
+osmoconf_DATA = $(OSMOCONF_FILES)
+
+EXTRA_DIST = $(OSMOCONF_FILES)
+
 CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,'

 dist-hook:
diff --git a/openbsc/doc/examples/osmo-bsc_mgcp/mgcp.cfg 
b/openbsc/doc/examples/osmo-bsc_mgcp/osmo-bsc-mgcp.cfg
similarity index 100%
rename from openbsc/doc/examples/osmo-bsc_mgcp/mgcp.cfg
rename to openbsc/doc/examples/osmo-bsc_mgcp/osmo-bsc-mgcp.cfg
diff --git a/openbsc/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg 
b/openbsc/doc/examples/osmo-bsc_nat/osmo-bsc-nat.cfg
similarity index 100%
rename from openbsc/doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg
rename to openbsc/doc/examples/osmo-bsc_nat/osmo-bsc-nat.cfg
diff --git a/openbsc/doc/examples/osmo-nitb/bs11/openbsc.cfg 
b/openbsc/doc/examples/osmo-nitb/bs11/osmo-nitb.cfg
similarity index 100%
rename from openbsc/doc/examples/osmo-nitb/bs11/openbsc.cfg
rename to openbsc/doc/examples/osmo-nitb/bs11/osmo-nitb.cfg
diff --git a/openbsc/doc/examples/osmo-nitb/nanobts/openbsc.cfg 
b/openbsc/doc/examples/osmo-nitb/nanobts/osmo-nitb.cfg
similarity index 100%
rename from openbsc/doc/examples/osmo-nitb/nanobts/openbsc.cfg
rename to openbsc/doc/examples/osmo-nitb/nanobts/osmo-nitb.cfg
diff --git a/openbsc/doc/examples/osmo-nitb/rbs2308/openbsc.cfg 
b/openbsc/doc/examples/osmo-nitb/rbs2308/osmo-nitb.cfg
similarity index 100%
rename from openbsc/doc/examples/osmo-nitb/rbs2308/openbsc.cfg
rename to openbsc/doc/examples/osmo-nitb/rbs2308/osmo-nitb.cfg
diff --git a/openbsc/doc/examples/osmo-nitb/sysmobts/openbsc.cfg 
b/openbsc/doc/examples/osmo-nitb/sysmobts/osmo-nitb.cfg
similarity index 100%
rename from openbsc/doc/examples/osmo-nitb/sysmobts/openbsc.cfg
rename to openbsc/doc/examples/osmo-nitb/sysmobts/osmo-nitb.cfg
diff --git a/openbsc/osmoappdesc.py b/openbsc/osmoappdesc.py
index c5b20ac..5b01e4c 100644
--- a/openbsc/osmoappdesc.py
+++ b/openbsc/osmoappdesc.py
@@ -20,19 +20,19 @@
 "doc/examples/osmo-nitb/bs11/openbsc-2bts-2trx.cfg",
 "doc/examples/osmo-nitb/bs11/openbsc-1bts-2trx-hopping.cfg",
 "doc/examples/osmo-nitb/bs11/openbsc-1bts-2trx.cfg",
-"doc/examples/osmo-nitb/bs11/openbsc.cfg",
+"doc/examples/osmo-nitb/bs11/osmo-nitb.cfg",
 

Change in osmo-trx[master]: Install sample cfg file to /etc/osmocom

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10924 )

Change subject: Install sample cfg file to /etc/osmocom
..

Install sample cfg file to /etc/osmocom

Change-Id: Ib871a3cd14386ef6e6b512a3d66e7e7a839295a5
---
M debian/osmo-trx-lms.install
M debian/osmo-trx-uhd.install
M doc/examples/Makefile.am
A doc/examples/osmo-trx-lms/osmo-trx-lms.cfg
A doc/examples/osmo-trx-uhd/osmo-trx-uhd.cfg
5 files changed, 24 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/osmo-trx-lms.install b/debian/osmo-trx-lms.install
index b58c862..b89506a 100644
--- a/debian/osmo-trx-lms.install
+++ b/debian/osmo-trx-lms.install
@@ -1,3 +1,4 @@
+etc/osmocom/osmo-trx-lms.cfg
 lib/systemd/system/osmo-trx-lms.service
 /usr/bin/osmo-trx-lms
 /usr/share/doc/osmo-trx/examples/osmo-trx-lms/osmo-trx-limesdr.cfg 
/usr/share/doc/osmo-trx/examples/osmo-trx-lms/
diff --git a/debian/osmo-trx-uhd.install b/debian/osmo-trx-uhd.install
index b7ec5ca..77236ca 100644
--- a/debian/osmo-trx-uhd.install
+++ b/debian/osmo-trx-uhd.install
@@ -1,3 +1,4 @@
+etc/osmocom/osmo-trx-uhd.cfg
 lib/systemd/system/osmo-trx-uhd.service
 /usr/bin/osmo-trx-uhd
 /usr/share/doc/osmo-trx/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 
/usr/share/doc/osmo-trx/examples/osmo-trx-uhd/
diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index 530c3fa..88d9142 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -1,4 +1,23 @@
-CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,'
+OSMOCONF_FILES =
+osmoconfdir = $(sysconfdir)/osmocom
+
+if DEVICE_UHD
+OSMOCONF_FILES += osmo-trx-uhd/osmo-trx-uhd.cfg
+endif
+
+# if DEVICE_USRP1
+# TODO: no usrp1 sample file yet
+# OSMOCONF_FILES += osmo-trx-usrp1/osmo-trx-usrp1.cfg
+# endif
+
+if DEVICE_LMS
+OSMOCONF_FILES += osmo-trx-lms/osmo-trx-lms.cfg
+endif
+
+osmoconf_DATA = $(OSMOCONF_FILES)
+EXTRA_DIST = $(OSMOCONF_FILES)
+
+CFG_FILES = find $(srcdir) -type f -name '*.cfg*' | sed -e 's,^$(srcdir),,'

 dist-hook:
for f in $$($(CFG_FILES)); do \
diff --git a/doc/examples/osmo-trx-lms/osmo-trx-lms.cfg 
b/doc/examples/osmo-trx-lms/osmo-trx-lms.cfg
new file mode 12
index 000..13ae04a
--- /dev/null
+++ b/doc/examples/osmo-trx-lms/osmo-trx-lms.cfg
@@ -0,0 +1 @@
+osmo-trx-limesdr.cfg
\ No newline at end of file
diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-uhd.cfg 
b/doc/examples/osmo-trx-uhd/osmo-trx-uhd.cfg
new file mode 12
index 000..11f2320
--- /dev/null
+++ b/doc/examples/osmo-trx-uhd/osmo-trx-uhd.cfg
@@ -0,0 +1 @@
+osmo-trx-usrp_b200.cfg
\ No newline at end of file

--
To view, visit https://gerrit.osmocom.org/10924
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib871a3cd14386ef6e6b512a3d66e7e7a839295a5
Gerrit-Change-Number: 10924
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bts[master]: Install sample cfg file to /etc/osmocom

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10921 )

Change subject: Install sample cfg file to /etc/osmocom
..

Install sample cfg file to /etc/osmocom

Change cfg file names so they don't overlap when installing different
osmo-bts versions, and make systemd services look for correct new name.

Remove unneeded duplicated EXTRA_DIST files from root dir Makefile.am

Change-Id: I75fdd06cc52ce50628efb1f9b007d2e3926db27d
---
M Makefile.am
M contrib/systemd/osmo-bts-lc15.service
M contrib/systemd/osmo-bts-sysmo.service
M contrib/systemd/osmo-bts-trx.service
M debian/osmo-bts-trx.install
M debian/osmo-bts-virtual.install
M doc/examples/Makefile.am
R doc/examples/litecell15/osmo-bts-lc15.cfg
R doc/examples/octphy/osmo-bts-octphy.cfg
R doc/examples/sysmo/osmo-bts-sysmo.cfg
R doc/examples/trx/osmo-bts-trx.cfg
R doc/examples/virtual/osmo-bts-virtual.cfg
12 files changed, 20 insertions(+), 14 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/Makefile.am b/Makefile.am
index b573aa8..5b49bb7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -7,10 +7,6 @@
 EXTRA_DIST = \
contrib/dump_docs.py contrib/screenrc-l1fwd \
contrib/l1fwd.init contrib/screenrc-sysmobts contrib/respawn.sh \
-   doc/examples/sysmo/osmo-bts.cfg \
-   doc/examples/sysmo/sysmobts-mgr.cfg \
-   doc/examples/virtual/openbsc-virtual.cfg \
-   doc/examples/virtual/osmobts-virtual.cfg \
git-version-gen .version \
README.md

diff --git a/contrib/systemd/osmo-bts-lc15.service 
b/contrib/systemd/osmo-bts-lc15.service
index 6aa9751..90e7fc2 100644
--- a/contrib/systemd/osmo-bts-lc15.service
+++ b/contrib/systemd/osmo-bts-lc15.service
@@ -5,7 +5,7 @@
 Type=simple
 ExecStartPre=/bin/sh -c 'echo 1 > /sys/class/leds/usr0/brightness'
 ExecStartPre=/bin/sh -c 'echo 1 > /sys/class/leds/usr1/brightness'
-ExecStart=/usr/bin/osmo-bts-lc15 -t 2 -s -c /etc/osmocom/osmo-bts.cfg -M
+ExecStart=/usr/bin/osmo-bts-lc15 -t 2 -s -c /etc/osmocom/osmo-bts-lc15.cfg -M
 ExecStopPost=/bin/sh -c 'echo 1 > /sys/class/leds/usr0/brightness'
 ExecStopPost=/bin/sh -c 'echo 0 > /sys/class/leds/usr1/brightness'
 Restart=always
diff --git a/contrib/systemd/osmo-bts-sysmo.service 
b/contrib/systemd/osmo-bts-sysmo.service
index 65b1f00..9255817 100644
--- a/contrib/systemd/osmo-bts-sysmo.service
+++ b/contrib/systemd/osmo-bts-sysmo.service
@@ -4,7 +4,7 @@
 [Service]
 Type=simple
 ExecStartPre=/bin/sh -c 'echo 0 > /sys/class/leds/activity_led/brightness'
-ExecStart=/usr/bin/osmo-bts-sysmo -s -c /etc/osmocom/osmo-bts.cfg -M
+ExecStart=/usr/bin/osmo-bts-sysmo -s -c /etc/osmocom/osmo-bts-sysmo.cfg -M
 ExecStopPost=/bin/sh -c 'echo 0 > /sys/class/leds/activity_led/brightness'
 ExecStopPost=/bin/sh -c 'cat /lib/firmware/sysmobts-v?.bit > /dev/fpgadl_par0 
; sleep 3s; cat /lib/firmware/sysmobts-v?.out > /dev/dspdl_dm644x_0; sleep 1s'
 Restart=always
diff --git a/contrib/systemd/osmo-bts-trx.service 
b/contrib/systemd/osmo-bts-trx.service
index cea8719..97c2b07 100644
--- a/contrib/systemd/osmo-bts-trx.service
+++ b/contrib/systemd/osmo-bts-trx.service
@@ -3,7 +3,7 @@

 [Service]
 Type=simple
-ExecStart=/usr/bin/osmo-bts-trx -s -c /etc/osmocom/osmo-bts.cfg
+ExecStart=/usr/bin/osmo-bts-trx -s -c /etc/osmocom/osmo-bts-trx.cfg
 Restart=always
 RestartSec=2

diff --git a/debian/osmo-bts-trx.install b/debian/osmo-bts-trx.install
index 2343d25..004a7ed 100644
--- a/debian/osmo-bts-trx.install
+++ b/debian/osmo-bts-trx.install
@@ -1,4 +1,5 @@
+etc/osmocom/osmo-bts-trx.cfg
 lib/systemd/system/osmo-bts-trx.service
 usr/bin/osmo-bts-trx
-usr/share/doc/osmo-bts/examples/osmo-bts-trx/osmo-bts.cfg
+usr/share/doc/osmo-bts/examples/osmo-bts-trx/osmo-bts-trx.cfg
 usr/share/doc/osmo-bts/examples/osmo-bts-trx/osmo-bts-trx-calypso.cfg
diff --git a/debian/osmo-bts-virtual.install b/debian/osmo-bts-virtual.install
index 0e6ca1b..f4d988f 100644
--- a/debian/osmo-bts-virtual.install
+++ b/debian/osmo-bts-virtual.install
@@ -1,5 +1,6 @@
+etc/osmocom/osmo-bts-virtual.cfg
 lib/systemd/system/osmo-bts-virtual.service
 usr/bin/osmo-bts-virtual
 usr/bin/osmo-bts-omldummy
-usr/share/doc/osmo-bts/examples/osmo-bts-virtual/osmobts-virtual.cfg
+usr/share/doc/osmo-bts/examples/osmo-bts-virtual/osmo-bts-virtual.cfg
 usr/share/doc/osmo-bts/examples/osmo-bts-virtual/openbsc-virtual.cfg
diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index e4be5fc..241f579 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -1,38 +1,46 @@
+OSMOCONF_FILES = virtual/osmo-bts-virtual.cfg

 doc_virtualdir = $(docdir)/examples/osmo-bts-virtual
 doc_virtual_DATA = \
-virtual/osmobts-virtual.cfg \
+virtual/osmo-bts-virtual.cfg \
 virtual/openbsc-virtual.cfg
 EXTRA_DIST = $(doc_virtual_DATA)

 if ENABLE_SYSMOBTS
 doc_sysmodir = $(docdir)/examples/osmo-bts-sysmo
 doc_sysmo_DATA = \
-

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: stop properly on failure in f_establish_fully()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10904 )

Change subject: MSC_ConnectionHandler: stop properly on failure in 
f_establish_fully()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10904
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4ac7bcbac35a4ae454d1806f3fbb727834d18b7
Gerrit-Change-Number: 10904
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 13 Sep 2018 13:58:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10895 )

Change subject: Install systemd services with autotools
..

Install systemd services with autotools

Change-Id: I7e4dae6b8c1685e8a673c58a843c41fa0af1b35c
---
M Makefile.am
M configure.ac
M contrib/Makefile.am
A contrib/systemd/Makefile.am
M debian/osmo-mgw.install
D debian/osmo-mgw.service
M debian/rules
7 files changed, 32 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Verified



diff --git a/Makefile.am b/Makefile.am
index 3270e4f..1497f80 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -24,6 +24,9 @@
 BUILT_SOURCES = $(top_srcdir)/.version
 EXTRA_DIST = git-version-gen osmoappdesc.py .version

+DISTCHECK_CONFIGURE_FLAGS = \
+   --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)
+
 @RELMAKE@

 $(top_srcdir)/.version:
diff --git a/configure.ac b/configure.ac
index 9f021df..3e6581d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -128,6 +128,22 @@
 AC_MSG_RESULT([$enable_ext_tests])
 AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes")

+# https://www.freedesktop.org/software/systemd/man/daemon.html
+AC_ARG_WITH([systemdsystemunitdir],
+ [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
+ [with_systemdsystemunitdir=auto])
+AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o 
"x$with_systemdsystemunitdir" = "xauto"], [
+ def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir 
systemd)
+
+ AS_IF([test "x$def_systemdsystemunitdir" = "x"],
+   [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"],
+[AC_MSG_ERROR([systemd support requested but pkg-config unable to query 
systemd package])])
+with_systemdsystemunitdir=no],
+   [with_systemdsystemunitdir="$def_systemdsystemunitdir"])])
+AS_IF([test "x$with_systemdsystemunitdir" != "xno"],
+  [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])])
+AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"])
+
 AC_MSG_RESULT([CFLAGS="$CFLAGS"])
 AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"])

@@ -151,4 +167,5 @@
 doc/Makefile
 doc/examples/Makefile
 contrib/Makefile
+contrib/systemd/Makefile
 Makefile)
diff --git a/contrib/Makefile.am b/contrib/Makefile.am
index db6d0f5..ab410c7 100644
--- a/contrib/Makefile.am
+++ b/contrib/Makefile.am
@@ -1 +1,3 @@
+SUBDIRS = systemd
+
 EXTRA_DIST = ipa.py
diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
new file mode 100644
index 000..c0d95ff
--- /dev/null
+++ b/contrib/systemd/Makefile.am
@@ -0,0 +1,5 @@
+if HAVE_SYSTEMD
+EXTRA_DIST = osmo-mgw.service
+systemdsystemunit_DATA = \
+  osmo-mgw.service
+endif
diff --git a/debian/osmo-mgw.install b/debian/osmo-mgw.install
index 39f7c01..ad3d3c6 100644
--- a/debian/osmo-mgw.install
+++ b/debian/osmo-mgw.install
@@ -1,2 +1,3 @@
+lib/systemd/system/osmo-mgw.service
 usr/bin/osmo-mgw
 usr/share/doc/osmo-mgw/examples/osmo-mgw/osmo-mgw.cfg
diff --git a/debian/osmo-mgw.service b/debian/osmo-mgw.service
deleted file mode 12
index 1e0664c..000
--- a/debian/osmo-mgw.service
+++ /dev/null
@@ -1 +0,0 @@
-../contrib/systemd/osmo-mgw.service
\ No newline at end of file
diff --git a/debian/rules b/debian/rules
index d13e426..d67243c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -14,7 +14,7 @@

 # main packaging script based on dh7 syntax
 %:
-   dh $@ --with autoreconf
+   dh $@ --with autoreconf

 # debmake generated override targets
 # Set options for ./configure
@@ -29,4 +29,7 @@
 override_dh_auto_test:
dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)

+override_dh_auto_configure:
+   dh_auto_configure -- --with-systemdsystemunitdir=/lib/systemd/system
+
 # See 
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-dbg

--
To view, visit https://gerrit.osmocom.org/10895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e4dae6b8c1685e8a673c58a843c41fa0af1b35c
Gerrit-Change-Number: 10895
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: stop properly on failure in f_establish_fully()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10904 )

Change subject: MSC_ConnectionHandler: stop properly on failure in 
f_establish_fully()
..

MSC_ConnectionHandler: stop properly on failure in f_establish_fully()

When the altstep in f_establish_fully() gets an unexpected ASSIGNMENT
FAIL or COMPLETE it should stop completely like it is already
implemented in many other altsteps.

Change-Id: Ib4ac7bcbac35a4ae454d1806f3fbb727834d18b7
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 102c30e..9f67f1b 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -939,18 +939,28 @@
 (not st.is_assignment and (st.modify_done or not exp_modify))) and
 exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentComplete) {
setverdict(fail, "Received non-matching ASSIGNMENT COMPLETE");
+   all component.stop;
+   mtc.stop;
}
[exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentFail) {
setverdict(fail, "Received unexpected ASSIGNMENT FAIL");
+   all component.stop;
+   mtc.stop;
}
[not exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentComplete) {
setverdict(fail, "Received unexpected ASSIGNMENT COMPLETE");
+   all component.stop;
+   mtc.stop;
}
[not exp_compl] BSSAP.receive(tr_BSSMAP_AssignmentFail) {
setverdict(fail, "Received non-matching ASSIGNMENT FAIL");
+   all component.stop;
+   mtc.stop;
}
[] T.timeout {
setverdict(fail, "Timeout waiting for ASSIGNMENT COMPLETE");
+   all component.stop;
+   mtc.stop;
}
}
log("g_media ", g_media);

--
To view, visit https://gerrit.osmocom.org/10904
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4ac7bcbac35a4ae454d1806f3fbb727834d18b7
Gerrit-Change-Number: 10904
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-mgw[master]: Install sample cfg file to /etc/osmocom

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10918 )

Change subject: Install sample cfg file to /etc/osmocom
..

Install sample cfg file to /etc/osmocom

Change-Id: I6926e989a130086f4b6c8277407377a4063f452f
---
M debian/osmo-mgw.install
M doc/examples/Makefile.am
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/osmo-mgw.install b/debian/osmo-mgw.install
index ad3d3c6..6f44961 100644
--- a/debian/osmo-mgw.install
+++ b/debian/osmo-mgw.install
@@ -1,3 +1,4 @@
+etc/osmocom/osmo-mgw.cfg
 lib/systemd/system/osmo-mgw.service
 usr/bin/osmo-mgw
 usr/share/doc/osmo-mgw/examples/osmo-mgw/osmo-mgw.cfg
diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
index 530c3fa..da504f4 100644
--- a/doc/examples/Makefile.am
+++ b/doc/examples/Makefile.am
@@ -1,3 +1,11 @@
+OSMOCONF_FILES = \
+   osmo-mgw/osmo-mgw.cfg
+
+osmoconfdir = $(sysconfdir)/osmocom
+osmoconf_DATA = $(OSMOCONF_FILES)
+
+EXTRA_DIST = $(OSMOCONF_FILES)
+
 CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,'

 dist-hook:

--
To view, visit https://gerrit.osmocom.org/10918
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6926e989a130086f4b6c8277407377a4063f452f
Gerrit-Change-Number: 10918
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-mgw[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10895 )

Change subject: Install systemd services with autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4dae6b8c1685e8a673c58a843c41fa0af1b35c
Gerrit-Change-Number: 10895
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Sep 2018 13:58:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Install systemd services with autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10895 )

Change subject: Install systemd services with autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4dae6b8c1685e8a673c58a843c41fa0af1b35c
Gerrit-Change-Number: 10895
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Thu, 13 Sep 2018 13:58:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes