Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #279

2018-10-17 Thread jenkins 
See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking

Change in osmo-trx[master]: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences

2018-10-17 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/11390 )

Change subject: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11390
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I838c21db29c54f1924dd478c2b34b46b70aab2cd
Gerrit-Change-Number: 11390
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Assignee: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Tom Tsou 
Gerrit-Comment-Date: Wed, 17 Oct 2018 14:33:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm_08_58.h: Introduce struct abis_rsl_chan_nr

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11303 )

Change subject: gsm_08_58.h: Introduce struct abis_rsl_chan_nr
..


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/11303/2/include/osmocom/gsm/protocol/gsm_08_58.h
File include/osmocom/gsm/protocol/gsm_08_58.h:

https://gerrit.osmocom.org/#/c/11303/2/include/osmocom/gsm/protocol/gsm_08_58.h@45
PS2, Line 45: ACCHs 0x01
> It's strange, it didn't look aligned in my editor, but it did during git show.
in git's patch output, the first char in each line is a diff indicator 
(+,-,space), so a line that has no tabs in it always appears one space further 
right than a line with tabs. Also tabs might snap to a different column in the 
diff output.


https://gerrit.osmocom.org/#/c/11303/2/include/osmocom/gsm/protocol/gsm_08_58.h@85
PS2, Line 85:   union abis_rsl_chan_nr chan_nr_fields; /*!< RSL channel 
number (value) */
(before this, the comment was spaced by tab; I don't like that, but I guess it 
should stay consistent to above anyway. same below.)



--
To view, visit https://gerrit.osmocom.org/11303
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6822021207270a00106c50f8ca6b93c1250df9
Gerrit-Change-Number: 11303
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 17 Oct 2018 14:22:13 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: MSC_Tests: add test to try two LU from different BSCs

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9204 )

Change subject: MSC_Tests: add test to try two LU from different BSCs
..


Patch Set 5: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn
File library/BSSMAP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn@51
PS5, Line 51:
(ws)


https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn@54
PS5, Line 54:   port BSSMAPEM_PROC_PT BSSAP_PROC_1;
I think with BTS we have an array of them? Is that possible with component 
ports? (arrays potentially save the need to code dup for each instance)


https://gerrit.osmocom.org/#/c/9204/5/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/9204/5/msc/BSC_ConnectionHandler.ttcn@53
PS5, Line 53: type record of BSC_ConnHdlrBscPars BSC_ConnHdlrBscParsTable;
ah, there's an array of BSCs here



--
To view, visit https://gerrit.osmocom.org/9204
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3eabf8537066f43faed8fb983d9e1f4092ec515
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 17 Oct 2018 14:17:06 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: gsm_04_08_cc: Add global guard timer for MNCC

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11307 )

Change subject: gsm_04_08_cc: Add global guard timer for MNCC
..


Patch Set 3: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/gsm_04_08_cc.c
File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/gsm_04_08_cc.c@80
PS3, Line 80:  vlr_subscr_msisdn_or_name(trans->vsub));
(best use same formatting as other logging in this file, e.g. line 2025)


https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/gsm_04_08_cc.c@89
PS3, Line 89:  vlr_subscr_msisdn_or_name(trans->vsub));
re


https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/osmo_msc.c
File src/libmsc/osmo_msc.c:

https://gerrit.osmocom.org/#/c/11307/3/src/libmsc/osmo_msc.c@57
PS3, Line 57:   /* If the mncc interface remains silent for more then 3 minutes,
("than" .. "during setup" ... or maybe just drop the comment anyway, it's 
obvious enough)



--
To view, visit https://gerrit.osmocom.org/11307
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7375d1e17cd746aac4eadfe1e587e82cf1630d3d
Gerrit-Change-Number: 11307
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 17 Oct 2018 14:10:18 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11391 )

Change subject: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f954a8807c0f0513422693ac24c647da0bfafd1
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:52:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11391 )

Change subject: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing
..


Patch Set 1:

would it be an option to configure the MSC's timer to 20 seconds instead? After 
all, each test execution would idle around for three full minutes. If we don't 
have a configurable timer there, I guess we should add it to the MSC?


--
To view, visit https://gerrit.osmocom.org/11391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f954a8807c0f0513422693ac24c647da0bfafd1
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:52:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11368 )

Change subject: rename m3ua-test, sua-test to nplab-*-test
..


Patch Set 4:

> NOTE: we need to modify the existing jobs to use the renamed
 > folders after this is merged.

(If that is done by a yml file patch you have submitted, then indicate its 
change-id in the commit log)


--
To view, visit https://gerrit.osmocom.org/11368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
Gerrit-Change-Number: 11368
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:42:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: jenkins-common.sh: add docker_images_require()

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11365 )

Change subject: jenkins-common.sh: add docker_images_require()
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11365/2/jenkins-common.sh
File jenkins-common.sh:

https://gerrit.osmocom.org/#/c/11365/2/jenkins-common.sh@8
PS2, Line 8:if [ -z "$NO_DOCKER_IMAGE_BUILD" ]; then
btw, in general, it is better to avoid double negation / positive meaning 
negative in settings like these. i.e.

  do_this = [true|false]

is easier to grok than

  dont_do_this = [true|false]

Then a default of 1:

  DOCKER_IMAGE_BUILD="${DOCKER_IMAGE_BUILD:-1}"

again not that important, but keep in mind for next time maybe.



--
To view, visit https://gerrit.osmocom.org/11365
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:38:37 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: testsuite.yml for all ttcn3/nplab jobs

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11370 )

Change subject: jobs: testsuite.yml for all ttcn3/nplab jobs
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml
File jobs/testsuite.yml:

https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml@7
PS1, Line 7:   - "{testsuite-name}{job-suffix}"
> I still don't like "suffix", too general. […]
in that other patch I realize that "master" isn't a feed name, and maybe I 
should just let this one go.



--
To view, visit https://gerrit.osmocom.org/11370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
Gerrit-Change-Number: 11370
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:33:53 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in docker-playground[master]: jenkins.sh: IMAGE_SUFFIX, docker_images_require()

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11366 )

Change subject: jenkins.sh: IMAGE_SUFFIX, docker_images_require()
..


Patch Set 3: Code-Review+1

hmm, 'master' isn't a feed really, is it. I don't know, I would prefer some 
meaningful name instead of "suffix" ... but if Harald likes it then nevermind...


--
To view, visit https://gerrit.osmocom.org/11366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb708ab16cb71bab5069127945b63388222369e
Gerrit-Change-Number: 11366
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:32:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: jenkins-common.sh: add docker_images_require()

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11365 )

Change subject: jenkins-common.sh: add docker_images_require()
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11365/1/jenkins-common.sh
File jenkins-common.sh:

https://gerrit.osmocom.org/#/c/11365/1/jenkins-common.sh@5
PS1, Line 5: docker_images_require() {
> In this commit, yes. But the next commit it will be used from all jenkins.sh 
> files. […]
On the one hand we want atomic commits, i.e. as small as makes sense. But it 
doesn't make sense to add dead code that no-one uses. Sometimes it is desirable 
to separate patches like this, but then the commit log should explicitly state 
which other change-id it prepares for.

For new functions, understanding the semantics usually requires to see how the 
callers invoke the new function. So yea, this would qualify for squashing with 
the patch that adds a caller.



--
To view, visit https://gerrit.osmocom.org/11365
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:29:16 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: jobs: testsuite.yml for all ttcn3/nplab jobs

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11370 )

Change subject: jobs: testsuite.yml for all ttcn3/nplab jobs
..


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml
File jobs/testsuite.yml:

https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml@7
PS1, Line 7:   - "{testsuite-name}{job-suffix}"
I still don't like "suffix", too general. It is the package feed name, so 
please call it "feed" or somesuch.


https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml@26
PS1, Line 26:   # nightly (overwrites the existing, manually created jobs!)
ideally this would migrate the manual jobs to being created by this file 
instead, which we want anyway.


https://gerrit.osmocom.org/#/c/11370/1/jobs/testsuite.yml@55
PS1, Line 55:   IMAGE_SUFFIX="{image-suffix}" ./jenkins.sh
same here: "IMAGE_SUFFIX" should be "PACKAGE_FEED" or something



--
To view, visit https://gerrit.osmocom.org/11370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie433925ee81a61c5788b4a6f2bc5b89c2689d251
Gerrit-Change-Number: 11370
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:24:33 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: support osmo-sip-connector with kamailio

2018-10-17 Thread Neels Hofmeyr 
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11144 )

Change subject: support osmo-sip-connector with kamailio
..


Patch Set 7:

So far, all of the osmo-dev/net happens within that subdir, and I want to keep 
it that way if possible. I would also have commented similarly on the socket 
path, but that's a user config item. Maybe also make that rundir a user config 
item, then I can't really complain anymore.

But even nicer would be to just place both socket and rundir in the same dir 
where the run.sh sits by default. No need to configure.

If it's too much effort we can merge this now, but I guess it's simple enough?


--
To view, visit https://gerrit.osmocom.org/11144
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2
Gerrit-Change-Number: 11144
Gerrit-PatchSet: 7
Gerrit-Owner: osmith 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-CC: daniel 
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:17:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing

2018-10-17 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11391


Change subject: MSC_Tests: Extend timeout in TC_mo_setup_and_nothing
..

MSC_Tests: Extend timeout in TC_mo_setup_and_nothing

The mncc guard timer in osmo-msc expires after 180 sec. This tests
terminates early and fails. Lets expand the timeout in order to give the
test a chance to pass.

Change-Id: I9f954a8807c0f0513422693ac24c647da0bfafd1
Related: OS#3599
---
M msc/MSC_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/91/11391/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 93d7c77..c0cd9d3 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1206,7 +1206,7 @@

 /* Test MO Call SETUP with no response from MNCC */
 private function f_tc_mo_setup_and_nothing(charstring id, BSC_ConnHdlrPars 
pars) runs on BSC_ConnHdlr {
-   f_init_handler(pars);
+   f_init_handler(pars, 190.0);

var CallParameters cpars := valueof(t_CallParams('12345'H, 0));

@@ -1218,7 +1218,7 @@

BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_CC_SETUP(cpars.transaction_id, 
cpars.called_party)));

-   f_expect_clear(30.0);
+   f_expect_clear(185.0);
 }
 testcase TC_mo_setup_and_nothing() runs on MTC_CT {
var BSC_ConnHdlr vc_conn;

--
To view, visit https://gerrit.osmocom.org/11391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f954a8807c0f0513422693ac24c647da0bfafd1
Gerrit-Change-Number: 11391
Gerrit-PatchSet: 1
Gerrit-Owner: dexter

Change in osmo-trx[master]: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences

2018-10-17 Thread Vadim Yanitskiy 
Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11390


Change subject: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences
..

sigProcLib: also detect both TS1 and TS2 RACH synch. sequences

According to 3GPP TS 05.02, section 5.2.7, there are three
synch. sequences for Access Bursts:

  - TS0: GSM, GMSK (default),
  - TS1: EGPRS, 8-PSK,
  - TS2: EGPRS, GMSK.

Until now, we used to detect TS0 only, let's also detect both
TS1 and TS2, which are used in extended (11-bit) RACH.

Change-Id: I838c21db29c54f1924dd478c2b34b46b70aab2cd
Related: OS#3054
---
M GSM/GSMCommon.cpp
M GSM/GSMCommon.h
M Transceiver52M/radioInterface.cpp
M Transceiver52M/sigProcLib.cpp
4 files changed, 38 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/90/11390/1

diff --git a/GSM/GSMCommon.cpp b/GSM/GSMCommon.cpp
index 8aba3be..711ca70 100644
--- a/GSM/GSMCommon.cpp
+++ b/GSM/GSMCommon.cpp
@@ -54,7 +54,10 @@

 const BitVector 
GSM::gDummyBurst("0001011011101101010010011101001000100010001110001011100010111000101011101001010001100110011100010010001001010101");

-const BitVector 
GSM::gRACHSynchSequence("01001011000110011010101000000");
+/* 3GPP TS 05.02, section 5.2.7 "Access burst (AB)", synch. sequence bits */
+const BitVector 
GSM::gRACHSynchSequenceTS0("01001011000110011010101000000");  /* 
GSM, GMSK (default) */
+const BitVector 
GSM::gRACHSynchSequenceTS1("01010100100011100010001001101");  /* 
EGPRS, 8-PSK */
+const BitVector 
GSM::gRACHSynchSequenceTS2("111000100111010101101101101110111");  /* 
EGPRS, GMSK */

 //   
|-head-||-midamble--||--data||t|
 const BitVector 
GSM::gRACHBurst("0011101001001011000110011010101000000110011111001001010110011000");
diff --git a/GSM/GSMCommon.h b/GSM/GSMCommon.h
index 8b8d5e8..f703c30 100644
--- a/GSM/GSMCommon.h
+++ b/GSM/GSMCommon.h
@@ -52,7 +52,9 @@
 extern const BitVector gDummyBurst;

 /** Random access burst synch. sequence */
-extern const BitVector gRACHSynchSequence;
+extern const BitVector gRACHSynchSequenceTS0;
+extern const BitVector gRACHSynchSequenceTS1;
+extern const BitVector gRACHSynchSequenceTS2;
 /** Random access burst synch. sequence, GSM 05.02 5.2.7 */
 extern const BitVector gRACHBurst;

diff --git a/Transceiver52M/radioInterface.cpp 
b/Transceiver52M/radioInterface.cpp
index 0f949d7..6245cfc 100644
--- a/Transceiver52M/radioInterface.cpp
+++ b/Transceiver52M/radioInterface.cpp
@@ -245,7 +245,7 @@
* Pre-allocate head room for the largest correlation size
* so we can later avoid a re-allocation and copy
* */
-  size_t head = GSM::gRACHSynchSequence.size();
+  size_t head = GSM::gRACHSynchSequenceTS0.size();

   /*
* Form receive bursts and pass up to transceiver. Use repeating
diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp
index 692fbe0..e13282f 100644
--- a/Transceiver52M/sigProcLib.cpp
+++ b/Transceiver52M/sigProcLib.cpp
@@ -132,7 +132,7 @@

 static CorrelationSequence *gMidambles[] = 
{NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL};
 static CorrelationSequence *gEdgeMidambles[] = 
{NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL};
-static CorrelationSequence *gRACHSequence = NULL;
+static CorrelationSequence *gRACHSequences[] = {NULL,NULL,NULL};
 static PulseSequence *GSMPulse1 = NULL;
 static PulseSequence *GSMPulse4 = NULL;

@@ -150,11 +150,15 @@
 delayFilters[i] = NULL;
   }

+  for (int i = 0; i < 3; i++) {
+delete gRACHSequences[i];
+gRACHSequences[i] = NULL;
+  }
+
   delete GMSKRotation1;
   delete GMSKReverseRotation1;
   delete GMSKRotation4;
   delete GMSKReverseRotation4;
-  delete gRACHSequence;
   delete GSMPulse1;
   delete GSMPulse4;
   delete dnsampler;
@@ -163,7 +167,6 @@
   GMSKRotation4 = NULL;
   GMSKReverseRotation4 = NULL;
   GMSKReverseRotation1 = NULL;
-  gRACHSequence = NULL;
   GSMPulse1 = NULL;
   GSMPulse4 = NULL;
 }
@@ -1332,7 +1335,7 @@
   return seq;
 }

-static bool generateRACHSequence(int sps)
+static bool generateRACHSequence(CorrelationSequence **seq, const BitVector 
, int sps)
 {
   bool status = true;
   float toa;
@@ -1340,13 +1343,14 @@
   signalVector *autocorr = NULL;
   signalVector *seq0 = NULL, *seq1 = NULL, *_seq1 = NULL;

-  delete gRACHSequence;
+  if (*seq != NULL)
+delete *seq;

-  seq0 = modulateBurst(gRACHSynchSequence, 0, sps, false);
+  seq0 = modulateBurst(bv, 0, sps, false);
   if (!seq0)
 return false;

-  seq1 = modulateBurst(gRACHSynchSequence.segment(0, 40), 0, sps, true);
+  seq1 = modulateBurst(bv.segment(0, 40), 0, sps, true);
   if (!seq1) {
 status = false;
 goto release;
@@ -1366,19 +1370,19 @@
 goto release;
   }

-  gRACHSequence = new CorrelationSequence;
-  gRACHSequence->sequence = _seq1;
-

Change in osmo-msc[master]: gsm_04_08_cc: Add global guard timer for MNCC

2018-10-17 Thread dexter 
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11307

to look at the new patch set (#2).

Change subject: gsm_04_08_cc: Add global guard timer for MNCC
..

gsm_04_08_cc: Add global guard timer for MNCC

The external MNCC handler may hang indefinitely in cases where the remote
end of the MNCC ceases to work properly. Add a global guard timer to
make sure the call reaches ACTIVE state.

Change-Id: I7375d1e17cd746aac4eadfe1e587e82cf1630d3d
Related: OS#3599
---
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/transaction.h
M src/libmsc/gsm_04_08_cc.c
M src/libmsc/msc_vty.c
M src/libmsc/osmo_msc.c
M tests/msc_vlr/msc_vlr_test_call.err
6 files changed, 95 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/07/11307/2
--
To view, visit https://gerrit.osmocom.org/11307
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7375d1e17cd746aac4eadfe1e587e82cf1630d3d
Gerrit-Change-Number: 11307
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

2018-10-17 Thread osmith 
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11368 )

Change subject: rename m3ua-test, sua-test to nplab-*-test
..


Patch Set 4:

> you can simply rename/move them.

Done.

NOTE: we need to modify the existing jobs to use the renamed folders after this 
is merged.


--
To view, visit https://gerrit.osmocom.org/11368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
Gerrit-Change-Number: 11368
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 17 Oct 2018 08:22:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

2018-10-17 Thread osmith 
osmith has uploaded a new patch set (#4). ( https://gerrit.osmocom.org/11368 )

Change subject: rename m3ua-test, sua-test to nplab-*-test
..

rename m3ua-test, sua-test to nplab-*-test

Allows writing a generic Jenkins Job Builder config.

Related: OS#3268
Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
---
R nplab-m3ua-test/.release
R nplab-m3ua-test/Dockerfile
R nplab-m3ua-test/Makefile
R nplab-m3ua-test/all-sgp-tests.txt
R nplab-m3ua-test/dotguile
R nplab-m3ua-test/jenkins.sh
R nplab-m3ua-test/m3ua-param-testtool.scm
R nplab-m3ua-test/osmo-stp.cfg
R nplab-sua-test/.release
R nplab-sua-test/Dockerfile
R nplab-sua-test/Makefile
R nplab-sua-test/dotguile
R nplab-sua-test/jenkins.sh
R nplab-sua-test/osmo-stp.cfg
R nplab-sua-test/some-sua-sgp-tests.txt
R nplab-sua-test/sua-param-testtool-sgp.scm
16 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/68/11368/4
--
To view, visit https://gerrit.osmocom.org/11368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iedf9a8cd9af1da674e018a08a977490520e602de
Gerrit-Change-Number: 11368
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-CC: Harald Welte

Change in osmo-bsc[master]: gsm_08_08: do not include zero length speech codec list.

2018-10-17 Thread dexter 
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11388 )

Change subject: gsm_08_08: do not include zero length speech codec list.
..


Patch Set 1:

> I am not sure we want to merge this patch. Why do you think having
 > no speech codec elements in list means "user plane interface is not
 > supported"? It can still support it but be misconfigured or on
 > purpose configured to have no codecs available?

(From my understanding the ip based user plane interface refers to RTP voice.)

I think its a matter of interpretation. The spec says that the element shall be
included if supported. So in revers this means if its missing, the ip based user
plane is not supported.

This is surely debatable. From my personal taste I think a speech codec list 
with
zero elements makes it easier to spot that something is wrong.


--
To view, visit https://gerrit.osmocom.org/11388
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07339322a71376e986a2d75b7bc1f552eafd02b5
Gerrit-Change-Number: 11388
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 17 Oct 2018 07:50:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: bssap: check for zero length speech codec lists.

2018-10-17 Thread dexter 
dexter has abandoned this change. ( https://gerrit.osmocom.org/11386 )

Change subject: bssap: check for zero length speech codec lists.
..


Abandoned

The check is redundant
--
To view, visit https://gerrit.osmocom.org/11386
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2aca205dfdf5c7de7cb48ea2b57eb54e678e12fc
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte

Jenkins build is back to normal : master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #2246

2018-10-17 Thread jenkins 
See