Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-11 Thread Keith Whyte 
Keith Whyte has posted comments on this change. ( 
https://gerrit.osmocom.org/11716 )

Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c@400
PS1, Line 400:  if (mncc->called.plan != GSM340_PLAN_UNKNOWN && 
mncc->called.plan != GSM340_PLAN_ISDN) {
> Maybe, using a switch statement would be better here?
It could also be a > greater than (1==GSM340_PLAN_ISDN) test.
I don't know. - I don't anticipate ever handling other cases.



--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Keith Whyte 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 11 Nov 2018 23:21:47 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC LCLS: add bts-loop tests

2018-11-11 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/11559 )

Change subject: BSC LCLS: add bts-loop tests
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11559
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40e786b430591899c722d99d685db26efa868508
Gerrit-Change-Number: 11559
Gerrit-PatchSet: 6
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 11 Nov 2018 21:52:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmo-sccp[master]: Make pointcode width function public

2018-11-11 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/11709 )

Change subject: Make pointcode width function public
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a9981dd2c1d78966c61a3f6b50c7c0d9b542caf
Gerrit-Change-Number: 11709
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 11 Nov 2018 21:52:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: LCLS: add bts-loop variant

2018-11-11 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/11552 )

Change subject: LCLS: add bts-loop variant
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11552
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8379f31037f2c48da69a01919701919a3066a2
Gerrit-Change-Number: 11552
Gerrit-PatchSet: 6
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Sun, 11 Nov 2018 21:52:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-11 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/11711 )

Change subject: vty: add command to show all known BSC
..


Patch Set 1:

Good points, I've made https://osmocom.org/issues/3687 to track this.


--
To view, visit https://gerrit.osmocom.org/11711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247fdce00f43072b0a2a0122b80bd40cdd9e0128
Gerrit-Change-Number: 11711
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Sun, 11 Nov 2018 21:51:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: vty: add command to show TRX selectively

2018-11-11 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11721


Change subject: vty: add command to show TRX selectively
..

vty: add command to show TRX selectively

Add following commands showing only TRX with appropriate RSL link
status:
* show trx connected
* show trx disconnected

This simplifies troubleshooting of complex setup with multiple BTS with
several TRX each.

Change-Id: I48866ce311a3e2c63235f60a497efe97bbd05a4a
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 54 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/11721/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 410cdac..cf361bf 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -1073,8 +1073,14 @@
return CMD_SUCCESS;
 }

-static void trx_dump_vty(struct vty *vty, struct gsm_bts_trx *trx)
+static void trx_dump_vty(struct vty *vty, struct gsm_bts_trx *trx, bool 
print_rsl, bool show_connected)
 {
+   if (show_connected && !trx->rsl_link)
+   return;
+
+   if (!show_connected && trx->rsl_link)
+   return;
+
vty_out(vty, "TRX %u of BTS %u is on ARFCN %u%s",
trx->nr, trx->bts->nr, trx->arfcn, VTY_NEWLINE);
vty_out(vty, "Description: %s%s",
@@ -1085,7 +1091,8 @@
trx->nominal_power - trx->max_power_red, VTY_NEWLINE);
vty_out(vty, "  NM State: ");
net_dump_nmstate(vty, >mo.nm_state);
-   vty_out(vty, "  RSL State: %s%s", trx->rsl_link? "connected" : 
"disconnected", VTY_NEWLINE);
+   if (print_rsl)
+   vty_out(vty, "  RSL State: %s%s", trx->rsl_link? "connected" : 
"disconnected", VTY_NEWLINE);
vty_out(vty, "  Baseband Transceiver NM State: ");
net_dump_nmstate(vty, >bb_transc.mo.nm_state);
if (is_ipaccess_bts(trx->bts)) {
@@ -1097,11 +1104,17 @@
}
 }

+static void trx_dump_vty_all(struct vty *vty, struct gsm_bts_trx *trx)
+{
+   trx_dump_vty(vty, trx, true, true);
+   trx_dump_vty(vty, trx, true, false);
+}
+
 static inline void print_all_trx(struct vty *vty, const struct gsm_bts *bts)
 {
uint8_t trx_nr;
for (trx_nr = 0; trx_nr < bts->num_trx; trx_nr++)
-   trx_dump_vty(vty, gsm_bts_trx_num(bts, trx_nr));
+   trx_dump_vty_all(vty, gsm_bts_trx_num(bts, trx_nr));
 }

 DEFUN(show_trx,
@@ -1131,7 +1144,8 @@
VTY_NEWLINE);
return CMD_WARNING;
}
-   trx_dump_vty(vty, gsm_bts_trx_num(bts, trx_nr));
+   trx_dump_vty_all(vty, gsm_bts_trx_num(bts, trx_nr));
+
return CMD_SUCCESS;
}
if (bts) {
@@ -1146,6 +1160,40 @@
return CMD_SUCCESS;
 }

+static inline void print_all_trx_ext(struct vty *vty, bool show_connected)
+{
+   struct gsm_network *net = gsmnet_from_vty(vty);
+   struct gsm_bts *bts = NULL;
+   uint8_t bts_nr;
+   for (bts_nr = 0; bts_nr < net->num_bts; bts_nr++) {
+   uint8_t trx_nr;
+   bts = gsm_bts_num(net, bts_nr);
+   for (trx_nr = 0; trx_nr < bts->num_trx; trx_nr++)
+   trx_dump_vty(vty, gsm_bts_trx_num(bts, trx_nr), false, 
show_connected);
+   }
+}
+
+DEFUN(show_trx_con,
+  show_trx_con_cmd,
+  "show trx connected",
+  SHOW_STR "Display information about a TRX\n"
+  "Show TRX with RSL connected\n")
+{
+   print_all_trx_ext(vty, true);
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(show_trx_dis,
+  show_trx_dis_cmd,
+  "show trx disconnected",
+  SHOW_STR "Display information about a TRX\n"
+  "Show TRX with RSL disconnected\n")
+{
+   print_all_trx_ext(vty, false);
+
+   return CMD_SUCCESS;
+}

 static void ts_dump_vty(struct vty *vty, struct gsm_bts_trx_ts *ts)
 {
@@ -4896,6 +4944,8 @@
install_element_ve(_bts_cmd);
install_element_ve(_rejected_bts_cmd);
install_element_ve(_trx_cmd);
+   install_element_ve(_trx_con_cmd);
+   install_element_ve(_trx_dis_cmd);
install_element_ve(_ts_cmd);
install_element_ve(_lchan_cmd);
install_element_ve(_lchan_summary_cmd);

--
To view, visit https://gerrit.osmocom.org/11721
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48866ce311a3e2c63235f60a497efe97bbd05a4a
Gerrit-Change-Number: 11721
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in libosmocore[master]: Streamline glibc version check

2018-11-11 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11719


Change subject: Streamline glibc version check
..

Streamline glibc version check

* use macro for version check
* report glibc version upon detection

Change-Id: Ia54f0b7a861f955be65bb0cf06eb10af9372d062
---
M src/gsm/gsm_utils.c
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/19/11719/1

diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c
index 7e6c794..be35cd4 100644
--- a/src/gsm/gsm_utils.c
+++ b/src/gsm/gsm_utils.c
@@ -95,11 +95,12 @@
 #include 
 #include 
 #include 
+#include 

 #include "../../config.h"

-/* FIXME: this can be removed once we bump glibc requirements to 2.25: */
-#if defined(__GLIBC__) && (__GLIBC__ >= 2) && (__GLIBC_MINOR__ >= 25)
+/* FIXME: this can be removed once we bump glibc requirements to 2.25:*/
+#if __GNUC_PREREQ (2,25)
 #include 
 #elif HAVE_DECL_SYS_GETRANDOM
 #include 
@@ -131,6 +132,8 @@
if (!gnutls_check_version("3.3.0"))
gnutls_global_deinit();
 }
+#else
+#pragma message ("glibc " OSMO_STRINGIFY_VAL(__GLIBC__) "." 
OSMO_STRINGIFY_VAL(__GLIBC_MINOR__) " random detected")
 #endif

 /* ETSI GSM 03.38 6.2.1 and 6.2.1.1 default alphabet

--
To view, visit https://gerrit.osmocom.org/11719
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia54f0b7a861f955be65bb0cf06eb10af9372d062
Gerrit-Change-Number: 11719
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in libosmocore[master]: Automatically disable GnuTLS fallback

2018-11-11 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11720


Change subject: Automatically disable GnuTLS fallback
..

Automatically disable GnuTLS fallback

Disable GnuTLS fallback if sufficient glibc version detected. Previously
GnuTLS fallback was used regardless of getrandom() availability in
glibc. Fix this by automatically disabling it when not needed. This does
not affect the ability to manually disable it unconditionally.

Change-Id: Ibe2117afc050261668a4d5a590044aabcd08aefe
---
M src/gsm/gsm_utils.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/11720/1

diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c
index be35cd4..7e1f487 100644
--- a/src/gsm/gsm_utils.c
+++ b/src/gsm/gsm_utils.c
@@ -102,6 +102,7 @@
 /* FIXME: this can be removed once we bump glibc requirements to 2.25:*/
 #if __GNUC_PREREQ (2,25)
 #include 
+#undef USE_GNUTLS
 #elif HAVE_DECL_SYS_GETRANDOM
 #include 
 #ifndef GRND_NONBLOCK

--
To view, visit https://gerrit.osmocom.org/11720
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe2117afc050261668a4d5a590044aabcd08aefe
Gerrit-Change-Number: 11720
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mo_sms for MO SMS over GSUP

2018-11-11 Thread Vadim Yanitskiy 
Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11718


Change subject: MSC_Tests.ttcn: introduce TC_gsup_mo_sms for MO SMS over GSUP
..

MSC_Tests.ttcn: introduce TC_gsup_mo_sms for MO SMS over GSUP

Change-Id: Id14bbd8bd51558cdacefea0fe042769cd69ed5c8
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 64 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/18/11718/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index c0cd9d3..4db5b29 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2022,6 +2022,67 @@
f_vty_config2(MSCVTY, { "smpp", "esme msc_tester"}, "no default-route");
 }

+/* Test MO-SMS from MS/BTS/BSC towards HLR (via GSUP) */
+private function f_tc_gsup_mo_sms(charstring id, BSC_ConnHdlrPars pars)
+runs on BSC_ConnHdlr {
+   var SmsParameters spars := valueof(t_SmsPars);
+   var GSUP_PDU gsup_msg_rx;
+
+   f_init_handler(pars);
+
+   /* We need to inspect GSUP activity */
+   f_create_gsup_expect(hex2str(g_pars.imsi));
+
+   /* Perform location update */
+   f_perform_lu();
+
+   /* Send CM Service Request for SMS */
+   f_establish_fully(EST_TYPE_MO_SMS);
+
+   var template GSUP_PDU mo_forwardSM := tr_GSUP_MO_FORWARD_SM_REQ(
+   imsi := g_pars.imsi,
+   sid := ?, state := ?,
+   sm_rp_mr := spars.rp.msg_ref,
+   /* FIXME: extract SM-RP-DA from spars.rp.dest */
+   sm_rp_da := tr_GSUP_SM_RP_DA_SMSC_ADDR(?),
+   sm_rp_oa := tr_GSUP_SM_RP_OA_NULL,
+   /* FIXME: define coding rules for SmsParametersTp, and use 
'decmatch spars.tp' */
+   sm_rp_ui := '052305002143F500'O
+   );
+
+   /* Submit an SMS on DTAP and expect MO-forwardSM-Req on GSUP */
+   f_mo_sms_submit(spars);
+   alt {
+   [] GSUP.receive(mo_forwardSM) -> value gsup_msg_rx {
+   log("RX MO-forwardSM-Req");
+   log(gsup_msg_rx);
+   setverdict(pass);
+   }
+   [] GSUP.receive {
+   log("RX unexpected GSUP message");
+   setverdict(fail);
+   mtc.stop;
+   }
+   }
+
+   /* Trigger RP-ACK by sending MO-forwardSM-Res */
+   GSUP.send(valueof(ts_GSUP_MO_FORWARD_SM_RES(
+   imsi := g_pars.imsi,
+   sid := gsup_msg_rx.ies[1].val.session_id,
+   state := gsup_msg_rx.ies[2].val.session_state,
+   sm_rp_mr := gsup_msg_rx.ies[3].val.sm_rp_mr)));
+   /* Expect RP-ACK on DTAP */
+   f_mo_sms_wait_rp_ack(spars);
+
+   f_expect_clear();
+}
+testcase TC_gsup_mo_sms() runs on MTC_CT {
+   var BSC_ConnHdlr vc_conn;
+   f_init();
+   vc_conn := f_start_handler(refers(f_tc_gsup_mo_sms), 88);
+   vc_conn.done;
+}
+
 /* convert GSM L3 TON to SMPP_TON enum */
 function f_sm_ton_from_gsm(BIT3 ton) return SMPP_TON {
select (ton) {
@@ -2777,6 +2838,8 @@
execute( TC_smpp_mo_sms() );
execute( TC_smpp_mt_sms() );

+   execute( TC_gsup_mo_sms() );
+
execute( TC_lu_and_mo_ussd_single_request() );
execute( TC_lu_and_mt_ussd_notification() );
execute( TC_lu_and_mo_ussd_during_mt_call() );
diff --git a/msc/expected-results.xml b/msc/expected-results.xml
index 8d9180f..f8e7eb3 100644
--- a/msc/expected-results.xml
+++ b/msc/expected-results.xml
@@ -63,6 +63,7 @@
   
   
   
+  
   
   
   

--
To view, visit https://gerrit.osmocom.org/11718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id14bbd8bd51558cdacefea0fe042769cd69ed5c8
Gerrit-Change-Number: 11718
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler.ttcn: split up f_mo_sms() into two functions

2018-11-11 Thread Vadim Yanitskiy 
Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11717


Change subject: BSC_ConnectionHandler.ttcn: split up f_mo_sms() into two 
functions
..

BSC_ConnectionHandler.ttcn: split up f_mo_sms() into two functions

This would allow to submit an SMS message using f_mo_sms_submit()
and wait for RP-ACK using f_mo_sms_wait_rp_ack() separately in the
follow-up changes for SMS over GSUP.

Change-Id: I5b35206286ae8add8b5bd34b0ab41ba7862c28e4
---
M msc/BSC_ConnectionHandler.ttcn
1 file changed, 28 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/17/11717/1

diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index bf7a6d2..96f522c 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -806,17 +806,13 @@
}
 }

-/* Submit a MO-SMS over an already existing (and authenticated, ...) DTAP 
connection */
-function f_mo_sms(inout SmsParameters spars)
+/* Submit a MO-SMS over an already existing DTAP connection */
+function f_mo_sms_submit(inout SmsParameters spars)
 runs on BSC_ConnHdlr {
var template (value) TPDU_RP_DATA_MS_SGSN tp_mo;
var template (value) RPDU_MS_SGSN rp_mo;
var template (value) PDU_ML3_MS_NW l3_mo;

-   var template TPDU_RP_DATA_SGSN_MS tp_mt;
-   var template RPDU_SGSN_MS rp_mt;
-   var template PDU_ML3_NW_MS l3_mt;
-
var default d := activate(as_other_sms());

/* just in case this is routed to SMPP.. */
@@ -830,6 +826,24 @@
/* receive CP-ACK for CP-DATA above */
BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_SMS(spars.tid, c_TIF_REPL, 
tr_CP_ACK_MT), spars.dlci));

+   deactivate(d);
+   setverdict(pass);
+}
+
+/* Wait RP-ACK for MO-SMS on an already existing DTAP connection */
+function f_mo_sms_wait_rp_ack(inout SmsParameters spars)
+runs on BSC_ConnHdlr {
+   var template (value) PDU_ML3_MS_NW l3_mo;
+
+   var template TPDU_RP_DATA_SGSN_MS tp_mt;
+   var template RPDU_SGSN_MS rp_mt;
+   var template PDU_ML3_NW_MS l3_mt;
+
+   var default d := activate(as_other_sms());
+
+   /* just in case this is routed to SMPP.. */
+   f_create_smpp_expect(hex2str(spars.tp.da.tP_DA_NoPad.tP_DAValue));
+
if (ispresent(spars.exp_rp_err)) {
/* expect an RP-ERROR message from MSC with given cause */
rp_mt := tr_RP_ERROR_MT(spars.rp.msg_ref, spars.exp_rp_err);
@@ -847,10 +861,18 @@
l3_mo := ts_ML3_MO_SMS(spars.tid, c_TIF_ORIG, ts_CP_ACK_MO);
BSSAP.send(ts_PDU_DTAP_MO(l3_mo, spars.dlci, true));
}
+
deactivate(d);
setverdict(pass);
 }

+/* Submit and wait a MO-SMS over an already existing (and authenticated, ...) 
DTAP connection */
+function f_mo_sms(inout SmsParameters spars)
+runs on BSC_ConnHdlr {
+   f_mo_sms_submit(spars);
+   f_mo_sms_wait_rp_ack(spars);
+}
+
 /* receive MT-SMS delivered from the MSC/SMSC over an already existing DTAP 
connection */
 function f_mt_sms(inout SmsParameters spars)
 runs on BSC_ConnHdlr {

--
To view, visit https://gerrit.osmocom.org/11717
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b35206286ae8add8b5bd34b0ab41ba7862c28e4
Gerrit-Change-Number: 11717
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #304

2018-11-11 Thread jenkins 
See 


--
[...truncated 3.81 KB...]
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking how to run the C preprocessor... gcc -E
checking for a BSD-compatible

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-11 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11716 )

Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c@400
PS1, Line 400:  if (mncc->called.plan != GSM340_PLAN_UNKNOWN && 
mncc->called.plan != GSM340_PLAN_ISDN) {
Maybe, using a switch statement would be better here?



--
To view, visit https://gerrit.osmocom.org/11716
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 11 Nov 2018 14:04:29 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: ansible: Wrap distro version number as string for ansible

2018-11-11 Thread Holger Freyther 
Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/11648 )

Change subject: ansible: Wrap distro version number as string for ansible
..


Patch Set 2:

> why is this needed? which version of ansible are you using?

ansible 2.4.6.0
  config file = None
  configured module search path = [ 
'/usr/local/share/py36-ansible/plugins/modules']
  ansible python module location = 
/usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.7 (default, Oct 30 2018, 23:02:44) [GCC 4.2.1 Compatible 
FreeBSD Clang 3.4.1 (tags/RELEASE_34/dot1-final 208032)]


Error summary (full error below):
AnsibleUnsafeText $OP int

The examples I found also compared it as string and it seems to work for the 
debian9 and limesuite case.


Full error:
fatal: [build2-deb9build-ansible]: FAILED! => {"failed": true, "msg": "The 
conditional check 'ansible_distribution == 'Debian' and 
ansible_distribution_version >= 9' failed. The error was: Unexpected templating 
type error occurred on ({% if ansible_distribution == 'Debian' and 
ansible_distribution_version >= 9 %} True {% else %} False {% endif %}): '>=' 
not supported between instances of 'AnsibleUnsafeText' and 'int'\n\nThe error 
appears to have been in 
'/root/git/osmo-ci/ansible/roles/osmocom-jenkins-slave/tasks/debian.yml': line 
35, column 3, but may\nbe elsewhere in the file depending on the exact syntax 
problem.\n\nThe offending line appears to be:\n\n\n- name: install java for 
stretch or later\n  ^ here\n"}


--
To view, visit https://gerrit.osmocom.org/11648
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58591ee37c6ec1479778c3f90ed8004a7e2adf1e
Gerrit-Change-Number: 11648
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sun, 11 Nov 2018 11:36:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: No