Change in ...libosmocore[master]: vty: command.c: Fix is_cmd_ambiguous() returning always 0

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14422 to look at the new patch set (#2). Change subject: vty: command.c: Fix is_cmd_ambiguous() returning always 0

Change in ...libosmocore[master]: vty: command.c: Fix is_cmd_ambiguous() returning always 0

2019-06-11 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14422 Change subject: vty: command.c: Fix is_cmd_ambiguous() returning always 0 .. vty: command.c: Fix is_cmd_ambiguous() returning

Change in ...libosmocore[master]: vty: command.c: Get rid of huge indentation block

2019-06-11 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14421 Change subject: vty: command.c: Get rid of huge indentation block .. vty: command.c: Get rid of huge indentation block Huge

Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_PortType.ttcn: clarify and unify timeout messages

2019-06-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14420 Change subject: library/L1CTL_PortType.ttcn: clarify and unify timeout messages .. library/L1CTL_PortType.ttcn: clarify and

Change in ...osmo-ttcn3-hacks[master]: bts: more lapdm tests

2019-06-11 Thread Hoernchen
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14419 to look at the new patch set (#2). Change subject: bts: more lapdm tests .. bts: more lapdm

Change in ...osmo-ttcn3-hacks[master]: bts: more lapdm tests

2019-06-11 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14419 Change subject: bts: more lapdm tests .. bts: more lapdm tests Change-Id: I0db71de5f600022935f47573aa919990de4bfec0 --- M

Change in ...osmo-ttcn3-hacks[master]: BTS: add some dynamic power control tests

2019-06-11 Thread Hoernchen
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14417 to look at the new patch set (#3). Change subject: BTS: add some dynamic power control tests ..

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-11 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14267 ) Change subject: osmo-remsim-client: add systemd service script template and etc/default config .. Patch Set 1: (1 comment)

Change in ...osmo-ttcn3-hacks[master]: bscnat: Introduce test TC_ctrl_location

2019-06-11 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14414 ) Change subject: bscnat: Introduce test TC_ctrl_location .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14267 ) Change subject: osmo-remsim-client: add systemd service script template and etc/default config .. Patch Set 1: assigning to

Change in ...osmo-ttcn3-hacks[master]: hlr: add Check IMEI tests

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 ) Change subject: hlr: add Check IMEI tests .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 ...

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989 ) Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 message for normal detach .. Patch Set

Change in ...osmo-ttcn3-hacks[master]: hlr: add f_vty_subscr_show_nomatch()

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14401 ) Change subject: hlr: add f_vty_subscr_show_nomatch() .. Patch Set 2: Code-Review+1 (1 comment)

Change in ...docker-playground[master]: bscnat: Bind bsc-nat CTRL on 0.0.0.0

2019-06-11 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14415 ) Change subject: bscnat: Bind bsc-nat CTRL on 0.0.0.0 .. bscnat: Bind bsc-nat CTRL on 0.0.0.0 Other tests already do

Change in ...osmo-ttcn3-hacks[master]: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 ...

2019-06-11 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989 ) Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 message for normal detach ..

Change in ...osmo-ttcn3-hacks[master]: BTS: add some dynamic power control tests

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14417 ) Change subject: BTS: add some dynamic power control tests .. Patch Set 2: (6 comments)

Change in ...docker-playground[master]: bscnat: Bind bsc-nat CTRL on 0.0.0.0

2019-06-11 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14415 ) Change subject: bscnat: Bind bsc-nat CTRL on 0.0.0.0 .. Patch Set 1: Verified+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14418 to look at the new patch set (#7). Change subject: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

Change in ...osmo-ttcn3-hacks[master]: bsc: Introduce test TC_ctrl_location

2019-06-11 Thread pespin
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14407 to look at the new patch set (#4). Change subject: bsc: Introduce test TC_ctrl_location

Change in ...docker-playground[master]: bscnat: Bind bsc-nat CTRL on 0.0.0.0

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14415 ) Change subject: bscnat: Bind bsc-nat CTRL on 0.0.0.0 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: bscnat: Introduce test TC_ctrl_location

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14414 ) Change subject: bscnat: Introduce test TC_ctrl_location .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: bscnat: Add function to run actions on test per BSC component

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14413 ) Change subject: bscnat: Add function to run actions on test per BSC component .. Patch Set 2: Code-Review+2 -- To view,

Change in ...osmo-remsim[master]: osmo-remsim-client: add systemd service script template and etc/defau...

2019-06-11 Thread roh
roh has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14267 ) Change subject: osmo-remsim-client: add systemd service script template and etc/default config .. Patch Set 1: (1 comment)

Change in ...osmo-trx[master]: Add VTY commands to set error ctr thresholds

2019-06-11 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14168 ) Change subject: Add VTY commands to set error ctr thresholds .. Add VTY commands to set error ctr thresholds osmo-trx will

Change in ...osmo-trx[master]: Add VTY commands to set error ctr thresholds

2019-06-11 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14168 ) Change subject: Add VTY commands to set error ctr thresholds .. Patch Set 3: Code-Review+2 +1+1 = +2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: bscnat: Refactor BSC_MS side code to allow different actions per test

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14411 ) Change subject: bscnat: Refactor BSC_MS side code to allow different actions per test .. Patch Set 2: Code-Review+2 -- To

Change in ...osmo-ttcn3-hacks[master]: bscnat: Refactor MSC side code to allow different actions per test

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14412 ) Change subject: bscnat: Refactor MSC side code to allow different actions per test .. Patch Set 2: Code-Review+2 -- To

Change in ...osmo-ttcn3-hacks[master]: lib/RAN: Introduce CTRL_CLIENT port to access CTRL muxed in RAN IPA conn

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14406 ) Change subject: lib/RAN: Introduce CTRL_CLIENT port to access CTRL muxed in RAN IPA conn .. Patch Set 3: Code-Review+2 --

Change in ...osmo-ttcn3-hacks[master]: bsc: Fix trailing whitespace

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14408 ) Change subject: bsc: Fix trailing whitespace .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: lib/CTRL: Improve and add more helper templates and functions

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14409 ) Change subject: lib/CTRL: Improve and add more helper templates and functions .. Patch Set 2: Code-Review+2 -- To view,

Change in ...osmo-ttcn3-hacks[master]: bscnat: Move generic code to wait for test into its own function

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14410 ) Change subject: bscnat: Move generic code to wait for test into its own function .. Patch Set 2: Code-Review+2 -- To view,

Change in ...osmo-ttcn3-hacks[master]: bsc: Introduce test TC_ctrl_location

2019-06-11 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14407 ) Change subject: bsc: Introduce test TC_ctrl_location .. Patch Set 3: (1 comment)

Change in ...osmo-trx[master]: Add VTY commands to set error ctr thresholds

2019-06-11 Thread roh
roh has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14168 ) Change subject: Add VTY commands to set error ctr thresholds .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14418 to look at the new patch set (#6). Change subject: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

Change in ...osmo-ttcn3-hacks[master]: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14418 to look at the new patch set (#5). Change subject: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

Change in ...osmo-ttcn3-hacks[master]: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14418 to look at the new patch set (#4). Change subject: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

Change in ...osmo-ttcn3-hacks[master]: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14418 to look at the new patch set (#3). Change subject: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

Change in ...osmo-ttcn3-hacks[master]: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14418 to look at the new patch set (#2). Change subject: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

Change in ...osmo-ttcn3-hacks[master]: bscnat: Add function to run actions on test per BSC component

2019-06-11 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14413 ) Change subject: bscnat: Add function to run actions on test per BSC component .. Patch Set 2: This change is ready for

Change in ...osmo-ttcn3-hacks[master]: bscnat: Introduce test TC_ctrl_location

2019-06-11 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14414 ) Change subject: bscnat: Introduce test TC_ctrl_location .. Patch Set 2: This change is ready for review. -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: bsc: Fix trailing whitespace

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14408 to look at the new patch set (#2). Change subject: bsc: Fix trailing whitespace .. bsc: Fix

Change in ...osmo-ttcn3-hacks[master]: lib/RAN: Introduce CTRL_CLIENT port to access CTRL muxed in RAN IPA conn

2019-06-11 Thread pespin
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14406 to look at the new patch set (#3). Change subject: lib/RAN: Introduce CTRL_CLIENT port to access CTRL muxed in RAN IPA conn

Change in ...osmo-ttcn3-hacks[master]: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define

2019-06-11 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14418 Change subject: lib/IPA_Emulation: Build IPA_CTRL conditionally based on define .. lib/IPA_Emulation: Build IPA_CTRL

Change in ...osmo-ttcn3-hacks[master]: lib/CTRL: Improve and add more helper templates and functions

2019-06-11 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14409 to look at the new patch set (#2). Change subject: lib/CTRL: Improve and add more helper templates and functions

Change in ...osmo-ttcn3-hacks[master]: lib/CTRL: Add more helper templates and functions

2019-06-11 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14409 ) Change subject: lib/CTRL: Add more helper templates and functions .. Patch Set 1: Code-Review-1 Fix in progress -- To

Change in ...osmo-ttcn3-hacks[master]: BTS: add some dynamic power control tests

2019-06-11 Thread Hoernchen
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14417 to look at the new patch set (#2). Change subject: BTS: add some dynamic power control tests ..

Change in ...osmo-ttcn3-hacks[master]: BTS: add some dynamic power control tests

2019-06-11 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14417 Change subject: BTS: add some dynamic power control tests .. BTS: add some dynamic power control tests Change-Id:

Change in ...osmo-ttcn3-hacks[master]: BTS: add some dynamic power control tests

2019-06-11 Thread Hoernchen
Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14416 ) Change subject: BTS: add some dynamic power control tests .. Abandoned i broke my git -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: BTS: add some dynamic power control tests

2019-06-11 Thread Hoernchen
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14416 to look at the new patch set (#2). Change subject: BTS: add some dynamic power control tests ..

Change in ...osmo-ttcn3-hacks[master]: BTS: add some dynamic power control tests

2019-06-11 Thread Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14416 Change subject: BTS: add some dynamic power control tests .. BTS: add some dynamic power control tests Change-Id:

Change in ...docker-playground[master]: bscnat: Bind bsc-nat CTRL on 0.0.0.0

2019-06-11 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14415 Change subject: bscnat: Bind bsc-nat CTRL on 0.0.0.0 .. bscnat: Bind bsc-nat CTRL on 0.0.0.0 Other tests already do it, and

Change in ...osmo-hlr[master]: rx_check_imei_req(): fix IMEI bounds checking

2019-06-11 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14399 ) Change subject: rx_check_imei_req(): fix IMEI bounds checking .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: hlr: add Check IMEI tests

2019-06-11 Thread osmith
Hello fixeria, pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 to look at the new patch set (#3). Change subject: hlr: add Check IMEI tests

Change in ...osmo-ttcn3-hacks[master]: hlr: add f_vty_subscr_show_nomatch()

2019-06-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14401 ) Change subject: hlr: add f_vty_subscr_show_nomatch() .. Patch Set 2: (1 comment)

Change in ...osmo-ttcn3-hacks[master]: hlr: add Check IMEI tests

2019-06-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 ) Change subject: hlr: add Check IMEI tests .. Patch Set 2: (3 comments)

Change in ...osmo-ttcn3-hacks[master]: hlr: add f_vty_subscr_show_nomatch()

2019-06-11 Thread osmith
Hello fixeria, pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14401 to look at the new patch set (#2). Change subject: hlr: add f_vty_subscr_show_nomatch()

Change in ...osmo-ttcn3-hacks[master]: hlr: add Check IMEI tests

2019-06-11 Thread osmith
Hello fixeria, pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 to look at the new patch set (#2). Change subject: hlr: add Check IMEI tests

Change in ...osmo-hlr[master]: rx_check_imei_req(): fix IMEI bounds checking

2019-06-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14399 ) Change subject: rx_check_imei_req(): fix IMEI bounds checking .. Patch Set 3: (1 comment)

Change in ...osmo-hlr[master]: rx_check_imei_req(): fix IMEI bounds checking

2019-06-11 Thread osmith
Hello fixeria, pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14399 to look at the new patch set (#3). Change subject: rx_check_imei_req(): fix IMEI bounds checking