Build failure of network:osmocom:nightly/libosmo-netif in Debian_9.0/armv7l

2019-09-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_9.0/armv7l Package network:osmocom:nightly/libosmo-netif failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-09-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Build failure of network:osmocom:nightly/libosmo-netif in Debian_8.0/x86_64

2019-09-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_8.0/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-09-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: introduce TC_ta_init_prach to test initial TA

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15410 ) Change subject: PCU_Tests_RAW.ttcn: introduce TC_ta_init_prach to test initial TA .. Patch Set 9: This change is ready for

Change in ...osmo-ttcn3-hacks[master]: library/PCUIF_CodecPort.ttcn: strip padding bytes from PCUIF_data

2019-09-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15571 Change subject: library/PCUIF_CodecPort.ttcn: strip padding bytes from PCUIF_data .. library/PCUIF_CodecPort.ttcn: strip

Change in ...osmo-ttcn3-hacks[master]: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases

2019-09-18 Thread fixeria
Hello pespin, laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430 to look at the new patch set (#8). Change subject: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases

Change in ...osmo-ttcn3-hacks[master]: PCU_Tests_RAW.ttcn: add test case for UL link quality adaptation

2019-09-18 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15526 to look at the new patch set (#2). Change subject: PCU_Tests_RAW.ttcn: add test case for UL link quality adaptation

Change in ...osmo-bts[master]: bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15537 ) Change subject: bts-trx: Change super verbose IDLE ind not-supported line to DEBUG .. Patch Set 1: Code-Review+2 Huh, so OsmoTRX

Change in ...osmo-trx[master]: radioDevice: Introduce getTxGain() API

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15520 ) Change subject: radioDevice: Introduce getTxGain() API .. radioDevice: Introduce getTxGain() API It will be used in later

Change in ...osmo-trx[master]: radioInterface{Multi, Resamp}: Fix successful writeSamples() masking u...

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15523 ) Change subject: radioInterface{Multi,Resamp}: Fix successful writeSamples() masking underrun from readSamples() .. Patch Set 1:

Change in ...osmo-trx[master]: radioInterface{Multi, Resamp}: Fix successful writeSamples() masking u...

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15523 ) Change subject: radioInterface{Multi,Resamp}: Fix successful writeSamples() masking underrun from readSamples() ..

Change in ...osmo-trx[master]: UHDDevice: Drop unneeded MULTI_ARFCN checks

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15522 ) Change subject: UHDDevice: Drop unneeded MULTI_ARFCN checks .. UHDDevice: Drop unneeded MULTI_ARFCN checks After previous

Change in ...osmo-trx[master]: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15521 ) Change subject: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls .. radioInterfaceMulti: Override setTxGain()

Change in ...osmo-trx[master]: UHDDevice: Drop unneeded MULTI_ARFCN checks

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15522 ) Change subject: UHDDevice: Drop unneeded MULTI_ARFCN checks .. Patch Set 1: +1+1=+2 -- To view, visit

Change in ...osmo-trx[master]: UHDDevice: Drop unneeded MULTI_ARFCN checks

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15522 ) Change subject: UHDDevice: Drop unneeded MULTI_ARFCN checks .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 ) Change subject: configure.ac: set C and C++ dialects .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-trx[master]: Move multi-ARFCN chan amount modification from UHDDevice to parent class

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15542 ) Change subject: Move multi-ARFCN chan amount modification from UHDDevice to parent class .. Patch Set 2: Code-Review+1 -- To

Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 ) Change subject: radioInterface: Mark setRxGain as virtual .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-trx[master]: Transceiver: Fixed copying of history into and from channelizer buffer.

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15413 ) Change subject: Transceiver: Fixed copying of history into and from channelizer buffer. .. Patch Set 2: Code-Review+1 -- To view,

Change in ...osmo-trx[master]: radioInterface: Atomically fetch and change underrun variable

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15524 ) Change subject: radioInterface: Atomically fetch and change underrun variable .. Patch Set 1: (1 comment)

Change in ...osmo-ttcn3-hacks[master]: Revert "MGCP: fix pattern warning"

2019-09-18 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570 ) Change subject: Revert "MGCP: fix pattern warning" .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: Revert "MGCP: fix pattern warning"

2019-09-18 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570 ) Change subject: Revert "MGCP: fix pattern warning" .. Revert "MGCP: fix pattern warning" For me this change causes

Change in ...osmo-ttcn3-hacks[master]: Revert "MGCP: fix pattern warning"

2019-09-18 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570 Change subject: Revert "MGCP: fix pattern warning" .. Revert "MGCP: fix pattern warning" For me this change causes MGCP

Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

2019-09-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of

Change in ...osmo-trx[master]: UHDDevice: Drop unneeded MULTI_ARFCN checks

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15522 ) Change subject: UHDDevice: Drop unneeded MULTI_ARFCN checks .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-trx[master]: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15521 ) Change subject: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls .. Patch Set 1: Code-Review+1 (1 comment)

Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64

2019-09-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of

Change in ...osmo-trx[master]: radioDevice: Introduce getTxGain() API

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15520 ) Change subject: radioDevice: Introduce getTxGain() API .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...libosmocore[master]: tdef_test: verify case where osmo_tdef_set returns -EEXIST

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15563 ) Change subject: tdef_test: verify case where osmo_tdef_set returns -EEXIST .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: tdef: Introduce min_val and max_val fields

2019-09-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15546 ) Change subject: tdef: Introduce min_val and max_val fields .. Patch Set 3: (2 comments)

Change in ...osmo-gsm-tester[master]: suite_test: suite requires the fake trial to implement get_run_dir()

2019-09-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15569 Change subject: suite_test: suite requires the fake trial to implement get_run_dir() .. suite_test: suite requires the fake

Change in ...osmocom-bb[master]: host/trxcon: add optional GSMTAP frame logging support

2019-09-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15568 Change subject: host/trxcon: add optional GSMTAP frame logging support .. host/trxcon: add optional GSMTAP frame logging support

Change in ...osmo-gsm-tester[master]: Add a per-test log file

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15567 ) Change subject: Add a per-test log file .. Patch Set 1: Tested manually it works fine with a suite with several tests. --

Change in ...osmo-gsm-tester[master]: Add a per-test log file

2019-09-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/15567 Change subject: Add a per-test log file .. Add a per-test log file This way there's no need to go over hours of logging in the

Change in ...libosmocore[master]: tdef: Introduce min_val and max_val fields

2019-09-18 Thread pespin
Hello fixeria, neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15546 to look at the new patch set (#3). Change subject: tdef: Introduce min_val and max_val fields

Change in ...osmo-trx[master]: radioInterface: Remove unusued getRxGain()

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15519 ) Change subject: radioInterface: Remove unusued getRxGain() .. radioInterface: Remove unusued getRxGain() Only the

Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

2019-09-18 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15560 to look at the new patch set (#5). Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs

Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

2019-09-18 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15560 to look at the new patch set (#4). Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs

Change in ...osmo-ci[master]: gerrit, master builds: concurrent OsmoPCU builds

2019-09-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/15566 Change subject: gerrit, master builds: concurrent OsmoPCU builds .. gerrit, master builds: concurrent OsmoPCU builds Re-enable

Change in ...osmo-trx[master]: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15521 ) Change subject: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls .. Patch Set 1: > Patch Set 1: > > I don't know how

Change in ...osmo-pcu[master]: tests/app_info: fix compiling with older g++

2019-09-18 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15564 ) Change subject: tests/app_info: fix compiling with older g++ .. tests/app_info: fix compiling with older g++ Do not use

Change in ...osmo-trx[master]: radioInterface: Remove unusued getRxGain()

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15519 ) Change subject: radioInterface: Remove unusued getRxGain() .. Patch Set 1: Code-Review+2 To simplify code. If it's not used, it's

Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 ) Change subject: configure.ac: set C and C++ dialects .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-pcu[master]: tests/app_info: fix compiling with older g++

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15564 ) Change subject: tests/app_info: fix compiling with older g++ .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

2019-09-18 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15560 ) Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs .. Patch Set 3: (1 comment) I hope this

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-18 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: > I still don't get why this has any mention of PCU in it. Well, I'm

Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

2019-09-18 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15317 ) Change subject: fix error on BSSMAP Cipher Mode Complete L3 msg IE .. fix error on BSSMAP Cipher Mode Complete L3 msg IE When

Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

2019-09-18 Thread neels
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15317 to look at the new patch set (#8). Change subject: fix error on BSSMAP Cipher Mode Complete L3 msg IE

Change in ...osmo-trx[master]: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls

2019-09-18 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15521 ) Change subject: radioInterfaceMulti: Override setTxGain() to avoid chan!=0 calls .. Patch Set 1: I don't know how the inheritance

Change in ...osmo-trx[master]: radioDevice: Introduce getTxGain() API

2019-09-18 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15520 ) Change subject: radioDevice: Introduce getTxGain() API .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual

2019-09-18 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 ) Change subject: radioInterface: Mark setRxGain as virtual .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-trx[master]: radioInterface: Remove unusued getRxGain()

2019-09-18 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15519 ) Change subject: radioInterface: Remove unusued getRxGain() .. Patch Set 1: Code-Review+1 I don't know why you want to remove it, but

Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects

2019-09-18 Thread osmith
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 ) Change subject: configure.ac: set C and C++ dialects .. configure.ac: set C and C++ dialects Make sure that the compiler always

Change in ...osmo-pcu[master]: configure.ac: set C and C++ dialects

2019-09-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15565 Change subject: configure.ac: set C and C++ dialects .. configure.ac: set C and C++ dialects Make sure that the compiler always

Change in ...osmo-pcu[master]: tests/app_info: fix compiling with older g++

2019-09-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15564 Change subject: tests/app_info: fix compiling with older g++ .. tests/app_info: fix compiling with older g++ Do not use C++11

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: I still don't get why this has any mention of PCU in it. the L1 SAPI

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out()

2019-09-18 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15489 ) Change subject: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out() .. osmo-bts-trx/scheduler: fix: check rc of

Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out()

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15489 ) Change subject: osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: tdef: Introduce min_val and max_val fields

2019-09-18 Thread pespin
Hello fixeria, neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15546 to look at the new patch set (#2). Change subject: tdef: Introduce min_val and max_val fields

Change in ...libosmocore[master]: tdef_test: verify case where osmo_tdef_set returns -EEXIST

2019-09-18 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15563 Change subject: tdef_test: verify case where osmo_tdef_set returns -EEXIST .. tdef_test: verify case where osmo_tdef_set returns

Change in ...libosmocore[master]: logging.h: add L1 SAPI related context and filter

2019-09-18 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15538 ) Change subject: logging.h: add L1 SAPI related context and filter .. logging.h: add L1 SAPI related context and filter

Change in ...osmo-trx[master]: radioInterfaceMulti: Check equals zero explicitly

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15515 ) Change subject: radioInterfaceMulti: Check equals zero explicitly .. radioInterfaceMulti: Check equals zero explicitly It's

Change in ...osmo-trx[master]: USRPDevice: Fix setRxGain return on error and getRxGain() returning a...

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15516 ) Change subject: USRPDevice: Fix setRxGain return on error and getRxGain() returning always 0 .. USRPDevice: Fix setRxGain

Change in ...osmo-trx[master]: USRPDevice: Return previous txGain if setting value failed

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15517 ) Change subject: USRPDevice: Return previous txGain if setting value failed .. USRPDevice: Return previous txGain if setting

Change in ...osmo-trx[master]: radioInterface: Rename mRadio to mDevice

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15514 ) Change subject: radioInterface: Rename mRadio to mDevice .. radioInterface: Rename mRadio to mDevice Previous naming is

Change in ...osmo-trx[master]: LMSDevice: Return previous txGain/rxGain if setting value failed

2019-09-18 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15518 ) Change subject: LMSDevice: Return previous txGain/rxGain if setting value failed .. LMSDevice: Return previous txGain/rxGain

Change in ...libosmocore[master]: tdef: Introduce min_val and max_val fields

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15546 ) Change subject: tdef: Introduce min_val and max_val fields .. Patch Set 1: (1 comment)

Change in ...osmo-trx[master]: radioInterface: Rename mRadio to mDevice

2019-09-18 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15514 ) Change subject: radioInterface: Rename mRadio to mDevice .. Patch Set 1: Code-Review+2 (1 comment)

Change in ...libosmocore[master]: tdef: Introduce min_val and max_val fields

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15546 ) Change subject: tdef: Introduce min_val and max_val fields .. Patch Set 1: > Patch Set 1: Code-Review-1 > > (7 comments) > > All

Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel c...

2019-09-18 Thread pespin
Hello fixeria, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/15408 to look at the new patch set (#4). Change subject: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel closed during WAIT_CC

Change in ...libosmocore[master]: logging: Move extern declaration of osmo_log_target_list from logging...

2019-09-18 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15559 to look at the new patch set (#2). Change subject: logging: Move extern declaration of osmo_log_target_list from logging.h to logging_internal.h

Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

2019-09-18 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15560 to look at the new patch set (#3). Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs

Change in ...libosmocore[master]: logging: Introduce mutex API to manage log_target in multi-thread envs

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15560 ) Change subject: logging: Introduce mutex API to manage log_target in multi-thread envs .. Patch Set 2: (2 comments)

Change in ...libosmocore[master]: logging.h: add L1 SAPI related context and filter

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15538 ) Change subject: logging.h: add L1 SAPI related context and filter .. Patch Set 3: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: bts: test for "logging filter l1-sapi"

2019-09-18 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15540 ) Change subject: bts: test for "logging filter l1-sapi" .. Patch Set 4: Code-Review+2 -- To view, visit

Change in ...libosmocore[master]: logging: Move osmo_log_target_list from logging.h to logging_internal.h

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15559 ) Change subject: logging: Move osmo_log_target_list from logging.h to logging_internal.h .. Patch Set 1: the commit log message

Change in ...libosmocore[master]: logging_internal.h: Fix osmo_log_info definition

2019-09-18 Thread laforge
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15558 ) Change subject: logging_internal.h: Fix osmo_log_info definition .. logging_internal.h: Fix osmo_log_info definition

Change in ...libosmocore[master]: logging_internal.h: Fix osmo_log_info definition

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15558 ) Change subject: logging_internal.h: Fix osmo_log_info definition .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15317 ) Change subject: fix error on BSSMAP Cipher Mode Complete L3 msg IE .. Patch Set 7: Code-Review+2 -- To view, visit

Change in ...osmo-pcu[master]: [DO NOT MERGE] jenkins gerrit-verifications test commit

2019-09-18 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15562 Change subject: [DO NOT MERGE] jenkins gerrit-verifications test commit .. [DO NOT MERGE] jenkins gerrit-verifications test commit

Change in ...osmo-bts[master]: vty: add "logging filter l1-sapi"

2019-09-18 Thread osmith
Hello neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15550 to look at the new patch set (#3). Change subject: vty: add "logging filter l1-sapi" ..

Change in ...osmo-bts[master]: vty: add "logging filter l1-sapi"

2019-09-18 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15550 ) Change subject: vty: add "logging filter l1-sapi" .. Patch Set 2: (1 comment)

Change in ...osmo-bts[master]: vty: add "logging filter l1-sapi"

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15550 ) Change subject: vty: add "logging filter l1-sapi" .. Patch Set 2: Code-Review+1 (1 comment)

Change in ...osmo-ttcn3-hacks[master]: bts: test for "logging filter l1-sapi"

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15540 ) Change subject: bts: test for "logging filter l1-sapi" .. Patch Set 4: Code-Review+1 -- To view, visit

Change in ...libosmocore[master]: logging.h: add L1 SAPI related context and filter

2019-09-18 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15538 ) Change subject: logging.h: add L1 SAPI related context and filter .. Patch Set 3: Code-Review+1 -- To view, visit

Change in ...osmo-bts[master]: vty: add "logging filter l1-sapi"

2019-09-18 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15550 ) Change subject: vty: add "logging filter l1-sapi" .. Patch Set 2: (2 comments)

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-18 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context .. Patch Set 4: (2 comments) As I've read through both osmo-bts patches, I realized that

Change in ...libosmocore[master]: logging.h: add L1 SAPI related context and filter

2019-09-18 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15538 ) Change subject: logging.h: add L1 SAPI related context and filter .. Patch Set 3: (1 comment)

Change in ...osmo-ttcn3-hacks[master]: bts: test for "logging filter l1-sapi"

2019-09-18 Thread osmith
Hello pespin, fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15540 to look at the new patch set (#4). Change subject: bts: test for "logging filter l1-sapi"

Change in ...libosmocore[master]: logging.h: add L1 SAPI related context and filter

2019-09-18 Thread osmith
Hello pespin, fixeria, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15538 to look at the new patch set (#3). Change subject: logging.h: add L1 SAPI related context and filter

Change in ...osmo-bts[master]: vty: add "logging filter l1-sapi"

2019-09-18 Thread osmith
Hello neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15550 to look at the new patch set (#2). Change subject: vty: add "logging filter l1-sapi" .. vty: add

Change in ...osmo-bts[master]: log: set L1 SAPI context

2019-09-18 Thread osmith
Hello fixeria, pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15539 to look at the new patch set (#4). Change subject: log: set L1 SAPI context