Change in osmo-hlr[master]: mdns_sock.c: fix resource leak of sock

2020-01-13 Thread osmith
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/16845 to look at the new patch set (#2). Change subject: mdns_sock.c: fix resource leak of sock ..

Change in osmo-hlr[master]: osmo-mslookup-client.c: fix dereferencing null

2020-01-13 Thread osmith
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/16843 to look at the new patch set (#2). Change subject: osmo-mslookup-client.c: fix dereferencing null

Change in osmo-hlr[master]: mdns_rfc.c: fix possible access of uninit. mem

2020-01-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16846 ) Change subject: mdns_rfc.c: fix possible access of uninit. mem .. Patch Set 1: (1 comment)

Change in osmo-hlr[master]: mslookup_client.c: fix dereferencing null pointer

2020-01-13 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16840 ) Change subject: mslookup_client.c: fix dereferencing null pointer .. mslookup_client.c: fix dereferencing null pointer Fixes: CID#207547

Change in osmo-hlr[master]: mslookup_client_mdns.c: fix dereferencing null

2020-01-13 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16842 ) Change subject: mslookup_client_mdns.c: fix dereferencing null .. mslookup_client_mdns.c: fix dereferencing null Fixes: CID#207545 Change-Id:

Change in osmo-hlr[master]: mdns_msg.c: always call va_end

2020-01-13 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16841 ) Change subject: mdns_msg.c: always call va_end .. mdns_msg.c: always call va_end Fixes: CID#207546 Change-Id:

Change in osmo-bsc[master]: fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TE...

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16352 ) Change subject: fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TEI_DN .. Patch Set 2: Code-Review+1 -- To

Change in osmo-pcu[master]: VTY: get rid of pcu_vty_go_parent() / pcu_vty_is_config_node()

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16347 ) Change subject: VTY: get rid of pcu_vty_go_parent() / pcu_vty_is_config_node() .. Patch Set 2: Code-Review+1 > Patch Set 2: > > Ok,

Change in osmo-bts[master]: L1SAP: use LOGL_DEBUG for logging from rach_pass_filter()

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16800 ) Change subject: L1SAP: use LOGL_DEBUG for logging from rach_pass_filter() .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TE...

2020-01-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16352 ) Change subject: fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TEI_DN .. Patch Set 2: This change is ready for

Change in osmo-pcu[master]: VTY: get rid of pcu_vty_go_parent() / pcu_vty_is_config_node()

2020-01-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16347 ) Change subject: VTY: get rid of pcu_vty_go_parent() / pcu_vty_is_config_node() .. Patch Set 2: Ok, since

Change in osmo-ttcn3-hacks[master]: MSC/Iu: fixup: start 16 BSC_ConnHdlr components in parallel

2020-01-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16801 ) Change subject: MSC/Iu: fixup: start 16 BSC_ConnHdlr components in parallel .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: MSC/Iu: fixup: start 16 BSC_ConnHdlr components in parallel

2020-01-13 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16801 ) Change subject: MSC/Iu: fixup: start 16 BSC_ConnHdlr components in parallel .. MSC/Iu: fixup: start 16 BSC_ConnHdlr components in

Change in osmo-bts[master]: L1SAP: use LOGL_DEBUG for logging from rach_pass_filter()

2020-01-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16800 ) Change subject: L1SAP: use LOGL_DEBUG for logging from rach_pass_filter() .. Patch Set 2: This change is ready for review. -- To

Change in osmocom-bb[master]: layer23: Fix build against gpsd >= 3.20

2020-01-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16848 ) Change subject: layer23: Fix build against gpsd >= 3.20 .. Patch Set 1: Code-Review+2 They seem to like breaking API... -- To

Change in osmocom-bb[master]: layer23: Fix build against gpsd >= 3.20

2020-01-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16848 ) Change subject: layer23: Fix build against gpsd >= 3.20 .. layer23: Fix build against gpsd >= 3.20 During 3.19->3.20 dev cycle,

Change in osmo-trx[master]: lms: Change radioDevice constructor arg name to avoid masking instanc...

2020-01-13 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/16847 to look at the new patch set (#2). Change subject: lms: Change radioDevice constructor arg name to avoid masking instance attr

Change in osmo-hlr[master]: mdns_rfc.c: fix possible access of uninit. mem

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16846 ) Change subject: mdns_rfc.c: fix possible access of uninit. mem .. Patch Set 1: (1 comment)

Change in osmo-hlr[master]: mdns_sock.c: fix resource leak of sock

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16845 ) Change subject: mdns_sock.c: fix resource leak of sock .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-hlr[master]: osmo-mslookup-client.c: fix dereferencing null

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16843 ) Change subject: osmo-mslookup-client.c: fix dereferencing null .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-hlr[master]: mslookup_client_mdns.c: fix dereferencing null

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16842 ) Change subject: mslookup_client_mdns.c: fix dereferencing null .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: osmo-mslookup-client: fix dereferencing null

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16844 ) Change subject: osmo-mslookup-client: fix dereferencing null .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: mdns_msg.c: always call va_end

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16841 ) Change subject: mdns_msg.c: always call va_end .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: mslookup_client.c: fix dereferencing null pointer

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16840 ) Change subject: mslookup_client.c: fix dereferencing null pointer .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: Change radiODevice constructor arg name to avoid masking instanc...

2020-01-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/16847 ) Change subject: lms: Change radiODevice constructor arg name to avoid masking instance attr .. lms: Change radiODevice constructor

Change in osmo-hlr[master]: osmo-mslookup-client: fix dereferencing null

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16844 ) Change subject: osmo-mslookup-client: fix dereferencing null .. osmo-mslookup-client: fix dereferencing null Fixes: CID#207543

Change in osmo-hlr[master]: mdns_rfc.c: fix possible access of uninit. mem

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16846 ) Change subject: mdns_rfc.c: fix possible access of uninit. mem .. mdns_rfc.c: fix possible access of uninit. mem Fixes: CID#207548

Change in osmo-hlr[master]: mdns_msg.c: always call va_end

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16841 ) Change subject: mdns_msg.c: always call va_end .. mdns_msg.c: always call va_end Fixes: CID#207546 Change-Id:

Change in osmo-hlr[master]: mslookup_client_mdns.c: fix dereferencing null

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16842 ) Change subject: mslookup_client_mdns.c: fix dereferencing null .. mslookup_client_mdns.c: fix dereferencing null Fixes: CID#207545

Change in osmo-hlr[master]: osmo-mslookup-client.c: fix dereferencing null

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16843 ) Change subject: osmo-mslookup-client.c: fix dereferencing null .. osmo-mslookup-client.c: fix dereferencing null Fixes: CID#207544

Change in osmo-hlr[master]: mslookup_client.c: fix dereferencing null pointer

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16840 ) Change subject: mslookup_client.c: fix dereferencing null pointer .. mslookup_client.c: fix dereferencing null pointer Fixes:

Change in osmo-hlr[master]: mdns_sock.c: fix resource leak of sock

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16845 ) Change subject: mdns_sock.c: fix resource leak of sock .. mdns_sock.c: fix resource leak of sock Fixes: CID#207542 Change-Id:

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-hlr[master]: db v6: determine 3G AUC IND from VLR name

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16764 ) Change subject: db v6: determine 3G AUC IND from VLR name .. Patch Set 5: Code-Review+2 -- To view, visit

Change in libosmocore[master]: application.c: check default loglevels on startup

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16833 ) Change subject: application.c: check default loglevels on startup .. Patch Set 1: Code-Review-1 (1 comment)

Change in libosmocore[master]: logging.c: Add valuestrings for loglevels

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16832 ) Change subject: logging.c: Add valuestrings for loglevels .. Patch Set 1: (1 comment)

Change in libosmocore[master]: logging.c: Add valuestrings for loglevels

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16832 ) Change subject: logging.c: Add valuestrings for loglevels .. Patch Set 1: Code-Review-1 (2 comments) I don't see how this can be

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-13 Thread keith
keith has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Trivial: code simplification, return early This commit also, (for what it

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-13 Thread keith
keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Trivial: code simplification, return early This commit also, (for what it

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-13 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Trivial: code simplification, return early This commit also, (for what

Change in osmo-trx[master]: smpl_buf: Fix str_code() param and print unknown error val

2020-01-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/16837 ) Change subject: smpl_buf: Fix str_code() param and print unknown error val .. smpl_buf: Fix str_code() param and print unknown error

Change in osmo-trx[master]: lms: Improve smpl_buf error logging

2020-01-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/16838 ) Change subject: lms: Improve smpl_buf error logging .. lms: Improve smpl_buf error logging Change-Id:

Change in osmo-hlr[master]: contrib/dgsm/ add example esme and dialplan

2020-01-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16204 ) Change subject: contrib/dgsm/ add example esme and dialplan .. contrib/dgsm/ add example esme and dialplan Add example scripts for the

Change in osmo-hlr[master]: fix missing braces in LOGP_GSUP_FWD

2020-01-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16792 ) Change subject: fix missing braces in LOGP_GSUP_FWD .. fix missing braces in LOGP_GSUP_FWD Change-Id:

Change in osmo-hlr[master]: add osmo-mslookup-client program (#2)

2020-01-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16836 ) Change subject: add osmo-mslookup-client program (#2) .. add osmo-mslookup-client program (#2) Standalone program using libosmo-mslookup to

Change in osmo-hlr[master]: contrib/dgsm/ add example esme and dialplan

2020-01-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16204 ) Change subject: contrib/dgsm/ add example esme and dialplan .. Patch Set 24: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: db v6: determine 3G AUC IND from VLR name

2020-01-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16764 ) Change subject: db v6: determine 3G AUC IND from VLR name .. Patch Set 5: Code-Review+1 -- To view, visit

Change in osmo-remsim[master]: require minimum version 1.3.0 of libosmocore

2020-01-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/16829 ) Change subject: require minimum version 1.3.0 of libosmocore .. require minimum version 1.3.0 of libosmocore Finally, a libosmocore

Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update most of our dependencies to upstream

2020-01-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16816 ) Change subject: deps/Makefile: Update most of our dependencies to upstream .. deps/Makefile: Update most of our dependencies to

Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update most of our dependencies to upstream

2020-01-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16816 ) Change subject: deps/Makefile: Update most of our dependencies to upstream .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-remsim[master]: require minimum version 1.3.0 of libosmocore

2020-01-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/16829 ) Change subject: require minimum version 1.3.0 of libosmocore .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: add osmo-mslookup-client program (#2)

2020-01-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16836 ) Change subject: add osmo-mslookup-client program (#2) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: add mDNS lookup method to libosmo-mslookup (#2)

2020-01-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16835 ) Change subject: add mDNS lookup method to libosmo-mslookup (#2) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: Makefile.am: fix pkgconfig_DATA

2020-01-13 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16834 ) Change subject: Makefile.am: fix pkgconfig_DATA .. Makefile.am: fix pkgconfig_DATA Fix building debian packages: dh_install: Cannot

Change in osmo-hlr[master]: Makefile.am: fix pkgconfig_DATA

2020-01-13 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16834 ) Change subject: Makefile.am: fix pkgconfig_DATA .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: 1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name

2020-01-13 Thread osmith
osmith has uploaded a new patch set (#25) to the change originally created by neels. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16205 ) Change subject: 1/2: refactor: add and use lu_fsm, osmo_gsup_req, osmo_ipa_name .. 1/2:

Change in osmo-hlr[master]: db v6: determine 3G AUC IND from VLR name

2020-01-13 Thread osmith
osmith has uploaded a new patch set (#5) to the change originally created by neels. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16764 ) Change subject: db v6: determine 3G AUC IND from VLR name .. db v6: determine 3G AUC IND from

Change in osmo-hlr[master]: add osmo-mslookup-client program (#2)

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16836 ) Change subject: add osmo-mslookup-client program (#2) .. add osmo-mslookup-client program (#2) Standalone program using

Change in osmo-hlr[master]: Makefile.am: fix pkgconfig_DATA

2020-01-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16834 ) Change subject: Makefile.am: fix pkgconfig_DATA .. Makefile.am: fix pkgconfig_DATA Fix building debian packages:

Change in libosmocore[master]: logging.c: Add valuestrings for loglevels

2020-01-13 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16832 ) Change subject: logging.c: Add valuestrings for loglevels .. logging.c: Add valuestrings for loglevels It might be helpful to

Change in libosmocore[master]: application.c: check default loglevels on startup

2020-01-13 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16833 ) Change subject: application.c: check default loglevels on startup .. application.c: check default loglevels on startup Default

Change in libosmo-sccp[master]: ss7: Set ASP addresses using asp_peer APIs

2020-01-13 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16796 ) Change subject: ss7: Set ASP addresses using asp_peer APIs .. ss7: Set ASP addresses using asp_peer APIs Change-Id:

Change in libosmo-sccp[master]: ss7: Return value from child function in osmo_ss7_xua_server_set_loca...

2020-01-13 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16794 ) Change subject: ss7: Return value from child function in osmo_ss7_xua_server_set_local_host .. ss7: Return value from child function in

Change in libosmo-sccp[master]: ss7: Fix sccp_simple_server rejecting connections

2020-01-13 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16797 ) Change subject: ss7: Fix sccp_simple_server rejecting connections .. ss7: Fix sccp_simple_server rejecting connections Server addresses

Change in libosmo-sccp[master]: ss7: Introduce APIs to manage asp_peer hosts

2020-01-13 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16795 ) Change subject: ss7: Introduce APIs to manage asp_peer hosts .. ss7: Introduce APIs to manage asp_peer hosts The code managing addresses

Change in libosmo-sccp[master]: ss7: Improve checks in osmo_ss7_asp_peer_add_host()

2020-01-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16831 ) Change subject: ss7: Improve checks in osmo_ss7_asp_peer_add_host() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmo-sccp[master]: ss7: Introduce APIs to manage asp_peer hosts

2020-01-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16795 ) Change subject: ss7: Introduce APIs to manage asp_peer hosts .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: ss7: Introduce APIs to manage asp_peer hosts

2020-01-13 Thread pespin
Hello laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16795 to look at the new patch set (#2). Change subject: ss7: Introduce APIs to manage asp_peer hosts

Change in libosmo-sccp[master]: ss7: Improve checks in osmo_ss7_asp_peer_add_host()

2020-01-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16831 ) Change subject: ss7: Improve checks in osmo_ss7_asp_peer_add_host() .. ss7: Improve checks in osmo_ss7_asp_peer_add_host() *

Change in osmo-hlr[master]: Add vty `imsi unknown cause` to set the reject cause

2020-01-13 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `imsi unknown cause` to set the reject cause .. Patch Set 2: I'll rework the patch. -- To view,

Change in libosmo-sccp[master]: ss7: Fix sccp_simple_server rejecting connections

2020-01-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16797 ) Change subject: ss7: Fix sccp_simple_server rejecting connections .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: ss7: Set ASP addresses using asp_peer APIs

2020-01-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16796 ) Change subject: ss7: Set ASP addresses using asp_peer APIs .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: ss7: Introduce APIs to manage asp_peer hosts

2020-01-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16795 ) Change subject: ss7: Introduce APIs to manage asp_peer hosts .. Patch Set 1: (8 comments)

Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update most of our dependencies to upstream

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16816 ) Change subject: deps/Makefile: Update most of our dependencies to upstream .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: Add SCCP_Tests_RAW for testing the actual SCCP implementation

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16814 ) Change subject: Add SCCP_Tests_RAW for testing the actual SCCP implementation .. Patch Set 1: Code-Review+1 (6 comments)

Change in osmo-hlr[master]: Add vty `imsi unknown cause` to set the reject cause

2020-01-13 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `imsi unknown cause` to set the reject cause .. Patch Set 2: > Patch Set 2: > > I would prefer if this was

Change in osmo-ci[master]: docker: drop python2 (again)

2020-01-13 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16554 ) Change subject: docker: drop python2 (again) .. docker: drop python2 (again) Re-apply patch Iacace670bdb949e67227e0faa1765e36bba42018, after

Change in osmo-ci[master]: docker: drop python2 (again)

2020-01-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16554 ) Change subject: docker: drop python2 (again) .. Patch Set 2: Verified+1 I've tested jenkins.sh scripts of all repositories with this