Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Factory_ARM/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/libosmo-sccp failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 252s] libosmo-sccp.src: W: no-changelogname-tag [ 252s] libosmo-sigtran-devel.armv7hl: W: no-changelogname-tag [ 252s] libosmo-sigtran5.armv7hl: W: no-changelogname-tag [ 252s] libosmo-xua-devel.armv7hl: W: no-changelogname-tag [ 252s] osmo-stp.armv7hl: W: no-changelogname-tag [ 252s] There is no changelog. Please insert a '%changelog' section heading in your [ 252s] spec file and prepare your changes file using e.g. the 'osc vc' command. [ 252s] [ 252s] osmo-stp.armv7hl: W: suse-missing-rclink osmo-stp [ 252s] The package contains an init script or systemd service file but lacks the [ 252s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 252s] [ 252s] libosmo-mtp-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libmtp.a [ 252s] libosmo-sigtran-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libosmo-sigtran.a [ 252s] libosmo-sccp-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libsccp.a [ 252s] libosmo-xua-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libxua.a [ 252s] This archive does not contain a non-empty .text section. The archive was not [ 252s] created with -ffat-lto-objects option. [ 252s] [ 252s] (none): E: badness 4 exceeds threshold 1000, aborting. [ 252s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings. [ 252s] [ 252s] ### VM INTERACTION START ### [ 255s] [ 234.535797] sysrq: Power Off [ 255s] [ 234.537247] reboot: Power down [ 255s] ### VM INTERACTION END ### [ 255s] [ 255s] armbuild17 failed "build libosmo-sccp.spec" at Sun May 24 03:50:01 UTC 2020. [ 255s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 156s] libosmo-sccp.src: W: no-changelogname-tag [ 156s] libosmo-sigtran-devel.x86_64: W: no-changelogname-tag [ 156s] libosmo-sigtran5.x86_64: W: no-changelogname-tag [ 156s] libosmo-xua-devel.x86_64: W: no-changelogname-tag [ 156s] osmo-stp.x86_64: W: no-changelogname-tag [ 156s] There is no changelog. Please insert a '%changelog' section heading in your [ 156s] spec file and prepare your changes file using e.g. the 'osc vc' command. [ 156s] [ 156s] osmo-stp.x86_64: W: suse-missing-rclink osmo-stp [ 156s] The package contains an init script or systemd service file but lacks the [ 156s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 156s] [ 156s] libosmo-mtp-devel.x86_64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libmtp.a [ 156s] libosmo-sigtran-devel.x86_64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libosmo-sigtran.a [ 156s] libosmo-sccp-devel.x86_64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libsccp.a [ 156s] libosmo-xua-devel.x86_64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libxua.a [ 156s] This archive does not contain a non-empty .text section. The archive was not [ 156s] created with -ffat-lto-objects option. [ 156s] [ 156s] (none): E: badness 4 exceeds threshold 1000, aborting. [ 156s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings. [ 156s] [ 156s] ### VM INTERACTION START ### [ 159s] [ 129.647244] sysrq: Power Off [ 159s] [ 129.688915] reboot: Power down [ 159s] ### VM INTERACTION END ### [ 159s] [ 159s] lamb55 failed "build libosmo-sccp.spec" at Sun May 24 01:51:26 UTC 2020. [ 159s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Factory_ARM/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/libosmo-sccp failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 231s] libosmo-sccp.src: W: no-changelogname-tag [ 231s] libosmo-sigtran-devel.aarch64: W: no-changelogname-tag [ 231s] libosmo-sigtran5.aarch64: W: no-changelogname-tag [ 231s] libosmo-xua-devel.aarch64: W: no-changelogname-tag [ 231s] osmo-stp.aarch64: W: no-changelogname-tag [ 231s] There is no changelog. Please insert a '%changelog' section heading in your [ 231s] spec file and prepare your changes file using e.g. the 'osc vc' command. [ 231s] [ 231s] osmo-stp.aarch64: W: suse-missing-rclink osmo-stp [ 231s] The package contains an init script or systemd service file but lacks the [ 231s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 231s] [ 231s] libosmo-mtp-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libmtp.a [ 231s] libosmo-sigtran-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libosmo-sigtran.a [ 231s] libosmo-sccp-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libsccp.a [ 231s] libosmo-xua-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libxua.a [ 231s] This archive does not contain a non-empty .text section. The archive was not [ 231s] created with -ffat-lto-objects option. [ 231s] [ 231s] (none): E: badness 4 exceeds threshold 1000, aborting. [ 231s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings. [ 231s] [ 231s] ### VM INTERACTION START ### [ 234s] [ 205.764653] sysrq: Power Off [ 234s] [ 205.791077] reboot: Power down [ 234s] ### VM INTERACTION END ### [ 234s] [ 234s] obs-arm-3 failed "build libosmo-sccp.spec" at Sun May 24 01:46:56 UTC 2020. [ 234s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/libosmo-sccp failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 79s] libosmo-sccp.src: W: no-changelogname-tag [ 79s] libosmo-sigtran-devel.i586: W: no-changelogname-tag [ 79s] libosmo-sigtran5.i586: W: no-changelogname-tag [ 79s] libosmo-xua-devel.i586: W: no-changelogname-tag [ 79s] osmo-stp.i586: W: no-changelogname-tag [ 79s] There is no changelog. Please insert a '%changelog' section heading in your [ 79s] spec file and prepare your changes file using e.g. the 'osc vc' command. [ 79s] [ 79s] osmo-stp.i586: W: suse-missing-rclink osmo-stp [ 79s] The package contains an init script or systemd service file but lacks the [ 79s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 79s] [ 79s] libosmo-mtp-devel.i586: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libmtp.a [ 79s] libosmo-sigtran-devel.i586: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libosmo-sigtran.a [ 79s] libosmo-sccp-devel.i586: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libsccp.a [ 79s] libosmo-xua-devel.i586: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libxua.a [ 79s] This archive does not contain a non-empty .text section. The archive was not [ 79s] created with -ffat-lto-objects option. [ 79s] [ 79s] (none): E: badness 4 exceeds threshold 1000, aborting. [ 79s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings. [ 79s] [ 79s] ### VM INTERACTION START ### [ 82s] [ 75.639528] sysrq: Power Off [ 82s] [ 75.644915] reboot: Power down [ 82s] ### VM INTERACTION END ### [ 82s] [ 82s] lamb12 failed "build libosmo-sccp.spec" at Sun May 24 01:39:54 UTC 2020. [ 82s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Factory_ARM/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/libosmo-sccp failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 245s] libosmo-sccp.src: W: no-changelogname-tag [ 245s] libosmo-sigtran-devel.armv7hl: W: no-changelogname-tag [ 245s] libosmo-sigtran5.armv7hl: W: no-changelogname-tag [ 245s] libosmo-xua-devel.armv7hl: W: no-changelogname-tag [ 245s] osmo-stp.armv7hl: W: no-changelogname-tag [ 245s] There is no changelog. Please insert a '%changelog' section heading in your [ 245s] spec file and prepare your changes file using e.g. the 'osc vc' command. [ 245s] [ 245s] osmo-stp.armv7hl: W: suse-missing-rclink osmo-stp [ 245s] The package contains an init script or systemd service file but lacks the [ 245s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 245s] [ 245s] libosmo-mtp-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libmtp.a [ 245s] libosmo-sigtran-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libosmo-sigtran.a [ 245s] libosmo-sccp-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libsccp.a [ 245s] libosmo-xua-devel.armv7hl: E: lto-no-text-in-archive (Badness: 1) /usr/lib/libxua.a [ 245s] This archive does not contain a non-empty .text section. The archive was not [ 245s] created with -ffat-lto-objects option. [ 245s] [ 245s] (none): E: badness 4 exceeds threshold 1000, aborting. [ 245s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings. [ 245s] [ 245s] ### VM INTERACTION START ### [ 248s] [ 226.213998] sysrq: Power Off [ 248s] [ 226.215719] reboot: Power down [ 248s] ### VM INTERACTION END ### [ 248s] [ 248s] armbuild19 failed "build libosmo-sccp.spec" at Sun May 24 00:35:12 UTC 2020. [ 248s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bsc[master]: bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan()
ipse has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/18436 ) Change subject: bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan() .. bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan() conn->fi might be NULL and thus can't be safely dereferenced. E.g. we're checking if it's NULL or not just a few lines above. so we should here as well. Here is a backtrace for the crash: (gdb) bt 0 0x55b948002772 in gscon_forget_lchan (conn=0x55b949c6b870, lchan=lchan@entry=0x7f00ae9ade68) at bsc_subscr_conn_fsm.c:718 1 0x55b948036c84 in lchan_fsm_wait_rf_release_ack_onenter (fi=, prev_state=) at lchan_fsm.c:1040 2 0x7f00afc6a599 in state_chg (fi=fi@entry=0x55b949bcfe10, new_state=new_state@entry=8, keep_timer=keep_timer@entry=false, timeout_ms=2000, T=3111, file=, line=1344) at fsm.c:699 3 0x7f00afc6aa5d in _osmo_fsm_inst_state_chg (fi=fi@entry=0x55b949bcfe10, new_state=new_state@entry=8, timeout_secs=, T=, file=, line=) at fsm.c:748 4 0x7f00afc78e62 in _osmo_tdef_fsm_inst_state_chg (fi=fi@entry=0x55b949bcfe10, state=state@entry=8, timeouts_array=timeouts_array@entry=0x55b9482b56a0 , tdefs=, default_timeout=140730455622800, default_timeout@entry=5, file=file@entry=0x55b948079d39 "lchan_fsm.c", line=1344) at tdef.c:346 5 0x55b9480341eb in lchan_fsm_timer_cb (fi=0x55b949bcfe10) at lchan_fsm.c:1344 6 0x7f00afc6b84a in fsm_tmr_cb (data=0x55b949bcfe10) at fsm.c:325 7 0x7f00afc65926 in osmo_timers_update () at timer.c:257 8 0x7f00afc65cda in _osmo_select_main (polling=0) at select.c:260 9 0x7f00afc66526 in osmo_select_main_ctx (polling=) at select.c:291 10 0x55b947fdcadf in main (argc=, argv=) at osmo_bsc_main.c:953 (gdb) p conn->fi $1 = (struct osmo_fsm_inst *) 0x0 Change-Id: I2427266ef4660935cde899462fa6df8d785c420e --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/36/18436/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2427266ef4660935cde899462fa6df8d785c420e Gerrit-Change-Number: 18436 Gerrit-PatchSet: 2 Gerrit-Owner: ipse Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan()
ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18436 ) Change subject: bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan() .. bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan() conn->fi might be NULL and thus can't be safely dereferenced. E.g. we're checking if it's NULL or not just a few lines above. so we should here as well. Here is a backtrace for the crash: (gdb) bt at fsm.c:748 default_timeout=140730455622800, default_timeout@entry=5, file=file@entry=0x55b948079d39 "lchan_fsm.c", line=1344) at tdef.c:346 (gdb) p conn->fi $1 = (struct osmo_fsm_inst *) 0x0 Change-Id: I2427266ef4660935cde899462fa6df8d785c420e --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/36/18436/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 0b475ff..3da9d66 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -715,7 +715,7 @@ osmo_fsm_inst_name(conn->fi), detach_label); } - if (conn->fi->state != ST_CLEARING + if ((conn->fi && conn->fi->state != ST_CLEARING) && !conn->lchan && !conn->ho.new_lchan && !conn->assignment.new_lchan) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2427266ef4660935cde899462fa6df8d785c420e Gerrit-Change-Number: 18436 Gerrit-PatchSet: 1 Gerrit-Owner: ipse Gerrit-MessageType: newchange
Change in osmo-pcu[master]: HACK: always assign TAI=0 on PTCCH/U, check SAPI of PH-RA.ind
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17830 ) Change subject: HACK: always assign TAI=0 on PTCCH/U, check SAPI of PH-RA.ind .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5aadff0d019c7e1cb78ce0327c11f83773fcc7f5 Gerrit-Change-Number: 17830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmo-pcu[master]: encoding: fix write_ia_rest_egprs_uplink_sba(): add missing CHECK(rc)
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18435 ) Change subject: encoding: fix write_ia_rest_egprs_uplink_sba(): add missing CHECK(rc) .. encoding: fix write_ia_rest_egprs_uplink_sba(): add missing CHECK(rc) Change-Id: I8e41c2912aaff689b0e311c8e2d3e961d2f1ac2c --- M src/encoding.cpp 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/35/18435/1 diff --git a/src/encoding.cpp b/src/encoding.cpp index 1805645..5d06ee9 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -328,6 +328,7 @@ /* TLLI_BLOCK_CHANNEL_CODING */ rc = bitvec_set_bit(dest, (bit_value)tbf->tlli()); + CHECK(rc); /* No BEP_PERIOD2 */ SET_0(dest); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8e41c2912aaff689b0e311c8e2d3e961d2f1ac2c Gerrit-Change-Number: 18435 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-pcu[master]: csn1: fix: never use enumerated types in codec structures
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18433 ) Change subject: csn1: fix: never use enumerated types in codec structures .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I917a40647480c6f6f3b0e68674ce9894379a9e7f Gerrit-Change-Number: 18433 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 23 May 2020 17:38:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/libosmo-sccp in openSUSE_Factory_ARM/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/libosmo-sccp failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 98s] libosmo-sccp.src: W: no-changelogname-tag [ 98s] libosmo-sigtran-devel.aarch64: W: no-changelogname-tag [ 98s] libosmo-sigtran5.aarch64: W: no-changelogname-tag [ 98s] libosmo-xua-devel.aarch64: W: no-changelogname-tag [ 98s] osmo-stp.aarch64: W: no-changelogname-tag [ 98s] There is no changelog. Please insert a '%changelog' section heading in your [ 98s] spec file and prepare your changes file using e.g. the 'osc vc' command. [ 98s] [ 98s] osmo-stp.aarch64: W: suse-missing-rclink osmo-stp [ 98s] The package contains an init script or systemd service file but lacks the [ 98s] symlink /usr/sbin/rcFOO -> /usr/sbin/service [ 98s] [ 98s] libosmo-mtp-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libmtp.a [ 98s] libosmo-sigtran-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libosmo-sigtran.a [ 98s] libosmo-sccp-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libsccp.a [ 98s] libosmo-xua-devel.aarch64: E: lto-no-text-in-archive (Badness: 1) /usr/lib64/libxua.a [ 98s] This archive does not contain a non-empty .text section. The archive was not [ 98s] created with -ffat-lto-objects option. [ 98s] [ 98s] (none): E: badness 4 exceeds threshold 1000, aborting. [ 98s] 7 packages and 0 specfiles checked; 4 errors, 8 warnings. [ 98s] [ 98s] ### VM INTERACTION START ### [ 101s] [ 87.169535] sysrq: Power Off [ 101s] [ 87.171150] reboot: Power down [ 101s] ### VM INTERACTION END ### [ 101s] [ 101s] obs-arm-9 failed "build libosmo-sccp.spec" at Sat May 23 16:40:47 UTC 2020. [ 101s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718 to look at the new patch set (#5). Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request .. RLC/MAC: implement decoding of EGPRS Packet Channel Request According to 3GPP TS 44.004, section 7.4a, two alternative RACH block formats are specified: 8 bit (1 octet) and 11 bit. This change adds CSN.1 definitions for 11 bit EGPRS Packet Channel Request as per 3GPP TS 44.060, table 11.2.5a.2. Change-Id: I96df3352856933c9140177b2801a2c71f4134183 Related: OS#1548 --- M src/gsm_rlcmac.c M src/gsm_rlcmac.h M tests/rlcmac/RLCMACTest.cpp M tests/rlcmac/RLCMACTest.err M tests/rlcmac/RLCMACTest.ok 5 files changed, 222 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/18/17718/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183 Gerrit-Change-Number: 17718 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: RLC/MAC: implement decoding of EGPRS Packet Channel Request
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17718 ) Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request .. Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183 Gerrit-Change-Number: 17718 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 23 May 2020 12:37:05 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: encoding: cosmetic: use RLC_MODE_ACKNOWLEDGED where possible
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/18434 )
Change subject: encoding: cosmetic: use RLC_MODE_ACKNOWLEDGED where possible
..
encoding: cosmetic: use RLC_MODE_ACKNOWLEDGED where possible
Change-Id: Ic69d120f622f512f05016596bfdd4a89b96e3e3b
---
M src/encoding.cpp
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/34/18434/1
diff --git a/src/encoding.cpp b/src/encoding.cpp
index 1805645..cb89b01 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -197,7 +197,8 @@
CHECK(rc);
/* RLC acknowledged mode */
- SET_0(dest); /* RLC_MODE */
+ rc = bitvec_set_bit(dest, (bit_value) RLC_MODE_ACKNOWLEDGED);
+ CHECK(rc);
rc = write_alpha_gamma(dest, alpha, gamma);
CHECK(rc);
@@ -668,7 +669,7 @@
}
block->u.Packet_Downlink_Assignment.MAC_MODE= 0x0;
// Dynamic Allocation
- block->u.Packet_Downlink_Assignment.RLC_MODE= 0x0;
// RLC acknowledged mode
+ block->u.Packet_Downlink_Assignment.RLC_MODE=
RLC_MODE_ACKNOWLEDGED;
block->u.Packet_Downlink_Assignment.CONTROL_ACK =
tbf->was_releasing; // NW establishes no new DL TBF for the MS with running
timer T3192
block->u.Packet_Downlink_Assignment.TIMESLOT_ALLOCATION = 0; //
timeslot(s)
for (tn = 0; tn < 8; tn++) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18434
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic69d120f622f512f05016596bfdd4a89b96e3e3b
Gerrit-Change-Number: 18434
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: csn1: fix: never use enumerated types in codec structures
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/18433 )
Change subject: csn1: fix: never use enumerated types in codec structures
..
csn1: fix: never use enumerated types in codec structures
I faced a problem while working on EGPRS Packet Channel Request
coding support: the unit test I wrote for it was passing when
compiled with AddressSanitizer, but failing when compiled
without it o_O. Somehow this was observed only with GCC 10.
Here is a part the standard output diff for that unit test:
*** testEGPRSPktChReq ***
decode_egprs_pkt_ch_req(0x2b5) returns 0
- ==> One Phase Access
+ ==> unknown 0xdd5f4e00
decode_egprs_pkt_ch_req(0x14a) returns 0
- ==> One Phase Access
+ ==> unknown 0xdd5f4e00
decode_egprs_pkt_ch_req(0x428) returns 0
- ==> Short Access
+ ==> unknown 0xdd5f4e01
At the same time, debug output of the CSN.1 decoder looked fine.
So WYSINWYG (What You See Is *NOT* What You Get)! As it turned
out, this was happening because I used an enumerated type to
represent the sub-type of EGPRS Packet Channel Request.
typedef struct
{
EGPRS_PacketChannelRequestType_t Type; // <-- enum
EGPRS_PacketChannelRequestContent_t Content;
} EGPRS_PacketChannelRequest_t;
The problem is that length of an enumerated field, more precisely
the amount of bytes it takes in the memory, is compiler/machine
dependent. While the CSN.1 decoder assumes that the field holding
sequential number of the chosen element is one octet long, so its
address is getting casted to (guint8 *) and the value is written
to the first MSB.
// csnStreamDecoder(), case CSN_CHOICE:
pui8 = pui8DATA(data, pDescr->offset);
*pui8 = i; // [ --> xx .. .. .. ]
Let's make sure that none of the existing RLC/MAC definitions is
using enumerated types, and add a warning comment to CSN_CHOICE.
Affected CSN.1 definitions (unit test output adjusted):
- Additional_access_technologies_struct_t,
- Channel_Request_Description_t.
Change-Id: I917a40647480c6f6f3b0e68674ce9894379a9e7f
---
M src/csn1.h
M src/gsm_rlcmac.h
M tests/rlcmac/RLCMACTest.err
3 files changed, 12 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/33/18433/1
diff --git a/src/csn1.h b/src/csn1.h
index 7eef5c8..761293d 100644
--- a/src/csn1.h
+++ b/src/csn1.h
@@ -493,9 +493,11 @@
* The value of the address is called a selector. Up to 256 (UCHAR_MAX) unique
* selectors can be handled, longer choice list would cause
CSN_ERROR_IN_SCRIPT.
* After unpacking, this value is then converted to the sequential number of
the
- * element in the union and stored in the UnionType variable.
+ * element in the union and stored in the UnionType variable (Par2).
* Par1: C structure name
- * Par2: C structure element name
+ * Par2: C structure field name holding sequential number of the chosen
element.
+ *BEWARE! Never use an enumerated type here, because its length is
+ *compiler/machine dependent, while decoder would cast it to
guint8.
* Par3: address of an array of type CSN_ChoiceElement_t where all
possible
*values of the selector are provided, together with the selector
*length expressed in bits and the address of the CSN_DESCR type
diff --git a/src/gsm_rlcmac.h b/src/gsm_rlcmac.h
index e9ae20a..9d859f3 100644
--- a/src/gsm_rlcmac.h
+++ b/src/gsm_rlcmac.h
@@ -158,7 +158,7 @@
{
guint8 PEAK_THROUGHPUT_CLASS;
guint8 RADIO_PRIORITY;
- RLC_MODE_t RLC_MODE;
+ guint8 RLC_MODE;
guint8 LLC_PDU_TYPE;
guint16 RLC_OCTET_COUNT;
} Channel_Request_Description_t;
@@ -1245,7 +1245,7 @@
typedef struct
{
- AccessTechnology_t Access_Technology_Type;
+ guint8 Access_Technology_Type;
guint8 GMSK_Power_class;
guint8 Eight_PSK_Power_class;
} Additional_access_technologies_struct_t;
diff --git a/tests/rlcmac/RLCMACTest.err b/tests/rlcmac/RLCMACTest.err
index c271e5c..83d416c 100644
--- a/tests/rlcmac/RLCMACTest.err
+++ b/tests/rlcmac/RLCMACTest.err
@@ -22,18 +22,18 @@
DCSN1 INFO csnStreamEncoder (type: Pkt UL Dummy Ctrl Block (3)): PayloadType =
1 | spare = 0 | R = 0 | MESSAGE_TYPE = 3 | TLLI = 2274915399 | Padding =
1|43|43|43|43|43|43|43|43|43|43|43|43|43|43|43|43|43|
DCSN1 INFO csnStreamDecoder (type: Pkt DL ACK/NACK (2)): PayloadType = 1 |
spare = 0 | R = 0 | MESSAGE_TYPE = 2 | DOWNLINK_TFI = 28 | :
Ack_Nack_Description | FINAL_ACK_INDICATION = 0 | STARTING_SEQUENCE_NUMBER = 1
| RECEIVED_BLOCK_BITMAP[0] = 0 | RECEIVED_BLOCK_BITMAP[1] = 0 |
RECEIVED_BLOCK_BITMAP[2] = 0 | RECEIVED_BLOCK_BITMAP[3] = 0 |
RECEIVED_BLOCK_BITMAP[4] = 0 | RECEIVED_BLOCK_BITMAP[5] = 0 |
RECEIVED_BLOCK_BITMAP[6] = 0 | RECEIVED_BLOCK_BITMAP[7] = 1 | : End
Ack_Nack_Description | Exist_Channel_Request_Description = 0 | :
Channel_Quality_Report | C_VALUE = 18 | RXQUAL = 0 | SIGN_VAR =
Change in osmo-pcu[master]: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387 to look at the new patch set (#5). Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request .. BTS::parse_rach_ind(): properly handle EGPRS Packet Channel Request Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7 --- M src/bts.cpp 1 file changed, 56 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/18387/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7 Gerrit-Change-Number: 18387 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/18385 to look at the new patch set (#2). Change subject: l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g .. l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g This is not a functional change, just fixing misleading function name. Access Bursts on PTCCH/U have nothing to do with PDTCH. Change-Id: I4ab710ba026315301cc6970263967616401a9fc8 --- M src/osmo-bts-litecell15/lc15_l1_if.c M src/osmo-bts-oc2g/oc2g_l1_if.c M src/osmo-bts-sysmo/sysmo_l1_if.c M src/pcu_l1_if.cpp M src/pcu_l1_if.h 5 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/85/18385/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4ab710ba026315301cc6970263967616401a9fc8 Gerrit-Change-Number: 18385 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: csn1: fix M_CHOICE: restirct maximum length of the choice list
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/18430 )
Change subject: csn1: fix M_CHOICE: restirct maximum length of the choice list
..
csn1: fix M_CHOICE: restirct maximum length of the choice list
The current implementation is not capable of handling more than
256 (UCHAR_MAX) selectors in the choice list. Let's document
this and add a guard check to the M_CHOICE handler.
Change-Id: I40c3c5b9be892804c6cd71cbb907af469ce5d769
---
M src/csn1.c
M src/csn1.h
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/18430/1
diff --git a/src/csn1.c b/src/csn1.c
index 3db1e13..3347a64 100644
--- a/src/csn1.c
+++ b/src/csn1.c
@@ -495,6 +495,8 @@
/* Make sure that the list of choice items is not empty */
if (!count)
return ProcessError(readIndex, "csnStreamDecoder",
CSN_ERROR_IN_SCRIPT, pDescr);
+else if (count > 255) /* We can handle up to 256 (UCHAR_MAX) selectors
*/
+ return ProcessError(readIndex, "csnStreamDecoder",
CSN_ERROR_IN_SCRIPT, pDescr);
while (count > 0)
{
diff --git a/src/csn1.h b/src/csn1.h
index d178ada..7eef5c8 100644
--- a/src/csn1.h
+++ b/src/csn1.h
@@ -490,7 +490,8 @@
* is the part of the message. In the CSN_CHOICE case, this rule does not
* apply. There is free but predefined mapping of the element of the union and
* the value which addresses this element.
- * The value of the address is called a selector.
+ * The value of the address is called a selector. Up to 256 (UCHAR_MAX) unique
+ * selectors can be handled, longer choice list would cause
CSN_ERROR_IN_SCRIPT.
* After unpacking, this value is then converted to the sequential number of
the
* element in the union and stored in the UnionType variable.
* Par1: C structure name
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18430
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I40c3c5b9be892804c6cd71cbb907af469ce5d769
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: csn1: fix csnStreamEncoder(): always check the choice index
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/18432 )
Change subject: csn1: fix csnStreamEncoder(): always check the choice index
..
csn1: fix csnStreamEncoder(): always check the choice index
It's so easy to pick an out of bounds value otherwise...
Change-Id: I12f5ab739b97f1f3b5d4bed1b5a4a661c879e89f
---
M src/csn1.c
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/32/18432/1
diff --git a/src/csn1.c b/src/csn1.c
index 700c342..5b60399 100644
--- a/src/csn1.c
+++ b/src/csn1.c
@@ -1803,7 +1803,6 @@
case CSN_CHOICE:
{
gint16 count = pDescr->i;
-guint8 i = 0;
const CSN_ChoiceElement_t* pChoice = (const CSN_ChoiceElement_t*)
pDescr->descr.ptr;
/* Make sure that the list of choice items is not empty */
@@ -1812,9 +1811,12 @@
else if (count > 255) /* We can handle up to 256 (UCHAR_MAX) selectors
*/
return ProcessError(writeIndex, "csnStreamEncoder",
CSN_ERROR_IN_SCRIPT, pDescr);
-pui8 = pui8DATA(data, pDescr->offset);
-i = *pui8;
-pChoice += i;
+/* Make sure that choice index is not out of range */
+pui8 = pui8DATA(data, pDescr->offset);
+if (*pui8 >= count)
+ return ProcessError(writeIndex, "csnStreamEncoder",
CSN_ERROR_INVALID_UNION_INDEX, pDescr);
+
+pChoice += *pui8;
guint8 no_of_bits = pChoice->bits;
guint8 value = pChoice->value;
LOGPC(DCSN1, LOGL_DEBUG, "%s = %u | ", pChoice->descr.sz ,
(unsigned)value);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18432
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I12f5ab739b97f1f3b5d4bed1b5a4a661c879e89f
Gerrit-Change-Number: 18432
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: csn1: fix csnStreamEncoder(): also check length of the choice list
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/18431 )
Change subject: csn1: fix csnStreamEncoder(): also check length of the choice
list
..
csn1: fix csnStreamEncoder(): also check length of the choice list
Similar checks are done in csnStreamDecoder(), so better check than sorry.
Change-Id: I441c716975905a37264efc8a76df92194f39c1fb
---
M src/csn1.c
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/31/18431/1
diff --git a/src/csn1.c b/src/csn1.c
index 3347a64..700c342 100644
--- a/src/csn1.c
+++ b/src/csn1.c
@@ -1802,10 +1802,16 @@
case CSN_CHOICE:
{
-//gint16 count = pDescr->i;
+gint16 count = pDescr->i;
guint8 i = 0;
const CSN_ChoiceElement_t* pChoice = (const CSN_ChoiceElement_t*)
pDescr->descr.ptr;
+/* Make sure that the list of choice items is not empty */
+if (!count)
+ return ProcessError(writeIndex, "csnStreamEncoder",
CSN_ERROR_IN_SCRIPT, pDescr);
+else if (count > 255) /* We can handle up to 256 (UCHAR_MAX) selectors
*/
+ return ProcessError(writeIndex, "csnStreamEncoder",
CSN_ERROR_IN_SCRIPT, pDescr);
+
pui8 = pui8DATA(data, pDescr->offset);
i = *pui8;
pChoice += i;
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18431
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I441c716975905a37264efc8a76df92194f39c1fb
Gerrit-Change-Number: 18431
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-trx[master]: doc: switch log levels to notice
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17594 ) Change subject: doc: switch log levels to notice .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ief82b85d9ff0e0e94eaabd255ebea961396fff32 Gerrit-Change-Number: 17594 Gerrit-PatchSet: 6 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 23 May 2020 11:50:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: doc: switch log levels to notice
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17594 ) Change subject: doc: switch log levels to notice .. doc: switch log levels to notice Some of the example configs have loglevels set to info. This is too verbose, lets make sure all loglevels are set to notice Change-Id: Ief82b85d9ff0e0e94eaabd255ebea961396fff32 --- M doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg M doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg M doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified Objections: fixeria: I would prefer this is not merged as is diff --git a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg index 16c68da..6d787f6 100644 --- a/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg @@ -4,7 +4,7 @@ logging print category 1 logging timestamp 1 logging print file basename - logging level set-all info + logging level set-all notice ! line vty no login diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg index 16c68da..6d787f6 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg @@ -4,7 +4,7 @@ logging print category 1 logging timestamp 1 logging print file basename - logging level set-all info + logging level set-all notice ! line vty no login diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg index d930da4..2e45da9 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg @@ -4,7 +4,7 @@ logging print category 1 logging timestamp 1 logging print file basename - logging level set-all info + logging level set-all notice ! line vty no login diff --git a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg index 2905ed7..1ecaec2 100644 --- a/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg +++ b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg @@ -4,7 +4,7 @@ logging print category 1 logging timestamp 1 logging print file basename - logging level set-all info + logging level set-all notice ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ief82b85d9ff0e0e94eaabd255ebea961396fff32 Gerrit-Change-Number: 17594 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged
Change in pysim[master]: cards: remove empty erase() methods.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18418 ) Change subject: cards: remove empty erase() methods. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If5add960ec0cab58a01d8f83e6af8cb86ec70a8d Gerrit-Change-Number: 18418 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:50:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: cards: remove empty erase() methods.
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/18418
)
Change subject: cards: remove empty erase() methods.
..
cards: remove empty erase() methods.
Some of the cards do not implement the erase method that each card
should have. However, having an empty method in each of those classes
does not make too much sense. Lets rather have an erase method in the
superclass (Card) that prints a warning to inform the user that erasing
the spcified card is not supported.
Change-Id: If5add960ec0cab58a01d8f83e6af8cb86ec70a8d
---
M pySim/cards.py
1 file changed, 4 insertions(+), 20 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/cards.py b/pySim/cards.py
index 73b0763..c7b34eb 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -37,6 +37,10 @@
def reset(self):
self._scc.reset_card()
+ def erase(self):
+ print("warning: erasing is not supported for specified card
type!")
+ return
+
def verify_adm(self, key):
'''
Authenticate with ADM key
@@ -529,8 +533,6 @@
# FIXME: EF.MSISDN
- def erase(self):
- return
class SysmoSIMgr1(GrcardSim):
"""
@@ -575,9 +577,6 @@
)
data, sw = self._scc._tp.send_apdu_checksw("009933" + par)
- def erase(self):
- return
-
class SysmoSIMgr2(Card):
"""
@@ -653,8 +652,6 @@
if p.get('smsp'):
data, sw = self._scc.update_record('6f42', 1,
lpad(p['smsp'], 80))
- def erase(self):
- return
class SysmoUSIMSJS1(Card):
"""
@@ -759,9 +756,6 @@
r = self._scc.select_file(['3f00', '7f10'])
data, sw = self._scc.update_record('6F40', 1, data,
force_len=True)
- def erase(self):
- return
-
class FairwavesSIM(Card):
"""
@@ -903,10 +897,6 @@
if sw != '9000':
print("Programming ACC failed with code %s"%sw)
- def erase(self):
- return
-
-
class OpenCellsSim(Card):
"""
OpenCellsSim
@@ -1046,9 +1036,6 @@
return None
- def erase(self):
- return
-
class SysmoISIMSJA2(Card):
"""
@@ -1169,9 +1156,6 @@
return
- def erase(self):
- return
-
# In order for autodetection ...
_cards_classes = [ FakeMagicSim, SuperSim, MagicSim, GrcardSim,
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/18418
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If5add960ec0cab58a01d8f83e6af8cb86ec70a8d
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: pcu: Add missing f_shutdown() to exit as soon as possible without fin...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18419 ) Change subject: pcu: Add missing f_shutdown() to exit as soon as possible without final=true .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9703f7c81a98b6ef826db48c107ee833c125e5cc Gerrit-Change-Number: 18419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:49:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-remsim[master]: contrib: integrate RPM spec
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/18307 ) Change subject: contrib: integrate RPM spec .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/18307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ib2da03980d99f12ab36ca5d5fdde92ddbefb040b Gerrit-Change-Number: 18307 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: roox Gerrit-Comment-Date: Sat, 23 May 2020 11:49:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-remsim[master]: contrib: integrate RPM spec
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-remsim/+/18307 )
Change subject: contrib: integrate RPM spec
..
contrib: integrate RPM spec
Remove OpenSUSE bug report link, set version to @VERSION@, make it build
with CentOS 8 etc.
Related: OS#4550
Change-Id: Ib2da03980d99f12ab36ca5d5fdde92ddbefb040b
---
M .gitignore
M configure.ac
R contrib/osmo-remsim.spec.in
3 files changed, 17 insertions(+), 13 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/.gitignore b/.gitignore
index e2546a0..a1cec37 100644
--- a/.gitignore
+++ b/.gitignore
@@ -49,3 +49,5 @@
debian/.debhelper
debian/debhelper*
debian/files
+
+contrib/osmo-remsim.spec
diff --git a/configure.ac b/configure.ac
index b65340f..5833d0d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -196,6 +196,7 @@
contrib/Makefile
contrib/etc_default/Makefile
contrib/systemd/Makefile
+ contrib/osmo-remsim.spec
doc/Makefile
doc/manuals/Makefile
src/Makefile
diff --git a/contrib/osmo-remsim.spec b/contrib/osmo-remsim.spec.in
similarity index 92%
rename from contrib/osmo-remsim.spec
rename to contrib/osmo-remsim.spec.in
index 84874bc..4ff26bc 100644
--- a/contrib/osmo-remsim.spec
+++ b/contrib/osmo-remsim.spec.in
@@ -12,24 +12,23 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
-#
-
%define sover 1
Name: osmo-remsim
-Version:0.2.2.86
+Version:@VERSION@
Release:0
Summary:Osmocom remote SIM software suite
License:GPL-2.0-or-later
Group: Productivity/Telephony/Servers
-URL:https://projects.osmocom.org/projects/osmo-remsim
+URL:https://osmocom.org/projects/osmo-remsim
Source: %{name}-%{version}.tar.xz
BuildRequires: autoconf
BuildRequires: automake
BuildRequires: libcsv-devel
BuildRequires: libtool
BuildRequires: pkgconfig
+%if 0%{?suse_version}
BuildRequires: systemd-rpm-macros
+%endif
BuildRequires: pkgconfig(libasn1c) >= 0.9.30
BuildRequires: pkgconfig(libosmoabis)
BuildRequires: pkgconfig(libosmocore) >= 0.11.0
@@ -40,7 +39,7 @@
BuildRequires: pkgconfig(libusb-1.0)
BuildRequires: pkgconfig(libosmousb)
BuildRequires: pkgconfig(libosmo-simtrace2)
-%{?systemd_ordering}
+%{?systemd_requires}
%description
osmo-remsim is a suite of software programs enabling physical/geographic
@@ -159,6 +158,7 @@
%post -n libosmo-rspro%{sover} -p /sbin/ldconfig
%postun -n libosmo-rspro%{sover} -p /sbin/ldconfig
+%if 0%{?suse_version}
%pre-n osmo-remsim-bankd %service_add_pre osmo-remsim-bankd.service
%post -n osmo-remsim-bankd %service_add_postosmo-remsim-bankd.service
%preun -n osmo-remsim-bankd %service_del_preun osmo-remsim-bankd.service
@@ -173,6 +173,7 @@
%post -n osmo-remsim-server %service_add_post osmo-remsim-server.service
%preun -n osmo-remsim-server %service_del_preun osmo-remsim-server.service
%postun -n osmo-remsim-server %service_del_postun osmo-remsim-server.service
+%endif
%files -n libosmo-rspro%{sover}
%license COPYING
@@ -180,9 +181,8 @@
%{_libdir}/libosmo-rspro.so.%{sover}*
%files -n libosmo-rspro-devel
-%{_includedir}/osmocom
%dir %{_includedir}/osmocom/rspro
-%{_includedir}/osmocom/rspro/rspro_client.h
+%{_includedir}/osmocom/rspro/*
%{_libdir}/libosmo-rspro.so
%{_libdir}/pkgconfig/libosmo-rspro.pc
@@ -204,12 +204,13 @@
%config %{_sysconfdir}/default/osmo-remsim-client*
%files -n libifd-osmo-remsim-client0
-%dir %{_libdir}/readers/
+%if 0%{?centos_ver}
+%dir %{_libdir}/pcsc/drivers/libifd-osmo-remsim-client.bundle
+%{_libdir}/pcsc/drivers/libifd-osmo-remsim-client.bundle/*
+%else
%dir %{_libdir}/readers/libifd-osmo-remsim-client.bundle
-%dir %{_libdir}/readers/libifd-osmo-remsim-client.bundle/Contents
-%{_libdir}/readers/libifd-osmo-remsim-client.bundle/Contents/PkgInfo
-%dir %{_libdir}/readers/libifd-osmo-remsim-client.bundle/Contents/Linux
-%{_libdir}/readers/libifd-osmo-remsim-client.bundle/Contents/Linux/libifd_remsim_client.so*
+%{_libdir}/readers/libifd-osmo-remsim-client.bundle/*
+%endif
%config %{_sysconfdir}/reader.conf.d/osmo-remsim-client-reader_conf
%changelog
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/18307
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Ib2da03980d99f12ab36ca5d5fdde92ddbefb040b
Gerrit-Change-Number: 18307
Gerrit-PatchSet: 5
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: roox
Gerrit-MessageType: merged
Change in osmo-remsim[master]: Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/18407 ) Change subject: Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in .. Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in Change-Id: Ifbd7b8d726c558f40b12bf864bec8b8c819b6094 --- M Makefile.am 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index 9c51a55..664e3b7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,7 +5,14 @@ pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libosmo-rspro.pc -EXTRA_DIST = asn1 .version README.md contrib/remsim-apitool.py +EXTRA_DIST = \ +.version \ +README.md \ +asn1 \ +contrib/osmo-remsim.spec.in \ +contrib/remsim-apitool.py \ +debian \ +$(NULL) AM_DISTCHECK_CONFIGURE_FLAGS = \ --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/18407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ifbd7b8d726c558f40b12bf864bec8b8c819b6094 Gerrit-Change-Number: 18407 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: PCU: introduce TC_egprs_pkt_chan_req_reject_exhaustion
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18425 ) Change subject: PCU: introduce TC_egprs_pkt_chan_req_reject_exhaustion .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie6e5fc68e1591c57e21541ba16fbdcd3fe477ac7 Gerrit-Change-Number: 18425 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:47:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU: introduce TC_egprs_pkt_chan_req_reject_emergency
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18424 ) Change subject: PCU: introduce TC_egprs_pkt_chan_req_reject_emergency .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I63d989e89e6235a631e024c2810a3a4b0de56ccf Gerrit-Change-Number: 18424 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:47:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: add receive templates for IMM ASS Reject
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18422 )
Change subject: library/GSM_RR_Types: add receive templates for IMM ASS Reject
..
library/GSM_RR_Types: add receive templates for IMM ASS Reject
Change-Id: Icece9245f4a85dcf59021a76d51d419cf1c13990
---
M library/GSM_RR_Types.ttcn
1 file changed, 32 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 4bd65d1..ec9b3cc 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -1036,4 +1036,36 @@
}
};
+ template GsmRrMessage tr_IMM_ASS_REJ(template FeatureIndicator
feature_ind := ?,
+template ReqRefWaitInd4 rr_wi_list
:= ?,
+template IARRestOctets rest_octets
:= ?) := {
+ header := t_RrHeader(IMMEDIATE_ASSIGNMENT_REJECT, ?),
+ payload := {
+ imm_ass_rej := {
+ feature_ind := feature_ind,
+ page_mode := ?,
+ payload := rr_wi_list,
+ rest_octets := rest_octets
+ }
+ }
+ };
+
+ template ReqRefWaitInd tr_ReqRefWaitInd(template RequestReference ref
:= ?,
+ template WaitIndication wi :=
?) := {
+ req_ref := ref,
+ wait_ind := wi
+ };
+
+ template IARRestOctets tr_IARRestOctets(template ExtRAList ext_ra_list
:= ?,
+ template uint3_t rcc := ?) := {
+ ext_ra_list := ext_ra_list,
+ rel13_ind := ?,
+ rcc := rcc ifpresent
+ };
+
+ template ExtRAOpt tr_ExtRAOpt(template BIT5 ext_ra := ?) := {
+ presence := '1'B, // L/H
+ ext_ra := ext_ra
+ };
+
} with { encode "RAW" ; variant "FIELDORDER(msb)" }
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18422
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icece9245f4a85dcf59021a76d51d419cf1c13990
Gerrit-Change-Number: 18422
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: fix definition of FeatureIndicator
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18420 )
Change subject: library/GSM_RR_Types: fix definition of FeatureIndicator
..
library/GSM_RR_Types: fix definition of FeatureIndicator
Change-Id: I06ad58f25aa97bf13de87127e7e2c6237a90557e
---
M library/GSM_RR_Types.ttcn
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index b09a760..0fa6ec6 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -365,10 +365,13 @@
/* 10.5.2.76 */
type record FeatureIndicator {
- BIT2spare,
- boolean cs_ir,
- boolean ps_ir
- } with { variant "" };
+ BIT2peo_bcch_change_mark,
+ boolean cs_ir,
+ boolean ps_ir
+ } with {
+ variant (cs_ir) "FIELDLENGTH(1)"
+ variant (ps_ir) "FIELDLENGTH(1)"
+ };
/* 24.008 10.5.5.6 */
type record DrxParameter {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18420
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I06ad58f25aa97bf13de87127e7e2c6237a90557e
Gerrit-Change-Number: 18420
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: add IAR Rest Octets definition
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18421 )
Change subject: library/GSM_RR_Types: add IAR Rest Octets definition
..
library/GSM_RR_Types: add IAR Rest Octets definition
See 3GPP TS 44.018, section 10.5.2.17 "IAR Rest Octets".
Change-Id: Ib1f16b310d6ca94f19a1700c78cb37e8b35ac570
---
M library/GSM_RR_Types.ttcn
1 file changed, 30 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 0fa6ec6..4bd65d1 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -652,9 +652,38 @@
type record ImmediateAssignmentReject {
FeatureIndicatorfeature_ind,
PageModepage_mode,
- ReqRefWaitInd4 payload
+ ReqRefWaitInd4 payload,
+ IARRestOctets rest_octets
} with { variant "" };
+ /* 10.5.2.17 IAR (Immediate Assignment Reject) Rest Octets */
+ type record IARRestOctets {
+ ExtRAList ext_ra_list,
+ BIT1rel13_ind, // L/H
+ uint3_t rcc optional
+ /* Addition in Rel-15: PEO IMM Cell Group Details struct */
+ } with {
+ variant (rel13_ind) "CSN.1 L/H"
+ variant (rcc) "PRESENCE(rel13_ind = '1'B)"
+
+ /* The TITAN's RAW encoder generates an octet-aligned
octetstring,
+* so we should make sure that unused bits contain proper
padding. */
+ variant "PADDING(yes), PADDING_PATTERN('00101011'B)"
+ };
+
+ /* Optional extended RA: 0 | 1 < Extended RA 1 : bit (5) > */
+ type record ExtRAOpt {
+ BIT1presence, // L/H
+ BIT5ext_ra optional
+ } with {
+ variant (presence) "CSN.1 L/H"
+ variant (ext_ra) "PRESENCE(presence = '1'B)"
+ /* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562488 */
+ variant (ext_ra) "BYTEORDER(last)"
+ };
+
+ type record length(4) of ExtRAOpt ExtRAList;
+
/* 9.1.21 */
type record MeasurementReport {
MeasurementResults meas_res
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18421
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib1f16b310d6ca94f19a1700c78cb37e8b35ac570
Gerrit-Change-Number: 18421
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18384 ) Change subject: ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors .. ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors This change enables interpretation of backslash escapes for echo, so the test case execution summary is always printed in color. Change-Id: I0cc77b4de764c7afd6416512a181c4c1610ce369 --- M ttcn3-tcpdump-stop.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index 1f4da3d..30d331d 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -22,9 +22,9 @@ date if [ x"$VERDICT" = x"pass" ]; then - echo "\033[1;32m== $TESTCASE $VERDICT ==\033[0m" + echo -e "\033[1;32m== $TESTCASE $VERDICT ==\033[0m" else - echo "\033[1;31m-- $TESTCASE $VERDICT --\033[0m" + echo -e "\033[1;31m-- $TESTCASE $VERDICT --\033[0m" fi echo -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0cc77b4de764c7afd6416512a181c4c1610ce369 Gerrit-Change-Number: 18384 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: PCU: introduce TC_egprs_pkt_chan_req_reject_content
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18423 ) Change subject: PCU: introduce TC_egprs_pkt_chan_req_reject_content .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bfd5621085d63896e2e9b70355524cf4285036a Gerrit-Change-Number: 18423 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:46:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: add IAR Rest Octets definition
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18421 ) Change subject: library/GSM_RR_Types: add IAR Rest Octets definition .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib1f16b310d6ca94f19a1700c78cb37e8b35ac570 Gerrit-Change-Number: 18421 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:46:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: add receive templates for IMM ASS Reject
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18422 ) Change subject: library/GSM_RR_Types: add receive templates for IMM ASS Reject .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icece9245f4a85dcf59021a76d51d419cf1c13990 Gerrit-Change-Number: 18422 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:46:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: fix definition of FeatureIndicator
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18420 ) Change subject: library/GSM_RR_Types: fix definition of FeatureIndicator .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I06ad58f25aa97bf13de87127e7e2c6237a90557e Gerrit-Change-Number: 18420 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:45:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18384 ) Change subject: ttcn3-tcpdump-stop.sh: fix echo: add -e to enable colors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0cc77b4de764c7afd6416512a181c4c1610ce369 Gerrit-Change-Number: 18384 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 23 May 2020 11:45:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: stats: Count paging requests flushed due to MSC Reset.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18427 ) Change subject: stats: Count paging requests flushed due to MSC Reset. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie93fc54fecdfcf615483f7f41a36dbcea61a537b Gerrit-Change-Number: 18427 Gerrit-PatchSet: 1 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:44:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: stats: Add a BTS counter for paging rqsts responded elsewhere.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18426 ) Change subject: stats: Add a BTS counter for paging rqsts responded elsewhere. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4b27a0559ef2762e62bc3ac3f17b89b0ed48 Gerrit-Change-Number: 18426 Gerrit-PatchSet: 1 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 23 May 2020 11:44:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ggsn[master]: example config: use RFC1918 addresses for GGSN pools
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/18429 ) Change subject: example config: use RFC1918 addresses for GGSN pools .. example config: use RFC1918 addresses for GGSN pools It's 172.16, not 176.16. Change-Id: I2d83ee747e8987f10c4960d42f3c3f2a723e3f4c --- M doc/examples/osmo-ggsn.cfg 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/29/18429/1 diff --git a/doc/examples/osmo-ggsn.cfg b/doc/examples/osmo-ggsn.cfg index e79fdfa..02523e9 100644 --- a/doc/examples/osmo-ggsn.cfg +++ b/doc/examples/osmo-ggsn.cfg @@ -42,10 +42,10 @@ gtpu-mode tun tun-device tun4 type-support v4 - ip prefix dynamic 176.16.222.0/24 + ip prefix dynamic 172.16.222.0/24 ip dns 0 8.8.8.8 ip dns 1 8.8.4.4 - ip ifconfig 176.16.222.0/24 + ip ifconfig 172.16.222.0/24 no shutdown apn inet6 gtpu-mode tun @@ -60,10 +60,10 @@ gtpu-mode tun tun-device tun46 type-support v4v6 - ip prefix dynamic 176.16.46.0/24 + ip prefix dynamic 172.16.46.0/24 ip dns 0 8.8.8.8 ip dns 1 8.8.4.4 - ip ifconfig 176.16.46.0/24 + ip ifconfig 172.16.46.0/24 ipv6 prefix dynamic 2001:780:44:2100:0:0:0:0/56 ipv6 dns 0 2001:4860:4860:: ipv6 dns 1 2001:4860:4860::8844 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/18429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I2d83ee747e8987f10c4960d42f3c3f2a723e3f4c Gerrit-Change-Number: 18429 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
