Change in osmo-msc[master]: add sequence_charts/call_reestablishment.msc

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/25074 ) Change subject: add sequence_charts/call_reestablishment.msc .. add sequence_charts/call_reestablishment.msc Change-Id:

Change in osmo-msc[master]: add vlr_subscr_find_by_mi

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/25075 ) Change subject: add vlr_subscr_find_by_mi .. add vlr_subscr_find_by_mi Will be used by I6fa37d6ca9fcb1637742b40e37b68d67664c9b60

Change in osmo-msc[master]: implement CM Re-Establish for voice calls

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/25076 ) Change subject: implement CM Re-Establish for voice calls .. implement CM Re-Establish for voice calls Related: SYS#5130 Change-Id:

Change in osmo-ttcn3-hacks[master]: GSUP_Emulation: allow moving HLR handling to another test component

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25071 ) Change subject: GSUP_Emulation: allow moving HLR handling to another test component .. GSUP_Emulation: allow moving HLR

Change in osmo-ttcn3-hacks[master]: SMPP_Emulation: replace previous entries in f_create_smpp_expect()

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25072 ) Change subject: SMPP_Emulation: replace previous entries in f_create_smpp_expect() .. SMPP_Emulation: replace previous

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment_auth

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25073 ) Change subject: msc: add MSC_Tests.TC_call_re_establishment_auth .. msc: add MSC_Tests.TC_call_re_establishment_auth Invoke

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment

2021-07-27 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25070 ) Change subject: msc: add MSC_Tests.TC_call_re_establishment .. msc: add MSC_Tests.TC_call_re_establishment The osmo-msc patch

Change in osmo-ttcn3-hacks[master]: msc: add a COORD port for inter-component coordination

2021-07-27 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25069 ) Change subject: msc: add a COORD port for inter-component coordination .. msc: add a COORD port for inter-component coordination

Change in osmo-ttcn3-hacks[master]: msc: add as_mgcp_ack_all_dlcx

2021-07-27 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25068 ) Change subject: msc: add as_mgcp_ack_all_dlcx .. msc: add as_mgcp_ack_all_dlcx Will be used by

Change in osmo-ttcn3-hacks[master]: MNCC_Emulation: allow moving call handling to another test component

2021-07-27 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25067 ) Change subject: MNCC_Emulation: allow moving call handling to another test component .. MNCC_Emulation: allow moving call

Change in osmo-ttcn3-hacks[master]: L3_Templates: add ts_ML3_MO_CC_DISC

2021-07-27 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25065 ) Change subject: L3_Templates: add ts_ML3_MO_CC_DISC .. L3_Templates: add ts_ML3_MO_CC_DISC To simulate an MS initiated call

Change in osmo-ttcn3-hacks[master]: MGCP_Emulation: allow moving ep handling to another test component

2021-07-27 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25066 ) Change subject: MGCP_Emulation: allow moving ep handling to another test component .. MGCP_Emulation: allow moving ep handling

Change in osmo-ttcn3-hacks[master]: .gitignore sms.db

2021-07-27 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25063 ) Change subject: .gitignore sms.db .. .gitignore sms.db When running osmo-msc in osmo-ttcn3-hacks/msc, it will leave behind an

Change in osmo-ttcn3-hacks[master]: msc: fix conn id in 'MGCP OK' msg (as_mgcp_ack_all_mdcx)

2021-07-27 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25064 ) Change subject: msc: fix conn id in 'MGCP OK' msg (as_mgcp_ack_all_mdcx) .. msc: fix conn id in 'MGCP OK' msg

Change in osmo-ttcn3-hacks[master]: msc: add MSC_Tests.TC_call_re_establishment

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25070 ) Change subject: msc: add MSC_Tests.TC_call_re_establishment .. msc: add MSC_Tests.TC_call_re_establishment The osmo-msc

Change in osmo-ttcn3-hacks[master]: msc: add a COORD port for inter-component coordination

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25069 ) Change subject: msc: add a COORD port for inter-component coordination .. msc: add a COORD port for inter-component

Change in osmo-ttcn3-hacks[master]: msc: add as_mgcp_ack_all_dlcx

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25068 ) Change subject: msc: add as_mgcp_ack_all_dlcx .. msc: add as_mgcp_ack_all_dlcx Will be used by

Change in osmo-ttcn3-hacks[master]: MNCC_Emulation: allow moving call handling to another test component

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25067 ) Change subject: MNCC_Emulation: allow moving call handling to another test component .. MNCC_Emulation: allow moving call

Change in osmo-ttcn3-hacks[master]: MGCP_Emulation: allow moving ep handling to another test component

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25066 ) Change subject: MGCP_Emulation: allow moving ep handling to another test component .. MGCP_Emulation: allow moving ep

Change in osmo-ttcn3-hacks[master]: gitignore sms.db

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25063 ) Change subject: gitignore sms.db .. gitignore sms.db When running osmo-msc in osmo-ttcn3-hacks/msc, it will leave behind an

Change in osmo-ttcn3-hacks[master]: msc: fix conn id in 'MGCP OK' msg (as_mgcp_ack_all_mdcx)

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25064 ) Change subject: msc: fix conn id in 'MGCP OK' msg (as_mgcp_ack_all_mdcx) .. msc: fix conn id in 'MGCP OK' msg

Change in osmo-ttcn3-hacks[master]: L3_Templates: add ts_ML3_MO_CC_DISC

2021-07-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25065 ) Change subject: L3_Templates: add ts_ML3_MO_CC_DISC .. L3_Templates: add ts_ML3_MO_CC_DISC To simulate an MS initiated call

Change in osmo-ccid-firmware[master]: add script to generate a inititial osmo-bankd slotconfig sorted by us...

2021-07-27 Thread roh
roh has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/25062 ) Change subject: add script to generate a inititial osmo-bankd slotconfig sorted by usb path .. add script to generate a

Change in osmo-pcu[master]: tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_DL_ASS

2021-07-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25061 ) Change subject: tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_DL_ASS .. tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_DL_ASS The flag

Change in osmo-pcu[master]: replace dl_ass_state with osmocom FSM

2021-07-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25060 ) Change subject: replace dl_ass_state with osmocom FSM .. replace dl_ass_state with osmocom FSM Related: OS#2709 Change-Id:

Change in osmo-pcu[master]: tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS

2021-07-27 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25059 to look at the new patch set (#2). Change subject: tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS ..

Change in osmo-pcu[master]: Replace ul_ass_state with osmocom FSM

2021-07-27 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25056 to look at the new patch set (#4). Change subject: Replace ul_ass_state with osmocom FSM .. Replace

Change in osmo-pcu[master]: tbf: Reimplement rlcmac_diag() and make it available from C

2021-07-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25058 ) Change subject: tbf: Reimplement rlcmac_diag() and make it available from C .. tbf: Reimplement rlcmac_diag() and make it available

Change in osmo-pcu[master]: tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS

2021-07-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25059 ) Change subject: tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS .. tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS The flag

Change in libosmocore[master]: utils: Fix c++ warn in OSMO_STRBUF_APPEND

2021-07-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/25057 ) Change subject: utils: Fix c++ warn in OSMO_STRBUF_APPEND .. utils: Fix c++ warn in OSMO_STRBUF_APPEND It's really a false

Change in osmo-ttcn3-hacks[master]: bsc: add TC_cm_reestablishment

2021-07-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021 ) Change subject: bsc: add TC_cm_reestablishment .. Patch Set 3: I'm personally fine with using strings here, I think it's a

Change in osmo-pcu[master]: Replace ul_ass_state with osmocom FSM

2021-07-27 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25056 to look at the new patch set (#3). Change subject: Replace ul_ass_state with osmocom FSM .. Replace

Change in osmo-ttcn3-hacks[master]: bsc: add Coord_PT to communicate between components

2021-07-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25019 ) Change subject: bsc: add Coord_PT to communicate between components .. Patch Set 3: > see my other comment on the use of

Change in osmo-ttcn3-hacks[master]: bsc: add TC_cm_reestablishment

2021-07-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25021 ) Change subject: bsc: add TC_cm_reestablishment .. Patch Set 3: but such enum has to be defined before definition of the

Change in osmo-pcu[master]: WIP: Replace ul_ass_state with osmocom FSM

2021-07-27 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25056 to look at the new patch set (#2). Change subject: WIP: Replace ul_ass_state with osmocom FSM .. WIP:

Change in libosmo-sccp[master]: m3ua: reject deregistration of static routing keys

2021-07-27 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/25024 ) Change subject: m3ua: reject deregistration of static routing keys .. m3ua: reject deregistration of static routing keys Make

Change in libosmo-sccp[master]: m3ua: reject deregistration of static routing keys

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/25024 ) Change subject: m3ua: reject deregistration of static routing keys .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: Get rid of tbf_dl:abort()

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25054 ) Change subject: Get rid of tbf_dl:abort() .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move rate_ctr free to tbf subclass destructor

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25053 ) Change subject: Move rate_ctr free to tbf subclass destructor .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move T3169 and T3195 to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25048 ) Change subject: Move T3169 and T3195 to tbf_fsm .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move RELEASING tbf_state transition to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25047 ) Change subject: Move RELEASING tbf_state transition to tbf_fsm .. Patch Set 2: Code-Review+1 (1 comment)

Change in osmo-pcu[master]: Move WAIT_RELEASE tbf_state transition to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25046 ) Change subject: Move WAIT_RELEASE tbf_state transition to tbf_fsm .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move FINISHED tbf_state transition to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25034 ) Change subject: Move FINISHED tbf_state transition to tbf_fsm .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: tests: tbf: Fix dl_tbf polled for data without being in FLOW state

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25045 ) Change subject: tests: tbf: Fix dl_tbf polled for data without being in FLOW state .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move FLOW tbf_state transition to tbf_fsm.

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25012 ) Change subject: Move FLOW tbf_state transition to tbf_fsm. .. Patch Set 5: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move NULL and ASSIGN tbf_state transition to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25011 ) Change subject: Move NULL and ASSIGN tbf_state transition to tbf_fsm .. Patch Set 5: Code-Review+1 Makes sense. Thanks for doing all

Change in libosmocore[master]: vty: clear screen with ^L

2021-07-27 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25013 ) Change subject: vty: clear screen with ^L .. vty: clear screen with ^L Use ANSI escape characters to clear the screen with ^L, like it

Change in libosmocore[master]: vty: clear screen with ^L

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25013 ) Change subject: vty: clear screen with ^L .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: mgcp_client: allow to reset endpoints on startup

2021-07-27 Thread dexter
Hello Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25008 to look at the new patch set (#6). Change subject: mgcp_client: allow to reset endpoints on startup

Change in osmo-ttcn3-hacks[master]: MGCP_Test: upgrade expected behavior for TC_dlcx_wildcarded

2021-07-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24821 ) Change subject: MGCP_Test: upgrade expected behavior for TC_dlcx_wildcarded .. Patch Set 5: Code-Review+1 -- To view, visit

Change in libosmo-sccp[master]: m3ua: reject deregistration of static routing keys

2021-07-27 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/25024 ) Change subject: m3ua: reject deregistration of static routing keys .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: WIP: Replace ul_ass_state with osmocom FSM

2021-07-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25056 ) Change subject: WIP: Replace ul_ass_state with osmocom FSM .. WIP: Replace ul_ass_state with osmocom FSM Change-Id:

Change in osmo-pcu[master]: Get rid of tbf_dl:abort()

2021-07-27 Thread pespin
Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25054 to look at the new patch set (#2). Change subject: Get rid of tbf_dl:abort() .. Get rid of

Change in osmo-pcu[master]: Move rate_ctr free to tbf subclass destructor

2021-07-27 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25053 to look at the new patch set (#2). Change subject: Move rate_ctr free to tbf subclass destructor ..

Change in osmo-pcu[master]: Move WAIT_RELEASE tbf_state transition to tbf_fsm

2021-07-27 Thread pespin
Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25046 to look at the new patch set (#2). Change subject: Move WAIT_RELEASE tbf_state transition to tbf_fsm

Change in osmo-pcu[master]: Move T3169 and T3195 to tbf_fsm

2021-07-27 Thread pespin
Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25048 to look at the new patch set (#2). Change subject: Move T3169 and T3195 to tbf_fsm .. Move

Change in osmo-pcu[master]: Move RELEASING tbf_state transition to tbf_fsm

2021-07-27 Thread pespin
Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25047 to look at the new patch set (#2). Change subject: Move RELEASING tbf_state transition to tbf_fsm

Change in osmo-pcu[master]: Move FINISHED tbf_state transition to tbf_fsm

2021-07-27 Thread pespin
Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25034 to look at the new patch set (#3). Change subject: Move FINISHED tbf_state transition to tbf_fsm

Change in osmo-pcu[master]: tests: tbf: Fix dl_tbf polled for data without being in FLOW state

2021-07-27 Thread pespin
Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25045 to look at the new patch set (#2). Change subject: tests: tbf: Fix dl_tbf polled for data without being in FLOW state

Change in osmo-pcu[master]: Move FLOW tbf_state transition to tbf_fsm.

2021-07-27 Thread pespin
Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25012 to look at the new patch set (#5). Change subject: Move FLOW tbf_state transition to tbf_fsm. ..

Change in osmo-pcu[master]: Move NULL and ASSIGN tbf_state transition to tbf_fsm

2021-07-27 Thread pespin
Hello osmith, Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/25011 to look at the new patch set (#5). Change subject: Move NULL and ASSIGN tbf_state transition to tbf_fsm

Change in libosmocore[master]: vty: clear screen with ^L

2021-07-27 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25013 ) Change subject: vty: clear screen with ^L .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Get rid of tbf_dl:abort()

2021-07-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25054 ) Change subject: Get rid of tbf_dl:abort() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/25054/1//COMMIT_MSG

Change in osmo-ttcn3-hacks[master]: bsc: improve error log for "RSL for unknown Dchan"

2021-07-27 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25023 ) Change subject: bsc: improve error log for "RSL for unknown Dchan" .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: Move rate_ctr free to tbf subclass destructor

2021-07-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25053 ) Change subject: Move rate_ctr free to tbf subclass destructor .. Patch Set 1: (1 comment)

Change in osmo-pcu[master]: tbf_free: Get rid of uneeded tbf_state transition

2021-07-27 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25055 ) Change subject: tbf_free: Get rid of uneeded tbf_state transition .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move rate_ctr free to tbf subclass destructor

2021-07-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25053 ) Change subject: Move rate_ctr free to tbf subclass destructor .. Patch Set 1: (1 comment)

Change in osmo-pcu[master]: Move RELEASING tbf_state transition to tbf_fsm

2021-07-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25047 ) Change subject: Move RELEASING tbf_state transition to tbf_fsm .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: MGCP_Test: upgrade expected behavior for TC_dlcx_wildcarded

2021-07-27 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24821 ) Change subject: MGCP_Test: upgrade expected behavior for TC_dlcx_wildcarded .. Patch Set 5: (1 comment)

Change in osmo-ttcn3-hacks[master]: MGCP_Test: upgrade expected behavior for TC_dlcx_wildcarded

2021-07-27 Thread dexter
Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24821 to look at the new patch set (#5). Change subject: MGCP_Test: upgrade expected behavior for TC_dlcx_wildcarded

Change in osmo-pcu[master]: Move NULL and ASSIGN tbf_state transition to tbf_fsm

2021-07-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25011 ) Change subject: Move NULL and ASSIGN tbf_state transition to tbf_fsm .. Patch Set 4: (2 comments)

Change in osmo-pcu[master]: tbf_free: Get rid of uneeded tbf_state transition

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25055 ) Change subject: tbf_free: Get rid of uneeded tbf_state transition .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Get rid of tbf_dl:abort()

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25054 ) Change subject: Get rid of tbf_dl:abort() .. Patch Set 1: Code-Review+1 (2 comments)

Change in osmo-pcu[master]: Move rate_ctr free to tbf subclass destructor

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25053 ) Change subject: Move rate_ctr free to tbf subclass destructor .. Patch Set 1: (1 comment)

Change in osmo-pcu[master]: Remove duplicate call to gprs_rlcmac_lost_rep

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25052 ) Change subject: Remove duplicate call to gprs_rlcmac_lost_rep .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Drop logging last mas report before freeing TBF

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25051 ) Change subject: Drop logging last mas report before freeing TBF .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Put dl_tbf::cleanup into destructor

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25050 ) Change subject: Put dl_tbf::cleanup into destructor .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Drop duplicate log line

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25049 ) Change subject: Drop duplicate log line .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move T3169 and T3195 to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25048 ) Change subject: Move T3169 and T3195 to tbf_fsm .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-mgw[master]: mgcp_client: allow to reset endpoints on startup

2021-07-27 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25008 ) Change subject: mgcp_client: allow to reset endpoints on startup .. Patch Set 5: (9 comments)

Change in osmo-mgw[master]: mgcp_client: allow to reset endpoints on startup

2021-07-27 Thread dexter
Hello Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25008 to look at the new patch set (#5). Change subject: mgcp_client: allow to reset endpoints on startup

Change in osmo-pcu[master]: Move RELEASING tbf_state transition to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25047 ) Change subject: Move RELEASING tbf_state transition to tbf_fsm .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-pcu[master]: Move WAIT_RELEASE tbf_state transition to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25046 ) Change subject: Move WAIT_RELEASE tbf_state transition to tbf_fsm .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-pcu[master]: Move FINISHED tbf_state transition to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25034 ) Change subject: Move FINISHED tbf_state transition to tbf_fsm .. Patch Set 2: Code-Review+1 (1 comment)

Change in osmo-pcu[master]: tests: tbf: Fix dl_tbf polled for data without being in FLOW state

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25045 ) Change subject: tests: tbf: Fix dl_tbf polled for data without being in FLOW state .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-pcu[master]: Move FLOW tbf_state transition to tbf_fsm.

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25012 ) Change subject: Move FLOW tbf_state transition to tbf_fsm. .. Patch Set 4: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Move NULL and ASSIGN tbf_state transition to tbf_fsm

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25011 ) Change subject: Move NULL and ASSIGN tbf_state transition to tbf_fsm .. Patch Set 4: (5 comments)

Change in docker-playground[master]: debian-stretch-titan: Wait for interface to be _up_ not just its exis...

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/22674 ) Change subject: debian-stretch-titan: Wait for interface to be _up_ not just its existance .. Patch Set 4: Code-Review+1

Change in docker-playground[master]: debian-stretch-titan: Wait for interface to be _up_ not just its exis...

2021-07-27 Thread daniel
daniel has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/22674 ) Change subject: debian-stretch-titan: Wait for interface to be _up_ not just its existance

Change in docker-playground[master]: debian-stretch-titan: Wait for interface to be _up_ not just its exis...

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/22674 ) Change subject: debian-stretch-titan: Wait for interface to be _up_ not just its existance .. Patch Set 3: Otherwise LGTM

Change in docker-playground[master]: debian-stretch-titan: Wait for interface to be _up_ not just its exis...

2021-07-27 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/22674 ) Change subject: debian-stretch-titan: Wait for interface to be _up_ not just its existance .. Patch Set 3: (1 comment)

Change in osmo-mgw[master]: mgcp_protocol: assert endp when it becomes mandatory

2021-07-27 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25026 ) Change subject: mgcp_protocol: assert endp when it becomes mandatory .. mgcp_protocol: assert endp when it becomes mandatory The logic when an

Change in osmo-mgw[master]: mgcp_protocol: assert endp when it becomes mandatory

2021-07-27 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25026 ) Change subject: mgcp_protocol: assert endp when it becomes mandatory .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: mgcp_ratectr: add stats items to monitor trunk usage

2021-07-27 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25041 ) Change subject: mgcp_ratectr: add stats items to monitor trunk usage .. Patch Set 1: (1 comment)

Change in osmo-mgw[master]: mgcp_ratectr: add stats items to monitor trunk usage

2021-07-27 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25041 ) Change subject: mgcp_ratectr: add stats items to monitor trunk usage .. Patch Set 1: (1 comment)

Change in osmo-ttcn3-hacks[master]: MGCP_Test: test DLCX request to non existant endpoint

2021-07-27 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24976 ) Change subject: MGCP_Test: test DLCX request to non existant endpoint .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MGCP_Test: upgrade expected behavior for TC_dlcx_wildcarded

2021-07-27 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24821 ) Change subject: MGCP_Test: upgrade expected behavior for TC_dlcx_wildcarded .. Patch Set 4: Code-Review+1 -- To view,

Change in osmo-mgw[master]: mgcp_protocol: assert endp when it becomes mandatory

2021-07-27 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25026 ) Change subject: mgcp_protocol: assert endp when it becomes mandatory .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: debug log: indicate change of primary lchan on a conn

2021-07-27 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25038 ) Change subject: debug log: indicate change of primary lchan on a conn .. debug log: indicate change of primary lchan on a conn Change-Id:

Change in libosmocore[master]: command: fix sourcecode formatting

2021-07-27 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25030 ) Change subject: command: fix sourcecode formatting .. Patch Set 1: Code-Review+2 -- To view, visit

  1   2   >